fix / review

matrix-sdk-android/src/main/java/im/vector/matrix/android/api/permalinks/MatrixLinkify.kt

@@ -17,9 +17,6 @@
 package im.vector.matrix.android.api.permalinks
 
 import android.text.Spannable
-import android.text.SpannableString
-import android.text.method.LinkMovementMethod
-import android.widget.TextView
 import im.vector.matrix.android.api.MatrixPatterns
 
 /**
@@ -57,36 +54,4 @@ object MatrixLinkify {
         return hasMatch
     }
     
-//    fun addLinks(textView: TextView, callback: MatrixPermalinkSpan.Callback?): Boolean {
-//        val text = textView.text
-//        if (text is Spannable) {
-//            if (addLinks(text, callback)) {
-//                addLinkMovementMethod(textView)
-//                return true
-//            }
-//
-//            return false
-//        } else {
-//            val spannableString = SpannableString.valueOf(text)
-//            if (addLinks(spannableString, callback)) {
-//                addLinkMovementMethod(textView)
-//                textView.text = spannableString
-//                return true
-//            }
-//            return false
-//        }
-//    }
-
-    /**
-     * Add linkMovementMethod on textview if not already set
-     * @param textView the textView on which the movementMethod is set
-     */
-    fun addLinkMovementMethod(textView: TextView) {
-        val movementMethod = textView.movementMethod
-        if (movementMethod == null || movementMethod !is LinkMovementMethod) {
-            if (textView.linksClickable) {
-                textView.movementMethod = LinkMovementMethod.getInstance()
-            }
-        }
-    }
 }

vector/src/main/java/im/vector/riotredesign/features/home/room/detail/timeline/item/MessageTextItem.kt

@@ -44,7 +44,7 @@ abstract class MessageTextItem : AbsMessageItem<MessageTextItem.Holder>() {
             false
         }
         it.setOnLinkLongClickListener { textView, url ->
-            //Long clicks are handled by parent, return false to block android to do something with url
+            //Long clicks are handled by parent, return true to block android to do something with url
             true
         }
     }