From 328f09072328131bf90d633661b6cc7fa4da6c87 Mon Sep 17 00:00:00 2001
From: Benoit Marty <benoit@matrix.org>
Date: Tue, 25 Jun 2019 15:08:33 +0200
Subject: [PATCH] Code quality: i18n

---
 vector/src/main/res/layout/item_pushgateway.xml      | 12 ++++++------
 vector/src/main/res/values/strings_riotX.xml         |  9 +++++++++
 .../res/xml/vector_settings_preferences_root.xml     |  8 +-------
 3 files changed, 16 insertions(+), 13 deletions(-)

diff --git a/vector/src/main/res/layout/item_pushgateway.xml b/vector/src/main/res/layout/item_pushgateway.xml
index e50a0015..c4a01be1 100644
--- a/vector/src/main/res/layout/item_pushgateway.xml
+++ b/vector/src/main/res/layout/item_pushgateway.xml
@@ -21,7 +21,7 @@
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
         android:layout_marginBottom="4dp"
-        android:text="app_id"
+        android:text="@string/push_gateway_item_app_id"
         android:textStyle="bold" />
 
 
@@ -38,7 +38,7 @@
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
         android:layout_marginBottom="4dp"
-        android:text="push_key:"
+        android:text="@string/push_gateway_item_push_key"
         android:textStyle="bold" />
 
 
@@ -55,7 +55,7 @@
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
         android:layout_marginBottom="4dp"
-        android:text="app_display_name"
+        android:text="@string/push_gateway_item_app_display_name"
         android:textStyle="bold" />
 
 
@@ -72,7 +72,7 @@
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
         android:layout_marginBottom="4dp"
-        android:text="device_name:"
+        android:text="@string/push_gateway_item_device_name"
         android:textStyle="bold" />
 
 
@@ -90,7 +90,7 @@
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
         android:layout_marginBottom="4dp"
-        android:text="Url:"
+        android:text="@string/push_gateway_item_url"
         android:textStyle="bold" />
 
     <TextView
@@ -106,7 +106,7 @@
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
         android:layout_marginBottom="4dp"
-        android:text="Format:"
+        android:text="@string/push_gateway_item_format"
         android:textStyle="bold" />
 
 
diff --git a/vector/src/main/res/values/strings_riotX.xml b/vector/src/main/res/values/strings_riotX.xml
index 987afcd8..7ff01489 100644
--- a/vector/src/main/res/values/strings_riotX.xml
+++ b/vector/src/main/res/values/strings_riotX.xml
@@ -21,4 +21,13 @@
     <string name="settings_push_rules_no_rules">No push rules defined</string>
     <string name="settings_push_gateway_no_pushers">No registered push gateways</string>
 
+    <string name="push_gateway_item_app_id">app_id:</string>
+    <string name="push_gateway_item_push_key">push_key:</string>
+    <string name="push_gateway_item_app_display_name">app_display_name:</string>
+    <string name="push_gateway_item_device_name">device_name:</string>
+    <string name="push_gateway_item_url">Url:</string>
+    <string name="push_gateway_item_format">Format:</string>
+
+    <string name="preference_root_legacy">Legacy</string>
+
 </resources>
\ No newline at end of file
diff --git a/vector/src/main/res/xml/vector_settings_preferences_root.xml b/vector/src/main/res/xml/vector_settings_preferences_root.xml
index 07729370..968aa68c 100644
--- a/vector/src/main/res/xml/vector_settings_preferences_root.xml
+++ b/vector/src/main/res/xml/vector_settings_preferences_root.xml
@@ -8,7 +8,6 @@
         android:title="@string/settings_general_title"
         app:fragment="com.example.SyncFragment" />
 
-
     <im.vector.riotredesign.core.preference.VectorPreference
         android:layout_width="match_parent"
         android:icon="@drawable/ic_flair"
@@ -22,33 +21,28 @@
         android:title="@string/settings_notifications"
         app:fragment="im.vector.riotredesign.features.settings.VectorSettingsNotificationPreferenceFragment" />
 
-
     <im.vector.riotredesign.core.preference.VectorPreference
         android:layout_width="match_parent"
         android:icon="@drawable/ic_sliders"
         android:title="@string/settings_preferences"
         app:fragment="com.example.SyncFragment" />
 
-
     <im.vector.riotredesign.core.preference.VectorPreference
         android:layout_width="match_parent"
         android:icon="@drawable/ic_lock"
         android:title="@string/settings_security_and_privacy"
         app:fragment="com.example.SyncFragment" />
 
-
     <im.vector.riotredesign.core.preference.VectorPreference
         android:layout_width="match_parent"
         android:icon="@drawable/ic_settings_lab"
         android:title="@string/room_settings_labs_pref_title"
         app:fragment="com.example.SyncFragment" />
 
-
     <im.vector.riotredesign.core.preference.VectorPreference
         android:layout_width="match_parent"
         android:icon="@drawable/ic_devices_info"
-        android:title="Legacy"
+        android:title="@string/preference_root_legacy"
         app:fragment="com.example.SyncFragment" />
 
-
 </androidx.preference.PreferenceScreen>
\ No newline at end of file