Merge pull request #241 from vector-im/feature/api16

min API 19 - tested
This commit is contained in:
Benoit Marty 2019-06-28 15:06:40 +02:00 committed by GitHub
commit 7ff2477a4f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
9 changed files with 12 additions and 10 deletions

View File

@ -33,7 +33,6 @@ android {
targetSdkVersion 28 targetSdkVersion 28
versionCode 1 versionCode 1
versionName "0.0.1" versionName "0.0.1"
multiDexEnabled true
testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner" testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"


buildConfigField "String", "GIT_SDK_REVISION", "\"${gitRevision()}\"" buildConfigField "String", "GIT_SDK_REVISION", "\"${gitRevision()}\""

View File

@ -58,7 +58,9 @@ android {
compileSdkVersion 28 compileSdkVersion 28
defaultConfig { defaultConfig {
applicationId "im.vector.riotredesign" applicationId "im.vector.riotredesign"
minSdkVersion 16 // Set to API 19 because motionLayout is min API 18.
// In the future we may consider using an alternative of MotionLayout to support API 16. But for security reason, maybe not.
minSdkVersion 19
targetSdkVersion 28 targetSdkVersion 28
multiDexEnabled true multiDexEnabled true
versionCode generateVersionCodeFromTimestamp() versionCode generateVersionCodeFromTimestamp()

View File

@ -22,7 +22,8 @@


<!-- RTL --> <!-- RTL -->
<issue id="RtlEnabled" severity="error" /> <issue id="RtlEnabled" severity="error" />
<issue id="RtlHardcoded" severity="error" /> <!-- Now with min API set to 19, we do not need Left and Right attribute, Start and End is enougth. For the moment, just reduce the severity -->
<issue id="RtlHardcoded" severity="warning" />
<issue id="RtlSymmetry" severity="error" /> <issue id="RtlSymmetry" severity="error" />


<!-- Code --> <!-- Code -->

View File

@ -16,10 +16,10 @@


package im.vector.riotredesign.features.media package im.vector.riotredesign.features.media


import android.media.ExifInterface
import android.net.Uri import android.net.Uri
import android.os.Parcelable import android.os.Parcelable
import android.widget.ImageView import android.widget.ImageView
import androidx.exifinterface.media.ExifInterface
import com.bumptech.glide.load.resource.bitmap.RoundedCorners import com.bumptech.glide.load.resource.bitmap.RoundedCorners
import com.github.piasy.biv.view.BigImageView import com.github.piasy.biv.view.BigImageView
import im.vector.matrix.android.api.Matrix import im.vector.matrix.android.api.Matrix

View File

@ -1,6 +1,6 @@
<?xml version="1.0" encoding="utf-8"?> <?xml version="1.0" encoding="utf-8"?>
<set xmlns:android="http://schemas.android.com/apk/res/android"> <set xmlns:android="http://schemas.android.com/apk/res/android">
<scale xmlns:android="http://schemas.android.com/apk/res/android" <scale
android:duration="1500" android:duration="1500"
android:fromXScale="1" android:fromXScale="1"
android:fromYScale="1" android:fromYScale="1"

View File

@ -90,7 +90,7 @@
android:layout_marginRight="16dp" android:layout_marginRight="16dp"
android:scaleType="fitCenter" android:scaleType="fitCenter"
android:src="@drawable/backup_keys" android:src="@drawable/backup_keys"
android:tint="?android:attr/textColorTertiary" /> android:tint="?riotx_text_primary" />


<TextView <TextView
android:layout_width="wrap_content" android:layout_width="wrap_content"
@ -125,7 +125,7 @@
android:layout_marginRight="16dp" android:layout_marginRight="16dp"
android:scaleType="fitCenter" android:scaleType="fitCenter"
android:src="@drawable/backup_keys" android:src="@drawable/backup_keys"
android:tint="?android:attr/textColorTertiary" /> android:tint="?riotx_text_primary" />


<TextView <TextView
android:layout_width="wrap_content" android:layout_width="wrap_content"

View File

@ -75,7 +75,7 @@
android:layout_marginTop="8dp" android:layout_marginTop="8dp"
android:layout_marginBottom="38dp" android:layout_marginBottom="38dp"
android:alpha="0" android:alpha="0"
android:tint="?android:attr/textColorTertiary" android:tint="?riotx_text_primary"
app:layout_constraintEnd_toStartOf="parent" app:layout_constraintEnd_toStartOf="parent"
app:layout_constraintTop_toBottomOf="parent" app:layout_constraintTop_toBottomOf="parent"
tools:ignore="MissingConstraints" tools:ignore="MissingConstraints"

View File

@ -80,7 +80,7 @@
android:layout_marginTop="6dp" android:layout_marginTop="6dp"
android:layout_marginBottom="38dp" android:layout_marginBottom="38dp"
android:alpha="1" android:alpha="1"
android:tint="?android:attr/textColorTertiary" android:tint="?riotx_text_primary"
android:visibility="visible" android:visibility="visible"
app:layout_constraintEnd_toEndOf="@id/composer_related_message_avatar_view" app:layout_constraintEnd_toEndOf="@id/composer_related_message_avatar_view"
app:layout_constraintStart_toStartOf="@id/composer_related_message_avatar_view" app:layout_constraintStart_toStartOf="@id/composer_related_message_avatar_view"

View File

@ -63,7 +63,7 @@
android:id="@+id/composer_related_message_action_image" android:id="@+id/composer_related_message_action_image"
android:layout_width="0dp" android:layout_width="0dp"
android:layout_height="0dp" android:layout_height="0dp"
android:tint="?android:attr/textColorTertiary" android:tint="?riotx_text_primary"
tools:ignore="MissingConstraints" /> tools:ignore="MissingConstraints" />


<ImageButton <ImageButton