From e3983deacce4f0cdfadf175b2b26bcc2a2998ded Mon Sep 17 00:00:00 2001 From: Benoit Marty Date: Tue, 4 Jun 2019 11:02:40 +0200 Subject: [PATCH] dispose uiDisposable in onDestroy() --- .../im/vector/riotredesign/core/platform/VectorBaseActivity.kt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/vector/src/main/java/im/vector/riotredesign/core/platform/VectorBaseActivity.kt b/vector/src/main/java/im/vector/riotredesign/core/platform/VectorBaseActivity.kt index 3ae8f3a8..c940d70b 100644 --- a/vector/src/main/java/im/vector/riotredesign/core/platform/VectorBaseActivity.kt +++ b/vector/src/main/java/im/vector/riotredesign/core/platform/VectorBaseActivity.kt @@ -93,7 +93,6 @@ abstract class VectorBaseActivity : BaseMvRxActivity() { } protected fun Disposable.disposeOnDestroy(): Disposable { - // TODO Ganfra: never disposed... uiDisposables.add(this) return this } @@ -133,6 +132,8 @@ abstract class VectorBaseActivity : BaseMvRxActivity() { unBinder?.unbind() unBinder = null + + uiDisposables.dispose() } override fun onResume() {