GitHub-Mirror/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos synced 2025-10-06 00:12:51 +02:00
Code Issues Packages Projects Releases Wiki Activity

[NTOS:LPC] Fix input parameter for ProbeAndCaptureUnicodeString (#5815)

Browse Source 
Addendum to commit b3c55b9e6 (PR #4399).

Passing &CapturedObjectName as pointer to be probed and captured would
fail if e.g. PreviousMode == UserMode, since that pointer is always in
kernel space. Instead, pass the original user-mode pointer.

Bug caught by Timo Kreuzer ;)
This commit is contained in:
Hermès Bélusca-Maïto
2023-10-22 21:57:59 +02:00
parent 5b54477d47
commit 501c2bdd63
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
ntoskrnl/lpc/create.c
View File

@@ -83,8 +83,9 @@ LpcpCreatePort(OUT PHANDLE PortHandle,
} }
else else
{ {
if (ObjectAttributes->ObjectName) ObjectName = ObjectAttributes->ObjectName;
CapturedObjectName = *(ObjectAttributes->ObjectName); if (ObjectName)
CapturedObjectName = *ObjectName;
} }
/* Normalize the buffer pointer in case we don't have /* Normalize the buffer pointer in case we don't have
@@ -96,7 +97,7 @@ LpcpCreatePort(OUT PHANDLE PortHandle,
/* Capture the port name for DPRINT only - ObCreateObject does its /* Capture the port name for DPRINT only - ObCreateObject does its
* own capture. As it is used only for debugging, ignore any failure; * own capture. As it is used only for debugging, ignore any failure;
* the string is zeroed out in such case. */ * the string is zeroed out in such case. */
ProbeAndCaptureUnicodeString(&CapturedPortName, PreviousMode, &CapturedObjectName); ProbeAndCaptureUnicodeString(&CapturedPortName, PreviousMode, ObjectName);
LPCTRACE(LPC_CREATE_DEBUG, "Name: %wZ\n", &CapturedPortName); LPCTRACE(LPC_CREATE_DEBUG, "Name: %wZ\n", &CapturedPortName);
ReleaseCapturedUnicodeString(&CapturedPortName, PreviousMode); ReleaseCapturedUnicodeString(&CapturedPortName, PreviousMode);
#endif #endif