* Remove one time inclusions from the main header and put them back where they belong.
* Improve header inclusions.
CORE-7716
svn path=/trunk/; revision=61882
* Properly name the main header.
* Remove one time inclusions from the main header and put them back where they belong.
CORE-7716
svn path=/trunk/; revision=61881
* Do not include debug.h from within the main header.
* Improve the GUIDs situation.
* Remove one time inclusions from the main header and put them back where they belong.
CORE-7716
svn path=/trunk/; revision=61880
* Do not include debug.h from within the main header.
* Improve the GUIDs situation.
* Remove one time inclusions from the main header and put them back where they belong.
CORE-7716
svn path=/trunk/; revision=61879
* Do not include debug.h from within the main header.
* Improve the GUIDs situation.
* Remove one time inclusions from the main header and put them back where they belong.
CORE-7716
svn path=/trunk/; revision=61878
- Implement FsRtlRegisterFileSystemFilterCallbacks
- Fix returned ResultLength value in NtQuerySystemInformation
- Create \FileSystems\Filters folder in IopCreateRootDirectories, used by Windows fltmgr
svn path=/trunk/; revision=61874
Add implementation of RtlFindLastBackwardRunClear from amd64 branch, thanks to Alex for noticing that it has never been merged.
svn path=/trunk/; revision=61872
* Remove one time inclusions from the main header and put them back where they belong.
* Improve header inclusions.
CORE-7716
svn path=/trunk/; revision=61870
* Do not include debug.h from within the main header.
* Improve the GUIDs situation.
* Remove one time inclusions from the main header and put them back where they belong.
* Improve header inclusions.
CORE-7716
svn path=/trunk/; revision=61855
* Do not include debug.h from within the main header.
* Improve the GUIDs situation.
* Remove one time inclusions from the main header and put them back where they belong.
* Improve header inclusions.
CORE-7716
svn path=/trunk/; revision=61854
* Remove one time inclusions from the main header and put them back where they belong.
* Improve header inclusions.
CORE-7716
svn path=/trunk/; revision=61853
* Remove one time inclusions from the main header and put them back where they belong.
* Improve header inclusions.
CORE-7716
svn path=/trunk/; revision=61852
- Fix a typo in KsecQueryVolumeInformation, noticed by Michael Fritscher
- Implement KsecGatherEntropyData, which will be used in generation of cryptographically secure random numbers according to FIPS 186-2. Based on information from http://blogs.msdn.com/b/michael_howard/archive/2005/01/14/353379.aspx
svn path=/trunk/; revision=61842
* Remove one time inclusions from the main header and put them back where they belong.
* Improve header inclusions.
CORE-7716
svn path=/trunk/; revision=61841
* Remove one time inclusions from the main header and put them back where they belong.
* Improve header inclusions.
CORE-7716
svn path=/trunk/; revision=61837
rapps: (for database) Many Improvements and Many Fixes
CORE-7710 #resolve #comment Fixed a few things like missing sizes for your edited ff2, ff3 and ff3.6 files. Thx for your help.
Added universal download links for sf.net linked files.
svn path=/trunk/; revision=61833
- Replace URLDownloadToFileW download routine by InternetOpenW, InternetOpenUrlW, InternetReadFile download routine. This makes it possible to set the user agent which allows us to use http://download.sourceforge.net URLs and not needing any hard coded mirrors anymore. (Thx goes to Usurp for that idea.)
- Replace CreateProcessW by ShellExecute. This reenables the question for elevated rights in Windows and allows RApps to open any file format the shell knows about.
Big thx goes out to AmineKhaldi, Christoph_vW, gigaherz and ThFabba for helping a rusted Java coder to get things in a resonable shape. ^^
svn path=/trunk/; revision=61832
* Remove one time inclusions from the main header and put them back where they belong.
* Improve header inclusions.
CORE-7716
svn path=/trunk/; revision=61827
* Remove one time inclusions from the main header and put them back where they belong.
* Improve header inclusions.
CORE-7716
svn path=/trunk/; revision=61825
* Remove one time inclusions from the main header and put them back where they belong.
* Improve header inclusions.
CORE-7716
svn path=/trunk/; revision=61822
* Remove one time inclusions from the main header and put them back where they belong.
* Improve header inclusions.
CORE-7716
svn path=/trunk/; revision=61820
* Remove one time inclusions from the main header and put them back where they belong.
* Improve header inclusions.
CORE-7716
svn path=/trunk/; revision=61819
* Move some inclusions to the main header.
* Set the default debugging channel globally through the main header.
* Improve the GUIDs situation.
* Improve header inclusions.
CORE-7716
svn path=/trunk/; revision=61817
* Create a main header and move some inclusions to it.
* Set the default debugging channel globally through the main header.
* Improve the GUIDs situation.
CORE-7716
svn path=/trunk/; revision=61814
* Remove one time inclusions from the main header and put them back where they belong.
* Improve header inclusions.
CORE-7716
svn path=/trunk/; revision=61813
* Remove one time inclusions from the main header and put them back where they belong.
* Improve header inclusions.
CORE-7716
svn path=/trunk/; revision=61812
* Remove one time inclusions from the main header and put them back where they belong.
* Improve header inclusions.
CORE-7716
svn path=/trunk/; revision=61806
Add a library for common encryption/hashing algorithms. Currently implements MD4, MD5, SHA1, RC4 (all taken from advapi32 with minor modifications) and AES (taken from OpenWrt Linux).
The library is currently used by advapi32 only, but ksecdd will make use of it later as well.
svn path=/trunk/; revision=61805
* Remove one time inclusions from the main header and put them back where they belong.
* Improve header inclusions.
CORE-7716
svn path=/trunk/; revision=61803
* Remove one time inclusions from the main header and put them back where they belong.
* Move some inclusions to the main header.
CORE-7716
svn path=/trunk/; revision=61793
* Move some inclusions to the main header.
* Extract the resource related definitions into resource.h and include it in both the main header and the resource file.
* Remove inclusions and definitions that already exist in the main header/resource file.
CORE-7716
svn path=/trunk/; revision=61790
* Remove one time inclusions from the main header and put them back where they belong.
* Improve header inclusions.
CORE-7716
svn path=/trunk/; revision=61789
- Increase Hive dirty counter when marking cells as dirty
- Clear the counter accordingly when flushing the hive
[NTOSKRNL]
- Lazy flush the registry when unlocking it
- Correctly update hive lazy flush count when actully flushing it
- Respect the force flush parameter
CORE-6762 #comment Should be fixed with r61783, let's see what testbot says.
svn path=/trunk/; revision=61783
* Remove one time inclusions from the main header and put them back where they belong.
* Improve header inclusions.
CORE-7716
svn path=/trunk/; revision=61772
* Remove one time inclusions from the main header and put them back where they belong.
* Improve header inclusions.
* Improve the GUIDs situation.
CORE-7716
svn path=/trunk/; revision=61771
* Remove one time inclusions from the main header and put them back where they belong.
* Improve header inclusions.
CORE-7716
svn path=/trunk/; revision=61770
* Remove one time winternl.h inclusion from the main header and put it back where it belongs.
* Improve header inclusions.
CORE-7716
svn path=/trunk/; revision=61769
* Remove one time inclusions from the main header and put them back where they belong.
* Improve header inclusions.
CORE-7716
svn path=/trunk/; revision=61767
* Remove one time mshtmhst.h inclusion from the main header and put it back where it belongs.
* Move resource.h inclusion to the main header.
* Remove redundant winnls.h inclusion.
CORE-7716
svn path=/trunk/; revision=61766
* Remove one time inclusions from the main header and put them back where they belong.
* Improve header inclusions.
* Improve the GUIDs situation.
CORE-7716
svn path=/trunk/; revision=61765
* Remove one time inclusions from the main header and put them back where they belong.
* Improve header inclusions.
* Improve the GUIDs situation.
CORE-7716
svn path=/trunk/; revision=61764
* Remove one time inclusions from the main header and put them back where they belong.
* Improve header inclusions.
CORE-7716
svn path=/trunk/; revision=61763
* Remove one time inclusions from the main header and put them back where they belong.
* Cleanup the main header.
CORE-7716
svn path=/trunk/; revision=61761
* Remove one time inclusions from the main header and put them back where they belong.
* Improve header inclusions.
CORE-7716
svn path=/trunk/; revision=61760
Implement IRP_MJ_DEVICE_CONTROL, handle ioctl 0x390004, used by MS advapi32 to generate random numbers. Even though it is not very crypto-safe, for now we just use RtlRandomEx, "improved" by xoring the seed with some data from KeTickCount (no idea whether that does any good)
svn path=/trunk/; revision=61759
- Implement NtPrivilegedServiceAuditAlarm, the internal function SepAdtPrivilegedServiceAuditAlarm is not implemented yet.
- Stubplement SepAccessCheckAndAuditAlarm and make NtAccessCheckAndAuditAlarm, NtAccessCheckByTypeAndAuditAlarm, NtAccessCheckByTypeResultListAndAuditAlarm and NtAccessCheckByTypeResultListAndAuditAlarmByHandle (love that name) wrappers around it.
svn path=/trunk/; revision=61753
Implement TokenSessionReference case in NtSetInformationToken, also make sure not to leak a reference on the token in case of an exception.
svn path=/trunk/; revision=61752
* Move some inclusions to the main header.
* Remove inclusions and definitions that already exist in the main header.
* Improve header inclusions.
CORE-7716
svn path=/trunk/; revision=61749
* Remove one time inclusions from the main header and put them back where they belong.
* Improve header inclusions.
CORE-7716
svn path=/trunk/; revision=61746
* Move some inclusions to the main header.
* Remove inclusions and definitions that already exist in the main header/resource file.
* Improve header inclusions.
CORE-7716
svn path=/trunk/; revision=61745
* Remove one time inclusions from the main header and put them back where they belong.
* Improve header inclusions.
CORE-7716
svn path=/trunk/; revision=61744
* Remove one time inclusions from the main header and put them back where they belong.
* Set the default debugging channel globally through the main header.
* Improve the main header.
CORE-7716
svn path=/trunk/; revision=61743
Save the password in the gina-context after successful logon and use it to check the password when unlocking the computer.
svn path=/trunk/; revision=61741
* Massive update of Romanian resources. Brought to you by Ștefan Fulea.
CORE-7778 #resolve #comment Committed in r61740. Thanks !
svn path=/trunk/; revision=61740
* Maintenance of Romanian resources. Brought to you by Ștefan Fulea.
CORE-7761 #resolve #comment Committed in r61739. Cheers ;)
svn path=/trunk/; revision=61739
* Remove one time inclusions from the main header and put them back where they belong.
* Cleanup the main header.
CORE-7716
svn path=/trunk/; revision=61736
* Remove one time inclusions from the main header and put them back where they belong.
* Cleanup the main header.
CORE-7716
svn path=/trunk/; revision=61734
* Remove one time inclusions from the main header and put them back where they belong.
* Do not include debug.h into the main header.
CORE-7716
svn path=/trunk/; revision=61732
* Remove one time inclusions from the main header and put them back where they belong.
* Cleanup the main header.
CORE-7716
svn path=/trunk/; revision=61731
* Remove one time inclusions from the main header and put them back where they belong.
* Cleanup the main header.
CORE-7716
svn path=/trunk/; revision=61728
* Remove one time inclusions from the main header and put them back where they belong.
* Cleanup the main header.
CORE-7716
svn path=/trunk/; revision=61727
* Remove one time inclusions from the main header and put them back where they belong.
* Improve header inclusions.
CORE-7716
svn path=/trunk/; revision=61726
* Remove one time inclusions from the main header and put them back where they belong.
* Improve header inclusions.
CORE-7716
svn path=/trunk/; revision=61725
* Create a main header and move some inclusions to it.
* Set the default debugging channel globally through the main header.
CORE-7716
svn path=/trunk/; revision=61724
* Move some inclusions to the main header.
* Set the default debugging channel globally through the main header.
* Remove inclusions and definitions that already exist in the main header.
* Improve header inclusions.
* Improve the GUIDs situation.
CORE-7716
svn path=/trunk/; revision=61723
* Move some inclusions to the main header.
* Set the default debugging channel globally through the main header.
* Remove inclusions and definitions that already exist in the main header.
* Improve header inclusions.
* Improve the GUIDs situation.
CORE-7716
svn path=/trunk/; revision=61722
* Move some inclusions to the main header.
* Set the default debugging channel globally through the main header.
* Remove inclusions and definitions that already exist in the main header.
* Improve header inclusions.
* Improve the GUIDs situation.
CORE-7716
svn path=/trunk/; revision=61721
* Move some inclusions to the main header.
* Set the default debugging channel globally through the main header.
* Remove inclusions and definitions that already exist in the main header.
* Improve header inclusions.
CORE-7716
svn path=/trunk/; revision=61720
* Remove one time inclusions from the main header and put them back where they belong.
* Improve header inclusions.
CORE-7716
svn path=/trunk/; revision=61719
* Move some inclusions to the main header.
* Set the default debugging channel globally through the main header.
* Remove inclusions and definitions that already exist in the main header.
* Improve header inclusions.
CORE-7716
svn path=/trunk/; revision=61718
* Remove one time inclusions from the main header and put them back where they belong.
* Improve header inclusions.
CORE-7716
svn path=/trunk/; revision=61717
* Move some inclusions to the main header.
* Remove inclusions and definitions that already exist in the main header.
* Improve header inclusions.
CORE-7716
svn path=/trunk/; revision=61715
Add Mpxplay to Application manager by Alex (jedi-to-be)
CORE-7290 #resolve #comment Committed and slightly fixed DL link and comment. Thx for help!
svn path=/trunk/; revision=61706
* Move some inclusions to the main header.
* Set the default debugging channel globally through the main header.
* Remove inclusions and definitions that already exist in the main header.
CORE-7716
svn path=/trunk/; revision=61702
* Remove one time inclusions from the main header and put them back where they belong.
* Cleanup the main header.
CORE-7716
svn path=/trunk/; revision=61699
* Remove one time inclusions from the main header and put them back where they belong.
* Improve the GUIDs situation.
* Improve the main header.
CORE-7716
svn path=/trunk/; revision=61697
* Remove one time inclusions from the main header and put them back where they belong.
* Cleanup the main header.
CORE-7716
svn path=/trunk/; revision=61696
* Remove one time shellapi.h inclusion from the main header and put it back where it belongs.
* Do not include debug.h into the main header.
CORE-7716
svn path=/trunk/; revision=61695
* Remove one time inclusions from the main header and put them back where they belong.
* Remove redundant resource.h inclusion.
CORE-7716
svn path=/trunk/; revision=61694
* Move some inclusions to the main header.
* Extract the resource related definitions into resource.h and include it in both the main header and the resource file.
* Set the default debugging channel globally through the main header.
* Remove inclusions and definitions that already exist in the main header/resource file.
CORE-7716
svn path=/trunk/; revision=61693
* Remove one time inclusions from the main header and put them back where they belong.
* Cleanup the main header.
CORE-7716
svn path=/trunk/; revision=61692
* Move some inclusions to the main header.
* Set the default debugging channel globally through the main header.
* Remove inclusions and definitions that already exist in the main header.
CORE-7716
svn path=/trunk/; revision=61691
- Display the lock message on the lock and unlock dialogs.
- Implement the DontDisplayLastUserName and ShutdownWithoutLogon options.
- Read the DefaultUserName and DefaultDomain and display the user name on the logon dialog unless the DontDisplayLastUserName option is enabled.
svn path=/trunk/; revision=61681
Improve english resource file by Lee Schroeder
Added that change to all other languages, too. (Where still applicable)
CORE-7479 #resolve
svn path=/trunk/; revision=61677
Use the administrator name, domain and password for the logon hack and store them in the registry for later use by winlogon if the AutoAdminLogon option is enabled.
CORE-7722 #resolve
svn path=/trunk/; revision=61676
- Allow double-clicking to install programs. Based on patch by Edijs Kolesnikovičs and Yuntian Zhang.
CORE-4357 #resolve #comment Thanks guys, this was a major annoyance.
svn path=/trunk/; revision=61675
- Implement search feature. Based on patch by David Quintana.
CORE-7268 #resolve
CORE-7786 #comment rapps contains a hack to load StrStrIW using GetProcAddress. That should be removed once this issue is fixed.
svn path=/trunk/; revision=61673
- Store settings in HKEY_CURRENT_USER
- Correctly show the main window if UpdateAtStart is enabled
- Improve error handling
svn path=/trunk/; revision=61672
- Fix AcpiRegQueryValue, to allow querying the required buffer size only (which was already used, but just didn't work)
- Fix GetProcessorInformation. Previously the function failed at the start, but no one checked the return value. Check return values of called functions, and properly NULL-Terminate the components of the REG_MULTI_SZ style value that ProcessorHardwareIds is supposed to be.
- Fix NULL-termination in Bus_PDO_QueryDeviceId as well as clean up the code, fix indentation and broken if/else cases
- Add some ASSERTs and comments
svn path=/trunk/; revision=61666
Fix the s*** out of SepCreateToken and NtCreateToken: respect optional arguments, do not access usermode memory without SEH, instead properly capture them, don't allocate 0 bytes from the pool, better argument verification. The function isn't perfect yet, but better and more secure.
svn path=/trunk/; revision=61662
Lookup new Ldr entries in IopInitializeBuiltinDriver (we used the old ones from the loader block, that are not valid anymore after the drivers have been relocated!)
svn path=/trunk/; revision=61659
- Greatly reduce needless repaints in the non client area but remembering the last hittest of the mouse events to redraw it only when it is needed
- Do not reset the theme region every time we move a window, also make sure we try to set a theme region only when it is needed
- Do not use OpenThemeData but use MSSTYLES_OpenThemeClass directly
- Do not reload the active theme every time we get a WM_THEMECHANGED message, make sure to see if the active theme was already loaded before trying to load it again
- See CORE-7775
svn path=/trunk/; revision=61654
- Fix memory/handle leak in failure case of GetServices. Patch by Christoph von Wittich
- Fix service handle failure checks
- Remove unnecessary casts
svn path=/trunk/; revision=61653
- Output debug information before ASSERTing. CORE-7671
- FORCEINLINE belongs before the return type (-Wold-style-declaration)
svn path=/trunk/; revision=61646
- When deleting a directory entry, also remove it from the hash table. This prevents use after free in the case of a hash collision
CORE-7774 #resolve
svn path=/trunk/; revision=61643
Three patches for mplay32 by Ricardo Hanke. Some more or less heavy tabs->spaces fixing and removing of spaces which are too much by myself
CORE-7590 #resolve
CORE-7594 #resolve
CORE-7613 #resolve
svn path=/trunk/; revision=61640
- Add the Lautus visual style by Pisarz. Based on a patch by Christoph von Wittich.
The resulting windows/linux themes have been checked on Windows XP.
svn path=/trunk/; revision=61635
Make the LSAP_POLICY_AUDIT_EVENTS_DATA structure compatible to the one used in Windows, so that the registry data is compatible between Windows and ReactOS lsasrv. Windows does not actually use dynamically sized structures, but always stores a full structure and the AuditEventsCount is AFTER the AuditEvents array, so that it is in fact pretty pointless. But that's how it works.
svn path=/trunk/; revision=61626
Fix a nasty bug in RtlQueryRegistryValues, that caused memory corruption when the the key name or data had the "wrong" length.
svn path=/trunk/; revision=61624
- Implement the STATE_LOCKED and STATE_LOCKED_SAS states and their transitions.
[MSGINA]
- Disable the logoff button of the security dialog if the AutoAdminLogon option is enabled.
- Implement the unlock computer dialog. The user name and password check is not implemented yet. Just press OK to unlock the computer.
- Simulate an SAS when the DisableCAD option is enabled and the computer is locked. The unlock dialog appears immediately.
svn path=/trunk/; revision=61622
Pay back the US National Debt.
... well not entirely, but at least remove the "hack similar in magnitude to the US's National Debt"! As a nice side effect we can now load Windows 2003 hive files.
svn path=/trunk/; revision=61621
* Remove one time inclusions from the main header and put them back where they belong.
* Cleanup the main header.
CORE-7716
svn path=/trunk/; revision=61618
* Remove one time inclusions from the main header and put them back where they belong.
* Improve the main header.
CORE-7716
svn path=/trunk/; revision=61616
* Remove one time inclusions from the main header and put them back where they belong.
* Improve the main header.
CORE-7716
svn path=/trunk/; revision=61614
* Remove one time inclusions from the main header and put them back where they belong.
* Cleanup the main header.
CORE-7716
svn path=/trunk/; revision=61612
* Remove one time inclusions from the main header and put them back where they belong.
* Cleanup the main header.
CORE-7716
svn path=/trunk/; revision=61611
* Remove one time shlwapi.h inclusion from the main header and put them back where it belongs.
* Cleanup the main header.
CORE-7716
svn path=/trunk/; revision=61610
* Remove one time inclusions from the main header and put them back where they belong.
* Improve the GUIDs situation.
* Improve the main header.
CORE-7716
svn path=/trunk/; revision=61609
* Remove one time inclusions from the main header and put them back where they belong.
* Do not include the whole NDK.
* Improve the main header.
CORE-7716
svn path=/trunk/; revision=61606
* Move some inclusions to the main header.
* Remove inclusions and definitions that already exist in the main header.
* Remove one time winsvc.h inclusion from the main header and put them back where it belongs.
CORE-7716
svn path=/trunk/; revision=61605
* Remove one time inclusions from the main header and put them back where they belong.
* Improve the main header.
CORE-7716
svn path=/trunk/; revision=61603
* Move some inclusions to the main header.
* Set the default debugging channel globally through the main header.
* Remove inclusions and definitions that already exist in the main header/resource file.
CORE-7716
svn path=/trunk/; revision=61602
* Remove one time inclusions from the main header and put them back where they belong.
* Cleanup the main header.
CORE-7716
svn path=/trunk/; revision=61601
* Remove one time inclusions from the main header and put them back where they belong.
* Cleanup the main header.
CORE-7716
svn path=/trunk/; revision=61599
Completely rewrite the registry code.
The old code was first loading the system hive and parsing it, duplicating each and every key and value into a custom freeldr specific registry format and used the latter to access the data. This was extremely slow when larger hive files (the one from a normal win 2003 installation is 2.5 MB vs 250kb in reactos) were imported. The new code uses the hive data directly. It's less code, faster and uses much less memory.
In the same move, refactor some mkhive code and move it into cmlib to be shared with freeldr.
svn path=/trunk/; revision=61595
Move the locale page between the acknowledgments and the owner/computer name pages.
Arch, you do not want to type your Russian password with an English layout, do you ?
svn path=/trunk/; revision=61593
- Change state to STATE_LOGGED_ON_SAS while the security dialog is open.
- Ignore an SAS while winlogon is already in an SAS state.
[MSGINA]
- Read AutoAdminLogon and DisableCAD settings when msgina is initialized.
- LoggedOutWindowProc: Disable the Cancel button on the logon dialog if the DisableCAD option has been enabled.
- GUILoggedOnSAS: Fix misuse of result variable which caused some really strange effects.
svn path=/trunk/; revision=61592
- WlxDisplaySASNotice: Do not try an auto admin logon here. Check for auto admin logon instead and let WlxLoggedOutSAS do the logon stuff.
[WINLOGON]
- Avoid posting two SAS notification messages when winlogon is started up.
svn path=/trunk/; revision=61587
- Implement a global dialog tracking list.
- Close the SAS notice dialog before the logon dialog is created and create a new SAS notice dialog when the user cancels the logon dialog. This prevents the creation of multiple SAS notice dialogs below the logon dialog.
svn path=/trunk/; revision=61585
Halfplement NtCloseObjectAuditAlarm (the internal function SepAdtCloseObjectAuditAlarm is not implemented yet, but the function now returns a proper status code)
svn path=/trunk/; revision=61584
* Do not mix ReactOS and Wine style debugging.
[SPEC2DEF]
* Use DbgPrint instead of DPRINT1 for the stub functions.
[ACTIVEDS]
* Cleanup the stubs file.
CORE-7716
svn path=/trunk/; revision=61578
- Don't be so nitpicky about display frequency when setting up display driver.
Fixes vmare letter stamp behaviour after graphics driver installation
svn path=/trunk/; revision=61577
* Add support for the CF_HDROP format in the shell drop targets.
* Implement IAsyncOperation for the shell data object implementation, which is how one checks to see if it's safe to perform a background copy.
* Actually check for the IAsyncOperation interface in the drop targets.
* 7-zip and WinRAR are now mostly working correctly in terms of drag and drop.
* Brought to you by Huw Campbell.
CORE-3760
svn path=/trunk/; revision=61576
- Add some debug print lidting available modes from a device driver.
- Take this as an occasion to use the much underrated win32k debug channels
Recompiling? You're so 2013!
svn path=/trunk/; revision=61575
- Update CM_KEY_CONTROL_BLOCK to match win2k3 SP2 symbols
- Implement KeyCachedInformation and KeyFlagsInformation cases in CmQueryKey
svn path=/trunk/; revision=61572
- Add missing _KEY_USER_FLAGS_INFORMATION
- Fix some FSCTL_* constants, add Win7/8 ones
- Sync DDK/XDK (just a reminder, you are supposed to fix XDK headers and simply regenerate the DDK headers from them)
svn path=/trunk/; revision=61567
* Remove one time inclusions from the main header and put them back where they belong.
* Cleanup the main header.
CORE-7716
svn path=/trunk/; revision=61566
* Remove one time inclusions from the main header and put them back where they belong.
* Cleanup the main header.
CORE-7716
svn path=/trunk/; revision=61564
* Move some definitions to the main header.
* Remove one time inclusions from the main header and put them back where they belong.
CORE-7716
svn path=/trunk/; revision=61563
* Move the main header up one level.
* Move some inclusions to the main header.
* Remove inclusions and definitions that already exist in the main header.
* Cleanup the main header.
CORE-7716
svn path=/trunk/; revision=61561
* Remove one time inclusions from the main header and put them back where they belong.
* Cleanup headers including the main one.
CORE-7716
svn path=/trunk/; revision=61559
* Remove one time inclusions from the main header and put them back where they belong.
* Cleanup the main header.
CORE-7716
svn path=/trunk/; revision=61558
* Remove one time inclusions from the main header and put them back where they belong.
* Cleanup the main header.
CORE-7716
svn path=/trunk/; revision=61557
* Remove one time inclusions from the main header and put them back where they belong.
* Cleanup the main header.
CORE-7716
svn path=/trunk/; revision=61556
* Remove one time inclusions from the main header and put them back where they belong.
* Cleanup the main header.
CORE-7716
svn path=/trunk/; revision=61555
* Remove one time inclusions from the main header and put them back where they belong.
* Cleanup the main header.
* Improve the GUIDs situation.
CORE-7716
svn path=/trunk/; revision=61553
* Remove one time inclusions from the main header and put them back where they belong.
* Cleanup the main header.
CORE-7716
svn path=/trunk/; revision=61552
* Remove one time inclusions from the main header and put them back where they belong.
* Cleanup the main header.
* Remove useless NDEBUG define.
CORE-7716
svn path=/trunk/; revision=61549
* Move some inclusions to the main header.
* Remove inclusions and definitions that already exist in the main header.
CORE-7716
svn path=/trunk/; revision=61548
- Use PSEH to test and catch SSE exceptions
#CORE-7727 Problem with software implementation is fixed with r61545. Investigating on vmware driver support.
svn path=/trunk/; revision=61545
- Add all groups, of which the user is a member, to the token group list.
- Remove the hard-coded administrators group and users group from the token group list.
This patch enables us to create ordinary user accounts which are not members of the administrator group and which do not have administrator privileges. Now we can start to test and fix the security components!
svn path=/trunk/; revision=61539
* Move shell file operations to background threads to prevent the shell from hanging during long copies, deletes, and moves.
* Improve drag and drop functionality.
* Add a partial drop handler to the recycle bin.
* Brought to you by Huw Campbell.
CORE-3760
svn path=/trunk/; revision=61537
* Remove one time inclusions from the main header and put them back where they belong.
* Cleanup the main header.
* Dedicated to Daniel Reimer.
CORE-7716
svn path=/trunk/; revision=61534
* Move some inclusions to the main header.
* Remove inclusions and definitions that already exist in the main header.
CORE-7716
svn path=/trunk/; revision=61532
* Remove one time inclusions from the main header and put them back where they belong.
* Cleanup the main header.
CORE-7716
svn path=/trunk/; revision=61530
* Remove one time inclusions from the main header and put them back where they belong.
* Cleanup the main header.
CORE-7716
svn path=/trunk/; revision=61529
* Remove one time inclusions from the main header and put them back where they belong.
* Cleanup the main header.
CORE-7716
svn path=/trunk/; revision=61528
* Remove one time inclusions from the main header and put them back where they belong.
* Cleanup the main header.
CORE-7716
svn path=/trunk/; revision=61527
* Remove one time inclusions from the main header and put them back where they belong.
* Improve the main header.
CORE-7716
svn path=/trunk/; revision=61526
* Remove one time inclusions from the main header and put them back where they belong.
* Cleanup the main header.
* Improve the GUIDs situation.
CORE-7716
svn path=/trunk/; revision=61524
* Remove one time inclusions from the main header and put them back where they belong.
* Cleanup the main header.
* Improve the GUIDs situation.
CORE-7716
svn path=/trunk/; revision=61523
* Remove one time inclusions from the main header and put them back where they belong.
* Cleanup the main header.
CORE-7716
svn path=/trunk/; revision=61520
* Remove one time inclusions from the main header and put them back where they belong.
* Include what we need from the NDK instead of the whole set.
CORE-7716
svn path=/trunk/; revision=61519
* Remove one time inclusions from the main header and put them back where they belong.
* Remove inclusions and definitions that already exist in the main header.
* Cleanup the main header.
CORE-7716
svn path=/trunk/; revision=61518
* Remove one time inclusions from the main header and put them back where they belong.
* Cleanup the main header.
CORE-7716
svn path=/trunk/; revision=61517
* Remove one time inclusions from the main header and put them back where they belong.
* Cleanup the main header.
CORE-7716
svn path=/trunk/; revision=61516
* Remove one time inclusions from the main header and put them back where they belong.
* Cleanup the main header.
CORE-7716
svn path=/trunk/; revision=61515
* Remove one time inclusions from the main header and put them back where they belong.
* Cleanup the main header.
CORE-7716
svn path=/trunk/; revision=61512
* Remove one time inclusions from the main header and put them back where they belong.
* Cleanup the main header.
CORE-7716
svn path=/trunk/; revision=61510
* Remove inclusions that already exist in the main header.
* Cleanup the main header.
* Improve the GUIDs situation.
CORE-7716
svn path=/trunk/; revision=61505
* Remove inclusions that already exist in the main header.
* Cleanup the main header.
* Improve the GUIDs situation.
CORE-7716
svn path=/trunk/; revision=61504
* Remove inclusions that already exist in the main header.
* Cleanup the main header.
* Improve the GUIDs situation.
CORE-7716
svn path=/trunk/; revision=61502
* Remove one time inclusions from the main header and put them back where they belong.
* Cleanup the main header.
CORE-7716
svn path=/trunk/; revision=61500
* Do not include debug.h into the main header.
* Remove one time inclusions from the main header and put them back where they belong.
* Cleanup the main header.
CORE-7716
svn path=/trunk/; revision=61499
- Create the privilege set for the logon token based on the users group membrships.
- Remove the hard-coded privilege set.
svn path=/trunk/; revision=61493
* Do not include debug.h into the main header.
* Remove one time inclusions from the main header and put them back where they belong.
* Move some inclusions to the main header.
* Remove inclusions and definitions that already exist in the main header.
CORE-7716
svn path=/trunk/; revision=61489
* Move some inclusions to the main header.
* Set the default debugging channel globally through the main header.
* Remove inclusions and definitions that already exist in the main header.
* Improve the GUIDs situation.
CORE-7716
svn path=/trunk/; revision=61484
* Move some inclusions to the main header.
* Set the default debugging channel globally through the main header.
* Remove inclusions and definitions that already exist in the main header.
CORE-7716
svn path=/trunk/; revision=61483
* Move some inclusions to the main header.
* Set the default debugging channel globally through the main header.
* Remove inclusions and definitions that already exist in the main header/resource file.
CORE-7716
svn path=/trunk/; revision=61482
* Move some inclusions to the main header.
* Remove inclusions and definitions that already exist in the main header.
CORE-7716
svn path=/trunk/; revision=61481
* Move some inclusions to the main header.
* Remove inclusions and definitions that already exist in the main header.
CORE-7716
svn path=/trunk/; revision=61480
* Move some inclusions to the main header.
* Set the default debugging channel globally through the main header.
* Remove inclusions and definitions that already exist in the main header/resource file.
CORE-7716
svn path=/trunk/; revision=61479
* Move some inclusions to the main header.
* Set the default debugging channel globally through the main header.
* Remove inclusions and definitions that already exist in the main header.
CORE-7716
svn path=/trunk/; revision=61478
* Move some inclusions to the main header.
* Set the default debugging channel globally through the main header.
* Remove inclusions and definitions that already exist in the main header.
* Improve the GUIDs situation.
CORE-7716
svn path=/trunk/; revision=61477
* Move some inclusions to the main header.
* Set the default debugging channel globally through the main header.
* Remove inclusions and definitions that already exist in the main header.
* Improve the GUIDs situation.
CORE-7716
svn path=/trunk/; revision=61474
* Move some inclusions to the main header.
* Set the default debugging channel globally through the main header.
* Remove inclusions and definitions that already exist in the main header.
* Improve the GUIDs situation.
CORE-7716
svn path=/trunk/; revision=61473
* Move some inclusions to the main header.
* Set the default debugging channel globally through the main header.
* Remove inclusions and definitions that already exist in the main header.
* Improve the GUIDs situation.
CORE-7716
svn path=/trunk/; revision=61471
* Move some inclusions to the main header.
* Remove inclusions and definitions that already exist in the main header.
CORE-7716
svn path=/trunk/; revision=61470
Fix user-mode access of pointers. From a patch by Sven Bjorn (private communication) and Aleksander Andrejevic.
"[...]In the routine NtSetTimerResolution() the pointer "CurrentResolution" is
checked using ProbeForWriteUlong(), but it is then accessed outside of a try-block.
This should be an error, since the user mode memory can become invalid at any point
in time and thus potentially make the kernel crash on access.
[...]"
CORE-7387 #comment A fix by Sven Bjorn was committed in revision 61468, thanks :)
svn path=/trunk/; revision=61468
Take the processor information from HARDWARE\\DESCRIPTION\\System\\CentralProcessor\\0 and pass it to the device manager.
CORE-5960 #comment Still WIP.
svn path=/trunk/; revision=61461
- Add default group SIDs to the token groups list (WorldSID aka Everyone and the logon type SID).
- Remove these SIDs from the hard-coded list.
svn path=/trunk/; revision=61457
* Set the default debugging channel globally through the main header.
* Remove one time inclusions from the main header and put them back where they belong.
CORE-7716
svn path=/trunk/; revision=61456
* Move some inclusions to the main header.
* Remove inclusions and definitions that already exist in the main header.
CORE-7716
svn path=/trunk/; revision=61455
* Don't use __MINGW32__ because of some stupid 3rd party code setup of ours (I'm looking at you, libxml2).
* Fixes MSVC build.
svn path=/trunk/; revision=61454
* Move some inclusions to the main header.
* Set the default debugging channel globally through the main header.
* Remove inclusions and definitions that already exist in the main header/resource file.
* Improve the GUIDs situation.
* Dedicated to the newborn Olivia !
CORE-7716
svn path=/trunk/; revision=61453
- add intrin.h which redirects to compiler specific version
- Do not add a global include directory for two headers
- Update float.h accordingly
svn path=/trunk/; revision=61450
* Move some inclusions to the main header.
* Set the default debugging channel globally through the main header.
* Remove inclusions and definitions that already exist in the main header.
CORE-7716
svn path=/trunk/; revision=61448
* Create a main header and move some inclusions to it.
* Set the default debugging channel globally through the main header.
* Remove inclusions and definitions that already exist in the main header.
CORE-7716
svn path=/trunk/; revision=61447
* Move some inclusions to the main header.
* Set the default debugging channel globally through the main header.
* Remove inclusions and definitions that already exist in the main header.
CORE-7716
svn path=/trunk/; revision=61446
* Create a main header and move some inclusions to it.
* Set the default debugging channel globally through the main header.
* Remove inclusions and definitions that already exist in the main header/resource file.
CORE-7716
svn path=/trunk/; revision=61445
* Set the default debugging channel globally through the main header.
* Remove one time inclusions from the main header and put them back where they belong.
CORE-7716
svn path=/trunk/; revision=61443
* Move some inclusions to the main header.
* Set the default debugging channel globally through the main header.
* Remove inclusions and definitions that already exist in the main header.
* Improve the GUIDs situation.
CORE-7716
svn path=/trunk/; revision=61442
* Create a main header and move some inclusions to it.
* Set the default debugging channel globally through the main header.
* Remove inclusions and definitions that already exist in the main header.
CORE-7716
svn path=/trunk/; revision=61440
* Create a main header and move some inclusions to it.
* Remove inclusions and definitions that already exist in the main header.
CORE-7716
svn path=/trunk/; revision=61437
* Include msidefs.h after propidl.h to prevent that dreadful PID_SECURITY two values problem.
CORE-7724 #resolve #comment Should be fixed in r61436.
svn path=/trunk/; revision=61436
- Add local group SIDs to the token groups list (LocalSID and LogonSID).
- Remove these SIDs from the hard-coded list.
svn path=/trunk/; revision=61433
* Move some inclusions to the main header.
* Set the default debugging channel globally through the main header.
* Remove inclusions and definitions that already exist in the main header.
CORE-7716
svn path=/trunk/; revision=61432
* Move some inclusions to the main header.
* Set the default debugging channel globally through the main header.
* Remove inclusions and definitions that already exist in the main header.
CORE-7716
svn path=/trunk/; revision=61431
* Move some inclusions to the main header.
* Remove inclusions and definitions that already exist in the main header/resource file.
CORE-7716
svn path=/trunk/; revision=61430
* Create a main header and move some inclusions to it.
* Remove inclusions and definitions that already exist in the main header.
CORE-7716
svn path=/trunk/; revision=61429
Improve heap allocations by using tags and using the temp heap for all temporary allocations that will not be used by the kernel. This avoids heap fragmentation for the default heap. Increase the temp heap size to 32 MB and limit the size of the cache to the temp heap size minus 128 KB to avoid exhausting the heap with cache data. See CORE-4413.
This commit is dedicated to Ronja, my beloved cat who passed away on 5th of December. Rest in peace, little Schnuppel.
svn path=/trunk/; revision=61428
* Create a main header and move some inclusions to it.
* Remove inclusions and definitions that already exist in the main header.
* Improve the GUIDs situation.
CORE-7716
svn path=/trunk/; revision=61427
* Create a main header and move some inclusions to it.
* Set the default debugging channel globally through the main header.
* Remove inclusions and definitions that already exist in the main header.
CORE-7716
svn path=/trunk/; revision=61424
* Move some inclusions to the main header.
* Set the default debugging channel globally through the main header.
* Remove inclusions and definitions that already exist in the main header.
CORE-7716
svn path=/trunk/; revision=61418
* Move some inclusions to the main header.
* Remove inclusions and definitions that already exist in the main header.
CORE-7716
svn path=/trunk/; revision=61416
- Move the creation of the token owner SID from msv1_0 to lsasrv.
- If the user is a member of the administrators group, the adminstrators group becomes the owner of the token. Otheriwse, the user is the owner of the token.
svn path=/trunk/; revision=61415
* Move some inclusions to the main header.
* Set the default debugging channel globally through the main header.
* Remove inclusions and definitions that already exist in the main header/resource file.
* Improve the GUIDs situation.
CORE-7716
svn path=/trunk/; revision=61414
* Move some inclusions to the main header.
* Set the default debugging channel globally through the main header.
* Remove inclusions and definitions that already exist in the main header.
CORE-7716
svn path=/trunk/; revision=61412
* Move some inclusions to the main header.
* Set the default debugging channel globally through the main header.
* Remove inclusions and definitions that already exist in the main header.
* Improve the GUIDs situation.
CORE-7716
svn path=/trunk/; revision=61411
- Move the creation of the default DACL from msv1_0 to lsasrv. Create the default DACL only if the selected authentication package does not provide one.
svn path=/trunk/; revision=61401
* Move some inclusions to the main header.
* Set the default debugging channel globally through the main header.
* Remove inclusions that already exist in the main header/resource file.
CORE-7716
svn path=/trunk/; revision=61400
* Create a main header and move some inclusions to it.
* Set the default debugging channel globally through the main header.
* Remove inclusions and definitions that already exist in the main header/resource file.
CORE-7716
svn path=/trunk/; revision=61398
* Move some inclusions to the main header.
* Set the default debugging channel globally through the main header.
* Remove inclusions and definitions that already exist in the main header.
CORE-7716
svn path=/trunk/; revision=61397
* Move some inclusions to the main header.
* Do not include debug.h into the main header.
* Remove inclusions and definitions that already exist in the main header.
CORE-7716
svn path=/trunk/; revision=61395
* Create a main header and move some inclusions to it.
* Set the default debugging channel globally through the main header.
* Remove inclusions that already exist in the main resource file.
CORE-7716
svn path=/trunk/; revision=61391
* Move some inclusions to the main header.
* Set the default debugging channel globally through the main header.
* Remove inclusions and definitions that already exist in the main header/resource file.
CORE-7716
svn path=/trunk/; revision=61386
* Create a main header and move some inclusions to it.
* Set the default debugging channel globally through the main header.
CORE-7716
svn path=/trunk/; revision=61385
* Move some inclusions to the main header.
* Set the default debugging channel globally through the main header.
* Remove inclusions and definitions that already exist in the main header.
CORE-7716
svn path=/trunk/; revision=61383
* Create a main header and move some inclusions to it.
* Set the default debugging channel globally through the main header.
CORE-7716
svn path=/trunk/; revision=61382
* Move some inclusions to the main header.
* Set the default debugging channel globally through the main header.
* Remove inclusions and definitions that already exist in the main header.
CORE-7716
svn path=/trunk/; revision=61380
* Move some inclusions to the main header.
* Set the default debugging channel globally through the main header.
* Remove inclusions and definitions that already exist in the main header.
CORE-7716
svn path=/trunk/; revision=61378
* Move some inclusions to the main header.
* Extract the resource related definitions into resource.h and include it in both the main header and the resource file.
* Set the default debugging channel globally through the main header.
* Remove inclusions and definitions that already exist in the main header/resource file.
CORE-7716
svn path=/trunk/; revision=61376
* Move some inclusions to the main header.
* Set the default debugging channel globally through the main header.
* Remove inclusions and definitions that already exist in the main header.
CORE-7716
svn path=/trunk/; revision=61367
* Move some inclusions to the main header.
* Set the default debugging channel globally through the main header.
* Remove inclusions and definitions that already exist in the main header/resource file.
CORE-7716
svn path=/trunk/; revision=61362
* Move some inclusions to the main header.
* Set the default debugging channel globally through the main header.
* Remove inclusions and definitions that already exist in the main header.
CORE-7716
svn path=/trunk/; revision=61359
* Move some inclusions to the main header.
* Set the default debugging channel globally through the main header.
* Remove inclusions and definitions that already exist in the main header.
CORE-7716
svn path=/trunk/; revision=61357
* Move some inclusions to the main header.
* Remove inclusions and definitions that already exist in the main header/resource file.
CORE-7716
svn path=/trunk/; revision=61353
* Move some inclusions to the main header.
* Extract the resource related definitions into resource.h and include it in both the main header and the resource file.
* Set the default debugging channel globally through the main header.
* Remove inclusions and definitions that already exist in the main header/resource file.
CORE-7716
svn path=/trunk/; revision=61347
* Move some inclusions to the main header.
* Set the default debugging channel globally through the main header.
* Remove inclusions and definitions that already exist in the main header.
CORE-7716
svn path=/trunk/; revision=61345
* Move some inclusions to the main header.
* Extract the resource related definitions into resource.h and include it in both the main header and the resource file.
* Set the default debugging channel globally through the main header.
* Remove inclusions and definitions that already exist in the main header/resource file.
CORE-7716
svn path=/trunk/; revision=61343
* Move some inclusions to the main header.
* Extract the resource related definitions into resource.h and include it in both the main header and the resource file.
* Remove inclusions and definitions that already exist in the main header.
CORE-7716
svn path=/trunk/; revision=61341
* Add stdio.h inclusion to the main header.
* Add some missing definitions to the internal header.
* Remove inclusions and definitions that already exist in the main header.
* Make the Wine synced source files use the main header.
CORE-7716
svn path=/trunk/; revision=61340
* Improve header inclusions.
* Move some inclusions to the main header.
* Set the default debugging channel globally through the main header.
* Remove inclusions and definitions that already exist in the main header.
CORE-7716
svn path=/trunk/; revision=61339
* Move some inclusions to the main header.
* Set the default debugging channel globally through the main header.
* Remove inclusions and definitions that already exist in the main header.
CORE-7716
svn path=/trunk/; revision=61338
* Move some inclusions to the main header.
* Set the default debugging channel globally through the main header.
* Remove inclusions and definitions that already exist in the main header.
CORE-7716
svn path=/trunk/; revision=61337
* Move some inclusions to the main header.
* Set the default debugging channel globally through the main header.
* Remove inclusions and definitions that already exist in the main header.
CORE-7716
svn path=/trunk/; revision=61336
* Move some inclusions to the main header.
* Set the default debugging channel globally through the main header.
* Remove inclusions and definitions that already exist in the main header.
CORE-7716
svn path=/trunk/; revision=61335
* Move some inclusions to the main header.
* Set the default debugging channel globally through the main header.
* Remove inclusions and definitions that already exist in the main header.
CORE-7716
svn path=/trunk/; revision=61333
- Use correct calling convention for some callbacks
- Actually use DriverEntry as entry point
CORE-7094 CORE-7668 #Comment Please retest after r61331
svn path=/trunk/; revision=61331
* Do not include debug.h into the main header.
* Move some inclusions to the main header.
* Remove inclusions and definitions that already exist in the main header.
CORE-7716
svn path=/trunk/; revision=61330
* Move some inclusions to the main header.
* Remove inclusions and definitions that already exist in the main header.
CORE-7716
svn path=/trunk/; revision=61329
* Move some inclusions to the main header.
* Set the default debugging channel globally through the main header.
* Remove inclusions that already exist in the main header.
CORE-7716
svn path=/trunk/; revision=61328
* Move some inclusions to the main header.
* Set the default debugging channel globally through the main header.
* Extract the resource IDs into resource.h and include it in both the main header and the resource file.
* Remove inclusions and definitions that already exist in the main header.
CORE-7716
svn path=/trunk/; revision=61327
* Move some inclusions to the main header.
* Set the default debugging channel globally through the main header.
* Remove inclusions and definitions that already exist in the main header.
CORE-7716
svn path=/trunk/; revision=61326
* Move some inclusions to the main header.
* Set the default debugging channel globally through the main header.
* Remove inclusions and definitions that already exist in the main header.
CORE-7716
svn path=/trunk/; revision=61325
* Move some inclusions to the main header.
* Set the default debugging channel globally through the main header.
* Remove inclusions and definitions that already exist in the main header.
CORE-7716
svn path=/trunk/; revision=61323
* Move some inclusions to the main header.
* Set the default debugging channel globally through the main header.
* Remove useless inclusions and definitions that already exist in the main header.
CORE-7716
svn path=/trunk/; revision=61322
- Arch, don't allow the mouse to create unexpected messages because this will surely cause failures. Also if you move the mouse during the test you will also get these failures
svn path=/trunk/; revision=61311
* Make the Recycle Bin icon reflect whether the bin is empty or not. Brought to you by Huw Campbell.
CORE-3712 #resolve #comment Committed in r61293. Cheers ;)
svn path=/trunk/; revision=61293
- Remove the old logon code. It is not needed any longer.
- LogonUserW: Pass two SIDs (LogonSid and LocalSid) to LsaLogonUser.
- LogonUserW: Use a better token source name.
svn path=/trunk/; revision=61281
- Correctly set the trackbar range for long files. Patch by Ricardo Hanke (foreverwinter at hotmail dot de)
CORE-7631 #resolve #comment Thanks! Committed in r61279
svn path=/trunk/; revision=61279
Use -ffat-lto-objects option for LTCG builds. GCC 4.9 now defaults
to slim LTO, which (owing to linker bug #13557) fails with undefined
reference errors.
[LWIP]
Compile with -fno-builtin-malloc -fno-builtin-free. GCC bug #56578.
svn path=/trunk/; revision=61266
- Improvements to the message system. Fix hook write backs. Reduced memory when calling back from server side. Disabled post or send, leaving it in place just for a while, to test. See CORE-7447.
svn path=/trunk/; revision=61251
- Restore code from revision 48982 by Giannis Adamopoulos. See CORE-6554.
- Port sync wine winpos code. Fixes all the wine win:test_children/popup_zorder tests except "move hwnd_F and its popups down" that is if'ed out. Side effect, ReactOS regressed from 29 to 48 failures for the DeferWindowPos API test. That is not bad compared to wine ran 347 tests and 52 failures, ReactOS ran 385 tests.
- Keeping code if'ed out for now and added a flag to set most bottom window.
svn path=/trunk/; revision=61244
- Add cat, ps and winefile for testing. Building winefile (cmake hacked please check it) is syned up with wine head (winefile.c/h only).
svn path=/trunk/; revision=61241
* Add Albanian translations to all the base/system folder. Brought to you by Ardit Dani.
CORE-7675 #resolve #comment Committed in r61235. Thanks !
svn path=/trunk/; revision=61235
Remove the legacy directory.rbuild file.
[VGAFONTEDIT]
- Add necessary headers definitions for CPI font files.
- Add some (unused for now) PSFv1 definitions.
- Add a (unused for now) VGAFONT structure that defines whether the font is stored as RAW, CPI or PSF.
svn path=/trunk/; revision=61227
- Convert resource file in the Amine way ;)
- Remove legacy .rbuild file.
- Just start to introduce cpi.h header for future support of CPI font files.
- Split up precompiled header into raw, psf and cpi headers for each supported font format.
svn path=/trunk/; revision=61226
* Add Albanian translation to almost all the applications folder. Brought to you by Ardit Dani.
CORE-7672 #resolve #comment Committed in r61222. Thanks !
svn path=/trunk/; revision=61222
Fix completely b0rked dialog layouts in the one and only dialog in this dll. 12 languages were fixed and the german translation updated.
svn path=/trunk/; revision=61209
Fix a bug that overwrites drive data if two FDDs are attached to a controller. Only the second drive is detected in this case.
svn path=/trunk/; revision=61162
This fixes the inclusion into the ReactOS system. (Included Gecko, Runtimes and sound drivers now are detected and used while setup)
svn path=/trunk/; revision=61156
Add an inf file for floppy disk drives. If you have a floppy disk drive attached to your computer, it should appear in the device manager.
svn path=/trunk/; revision=61154
- Get rid of MmZeroPte and instead implement MI_ERASE_PTE. Use this and only this to make a PTE zero. The other functions will not allow to do this.
- Add MI_UPDATE_VALID_PTE to update a valid PTE with another valid PTE
- Add 2 additional protection mask constants: MM_PROTECT_ACCESS for the lower 3 bits and MM_PROTECT_SPECIAL for the higher 2 bits. Make use of the latter when dealing with guard pages and caching.
- Deduplicate some code in MmArmAccessFault
- Move code in MiDeleteSystemPageableVm to where it belongs (it was in the wrong else case!)
- Wse MiQueryPageTableReferences instead of manipulating MmWorkingSetList->UsedPageTableEntries
svn path=/trunk/; revision=61110
- Implement SepAdjustPrivileges, which does both the counting of (changed) privileges as well as applying them, when requested. Use it in NtAdjustPrivilegesToken twice instead of duplicating the code there.
- Fix return value of NtAdjustPrivilegesToken by making sure to properly count the found privileges and check against the provided ones
- Lock the Token, while messing with the privileges
- Add support for SE_PRIVILEGE_REMOVED
- Proplery (re)calculate Token flags after changing privileges
- Improve failure pathes by using a common cleanup label
- Don't free the allocations atatched to the token in SepCreateToken on failure, since ObDereferenceObject will already do that.
- Make priviliges constants instead of initializing them.
svn path=/trunk/; revision=61109
- Remove the BoundaryAddressMultiple parameter from MmCreateMemoryArea (wasn't used) and give it instead a Granularity parameter
- Use the Granularity parameter in MmMapViewOfSegment to make sure that full sections are allocated on a MM_ALLOCATION_GRANULARITY aligned address.
- Check for overflow and unaligned image base in MmMapViewOfSection when mapping image sections
- Return proper status code on failure
svn path=/trunk/; revision=61108
BuildUserInfoBuffer: Set the UF_PASSWD_CANT_CHANGE account control flag if the user does not have the USER_CHANGE_PASSWORD access right for his own account data.
svn path=/trunk/; revision=61103
- Create the Security directory and the LSA_AUTHENTICATION_INITIALIZED event in SepInitializationPhase1().
- Get rid of SeInitSRM().
svn path=/trunk/; revision=61102
- Fix wrong check for realtime priority class in CreateProcessInternalW
- Fix double free in GetEnvironmentVariable[AW]
- Fix broken sizeof usage ('X' is of type int!)
- Remove redundant casts and comparisons
svn path=/trunk/; revision=61101
Windows / ReactOS uses a software protection field called protection mask, which is stored inside invalid (Software) PTEs to provide information about the desired protection, when a page is made valid by the page fault handler. The mask consists of the values 0-7 specifying the read/write/execute rights, 0 being inaccessible aka MM_ZERO_ACCESS, plus 2 flag-like bits, for uncached and writecombine memory respectively. Both flags together don't make sense, so this combination is used to mark guard pages. Since all these flags only make sense when used together with a proper access (i.e. not MM_ZERO_ACCESS), the combination of these flags together with MM_ZERO_ACCESS was given special meaning: MM_DECOMMIT, which equals MM_GUARDPAGE | MM_ZERO_ACCESS is for decommitted pages, that are not yet erased to zero, MM_NOACCESS, which is the mask for pages that are mapped with PAGE_NOACCESS (this is to make sure that a software PTE of a committed page is never completely 0, which it could be, when MM_ZERO_ACCESS was used), and finally MM_OUTSWAPPED_KSTACK for outswapped kernel stacks. See also https://www.reactos.org/wiki/Techwiki:Memory_Protection_constants.
The next thing to know is that the number of PTEs that are not null is counted for each PDE. So once a page gets committed, a software PTE is written and the reference count is incremented. When the page is made valid by the fault handler, the count is not changed, when the page is decommitted, the MM_DECOMMIT software PTE is written and again the PTE stays non-null and nothing is changed. Only when the range is cleaned up totally, the PTEs get erased and the reference count is decremented. Now it happened that our page fault handler missed to validate the access rights of protection constants. The problem that came up with this is a major one: since a decommitted page is a software PTE with MM_DECOMMIT as the protection mask (which we remember has the MM_GUARDPAGE bit set), the fault handler considered faults on decommitted PTEs as faults on guard pages and simply removed the guard page flag, leaving a completely empty PTE behind! So the decommitted page got erased without decrementing the reference count. This lead to CORE-7445.
- Add protection flags (MM_GUARDPAGE, MM_WRITECOMBINE, MM_OUTSWAPPED_KSTACK)
- Instead of writing 0 to a PTE, use MI_WRITE_INVALID_PTE with MmZeroPte
- Implement MiIsAccessAllowed that checks for read/write/execute access and use it in MiAccessCheck
- Add some more ASSERTs
CORE-7445 #resolve
svn path=/trunk/; revision=61095
- define STR_FILE_SYS_BIND_DATA in the public headers and use it in IFileSystemBindDataImpl and CFSFolder. Now we use the same string to store the IFileSystemBindDataImpl in the bind context.
- Fix CFSFolder::ParseDisplayName to properly parse paths with a IBindCtx
- Should fix creating pidls that represent files that don't exist and fix SHChangeNotify tests that hanged for a whole minute in our test suite
svn path=/trunk/; revision=61094
- Add a disabled "Change Password" button to the Security dialog.
- Add the "Change Password" dialog and a basic dialog function.
svn path=/trunk/; revision=61092
- Use MI_IS_MAPPED_PTE instead of unportable bit fiddling
- Use MiDecrementPageTableReferences instead of manually messing with MmWorkingSetList, which is not portable
- Make MmGetPhysicalAddress portable
svn path=/trunk/; revision=61086
- Add hacks to MmMapViewInSessionSpace and MmUnmapViewInSessionSpace to check for legacy (non ARM3) sections (image sections) and (un)map them in system space instead.
- Fix MmCommitSessionMappedView (it wasn't resetting the PointerPte to the start, when processing the PTE range a second time)
- Remove an ASSERT that didn't allow unmapping session space mappings, since that works (see CORE-6729)
- Change a write to a PTE to using MI_WRITE_VALID_PTE
svn path=/trunk/; revision=61081
- Fix few French resources.
- Support F2 key for renaming keys/values.
Patch by Edijs Kolesnikovics
CORE-7615 #resolve #comment Committed in revision 61080. Thanks!
svn path=/trunk/; revision=61080
Skip all images that were loaded using MmLoadSystemImage in MiFindInitializationCode. Drivers loaded by Mm are handled in MmFreeDriverInitialization (which we currently run for boot loaded images as well, so duplicated work...). But now at least session loaded images are NOT processed this way. Because even though they can have INIT sections, they don't neccessarily like it when stuff gets removed, especially win32k doesn't like it when it's .rsrc section is being discarded due to it's section flags!
svn path=/trunk/; revision=61076
Check the PTE as well in MmArmAccessFault, when we are at high IRQL and fail if it's not valid. Otherwise we just end up in an endless loop.
svn path=/trunk/; revision=61075
Always call the win32 process callout from PsConvertToGuiThread and handle the case where we alrady have an allocated win32 process there. (The original win32k sometimes allocates a win32 process, but doesn't initialize it, so it needs to be called again to do so)
svn path=/trunk/; revision=61072
- call ShellDDEInit, FileIconInit and WinList_Init while initializing
- Calling ShellDDEInit fixes cases like pressing Explore in a folder context menu from a file open dialog (before this it just hanged)
- We also need to call FileIconInit in order to initialize the shell icons properly. Before this Shell_GetImageLists called FileIconInit in case it was not called
- Calling WinList_Init should make CLSID_ShellWindows work but it fails for now. CLSID_ShellWindows is needed in cases like opening a second time My computer from desktop should activates the existing My computer window and it is also needed for SHOpenFolderAndSelectItems in order to work
svn path=/trunk/; revision=61064
Properly implement MmGetSessionById, MmAttachSession, MmDetachSession and MmQuitNextSession. Implement more session cleanup code and make sure a session is not killed while a process is attached to it. There used to be a bug, where removing a process from the session list caused pool corruption, which was because we called MiSessionRemoveProcess twice: once from PspExitThread, when the last thread exited and another time from PspDeleteProcess, when the reaper thread deleted the process object. This was, because the flag that said the process was in a session was not cleared properly. This is now fixed and inserting and removing processes into the session's list works fine. Also protect it properly with a spinlock.
svn path=/trunk/; revision=61061
Keyboard layout files have special requirements to the section layout of the dell. That is because MS win32k devs didn't write proper code and that is why the original win32k first parses all sections, looks for the .data section, checks if everything is valid and then truncates a pointer in a table to 16 bit and uses this as an offset into the section. Of course that does ONLY work, if the section is the first section AND that pointer happens to be less than 64k off from the start of the section AND the image base is 64k aligned. To achieve this, add a new module type kbdlayout that does all the neccessary things. On MSVC we merge the sections with a linker command, on GCC we use a custom linker script.
svn path=/trunk/; revision=61053
Implement ExpWin32SessionCallout, which attaches to the session that the object (desktop or window station) belongs to before invoking any callbacks. The session side of support for this is currently hardcoded to support only a single session. To make this properly work, all callbacks that go through this function have the same function pointer type now, fix this in win32k accordingly.
svn path=/trunk/; revision=61052
Implement RtlpCloseHandleCallback, closing the handle table, and use it as callback for ExSweepHandleTable in RtlpDestroyAtomHandleTable. Without a callback ExSweepHandleTable simply crashes, so obviously we never clean up any atom tables, possibly because the window station is never closed.
svn path=/trunk/; revision=61039
Implement ObSetHandleAttributes. Rename the ObIsKernelHandle macro to ObpIsKernelHandle to avoid ambiguities (ObIsKernelHandle is a public Vista+ API). Check for NtCurrentProcess and NtCurrentThread in ObpIsKernelHandle, since those are always non-kernel handles.
svn path=/trunk/; revision=61037
LogfInitializeExisting: Do not try to write to a file that has been opened as a backup file. It has been opened read-only.
svn path=/trunk/; revision=61026
Rewrite the code for generating def files. Remove useless switches. Seperate code for GCC and MSVC for easier maintainability. Make use of the new dlltool feature implemented by Kai Tietz, that allows to specify the name of an import/export. It is now possible to both export stdcall and fastcall decorated symbols as well as import from them.
svn path=/trunk/; revision=61024
- fixes vmware audio driver hangs
- needs more work
- patch by David Quintana
CORE-7488 #resolve #comment thanks for the patch
svn path=/trunk/; revision=61017
[VIDEOPRT] Implement some registry support routines to create new style (XP+) registry keys. Handle IOCTL_VIDEO_INIT_WIN32K_CALLBACKS in videoprt, reorganize the code to dispatch ioctls. Simplify failure path in IntVideoPortFindAdapter
svn path=/trunk/; revision=61013
Add all function stubs. (win32k from windows 2k3 is nasty and indexes the function table directly instead of looking up the entries...)
svn path=/trunk/; revision=61012
Fix RtlWriteRegistryValue, it closed the handle passed to it instead of checking for RTL_REGISTRY_HANDLE flag.
[NTOSKRNL]
Fix PnpRootCreateDevice, which was relying on the broken RtlWriteRegistryValue by aborting, when it *succeeded* to create a registry key, instead of when it failed.
Also use kernel handles and ObCloseHandle.
svn path=/trunk/; revision=61011
... and for 61001st commit: Fix the ANSI version of the server-side of ChangeServiceConfig2A API, which broke at converting SERVICE_FAILURE_ACTIONS ANSI structures into UNICODE ones.
Fixes the VMWare Tools Installer; blame Sylvain if it doesn't ;)
Based on a patch by Sylvain Petreolle.
CORE-7539 #comment Fixed in revision 61001, thanks !
svn path=/trunk/; revision=61001
- Fix an assert in new cursoricon implementation
- Fix CreateIconIndirect behaviour regarding bits per pixel and bitmap dimensions
- Fix LookupIconIdFromDirectoryEx behaviour to fulfill last commited tests
CORE-7575 #comment LookupIconDirectoryEx and CreateIconIndirect now works as per tests
svn path=/trunk/; revision=60999
- Add tests for LookupIconIdFromDirectoryEx
- Add a workaround in GetIconInfo tests for a ReactOS bug in EnumDisplaySettings
- Add tests for EnumDisplaySettings demonstrating the bug.
- Add some traces to better follow the test run
svn path=/trunk/; revision=60994
- Commit everything I got on new cursor/icon implementation
- Implement loading animated cursors (no display yet)
- Get rid of this m:n relation between cursors and processes. (ie. proper implementation of LR_SHARED)
- Get rid of the global linked list of cursors (ditto)
- Use atoms instead of copying the module name into the object. (aka stop using non paged pool for nothing)
- Misc fixes
svn path=/trunk/; revision=60978
Fix German and Romanian language ids, which resulted into wrong codepage resources into kernel32.
Add French resource file.
svn path=/trunk/; revision=60968
[VIDEOPRT] Add missing WdDdiWatchdogDpcCallback export
[WATCHDOG] Add a dummy watchdog.sys
Now win32k.sys from win 2003 can be loaded.
svn path=/trunk/; revision=60952
Fix MmLoadSystemImage, to check the system32\drivers path for import modules as well. This should normally only be done for session loaded images, but since we don't support that yet, we do it for all images, until this is fixed. Simplify (flatten) the code by adding a common failure label and use goto where appropriate. Stop leaking memory in failure case (MissingDriverName was never freed. It is leaked on windows 2003 as well)
svn path=/trunk/; revision=60951
Fix probing of parameters in IoCreateFile. Also move the allocation of the OpenPacket down a bit and get rid of 15 ExFreePool() invocations.
svn path=/trunk/; revision=60950
Implement ReadConsoleInputExA/W, which are a generalization of ReadConsoleInputA/W and PeekConsoleInputA/W. They allow you to read console input events by either waiting (or not) for their presence, and to remove them from the console input list (or not).
Those functions are the read-equivalent of WriteConsoleInputVDMA/W.
Used in Windows' NTVDM (guess why ;) ).
svn path=/trunk/; revision=60920
- Do not use HIMAGELIST_QueryInterface which is exported from vista comctl32. The replacement code is taken from HIMAGELIST_QueryInterface and its fine to use it, as is safe to assume that an HIMAGELIST is a IImageList*
- Allows us to use comctl32 5.82 from win2003 and boot to desktop
svn path=/trunk/; revision=60879
- Open the Admin tools folder when we click Manage in the context menu of my computer for now as we don't have mmc yet
svn path=/trunk/; revision=60874
- Implement MiUnlockProcessWorkingSetShared() and make use of it in MiUnlockProcessWorkingSetForFault().
- Complete implementation of MiLockProcessWorkingSetForFault()
svn path=/trunk/; revision=60871
- Add context hack from wine. Pass alt tab info calls to win32k.
- From wine: Alexandre Julliard : user32: Automatically load comctl32 when one of its classes is requested.
svn path=/trunk/; revision=60858
* apply patch from [#CORE-7521] (paint fails silently if a file could not be opened)
* apply patch from [#CORE-7311] (fix and improve resource and UI) in modified form
New resource strings are involved => please check translations
svn path=/trunk/; revision=60850
- Hackix F5 accelerator by moving it for now to the accelerator table of the shell view control
- Use uppercase letters in the accelerator table in order to make windres compile it properly.
- shell accelerators should work fine now
svn path=/trunk/; revision=60848
- When the caller uses SVGIO_BACKGROUND we should always return a context menu of the background. To do it we pass no items to CDefFolderMenu even when we have selected items. Should improve the situation for ctrl+c, ctrl+v in the shell
svn path=/trunk/; revision=60845
Get the user name and domain name from the logon token and set the USERNAME and USERDOMAIN environment variables accordingly.
svn path=/trunk/; revision=60834
- Don't ASSERT the correct ConsoleCtrlInfoLength in NtUserConsoleControl
- Move GreSetObjectOwnerEx out of the SEH block.
svn path=/trunk/; revision=60829
LoadUserProfileW: Add a hack to prevent a failure when a newly created user profile is loaded twice. This failure (sharing violation) is caused by the unimplemented NtUnloadKey function!
This patch enables us to create and use our own user accounts. Please note that these accounts still have hard-coded group and privilege settings.
svn path=/trunk/; revision=60823
- Finally fully implement FstubVerifyPartitionTableEFI(). It is capable of fixing a GPT disk.
- Fix implementation of FstubReadHeaderEFI() (which returns a pointer to the header). Fixed all the other functions accordingly. Note that you have to be careful when using Disk->Buffer. You can easily read a buffer that doesn't contain your data anylonger.
- Fix implementation of FstubReadPartitionTableEFI(). It was improperly dealing with the backup table. Now, it will look for it and replace/recreate it if not found where expected.
- Fix implementation of FstubWriteEntryEFI(). The computation of memory placement was wrong, and thus it was missing partitions and causing corruption. Thank you checksums!
In case you format a disk with GPT using Linux (with GParted, for instance), don't be surprised if once started with ReactOS your GPT is modified, and especially its backup table moved. They don't have the same sector counts.
It was a nice way to tests whether ReactOS properly write GPT. Which it does now :-).
svn path=/trunk/; revision=60811
- Handle invalid cbSize in Shell_NotifyIcon[AW]. Patch by Ivan Rodionov.
- Use FIELD_OFFSET for variable-length structure
CORE-7164
svn path=/trunk/; revision=60804
- Add /FS to VS 2013 build to fix issues with concurrent access to PDB files. Patch by David Quintana
- Use subsystem version 5.02 for x64, because 5.01 doesn't exist
CORE-7434 #resolve
svn path=/trunk/; revision=60803
Implement MiSetControlAreaSymbolsLoaded and MiLoadUserSymbols. These are responsible
for marking the control area that we've loaded the symbols and for effectively loading
the symbols.
These two functions only apply on image section! (ie, ControlArea->u.Flags.Image not null).
They are only compatible with ARM3. But, for the moment, old MM is responsible for image section
mapping and thus, these two functions cannot be used.
Once this responsibility is transfered to ARM3, first call MiCacheImageSymbols, if successful, then call
MiSetControlAreaSymbolsLoaded and MiLoadUserSymbols. After checking image was at base and GlobalMemory was not
set.
Once this is finally linked, this *should* fix PSAPI apitests.
svn path=/trunk/; revision=60802
Enable the new SAM-based logon system.
Using your own accounts to log-on to ReactOS will still fail because of bugs in winlogon, userenv.dll and the registry. But at least the infrastructure is in place and we can start to fix the reamining bugs. All accounts still use a hard-coded privilege set, but this will be fixed as soon as possible.
svn path=/trunk/; revision=60800
Implement a helper function ExpConvertLdrModuleToRtlModule() that converts
a Ldr represented module to a Rtl represented module (structure matters).
Use it for kernel modules list AND user modules list.
This fixes the FIXME of that section but it actually doesn't fix anything
given that our user module lists is still empty (whereas it should be filled in).
svn path=/trunk/; revision=60798
Bye bye PSAPI. Welcome PSAPI :-).
This is a rewrite of the PSAPI DLL to make it match the W2K3 DLL.
It fixes several bugs and implements missing features.
It doesn't use the EPSAPI library anylonger (which old and buggy).
All winetests are passing when executed on W2K3 with this DLL.
Not all tests are passing on ReactOS though, because of missing features in the kernel.
Anyway, this greatly reduces the amount of failed tests.
ROSTESTS-122 #comment Fixed with r60794 #resolve
svn path=/trunk/; revision=60794
Complete MEMORY_INFORMATION_CLASS by adding a missing class (at the proper place): MemoryWorkingSetExList
Alex, could you review please? Not fully sure about the name of such class.
svn path=/trunk/; revision=60793
Implement WriteConsoleInputVDMA/W, its only purpose being putting console input events at the beginning of the console input event list instead of putting them at the end, as it is done with WriteConsoleInputA/W .
svn path=/trunk/; revision=60756
* Properly import WMIC (correcting the previous import committed in r60748).
* The import of other WMI related modules is also already done, and will be committed eventually in the current ongoing sync.
CORE-7469
svn path=/trunk/; revision=60751
The standard writing for ReactOS is with "OS" in capital letters, not in lowercase letters.
Patch by Yuntian Zhang.
CORE-7524 #resolve #comment Fixed in revision 60749, cheers!
svn path=/trunk/; revision=60749
Import WMIC ("Windows Management Instrumentation Console") from Wine 1.7.5 (just released yesterday, 25/10/2013), in which we include only the necessary headers.
Sync up README.WINE too.
WMIC is needed (amongst other things) for retrieving the date of the build when configuring a new build using RosBE. Dedicated to Sylvain Petreolle and Amine Khaldi.
svn path=/trunk/; revision=60748
It appears that "Dhivehi" is the preferred scripture.
CORE-7523 #resolve #comment Committed in revision 60746, cheers.
svn path=/trunk/; revision=60746
[RTL] Fix RtlAddAce (the version checks were inverted.)
[NTOSKRNL] Make SystemExtendServiceTableInformation case of NtSetSystemInformation behave more like Windows
[NTOSKRNL] Fix PsGetCurrentThreadWin32ThreadAndEnterCriticalRegion
svn path=/trunk/; revision=60737
Fix console palette setting. For that, we create a console framebuffer on which we draw the different active screen buffers (be they text or graphics), we can change the palette associated to this framebuffer and then we draw the framebuffer on screen.
Console palettes now work !!!!!! @ [TheFlash]
Part 2/2
svn path=/trunk/; revision=60734
- Remove no longer needed special casing for __MINGW32__. Patch by Ivan Rodionov.
CORE-7335 #resolve #comment Thanks! Committed in r60733.
svn path=/trunk/; revision=60733
- SampSetupCreateUserAccount, SamrCreateUserInDomain and SamrCreateUser2InDomain: Set the PrivateData attribute.
- SamrGetAliasMembership: Remove a superfluous call to SampRegCloseKey.
- SampQueryUserAll and SampSetUserAll: Disable access to the SecDesc attribute as long as it is not set upon user account creation.
svn path=/trunk/; revision=60728
- sam.idl: Rename GROUP_ATTRIBUTE_INFORMATION to SAMPR_GROUP_ATTRIBUTE_INFORMATION in order to avoid confilcts with new types in ntsam.h.
- ntsam.h: Add missing group specific structures.
svn path=/trunk/; revision=60727
- Fix console palette setting; introduce the ConsoleMakePalettePublic control code for NtUserConsoleControl API which
is called by the SetConsolePalette to make the given palette handle public (indeed, the caller to SetConsoleHandle
gives to this API a GDI palette handle which is aimed at being used by another process, i.e. by CSRSS.EXE; in normal
operation this is impossible unless saying to GDI that the handle is meant to be public; that's what it's done there).
Thanks to Aleksander and David (who provided tests) and Timo (see revision 60725) for having helped me in understanding
what happened exactly there.
- Remove now-unneeded DPRINT1s and the hacked palette that was introduced in revision 60629/60641.
Part 1/2
svn path=/trunk/; revision=60726
Add GreSetObjectOwnerEx, allowing to set the owner of not-owned objects by passing GDIOBJFLAG_IGNOREPID as 3rd parameter. Use with care :) Dedicated to Alexander and Hermès.
svn path=/trunk/; revision=60725
- Correctly compute addresses of MI_VAD_BITMAP and MI_WORKING_SET_LIST. In trunk's MM it went unnoticed because nothing really cares about these two structs.
svn path=/trunk/; revision=60721
- The (ATI) patch CORE-6551. Please oh please use this jira core issue for all bug reports and regressions.
- Major rewrite to input message queue. It is now attachable between threads. After all the hubbub the only thing we pass are all the SetActive/Foreground/Parent/Window wine msg and win tests. But not the message sequence tests.
- Pass all but one foreground API User32 ATI test when the message patch is installed. But w/o it, pass all but 8'ish.
- Tested XP osk (On-Screen Keyboard) with CMD, it works but is quirky. Need to look into set to top window issues.
- AHK issues work long as ATI is used and when it is not the some AHK tests fail. That was why all the hot key changes had been committed before. Still looking into this.
- Please test everything and post to the appropriate jira issue reports. I do not have a lot of time anymore to focus hard on many issues, it will take months to do so with just one.
svn path=/trunk/; revision=60718
- Introduce a new and faster way to return to kernel mode from traps by using a ret 8 instruction instead of an iret.
- Make use of KiUserTrap where appropriate
- Remove some pointless toplevel volatile
svn path=/trunk/; revision=60701
- Add an initial stub for CMenuBand that creates a menu bar and fills it with contents. However its still not functional
svn path=/trunk/; revision=60690
- Fix translations of booloader installation menu (see rev.48703). ACHTUNG ACHTUNG!! Greek and Spanish people, please review the translation fix and provide patches if needed!!
- Update French translation.
CORE-7516 #resolve #comment Committed in revision r60678.
svn path=/trunk/; revision=60678
- Fix the name of a function.
- Fix HdlspSendStringAtBaud (we started displaying string at its second character) and fix HdlspPutData (data was sent erroneous, shifted by 1).
Fix SAC display.
svn path=/trunk/; revision=60675
* Set the assert related macros in consistency with the DDK ones, for release builds.
* Improve the debug build checks here (DBG was not even considered before).
svn path=/trunk/; revision=60666
Remove too zealous check for OEMSourceMediaLocation.
OEMSourceMediaLocation can be NULL and means that the current path or a default URL is beeing used.
Fixes installation of VMWare Tools drivers.
The installation still aborts due to issue in configuring the vmware tools service.
svn path=/trunk/; revision=60649
- Update the definition of DM_SPECVERSION according to the Win's PSDK.
- Add the DMDISPLAYFLAGS_TEXTMODE flag for DEVMODE::dmDisplayFlags (see Wine PSDK, Win's PSDK ...)
- Add DMDFO_DEFAULT, DMDFO_STRETCH and DMDFO_CENTER flags for DEVMODE::dmDisplayFixedOutput (see Wine PSDK, Win's PSDK, MSDN ...)
svn path=/trunk/; revision=60633
Implement SetConsolePalette (see r59711 for more details), but it is still WIP:
- the helper function ConDrvSetConsolePalette uses a hardcoded palette for testing purposes,
- lots of DPRINT1 are displayed when using this function or when swapping active screen buffers,
- lot of code redundancy which will be put in some helper functions when this code will work correctly,
- and I get some WIN32K warnings:
WARNING: IntGdiRealizePalette at ../../win32ss/gdi/ntgdi/palette.c:777 is UNIMPLEMENTED!
It would be great if a win32k guy can have a look at this!! And I suspect that's because of this that the changed palette is not used...
Also, deactivate the WM_NCRBUTTONDOWN/WM_NCRBUTTONUP hack I introduced in revision 58632, because James worked on this in revisions 60622 and 60626 (see CORE-7054 too).
svn path=/trunk/; revision=60629
* Make npfs_new the one and only npfs. One of the few foo_new modules that actually made it and I hope it won't be the last ;)
CORE-7451
svn path=/trunk/; revision=60611
- Macros renaming.
- When switching active screen buffers, do it a bit more properly, i.e. announce it to the terminal emulator (aka. frontend) so that it will be able to change the associated console palette, be able to support displaying multi screen buffers or displaying another screen buffer than the active one (for debugging purposes or whatever), etc...
There are still some hacks and commented code, which whill be cleaned when I'll be sure that everything works and is not broken somewhere.
svn path=/trunk/; revision=60593
- Setup small icon support from create window not in register class.
- Remove flags if not inside the current version control. Version control is still FIXME.
svn path=/trunk/; revision=60592
- leaner build part 13 of X
- Get rid of shaders and programs support (with assorted extensions), ARB_multitexture and ATI_envmap_bumpmap extensions.
CORE-7499
svn path=/trunk/; revision=60576
* Fix several logically dead code blocks. CIDs 731580, 731581 and 731582.
* Add a compile time assert to perform a preventive check as suggested by Thomas Faber.
CORE-6681
svn path=/trunk/; revision=60573
Add an apitest for psapi GetDeviceDriverFileName.
I'm looking for help to bring it even farther. Ideally, it would be interesting
to be able to GetDeviceDriverFileName on ntoskrnl base address. The whole point is
about getting it dynamically.
The day we can do it properly, I can predict that it will fail on ReactOS, we're not having
correct paths for KDCOM, HAL, and NTOSKRNL modules in the kernel (thank you FreeLdr? - Where are you
starting '\'?)
svn path=/trunk/; revision=60566
* Move the gecko prompt from the mshtml registration to the second stage installer itself. This allows mshtml to register properly regardless of the availability of the gecko package.
svn path=/trunk/; revision=60565
- Add some descriptions.
- Add HKLM\Software\Microsoft\Windows NT\CurrentVersion\IniFileMapping needed for win2k3 basesrv (otherwise it fails to initialize) (and ours when the INI File Mappings functionality will be fully implemented). INI File Mappings allows redirections from e.g. system.ini --> Adequate Registry Key, when you use APIs such that WritePrivateProfileString to write settings in those INI files (for 16-bit compat).
svn path=/trunk/; revision=60563
During my investigations for making working Win2k3 csrsrv.dll (or other CSR servers) into ROS (to compare our behaviour with our own csrsrv.dll and Win2k3 one), I hit a problem: if I test a checked-build version of csrsrv (or other CSR servers), everything was fine when they were loaded, but if I use a release-build version (i.e. without any debug information), I systematically hit a memory access violation which was traced back to the moment when a CSR server's CsrInitialization entry point was called.
So I did the experiment, where I used our (debug-build) csrsrv with a free-build win2k3 CSR server dll (it was winsrv.dll, and I retested with basesrv.dll after). I hit the access violation. But if I took a debug-build version of winsrv.dll, everything was OK.
I then added in our csrsrv' server.c file the following line (around line 212 of the current file version):
DPRINT1("%s ; ServerDll->ValidTable = 0x%p ; ServerDll->NameTable = 0x%p ; ServerDll->SizeOfProcessData = %d ; ServerDll->ConnectCallback = 0x%p\n", DllString, ServerDll->ValidTable, ServerDll->NameTable, ServerDll->SizeOfProcessData, ServerDll->ConnectCallback);
and I saw that, when using a debug-build win2k3 CSR server, everything was fine (in particular the ServerDll->SizeOfProcessData member contained a reasonable value, e.g. a size of 88 bytes), whereas if I used a free-build version, I got an off-by-one problem, with the ServerDll->ValidTable pointer valid but the ServerDll->NameTable member being equal to 88 (i.e. invalid pointer) and the ServerDll->SizeOfProcessData member being equal to a very large value, which looked like a pointer value.
After more investigations, I saw that in debug-build CSR servers the list of API names were stored, whereas it was not the case in free-build versions. Therefore I concluded that the API names table was included *ONLY* in debug builds and not in release builds.
Hence, to be able to test in ROS either debug-builds or release-builds versions of Windows CSR servers in ROS (and vice-versa), I introduced a #define called CSR_DBG, which is defined only if the DBG macro is != 0, and which is not defined otherwise. When the CSR_DBG flag is defined, API names tables are added in CSR servers and otherwise, they are not.
Therefore, we are now able to test debug-build Windows CSR servers in ROS (the default possibility) or free-build versions of these CSR servers (but first, we have to build the other ones without the CSR_DBG flag, to avoid the off-by-one problem described above).
svn path=/trunk/; revision=60560
- Use Yes/No instead of Ok/Cancel for "Are you sure you want to delete the power scheme?" Patch by Lee Schroeder.
- Remove some unnecessary casts
CORE-7503 #resolve
svn path=/trunk/; revision=60557
CSR_WAIT_FUNCTION functions are callbacks and therefore are __stdcall aka. NTAPI. Fix this.
Now, using either our csrsrv or win2k3' csrsrv works without problems; there is no console key-press problems anymore (aka. stack corruption when calling multiple times CsrNotifyWait, which called those CSR_WAIT_FUNCTION functions).
svn path=/trunk/; revision=60553
- Fix the second parameter WaitType (aka. NotifyAll) of CsrNotifyWait. Indeed, we used before the constants WaitAll == 0 / WaitAny == 1 (see the WAIT_TYPE enum); however, it appeared that Win2k3's CsrNotifyWait wanted a WaitType parameter == 1 when waiting for all the waits in a given wait-list. Therefore we would have to use WaitAll for waiting for any of the wait blocks, and WaitAny for waiting for all the wait blocks... looks illogical. Therefore I use instead a BOOLEAN variable (that I call NotifyAll) which is TRUE when I want to wait for all the wait blocks, and FALSE otherwise (as done e.g. for the WaitForMultipleObjects API).
- Fix its usage in CONSRV.
Magically fix key presses problems in console, when using Win2k3 csrsrv.dll ...
svn path=/trunk/; revision=60551
- Do not associate the newly created wait block to the waiting thread (in CsrInitializeWait) in case this one is going to terminate, but do it instead in CsrCreateWait, where the check actually takes place.
- Avoid PPORT_MESSAGE casts.
- Fix a list insertion problem in CsrMoveSatisfiedWait.
- Fix some descriptions / comments.
svn path=/trunk/; revision=60541
[RTL]: Stubplement and export RtlConsoleMultiByteToUnicodeN (and fallback to RtlMultiByteToUnicodeN) needed for WIndows 2k3 winsrv.dll
CORE-7481 #comment LdrFlushAlternateResourceModules and RtlConsoleMultiByteToUnicodeN stubplemented in revision 60532.
svn path=/trunk/; revision=60532
SampQueryUserAll: Rewrite the handling of the WhichFields variable in order to simplify the support of trusted user information.
svn path=/trunk/; revision=60527
- leaner build part 12 of X
- Get rid of ARB_color_buffer_float, ARB_framebuffer_object, EXT_texture_lod_bias, SGIS_generate_mipmap and SGIS_texture_lod extensions.
CORE-7499
svn path=/trunk/; revision=60518
- leaner build part 11 of X
- Get rid of ARB_draw_buffers, ARB_draw_buffers2, ARB_draw_buffers_blend extensions.
CORE-7499
svn path=/trunk/; revision=60516
- leaner build part 10 of X
- Get rid of ARB_copy_buffer, ARB_depth_buffer_float, ARB_draw_instanced, ARB_texrure_buffer_object, ARB_uniform_buffer_object, EXT_framebuffer_sRGB, EXT_packed_depth_stencil, {MESA,EXT}_texture_array, EXT_texture_sRGB extensions.
CORE-7499
svn path=/trunk/; revision=60514
- Fix pointer fix-up of domain name, user name and password. This failed for null pointers.
- Update the dispatch table and create a logon session as part of the user logon.
svn path=/trunk/; revision=60513
- leaner build part 9 of X
- Get rid of NV_texture_rectangle, ARB_ES2_compatibility, NV_primitive_restart extensions and texture compression.
CORE-7499
svn path=/trunk/; revision=60512
- leaner build part 8 of X
- Get rid of the support for opengl ES and their extensions, the ARB_depth_clamp extension and the program implementation of the fixed function pipeline.
CORE-7499
svn path=/trunk/; revision=60511
- leaner build part 6 of X
- Get rid of the ARB_blend_func_extended, ARB_explicit_attrib_location, ARB_seamless_cube_map, ARB_texture_multisample extension EXT_provoking_vertex, EXT_vertex_array_bgra and AMD_seamless_cubemap_per_texture extensions
#CORE-7499
svn path=/trunk/; revision=60505
- leaner build part 5 of X
- Fix build from part 4 (damn you tortoiseSVN)
- Get rid of the ARB_instanced_arrays extension
svn path=/trunk/; revision=60504
- leaner build part 4 of X
- Get rid of ARB_occlusion_query, ARB_occlusion_query2, ARB_sync, ARB_transform_feedback2, EXT_draw_buffers2, EXT_transform_feedback, EXT_timer_query, ATI_fragment_shader (this time for real) and NV_conditional_render extensions
svn path=/trunk/; revision=60503
* Sync with Wine 1.7.1. It was synced just recently (8 years ago) but there's not harm in syncing it again ;)
CORE-7469
svn path=/trunk/; revision=60500
- leaner build part 3 of X
- Get rid of ARB_depth_texture, ARB_sampler_objects, ARB_shadow, ARB_shadow_ambient, ARB_texture_rgb10a2ui, ARB_timer_query and EXT_texture_sRGB_decode extensions
svn path=/trunk/; revision=60496
* Fix MSVC build.
* Speedup build.
* Pierre, can you please consult with me before stepping on my toes (with improper syncs) ?
svn path=/trunk/; revision=60471
Sync with Wine 1.7.1
CORE-7469
Tests for EnumProcessModules() have been skipped since they cause stack corruption
ROSTESTS-122
svn path=/trunk/; revision=60470
- A BCB's cache segment list is sorted -- so actually make use of that property during list traversal
- Fix inverted wait condition in CcZeroData
- Correct offset check in CcSetFileSizes
CORE-7491
svn path=/trunk/; revision=60457
* Show the status messages only in -V mode.
* Improve error messages by marking them as ERROR/WARNING.
* Brought to you by David Quintana.
CORE-7477 #resolve #comment Committed in r60449. Gracias.
svn path=/trunk/; revision=60449
- Correctly return STATUS_TIMER_RESOLUTION_NOT_SET if the resolution was not changed in NtSetTimerResolution. Patch by Aleksandar Andrejevic.
CORE-7387
svn path=/trunk/; revision=60407
- Test that NtSetTimerResolution appropriately returns STATUS_TIMER_RESOLUTION_NOT_SET. Patch by Aleksandar Andrejevic.
CORE-7387
svn path=/trunk/; revision=60406
- Fix RtlGetLengthWithoutTrailingPathSeperators declaration
CORE-7482 #comment Hermès, feel free to add back your define thingie.... I just need this to work right now ;)
svn path=/trunk/; revision=60403
- Protect against invalid ThreadContext pointer in PspCreateThread. Spotted by Aleksander Andrejevic.
CORE-7252
- Fix MSVC warning in HdlspDispatch
svn path=/trunk/; revision=60401
Implement and export RtlGetLengthWithoutTrailingPathSeperators (aka. RtlGetLengthWithoutTrailingPathSeparators) (needed for win2k3's basesrv.dll).
Patch by David Quintana, where I simplified the loop (and reduced the number of local variables).
CORE-7482 #comment Function committed in revision 60348, thanks ;)
svn path=/trunk/; revision=60348
[CMAKE] Use the same MSVC build flags for x64 as for x86
[SMLIB] Fix MSVC warnings
[MODULES] Don't include optional modules on x64
[NTOSKRNL] Add some missing globals and definitions for x64
[CSRSRV] Fix an MSVC warning
svn path=/trunk/; revision=60325
No need now to declare a NTSTATUS ExceptionStatus; variable to be able to use KmtStartSeh() / KmtEndSeh() macros; this is done automagically.
svn path=/trunk/; revision=60320
- No need now to declare a NTSTATUS ExceptionStatus; variable to be able to use StartSeh() / EndSeh() macros; this is done automagically.
- Use explicitely unicode macros where it's needed.
svn path=/trunk/; revision=60319
Introduce a "apitest.h" header gathering special things for apitests (SEH macros, wine/test.h inclusion, and so on...).
svn path=/trunk/; revision=60313
- Fix disabling impersonation in PsDisableImpersonation, and
- Fix how we do restore impersonation in NtOpenThreadTokenEx.
Patch by Thomas Faber,
CORE-7476 #comment Patch committed in revision 60301, thanks :). Please retest the bug.
svn path=/trunk/; revision=60301
- Disable un-used mesa features (ATI/NV programs) for a leaner build
- Print a fixme instead of asserting in software version of wglGetProcAddress
svn path=/trunk/; revision=60300
Set the session ID to the process' associated PEB (introduced in revision 43476, the code erratically disappeared in revision 57011 when Alex fixed sessions).
svn path=/trunk/; revision=60299
- Fix Job object session ID setting and comparison; fix a list initialization.
- Correct some comments.
- As Alex noticed it 7 years and 2 months ago, in revision 23197, the ProcessSessionInformation case in the NtSetInformationProcess API doesn't set a new session ID for the given process anymore (checked by myself too), because it is set once and for all at process creation time and is stored inside the Process->Session structure managed by MM. Therefore fake changing it: we just return success if the user-defined value is the same as the session ID of the process, and otherwise we fail.
svn path=/trunk/; revision=60298
- Implement PsGetCurrentThreadProcess, PsGetCurrentThreadProcessId and PsGetCurrentThreadTeb based on their non-current versions.
- Fix PsGetThreadSessionId to call MmGetSessionId.
- Fix the return value type of PsGetJobSessionId.
- Remove an unneeded cast.
svn path=/trunk/; revision=60296
Stubplement BaseSrvNlsLogon and BaseSrvNlsUpdateRegistryCache needed by Windows-2k3's WINSRV.DLL . Their return value types are unknown, but the number of parameters was obtained by reading http://wcwp.googlecode.com/svn/trunk/wcwp/bin/masm32/include/basesrv.inc .
svn path=/trunk/; revision=60287
Stubplement IsSETEnabled, needed when testing WINSRV.DLL from Windows 2k3 SP1/2.
(this function determines whether the Shutdown Event Tracker is enabled, see http://undoc.airesoft.co.uk/user32.dll/IsSETEnabled.php for more information).
svn path=/trunk/; revision=60286
- remove reference to the not-used not-built-anymore mesa32 opengl ICD
Thank you, our relationship was great, but somehow ReactOS matured and you are not in the plan anymore. Fare thee well.
svn path=/trunk/; revision=60284
- Blow up the old implementation and enable the new one
- Software implementation now relies on mesa in the form of a mesa "driver", no longer on osmesa (which inspired the current implementation)
- Add nice and fast x86 trampolines to forward opengl API calls to the current thread's dispatch table
Some tiny bits are missing, but the DLL is fully functional, so let's use it.
svn path=/trunk/; revision=60281
- Revert r60250 (which was here just to test something in all of the test bots).
- Display which file we wanted to execute, when seeing that it wasn't an executable file nor a .bat or .cmd file.
svn path=/trunk/; revision=60272
Fix caption on a button. Patch by Lee Schroeder.
I changed IDC_USER_RESET to IDC_USERS_RESET as it is more consistent.
CORE-7475 #resolved #comment Committed in r60262. Thanks.
svn path=/trunk/; revision=60262
- Return process pool quota on free
- Do not use POOL_QUOTA_FAIL_INSTEAD_OF_RAISE on non-quota allocations
- Welcome back, device installation wizard
CORE-7459 #resolve
svn path=/trunk/; revision=60230
- NetLocalGroupAdd: Delete the newly created alias if setting alias information fails.
- NetUserGetGroups, NetUserGetInfo and NetUserGetLocalGroups: Return NERR_UserNotFound if no matching user was found.
svn path=/trunk/; revision=60199
- forward glFlush to glFinish for single buffered formats
- import wglUseFontBitmaps and wglUseFontOutlines from wine 1.7.2
- Remove a useless call to OSMesaMakeContextCurrent
- Add a few debug prints
svn path=/trunk/; revision=60181
- Call DrvSetCallbackProcs when initializing the ICD.
Prototype taken from mesa ICD, functionality documented by one of them.
svn path=/trunk/; revision=60171
Introduce a new opengl32 implementation, the 3D library with better perspectives (tm), featuring:
- A new software rendering implementation on top of osmesa.
- Rendering to bitmaps
- Thread safety.
- A try to be really compatible with ICD DLLs (WIP)
- Other cool stuff, check log for details.
WIP, the SW implementation already works.
svn path=/trunk/; revision=60150
- Ignore C++ redirects again because they breaks msvcrt
CORE-7465 #resolve
[FRAMEDYN]
- Work around the lack of C++ redirects
svn path=/trunk/; revision=60135
Use NetLocalGroupGetMembers level 2 instead of level 1 in order to display the domain names of well-known groups in the group membership list. Skip the domain name for other account types.
svn path=/trunk/; revision=60134
NetLocalGroupGetMembers:
- Do not try to add the size of a domain name to the return buffer if the domain index is negative.
- Do not try to copy a domain name to the return buffer if the domain index is negative.
- Move the write pointer after writing the domain name.
svn path=/trunk/; revision=60125
Add warning C4090 (different 'modifier' qualifiers -- for C programs only; for C++ programs, the compiler error C2440 is issued --) as an error (usually, when I hit this warning, it means that I'm doing an error in my code...). This warning can be caused when a pointer to a const or volatile item is assigned to a pointer not declared as pointing to const or volatile.
This warning is already treated as an error by GCC...
svn path=/trunk/; revision=60100
* Introduce wpp as a cross compiling lib, and rename out host one as wpphost.
[WIDL]
* Update the link reference to the host wpp.
[PSDK]
* Update d3d9types.h and import d3d11shader.h and d3dcompiler.h from Wine.
[DXGUID]
* Introduce dx10guid to contain some GUIDs needed only by Wine DirectX modules.
[D3DCOMPILER_43]
* Import from Wine 1.7.1.
svn path=/trunk/; revision=60098
- npipe.c:
* Use RtlPrefixUnicodeString instead of RtlPrefixString with casts.
* Check results of RtlCreateUnicodeString and RtlPrefixUnicodeString, return FALSE if they fail and set an appropriate last error.
* Free the string created with RtlCreateUnicodeString instead of leaking memory.
* Fix a path type check (RtlPathTypeUncAbsolute instead of RtlPathTypeRootLocalDevice).
- path.c: I prefer seeing the default case at the end of the switch (no functional changes).
[NTOS:MM]
- Use RtlPrefixUnicodeString instead of RtlPrefixString with casts.
[RTL]
- RtlPrefixString acts on general PSTRINGs (which are not UNICODE).
- Remove extra spaces between names of functions and parentheses.
- Clarify the fact that we run over characters.
svn path=/trunk/; revision=60085
- Enable qmgr tests again. They all get skipped now instead of crashing. When npfs_new manages to run these, we know it's really working well ;)
CORE-6536
svn path=/trunk/; revision=60079
[NPFS-NEW]: Actually implement NpCancelWaiter instead of making it ASSERT.
[NPFS-NEW]: Critical fixes to NpAddWaiter and NpWaitForNamedPipe to fix logic flaws.
NPFS-NEW now behaves without any visible regressions, and exhibits only 2 failures in the kernel32 pipe winetest -- vs 120+ failures with the current NPFS driver. It has 0 ntdll pipe failures, and 0 kmtest pipe failures.
svn path=/trunk/; revision=60070
[NPFS-NEW]: Fix busted up NpGetNextRealDataQueueEntry and fix its usage.
These changes don't appear to "fix" any tests, but they were real bugs. Thanks to ThFabba.
svn path=/trunk/; revision=60068
- Zero out the Int10 Bios call arguments structure before calling Videoprt Int10CallBios
- Properly check for VESA BIOS return value from such calls
- Use VGA registers to update the palette when possible.
Now bochs goes up to 3rd stage when using this driver in conjunction with framebuf_new.
svn path=/trunk/; revision=60063
[CSRSRV]: CsrInsertThread should call this API to make sure the thread isn't dead already. Update the callers to handle this possible failure.
This behavior was obeserved in Windows' CSRSRV.DLL. It now works in ReactOS as well.
svn path=/trunk/; revision=60059
[NTOSKRNL]: Make MmCreateSection do the correct access checks and parameter checks, just like ARM3 does. For example, asking for PAGE_EXECUTE on a non-image file no longer requests SYNCHRONIZE and FILE_READ_DATA...it asks... FILE_EXECUTE. Cause you know... that's what the caller..wants. Anyway, this, among other things, fixes LdrValidateImageChecksum (and those annoying errors 0xC0000022 in the logs). SMSS is now checking the checksums of Known DLLs just like before (in Win7 they stopped doing this to improve boot performance, lol). It also makes Windows' SMSS happy.
svn path=/trunk/; revision=60055
Use _SEH2_YIELD when exiting from a _SEH2 block via a return or a goto (otherwise --> bug in the stack).
This limitation will be removed in SEH3, but it's not used at the moment.
svn path=/trunk/; revision=60052
Don't hardcode the first parameter of the bugchecks. Instead, I introduce a NpBugCheck macro and file identifiers
(their names conform to the existing name convention of the driver) so that, when bugchecking, we report as the
first parameter of the NPFS_FILE_SYSTEM bugcheck the file ID (in the high word) and the line (in the low word)
where the bugcheck was emitted.
See the MSDN article "Bug Check 0x25: NPFS_FILE_SYSTEM" - http://msdn.microsoft.com/en-us/library/windows/hardware/ff557436(v=vs.85).aspx
for more information.
Inspired from the existing ext2 driver.
Should be done for the other filesystems (FAT, NTFS, CDFS, Redirector, Mailslot, etc...).
svn path=/trunk/; revision=60051
[NTOSKRNL]: Fix OPEN_PACKET definition. Also, allocate it from the pool in IoCreateFile, instead of the stack (Windows does too).
[NTOSKRNL]: IoCreateFile should only be setting IO_STATUS_BLOCK Information/Status if EA Buffer validation *Fails*, not if it succeeds!
svn path=/trunk/; revision=60038
- Fix MSVC build
- Fix some name mangling issues
- Add stub libraries to make the dll actually usable. The GCC alias library is still broken though.
svn path=/trunk/; revision=60037
download.microsoft.com/download/5/7/7/577a5684-8a83.../drvqa.doc". Fix a few incorrect exclusive vs shared lock acquires.
svn path=/trunk/; revision=60034
* Fix the locking in MiQueryBasicInformation to cover ARM3 too, not just RosMm. This makes sure we don't change the address space while querying it (or vice-versa).
* Don't attempt to query information for a terminated process (fixes some kernel32 loader winetests, matches Windows behavior).
* Brought to you by Alex Ionescu.
svn path=/trunk/; revision=60021
* Return the proper status when we attempt to illegally commit non-ARM3 section. We hit this assert with some kernel32 winetests (mainly loader and virtual). Brought to you by Alex Ionescu.
svn path=/trunk/; revision=60016
Use a correct return variable for RtlCreateUnicodeStringFromAsciiz. Advice: read the documentation before using functions...
svn path=/trunk/; revision=60014
- Allocate buffers for account and domain names in the well-known sid list instead of using pointers to strings.
- Add a string load routine and convert all hard-coded SID names to resources.
A german translation will follow soon.
svn path=/trunk/; revision=60013
- Fix header formatting plus windows headers inclusion.
- RtlCreateUnicodeString returns booleans, not ntstatuses, so fix the code appropriately.
svn path=/trunk/; revision=60012
* Import Wine's (broken) winioctl.h.
* Remove FILE_FS_VOLUME_INFORMATION from winternl.h. It doesn't belong there.
[NTDLL_WINETEST]
* Be more specific about winioctl.h inclusion.
svn path=/trunk/; revision=60005
* Be more specific about the commctrl.h inclusion.
* We no longer need to add include/reactos/wine as a global inclusions folder.
svn path=/trunk/; revision=60004
Fix string size to store GPT GUIDs.
This was causing a buffer overflow (with ending null char) and thus a stack corruption.
The side effect of the stack corruption was that the debug code (display) was looping
forever while attempting to read partition table making ntoskrnl unable to boot with
a machine where there's a GPT disk.
Kernel is now able again to handle GPT disks (and they can be used again in user-land).
This was magically hidding before r59923 or by disabling NDEBUG. Lovely Heisenbugs :-).
svn path=/trunk/; revision=60003
[NPFS-NEW]: Implement QueryVolume, QuerySecurity, SetSecurity. Everything but Directory Query, Fast I/O, and a few rare FSCTLs is implemented now. The former two will come in an upcoming commit.
[NPFS-NEW]: Major cleanup in the way some member variables were being addressed. Reference them as array members based on the correct FILE_PIPE defines from now on. Also fix a lot of formatting issues. Fix a bunch of bugs that were found. Use FILE_PIPE_SERVER_END and FILE_PIPE_CLIENT_END intead of a BOOLEAN. Use TRUE/FALSE/STATUS_SUCCESS/NULL/etc when needed intead of 0/1. The code formatting can/should still be improved, but this was a big help.
svn path=/trunk/; revision=60000
* Beginnings of windows-compatible NPFS driver. Still rough WIP, supports CreateNamedPipe and Create IRPs for now only. This is mainly to lay out all the structures (VCB, DCB, FCB and CCB). Work on read/write (and hence data queue management) is next. Brought to you by Alex Ionescu.
svn path=/trunk/; revision=59996
* Improve Russian localization. Patch by Alex Gorgurov based on the work of jperm (jaroslaff111 @at@ mail .dot. ru).
CORE-7381 #resolve #comment Committed in r59977. Thank you all.
svn path=/trunk/; revision=59978
* Correct AD and B2 characters of codepage 437. By Erdem Ersoy.
CORE-7432 #resolve #comment Committed in r59976. Thanks.
svn path=/trunk/; revision=59976
* "Fix" the VS build when the default code page is a MBCS (Chinese version). For some reasons, the MSVC resource compiler ignores the #pragma code_page inside the included nls files. Brought to you by Yuntian Zhang.
CORE-7420 #resolve #comment Committed in r59975. Cheers.
svn path=/trunk/; revision=59975
* Improve the German translation, fix the position of some new strings that are larger than English originals and fix some formatting. By Robert Naumann.
CORE-7440 #resolve #comment Committed in r59974. Thanks.
svn path=/trunk/; revision=59974
- Use the new function SampSetObjectAttributeString to write strings to the registry. Handle empty strings properly.
- Fix SampGetObjectAttributeString to handle empty strings properly as well.
svn path=/trunk/; revision=59964
* Implement an undocumented flag for the rebar control. This flag is used by browseui and is needed to show the explorer window properly. Should be sent Upstream. Brought to you by Giannis Adamopoulos (Smiley).
* Update the sync diff.
svn path=/trunk/; revision=59962
* Stretch/Skew dialog fully implemented (skewing not yet functional), please check translations
* pre Windows Vista MSPaint palette selectable via menu entry
* Attributes dialog supports setting width and height in inches and cm also
* drawing functions improved
* some variables grouped into structs
* Changed SendMessage(... WM_PAINT ...) into InvalidateRect(...), this is the way it should be and it fixes half of the repainting bugs
svn path=/trunk/; revision=59954
Remove operator LPWSTR() in favor of operator LPCWSTR() const (likely to fix its export ;-))
Add missing operators implementations as inline
svn path=/trunk/; revision=59947
- Improve SamRegCloseKey and fix all calls to it accordingly. Also replace all calls to NtClose by calls to SampRegCloseKey.
- Add a resource to protect the Samr functions from concurrent access.
svn path=/trunk/; revision=59945
Partplement framedyn.dll
So far, only CHString class is implemented in it
Regarding CHString class implementation:
It has been implemented matching Windows behavior and bugs
It might not be really nice at some points but this ensures
compatibility with applications relying on it.
As a side note: this might explain why this API was abandonned after w2k3...
Regarding the DLL itself:
Its implementation into ReactOS allows systeminfo.exe application from w2k3 to
load and start initialization into ReactOS. It stops working later on with some
IDispatch error.
The DLL cannot be used to build any application against framedyn.dll with our "default" BE (read with G++).
Only MSVC mangled name are exported so far (as on Windows ;-)) thanks to aliasing. This is why there are two spec files.
This makes G++ unable to link with it though. This is the reason why there are no framedyn_apitests so far.
Furthermore, the DLL only have exports for x86 and none for x64 for the moment.
Any help is welcome for having exports for x64 target and to be able to have aliasing for G++ (from its mangled names
to MSVC ones).
svn path=/trunk/; revision=59940
Add two headers: chstring.h and provexce.h
They are used for framedyn.dll stuff, for instance
So far, the CHString class is not fully populated. It is only
populated with exported stuff from framedyn.dll
svn path=/trunk/; revision=59939
* Don't overwrite the MZ header when there are no long section names.
* Correct an error including 4 more bytes than needed in the coff strings.
* Brought to you by Arty.
svn path=/trunk/; revision=59938
- Convert some language resource files into UTF-8 without BOM (aka. ANSI as UTF-8 with Notepad++).
- Improve some French translation.
- Fix Czech translation, thanks Radek :)
(Addendum to r59924 and r59925)
svn path=/trunk/; revision=59937
[NTDLL-KERNEL32-BASESRV-WINSRV]: Specify by hand (hackz for MSVC builds) that the dll will be a "Console DLL" (ie. not a native one nor a Gui DLL).
[BASESRV]: Explicitely set the DLL entry point to DllMain (unusued).
[WINSRV]: Explicitely set the DLL entry point to DllMain (unusued) AND REMOVE usage of msvcrt (that might pose problems when testing with Windows msvcrt etc...) and use libcntpr instead.
Thanks to Amine for having helped me in solving a problem with delayed imports.
svn path=/trunk/; revision=59933
Implement RtlDefaultNpAcl, needed for giving a default security to named pipes. Makes Win2k3 kernel32 happy when one creates named pipes for SCM and so on.
Getting the SID of the caller is done as described in http://www.osronline.com/article.cfm?article=50 in "Extracting the SID from the Token".
svn path=/trunk/; revision=59928
- Improve the stub for CAddressEditBox::SetOwner to make the rest of browseui happy for now
- In CShellBrowser::Initialize browse to the pidl that is passed as parameter instead of always browsing to the desktop folder
- Fix a bug in atl class CContainedWindowT::DefWindowProc that was calling the window proc with an invalid hwnd.
svn path=/trunk/; revision=59927
- FsRtlCopyWrite: Fix typos in local var names and comments.
- FsRtlCopyWrite: Fix copypasta in a call to FastIoCheckIfPossible: wait flag shouldn't be always TRUE in this case (it's determined by Wait parameter).
- FsRtlCopyRead: Fix updating of CurrentByteOffset.
- FsRtlAcquireFileForCcFlushEx / FsRtlReleaseFileForCcFlush: Handle the case when FastIO callback may fail and FsRtl still needs to act as if FastIO callback would be missing at all.
- Implement FsRtlAcquireFileForModWriteEx / FsRtlReleaseFileForModWrite thanks to Rajeev Nagar's book.
- Now all necessary FsRtl locking/unlocking mechanisms exist.
svn path=/trunk/; revision=59926
* Remove some Wine specific text and introduce a tiny update to the German translation. By zehnvor.
CORE-7221 #resolve #comment Committed in r59924. Danke.
svn path=/trunk/; revision=59924
- Halfplement CDesktopBrowser::BrowseObject. Now when the user tries to open a folder from the desktop we will try to create a new explorer window.
- ps: this affects only explorer_new and the rest of the shell is still not working well enough to actually show the new window
svn path=/trunk/; revision=59918
- Implement two types of FsRtl locking functions: exclusive lock and Cc flushing lock, along with their releasing counterparts, without the filter callbacks support. These functions are unused in trunk now but would be needed by proper Cc/Mm/IFS in future.
svn path=/trunk/; revision=59889
- Fix nls.c header information.
- Rename BasepUnknown to BasepDebugProcess according to j00ru's http://j00ru.vexillium.org/csrss_list/api_list.html#Windows_2k3 and what Alex_Ionescu committed in r59879 (deprecated api).
svn path=/trunk/; revision=59884
[BASESRV]: Implement BaseSrvNlsCreateSection, which is needed by Windows kernel32.dll. Also implement the delay-loading functionality it needs.
svn path=/trunk/; revision=59879
[NDK]: Fix definition of a global flag.
[RTL]: RtlpCreateUserStack: 1) If the image is invalid, bail out. 2) If the stack commit is higher than reserve, adjust reserve. 3) After allocating a guard page, the stack limit is now ABOVE the guard page, not BELOW it (stack grows backward!).
[RTL]: Remove the hack which always Commited the "StackReserve" value. Threads now have a 4-64KB stack, instead of a 1MB stack.
[NTOSKRNL]: Implement MiAccessCheck and MiCheckForUserStackOverflow, which handle guard page + stack expansion.
[USER32]: Because threads now correctly run with a smaller stack than usual (and expand as needed), remove some checks in user-mode callbacks which forced larger stacks.
svn path=/trunk/; revision=59868
[RTL]: Make the Wine RtlActivationContext* APIs use the native RTL flags, not the Win32 flags.
[KERNEL32]: Separate Wine-specific ActCtx code from NT-compatible ActCtx code, and reimplement the latter. Now all ActCtx APIs except CreateActCtx (which is a mess on Windows) are compatible with the real NT RtlActivationContext APIs in terms of flags.
[KERNEL32]: Fix the hacks which were sending Win32 flags to the NT Native Rtl* functions.
svn path=/trunk/; revision=59866
[CSRSRV]: Fix definition of CSR_API_CONNECTINFO structure. It is now compatible with Server 2003. Also, set the DebugFlag.
svn path=/trunk/; revision=59864
* Improve resource files layout to make it consistent with the rest of our codebase. By Erdem Ersoy.
CORE-7414 #resolve #comment Committed in r59863. Thanks.
svn path=/trunk/; revision=59863
[USER32]: Initialize the KernelCallbackTable when loaded in GUI process. Also, store it statically instead of requiring a heap allocation (just like Windows).
svn path=/trunk/; revision=59862
* Introduce the support for organizing the solution into a hierarchy of folders that matches our codebase layout.
* You can enable this feature by adding -DUSE_FOLDER_STRUCTURE=1 to your configure phase (the VSSolution one).
* Based on a patch by Yuntian Zhang with my improvements.
CORE-7412
svn path=/trunk/; revision=59860
[NTOSKRNL]: Gut out almost all the fields in the ReactOS-specific MM_IMAGE_SECTION, and replace them with the NT SECTION_IMAGE_INFORMATION structure instead. Make NtQuerySection simply return a copy of these fields (as on Windows).
[NTOSKRNL]: Update the PE loader code to now store information in SECTION_IMAGE_INFORMATION. Also store LoaderFlags and DllCharacteristics, which were not stored/returned to users before (in NtQuerySection).
[NTOSKRNL]: An entrypoint of NULL should also set ImageContainsCode to FALSE.
[NTOSKRNL]: Implement MmGetImageInformation, which is used by NtQueryInformationProcess(ProcessImageInformation). Also implement this latter info class.
[NTOSKRNL]: Delete ps_i.h, nobody uses this anymore.
svn path=/trunk/; revision=59859
[NTOSKRNL]: MmCreatePeb should correctly fill out the Heap PEB parameters.
[NTOSKRNL]: MmInitSystem and mminit.c should correctly initialize and hold the Heap Tuning Parameters.
[NTOSKRNL]: CmControlVector should read the registry Heap Tuning Parameters into the real Mm variables, instaed of "Dummy".
This removes heap hacks and makes Windows NTDLL happy.
svn path=/trunk/; revision=59857
- Add brackets around "case XXX:" so that I'm able to (un)fold regions of code when debugging and reading.
- Temporarily skip AppCompat functionality added by Alex, in order to "fix" (read: hack-fix) launch of .bat/.cmd files. Indeed, when .bat/.cmd files get started with the CreateProcess function, a call to NtCreateSection fails with status STATUS_INVALID_IMAGE_NOT_MZ, as expected (line 2952). But the new AppCompat code (lines 3028 and 3031-3033 and following, and 3114), executed whenever the status code from NtCreateSection is STATUS_SUCCESS or STATUS_INVALID_IMAGE_NOT_MZ or something else, overwrites the status code by other values, so that, after we return to the main code path (lines 3174 and following), the status code isn't STATUS_INVALID_IMAGE_NOT_MZ anymore but STATUS_SUCCESS or whatever, and then, we fail to run the .bat/.cmd file (that should be done at lines 3314-3316 and following).
To Alex_Ionescu: Have a look at this and fix it properly!!
svn path=/trunk/; revision=59855
***NOTE THAT I ONLY DID THIS FOR UNICODE. I DID NOT BOTHER TO FIX THE ANSI VERSION. ERIC KOHL, PLEASE REVIEW & FIX AS APPROPRIATE***
svn path=/trunk/; revision=59843
* Check more parameters in MultiByteToWideChar() and WideCharToMultibyte(). By Marcus Boillat.
* Fixes 4 kernel32:codepage tests.
CORE-7411 #resolve #comment Committed in r59839 with formatting fixes. Thanks.
svn path=/trunk/; revision=59839
[SACDRV]: Cleanups and fixes. You can now use "Shutdown", "crashdump" and "restart" in the !SAC and the commands work as expected.
[SACDRV]: Implement GetTListInfo and DoTlistCommand. PrintTListInfo is next to actually show the output.
svn path=/trunk/; revision=59838
[CMD]
The default command prompt is $p$g. But still keep the information line by setting a system environment variable "PROMPT" set to $i$p$g. Therefore, if you are tired of it, either remove the environement variable or redefine it to whatever you want. In a current command-line session, to restore the default command prompt, enter "prompt" without any other parameter.
svn path=/trunk/; revision=59837
Remove the help resources moved to the help utility.
@ gigaherz (a.k.a. David Quintana): Don't worry! Your changes to fr-FR.rc were already moved to help.exe in the previous commit :D
svn path=/trunk/; revision=59833
Add a help.exe utility to replace the old built-in command "help" in cmd.exe (i.e. do it the Win2k3 way).
This way, if somebody runs a personalized command-line environment which provides its own help command, one can use the personalized help command and not the standard one (e.g. the "help" command of RosBE).
Adapted by myself from a patch by Lee Schroeder.
CORE-5701 #resolve #comment Committed in revision 59832, thanks :) I use a trick to be able to compile the utility (use: ninja cmd_help) because doing "ninja help" has a signification in ninja (signaled by AmineKhaldi).
svn path=/trunk/; revision=59832
[SACMSG]: Re-commit the .mc file with CRLF endings, this is essential for correct output.
[SACDRV]: Fix bug in VTUTF8ChannelAnsiDispatch (freeing stack memory with pool API).
[SACDRV]: Fix the way in which the cell buffer was being computed. This way works (tm) and is also much easier to read.
[SACDRV]: Fix bug in VTUTF8ChannelIRead (incorrect char vs byte sizing).
VT-UTF8 output and input works now in the !SAC channel. There's still some lurking bugs, however, such as when hitting the 24th row (probably an off-by-one memcpy).
svn path=/trunk/; revision=59831
WANTED: The fact that the SAC developers cherry-picked *which* ANSI standard and VT standard they were going to follow, threw in ANSI.SYS compatibility, and then added a bunch of bugs, makes me wonder if real people use SAC on Windows...
svn path=/trunk/; revision=59826
[SACDRV]: Implement VTUTF8ChannelOEcho.
[SACDRV]: WIP-lement VTUTF8ChannelConsumeEscapeSequence. Have to do some reading up on ANSI to get this right.
svn path=/trunk/; revision=59824
- Fix all bugs that keep MMC from starting and terminating properly.
- Implement an MDI client window.
- Add menuitem "File/New" in order to create a new console window (MDI child).
- Add a "large" menu that is used when console windows are visible.
svn path=/trunk/; revision=59823
Add system.ini into C:\ReactOS.
Patch by Lee Schroeder.
CORE-7402 #resolve #comment Committed in revision 59806, thanks :)
svn path=/trunk/; revision=59806
We aim at being compatible with Windows Server 2003... Do it better! Use the \GLOBAL?? dos-devices object directory instead of \??, as used in Windows NT and 2000 (which becomes per-session in Windows >= XP), but add a temporary hack (i.e. create a symbolic link \?? <---> \GLOBAL??) since we don't support yet Ob device mappings which are needed for this mapping, in particular.
As a side-effect, fix starting of DeviceTree v2.30 on ReactOS. Now it works correctly, as on Win2k3 :)
CORE-6572 #resolve #comment Finally fix loading of the objinfo driver, which failed at creating a symbolic link in \GLOBAL??\ for its device.
svn path=/trunk/; revision=59803
* Improve resource files layout to make it consistent with the rest of our codebase. By Robert Naumann.
CORE-7397 #resolve #comment Committed in r59797. Thanks.
svn path=/trunk/; revision=59797
Fix usage of the 2nd parameter of NtFlushVirtualMemory, in the FlushViewOfFile file. This fixes the creation of "self-extracted" files from executables (e.g. DeviceTree utility from OSR or some Sysinternals tools).
CORE-6572 #comment Partly fixed in revision r59793. Now the objinfo.sys file is created without corruption, but there are problems loading the driver itself...
This fixes a bug introduced in revision 775 about 14 years ago!
Many thanks to Oláf for having debugged DeviceTree and oriented me to the real problem :D
svn path=/trunk/; revision=59793
*Just* clarify some parts of the code and argument names of functions, and do not hardcode constant values; use #defines instead.
svn path=/trunk/; revision=59791
- Move NtQueryTimerResolution and NtSetTimerResolution from ke/clock.c to their proper place in ex/time.c
- Simplify NtQueryTimerResolution and implement NtSetTimerResolution based on the patch of Aleksandar Andrejevic.
CORE-7387 #resolve #comment NtSetTimerResolution function committed in revision 59790, thanks :D
svn path=/trunk/; revision=59790
Add a test for NtQueryTimerResolution and NtSetTimerResolution, by Aleksander Andrejevic.
See CORE-7387 for more information.
svn path=/trunk/; revision=59786
Use some existing #define'd constants.
[CSRSRV-BASESRV]
- Add CSR version define (based from BASESRV version define).
- Add missing BASESRV structures, taken from https://code.google.com/p/ontl/source/browse/branches/devel/ntl/nt/csr.hxx (OpenNT Native Template Library).
svn path=/trunk/; revision=59779
[SACDRV]: Implement VtUtf8 case in ChannelInitializeVTable.
[SACDRV]: Implement DoHelpCommand, reformat concmd.c to standards.
[SACDRV]: ConMgrInitialize shoudl setup the SAC channel as VtUtf8, not Raw. I guess it was set to Raw since VtUtf8 wasn't yet implemented, however this breaks the command parsing since it expects WCHAR's. Make a note of this, and temporarily hack ConMgrSerialPortConsumer to work with CHAR's from a Raw channel.
[SACDRV]: Implement ConMgrProcessInputLine, which calls out the appopriate helpers.
[SACDRV]: Fixes to parsing in ConMgrSerialPortConsumer
[SACDRV]: Document, reformat, and fix some of the bugs in the RawChannelI* commands.
[SACDRV]: Implement simple (ANSI) case of SacTranslateUtf8ToUnicode.
[SACDRV]: Implement SacFormatMessage and GetMessageLineCount.
[SACDRV]: Start implementing VT-UTF8 support. Input routines are done, output routines are still WIP.
[SACMSG]: Fix the messages in the .MC file. Stuff is now being output correctly. If using Putty, make sure to turn on "Implicit CR in every LF" in Settings->Terminal.
svn path=/trunk/; revision=59778
* Add a flag (-s) to pass the source folder. This allows it to set the debug file paths relatively to that source folder. Brought to you by Arty.
[CMAKE]
* Leverage the new rsym flag. The rossym file paths are no longer absolute.
svn path=/trunk/; revision=59775
[NTOSKRNL]: Implement InbvPortPollOnly and InbvPortGetByte.
[NTOSKRNL]: Implement HeadlessCmdClearDisplay and HeadlessCmdGetByte.
[SACDRV]: Implement the TimerDpcRoutine which calls HeadlessCmdGetByte. We now consume characters in the EMS port.
[SACDRV]: Implement ConMgrSerialPortConsumer. We now do full VT-100 input parsing. DEL, BS, TAB, SPACE all work. Pressing ENTER results in an ASSERT in ConMgrProcessLine as expected.
svn path=/trunk/; revision=59772
SamSetInformationUser.UserAllInformation: Pass hashed passwords to SamrSetInformationUser.
[SAMSRV]
SampSetUserAll:
- Get fixed user data at the start of the function and set it only if it has been modified.
- Set user password hashes.
svn path=/trunk/; revision=59770
- NetUserAdd: Open the accounts domain with DOMAIN_READ_PASSWORD_PARAMETERS access. This is needed in order to check whether the password matches the password requirements of the domain.
- Start implementing NetUserGetGroups.
svn path=/trunk/; revision=59759
- Do not use a internal section object structure type, it's just not necessary and win32k should not ever need to access its fields directly.
svn path=/trunk/; revision=59733
[SACDRV]: implement SacTranslateUnicodeToUtf8.
[NTOSKRNL]: implement HadlessCmdPutData.
EMS bringup is now functional:
"
Computer is booting, SAC started and initialized.\n\nUse the \"ch -?\" command for information about using channels.\nUse the \"?\" command for general help.
SAC>%0
"
svn path=/trunk/; revision=59732
[SACMSG]: SAC wants the message tables as Unicode, but the CMakeList has an obscure comment that Unicode MC needs "testing". Well, I'll be the first to test it and confirm it works -- implement a UNICODE_SOURCE_REALLY to get Unicode-mc.
[SACMSG]: Add a few more constants.
[SACDRV]: Implement InitializeMachineInformation.
[SACDRV]: Fix countless bugs. Now the entire driver initializes up to UTF8EncodeAndSend, which is unimplemented. We're almost there!
svn path=/trunk/; revision=59718
[HIVESYS]: Fix double-addition of "nmidebug". One of those should have been "sacdrv".
[FREELDR]: Fix bugs in WinLdrSetupEms which caused an invalid HEADLESS_LOADER_BLOCK to be created.
[FERELDR]: Move WinLdrSetupEms in LoadWindowsCommon, so that setupldr can use EMS too.
svn path=/trunk/; revision=59716
- Disable object logging now that all the deadlocks, leaks, double-frees, and use-after-frees visible in our test suite are fixed in TCP/IP
svn path=/trunk/; revision=59709
- Fix a nasty bug preventing any of the non-default interface's NCEs from being selected
- Fix a bug preventing loopback NCEs from being found (fixes hang in ws2_32:sock winetest)
svn path=/trunk/; revision=59708
- Add logging of address files and connections (on temporarily for testing changes)
[LWIP]
- Drastically simplify the closing state machine
- All connection objects (and as a result address files too) are now getting properly reaped now
- Tested with Firefox and Abyss Web Server
svn path=/trunk/; revision=59705
- Define i386 on x86 MSVC builds
- Probably fixes the infamous MSVC networking issues caused by tcpip.h assuming it was a big-endian platform and never byte-swapping anything
[TCPIP][LAN]
- Fix byteswapping on AMD64 and ARM builds too
svn path=/trunk/; revision=59704
- SetupDiRegisterDeviceInfo shouldn't fail if a device instance already exists
- MSDN documentation for this function states: "If [SPRDI_FIND_DUPS] is not specified, the device instance is registered regardless of whether a device instance already exists for it."
svn path=/trunk/; revision=59702
- Handle the CM_CREATE_DEVNODE_GENERATE_ID flag
[SETUPAPI]
- Use the correct ID (the newly generated instance ID) when creating the device info if the DICD_GENERATE_ID flag was passed in
svn path=/trunk/; revision=59699
- Pass the CM_CREATE_DEVINST_GENERATE_ID flag to CM_Create_DevInst_ExW if DICD_GENERATE_ID was used
- Currently unimplemented in umpnpmgr
svn path=/trunk/; revision=59698
Fix the prototype of the undocumented function SetConsolePalette (see http://comments.gmane.org/gmane.comp.lang.harbour.devel/27844 and d79a1b7b81 for a usage example); tested by Mysoft a.k.a. Grégory Macario Harbs.
Needed for modifying VGA palettes for NTVDM.
svn path=/trunk/; revision=59697
* Fix __ll_rshift() and __ull_rshift(). Thanks to Filip Navara for his help with the issue.
* Properly mark int64part as unsigned __int6 in _byteswap_uint64().
* Add missing prototypes.
svn path=/trunk/; revision=59692
[NTOSKRNL]: Commit an old patch of mine that sets up the right frontend code in IoAssignResources. All it does is add some error checking before calling the old halfplemented backend.
svn path=/trunk/; revision=59653
[TXTSETUP]: Add sacdrv.sys to the list of setup drivers.
[CMAKELISTS]: Add sac/sacdrv/sacmsg to the build.
[SACMSG]: Update some messages to give them identifiers.
[SACDRV]: Reformat almost the entire driver to ReactOS standards.
[SACDRV]: Implement about 50% of the driver, including most of the Channel Manager, Command Manager and Raw Channel Support. Comment and cleanup all of the old code that was there before. This is WIP -- it will only activate if you attempt to enable EMS. EMS/SAC support should be very helpful for Thorium Core/ARM port.
svn path=/trunk/; revision=59649
* Sync user32 spy.c with Wine 1.5.26. Based on a patch by Samuel Serapion updated by me.
CORE-7210 #resolve #comment Committed an updated version in r59615. Thanks.
svn path=/trunk/; revision=59615
- Perform intialization of root hub in a worker thread
- Should help ReactOS to continue booting when an usb controller causes hangs
svn path=/trunk/; revision=59605
* Italian translation update for hostname, notepad, input, devmgr and msgina. By Paolo Devoti.
CORE-7319 #resolve #comment Committed in r59602. Grazie!
svn path=/trunk/; revision=59602
* Compile debug builds using -O1 instead of -Os. This results in faster compilation time with no measurable difference in runtime performance according to tests.
CORE-7374 #resolve #comment Committed in r59598.
svn path=/trunk/; revision=59598
* Make WS2TCPIP_INLINE and MSTCPIP_INLINE static inline instead of extern inline. This way we don't run into any warnings.
svn path=/trunk/; revision=59596
- Reduce number of hash collisions during bootup from 10 to 0, by choosing 257 (prime number = good) instead of 256 (power of 2 = bad)
- Use ULONG for CsrpStaticThreadCount and CsrpDynamicThreadTotal to fix an MSVC warning.
svn path=/trunk/; revision=59591
Fix memory leak in dir_hash_add_file().
The duplicated targetnorm used for calling dir_hash_create_dir is never affected anywhere. It is duplicated again before affectation. And thus,
leaks.
svn path=/trunk/; revision=59581
- Improve the execution of a shell verb in the default context menu.
- Retrieve the browse flags from the verb in order to figure out if we should actually try to browse
- Execute all the items that were selected and not only the first one
svn path=/trunk/; revision=59579
* A new approach to splitting the reactos.cab generation time now by more than a half, which consists of using the default compression level.
* The catch is 50kb bigger cab :p
svn path=/trunk/; revision=59577
* Turkish Translation of calc, charmap, dxdiag, solitaire, spider, winmine, magnify, mspaint, mstsc, notepad, rapps, regedit, clb, taskmgr, winhlp32, wordpad and write.
* Brought to you by Erdem Ersoy with a fix by me.
CORE-7261 #resolve #comment Committed in r59573.. Thanks !
svn path=/trunk/; revision=59573
* Silence some warnings about nonstandard extensions used (zero-sized array in struct/union and nameless struct/union).
svn path=/trunk/; revision=59568
SamrChangePasswordUser:
- Check the MinPasswordAge before trying to change the password.
- Set the PasswordLastSet time if the password has been changed successfully.
- Set the BadPasswordCount and LastBadPasswordTime if the caller tried to set a bad password.
svn path=/trunk/; revision=59560
- Stub MUI support functions (by Edison Henrique Andreassy). Don't export them yet (they need to be checked according to the Windows version, so that kernel32 export table matches our target).
svn path=/trunk/; revision=59556
- Victor Martinez Calvo: Add a missing status check in RtlpQueryRemoteProcessModules.
- Aleksey Bragin: The code is quite ugly, adding this check makes it just a little bit less uglier :-)
CORE-7059 #resolve #comment Committed in 59554, thanks.
svn path=/trunk/; revision=59554
- Alexander Yastrebov: Properly write data into the standard output device depending whether it's a char or a block device.
CORE-6628 #resolve #comment Patch committed in revision 59552, thank you Alexander and sorry that it took so long!
svn path=/trunk/; revision=59553
Update the PCI hardware IDs. Extracted from the pci.ids database from http://pciids.sourceforge.net/ from 2013.07.20
Maintained by Martin Mares <mj@ucw.cz> and other volunteers from the PCI ID Project at http://pci-ids.ucw.cz/.
svn path=/trunk/; revision=59551
[CDMAKE]
* Introduce a way to create an iso using a file map instead of the current on-disk layout. This allows us to massively reduce the IO and the disk space needed to perform the creation of the 3 ISOs, and at the same time speed up the process. Brought to you by Art Yerkes (arty) with review/bug fix by Thomas Faber.
[CMAKE]
* Leverage the newly introduced cdmake feature.
* Silence cdmake verbosity.
* Write the contents of the file lists at once, instead of appending to it one item by one.
[VGAFONTS]
* Don't include the cab file twice.
svn path=/trunk/; revision=59547
- Add the accelerators table that will be used for the shell view control
- Rewrite CDefView::OpenSelectedItems and CDefView::OnContextMenu.
- Rewrite accelerators handling for the shell view. Instead of handling them manually in CDefView::OnNotify, we now translate it properly in CDefView::TranslateAccelerator and forward the result WM_COMMAND message to the IContextMenu2 using a new method called CDefView::OnExplorerCommand.
- Now we don't do call ShellExecute or use clipboard function right in CDefView and this also is the first step to properly handle opening or exploring a folder (which is needed for explorer_new)
svn path=/trunk/; revision=59541
- Silence warnings. Using (unnecessary) virtual destructors here rather than final because that's what the 99 other classes already do.
svn path=/trunk/; revision=59535
- And here's finally a reason why we shouldn't use g++'s host-headers and libraries
- Switch back to wishy-washy-what's-a-standard mode for C++ globally, and enable C++11 only for netshell
svn path=/trunk/; revision=59534
Fix the creation of empty REG_MULTI_SZ values (they have to contain only one NULL char, since a multi-string has the form:
str1\0str2\0...strN\0\0
where each strI\0 is a null-terminated string, and a multi-string is terminated by a null string.
And therefore an empty multi-string has only one null char, corresponding to the terminating null string.
svn path=/trunk/; revision=59529
- In the token parsing function SmpParseToken, just return success directly if the input string has zero length, instead of running code which does nothing at the end, because the length was zero...
- Give a default value for the "BootExecute" entry in the SMSS registry configuration table (this value is used when there is no BootExecute registry value inside HKLM\System\CurrentControlSet\Control\Session Manager) and precise that it is a multi-string value.
- Remove a redundant "Environment" entry in this table, too.
svn path=/trunk/; revision=59518
- Fix a potential overflow bug.
- Don't hardcode the "/ 2" in indices computation (2 == sizeof(WCHAR))
- Fix a string enumeration bug when enumerating strings inside REG_MULTI_SZ values, in RtlQueryRegistryValues.
svn path=/trunk/; revision=59517
Indeed, it appears after extended testing that, when calling from user-mode, Windows checks the real presence of the SYNCHRONIZE flag when using FILE_SYNCHRONOUS_IO_(NON)ALERT even if we pass any of the GENERIC_xxx access flags...
Otherwise, when using FILE_GENERIC_(READ/WRITE) flags directly, there is no need to add the SYNCHRONIZE flag since it is already incorporated in it.
See CORE-7361 for more details.
svn path=/trunk/; revision=59514
Indeed, it appears after extended testing that, when calling from user-mode, Windows checks the real presence of the SYNCHRONIZE flag when using FILE_SYNCHRONOUS_IO_(NON)ALERT even if we pass any of the GENERIC_xxx access flags...
Part 1/X
svn path=/trunk/; revision=59512
[DBGHELPHOST]
* Introduce a self-contained, static library version of dbghelp, in order to leverage its PE DWARF support. Thanks to Jerome Gardou for his work on the compatibility layer, and to Thomas Faber for helping me with the review/improvements.
* Unify the new host lib with the existing dll codebase using preprocessor conditions. This prevents code duplication.
* Skip as much unneeded functionality as possible when compiling dbghelphost to keep it light and straight to the point.
[RSYM]
* Introduce the required functions that allow parsing DWARF (using dbghelphost) and using it (along with coff symbols) to create the rossym debug info. Brought to you by Awesome Arty with some bugfixes from Jerome Gardou. Many thanks to Thomas Faber for assisting me with the testing/bug hunting.
[CMAKE/GCC]
* Introduce a combination of dwarf and debug emission flags that ensure the smallest debug info size among all the possible options we have.
* Introduce compressed debug sections that I already included the support for in RosBE 2.1. Thanks to the mingw-w64 folks (Kai Tietz) for the patch.
* Don't compress debug sections of C++ modules for now due to a bug in the toolchain that leads to spamming the build at link time with a warning.
* Don't run rsym on the RC shared libraries. Thanks to Thomas Faber for spotting this.
[DBGHELP]
* Update the ros diff to reflect the changes introduced by the dbghelphost unification.
svn path=/trunk/; revision=59505
- Fix CcMdlReadComplete2 prototype.
- Fix a bug in Dominique Cote's code: when performing FsRtlGetFileSize, the length of the buffer should be set accordingly to the information class asked for, that is - FILE_STANDARD_INFORMATION structure. Previous calculation formula makes no sense at all and leads to memory corruption (if filesystem driver is stupid enough) or inability to get file size (if filesystem driver is coded by good developers).
svn path=/trunk/; revision=59495
- Fix ExAllocateFromZone. I understand it's deprecated, but it having a broken implementation which can't work at all because the one who coded this function failed to understand basic algorithms of linked lists is nonsense.
svn path=/trunk/; revision=59494
- Implement enabling Large Pages support if it is detected. The Page Size Extension (PSE) bit in CR4 is enabled when paging is disabled. To achieve that, a temporary virtual and physical identity mapping is created, which is discarded after PSE is enabled.
svn path=/trunk/; revision=59491
- Add configure support for VS 2013
- Add a missing /nologo to assembler invocations
- Properly complain about old MSVC versions during configure instead of failing the build
svn path=/trunk/; revision=59488
Fix some broken logic: we can duplicate console handles only if both the source and the target processes are in fact the current process.
svn path=/trunk/; revision=59486
Fix a delayed-imports problem, catched by Timo and Thomas with a MSVC build. Caused by the fact that the static library consrv specified delayed imports for it, thinking that they will be added to the list of delayed imports of winsrv. In fact it doesn't work and those imports become real imports.
svn path=/trunk/; revision=59480
Fix return of MiProtectedPoolUnProtectLinks() which was always returning null, instead of returning
safe unprotected links when needed
svn path=/trunk/; revision=59478
Now that the console server works fine, move it into its real place (as in Windows), that is, inside winsrv.dll, instead of hosting it in consrv.dll.
svn path=/trunk/; revision=59461
Kill bashisms introduced by r59197 and replace them by sh code.
This is mainly to preserve maximum portability of the code, and to
fix configure.sh on platforms where /bin/sh doesn't point to /bin/sh ;-).
svn path=/trunk/; revision=59457
- Hey Arch! You're displaying Major function codes, not IOCTL codes. Also, remove unnecessary casts (coming from some old code), and a use-after free.
- Add some memory helpers.
svn path=/trunk/; revision=59448
Initial commit of the ReactOS Console Driver.
For the moment, it's just able to load/unload, creating a "controller" device
and being able to DPRINT1 lots of messages when you try to access to it.
svn path=/trunk/; revision=59447
- Try again to fix version detection. If anyone sees compilers that are not .00 versions, please complain. This is required because a simply "contains" check can match all parts of the version number -- e.g. 16.00.40219.01 contains "19." in addition to "16."
svn path=/trunk/; revision=59443
Indeed with VS2010, checking for the string content " 16." instead of "16." makes version checking fail.
After checking with a hex editor what was the character preceding the number "1" of the "16." part of the
version string returned by cl.exe, I saw that it wasn't a space as thought by the author, but the character
of code 0xA0 ...
svn path=/trunk/; revision=59437
Forgot to add those files in the previous commit r59435:
We now store only console handles and not console pointers themselves.
svn path=/trunk/; revision=59436
- Use a handle table for storing consoles. Now checking validity of console handles is done in O(1) instead of O(n) as before.
I will see later on whether it would be good to have both a handle table and a linked list (which is removed here) for storing them
(when condrv will be a real console driver, handles to consoles will be obtained as you would obtain usual handles to devices, etc...
so that consoles will be internally stored in a linked list again).
- Add a "dummy" frontend to have the possibility to adopt default actions when no frontend is attached to a console, and to always have
a valid virtual table for them.
svn path=/trunk/; revision=59435
- Fix some files' info-header text.
- Move code of SrvSetConsoleWindowInfo to ConDrvSetConsoleWindowInfo.
- Introduce the helper function GetScreenBufferSizeUnits to retrieve screen-buffer width/height units.
svn path=/trunk/; revision=59433
- Switch back to a 32K receive window, because WRAP doesn't work with a 64K window and our receive code depends on that functionality
svn path=/trunk/; revision=59430
- Fix receive stalling if more than 10 packets are in the receive window
- Tune configuration to use larger DMA transfers and begin DMA earlier
svn path=/trunk/; revision=59429
- Add an RTL8139 driver based on documentation on OSDev, our existing drivers, and some prior work by Z98
- It should fully work on emulated and real RTL8139 hardware (I developed against QEMU's RTL8139)
- It's not 100% complete (some reset and halt paths aren't done) but everything I tested worked (ping, dwnl, rapps, Firefox)
svn path=/trunk/; revision=59427
Features-only commit:
- Fix version presentation at startup and when using the "ver" command (in French)
- Add to the prompt's command help, the fact that the $S specifier can be used to add a space.
- Implement the $I prompt specifier (see http://www.robvanderwoude.com/prompt.php), which sets
an information line on top of the screen (à la OS/2).
Use this new setting by default (I'm doing a poll on who loves it / hates it, and how we can improve it).
To disable it, use the command: "prompt $p$g" (the default windows' prompt).
To enable it, add the $s specifier to the prompt string (e.g. "prompt $i$p$g").
For your information, OS/2 uses "prompt $i[$p]" :)
svn path=/trunk/; revision=59422
- Move SrvSetConsoleWindowInfo to a better place.
- When enlarging the console buffer, use the attributes of the last cell of each line to fill the new cells for each line.
- Remove usage of HAVE_WMEMSET / wmemset for resizing the buffer (NOTE: maybe it will be needed again later on...)
svn path=/trunk/; revision=59420
Remove extra \r put by hand in some console output functions, so that we use there only \n.
But modify the ConWrite function so that, if we redirect output to something else than a console
(e.g. redirect to a file or to a serial console via ... > AUX), newline characters \n get converted
into \r\n automatically.
What you get, for instance, is: https://imageshack.com/a/img853/5834/l34.png
svn path=/trunk/; revision=59411
Fix the default input & output console modes. Now, you can use the command interpreter via serial port redirection, by:
1- Enabling a serial port on the machine on which ReactOS runs.
2- Launching:
cmd > AUX
at a command prompt.
svn path=/trunk/; revision=59405
Add a helper function which checks whether we are going to output text to a console handle or to a file handle.
Use it in ConWrite and in ConPrintfPaging.
svn path=/trunk/; revision=59401
- Remove erratic tabs in language files.
- Add the fact that one can use the "help" command with: "help command" to obtain help for "command".
svn path=/trunk/; revision=59391
And finally...
...
... fix whitespace, part 6/6 !!!! (convert tabs into 4-space indent).
Really, CMD is, together with win32k, the worst indented project I've ever seen.
You have lots of non-sensical extra newlines put in the middle of the code,
weird indentation made by a mix of tabs / spaces which take either 4 or 8 or even (!!)
2 spaces per indentation level; sometimes some guy mixed his space key with his tab key
to add a space between a word and another one; a mix of some sh*tty code styles (K&R and personal ones),
many many times no space between a logical keyword and the operand on which it applies, etc... etc...
I tried to put some sense in it, but I may have forgotten some insidious tabs somewhere...
svn path=/trunk/; revision=59389
- Fix MSVC version detection in configure.cmd
CORE-7337 #comment VS12 is not supported by CMake yet. With r59381, configure should at least give you a proper error message.
svn path=/trunk/; revision=59381
- Don't intentionally break on MSVC. I'm too lazy to change all of these to __REACTOS__, and it's a hack anyway...
CORE-7335
svn path=/trunk/; revision=59380
Correct some definitions (checked against official DDK). Fix also FSCTL_SET_SPARSE.
CORE-7333 #resolve #comment Fixed in revision r59376, thanks.
svn path=/trunk/; revision=59376
Fix extended and control characters handling in text-boxes. We don't show anymore strange characters when pressing on, e.g. up or down arrows anymore.
Also, fix uppercase 'o' character (which has the same scan code but is not an extended key, as the End key).
The culprit revision which introduced this bug is r58658.
CORE-7323 #resolve #comment The uppercase 'o' problem is fixed in revision r59373. Thanks for your report :)
svn path=/trunk/; revision=59373
Fix tree-view's image-list handle leakage when application quits.
Loosely based on a patch by Edijs Kolesnicovičs and Grégory Macário Harbs
NOTE: Always cleanup / destroy (or, try to) things in the reverse way they are created / initialized (i.e. in a symmetrical way). Therefore, destry the associated tree-view's image-list in the DestroyTreeView function, which is the opposite of CreateTreeView (which calls InitTreeViewImageLists). The same mechanism is already used by the list-view. For completeness, add a parameter to the DestroyTreeView function (a handle to a tree-view) so that we can pass to it the global tree-view's handle (see what's done in WM_DESTROY message handling in ChildWndProc).
CORE-6856 #resolve #comment Should be fixed in revision r59371. See the commit log for more details. Thanks :)
svn path=/trunk/; revision=59371
- Use UNICODE markers for characters (the L'.' symbol for example) (i.e. fix code originating from Wine).
- Accept NULL Path/FileName in RtlDosSearchPath_U (fixes some ntdll_apitest tests, see after).
Fixes for RtlGetFullPathName_Ustr:
==================================
- Rework RtlGetFullPathName_Ustr by "reusing" little parts of the code of our old RtlGetFullPathName_U coming from Wine (and then make RtlGetFullPathName_U call RtlGetFullPathName_Ustr instead).
- Include the get_full_path_helper code into RtlGetFullPathName_Ustr and NT'ify it, and fix it too:
* Fix skipping trailing path separators (slashes / backslashes) at the end of pathes.
* Zero-out the destination buffer
* Fix retrieving the "Short Name" (ie. the file name) out from the given full path name.
* Fix remaining UNC path handling (ie. correctly remove trailing points, spaces, in UNC paths).
They fix the following tests:
* kernel32:FindFiles (6 failures to full success)
* ntdll:RtlDosPathNameToNtPathName_U (4 failures to full success)
* ntdll:RtlDosSearchPath_U (6 failures to full success)
* ntdll:RtlGetFullPathName_U (8 failures down to 2 failures because we don't correctly NULLify the user buffer when trimming unneeded chars)
* ntdll:RtlGetFullPathName_UstrEx (6 failures down to 2 failures for the same reasons as the previous test)
To Do: Finish to NT'ify the code originated from Wine, fix NULLification of the user buffer (when trimming unneeded characters), and "clean" the code ie. remove extra DPRINTs and added FIXMEs and NOTEs comments.
svn path=/trunk/; revision=59366
Return STATUS_OBJECT_NAME_INVALID instead of STATUS_BAD_NETWORK_PATH, fixes some tests (kernel32:FindFiles in particular).
svn path=/trunk/; revision=59364
- Make MSVC analyzer happy by initializing the event before calling IoBuildDeviceIoControlRequest. Patch by Ivan Rodionov (overclocker at list dot ru).
CORE-7328 #resolve #comment Committed, thanks.
svn path=/trunk/; revision=59352
- Add all runs dumping to aid in development.
- Do not try to add a mapping run with 0 LBN. Zero and negative LBNs are forbidden.
- Rework other tests to work as expected (plumb a hole).
svn path=/trunk/; revision=59347
Remove a spurious cast, and add a note for the pInputControl parameter of ReadConsole.
[CONSRV]
- Move some input/output console function helpers to condrv.
- The way we notify for the presence of new input data, or for console pausing/unpausing, should be reconsidered (who should do this? The console driver? The active front-end?)
svn path=/trunk/; revision=59345
- Develop a new implementation of Large MCBs. It's based on (tested-in-real-world) implementation from Captive NTFS project, which is improved, enhanced, cleaned and beautified, using our own tests.
There are some test failures and some fishy things there (you may notice them when a variable name doesn't follow ReactOS kernel functions naming convention), however it's way better than the previous implementation.
Link to the original source file: http://git.jankratochvil.net/?p=captive.git;a=blob;f=src/libcaptive/fs/mcb.c;h=62b524630af82c9124c2c9b4eea7c4f0128c2cc4;hb=HEAD
svn path=/trunk/; revision=59342
* Do not generate empty Vtbl structure for empty interfaces. Brought to you by Thomas Faber.
* Patch is pending upstream.
svn path=/trunk/; revision=59312
Move some output functions to the future console driver (i.e. for the moment, CSR console server functions SrvConsole* call ConDrv* functions).
Don't worry, internal headers will be rearranged, so that:
<ConDrv***_function_prototype>(...);
CSR_API(SrvConsole***)
{
...
}
constructions will be avoided in the future. For now, just make everything working.
svn path=/trunk/; revision=59308
Start to separate better the CSR console server layer from the pure set of console functions (which will constitute a future console driver called... condrv :) ), and rework the terminal frontends interface.
Now load the frontends by order :
- the tui if we're in console mode
- the gui, otherwise.
(It's a temporary solution)
More modifications to come !
svn path=/trunk/; revision=59297
- Enable STLPort build on MSVC
- Configure STLPort not to generate static constant definitions (which MSVC doesn't like)
- Link C++ modules to stlport and cpprt as appropriate
- Fix comsupp and atl C++ options
CORE-6950
svn path=/trunk/; revision=59290
- Add replace_compile_flags macros. Thanks to Amine and LLVM.
- Clean up compilerflags.cmake a bit, and make invalid macro/function invocations fatal so we actually notice them
svn path=/trunk/; revision=59286
As ThFabba said:
" - Properly escape exclamation mark in configure message " <-- It's for delayed variable expansions in CMD scripts !! That's the true reason !
See r59281.
(The r59283 was a commit I've done because, independently (i.e. without seeing r59281), it happened for some reason that this phenomenon didn't appear at home, and after updating my local copy and rerunning a configure.cmd, I saw ^ characters before the ! . In fact it was because I temporarily disabled the delayed expansion vars in my configure script).
Therefore revert my error, shame on me :)
svn path=/trunk/; revision=59284
Clean-up the setup code:
- Use SampRegXxx functions instead of RegXxx functions.
- Let the setup functions return NTSTATUS instead of BOOL.
- Use a separate function to create the server object.
svn path=/trunk/; revision=59282
- configure no longer defaults to nmake, don't confuse the user
- Properly escape exclamation mark in configure message
svn path=/trunk/; revision=59281
- Fix incorrect McbMappingCompare() declaration, which was hard-casted to an incompatible prototype. It fixes the problem of crashes in generic tables code, however it does not make the actual MCB code logic any better.
svn path=/trunk/; revision=59266
Make F12 key working again on ReactOS. The problem was that it was hardcoded for activating a debugger and since we currently didn't activated a debugger, then nothing happened when pressing F12.
This key is in fact the default key (under some assumptions) for the UserDebuggerHotKey option, which should be read from the registry. Temporarily disable the checking code until someone implements a proper code for that.
svn path=/trunk/; revision=59258
Check for NULL pointer returned by PEN_AllocPenWithHandle before dereferencing the returned pointer (the allocation function can return NULL in low memory conditions, leading to kernel crashes).
svn path=/trunk/; revision=59257
Check for NULL pointer returned by COLORSPACEOBJ_AllocCSWithHandle before dereferencing the returned pointer (the allocation function can return NULL in low memory conditions, leading to kernel crashes).
Adapted from a patch from Aleksandar Andrejevic.
CORE-7317 #resolve #comment Fixed in revision r59255, cheers :D
svn path=/trunk/; revision=59255
- NetUserGetInfo: Implement level 11.
- NetUserSetInfo: Implement level 1024, 1025 and 1051.
- NetUserSetInfo: Support CountryCode and CodePage in level 2.
- NetUserSetInfo: Support CountryCode, CodePage and PrimaryGroupId in level 3.
svn path=/trunk/; revision=59254
Sync all sizes to be of the same size in every language to have a common look again!
Fix a size typo in nl-NL
Some languages need a overhaul badly! Especially Romanian really need to be shortened to not have such romans (See the word play?? ^^) for every string.
svn path=/trunk/; revision=59253
CORE-7261 #resolve #comment Committed in revision r59250, thanks for help. Skipped wordpad, winhlp32 and write. These apps are wine synched and you need to send these patches to them, sorry.
CORE-7274 #resolve #comment Committed in revision r59249, thanks for help.
svn path=/trunk/; revision=59250
- Simplify initialization of CONSOLE_START_INFO objects by also initializing their AppPath member in InitConsoleInfo.
- Add two members IconPath and IconIndex in the CONSOLE_START_INFO structure, to be used in a future work...
[HEADERS]
- CHAR_INFO* == PCHAR_INFO
- Add two informative comments for two fields of the CONSOLE_READOUTPUT structure (again, to be used in a future work...)
svn path=/trunk/; revision=59234
- NetUserEnum, NetUserGetInfo: Query UserAllInformation instead of UserAccountInformation.
- BuildUserInfoBuffer: Return more information to the caller (UserComment, Parameters, UnitsPerWeek, LogonHours and LogonServer).
- FreeUserInfo: Free additional strings.
svn path=/trunk/; revision=59223
- Use a Unicode screen-buffer for the console.
- Fix some pointers miscalculations in Read/Write console output routines, which lead to character display problems sometimes.
CORE-7277 #resolve #comment Should be fixed in revision r59212. Thanks for your report :)
svn path=/trunk/; revision=59212
- recognize PCI\CC_0000 as a valid ID for VBE adapters.
CORE-6773. #resolve #comment Should be fixed with r59207, thanks.
svn path=/trunk/; revision=59207
Fix group renaming code. It is not enough to set the name attribute. The domain object also need a new name-id mapping. Also fail if the new group name is already used by any account object in the domain.
svn path=/trunk/; revision=59204
- Release capture if the scroll is not tracking events. This fixes CORE-7075.
- Minor sync porting to minimize differences.
svn path=/trunk/; revision=59201
Fix alias renaming code. It is not enough to set the name attribute. The domain object also need a new name-id mapping. Also fail if the new alias name is already used by any account object in the domain.
svn path=/trunk/; revision=59200
- Pressing the Shift key while copying text in the console, allows us to copy it without newlines (tested on Windows).
- When starting keyboard selection ("Marking"), put the cursor on top left of the console view.
- Improve key presses actions when being in selection mode (pressing ENTER when being in selection mode, copies the text and cancels selection mode, pressing ESC or Ctrl-C cancels the selection, etc...)
- Try to fix erratic context menu apparitions when being in Quick-Edit mode (caught by Javier Fernandez, aka. elhoir)
svn path=/trunk/; revision=59198
- Add NUMBER_POOL_LOOKASIDE_LISTS constant
- Add PAT MSR constants for amd64
- Add missing extern "C"
[NTOSKRNL]
- Fix pool lookaside list usage for 64 bit
svn path=/trunk/; revision=59194
- Fix IN/OUT declaration of parameters for GetFullPathNameA/W
- Fix a bad usage of GetFullPathNameW in the GetTempPathW API, where the source and destination buffer for GetFullPathNameW was the same (Yet another Wineism :(( ). On Windows, using the same buffer fills it with a garbled string. Avoid this behaviour on ReactOS too, because internally GetFullPathNameW calls RtlGetFullPathName_U, the latter zeroing-out the destination buffer before usage.
[RTL:PATH]
See comments of revision r59183 (and in particular, fix some ntdll:RtlDos* path functions).
svn path=/trunk/; revision=59193
Fix NetLocalGroupGetMembers and implement level 1. The netapi32:access winetest does not crash any more and group members appear in the user manager control panel.
svn path=/trunk/; revision=59186
Fix return type and usage of RtlDetermineDosPathNameType_U, and use the declaration of RTL_PATH_TYPE in winternl.h instead of the wineism DOS_PATHNAME_TYPE.
See r59183 and 59184 for more information.
svn path=/trunk/; revision=59185
Fix return type and usage of RtlDetermineDosPathNameType_U, and use the declaration of RTL_PATH_TYPE in winternl.h instead of the wineism DOS_PATHNAME_TYPE.
[RTL:PATH]
- Make usage of the IS_PATH_SEPARATOR(...) macro instead of automatically checking for L'\\' or L'/', and of OBJ_NAME_PATH_SEPARATOR when checking for L'\\' only or setting the character L'\\' (just code consistency only).
<Test fixes:>
- Fix a search loop and a check in RtlpWin32NTNameToNtPathName_U (a problem of setting the pointer *PartName via the variable p existed (always 1 character shift wrt. the expected result, and now *PartName is set to NULL even if p == NewBuffer).
- Zero out an optional parameter (if present) in RtlDosSearchPath_Ustr.
- Zero out the return buffer in RtlGetFullPathName_U (function from Wine).
Those fixes ^ correct the following tests:
* ntdll:RtlDosPathNameToNtPathName_U (58 errors to 4 errors remaining due to UNC path handling).
* ntdll:RtlDosSearchPath_U (9 errors to 6 errors remaining due to the fact that our RtlDosSearchPath_U doesn't throw exception on bad arguments because it checks the validity of its arguments (pointers especially), whereas on Windows it seems it doesn't happen to be the case).
* ntdll:RtlDosSearchPath_Ustr (4 errors to full success).
* ntdll:RtlGetFullPathName_U (31 errors to 8 errors).
* ntdll:RtlGetFullPathName_UstrEx (29 errors to 6 errors).
svn path=/trunk/; revision=59183
- Add tests for SeQueryInformationToken NTAPI. By Moscow State Technical University students Constantine Belev, Denis Grishin, Egor Sinitsyn.
- Disabled from testbot because they bugcheck ReactOS (unimplemented functions bugcheck). Work in progress...
svn path=/trunk/; revision=59178
- Add tests for FsRtl Tunnel Cache APIs. By Moscow State Technical University students Arseny Ashuha, Marina Volosnikova and Denis Petkevich.
- Disabled from testbot because they bugcheck ReactOS (unimplemented functions bugcheck).
svn path=/trunk/; revision=59177
Revert r59165 because RtlPrefixUnicodeString may not behave exactly as what the original code did (but keep the command in comment). I also want how tests behave with the change.
svn path=/trunk/; revision=59173
Sorted the languages chronological, fixed some typos and extended the containing DLLs information for the MS Runtime Packs to all languages.
Changed the MB and kB in the French section to Mo and ko if not already done anyway.
Removed some double existent language IDs.
(Thx to Pierre and Olaf for helping with French and Polish)
svn path=/trunk/; revision=59169
- Added as far as still recent.
ROSAPPS-259 #resolve #comment Thanks for help !
- Added + Modification to German translation.
ROSAPPS-258 #resolve #comment Thanks for help !
- Added + small consistency fixes in the patch file.
CORE-6948 #resolve #comment Thanks for help !
- Added + Modification to German translation.
CORE-7064 #resolve #comment Thanks for help !
- Added + German translation.
Additionally I added German translations where missing.
svn path=/trunk/; revision=59166
- Change inclusion order. This is necessary when using VS static analyze, which requires IRQL level constants to be defined before IRQL annotations are used.
- Comment out 2 ASSERTS in amd64 specific code for now.
- Add cmtypes to ntddk.template.h to account, replacing the manually added structures
svn path=/trunk/; revision=59154
* Lock address space while deleting the segment and then unlock it. Brought to you by Nikolay Borisov.
CORE-7220 #resolve
svn path=/trunk/; revision=59153
- Add proper definition for DBG_UNREFERENCED_PARAMETER and DBG_UNREFERENCED_LOCAL_VARIABLE
[NTOSKRNL/RTL]
- Fix a number of warnings about unreferenced local variables
- Add 2 assertions that unmapping a section succeeds
svn path=/trunk/; revision=59151
- Fix a format specifier
[NTOSKRNL]
- Add a missing compiler memory barrier to KeIpiGenericCall
- Remove a pointless cast
svn path=/trunk/; revision=59147
SampDeleteAccountDbObject: Fix the check of a returned status value. The old check caused a failure even though the returned value meant success.
svn path=/trunk/; revision=59145
Fixed all sizes.
Updated FireFox and Thunderbird to the newest stables.
Same goes for LibreOffice and Apache OpenOffice.
Some more minor updates for a few apps.
svn path=/trunk/; revision=59144
- Improve the stub for MEM_RESET case of NtAllocateVirtualMemory.
Fixes infinite loop for gecko-based application (including firefox19 and ReactOS/wine mshtml implementation)
svn path=/trunk/; revision=59141
SamrDeleteAlias: Dereference the AliasHandle parameter properly. All SamrDelete functions use a pointer to the handle. The other SamrDelete functions do it right.
svn path=/trunk/; revision=59140
NetLocalGroupGetInfo: Fix a bug in the alias search code. The function should search the account domain if no alias was found in the builtin domain, instead of returning an error. Fail only if the desired alias can not be found in both domains.
svn path=/trunk/; revision=59138
- Implement SetConsoleCursor and ShowConsoleCursor (set the shape of the cursor, and show/hide it). It appears that SetConsoleCursor acts only on graphics screen buffers (tested on Windows).
I personnaly think it's a limitation we can suppress, but at the moment I keep it.
- Implement SetConsoleMaximumWindowSize which does nothing else than returning TRUE but doesn't give any constraint on the maximum size of the console window (tested on Windows Server 2003).
See http://undoc.airesoft.co.uk/kernel32.dll/SetConsoleCursor.php , http://undoc.airesoft.co.uk/kernel32.dll/ShowConsoleCursor.php and http://undoc.airesoft.co.uk/kernel32.dll/SetConsoleMaximumWindowSize.php for more details.
Useful for the NTVDM interface !
[CONSRV:Gui frontend]
- Fix "Select all" action.
- Enable or disable "Copy" and "Paste" commands in the edition menu.
svn path=/trunk/; revision=59135
- Do not dereference an unsafe ObjectAttributes pointer in IoCreateFile. Spotted by Aleksandar Andrejevic
(I'm removing the OriginalAttributes assignment completely because it's never used, and it generally makes no sense to copy this. ObOpenObjectByName already takes care of everything in attributes)
CORE-7167
svn path=/trunk/; revision=59134
* Properly fail when the read pointer is out of the file. Brought to you by Sergey Chernov.
CORE-7249 #resolve #comment Committed in r59133. Thanks !
svn path=/trunk/; revision=59133
COLOR builtin command of CMD does not format output color correctly.
When changing the color of the foreground of the console with the command "color 3" for instance,
the confirmation message "Color 3" appears whereas it should say "Color 03" as the number is output in 1-byte hexadecimal form.
Patch by Radek Liška
CORE-7246 #resolve #comment Committed in revision r59132. Thanks :)
svn path=/trunk/; revision=59132
... use Ninja by default for compiling ReactOS !!
Users now have to do:
./configure
to use Ninja for building ReactOS.
The old method (using makefiles) is available by doing:
./configure Makefiles
(or: ./configure makefiles )
Tested by Amine and Sylvain (blame them ;) )
svn path=/trunk/; revision=59129
- Handle case when device interface link is properly set
[WDMAUD]
- Implement timer routine, which issues a work item
- Implement querying sysaudio if the audio device count has changed. In that case reinitialize the mmixer library
- No reboot is now more required after installing audio devices.
svn path=/trunk/; revision=59121
- Emulate a return from _SEH2EnterHandleTrylevel/_SEH2EnterFrameAndHandleTrylevel rather than directly jumping to the handler in case of an exception. This prevents us from invalidating compiler assumptions. Thanks to Timo.
Should fix GCC 4.7 bug with PSEH2 (CORE-7240).
svn path=/trunk/; revision=59120
- Create the None (aka Users) group upon setup.
- Add all users as members of the Users group.
- Add the Guest user as a member of the Guests alias.
svn path=/trunk/; revision=59115
- Disable call to Direct3DCreate9 [HACK]
- Use the correct parent window handle when creating the system dialogs.
- Fix the next page button
- TODO: ReactOS needs to check whether a correct parent window handle was provided
- Fixes dxdiag tab problem
svn path=/trunk/; revision=59113
- Create shortcuts based on shortcuts.inf instead of hardcoding them
Note to translators: please make sure that all shortcut translations are correct. Several localized strings had to be copied by hand so there is the possibility that some errors exist
svn path=/trunk/; revision=59110
* Simplified the help system
* Removed an unnecessary check in the help system that listed the first help entry 'active' no matter what was entered into the help system, even if the word is not in the list.
* Removed exit_main and rem_main functions since it took a little extra processing time and made the code a bit harder to read. Now it determines if the given command is rem or exit first before looking through the entire function list.
* Converted WCHAR* to LPWSTR to make it a bit easier to read.
* Add a title to the program to make it easier for the user to determine the name of the application currently running, especially if a large script is being used.
Patch by Lee Schroeder.
Thanks!
CORE-7187 #resolve #comment Committed in r79104.
svn path=/trunk/; revision=59104
Fix some compilation warnings with MSVC.
[KERNEL32-CONSRV]
- Implement console graphics screen buffers, as described in http://blog.airesoft.co.uk/2012/10/things-ms-can-do-that-they-dont-tell-you-about-console-graphics/ .
The idea is that the console server creates a memory shared section to be shared with the client console application (it increases performance). A mutex is used to "say" to the console server that he can repaint the screen. The function InvalidateConsoleDIBits is implemented too. The definition of the structure CONSOLE_GRAPHICS_BUFFER_INFO comes directly from the site.
- CreateConsoleScreenBuffer was modified to be able to create such buffers.
This is needed for a working NTVDM-like application.
[CONSRV]
- Rework the console buffer structures so that text-mode buffers and graphics-mode buffers can "inherit" from an "abstract" structure, CONSOLE_SCREEN_BUFFER. Add few helper functions for manipulating them.
- Reorganize the output code in "graphics.c" and "text.c" files to separate text-mode only code from graphics-mode only code, both in the console server and in the GUI front-end.
Other fixes:
- Fix mouse handling (left and right clicks when one goes away from the "Selection" mode); do not handle mouse signal when we reactivate the GUI front-end window by a click.
- Fix GetLargestConsoleWindowSize API in console server side. Now pressing Alt+F9 in Far Manager to "change" the "video" mode works correctly.
Finally:
- Start to implement a (fake, i.e. not using directly a VGA driver) console fullscreen mode. Currently Alt-Enter key presses call a stub which just alternates DPRINTing between "switch to fullscreen mode" and "switch to windowed mode".
Images here:
- Example of an application (a 16-bit emulator by Mysoft) which uses the console graphics screen-buffer functionality: http://img577.imageshack.us/img577/1693/mysoftemulatorargon.png
- A potpourri of console applications which use graphics screen-buffers: http://img571.imageshack.us/img571/6526/consoledelirium.png
Enjoy :)
svn path=/trunk/; revision=59099
- Fix almost all of the (few) tests for uxtheme
- Do not allow opening or enumerating themes when the themes service is not running
svn path=/trunk/; revision=59098
- Add some missing 64 bit intrinsics
- Fix a warning in intsafe.h
- Use SAL2 annotations in sspi.h
- Fix some annotations
svn path=/trunk/; revision=59094
SampSetUserPassword:
- Update the password history only if the new password hash is not the empty password hash.
- Set the empty LM or NT password hash if the password is not present in order to keep both password hashes synchronized.
svn path=/trunk/; revision=59087
Calculate NT and LM hashes of the empty password string and use them as default passwords hashes in new user accounts.
svn path=/trunk/; revision=59083
- Only use the first port base address for parallel port identification. ECP ports have a second base address that confused the identification code.
- Apply the same check to the serial port identification code because it can prevent potential malfunction. At least it doesn't hurt to be on the safe side.
svn path=/trunk/; revision=59082
- partly implement support for scsiop_mechanism command, not yet activated
- terminate request properly when it is not supported. Fixes leaking of irp requests
svn path=/trunk/; revision=59081
- Implement HidClass_Power
[USBCCGP]
- Remove superflous spaces
- Implement IRP_MJ_SYSTEM_CONTROL
- Fix bug in IRP_MJ_POWER handler
- Add driver unload routine
[USBEHCI,USBOHCI, USBUHCI]
- Support Win2k3 usbhub.sys, which uses null device handle for the root usb hub
- Based on a patch by Thomas Faber
svn path=/trunk/; revision=59080
Take in account the boot disk in the number of detected disks.
It allows booting without a hard disk (e.g cdrom/floppy alone with an USB storage device)
svn path=/trunk/; revision=59079
Comparison is always true due to limited range of data type.
Patch by Samuel Serapion.
CORE-7178 #resolve #comment Committed in r59077.
svn path=/trunk/; revision=59077
Comparison is always true due to limited range of data type. Patch by Samuel Serapion.
CORE-7177 #resolve #comment Committed in r59076.
svn path=/trunk/; revision=59076
SeValidSecurityDescriptor does not correctly check for invalid DACL revision numbers. Patch by Samuel Serapion.
CORE-7209 #resolve #comment Committed in r59075.
svn path=/trunk/; revision=59075
- Remove dead code.
- Use SampReg functions for access th the registry.
- Improve error handling in SampCreateDbObject and SampOpenDbObject functions.
svn path=/trunk/; revision=59067
- Produce a proper error when add_cd_file is used with an unknown folder
- Remove an rbuild-leftover in reactos.dff.in
- Update outdated build tool message in configure
svn path=/trunk/; revision=59058
- Simplify CommandColor and document it. Checking whether one sets the same color for both foreground and background is now only checked inside SetScreenColor.
Based on a patch by Victor
CORE-7191 #resolve #comment Committed in rev.59055.
- Fix handling of /T:<color> option when starting cmd.exe
- Remove unneeded error string.
svn path=/trunk/; revision=59055
- Fix double irp completion bug in hidclass
- Hidclass now properly initializes and works in WinServer2003
- Tested excessively by Vic (Blame him ;))
svn path=/trunk/; revision=59049
* Sync with Wine 1.5.26 and update Wine gecko package to 1.9.
[PSDK]
* Update mshtmdid.h and mshtml.idl.
[APPWIZ]
* Import the new way of handling Wine gecko package.
[BOOTDATA/PACKAGES]
* Account for the new Wine gecko package slipstreaming.
svn path=/trunk/; revision=59047
Fix a bug that corrupted in-parameters when a remote function is called. If the in-parameter is an array of UNICODE_STRINGS, the bug terminates all strings at the length of the first string. For example, when LsaLookupNames is called in order to retrieve the SIDs of the "Guest" and "Administrator" users, the remote function received the strings "Guest" and "Admin".
The patch will be sent to the WINE project after a similar bug for out-parameters has been fixed too.
svn path=/trunk/; revision=59038
* Add to trunk, with a stubbed RunonceEx. Brought to you by Robert Naumann.
CORE-7194 #resolve #comment Committed in r59035. Cheers ;)
svn path=/trunk/; revision=59035
- Merge r58706 (ntos/ke: Reset the state of the right thread when switching NPX threads)
- Merge r58727 (ntos/mm: Fix check for address range fitting the VAD when commiting memory)
- Merge r58865 (bootdata: Add Themes folder during setup)
- Merge r59015 (rundll32: always return 0)
svn path=/branches/ros-branch-0_3_15-lt2013/; revision=59033
* Add a way to register typelibs using the TypeLibraries section in syssetup.inf. Brought to you by Giannis Adamopoulos.
svn path=/trunk/; revision=59028
+ Added German resource for hostname to build process.
General overhaul of shutdown application to make texts fit better than before. Whoever thought CTEXT is a good idea... NO it's not. Changed to LTEXT as used at almost all other apps we have. This makes text ordering way simpler.
CORE-7148 #resolve #comment Resolved in revision 59025. Thanks for your help :D
svn path=/trunk/; revision=59025
* Fix ITravelLogClient::GetWindowData() definition (parameters) and correct its use.
* Account for tlogstg.h where the ITravelLogClient interface is now defined.
[PSDK]
* Import tlogstg.idl from Wine 1.5.26.
* Remove the now duplicated definitions from shobjidl.idl.
[UUID]
* Add tlogstg.idl.
svn path=/trunk/; revision=59024
Implement a special case for existing files which are opened using the FILE_OVERWRITE or FILE_OVERWRITE_IF file disposition: New file attributes must be ORed with the existing file attributes.
svn path=/trunk/; revision=59023
Allow only readonly, hidden, system and archive files attributes to be set for existing files. Other file attributes must be ignored.
This fixes several tests.
svn path=/trunk/; revision=59022
- LsapCheckLogonProcess: Open client process using the PROCESS_DUP_HANDLE access right because we need to duplicate the logon token back into the clients handle table.
svn path=/trunk/; revision=59013
- Plug a memory leak in HidUsb_GetReportDescriptor
- Do not try to free in the middle of a pool block on IRP_MN_STOP_DEVICE
- Implement HidPower
- Do not access an IRP after completing it in HidCreate
- Do not waste a stack location in HidSystemControl
svn path=/trunk/; revision=59010
Wait for the LSA server to complete its initialization before initializing the GINA dll. This change is required because future changes to MSGINAs logon code will require access to the LSA.
svn path=/trunk/; revision=59002
- Use new helpers ConsoleAllocHeap and ConsoleFreeHeap instead of RtlAllocateHeap and RtlFreeHeap, to be able to use also debug heaps etc...
- Initialize completely CONSOLE and CONSOLE_SCREEN_BUFFER structures to avoid using unitializing fields, that can be prone to bugs.
- Do not unnecessarily lock the per-process IO handles table.
- Validate the console pointers when calling SrvCloseHandle / SrvVerifyConsoleIoHandle / SrvDuplicateHandle (so that we are sure to do valid operations for console applications, and fail properly for GUI ones).
- Fix a bug caught by [TheFlash] which unveiled only on livecds (why??) as random CSR heap corruptions. It was caused by corrupting the heap by freeing invalid IO handles when freeing the handles table inherited by default when starting a console application. I reworked the initialization code a bit and the freeing code to fix this problem.
This bug was diagnosed with the help of Thomas Faber's debug heap (see http://www.reactos.org/wiki/User:ThFabba/Debug_Heap ), that I've augmented a bit (with dumping functions when a heap block was found invalid).
- Now reenable the CSR heap usage.
CORE-7157 #resolve #comment Resolved in revision 59001. Thanks for your help :D
svn path=/trunk/; revision=59001
* Add some function annotations.
* Fix several debug print specifiers.
* Properly mark some unreferenced parameters as such.
svn path=/trunk/; revision=58990
* Fix the mismatch between sizeof and countof quantities in CdfsMakeFCBFromDirEntry.
* Properly account for '\\' and '\0'.
* Fix one more debug print specifier.
svn path=/trunk/; revision=58988
* Add some function annotations.
* Fix several debug print specifiers.
* Properly mark some unreferenced parameters as such.
svn path=/trunk/; revision=58987
Fix a bug in size calculation that causes memory corruption on 64 bit
Fix some MSVC/x64 warnings
[UNIATA]
Fix some MSVC/x64 warnings
svn path=/trunk/; revision=58985
* Add some function annotations.
* Fix several debug print specifiers.
* Properly mark some unreferenced parameters as such.
svn path=/trunk/; revision=58982
* Add some function annotations.
* Fix several debug print specifiers.
* Properly mark some unreferenced parameters as such.
svn path=/trunk/; revision=58981
Allow only readonly, hidden, system and archive files attributes to be set for a new file. Other file attributes must be ignored.
This fixes several tests.
svn path=/trunk/; revision=58976
* Add some function annotations.
* Fix several debug print specifiers.
* Properly mark some unreferenced parameters as such.
svn path=/trunk/; revision=58975
- FreeLdr is able now to load personalized Kernel Debugger Transport DLLs by reading at the kernel command line and interpreting the /DEBUGPORT=xxx entry (--> loads KDxxx.DLL dll in \SystemRoot\System32\).
Therefore we can not only load the "default" kdcom.dll, but also 3rd-party ones such as kdbazis.dll from VirtualKD (from revision 58902).
- The GCC-compiled-only version of kdcom, containing legacy COM code, was removed and put directly along KDBG. It remains only a stub / template for future kdcom-like dlls. The MSVC-version remains untouched.
- Make those functions ^ use directly the CPORTLIB library.
svn path=/trunk/; revision=58974
- Fix dprints (be careful when "Status" variables are booleans).
- Don't fail when trying to load an non-existent KD transport dll.
svn path=/branches/kd++/; revision=58971
* Mark SelectTimeout as a KDEFERRED_ROUTINE and fix its calling convention. This fixes a potential stack corruption.
* Brought to you by Nikolay Borisov and the MSVC static analyzer ;)
CORE-7171 #resolve
svn path=/trunk/; revision=58969
* Add some function annotations.
* Fix several debug print specifiers.
* Properly mark some unreferenced parameters as such.
* This fixes several warnings emitted by the MSVC static analyzer.
* Brought to you by Nikolay Borisov, with minor consistency styling changes by me.
CORE-7171
svn path=/trunk/; revision=58966
In fact, the kdcom used for KDBG (in GCC builds) is really a thin layer atop of CPORTLIB.
Remove extra code (remove also the KD_PORT_INFORMATION type) and replace it with calls to CPORTLIB functions.
Next step is to put all that thing into KDBG directly, as helper functions. Then, if one wants to make a really kdcom (as we have for MSVC builds), one has to refactor all KDBG.
svn path=/branches/kd++/; revision=58964
Finally reenable RtlAcquirePrivilege and RtlReleasePrivilege now that they are fixed.
[KERNEL32]
Remove the hacks in SetSystemTime() and SetLocalTime() now that RtlAcquirePrivilege is working properly.
[SYSSETUP]
Remove the hack for privileges in SetSystemLocalTime() now that SetLocalTime() can properly acquire needed privilege.
CORE-7168 #comment Fixed with r58960 #resolve
svn path=/trunk/; revision=58960
When we are impersonating, also set the flag, so that on release, we can kill it.
This hopefully fixes 2nd stage and the whole mess it was causing in privileges.
svn path=/trunk/; revision=58959
Place the (unimplemented) real KD functions into a dedicated file and isolate ReactOS-specific port functions. They can go into a libary along KDBG !
svn path=/branches/kd++/; revision=58958
Comment that part too, because it was in KdPortInitialize and here, it reported an invalid port. KdPortInUse is initialized by KDBG.
svn path=/branches/kd++/; revision=58957
Also "fix" hack of RtlAcquirePrivilege in SetSystemTime(). Spotted by Thomas.
Note for syssetup/rtl/kernel32 devs:
Make it crystal clear that this is a hack and has to be deleted once RAP is fine.
Also note that for SetLocalTime() and 2nd stage, syssetup acquires the privilege itself
in SetSystemLocalTime() before calling SetLocalTime().
This will also have to be deleted once RAP is working fine. Otherwise it will keep failing:
it is not possible to acquire a privilege already held.
svn path=/trunk/; revision=58953
Comment out RtlAcquirePrivilege & RtlReleasePrivilege for the moment.
It appears we are overflowing memory and thus corrupting registry, that breaks ReactOS install.
To be investigated...
svn path=/trunk/; revision=58938
ISO images generated by cdmake have invalid time and date.
Patch by Aleksandar Andrejevic, aka. [TheFlash]
CORE-7163 #resolve #comment Committed in revision r58932, thanks for the patch ;)
svn path=/trunk/; revision=58932
* Add NT_CONSOLE_PROPS and NT_FE_CONSOLE_PROPS and fix EXP_SZ_LINK.
* Add SHELL_LINK_INFO_* and some Shell Link Extra Data structures (for IShellLinkDataList).
[USERINIT][CPLS][DLLS]
* Add the now necessary wincon.h inclusion.
* Brought to you by Dominik Hornung.
CORE-7162 #resolve #comment Committed in r58930. Danke !
svn path=/trunk/; revision=58930
Hack: To try to uncover a heap corruption in CONSRV, use our own heap instead of the (default) CSR heap, so that we won't corrupt it and obtain strange bugs thrown by memory allocation in csrsrv.
Thanks to Aleksandar Andrejevic, aka. [TheFlash] for having seen that.
See CORE-7157 for more information.
svn path=/trunk/; revision=58926
Be sure to use our local heap instead of the current application heap, to store the console title.
To simplify the code, I introduced helper functions based on well-known Rtl functions.
svn path=/trunk/; revision=58925
- Hackfix hanging test. There's no benefit in having testbot take longer.
ROSTESTS-73 #comment Temporary timeout added in r58917 to prevent hanging.
svn path=/trunk/; revision=58917
* Plug a leak in IntGdiAddFontResource(). Original fix by Katayama Hirofumi MZ with one more instance covered by Timo Kreuzer.
* Return 0 instead of status in the file mapping failure path. By Timo Kreuzer.
svn path=/trunk/; revision=58913
- Fix some function parameter types, so to avoid unuseful casts (from pointers to const strings to pointers to strings in particular).
- The big thing: make FreeLdr load personalized Kernel Debugger Transport DLLs by reading at the kernel command line and interpreting the /DEBUGPORT=xxx entry (--> loads KDxxx.DLL dll in \SystemRoot\System32\).
So now, we can not only load the "default" kdcom.dll, but also 3rd-party ones such as kdbazis.dll from VirtualKD.
Read http://www.nynaeve.net/?p=173 for a trick I used :
"[...] Another enhancement that could be done Microsoft-side would be a better interface for replacing KD transport modules. Right now, due to the fact that ntoskrnl is static linked to KDCOM.DLL, the OS loader has a hardcoded hack that interprets the KD type in the OS loader options, loads one of the (hardcoded filenames) "kdcom.dll", "kd1394.dll", or "kdusb2.dll" modules, and inserts them into the loaded module list under the name "kdcom.dll". [...]".
svn path=/branches/kd++/; revision=58902
Patch by Aleksey Bragin (he's not aware yet!):
Also implement FsRtlIs*InExpression prologue in FsRtlIsDbcsInExpression (adapted from Aleksey's work on FsRtlIsNameInExpression)
Also added support for Dbcs chars in it
svn path=/trunk/; revision=58897
- Call tcp_shutdown() two different times for TX|RX shutdown to avoid the tcp_close() problem entirely
- Forcefully close the socket in LibTCPCloseCallback (not optimal, but good enough)
svn path=/trunk/; revision=58896
- Don't define mem_trim() to realloc() because mem_trim() must never move the buffer pointer
- Fix realloc() which was completely broken
- Properly handle a TX|RX shutdown
svn path=/trunk/; revision=58895
Implementation of pause, continue, and help commands for net service application. Patch by theflash.
Core-7131 #resolve
svn path=/trunk/; revision=58894
Unicodify and add localization support.
Patch by Lee Schroeder, simplified by me.
CORE-7142 #resolve #comment Committed in revision r58893, thanks!
[REGEDIT]
"Neutralize" common resources.
svn path=/trunk/; revision=58893
- Reformat the code for better readability. Sacrifice 80 chars max line width in favor of a readable code (sorry, but when the indentation eats 12 chars, formulas for calculating sizes are hard to fit into less than 70 chars, and they become totally unreadable).
svn path=/trunk/; revision=58890
- Start bringing sanity to FSRTL Large MCB implementation:
* Get rid of the GET_LIST_HEAD macro and define a proper private struct to access its members. That's much more flexible,and that's how it's usually done in hundreds of other places in the kernel. Otherwise we might just forget about structs and invent macros to access individual virtual fields in a byte array :)
* Going through the code (first, preliminary pass) and putting helper debug prints, especially when the code does not work as expected.
* Move variables definitions to the beginning of the function (thus get rid of up to local vars being redifined up to 3x times within a single function).
svn path=/trunk/; revision=58889
- Initialize SM_CXSCREEN and SM_CYSCREEN metrics in co_IntInitializeDesktopGraphics
- Also move some code from IntCreatePrimarySurface to co_IntInitializeDesktopGraphics
svn path=/trunk/; revision=58887
The idea then would be to have the following behaviour (when specifying the following options in the kernel command line):
/DEBUGPORT=COMi --> load KDCOM.DLL and use COMi port (i == 1,2,3,4) if possible.
/DEBUGPORT=FOO --> load KDFOO.DLL (useful for KDUSB.DLL, KD1394.DLL, KDBAZIS.DLL for VirtualKD, etc...)
/DEBUGPORT=ROSDBG:[COMi|SCREEN|FILE|GDB|...] --> load KDROSDBG.DLL which contains the ROS kernel debugger, and use COMi or SCREEN or... as output port.
svn path=/branches/kd++/; revision=58883
- turkish translation update by Erdem Ersoy: CORE-7025,CORE-7032,CORE-7033,CORE-7034,CORE-7071;
- italian translation update by Paolo Devoti: CORE-7122;
- use the same notepad caption title as in Windows 2003 for AHK test compatibility, patch by Edijs Kolesnikovics: CORE-7023;
- added polish translation of samsrv and wlanconf, updated polish translation of rapps, msgina, consrv, console and desk;
- convert msgina to compile resources for a defined language;
svn path=/trunk/; revision=58882
- Use SHELL_LINK_HEADER instead of defining a local structure. Patch by Dominik Hornung (dominikhornung at gmx dot de).
CORE-7099
svn path=/trunk/; revision=58881
- Add tests for ZwAllocateVirtualMemory, ZwCreateSection, ZwMapViewOfSection. Patch by Nikolay Borisov (nib9 at aber dot ac dot uk).
- Some tests are currently skipped because they crash or assert on ROS: See ROSTESTS-107, ROSTESTS-108, ROSTESTS-109, ROSTESTS-110.
ROSTESTS-105 #resolve
svn path=/trunk/; revision=58874
- Implement a mechanism for kmtests to retrieve information from user-mode. Patch by Nikolay Borisov (nib9 at aber dot ac dot uk).
- Currently supported function: QueryVirtualMemory
ROSTESTS-96 #resolve
svn path=/trunk/; revision=58873
- Rework FsRtlExpression test to be more maintainable by using a table. Patch by Víctor Martínez Calvo, a few comments by me.
CORE-7108 #resolve
svn path=/trunk/; revision=58864
* Account for the asm source files in all the HAL flavors. Should fix compiling them with VS (which regressed recently).
svn path=/trunk/; revision=58862
- Apply changes from http://code.reactos.org/cru/CR-30
- If an event object already exists, CreateEvent returns a valid handle to it. So that, if the returned handle is NULL, then automatically we are sure that it doesn't exist. Therefore remove unneeded checks.
svn path=/trunk/; revision=58856
- Handle VME for the PUSHF and POPF instruction in virtual mode
- There is no reason to set interrupt flag when handling POPF
- Fix a typo in POPF case : mask out the right variable
See http://www.rcollins.org/articles/vme1/ for reference
svn path=/trunk/; revision=58852
* Make sure that BaseAddress is at 64-k boundary in NtMapViewOfSection(). Fixes a couple NtMapViewOfSection tests.
* Brought to you by Zhan Jianyu (aka larmbr) with review and improvement by Timo.
CORE-7118 #resolve #comment A slightly improved fix was committed in r58851. Thanks ;)
svn path=/trunk/; revision=58851
- Apply similar fixes as in 58848 to RtlGetElementGenericTable (no need to make too fancy predecrements if they work incorrectly in this case when do/while loops were unnecessary at all).
svn path=/trunk/; revision=58850
- Do not set result variable NodeOrParent in RtlpFindGenericTableNodeOrParent in case the generic table is empty, just returning TableEmptyTree is enough.
- Fix improper enumeration of generic tables nodes. The way they were done previously clearly shows that noone was actually testing these APIs and a simple mistake (do/while instead of while loop) led to a NULL pointer access. Thanks to Pierre for developing MCB tests which revealed this problem.
Rephrasing Vladimir Lenin: "Test, test and again test!"
svn path=/trunk/; revision=58848
Reimplement (yes, once more...) all the DOS wildcards in FsRtlIs*InExpression().
This time with a better understanding of MSDN (doc can be sometimes quite cryptic...).
Which means that now the functions are passing all the tests and are even simpler.
svn path=/trunk/; revision=58847
Add tests for testing Large MCBs on Aleksey's request.
Currently, they fail (and even crash) on ReactOS.
Aleksey promised a bugfix!
svn path=/trunk/; revision=58838
- Use stdlib.h header instead of declaring the atol function's prototype (caught by Jérôme).
- Clarify the loop in KdpSendPacket (by Timo).
NOTE: I also noticed that it was not this loop-change that fixed reconnection (see commit message of r58823), but one of the changes of revision r58822 (certainly the one in the KdpReceiveByte function) (ironically I said "Seems to fix..." since I noticed that change of behaviour when I was trying to play with the code in KdpSendPacket with modifications of r58822, but I didn't notice that in fact it happened with changes of r58822. It is only today that I constated that, during a revert of r58823 + test + a remark from Timo).
svn path=/trunk/; revision=58834
Properly handle (as Windows does) WC in case last dot was eaten in path name translation
Fixes last FindFile failing tests
svn path=/trunk/; revision=58833
- Do not apply non client metrics defined in the theme, while applying the theme. This is now done by desk.cpl
- Implement OpenThemeDataFromFile to let desk.cpl open a theme file and query the metrics stored in the theme file
- Make use of the HTHEME hTheme parameter in GetThemeSysBool, GetThemeSysColor, GetThemeSysFont, GetThemeSysInt, GetThemeSysSize and GetThemeSysString
svn path=/trunk/; revision=58831
- Code reorganization: put all the port control functions together.
- Little simplifications of some functions (from CORE-7106).
svn path=/trunk/; revision=58825
Open the caller process using more access rights in order to be able to allocate memory in the callers address space and to be able to write into the allocated memory.
svn path=/trunk/; revision=58816
- Fix LsaFreeReturnBuffer. It is used to free virtual memory instead of heap memory because Buffer is a pointer to a virtual memory buffer that has been allocated by an authentication package.
- Fix several DataLength calculations and a typo.
svn path=/trunk/; revision=58815
Implement support for WC translation to DOS so that they are correctly passed to FsRtlIs*InExpression()
Please retest issues CORE-5125 and CORE-7100
svn path=/trunk/; revision=58814
- Add KmtSendWStringToDriver to easily send unicode strings to special-purpose drivers
- Add TESTENTRY_NO_EXCLUSIVE_DEVICE flag for non-exclusive devices in special-purpose drivers
ROSTESTS-104
svn path=/trunk/; revision=58812
- Add missing file
- In desk.cpl we now use RegLoadMUIStringW however this function is introduced in vista. Since we don't have an official policy what to do in such cases I chose to create a local copy of this function here becasue it also lets us test desk.cpl in xp
svn path=/trunk/; revision=58809
- Overhaul the appearance tab
- Fixed and tested to work almost flawlessly on windows xp and windows 7
- Implement selecting the size of a scheme
- Implement loading the scheme from a visual style and allow the user to customize it before applying the visual style
- Implement showing visual styles preview
- Properly load and apply system metrics
- Store the scheme in memory as NONCLIENTMETRICS and ICONMETRICS structs instead of arrays of sizes and fonts
- Store the loaded themes in a list instead of a global array
- Now that this works great in windows, it also mean that we have to modify our colour schemes in the registry to
be in the same format with windows and also fix uxtheme to handle system metrics properly
svn path=/trunk/; revision=58808
Allow ignoring all nullable matching wildcards at the end of the expression string when name is over in FsRtlIs*InExpression()
This fixes a few tests
svn path=/trunk/; revision=58806
- Open Date and Time Properties on double-click on the tray clock. Based on patch by Edijs Kolesnikovičs and Grégori Macário Harbs.
CORE-6860 #resolve
svn path=/trunk/; revision=58794
Add more tests for FsRtlIsNameInExpression() by Victor Martinez
Also add these tests for FsRtlIsDbcsInExpression()
See CORE-5125 for more information
svn path=/trunk/; revision=58788
- Promote some debug messages to errors in order to understand why trying to open the task manager from the loged on dialog sometimes fails
svn path=/trunk/; revision=58786
* Import from Wine 1.5.26.
[PSDK]
* Import docobjectservice.idl and htiface.idl from Wine.
* Add some missing definitions in shlobj.h.
[UUID]
* Add docobjectservice.idl and htiface.idl to the list.
* Add CGID_DocHostCommandHandler.
svn path=/trunk/; revision=58783
Here is all the deprecated code: the old CSR as well as the new one which wasn't included; the ReactOS-specific win32csr and the csr module of win32k.
svn path=/trunk/; revision=58771
Merge of the ros-csrss branch created with a three-fold purpose:
- Use the new Windows-compatible Client-Server Runtime Subsystem (csrss + csrsrv)
written by Alex Ionescu to replace the old hacked one. Also the CSR client part,
residing in ntdll, is updated. Some work also done on the dlls side, which
communicate with CSR, namely kernel32.
- Replace our very old win32csr.dll CSR server by the collection basesrv.dll /
winsrv.dll as it is done under Windows.
- Since the console subsystem is (for historical purposes on Windows) the
only subsystem which exploits all the possibilities of the CSR, I decided to
put it in a new CSR dll called 'consrv.dll', even if on Windows it is included
together with other APIs inside the winsrv dll (since Windows NT 3.1 release)
(I took the name 'consrv' from the dll where it was included in Windows NT 3.1
beta from October 1991). Some work was also done on its internal architecture
(the external interface is of course unchanged for compatibility reasons) and a
two-layer approach was developed, using the existing idea of console functions +
GUI or TUI we already had in win32csr:
* the "console server" which dialogs with the console applications,
and which maintains a list of all the created consoles.
* different "front-ends" corresponding to where you want to output
the information (~= console hardware) (Work-In-Progress).
Another idea would be to make those front-ends dynamically-loadable (instead
of being compiled inside consrv).
- I also fixed some parts of the console properties dialog box.
More information can be found in http://www.reactos.org/archives/public/ros-dev/2013-April/016121.html
CORE-122 CORE-2510 CORE-7002 #resolve #comment Committed in revision r58xxx.
svn path=/trunk/; revision=58770
When generating the memory descriptor list, do not map the pages at the same time, since that requires allocating page tables, which will alter the state of pages, that might already have been processed. Instead map everything beforehand. This has not had any impact on x86, since the pfn database initialization code mindlessly adds all mapped pages as valid, even if they were reported as free by the OS loader. But proper Mm code does not necessarily do this.
svn path=/trunk/; revision=58760
Fix compilation with MSVC. In particular initialization of structures variables (due to MSVC-C-compilation dumbass convention).
svn path=/branches/ros-csrss/; revision=58756
* Import audioclient.idl and mmdeviceapi.idl from Wine and add them to the generated PSDK headers.
* Add missing WAVE_FORMAT_IEEE_FLOAT definition to mmreg.h.
* Import audiosessiontypes.h, devpkey.h and propkey.h from Wine.
svn path=/trunk/; revision=58751
Addendum to revision r58744.
CORE-7062 #comment the NDIS_** structures, albeit containing the "recieve" misspelling, must be kept as they are because we must be compatible with the Windows DDK. Indeed this one contains the misspelling. Blame Microsoft if they do not know how to write proper English or if they do not re-read what they are writing !!
svn path=/trunk/; revision=58748
Correct spelling of "receive" throughout the codebase.
Patch by andygui.
CORE-7062 #resolve #comment Part for RosApps fixed in revision r58746.
svn path=/trunk/; revision=58746
Correct spelling of "receive" throughout the codebase.
Patch by andygui.
CORE-7062 #resolve #comment Part for RosTests fixed in revision r58745.
svn path=/trunk/; revision=58745
Correct spelling of "receive" throughout the codebase.
Patch by andygui.
CORE-7062 #resolve #comment Fixed in revision r58744. Thanks :)
svn path=/trunk/; revision=58744
Fix the definition of BYTES_TO_PAGES. While the macro might look overcomplicated, it actually needs to be this way to prevent integer overflows.
svn path=/trunk/; revision=58738
Add header files for RTL8139 drivers holding function definitions and register addresses. Still incomplete/some holdovers from old ne2000 driver which will get pruned as more of the driver is rewritten. Not committing the actual driver code yet due to the need to massively clean it up. Not yet added to compilation.
CORE-7081
svn path=/trunk/; revision=58733
- Reintegrate the text-only frontend, deactivated in revision r58447.
- Use a (temporary) helper ConioIsBufferResizeSupported to know whether or not the frontend supports screenbuffer resizing. In a near future, all the frontends will support that so this function will be removed.
- Promote ConioResizeBuffer to be a function of the console server (not only reserved for the GUI frontend).
[WIN32K]
- Remove the support of registrating TUI notification window class (feature such as knowing at which console app the notification window belongs to is unneeded when using the TUI).
- Start to introduce ConsoleAcquireDisplayOwnership, a win32k console control to let win32k release the display so that we can own it (it is step 0.0.1 on a scale of 0.0.0 to 1.0.0).
Note that, as in trunk, getting a text-only interface when booting with the /CONSOLE switch still doesn't work (clash between text-mode and video-mode enabled by win32k).
svn path=/branches/ros-csrss/; revision=58732
Try to do some archaeology of names: attempt to attribute some files to programmers who spent lot of time on them, based on SVN history (I might have forget some other ones).
svn path=/branches/ros-csrss/; revision=58730
Fix incorrect assignation.
Patch by Victor Martinez
Reviewed by Timo Kreuzer
CORE-7067 #comment Committed in r58729 #resolve
svn path=/trunk/; revision=58729
* Enable the test for committing regions larger than the section again
* Test behaviour of NtFreeVirtualMemory(MEM_DECOMMIT) for section-backed virtual memory
svn path=/trunk/; revision=58728
- Fix check for address range fitting the VAD when commiting memory
CORE-7065 #comment Should be fixed with r58627 #resolve
svn path=/trunk/; revision=58727
- Implement GetLargestConsoleWindowSize (and add a DPRINT to see what happens when Far 1.65 is launched).
- Implement SetConsoleWindowInfo in kernel32 and pre-implement its CONSRV counterpart.
svn path=/branches/ros-csrss/; revision=58726
"Hack-fix" some headers to remove the forward declaration of typedef struct _CONSOLE *PCONSOLE;, which makes GCC 4.4.3 angry, but makes GCC 4.7.2 stay imperturbable.
svn path=/branches/ros-csrss/; revision=58725
Code reorganization only: put public server apis definitions in a dedicated include to be included in the respective init.c files.
svn path=/branches/ros-csrss/; revision=58718
Code reorganization. Common functions declarations, shared between the console server and the frontends, are put inside a include/ subdirectory. Functions needed only for the console server are in the usual root directory. Functions used only for the frontends are in their corresponding directories in under frontends/.
svn path=/branches/ros-csrss/; revision=58717
A little bit of code reorganization (more a "matter of taste"; delete allocated pointers in the reverse way we allocated them).
[NTDLL]
- Free a used SID (i.e. fix a memory leak).
- Only just "reserve" memory pages for the section for the CSR port. Memory will be actually committed later on (checked on Windows Server 2003 and on http://j00ru.vexillium.org/?p=527 ).
svn path=/branches/ros-csrss/; revision=58716
Don't attempt to close undefined handles.
Also properly set them on failure as "the contents of the output parameters are indeterminate" on failure.
svn path=/trunk/; revision=58701
* Don't be so complicated for defining the DEFINE_GUIDSTRUCT and DEFINE_GUIDNAMED macros on GCC
CORE-7052 #comment fixed in 58697, thanks. #resolve
svn path=/trunk/; revision=58697
- Add a test verifying that the filter set with SetUnhandledExceptionFilter is called.
Take this as an occasion to demonstrate a bug with SSE exceptions in ReactOS
svn path=/trunk/; revision=58692
* Don't set the compiler and linker PDB to the same file (it's the linker's PDB that matters).
* No code changes, 12% faster msvc build.
svn path=/trunk/; revision=58685
Fix TOO MANY !! :(((( "initialize" misspellings.
Note1: One remains in subsystems/csr/csrsrv/init.c, but will be corrected in my future csrss branch merging.
Note2: In ntoskrnl/se/semgr.c, one tries to create the "LSA_AUTHENTICATION_INITALIZED" event. This is ROS-SPECIFIC !!!! In the sense that it doesn't exist on Windows. Instead, the "LSA_AUTHENTICATION_INITIALIZED" exists. Correct that fact.
svn path=/trunk/; revision=58679
Fix spelling of 'length' in various places.
Patch by andygui
CORE-7043 #resolve #comment Part for ROSTests committed in r58674, thanks!
svn path=/trunk/; revision=58674
Fix spelling of 'length' in various places.
Patch by andygui
CORE-7043 #comment Part for ROSApps committed in r58673, thanks!
svn path=/trunk/; revision=58673
Fix spelling of 'length' in various places.
Patch by andygui
Concerning kdio.c, we can see that the original author didn't see his misspelling since he used two different variables named:
KdpScreenLineLength and KdpScreenLineLenght ! ; the latter being renamed here KdpScreenLineLengthDefault to make the difference.
CORE-7043 #comment Part for ReactOS committed in r58672, thanks!
svn path=/trunk/; revision=58672
- Further improve FreeLdr's edit-boxes editing capabilities, by supporting insert-mode (only at the moment), backspace and delete to remove a character, moving left or right, going to the beginning or to the end of the string.
- Add a helper function DrawText2 to allow for displaying partial string (giving a maximum number of characters to display).
Enjoy :)
svn path=/trunk/; revision=58658
Add support for HOME and END keys in menus, and allow going to the end (resp. to the beginning) if we are on the first (resp. on the last) item and we press up (resp. down).
Enjoy :)
svn path=/trunk/; revision=58635
Allow passing into quick-edit and insert mode via the console properties dialog. Also make the context menu working.
svn path=/branches/ros-csrss/; revision=58634
Implement (Get/Set)ConsoleDisplayMode.
[PSDK]
Reorganize wincon.h a little bit and add few new flags from MSDN / Wine's wincon.h (which was up-to-date compared to ours) and from https://sites.google.com/site/marckupper/utilities/setconsolemode (the ENABLE_AUTO_POSITION flag which happens to be set by default for consoles on Windows Vista+).
[CONSRV]
- Fix the implementation of Srv(Get/Set)ConsoleMode.
- Try to fix some mouse handling problems.
- Add a TEMPORARY HACK!!!! to circumvent one of the many bugs we have in user32/win32k concerning handling right-mouse clicks on windows titlebars.
The comment:
/*
* HACK: !! Because, when we deal with WM_RBUTTON* and we do not
* call after that DefWindowProc, on ReactOS, right-clicks on the
* (non-client) application title-bar does not display the system
* menu and does not trigger a WM_NCRBUTTONUP message too.
* See: http://git.reactos.org/?p=reactos.git;a=blob;f=reactos/win32ss/user/user32/windows/defwnd.c;hb=HEAD#l1103
* and line 1135 too.
*/
Tested with Far Manager 3 (TM)
Happy Easter !!
svn path=/branches/ros-csrss/; revision=58632
- Fix the SAMPR_LOGON_HOURS type description.
- Implement the LogonHours attribute query code for all user query functions.
svn path=/trunk/; revision=58629
Introduce GET_KEYSTATE_WPARAM, GET_NCHITTEST_WPARAM, GET_XBUTTON_WPARAM macros.
[CONSRV]
Fix double-click, mouse scrolling and add support for control keys.
svn path=/branches/ros-csrss/; revision=58623
- Fix passing and retrieving gui terminal front-end information.
- Fix default (global) console parameters saving.
[CONSRV]
- PSEH2-protect calls to CreateRemoteThread when 1. calling console app. control handlers and 2. retrieving console settings from console.dll.
- Introduce a new way of locking consoles when being used, and store them in a list.
svn path=/branches/ros-csrss/; revision=58615
- Apply Wine commit 84075591 (user32: Don't access past the file size when loading a cursor/icon) by Alexandre Julliard.
- Add a few consts (also from Wine).
CORE-7027 #comment Ldr and Mm are doing everything right. UPX in fact broke the resource section, and LoadImage is just not handling that correctly. #resolve
svn path=/trunk/; revision=58614
- Set bugcheck data when the image is corrupt
- Add 2 more useful debug constants: DEBUG_WARN and DEBUG_ERR
- Use COM2 for debug output when _WINKD_ is defined
- Fix amd64 boot
svn path=/trunk/; revision=58606
- Further separate properties of the GUI terminal front-end and those independent of the UI.
- Fix some console initialization steps.
svn path=/branches/ros-csrss/; revision=58605
- Add missing __stosq intrinsic
- Move architecture specific stuff to a later location in wdm.h to make sure we have ASSERT macros already
- Add missing extern "C" to some NDK header
- Remove duplicate sal definitions
svn path=/trunk/; revision=58598
Update/add translations:
- German by Zehnvor (CORE-6804);
- Italian by Ivan Di Francesco (CORE-6911);
- Chinese by Yu Pan (CORE-7000);
- Turkish by Erdem Ersoy (CORE-7011, CORE-7014).
svn path=/trunk/; revision=58583
- Use set foreground instead of setting active during a mouse click. Add support hack since this should be handled on server side.
- This is an ATI patch fix.
svn path=/trunk/; revision=58562
- Dialog procs should return FALSE instead of calling DefWindowProc. Fixes mouse activation of the window when the user clicks in the client area
svn path=/trunk/; revision=58561
Calculate PasswordCanChange and PasswordMustChange time for SamQueryInformationUser.UserLogonInformation and SamQueryInformationUser.UserAllInformation.
svn path=/trunk/; revision=58560
Remove extra space characters produced by replacing backslash with space
for Shift_JIS backslash problem. Patch by me, reviewed by Katayama
Hirofumi MZ. Fixes bug CORE-6990.
svn path=/trunk/; revision=58558
Use a new helper function ConSrvConsoleProcessCtrlEvent to send control events to processes belonging to a given console.
svn path=/branches/ros-csrss/; revision=58556
- Victor Martinez: ECHO command should write CRLF. Fixes regressions in several apps that depend on console output.
CORE-6916 #resolve #comment Committed in r58553.
svn path=/trunk/; revision=58553
- We can now free the fiber activation context stack since RtlFreeActivationContextStack is implemented.
- Free the thread activation context stack if we fail at creating a remote thread.
svn path=/trunk/; revision=58549
- Add LsaApLogonUserEx and LsaApLogonUserEx2 stubs.
- Delay import samsrv and lsasrv import libs.
- Start the implementation of the logon process.
svn path=/trunk/; revision=58537
- It seems (after testing) that services report now correctly their state to the SCM. So we can start them in SERVICE_START_PENDING state (see revisions r45626 and r45640).
- Add some informative comments.
- Use a helper function to create start events at initialization time.
- When autostart services are up, signal an event. (see revisions r45633 and r45658).
- Wait for LSASS just after having created the services database, and before calling ScmGetBootAndSystemDriverState (conform to Windows Internals 4th, page 224).
---------
- When starting auto-start services, hold a lock during all the operation in such a way that, if an external program wants to start a service, it is obliged to wait till all the auto-start services have been started (usual service starting also uses that lock).
CORE-7001 #resolve #comment Should be fixed by r58534. Do not hesitate to reopen this bug-report if the problem reappears.
svn path=/trunk/; revision=58534
- Implement LsaIFree_LSAPR_POLICY_INFORMATION, which will be used by msv1_0.dll.
- Fix a potential compiler warning in LsapAddAuthPackage.
- Remove an obsolete check from LsarSetAuditEvents.
svn path=/trunk/; revision=58532
Put an event name into a macro (shared between advapi32.dll and services.exe)
[BOOTDATA]
Remove two reactos-specific and unused values in HKLM\SOFTWARE\Microsoft\Windows NT\CurrentVersion\Winlogon : StartLsass and StartServices.
svn path=/trunk/; revision=58520
- Store the session id in WINSTATION_OBJECT when we create a window station.
- Don't allow switching to a desktop that belongs to a different session
This is a modified version of the patch from CORE-5531
svn path=/trunk/; revision=58514
Reorder closing of handles (the service handle then the SCM handle), it clarifies the logic (but not change it dramatically).
[RSYM64]
Correct a misspelling, no code change.
svn path=/trunk/; revision=58488
Disable enqueuing processes into the SessionGlobal->ProcessList, since it's broken and causes non paged pool corruption. The reason is that sometimes the process is not removed, so a dead allocation stays in the list, causing havoc, when the next or previous process in that list is removed.
svn path=/trunk/; revision=58487
- Implement "!pool" kdbg extension that works like in WinDbg
- Implement ExpCheckPoolAllocation to check a single allocation for sanity
- Rename MEMORY_ARE::PageOpCount (which is unused) to Magic and set it to 'MAre'
- Implement MiRosCheckMemoryAreas, that checks all memory areas for integrity and PspCheckProcessList that checks the process list. The code is not used anywhere, since it can cause a major performance impact, but it proved useful to detect non paged pool corruptions. So I'll commit it in the hope that it will be useful.
svn path=/trunk/; revision=58485
Implement the usage of the STARTF_TITLEISLINKNAME flag (in a STARTUPINFO structure, it signals that the program was started from a shell link, and therefore its lpTitle member holds the path of the link).
What I do is that, in CShellLink::InvokeCommand (called when a shortcut is being executed), I initialize the SHELLEXECUTEINFO structure such that we know that we are starting from a shortcut (use the
SEE_MASK_HASLINKNAME flag), and to hold the path to the flag I use its lpClass member (which is not used for other things in this code path). Then the whole thing is passed to ShellExecuteExW which, in turn,
calls the SHELL_ExecuteW function. This function reads the SHELLEXECUTEINFO structure and, if it has the flag SEE_MASK_HASLINKNAME (or SEE_MASK_HASTITLE too, if somebody also uses lpClass to pass a particular
title for the startup), we use the forementioned lpClass member, holding the link path, as the title (lpTitle member) of a new STARTUPINFO object used when calling CreateProcess (and thus, launching the
new application). So that this application will be aware that she was launched via a link (therefore we become compliant with the STARTF_TITLEISLINKNAME documentation).
svn path=/branches/ros-csrss/; revision=58480
- Define all the missing STARTF_* flags needed for the STARTUPINFO structure (taken from http://msdn.microsoft.com/en-us/library/windows/desktop/ms686331(v=vs.85).aspx).
Amongst them is the STARTF_TITLEISLINKNAME flag that I use in the console server to determine whether a console app was started from a shell link, and if so, extract
the name of the link and its icon.
- Define all the missing SEE_MASK_* flags needed for the SHELLEXECUTEINFO structure, but the Windows 8 flag (taken from http://msdn.microsoft.com/en-us/library/windows/desktop/bb759784(v=vs.85).aspx).
Furthermore I add three undocumented flags, SEE_MASK_HASLINKNAME, SEE_MASK_HASTITLE and SEE_MASK_FLAG_SEPVDM. These three flags are undocumented and even not present in the official Windows SDK.
However they are used in shobjidl.idl to define some CMIC_MASK_* flags, these ones being mentioned in the MSDN documentation of the CMINVOKECOMMANDINFOEX structure (see http://msdn.microsoft.com/en-us/library/windows/desktop/bb773217(v=vs.85).aspx).
So I affect them a range of values which seems to be strangely empty (see the code). Of course their values may differ from the real ones, however I have no way of discovering them. If somebody else
can verify them, it would be great.
svn path=/branches/ros-csrss/; revision=58479
- Implement SamIConnect.
- Add a trusted caller flag to the database object type and inherit it to opened or created sub objects.
- Restrict access to SamrQueryInformationUser.UserInternal1Information for non-trusted callers.
svn path=/trunk/; revision=58472
Clarify few parts of code; remove unneeded comments and DPRINTs; start documentation of the CsrCreateProcess routine.
[BASESRV-CONSRV-WINSRV]
Correct the sizes of the API tables.
[SM]
Correct the API names.
svn path=/branches/ros-csrss/; revision=58464
Attempt to fix terminal window positioning at initialization. Some work also needs to be done in console.dll.
svn path=/branches/ros-csrss/; revision=58463
In LsapCreateDatabaseObjects pass the pointer AuditEventsInfo to LsapSetObjectAttribute instead a pointer to the pointer. Fixes 1 advapi32::lsa winetest when compiled with the new BE.
svn path=/trunk/; revision=58461
- Implement LSA dispatch routines LsapAllocateClientBuffer, LsapFreeClientBuffer, LsapCopyToClientBuffer and LsapCopyFromClientBuffer.
- LsapCallAuthenticationPackage and LsapLogonUser: Copy data from the callers address space into a local buffer and pass it to the authentication package.
svn path=/trunk/; revision=58457
No need to check ApiMessage.Status if you also check the returned value of CsrClientCallServer because, according to dll/ntdll/csr/connect.c:CsrClientCallServer, the (only) return value of CsrClientCallServer _is_ equal to ApiMessage.Status (vide line 169).
svn path=/branches/ros-csrss/; revision=58456
Remove the old implementation of GetConsoleInputWaitHandle which was commented-out for some time.
[BASESRV]
Correct few names.
svn path=/branches/ros-csrss/; revision=58454
Fix CsrCaptureTimeout (verified against Windows Server 2003).
[KERNEL32-CSRSRV-BASESRV-CONSRV-WINSRV]
Clean the code: remove unuseful comments and dprints, reorganize a little bit few source files.
svn path=/branches/ros-csrss/; revision=58453
- Move LsapLookupAuthenticationPackage, LsapCallAuthenticationPackage and LsapLogonUser from authport.c to authpackage.c.
- Make LsapCallAuthenticationPackage and LsapLogonUser call the matching authentication package functions.
svn path=/trunk/; revision=58451
Fix the initialization of screen buffers (concerning the cursor size).
[KERNEL32]
Fix almost all of the console winetests. Only 26 tests remain to be fixed, concerning principally WriteConsoleInputA/W and GetNumberOfConsoleInputEvents.
svn path=/branches/ros-csrss/; revision=58448
- Start to sort out things that depends only of the internals of a console, and things which are only related to "terminal emulators". Do it especially for (what I will call starting from now) the "GUI terminal emulator".
- Temporarily deactivate starting "TUI terminals".
- Temporarily break report that the terminal window is held by the current running console application in it (see r58107). This will be fixed later on.
svn path=/branches/ros-csrss/; revision=58447
* Fix some format specifiers (part 2 of r58442). Thanks Amine :)
* Remane two "global" static variables to avoid name collision warnings.
svn path=/trunk/; revision=58443
* Add "/nologo" to the MSVC resource compilation rule. Brought to you by Yu Pan (binsys {at} 163 dot com).
CORE-6997 #resolve #comment Committed in r58438.
svn path=/trunk/; revision=58438
- Fix a bug in EngLoadModuleEx
- Fix a bug in co_IntLoadSysMenuTemplate
- Fix / improve a number of annotations
- Improve code in NtGdiExtGetObjectW
- Check return value of ZwAllocateVirtualMemory and handle error in GdiPoolAllocate
- Fix possible memory leaks in NtGdiPolyDraw
- Check for NtGdiExtCreatePen == NULL instead of passing it to ProbeForRead in NtGdiExtCreatePen
- Simplify code in NtGdiGetTextMetricsW
- Fix a number of format specifiers
svn path=/trunk/; revision=58434
- Get all procedure addresses of the loaded authentication packages and keep them in the authentication package entry.
- Implement parts of the lda dispatch table (allocate heap and free heap) and pass the table to LsaApInitializePackage call.
- Implement authentication package lookup by name.
[MSV1_0]
- Store the dispatch table entries passed to the LsaApInitializePackage call and use them to allocate a STRING to return the package name.
svn path=/trunk/; revision=58427
Properly handle glyph positions and take target coordinate transformation into account when caching glyphs. (This is suboptimal, since we might cache duplicates of the same glyphs, but it works). Fixes CORE-4657.
svn path=/trunk/; revision=58418
Fix the console properties dialog, when launching and transmitting console properties. Before, the properties dialog was directly launched by the console server (consrv), running with CSRSS (System) privileges, what constituted a security hole. Now, I create a remote thread in the running process owning the console for launching the properties dialog (thus it has only user privileges, and not System ones anymore). For that purpose, I basically took the technique described in the following paper (Cesar Cerrudo, "Story of a dumb patch", http://www.argeniss.com/research/MSBugPaper.pdf or http://www.scn.rain.com/~neighorn/PDF/MSBugPaper.pdf), where basically the console server shares the console properties via a shared memory section with the console properties dialog dll. The address of the thread which launches the dialog in the context of the console app is given to the console server the same way as we do for the control handler (called e.g. when you press Ctrl-C, etc...)
Of course this is quite hackish, because you have the GUI interface split between the console server and the console properties dialog dll. Something far more elegant would be to put all the GUI thingie into a dedicated dll or exe, running with the same privileges as the console program itself (a kind of console -- or terminal -- emulator).
[CONSOLE.DLL]
Fix retriving / setting colors.c and other things.
[CONSRV.DLL]
- Fix retrieving / setting console properties from the registry (via the HKCU\Console\* keys), via the shell shortcuts (not totally done at the moment, because somebody has to implement properly that thing : http://msdn.microsoft.com/en-us/library/windows/desktop/bb773359(v=vs.85).aspx (NT_CONSOLE_PROPS structure stored as a shortcut data block) (at application launching time), and via the console properties dialog.
- Few DPRINTs removed.
svn path=/branches/ros-csrss/; revision=58415
Remove LsaRegisterPolicyChangeNotification and LsaUnregisterPolicyChangeNotification because they are not exported by advapi32.dll. These functions are exported by secur32.dll instead.
svn path=/trunk/; revision=58413
- Remove CsrSetLogonNotifyWindow
- Use a reactos only TWOPARAM_ROUTINE_EXITREACTOS call in order to start the shut down process in winlogon
- Use a NOPARAM_ROUTINE_ISCONSOLEMODE call in DtbgIsDesktopVisible to fix detecting console mode in gui-on-demand mode
svn path=/trunk/; revision=58411
- Fix the "grey panel" bug when doing File --> New.
- Add the possibility, when doing File --> New, to save the drawing the user did before actually reset it, and take into account whether he/she cancels the operation in the middle.
Patch by Marco Vaiano, slightly modified by me.
CORE-5642 #resolve #comment Committed in revision r58408. Thanks :)
svn path=/trunk/; revision=58408
- Replace the old LogonStatus variable by a LOGON_STATE enum type.
- Declare and document all new states and their transitions.
svn path=/trunk/; revision=58391
- Make NtUserSwitchDesktop hide the previous desktop window and show the new one. This doesn't change much yet as winlogon still uses only one desktop
svn path=/trunk/; revision=58386
CORE-6977 #comment Make sure the buffer for NtQueryInformationAtom is ULONG aligned. Fixes failed atom tests on ReactOS and Windows when compiled with GCC 4.7.2. Should be sent to wine. Keeping the jira issue open.
svn path=/trunk/; revision=58378
CORE-6969 Adding a check to skip a test after failure instead of continuing with uninitialized memory. "Fixes" a crash when compiled with GCC 4.7.2
svn path=/trunk/; revision=58377
- Do not set the current thread desktop automatically the first time CreateDesktop is called. The caller is supposed to call SetThreadDesktop to specify which desktop should be used
svn path=/trunk/; revision=58376
Get rid of reactos_arc_hardware_data, which wasn't used anyway. This frees up 16KB of memory. Don't reallocate the PARTIAL_RESOURE_LISTs in FldrCreateComponentKey, instead take over the ones passed by the caller.
svn path=/trunk/; revision=58369
- Fix a bug in StartupWindowThread that had as a result to close the desktop handle we get from winlogon. The problem is the wrong usage of SetThreadDesktop as it closes the previous desktop, so keeping OldDesk is totally useless and when the thread exits it will close the handle to the current thread desktop which is Session->WinlogonDesktop from winlogon. To solve this issue we have to duplicate the handle we get from winlogon and let it get closed by win32k when the thread exits
svn path=/trunk/; revision=58367
- Fix a nasty bug in IntTrackMouseMove that prevented us from stopping the ID_EVENT_SYSTIMER_MOUSEHOVER timer.
- IntKillTimer requires a PWND as first argument but we were passing an HWND and as a result the timer was never stopped
- Fixes the remaining failed tests for TrackMouseEvent (besides queue state tests)
svn path=/trunk/; revision=58364
- Implement WlxScreenSaverNotify. I decided to return a hardcoded FALSE because RegQueryValueExW always reads "1", although there is a "0" written in the registry. Will fix it later.
svn path=/trunk/; revision=58363
- Use the "Fixedsys Excelsior 3.01-L2" font instead of "Fixedsys Excelsior 3.01" for the Fixedsys font substitution (the *-L2 version corrects a bug when displaying the letter 'A'-upper-case).
- Add the font-substitute "Lucida Console" to "DejaVu Sans Mono".
svn path=/trunk/; revision=58362
When processing forwarders and the target image was not yet loaded, try to load it (using .dll extension if no extension is given)
svn path=/trunk/; revision=58361
- Remove the SCRNSAVE.EXE value from the registry and set ScreenSaveActive to "0" as this is the setting for "None" screen saver.
- Change screen saver settings the way Windows XP does it.
svn path=/trunk/; revision=58360
- Call DispatchSAS when the screen saver is started by a WM_LOGONNOTIFY message.
- Lock the workstation after the screen saver was terminated.
svn path=/trunk/; revision=58359
Remove calls to SystemParametersInfoW(SPI_SETSCREENSAVEACTIVE,... as it does not make sense to activate and deactivate screen savers when activating or deactivating the screen saver page. The screen saver should be activated when the user chooses a screen saver and it should be deactivated when the user chooses the "None" option.
CORE-6963#resolve
svn path=/trunk/; revision=58358
Remove pre-saved console default settings in the registry. They will be set by consrv itself at initialization (Work In Progress).
svn path=/branches/ros-csrss/; revision=58357
- hopefully put an end to this embarassing succession by adding missing linkage to msvcrt where needed.
Than you ld, for getting symbols out of thin air
svn path=/trunk/; revision=58356
- Add ENABLE_INSERT_MODE, ENABLE_QUICK_EDIT_MODE and ENABLE_EXTENDED_FLAGS flags.
- Add GetConsoleAliasExesA/W and GetConsoleAliasExesLengthA/W api definitions.
[DOSKEY]
Remove unneeded definitions since now these are declared in the psdk.
svn path=/branches/ros-csrss/; revision=58345
- Do not assume all zeroes in PE sections that contain uninitialized data. Such sections can have other contents as well, and MiReadPage already provides zeroes for outside-of-file data anyway
CORE-6958 #resolve
svn path=/trunk/; revision=58344
- Add an icon.
- Fix some labels in the property box and the disposition of controls in english and french resources (not in all because positions change between languages and I've no time synchronizing by hand all the resource files, removing the differences).
svn path=/branches/ros-csrss/; revision=58343
- Remove the WM_SYSMENU style from the security dialog.
- Add the unlock dialog.
- Fix the layout of the german logon dialog. Password and user name are left-aligned again.
svn path=/trunk/; revision=58328
- Fix a typo in the german lock dialog.
- Store the user name and domain in the gina context and use them in the lock dialog.
- Initialize the LOGONSERVER environment variable.
svn path=/trunk/; revision=58326
Create a context struct when the client is registered and delete it when the client is deregistered. In the mean time, pass the context to all client authentication functions. The context contains a handle to the client process and a handle to the current connection port. The process handle will later be used to retrieve and return logon data and to pass the toke handle back to the client.
svn path=/trunk/; revision=58308
Code reorganization only : move the console-related initialization functions into a dedicated file, and create a specific header to hold console function definitions.
svn path=/branches/ros-csrss/; revision=58306
- Introduce a CONSOLE_PROPS structure to hold console properties such as its title or startup attributes it should have. Initialized at console application launch time. I have to see how could it be possible to merge this structure with some parts of the GUI_CONSOLE_DATA structure and of the ConsoleInfo structure from console.dll (in /dll/cpl).
- Use a helper function to initialize the CONSOLE_PROPS structure in kernel32, at console app start or when calling AllocConsole.
- In BasepInitConsole, do initialization of CONSOLE_PROPS and related only if we are about to launch a console app.
[CONSRV]
- Adapt CONSOLE_CONNECTION_INFO and CONSOLE_ALLOCCONSOLE structures to take into account CONSOLE_PROPS.
- Fix the way we are setting console titles.
- Add experimental support for loading console properties and title and icon from shell links, thanks to the helper LoadShellLinkInfo. However I'm using there Shell COM facility to extract link properties (I could do it "the RAW way", however I would then know the format of link files, that I don't know and that I don't want to mix up with the console code). Therefore I must add dependencies to uuid and ole32 libraries. Note that icons are used in GUI consoles only (use the PrivateExtractIconExW function to retrieve both handles to the big and small icons at the same time).
Part 1/2
[CONSRV]
- Remove an unuseful xxxInitScreenBuffer function in the virtual functions console table.
- In GUI_CONSOLE_DATA structure and related functions, temporarily explicitely mark which members may be used for both GUI and TUI consoles (for a future simplification).
- Add temporary debug prints when we are setting console icon, to see the flow of calls (will be removed just before merging back to trunk).
- Add temporary debug prints in ConSrvInitConsoleScreenBuffer and ConioDeleteScreenBuffer, to figure out how SBs are initialized.
svn path=/branches/ros-csrss/; revision=58305
- Add the LSA_CONNECTION_INFO struct to the LSA_API_MSG in order to handle the connection info in an easy way.
- Let the connection handler return OperationalMode and Status values. This obsoletes a separate register call to lsasrv.dll, thus remove the register call code entirely.
- Add dispatcher code and stubs for the remaining client calls.
- Add experimental implementation of LsaCallAuthenticationPackage and LsaLogonUser.
svn path=/trunk/; revision=58304
Make the call sequence LsaRegisterLogonProcess, LsaLookupAuthenticationPackage, LsaDeregisterLogonProcess work without failures or loss of connection. WIP.
svn path=/trunk/; revision=58303
* Rely on CMAKE_HOST_WIN32 instead of CMAKE_HOST_SYSTEM_NAME which, sometimes, isn't set for some reason. Should fix the incorrect MINGW_TOOLCHAIN_PREFIX value issue.
svn path=/trunk/; revision=58292
* Fix a corner case when the start segments overlaps the end segment in Chord(), Pie(), Arc() and ArcTo() functions.
* This should fix the Pie chart in "Disk Properties" when all the space is used.
* Brought to you by Victor Martinez Calvo.
CORE-6848 #resolve #comment Committed in r58291. Thanks !
svn path=/trunk/; revision=58291
* Account for the fact that PID_SECURITY is defined in propidl.h with a different value. Spotted by Sylvain.
CORE-6930 #resolve #comment Fixed in r58289.
svn path=/trunk/; revision=58289
- Actually fail when the maximum number of reparse attempts is reached in ObpLookupObjectName. It previously returned a pointer to whatever object was currently in charge of parsing, but without taking a reference to it.
- Fixes 'Header->HandleCount == 0' assertion failure (on \REGISTRY object) after running ntdll_winetest:reg three times (and also fixes the remaining test failure)
svn path=/trunk/; revision=58281
* Add transparency to icons in the task bar and in the tray bar. Brought to you by Carlo Bramini.
CORE-6938 #resolve #comment Committed in r58279. Grazie ;)
svn path=/trunk/; revision=58279
Fix build, but remove support for architecture specific inf sections. This means livecd cannot have those until someone implements this. I give up...
svn path=/trunk/; revision=58276
- Implement support for architecture specific INF sections both in mkhive and in usetup (For an example, check hivesys.inf at the bottom)
- Get rid of architecture specific .inf files
svn path=/trunk/; revision=58271
- Add interface function to IUSBHardwareDevice, which returns the USB controller type
- The controller type is used for debugging in the common usb library (libusb)
svn path=/trunk/; revision=58268
- Ignore the unsupported MEM_TOP_DOWN flag instead of failing NtAllocateVirtualMemory
CORE-6392 CORE-6805 #comment MEM_TOP_DOWN should be sufficiently fixed in r58266, and setup now starts. Please confirm.
svn path=/trunk/; revision=58266
- Process startup items before creating the desktop. Fix some comments, add TODOs. Based on patch by Edijs Kolesnikovičs.
CORE-6896 #resolve
svn path=/trunk/; revision=58262
- Further compactify console allocation / attach code by putting common code into helper functions.
- Now, the default title of a console window is... "ReactOS Console" (and not command prompt since a console window isn't only reserved to command prompts).
svn path=/branches/ros-csrss/; revision=58260
SamSetInformationUser: Build the LM password and calculate the LM password hash in the UserSetPasswordInformation case.
svn path=/trunk/; revision=58259
Remove a comment becoming pointless since revision r58255.
[WIN32SS]
Remove an operation, redundant since revision r58255.
svn path=/trunk/; revision=58257
SamSetInformationUser: Add special code for the UserSetPasswordInformation class that calculates the NT hash of the password and stores it by calling SamrSetInformationUser using the UserInternal1Information class.
svn path=/trunk/; revision=58256
- Add a macro which specifies how much space chars a TAB is.
- Implement BELL ANSI character handling (basic) and add temporary DPRINTs to see who is called (by the way, Beep() functions seems not to work correctly).
svn path=/branches/ros-csrss/; revision=58253
- Remove x64 asm stub for acos from cmake file, since we already have a generic C implementation
- Implement sqrt for amd64 in SSE, both in C and asm. While the C version would be sufficient, it's currently less portable due to the lack of mm intrinsics for GCC
- Silence a warning
svn path=/trunk/; revision=58251
- Add a DPRINT with more info to the 'Hash == TableMask' assertion
- Validate pool tags on free also for big allocations
- Validate pool tag earlier, before tracking the free operation
CORE-6929
svn path=/trunk/; revision=58246
Implement IoCancelFileOpen().
You can read: http://www.osronline.com/showThread.cfm?link=20807
Even though the proposed implementation is closer to W2K implementation than to W2K3 implementation
In W2K3, no IRP is issued with major close.
svn path=/trunk/; revision=58244
Implement IopAllocateIrpMustSucceed() which is designed to *normally* always return an IRP.
Even in low memory situations (if you wait enough).
svn path=/trunk/; revision=58243
Revert my change of loading the win32k kernel-mode subsystem driver by reading the Kmode value and use instead a hardcoded value, per request of Alex.
I'm wondering why Windows wouldn't allow you to use a personalized value there and forces you to use win32k with this name, placed in \SystemRoot\System32 directory and not in an other place.
svn path=/trunk/; revision=58241
- Uniformize the error messages and also, SmpParseCommand is SmpParseCommandLine in fact.
- Remove an unneeded cast since Flags is already ULONG.
svn path=/trunk/; revision=58238
Modify driver acquiring/releasing privilege according to r58233. The corresponding modification in services.c will be done at the next synchronization.
svn path=/branches/ros-csrss/; revision=58234
Fix acquiring/releasing driver-loading and unloading privilege (see r57754) by using the RtlAdjustPrivilege API instead of using the standard user-mode Win32 API (thus get rid of calling LSA when calling LookupPrivilegeValueW).
svn path=/trunk/; revision=58233
- Zero-out some allocated memory.
- During my investigations preceding the implementation of AttachConsole (r58166), I wanted (in a first attempt; finally I've found a better way to achieve what I wanted to do) to retrieve the CSR_PROCESS structure of the parent of a given process. I've found the 'Parent' member in the CSR_PROCESS structure, however this member was always initialized to NULL when new processes were created via CsrCreateProcess (and via the call to CsrInsertProcess). After looking at some informating here (http://svn.reactos.org/svn/reactos/trunk/reactos/include/subsys/csr/server.h?r1=17363&r2=17362&pathrev=17363) and there (http://forum.sysinternals.com/csrwalker-processes-detection-from-user-mode_topic15457.html), I became convinced that the 'Parent' member was unexistent starting from Windows Server 2003. Also, after much more investigation, I've found that the CsrInsertProcess function was called with only two parameters starting from Windows Server 2003 (and still continues in Windows 7), the always-NULL paramater being removed.
Therefore, I remove that unneeded parameter from CsrInsertProcess and the corresponding 'Parent' member from CSR_PROCESS.
svn path=/branches/ros-csrss/; revision=58232
Clean-up IntReadConsoleOutputCode a little bit.
[CONSRV]
Fix a buffer overflow in SrvReadConsoleOutputString, which was translated sometimes into heap corruption and assert, triggered when freeing a remote captured buffer in csrsrv, when executing kernel32_winetest console, just during a call to ReadConsoleOutputCharacterA.
Nevertheless I still keep the culprit code (commented-out now) because it might be useful in the future.
svn path=/branches/ros-csrss/; revision=58229
- Actually put in the C++ headers what our CRT implements, instead of some random mix of libstdc++ and who knows what. This means the header contents are somewhat outdated and non-standard, but that's preferable to unusable
- Fix a forward declaration in math.h
svn path=/trunk/; revision=58228
Fix a fixme in IopParseDevice() by calling SeOpenObjectAuditAlarm().
Won't change anything right now since it calls a stub.
svn path=/trunk/; revision=58226
- Use set_cpp instead of hand-coding all the parameters
- Use comutil.h and link with comsupp unconditionally, since we now have them
- Use STLPort-compatible filebuf constructor for TCHAR iostreams
- Fix a few MSVC and GCC 4.7 errors/warnings
svn path=/trunk/; revision=58224
- Import C++ compiler support headers from mingw-w64 (with some fixes)
- Implement the required parts of the comsupp library
svn path=/trunk/; revision=58223
- Do not allow multiple "Taskbar and Start Menu Properties" windows. Based on patch by Edijs Kolesnikovičs & Grégori Macário Harbs.
CORE-6885 #resolve
svn path=/trunk/; revision=58217
- Add missing domain information types to ntsam.h and fix conflicts in ntsecapi.h and sam.idl.
- Add SamChangePasswordUser, SamChangePasswordUser2 and SamChangePasswordUser3 stubs.
svn path=/trunk/; revision=58216
* This significantly shrinks the dependency tracking data and the compiled objects size, which speeds up the whole build process (especially the incremental builds) accelerating the daily development as a result.
* No intended code changes, ~27% smaller build. Enjoy ;)
svn path=/trunk/; revision=58214
Rename functions to their new scheme: ConSrv* instead of Win32Csr* or Conio* (with some exceptions for the latter case).
No code changes.
svn path=/branches/ros-csrss/; revision=58213
- Start to implement waiting threads notifications. They can be notified by:
* the required action (screen displaying lock/unlock, presence of new characters in the input buffer),
* the fact that the application terminates,
* we close a (input) handle.
TODO: When we notify them by calling CsrNotifyWait, they are not dereferenced automatically, but they can be
by calling a dedicated CSR function. We need to know where it is the best to dereference them.
- Correct a bug introduced in revision r58191, which broke console input mode changes (in SrvSetConsoleMode and SrvGetConsoleMode).
svn path=/branches/ros-csrss/; revision=58211
- Do not allow multiple run dialogs. Based on patch by Edijs Kolesnikovičs & Grégori Macário Harbs.
CORE-6871 #resolve
svn path=/trunk/; revision=58208
- Start to uniformize some helpers' names :
ConioLockConsole --> ConioGetConsole and ConioUnlockConsole --> ConioReleaseConsole
ConioLockInputBuffer --> ConioGetInputBuffer and ConioUnlockInputBuffer --> ConioReleaseInputBuffer
ConioLockScreenBuffer --> ConioGetScreenBuffer and ConioUnlockScreenBuffer --> ConioReleaseScreenBuffer
but the overall naming must be revamped.
- Add them a boolean parameter to determine whether or not we should lock the console. It is useful to not lock an already locked console when input / output waiting threads are called,
because these are called from functions which lock the console.
- In the GUI console window message loop, after retrieving a pointer to the corresponding console, lock it before calling funtions in the message dispatcher (and unlock the console at the end).
- Use PostMessage instead of SendMessage for "sending" GUI messages to console windows, to avoid possible deadlocks (because of console locking).
- Add temporary /// LOCK /// comments to easily localize where I deactivated extra console (un)locking code (this remains to be analyzed further).
svn path=/branches/ros-csrss/; revision=58205
- Remove duplicate dllimport attributes CORE-6917 #resolve
- Add annotations for wcslen
- Add kernelspecs.h (complete)
- Add some more entries in driverspecs.h
- Fix a number of annotations
svn path=/trunk/; revision=58204
Add bitmap font for code page 862. Hebrew glyphs are from X11 font
"Schumacher Clean" (see license below), modified by Baruch Rutman
(peterooch*at*gmail*dot*com). CORE-6912.
Copyright 1989 Dale Schumacher, dal@syntel.mn.org
399 Beacon Ave.
St. Paul, MN 55104-3527
Permission to use, copy, modify, and distribute this software and
its documentation for any purpose and without fee is hereby
granted, provided that the above copyright notice appear in all
copies and that both that copyright notice and this permission
notice appear in supporting documentation, and that the name of
Dale Schumacher not be used in advertising or publicity pertaining to
distribution of the software without specific, written prior
permission. Dale Schumacher makes no representations about the
suitability of this software for any purpose. It is provided "as
is" without express or implied warranty.
svn path=/trunk/; revision=58202
- Improve help strings for GCC optimization levels.
- Add new -Ofast and -Og levels.
- Simplify gcc.cmake a bit.
- Use MINGW_TOOLCHAIN_SUFFIX.
svn path=/trunk/; revision=58201
Some keyed event fixes: disable APCs before acquiring the pushlock, close handle on exception, check if a wait was aborted and remove the wait list entry from the list in that case.
svn path=/trunk/; revision=58200
- Add a generic delete function for database objects.
- Do not create Members sub keys for group objects.
- Get rid of the SamDbContainerObject object type.
- Implement SamrDeleteGroup.
svn path=/trunk/; revision=58196
- Get in a simpler way the console owned by a console window: replace GuiConsoleGetDataPointers by GuiGetWindowConsole.
- Only in functions which need it, we get the GUI data held by the console.
svn path=/branches/ros-csrss/; revision=58194
[XDK/DDK] Add missing annotations, move some prototypes to more appropriate headers
[NDK] Fix a number of annotations
[NDK] Use SAL2 dummys from umtypes as well
svn path=/trunk/; revision=58193
- Isolate the members of the CONSOLE structure which are used as input buffer data, in a new structure called ... CONSOLE_INPUT_BUFFER !
- Rename some helper functions to better match what they are doing.
svn path=/branches/ros-csrss/; revision=58191
- Hide minimized window captions (and enable shell notifications, thus fixing taskbar buttons). This should have been in r57978, but got lost.
- From Andrew Green's GSoC branch. Spotted by Edijus.
CORE-6899 #resolve
svn path=/trunk/; revision=58186
- Italian Translation and fix duplicate MENUITEM in fr-FR.rc, ko-KR, no-NO.rc files. Patch by Ivan Di Francesco.
- Adapt a little bit French translation (by me).
CORE-6908 #resolve #comment Committed in r58185. Thanks !
svn path=/trunk/; revision=58185
Introduce new helper functions Win32CsrInitHandlesTable and Win32CsrAllocateConsole and use them in many places (in ConsoleConnect, SrvAllocConsole and SrvAttachConsole).
svn path=/branches/ros-csrss/; revision=58184
Fix support for CONIN$ and CONOUT$, and add support for CON special file
(now, writing to C:\CON or C:\somepath\CONIN$ or C:\anotherpath\CONOUT$ works).
svn path=/branches/ros-csrss/; revision=58182
- Temporary make the property dialog working again (but it's not the ultimate solution).
- in conio.h : members reorganization only.
svn path=/branches/ros-csrss/; revision=58177
[RTL] Use RtlpTimeout for critical sections, which is initialized from the PEB. Implement using the LowMemory keyed event, when allocating the normal event failed.
svn path=/trunk/; revision=58175
- Seperate some usermode only heap functions into their own file and implement dummys in the kernel rtl so that they don't get included in the kernel
- Convert usage of RTL_CRITICAL_SECTION in heappage.c to use of HEAP_LOCK
- Implement A kernel dummy for RtlCallVectoredExceptionHandlers, so we don't put vectored exception handler code into ntoskrnl
- Now we don't have critical section code in the kernel anymore, which wasn't working anyway.
svn path=/trunk/; revision=58173
- Finish to do the replacements HeapAlloc --> RtlAllocateHeap and Co.
- Finish to UNICODify consrv (it happens that it has been almost done already).
- Modify the way we start BlueScreen driver (in TUI mode): instead of using the SCM which, at that moment, is starting (and is not ready to answer to start/stop services requests), use the NT apis to start the driver (in the same way the SCM performs driver starting).
- Add a note on HAVE_WMEMSET.
svn path=/branches/ros-csrss/; revision=58169
- Correct a error return code (in AllocConsole).
- Implement AttachConsole (inspired by AllocConsole).
[CONSRV]
- Correct a error return code (in AllocConsole).
- Introduce helper functions to simplify console-initialization code.
- Implement server-side of AttachConsole (I used pieces of code from ConsoleNewProcess, ConsoleConnect and SrvAllocConsole).
Some debug prints were introduced (for debug-purposes :P), will be removed when all things work.
TODO: have a look on the handles code.
svn path=/branches/ros-csrss/; revision=58166
- SamrAddMemberToGroup: Add the group membership to the user object.
- SamrRemoveMemberFromGroup: Remove the group membership from the user object.
svn path=/trunk/; revision=58161
Add an error icon to the C Runtime termination message box.
Patch by Lee Schröder.
CORE-6886 #resolve #comment Committed in r58157, thanks :)
svn path=/trunk/; revision=58157
Fix the debugging macros introduced in r58132 (for the _FATAL case):
do not use exceptions but instead a breakpoint followed by a process termination procedure (or a bugcheck if we are in kernel mode).
Feel free to improve them !!
[DRIVERS-HAL]
Finish to use the new debugging macros
Part 3/3
svn path=/trunk/; revision=58154
Rewrite DisplayCharacter. The new algorithm is much faster. It uses the VGA mask register to draws up to 8 pixels at once, completely getting rid of the inner loop. Pixel position / mask calculations and the check for opaque vs transparent background are moved out of the loops. The result is a single loop for the y coordinate containing an inlined __outbyte and memory write. A second loop in case of unaligned character writes.
svn path=/trunk/; revision=58148
Apply the following optimizations:
- include ioaccess.h to inline port access, instead of going through hal.
- Make __outpb and __outpw macros rather than stdcall function
- Make SetPixel FORCEINLINE
- Do not switch mode for every pixel we write, instead do it once before doing larger blt operations
- use __movsb instead of manual loop plus READ/WRITE_REGISTER_UCHAR
This noticeably improves performance.
svn path=/trunk/; revision=58147
Add the source login logo .svg file. To make the bitmap, export the .svg file in png, then save the png in Bitmap 24bits.
svn path=/trunk/; revision=58145
Note to people:
~=~=~=~=~=~=~=~
- The msgina (login) logo is made from a .svg file. The copyright line text has font Lucida Sans Unicode (this font allows you to have the right length to the year-dash-separator). DejaVu Sans may also work. I would prefer to use the other logo used as the header for the ReactOS Welcome program (welcome.exe from the CD), but also it is given as a .bmp and I would like to have a .svg or some equivalent format to use it (with little modifications though) as a new login logo (in particular, rescaling it).
- Adjust the boot-logo year, also with the Lucida Sans Unicode font. This was done with Paint from Win2k3 (WARNING!! Not with Windows 7 Paint !!) because it keeps the palette of the opened bitmap, contrary to Windows7 one.
- If somebody has the original boot-logo file (a .svg, ..., something else?), then signal it to me !
svn path=/trunk/; revision=58144
- Use __debugbreak in _assert when user presses ignore in the message box
- Implement __crt_MessageBoxA and use it from _assert and abort
- Rewrite abort and _set_abort_behavior
- Add function headers and set BSD license for my code
- CORE-6594 #resolve
svn path=/trunk/; revision=58143
* For anyone who wants to work only on a certain module (or a set of modules), you can add "project(module)" to the related CMake file. This will generate a solution that contains all the required dependencies needed to compile only that module, without having to open a huge solution with 900+ projects.
* We'll create a wiki page to explain how to use this in detail.
* Dedicated to all VS users. Have fun ;)
svn path=/trunk/; revision=58141
- Fix the debugging macros I've introduced in r58132; in particular do not use while(true); for forbidding the user to continue execution, but instead raise an exception with EXCEPTION_NONCONTINUABLE flag (included when called RtlRaiseStatus).
- Adjust the definition of RtlRaiseStatus (in kernel-mode it is ExRaiseStatus which is used).
svn path=/trunk/; revision=58135
- romanian translation update by Stefan Fulea; CORE-6718
- fix for japaneese cmd translation by Tomoya Kitagawa; CORE-6820
- polish translation update of desk and input;
svn path=/trunk/; revision=58134
Introduce four new debugging macros, ERROR_DBGBREAK, ERROR_FATAL, UNIMPLEMENTED_DBGBREAK, UNIMPLEMENTED_FATAL (and two helpers, __NOTICE and __ERROR_DBGBREAK).
They are designed to display on the debug-log a printf-like user-defined message and to break into the debugger.
- The *_DBGBREAK macros break only into the debugger and allow to continue (they don't hang).
- The *_FATAL macros break into the debugger and then halt the execution.
(Based on an idea of Aleksey Bragin, see the ros-dev mailing list about the while(true) --> assert(false); changes).
[NTOSKRNL]
Use these macros instead of ASSERT(FALSE); introduced in revisions r58110, r58111 and r58112 to replace while(TRUE); halts.
Part 1/3
svn path=/trunk/; revision=58132
- NetUserGetInfo: Add Support for info level 23.
- Convert UserAccountControl flags to user info flags and convert last logon, last logoff and account expires time.
svn path=/trunk/; revision=58130
- Correctly show current time zone name even if no daylight saving settings are set. Patch by Lee Schroeder.
CORE-6803 #resolve #comment Fixed, thanks. Sorry for the long wait.
svn path=/trunk/; revision=58126
- Move "Show window previews (thumbnails)" option to advanced tab, as it doesn't exist in Windows. Patch by Edijs Kolesnikovičs.
CORE-6840 #resolve
svn path=/trunk/; revision=58124
- Plug a memory leak in IDropTargetImpl
- Do not allocate 64x the required space in TaskSwitchWnd_AllocTaskItem
- Properly free and unregister the tray window
- Fix a few more style issues
svn path=/trunk/; revision=58123
Check for NULL parameter in the function CsrLocateThreadByClientId. Triggered when it was called by CsrApiHandleConnectionRequest during tests (the call to CsrLocateThreadByClientId happens in line 146 of api.c).
svn path=/branches/ros-csrss/; revision=58121
Rename some structures (CSRSS_... ---> CONSOLE_...) and clarify what the ConsoleHandle members are for (--> OutputHandle or InputHandle).
No code changes otherwise.
svn path=/branches/ros-csrss/; revision=58119
Implement SamrQueryInformationUser.UserParametersInformation and set the Parameters attribute when a new user is created.
svn path=/trunk/; revision=58117
In NtGdiStretchDIBitsInternal check early for info dc / mem dc without surface, only allocate memory and copy bits if the caller actually passed bits (they are optional), free the allocation, when an exception happens instead of leaking the memory.
svn path=/trunk/; revision=58116
and in some cases, return an adequate value. In some places however, I add an ASSERT(FALSE); before keeping the while (TRUE); in critical regions.
(Only x86, as well as in r58110). More ASSERTS (in debug mode) or BSODs may appear, instead of having hung threads.
Part 1-bis/2
svn path=/trunk/; revision=58111
Implement DC_hSelectFont, use it from NtGdiSelectFont and GdiFlushUserBatch. Make sure plfnt is != NULL before dereferencing it in "TEXTOBJ_LockText"
svn path=/trunk/; revision=58109
- Start to implement NtUserConsoleControl to allow the console server define Console Window Class atom.
- In UserInitialize, initialize the current thread by a call to UserCreateThreadInfo.
- In UserCreateThreadInfo, set the TIF_CSRSSTHREAD flag for threads created by CSRSS.
- In NtUserQueryWindow, when querying the process/thread ID associated to a given window, check whether the window was created by CSRSS and if so, if this is a Console window, get the process/thread ID of the associated console process (console leader process), instead of the CID of CSRSS.
[CONSRV]
- Introduce the concept of console leader process (to be used as the process owning the console window).
- Introduce extra console window information to store the PID and TID of the console leader process via new internal flags to be used by GetWindowLong.
- Effectively set the console window console leader CID at its creation.
- Improve CsrInitConsole to set a console leader process to the console being created.
This fixes http://jira.reactos.org/browse/CORE-122 in this branch.
[CONSRV-WIN32K]
Fix various code misspellings.
svn path=/branches/ros-csrss/; revision=58107
Remove a temporary DPRINT1.
[CSRSRV]
- Shut down debug output.
- Fix some misspellings.
- Fix a bug in CsrMoveSatisfiedWaits ("satisfied" waits are waits where WaitFunction was put to NULL during a previous call to CsrNotifyWait, but still not dereferenced, and which can be dereferenced by a call to CsrDereferenceWait).
svn path=/branches/ros-csrss/; revision=58103
- Fix console apps initialization.
- Add some debug output (NOTE TO MYSELF: remove them when all things work).
- Rewrite ConsoleNewProcess.
- Reorganize SrvAllocConsole and create ConsoleConnect based on SrvAllocConsole.
- Create ConsoleDisconnect which undoes what ConsoleConnect and ConsoleNewProcess did.
- Rework a little bit CsrInitConsole.
Now the console app. initialization algorithm is the following:
1- A process is created, its type (GUI or CUI) is determined (kernel32 and basesrv).
2- ConsoleNewProcess is called (consrv) and makes this new process inherit the console handles table from its parent
(NOTE: this is done for all CUI processes, because at this point, we still don't know whether we must inherit
the handles from the parent or not).
3- (back in kernel32) In BasepInitConsole, we determine whether or not we must create a new console window or use
the parent's one or not using one at all. We (as a client) connect to the console server (consrv) (via CsrClientConnectToServer)
which in turn (via CSRSS mechanism) calls ConsoleConnect. For GUI processes we do nothing. For CUI processes, we initialize
a new console based on properties set in BasepInitConsole.
4- When a process dies, ConsoleDisconnect is called and whether it is a GUI or CUI process, we revert the actions done previously.
Part 2/2
TODO: - Debug the CSR waits.
- Work on the console properties property-sheet.
- See what can be done on http://jira.reactos.org/browse/CORE-122
svn path=/branches/ros-csrss/; revision=58098
- Fix console apps initialization.
- Introduce a helper function InitConsoleCtrlHandling for initializing console control handling.
- We now initialize the new created console when connecting the client (kernel32) to the server (consrv) by calling CsrClientConnectToServer with real parameters (not dummy ones).
- Add/activate some debug prints (will be removed when all things work).
Part 1/2
svn path=/branches/ros-csrss/; revision=58096
SamrGetAliasMembership:
- Change requrred access right from DOMIN_LOOKUP to DOMAIN_GET_ALIAS_MEMBERSHIP.
- Handle the case properly where a user is not a member of any alias.
- Retrieve an alias members RID correctly.
svn path=/trunk/; revision=58094
Fix untitled Run dialog in some languages. I wonder why it was as it since ages, in some languages but not in anothers.
svn path=/trunk/; revision=58092
- Revert lstrcpynW --> wcsncpy changes from r57471 back to lstrcpynW because this function automatically NULL-terminate strings
(but I wonder if there is a replacement of lstrcpynW which has all its functionalities, in the CRT). This fixes address loading
after editing it in the address bar. Caught by Edijus ;)
- Unicodize a little bit more regedit.
svn path=/trunk/; revision=58090
- In NtGdiGetRandomRgn use the region pointers directly, instead of getting their handles. These regions might not even have a handle.
- Fix last error code
svn path=/trunk/; revision=58089
- Use REG_OPTION_NON_VOLATILE instead of 0 in RegCreateKeyEx.
- Do not rename keys when they have the same name, case-insensitive (as Windows does), fix for r58079 / CORE-6205.
svn path=/trunk/; revision=58087
Exchange fields individually in PDEVOBJ_vSwitchPdev() instead of duplicating a full PDEV structure on the stack. This saves a lot of stack space.
svn path=/trunk/; revision=58081
- Check if the new name equals the old name. In that case don't rename key.
- Fixes regedit accidentaly deleting keys when a key is clicked and the rename field appears
CORE-6205 #resolve #comment finally regedit is usable
svn path=/trunk/; revision=58079
- Add some annotations
- Fix some 64bit issues
- Fix a typo
- reduce ENUM_RECT_LIMIT to 32, which is more than enough and doesn't waste as much stack space
- remove some unused macros
svn path=/trunk/; revision=58076
- Be sure that we reply to the dying client when he dies.
- "Improve" a debug output (display the client process).
- Use existing helper functions for incrementing reference counts for threads and processes.
svn path=/branches/ros-csrss/; revision=58075
Do NOT confuse a handle and a pointer to a handle !! In this case we need a handle.
Caught in the following situation :
1- Launch a process A which initializes a console A (say, cmd.exe).
2- Launch a process B which also initializes a console B (for instance, in the first cmd.exe, do: start cmd.exe)
3- Click on the "Close" button (the "Cross" button in the right upper side) of the windows of the console A.
4- Notice that the console B closes but the process B remains alive, whereas the console A remains open but the process A is killed...
(contrary to what you expected, closing the console A and the process A)
(when clicking on the "Close" button, the Console Server launches a remote thread in the context of the target process, and it appeared in the described situation
that it was the wrong process, because of bad parameter passing to the sub-function CsrLockProcessByClientId called when creating the remote thread).
svn path=/branches/ros-csrss/; revision=58073
- Enable the call to NetUserAdd.
This enables us to create new user accounts. A lot of stuff is still missing, so don't be surprised if something unexpected happens. It will be fixed soon.
Happy new Year!
svn path=/trunk/; revision=58072
Pass a PUNICODE_STRING instead of a LPWSTR (and unused BufferSize) to FindMatchingCreateItem(), make use of the Length parameter instead of trusting on NULL termination when searching for path separators.
svn path=/trunk/; revision=58065
I replaced by error the mask 0x10000003 by 0x3, which had as an effect to match handles of value 0xffffffff (invalid_handle_value). Fichtre !
svn path=/branches/ros-csrss/; revision=58064
- Code reorganization.
- In particular, move IsConsoleHandle macro to a place which it can be used by both kernel32 and consrv.
svn path=/branches/ros-csrss/; revision=58063
Hack the hack a bit more. Should fix annoying warnings about possible uninitialized variables. Also generates smaller code, by getting rid of a stray relative jump instruction.
svn path=/trunk/; revision=58057
* HANDLE_TYPE --> CONSOLE_HANDLE_TYPE because it hits "previous" definition of this enumeration (a totally different one from win32ss/include/ntuser.h)
* Temporarily add a dummy member to the CONSOLE_CONNECTION_INFO structure, to make MSVC happy.
svn path=/branches/ros-csrss/; revision=58055
Fix value of MmUserProbeAddress, which is MI_USER_PROBE_ADDRESS (0x7FFF0000) and not MI_HIGHEST_USER_ADDRESS (0x7FFEFFFF)!
svn path=/trunk/; revision=58049
In NtAllocateVirtualMemory, when MEM_RESET is passed, silence the DPRINT and also return STATUS_SUCCESS, since MEM_RESET is only an optimization (tells the memory manager that the contents shouldn't be written to the pagefile) and it won't hurt (except the performance) to pretend success. On the other hand paging out is probably never done anyway due to broken Mm.
This fixes spamming the log by Firefox. It does not fix the hangs that firfox suffers from.
svn path=/trunk/; revision=58047
Apply Wine commit "wpp: Fix path separator on Windows platforms." by Hermès Bélusca-Maïto (9dbd1969fca9c31155c6d85ea8129d249467926b)
Indeed, Windows systems use ':' as part of paths and therefore, use another separator character.
This enables compiling ReactOS from source files located in a different disk partition as the generated (output) files.
CORE-6442 #resolve #comment Committed in r58044.
svn path=/trunk/; revision=58044
- Apply Wine commit "widl: Print large enum constants in hex." by Alexandre Julliard (756d33ddae316c71b1241e7c8684c07cd82b9e05)
- Remove some minor differences to Wine
svn path=/trunk/; revision=58039
Store an objects relative id in the database object. This will later be used to protect pre-defined objects from being deleted.
svn path=/trunk/; revision=58038
SamrQueryInformationDomain (DomainGeneralInformation/DomainGeneralInformation2): Count the number of Aliases, Groups and Users.
svn path=/trunk/; revision=58036
- Start implementing a library which is used to parse USB configuration descriptors and construct KSFILTER_DESCRIPTOR structure, which is used with the kernel streaming driver (ks.sys)
- The library will be used in USBAUDIO driver
svn path=/trunk/; revision=58033
* Correct a typo that led to incorrect Capacity value (shown in the disk properties).
* Correct some colors inversion in the Free/Used disk space chart.
* Brought to you by Victor Martinez Calvo.
CORE-6838 #resolve #comment Committed in r58030. Gracias ;)
svn path=/trunk/; revision=58030
- Do not close Notepad when 'Save As' dialog is canceled (behaviour correction, makes it as under Windows). Patch by Peter Hater.
- Temporarily fix saving with invalid file name --> now return an error, don't save the file, reset the internal file name to "" (untitled) and keep Notepad opened.
This is due to the lack of file name validation when calling Save-As file box (should be done by default, but it is not under ROS).
CORE-6836 #resolve #comment Committed in r58024. Thanks :)
svn path=/trunk/; revision=58024
* memcpy should behave exactly like memmove for Windows compatibility.
CORE-6833 #resolve #comment Committed in r58021.
svn path=/trunk/; revision=58021
- Move PcBeep function declaration to a better header.
- Resuscitate OptionMenuCustomBootReactOS() from revision r52491, update it to match recent changes in freeldr as well as making it using new boot method, and reuse ConstructArcPath.
Why I'm doing this ? Because it can be useful to enter personalized boot options by hand at boot time rather than being obliged to edit freeldr.ini. This needs care, not brutal deletion.
svn path=/trunk/; revision=58020
* Fix allocating the required bytes in SetupGetFileCompressionInfoW. Brought to you by Peter Hater (7element {at} mail [dot] bg)
CORE-6815 #resolve #comment Committed in r58018. Cheers ;)
svn path=/trunk/; revision=58018
- Include a netapi32.h in most files and move the other includes into netapi32.h.
- Add functions to open account and builtin domains directly and use these functions.
svn path=/trunk/; revision=58017
Export __crtLCMapStringW and correct __crtLCMapStringA: their prototypes are :
int CDECL __crtLCMapStringW(LCID lcid, DWORD mapflags, const wchar_t *src,
int srclen, wchar_t *dst, int dstlen, unsigned int codepage, int xflag)
and
int CDECL __crtLCMapStringA(LCID lcid, DWORD mapflags, const char* src,
int srclen, char* dst, int dstlen, unsigned int codepage, int xflag)
Needed by SVN.
svn path=/trunk/; revision=58016
- Add Advanced tab in task bar properties to support ReactOS-specific options (currently: show seconds in tray clock). Patch by Edijs Kolesnikovics.
CORE-5410 #comment Patch committed, thanks! Awaiting the updated save-to-registry functionality.
svn path=/trunk/; revision=58011
Improve the way we are doing the timing: When the timeout is > 0, we refresh its display. When it becomes == 0, we exit the waiting-loop and do the right action (start the default OS, ...). However, when we press a key, it is set to -1 by convention, that means, no timeout. The timeout display is then cleared ONLY ONCE since there is no need to refresh it each time we do a waiting-loop-turn when the timeout is == -1.
svn path=/trunk/; revision=58010
- Show the selected boot options as NTLDR does (in light blue under the "For troubleshooting... press F8" message).- The different safe modes are now mutually exclusive, as they must be.
- They can be coupled to the "boot logging", "vga mode" and "debugging" modes, enlarging possibilities (contrary to NTLDR. However you'll remark that these combinations are allowed when set with msconfig...).
- Since the safe modes come by default with boot logging, don't show "Boot Logging" when one of the safe modes is selected, but instead show the corresponding safe mode name.
- Modify the needed functions.
svn path=/trunk/; revision=58008
- Lee Schroeder: Replaces the current fontview icon with the icon found in the tango icon set (apps/preferences-desktop-font.png). This creates better consistency since that is where the majority of the icons come from.
CORE-6827 #resolve
svn path=/trunk/; revision=58007
Allow VideoMode to be set via decimal, hexadecimal, ... number representation in bootcd/livecd/freeldr.ini (see the Brian Palmer's FREELDR.INI example).
svn path=/trunk/; revision=58005
- Menu titles --> Menu headers (see r57842).
- In the same way we introduced menu headers, introduce menu footers, therefore we add the possibility, in mini-tui,
of showing or hiding the "For troubleshooting and advanced startup options for ReactOS, press F8." message, only
useful for the main menu (the one which shows the list of available OSes installed on the system).
svn path=/trunk/; revision=58001
Add some spacing (not too much) between the screen borders and the "Safe Mode" and the ReactOS version string labels, in Safe Mode.
svn path=/trunk/; revision=58000
Add a suitable 'Fixedsys' TTF Unicode font, called 'Fixedsys Excelsior v3.01'.
Released into the Public Domain.
By Darien Gavin Valentine,
http://www.fixedsysexcelsior.com/
svn path=/trunk/; revision=57998
- Implement NetUserGetInfo.
- Implement level 10 in BuildUserInfoBuffer.
- Zero-initialize the user info buffer after allocation.
svn path=/trunk/; revision=57997
- Remove "Properties" from the task bar property sheet title, as it is automatically appended. Patch by Edijs Kolesnikovics
CORE-6826 #resolve
svn path=/trunk/; revision=57993
* Add basic support for the new MSVC build handling that comes with the upcoming RosBE 2.1.
* This needs to be inspected further to make sure it matches our current setup.
svn path=/trunk/; revision=57990
1) Use of CheckDlgButton() and IsDlgButtonChecked() rather than SendMessage, it will improve code readability.
2)Removes an useless initialization into perfpage.c
3) GetWindowLong/SetWindowLong were replaced with GetWindowLongPtr/SetWindowLongPtr, but GWL_WNDPROC and GWL_ID were not with GWLP_WNDPROC and GWLP_ID.
4) Corrected some comment texts.
Patch by Carlo Bramini
CORE-6367 #resolve
svn path=/trunk/; revision=57989
- Use in some places ZeroMemory instead of memset(..., 0, ...).
- Fix way of initializing the STARTUPINFO structure before call to CreateProcess: in particular, when using the wShowWindow field, also use the STARTF_USESHOWWINDOW flag.
[USERINIT]
- Fix way of initializing the STARTUPINFO structure before call to CreateProcess: in particular, when using the wShowWindow field, also use the STARTF_USESHOWWINDOW flag.
- This fixes CORE-5735.
CORE-5735 #resolve #comment Command-line launching fixed in revision r57986.
svn path=/trunk/; revision=57986
- Add support for task bar theming
- Add notification area support
- Add support for window flashing
- Hide minimized windows
- Based on Andrew Green's GSoC branch (3/3)
svn path=/trunk/; revision=57978
- Run file dialog in its own thread
- Correctly check MapWindowPoints return value
- Fix a warning
- Based on Andrew Green's GSoC branch
svn path=/trunk/; revision=57977
- Fix a bug during socket closure that could cause buffered data to be lost
[LWIP]
- Only signal errors when the packet queue is empty to avoid dropping received data
- Use pbuf_copy_partial to copy pbuf chains instead of doing it manually which had a bug
CORE-6655 #resolve CORE-6741 #resolve
svn path=/trunk/; revision=57975
Fix a bug in the GDI pool code that could lead to list corruption and a failed ASSERT, when an app allocated a large number of DCs or brushes, like AbiWord with more than 1 document open. Also add a few more ASSERTs.
svn path=/trunk/; revision=57973
- Fork netapi32.dll because most of its exported functions are interfaces to services that wine will not implement.
- Move user and group functions to separate files and add some stubs.
- Update README.WINE.
svn path=/trunk/; revision=57972
- Rewrite NtUserGetAtomName, make it return the length in WCHARs instead of bytes, as it is supposed to be. Fix a buffer overrun, when the caller passes a too large UNICODE_STRING buffer. Probe the output buffers before accessing them. Makes sure the target string is always NULL terminated, even if the buffer is too small for the whole name.
- Remove NULL termination code from IntGetAtomName, since that is already done by RtlQueryAtomInAtomTable
svn path=/trunk/; revision=57970
- Upgrade the files architecture to the classic one : lang-directory for language resource files, rsrc.rc and <app_name>.rc for main resource files.
- Convert remaining language resource files to UTF-8 without BOM.
- Add version information to the program - Patch by Lee Schroeder.
CORE-6821 #resolve #comment Committed in r57963. Thanks :)
svn path=/trunk/; revision=57963
- Update RedHat Liberation Fonts to 2.00.1
- Update and add some DejaVu Fonts to 2.33
- Update GNU FreeFonts to revision 20120503
- Update Tahoma and Symbol Fonts to Wine HEAD
- Sort the fonts documentation files to dedicated directories
svn path=/trunk/; revision=57959
- Use 2 seperate SEH blocks in PsSuspendThread(). This way we don't leak the rundown protection, and don't keep a terminating thread suspended, when KeSuspendThread() throws an exception. Also only catch STATUS_SUSPEND_COUNT_EXCEEDED exceptions in the SEH filter.
svn path=/trunk/; revision=57958
- Add some missing return value checks
- Add some annotations
- Fix format specifiers
- Fix variable scope conflicts
- Fix possible closing of a NULL handle
- Use ObCloseHandle instead of ZwClose
svn path=/trunk/; revision=57954
- Add/improve some annotations
- Improve code in EngpGetPDEV and NtGdiGetRegionData
- Simplify SEH exception handling
- Fix possible NULL pointer dereferences
- Fix wrong variable usage in UnpackParam
- Fix a possible bufer overrun
- Check return value of ExAllocatePool and RtlCreateUnicodeString
- Fix & vs && typo
All detected with VS11 analyse
svn path=/trunk/; revision=57948
- services.exe is indeed a GUI program, so build it as such.
- Check the return value of RegisterServicesProcess and thus allow only one instance of services.exe to be launched.
CORE-6123 #resolve #comment Fixed by r57946.
svn path=/trunk/; revision=57946
- Fix a calculation bug in the heap code
- Fix pointer arithmetics
- Fix artihetic overflows
- rename some global items to not conflict with local names
- Silence some more warnings from VS analyze
svn path=/trunk/; revision=57936
- Effectively reboot instead of exiting the bootloader and hanging.
- Do a cold reboot instead of a (soft) warm reboot, to let the user be able to choose another boot support or do anything else, instead of directly rebooting to the bootloader. Rename the concerned function accordingly.
svn path=/trunk/; revision=57935
Completely remove the special blue "setup-ui" appearing when starting the bootcd, in this way revert a part of r57842 and r57843.
Requested by some people. Now we keep the NTLDR-like boot ui.
svn path=/trunk/; revision=57933
Start rewrite sal.h
This will drop support for WDK's prefast, since it's impossible to maintain both sal version 1 and 2 and the old stuff is quite unreliable anyway. Only MSVC 11+ analyze with attributes for SAL will work.
abragin: "\o/ for throwing away some legacy" ;-)
svn path=/trunk/; revision=57932
Fix BSOD when starting ReactOS in Safe Mode :
NEVER dereference a NULL pointer in a DPRINT or you are dead !! (here, the possible NULL pointer is GetW32ProcessInfo()->prpwinsta).
More precisely, you obtain:
<NTOSKRNL.EXE:112296 (ReactOS/ntoskrnl/ke/i386/traphdlr.c:1246 (@KiTrap0EHandler@4))>
<NTOSKRNL.EXE:110154 (ReactOS/ntoskrnl/ke/i386/trap.s:0 (_KiTrap0E))>
<NTOSKRNL.EXE:142926 (ReactOS/lib/sdk/crt/printf/streamout.c:644 (streamout))>
<NTOSKRNL.EXE:140631 (ReactOS/lib/sdk/crt/printf/_sxprintf.c:61 (_vsnprintf))>
<NTOSKRNL.EXE:12736a (ReactOS/lib/rtl/debug.c:85 (vDbgPrintExWithPrefixInternal@24))>
<NTOSKRNL.EXE:12751c (ReactOS/lib/rtl/debug.c:209 (DbgPrint))>
<win32k.sys:55034 (ReactOS/win32ss/user/ntuser/sysparams.c:451 (SpiGet))>
<win32k.sys:56bc7 (ReactOS/win32ss/user/ntuser/sysparams.c:963 (@UserSystemParametersInfo@16)
svn path=/trunk/; revision=57923
Improve functionnality of the shutdown utility :
* Added extra arguments based upon Windows 7.
* Added options to CommandLineOptions function.
* Simplify the PrintResourceString() function.
* Removed PrintUsage() since PrintResourceString() does a more flexible job at printing strings out.
* Added clear error messages when there is a problem. This makes it a bit easier to determine if there is a problem.
* Convert all the C++ comments to C.
* Since each version of Windows has a different upper limit for the length of the comment, a work around solution is used that first checks the length of the comment based upon the version of Windows that the user is currently using.
* Added support for hibernation mode, but the function SetSuspendState() is only a stub right now.
* In cases where the shutdown/restart operation is done remotely, now the proper permission is granted if the user has the proper permission.
* Added the REASON structure, which contains all the reason code combinations required for giving the proper reason code to the computer.
* Added bare bones basic support for the GUI option (/i). However, until the required features are added to ReactOS, the GUI won't do anything.
* Convert the program to full UNICODE support.
CORE-6613 #resolve #comment Committed in r57916. Thanks :)
svn path=/trunk/; revision=57916
- Use a list of possible operating system method loading to load ReactOS / ROS-Setup / Windows / Linux or booting from a disk / partition ..., instead of using a (huge) if () else if () ... instruction.
- Modify the corresponding functions to take into account for this new functionality.
- Allow having a live + boot cd if needed, in a elegant way.
svn path=/trunk/; revision=57899
SetupDiLoadClassIcon: Return the handle to or index of the default icon (Other devices icon) if no valid ClassGuid was provided by the caller.
With this patch, the class icon of 'Other devices' appears in the device property sheets in the device manager.
svn path=/trunk/; revision=57884
* Reduce palette window size.
* Fix some Japanese text.
* Brought to you by Hirofumi Katayama.
CORE-6802 #resolve #comment Committed in r57870. Thanks ;)
svn path=/trunk/; revision=57870
However here, we must keep the incrementation at the end of the loop, because of a possible corner case (a loop-break which takes place when we reach the last element of the list, but NextEntry already points to its head because of the cyclicity of the list) with the following 'if'-test made just after the loop.
svn path=/branches/ros-csrss/; revision=57867
Put the "Move to the next entry" code just after retrieving list record, because it is less bug-prone.
Indeed correct a bug in CsrDestroyProcess where we were doing an infinite loop when trying to notify existing CSR waits, because NextEntry was set to the CsrProcess->ThreadList.Flink element (head) of the list.
svn path=/branches/ros-csrss/; revision=57866
* Update some shell related headers.
[UUID]
* Add some GUIDs to shguids.c.
[MAIN.CPL]
* Remove initguid.h inclusion and link to uuid.
svn path=/trunk/; revision=57857
Reintroduce the long-awaited boot-logo fading-in, removed since ReactOS 0.3.3 due to bootvid / inbv refactoring. Code taken from the old (ie. pre-ReactOS 0.3.3) bootvid.
svn path=/trunk/; revision=57855
Improve the overall look:
- Augment the timeout of the livecd from 3 seconds to 5 seconds.
- In "Mini"-UI (i.e. NTLDR-like UI), add a newline between "Press ENTER" and the time counting.
- Have a real "Setup"-UI (i.e. make it really work).
- Add the possibility to change the title of menus.
svn path=/trunk/; revision=57842
- make some functions locale aware
- add implementation of ___mb_cur_max_func and _isctype_l
[MSVCRT20]
- keep up with msvcrt
[MSVCRT40]
- ditto
svn path=/trunk/; revision=57838
- LsarQueryAuditEvents: Do not fail if the PolAdtEv attribute does not exist and return proper inormation to the caller.
- Implement LsarSetAuditEvents.
svn path=/trunk/; revision=57837
- Add a trusted flag to the lsa object type.
- Inherit the trusted flag from the policy object when an account or secret object is created or opened.
- Set the trusted flag for a policy object in LsaIOpenPolicyTrusted.
svn path=/trunk/; revision=57821
- Delete all the remnants of Win32CsrValidateBuffer calls, which were replaced by standard CsrValidateMessageBuffer calls, and therefore delete the unused server.c file.
- Adapt WriteConsole API to use CSR waits. This replaces the old event-based waiting.
TODO: Dereference all the waits in Console->WriteWaitQueue.
svn path=/branches/ros-csrss/; revision=57819
- Simplify IntGetConsoleInput and IntReadConsole.
[CONSRV]
- Implement event waiting for reading console input buffer with CSR wait blocks. This replaces the event-based waiting which, after being moved from client-side (kernel32) to server-side (see r57721), made all consoles hang when one of them was waiting for new input.
TODO: Dereference all the waits in Console->ReadWaitQueue.
svn path=/branches/ros-csrss/; revision=57817
- Only dissolve a stack of cards if they're of the same color
- Allow easier recognition of suit in concealed cards
- Patch by Marcel Leyendeckers, m dot leyendeckers at gmx dot de
CORE-6808 #resolve #comment Committed. Thanks!
svn path=/trunk/; revision=57815
- Set USBD status when a device is successfully configured and transferred length for vendor class requests
- Add error msg when copying of interface descriptor fails
svn path=/trunk/; revision=57813
- Add a useful CHECK_API_MSG_SIZE macro to check whether a server message structure can hold in a CSR_API_MESSAGE structure. These checks are required because LPC will use the generic CSR_API_MESSAGE structure for communicating all the different servers' messages, and thus we avoid possible buffer overflows with this method.
- Effectively use this macro for all the server message structures.
- Remove a hack regarding the maximum data size we can pass through the CSR LPC port.
- Remove the now unused CSRSS_HEADER_SIZE symbol.
svn path=/branches/ros-csrss/; revision=57810
Re-fix part of the capture-buffer offset setting, based on what I understood from all my previous investigations. It reverts a little part of r57673 but fixing some existing bugs there.
svn path=/branches/ros-csrss/; revision=57809
- Comment on the size of some members of the CSR_WAIT_BLOCK structure.
- Initialize the WaitBlock member of CSR_THREAD to a valid value when creating a wait block, and NULLify it when we release a wait block.
- ALWAYS USE offsets in CSR_CAPTURE_BUFFER structure, instead of real pointers !! It is needed when their base address change (eg. during a CSR wait, their base address, corresponding to the address of an CSR API message, change) (found when testing CSR waits with the console).
svn path=/branches/ros-csrss/; revision=57806
- Add check if interface descriptor was parsed
- Correct error message
- Set device idle after a configuration has been selected
- CORE-6574
svn path=/trunk/; revision=57805
- Set ParameterValue when NdisReadConfiguration is successful
- Fixes crash when Belkin F5D8053 N Wireless USB Adapter is initializing
- Introduced in rev 5338 (31/07/2003)
svn path=/trunk/; revision=57803
- Correct a misspelling 'CsrThreadAltertable' -> 'CsrThreadAlertable'.
- Introduce CSR_REPLY_CODEs instead of using hardcoded values, and use them with CSR_API_ROUTINE-type functions. They correspond to which decision CSRSRV should take after a server function is called: answer to the client or not, and perform according tasks.
[BASESRV]
Use CSR_REPLY_CODEs.
svn path=/branches/ros-csrss/; revision=57801
- Handle devices which provide indicate a serial number but not provide one
- Fixes device installation initialization for F5D8053 N Wireless USB Adapter
svn path=/trunk/; revision=57799
- Remove the right element from the list when uninitializing a file lock
- Do not modify the content of the table range while looping on its elements
- Fix rebuilding the table when unlocking a shared range
Thanks go to Pierre for the hint for where to look at
CORE-6615 #comment fixed by r57798 #resolve
CIRE-6535 #comment fixed by r55798 #resolve
svn path=/trunk/; revision=57798
- Skip other spaces preceding a command option instead of increasing the reading pointer of a constant (should fix KDSERIAL).
- Use a macro for representing length in chars of constant strings instead of putting magic values.
svn path=/trunk/; revision=57787
- Fix object deletion.
- Add a registry wrapper function that enables us to delete registry keys which have already been opened.
- Make LsarDelete call LsarDeleteObject because otherwise object deletion would not be possible.
svn path=/trunk/; revision=57784
Fixes COM port debugging output with Virtual PC 2007. See r57781 for more details.
CORE-4247 #comment Fixed also in r57782.
svn path=/trunk/; revision=57782
- Use cportlib for COM port facilities. Fixes COM port debugging output with Virtual PC 2007.
- Remove now unneeded header file.
CORE-4247 #comment Fixed in r57776, r57777, r57780 and r57781. #resolve
svn path=/trunk/; revision=57781
GetByte --> Wait for data (with timeout) and get it if available.
PollByte --> Check for data, get it if available, and return immediately.
svn path=/trunk/; revision=57780
- Make use of the previously committed cportlib code. This works great on VPC 2007 :)
- Comment the unused Rs232PortPollByte function.
- In hardware.c, add useful comments and two macros holding the maximum number of COM and LPT ports.
svn path=/trunk/; revision=57777
- Do a synthesis of all the code I've found concerning initializing COM ports (in kdcom / kddll / kdbg in the kernel and in freeldr). The "// Windows" comments concern the original code for testing the existence of COM ports, inside cportlib, whereas "// ReactOS" comments concern the equivalent existing in our kdcom/kddll/kdbg etc...
- CORRECT THE VIRTUAL PC COM PORT INITIALIZATION !! The problem was, that the current COM port existence test fails on VPC whereas it works well in all other virtual machines. Therefore :
* I keep the existing testing code in a function called ComPortTest1, this works everywhere but on VPC ;
* I add a very basic COM port existence test function called ComPortTest2, which basically looks for the scratch register, this works everywhere including on VPC.
* The COM port existence test consists in the two tests above.
svn path=/trunk/; revision=57776
- Implement LsarDeleteObject.
- Store the object name in the database object in order to be able to delete the objects key later.
svn path=/trunk/; revision=57769
- Add enumeration of user rights to LsarEnumerateAccountRights.
- Use RPC_UNICODE_STRING instead of UNICODE_STRING in the privilege lookup code.
svn path=/trunk/; revision=57767
- (Re-)implement acquiring/releasing driver-loading and unloading privilege (Note: the two privileges have the same name SE_LOAD_DRIVER_NAME).
- Rework the SCM initialization code. In particular, acquiring the starting lock MUST BE done BEFORE starting the RPC server, otherwise, a program can try to start a service (and during this operation, the global start lock is acquired by the SCM) DURING the initialization of SCM, and in particular between the call to ScmStartRpcServer and ScmAcquireServiceStartLock. The SCM would then see an already-acquired start lock at this point and would fail to initialize. ==> This commit corrects this behaviour.
svn path=/trunk/; revision=57754
When filling LoadOptions, strip the '/' commutator symbol in front of each option. Now we fully comply with Windows when holding LoaderBlock->LoadOptions, and the content of the registry value SystemStartOptions under HKLM\CurrentControlSet\Control display the options without their / symbol.
[WIN32K]
Now, the SystemStartOptions value doesn't contain / anymore.
svn path=/trunk/; revision=57752
Deactivate the code of GetConsoleInputWaitHandle, because it calls a function that doesn't seem to appear in the console server apis listed in http://j00ru.vexillium.org/csrss_list/api_list.html (and that I haven't included in the console server apis list), until I find a better solution. It fixes compilation.
[CONSRV]
- Code reorganization
- Introduce the CONSOLE_CONNECTION_INFO structure needed for initializing consoles when launching a program (see http://svn.reactos.org/svn/reactos/trunk/reactos/lib/kernel32/misc/dllmain.c?r1=16826&r2=16825&pathrev=16826), instead of calling AllocConsole. Not used at this time.
Now the branch compiles.
svn path=/branches/ros-csrss/; revision=57749
I think this history deserves champagne and forceful warning comments, which have been added.
Simple solution: Don't blindly sync Wine code!
#resolve #CORE-6495
svn path=/trunk/; revision=57747
Remove the unneeded CsrpHandleConnectionRequest function since CsrApiHandleConnectionRequest does already the job.
svn path=/branches/ros-csrss/; revision=57744
When calling CsrClientConnectToServer with a valid connection info user buffer, after capturing the buffer and calling CsrClientCallServer, do not forget to copy back to the user buffer the updated connection info and to free the capture buffer !
svn path=/branches/ros-csrss/; revision=57743
- Remove unused functions CallHardError and CsrHandleHardError (in fact calling the hard error callback is already done in the listening thread).
- Add an annotation and correct a typographical error; remove old comments.
- Remove the now unneeded csrplugin.h header (a relic of the old callback system of the old csrss/csrsrv).
svn path=/branches/ros-csrss/; revision=57741
- Merge IntWriteConsoleOutputCharacter and WriteConsoleOutputAttribute functions into IntWriteConsoleOutputCode helper functions, which is used inside WriteConsoleOutputAttribute and WriteConsoleOutputCharacterW/A.
- In server-side, merge CsrWriteConsoleOutputChar and CsrWriteConsoleOutputAttrib into the server API SrvWriteConsoleOutputString.
- The structures CSRSS_WRITE_CONSOLE_OUTPUT_CHAR and CSRSS_WRITE_CONSOLE_OUTPUT_ATTRIB are merged into CSRSS_WRITE_CONSOLE_OUTPUT_CODE.
[CONSRV]
- Add a CsrValidateMessageBuffer usage.
svn path=/branches/ros-csrss/; revision=57740
- Modify the helper function IntWriteConsole to make it use of capture buffers for passing things to write.
- Now, the loop disappears.
- I moved the pause-event wait (introduced in revision r47359) inside consrv, and (concerning the server-api-part SrvWriteConsole), especially in the ConioWriteConsole function, to be sure that all functions calling ConioWriteConsole become sensible to pause event. This REALLY NEEDS testing (and of course the code needs cleaning of the introduced comments, when I'm sure it works).
svn path=/branches/ros-csrss/; revision=57738
- Merge IntFillConsoleOutputCharacter and FillConsoleOutputAttribute functions into IntFillConsoleOutputCode helper and make it used by FillConsoleOutputAttribute/CharacterW/A.
- In server-side, CsrFillOutputChar and CsrFillOutputAttrib are merged into SrvFillConsoleOutput.
- Merge CSRSS_FILL_OUTPUT and CSRSS_FILL_OUTPUT_ATTRIB structures into CSRSS_FILL_OUTPUT.
svn path=/branches/ros-csrss/; revision=57734
- Use the ConsoleGetPerProcessData macro (--> CONSOLE_PROCESS_DATA structure).
- Do not forget to leave a critical section if we fail.
svn path=/branches/ros-csrss/; revision=57731
Use new structures and api indices namings.
[CONSRV]
Use CsrValidateMessageBuffer instead of Win32CsrValidateBuffer.
svn path=/branches/ros-csrss/; revision=57729
- Use new structures and api indices namings (as usual).
[CONSRV]
- Merge CSRSS_SET_TITLE and CSRSS_GET_TITLE into CSRSS_CONSOLE_TITLE.
- Merge CSRSS_GET_CONSOLE_(OUTPUT_)CP and CSRSS_SET_CONSOLE_(OUTPUT_)CP into CSRSS_CONSOLE_CP.
- NtDuplicateObject(GetCurrentProcess(), ... ---> NtDuplicateObject(NtCurrentProcess(), ...
- Use CsrValidateMessageBuffer instead of Win32CsrValidateBuffer.
- Use CONSOLE_PROCESS_DATA structure.
TODO: Remove a DPRINT1 checkpoint in SrvAllocConsole after future tests are OK.
svn path=/branches/ros-csrss/; revision=57727
- Use new structures and api indices namings.
[CONSRV]
- CSRSS_SET_CURSOR ==> CSRSS_SET_CURSOR_POSITION for SrvSetConsoleCursorPosition.
- Merge CSRSS_GET_CURSOR_INFO and CSRSS_SET_CURSOR_INFO into CSRSS_CURSOR_INFO.
svn path=/branches/ros-csrss/; revision=57725
- Make some functions compliant with the new structures and server apis indices names.
[KERNEL32/CONSRV]
- Merge CSRSS_SET_CONSOLE_MODE and CSRSS_GET_CONSOLE_MODE into CSRSS_CONSOLE_MODE.
- Rename CSRSS_SETGET_CONSOLE_HW_STATE into CSRSS_CONSOLE_HW_STATE.
svn path=/branches/ros-csrss/; revision=57724
- Make OpenConsole call only one server api, namely SrvOpenConsole, which was known before under the name CsrGetHandle (this latter function was removed in r57689 by error).
- Merge CSRSS_GET_INPUT_HANDLE and CSRSS_GET_OUTPUT_HANDLE structures into CSRSS_OPEN_CONSOLE (used by the functions named above).
[CONSRV]
- Add SrvOpenConsole (copied from CsrGetHandle), and add DPRINT1s to it.
- Load the localized string "Command Prompt" using the Server DLL's instance handle instead of calling GetModuleHandleW.
- Make use of CONSOLE_PROCESS_DATA structures.
svn path=/branches/ros-csrss/; revision=57723
Reorganize the data members according to their purposes (increases the lisibility only). No code changes.
svn path=/branches/ros-csrss/; revision=57722
- Move the waiting loop of IntReadConsole into SrvReadConsole instead.
- Merge IntPeekConsoleInput and IntReadConsoleInput helpers into a single IntGetConsoleInput helper function
and make PeekConsoleInputW/A and ReadConsoleInputW/A use it.
Indeed, the "only" difference between these two functions, is that the first one keeps the data read inside
the console input buffer, but on the contrary the second removes the data and does not return until at least
one input record has been read.
In server-side, CsrReadInputEvent and CsrPeekConsoleInput are merged into SrvGetConsoleInput. Merge the corresponding
structures.
- Use shorter variable names in IntReadConsoleOutput and use CONSOLE_PROCESS_DATA structure in SrvReadConsoleOutput.
- Merge IntReadConsoleOutputCharacter and ReadConsoleOutputAttribute functions into a single IntReadConsoleOutputCode
helper function, and make ReadConsoleOutputAttribute and ReadConsoleOutputCharacterW/A use it.
In server-side, CsrReadConsoleOutputChar and CsrReadConsoleOutputAttrib are merged into SrvReadConsoleOutputString.
(Remark: the SrvReadConsoleOutputString name comes from http://j00ru.vexillium.org/csrss_list/api_list.html and I
checked that it was indeed the server function that was called by both ReadConsoleOutputAttribute and ReadConsoleOutputCharacter).
The idea behind merging these two functions is, that an attribute or a character are instances of the same entity, namely
a "code" (what would be called an (ANSI) escape sequence). Therefore I encode them inside the same CSRSS_READ_CONSOLE_OUTPUT_CODE
structure and I use it with the previous functions.
[CONSRV]
- Make use of the CONSOLE_PROCESS_DATA structure (introduced in r57685).
- Use CsrValidateMessageBuffer instead of Win32CsrValidateBuffer.
- Reorganize conmsg.h a little bit.
svn path=/branches/ros-csrss/; revision=57721
- Use a standard win32 thread function for the ConsoleControlDispatcher thread, instead of a custom PCONTROLDISPATCHER one.
- Deactivate debug outputs in console.c, which were activated by error in r57706.
svn path=/branches/ros-csrss/; revision=57714
- Move console-related Vista+ functions from client/vista.c to a dedicated client/console/vista.c file, and add it to compilation.
- Move some helper functions from console.c to history.c.
- Use the new api index names in history.c.
[CONSRV]
- Merge CSRSS_GET_HISTORY_INFO and PCSRSS_SET_HISTORY_INFO structures declarations into CSRSS_HISTORY_INFO, and therefore use only one member of it inside CONSOLE_API_MESSAGE structure.
- WORD --> UINT for few structure members related to history information.
svn path=/branches/ros-csrss/; revision=57713
- Use capture buffers to pass (variable-length) strings to the console server.
- Merge the CSRSS_ADD_CONSOLE_ALIAS and CSRSS_GET_CONSOLE_ALIAS structures into a unique structure CSRSS_CONSOLE_ALIAS.
TODO: Check what happens to the "/ sizeof(WCHAR);" in GetConsoleAliasesW.
svn path=/branches/ros-csrss/; revision=57712
- Move all the read/write related functions to an appropriate source file and add it to compilation.
- Fix credits for alias.c
svn path=/branches/ros-csrss/; revision=57711
- Move history-functions to a dedicated source file. The functions were created in r47580 and therefore update the description header of the file.
svn path=/branches/ros-csrss/; revision=57709
- Move alias-functions to a dedicated file. The names of the programmers were retrieved via svn information (see r32093 and r32118).
svn path=/branches/ros-csrss/; revision=57707
- Place console.c file in a dedicated directory because I will after split it into logical units (eg. a file for Alias-functions, a file for Read-write functions, etc...) to facilitate maintenance.
svn path=/branches/ros-csrss/; revision=57705
- Comments formatting.
- Correct a nasty initialization bug which unveiled itself as, eg., critical sections being already initialized in consoles, whereas we were creating new ones. It was because we didn't copy correctly per-process server data from parent process to child process. Now consoles initialize finely.
Now, only modifications to the console subsystem remain to make it totally conform to the new messaging structures of csrss (I mean, using the capture buffers).
svn path=/branches/ros-csrss/; revision=57703
- Use a variable ServerDll instead of using each time CsrLoadedServerDll[i], as it is done in some other places.
- Clean the code (remove extra-parentheses).
- Zero-out the memory buffer allocated for CsrSrvSharedStaticServerData.
svn path=/branches/ros-csrss/; revision=57701
NetLocalGroupEnum: Add code to return information about a single alias to the caller.
Now, the user account control panel enumerates the built-in groups. ;-)
svn path=/trunk/; revision=57700
Resize the dialogs to fit the ReactOS image, and add the logo to the "Please wait..." dialog
(which is displayed when a user is logging-on or quitting his session and the "Save your parameters..."
message is displayed). Now ReactOS looks perfect.
svn path=/trunk/; revision=57697
- Implement usage of alpha cursors (does not work yet due to a bug in windres)
- Directly use bitmaps passed to NtUserSetCursorIconData instead of copying them
svn path=/trunk/; revision=57695
- Remove the unneeded CallProcessCreated function since the same functionality is programmed and executed in CSRSRV when CsrInsertProcess is called via a call of CsrCreateProcess.
- Remove some hacks in process creation.
- In BaseSrvExitProcess, use the 'Reply = 2' value instead of the old hack 'ApiMessage->ApiNumber = 0xBABE'.
[USER32/WINSRV]
- Make SetLogonNotifyWindow call our 'RosSetLogonNotifyWindow' hack and explicitely mark it as a hack.
- CsrSetLogonNotifyWindow --> RosSetLogonNotifyWindow to emphasize that it is a ReactOS-specific hack.
svn path=/branches/ros-csrss/; revision=57694
- Add test showing that a bitmap created using CreateDIBItmap can be selected into a DC despite a different bits depth
svn path=/trunk/; revision=57693
- Start using CURSORDATA structure for passing data from user to kernel mode.
- Start using the proper CURSOR structure for win32k internal represesentation of cursor and icons
- Create the alpha bitmap in user mode instead of kernel mode.
svn path=/trunk/; revision=57692
- Work only with BITMAPINFO in GreGetDIBItsInternal and convert the structure back to BITMAPCOREINFO if needed.
- Set the rgbReserved member to 0 when getting palette of a DIB section
svn path=/trunk/; revision=57691
- Use the DLL instance for getting its win23 resources.
- Use the CONSOLE_PROCESS_DATA structure (see r57686) for accessing console-specific fields of the processes (instead of using them implemented in the CSR_PROCESS structure).
- Win32CsrDuplicateHandleTable --> ConsoleNewProcess since it's the callback function called when a new process is created, and start to move some hacks currently present in BaseSrvCreateProcess.
TODO: suppress the starting-application-related hacks in BaseSrvCreateProcess (in basesrv).
svn path=/branches/ros-csrss/; revision=57689
- Use the new PCONSOLE_PROCESS_DATA type instead of PCSR_PROCESS, for accessing console-specific fields inside a console structure (the code modifications inside these functions will follow in the next commits).
- Remove unneeded included header files in consrv.h.
- Use a DLL instance in order to facilitate the access to win32 resources.
- Activate the declaration of server apis (or rename existing ones to the Windows scheme from the http://j00ru.vexillium.org/csrss_list/api_list.html#Windows_2k3 list).
- Comment the Win32CsrValidateBuffer helper (because it should be replaced by the usage of CsrValidateMessageBuffer).
- Add the list of the old APIs (just for me, to remember at the end to check that I didn't forget ome of them during the process of moving / renaming).
svn path=/branches/ros-csrss/; revision=57686
Add a new header containing per-process console-specific structure CSRSS_CON_PROCESS_DATA (it is stored inside one of the element of the ServerData array inside the CSR_PROCESS structure). It was deleted from csrsrv.h in revision r57673 and reappears here. Also add a macro in order to facilitate its access inside consrv.
svn path=/branches/ros-csrss/; revision=57685
NetLocalGroupEnum: Make sure that built-in aliases are retrieved once and only one alias is enumerated upon each consecutive call. Retrieve name and comment for each alias.
svn path=/trunk/; revision=57684
SamrQueryInformationAlias: When retrieving general information, return a member count of zero if the members sub key does not exist.
svn path=/trunk/; revision=57682
- Add parameter annotations.
- Improve CSR buffer allocation with 4-byte align.
- Simplify the capture-buffer pointers settings.
[CSRSRV]
- Remove last console structure from csrsrv.h (in next commits it will be placed in a proper header).
- Enable global CSR debugging (for debugging purposes... ;-) ).
- api.c: Enable debugging.
- api.c/.h: Remove old code and deprecated unused definitions.
- Use the Win2k3-compliant version of CsrCreateThread (code from subsystems/csr/csrsrv) (TODO: correct its usage in basesrv:BaseSrvCreateThread).
- init.c: Implement a helper routine, CsrInitCsrRootProcess, in order to initialize the per-process server data (see CSR_PROCESS structure) in the Root CSR process. New process inherit it from this Root process.
- server.c - Add a DPRINT. Remove a hack. Correct a parameter passing.
- session.c - Remove a hack (it will go to the new process initialization in consrv)
- Disable the code of CsrConnectToUser while user32:ClientThreadSetup doesn't work.
- Correct the implementation of CsrValidateMessageBuffer.
- Basic implementation of CsrValidateMessageString using CsrValidateMessageBuffer.
TODO:
- Compare CsrpHandleConnectionRequest with the other one function in api.c.
- Compare CsrValidateMessageBuffer with Win32CsrValidateBuffer ?
svn path=/branches/ros-csrss/; revision=57673
- Implement LookupIconIdFromDirectoryEx.
- Implement CopyImage
- Finish Implementing LoadImage
- Implement various functions.
[WIN32SS]
- Add a first working implementation for LR_SHARED cursors and icons.User32 support is there, but more work is needed in win32k.
svn path=/trunk/; revision=57672
- Use new messaging structures, defined-names instead of hardcoded values.
- Enable temporary debugging tracing and add some DPRINTs.
- Delete an unused variable.
svn path=/branches/ros-csrss/; revision=57667
This is the first of a series of commits aiming at making kernel32 using the new CSR messaging structures for communicating with Server Dlls.
svn path=/branches/ros-csrss/; revision=57666
- Remove the now unneeded CSR messaging support.
- CsrInit() goes away also and the usage of the CsrProcess is replaced by that of gpepCSRSS.
[WINSRV]
- Use a DLL instance for loading resources, instead of calling GetModuleHandle.
[KERNEL32/NTDLL]
- Remove unneeded variables.
svn path=/branches/ros-csrss/; revision=57665
- Correct an enumeration identificator initialization.
- Move the call of CSR for registering the logon application, from kernel-mode win32k to user-mode user32
and therefore remove the unneeded co_CsrNotify function (plus some other unneeded defines).
- Comment some non-working code (#if 0) in user32/misc/misc.c and winsrv/shutdown.c.
svn path=/branches/ros-csrss/; revision=57664
- Move the ReactOS-specific workaround described in http://jira.reactos.org/browse/CORE-6611 and http://jira.reactos.org/browse/CORE-4620
from kernel32 to ntdll for using it by RtlGetVersion, in order to :
* still having it available in user-mode only,
* and having VerifyVersionInfo (and its Rtl counter-part) working properly.
[RTL/NTOSKRNL]
- Code formatting.
- Use a defined-constant instead of a hard-coded value.
svn path=/trunk/; revision=57662
Fix report of OS version: we report us as Windows Server 2003 SP1, in a consistent way, i.e. our product type is ServerNT and not WinNT (workstation).
However, for applications which would need to see us as a workstation OS, a workaround exists and can be activated manually by the user (by default it is not).
See http://jira.reactos.org/browse/CORE-4620 for a description of the workaround.
CORE-6611 #comment In r57661, our version is reported consistently.
svn path=/trunk/; revision=57661
- Remove InputDesktopHandle variable because it is a handle and that means that it can only be used in the context of winlogon
- Fixes NtUserOpenInputDesktop which never really worked
svn path=/trunk/; revision=57659
- Use ONEPARAM_ROUTINE_GETCURSORPOS instead of ONEPARAM_ROUTINE_GETCURSORPOSITION in GetCursorPos
- Correctly check if the current thread belongs to the active desktop
svn path=/trunk/; revision=57657
- Properly handle deletion of cursor/Icon objects
- Gracefully change object owner when process closes
- Remove useless check in a macro
svn path=/trunk/; revision=57641
[WIN32CSR/BOOTDATA]
- Finally get rid of win32csr, being replaced by winsrv and consrv.
- Remove it from the subsystem command-line.
[WINSRV]
- Move a hack from win32csr to winsrv.
svn path=/branches/ros-csrss/; revision=57635
- Use the new subsystems header winmsg.h
- Use the new USER_API_MESSAGE structure, and adapt co_CsrNotify in consequence.
- Code formatting.
[KERNEL32]
- Use the new subsystems headers basemsg.h, conmsg.h, winmsg.h, etc...
[NTDLL]
- Code formatting only.
svn path=/branches/ros-csrss/; revision=57628
- Double the size of the user handle table in order to allow the test suite to complete despite the horrible object leaks
svn path=/trunk/; revision=57624
- Fix WARN macros
- Keep a list of the PROCESSINFO of all the running processes
- Count how many handles a process owns per type in PROCESSINFO
- Improve the debug output when we run out of user handles to show all handle counts per process
svn path=/trunk/; revision=57623
- From version 9.0, mesa doesn't ship the glu library anymore. It is maintained in another tree.
- Introduce glu 9.0 to ReactOS code base.
svn path=/trunk/; revision=57621
- Fix structures usage and headers inclusions.
- Make winsrv compile.
- Deactivate some code related to processes enumeration (for testing purposes).
svn path=/branches/ros-csrss/; revision=57620
- Add winsrv and consrv to the Win32 subsystem command line. Keep win32csr but move it to another Server ID (till it disappears).
svn path=/branches/ros-csrss/; revision=57612
- Move the last APIs which should be in winsrv and remove unneeded files and resources from win32csr. Keep only the desktop things.
- I'm waiting for the patch of Giannis which would act on win32csr, then I will transfer the needed changes into winsrv and I will remove definitively win32csr.
At the moment, winsrv doesn't compile, but win32csr does.
svn path=/branches/ros-csrss/; revision=57611
- Add consrv to compilation. It compiles now \o/
- Convert the used console-csrss structures to the new ones.
[CSR]
- Continue to move some structures, and temporary activate a symbol.
[WIN32CSR]
- Clean a header.
svn path=/branches/ros-csrss/; revision=57602
- Use LookupAccountNameW to retrieve the account SID when a user tries to log-on to a computer.
- Little clean-up of LogonUserW.
This is the first step to get rid of hard-coded logon stuff.
svn path=/trunk/; revision=57601
- Move all the console subsystem from win32csr to a new server dll called consrv.dll (instead of putting it directly to winsrv.dll). It's because I want to rework on this later on.
Many things must be done in order to achieve the moving (renaming functions, etc...). Tables & symbol names come from http://j00ru.vexillium.org/csrss_list/api_list.html as usual,
but here I took the Win 2k3 ones and I added few Win 7 functions which already existed in our codebase. The other table names are guessed based on what originally existed in csrsrv
and so on. Many stubs are also missing.
Cultural remark: consrv.dll originally existed in Beta releases of Windows NT 3.1 (e.g. the October 1991 one), but was soon merged with winsrv.dll and thus, in subsequent versions of
Windows, the console subsystem is also found in winsrv.dll. See http://www.logotypes.se/NT310CSRSS.txt and http://j00ru.vexillium.org/?p=349#comment-1883. One has to wait until
Windows 7 to see it moving again to conhost.exe.
[CSRSRV]
- Add an explanation comment on what the ValidTable member in the CSR_SERVER_DLL structure is for.
svn path=/branches/ros-csrss/; revision=57597
- Implement HidP_GetUsageValue
- Add hack to HidParser_GetScaledUsageValueWithReport
[MOUHID]
- Add partial support for absolute pointing devices
- Tested in VBOX 4.1.22 with absolute pointing devices
- Needs more work in win32k
- Core 6553
svn path=/trunk/; revision=57595
- Fix a variable and a header names.
[CSR]
- Move all the interesting code from the "old" csrsrv (see r57579) to the new one. TODO: finish to reorganize the code.
- Rename the headers to a standard naming I will use for the other server dlls.
- Remove now unneeded files.
(one can sometimes find commented names next to declaration of variables: it is when a variable name doesn't satisfy me because it isn't enough self-explaining for my taste).
[CONSOLE]
- Add a new header for console working (win32csr --> consrv.dll == the console part of winsrv.dll I separate from it, because I plan a profound reworking on the console after all that).
svn path=/branches/ros-csrss/; revision=57591
- Use new naming scheme.
[CSRSRV]
- Continuing headers reorganization.
- Activate new code.
[CSRSRV/WIN32CSR]
- Move some code into basesrv.
[BASESRV]
- Add basesrv.dll
The names of the APIs tables come from http://j00ru.vexillium.org/csrss_list/api_list.html as usual,
however I used the NT 4 ones for testing purposes only. After that I will update them to 2k3 version
and add function stubs. Also some variable names are deduced from the subsystems/win32/csrss/csrsrv/server.c ones.
svn path=/branches/ros-csrss/; revision=57587
- Change the account and domain names in the WELL_KNOWN_SID type to AccountName and DomainName.
- Implement a function to look-up fully qualified well-known names (for example "NT AUTHORITY\LOCAL SERVICE"). This kind of look-up was still missing from LsapLookupNames.
- Ensure that all well-known SIDs returned by look-up functions are copied from the list of well-known SIDs, because RPCRT4.DLL frees the SID buffers after copying the SIDs to the caller. This will corrupt the well-known SID list if pointers to the original SIDs are passed.
- Check all memory allocations.
svn path=/trunk/; revision=57581
- Rename ProcessDataLock to CsrProcessLock (as it was in the "old" csrsrv, see r57579).
- Merge the APIs from the "old" csrsrv (subsystems/csr , see r57579) with the other ones (subsystems/win32/csrss/csrsrv).
- Reorganize the functions into Private & Public functions.
- Add temporary comments.
- Start removing things which should be present in basesrv instead of in csrsrv.
This breaks build of this branch at the moment...
svn path=/branches/ros-csrss/; revision=57580
Add setupapi.dll to the KnownDlls list.
CORE-6732 #comment Quake II setup fixed in rev 57576. Patch by Lee Schroeder. #resolve
svn path=/trunk/; revision=57576
- Use the new messaging structures and the new macros, plus the new CSR_API function's signature (--> and rename some variables).
- Code cleaning & formatting.
[CSRSS/NDK]
- Reorganize all the header files in logical units (server.h for server-side of CSR, client.h for client-side, and msg.h for messaging), removing duplicated definitions.
- Code cleaning & formatting.
The next step would be to activate the code of server-dll loading inside csrsrv, then moving all the console-related APIs from win32csr to winsrv, the latter built with the same structure as csrsrv's.
svn path=/branches/ros-csrss/; revision=57570
- Add well-known account names "LOCALSERVICE" and "NETWORKSERVICE" as aliases of "LOCAL SERVICE" and "NETWORKSERVICE". They can be found on a german Windows XP.
- Remove a part LsaLookupSids that returned "UNKNOWN\Test" for unknown SIDs. Was used for tests only.
svn path=/trunk/; revision=57568
LsapLookupIsolatedNames: Add a domain entry to the referenced domain list for an unknown/unidentified domain. Its SID is the SID of the account minus the last sub-authority and its name is an empty string.
svn path=/trunk/; revision=57557
- Use COM for calling SHBrowseForFolder.
- Allow choosing a directory for downloading.
- Correct a typo in the name of a function.
svn path=/trunk/; revision=57553
- Pre-implement InitiateSystemShutdownExW.
- Cosmetic formatting code (by me).
Patch by Lee Schroeder. See CORE-6613 for more details.
CORE-6613 #comment Committed shutdown.c.
svn path=/trunk/; revision=57546
Correct the SP number (==> SP1) we are reporting (currently SP1 of Windows Server 2003). The SP6 thingie was a remainder from our previous target, Windows NT 4 SP6.
svn path=/trunk/; revision=57543
Use a temporary buffer to parse the program's arguments, instead of using (and thus overwriting) the _a/wcmdln variable.
Fix msvcrt_apitest:CommandLine test.
CORE-6717 #comment Fixed in revision r57536. #resolve
svn path=/trunk/; revision=57536
- Assume that the provided buffer size is maximal in GetDIBits
[WIN32K]
- Probe buffer before writing to it
- Fail DIB Section creation if palette creation failed
svn path=/trunk/; revision=57535
- Fix a bug in RtlAreAnyAccessesGranted
- Fix an MSVC warning in RtlEqualPrefixSid
[CRT]
- Fix an MSVC warning in _ui64tow_s
[NTOSKRNL]
- DPRINT the filename when MmLoadSystemImage fails
- Fix a few MSVC warnings
svn path=/trunk/; revision=57518
Implement lookup of accounts in the account domain of the SAM database. The advapi32 security winetest shows proper domain and account names for the administrator and guest SIDs.
svn path=/trunk/; revision=57517
Implement SamIFree_SAMPR_RETURNED_USTRING_ARRAY and SamIFree_SAMPR_ULONG_ARRAY.
These functions are used to free structures that were allocated by calls to Samr-functions.
svn path=/trunk/; revision=57516
In NtQuerySystemEnvironmentValue :
- Use a fixed-length buffer size for holding a temporary variable.
- Correct the pool TAG.
svn path=/trunk/; revision=57514
- Store the names and SIDs of the built-in and account domains in global vaiables.
- Move the lookup code for isolated names to a separate function.
svn path=/trunk/; revision=57511
Use a struct do define the combined DIBSECTION/BITMAPINFO buffer in CreateCompatibleBitmap, to make it more clear how it works. See CID 716216
svn path=/trunk/; revision=57509
Chnge return type of ClientLoadLibrary to BOOL. Previously it returned HMODULE in both the load and unload case, being a meaningless value in the latter case. All users of this function were using it as a boolean parameter only.
svn path=/trunk/; revision=57507
- Make LsarLookupNames, LsarLookupNames2 and LsarLookupNames4 call LsapLookupNames and convert the results where this is needed.
- Split the lookup code in LsapLookupSids into separate functions.
svn path=/trunk/; revision=57503
- Make LFONTs (for some incomprehensible reason called TEXTOBJ in ros) shared objects, as they are supposed to be. Since that conflicts with our totally broken font code that happily messes with the LFONT's contents, an additional push lock is aquired to get exclusive ownership.
svn path=/trunk/; revision=57494
- Tested wine win test_scrollwindow, test_scrollvalidate, test_scrolldc, and test_scroll plus ReactOS API tests. Pass all but three region tests in test_scrollvalidate.
- Dedicated to Víctor Martínez Calvo.
svn path=/trunk/; revision=57491
- Change LsapLookupSids to match LsarLookupSids2 and LsarLookupSids3.
- Implement LsarLookupSids2 and LsarLookupSids3.
- Update the call to LsapLookupSids in LsarLookupSids and convert the translated names list after calling LsapLookupSids.
svn path=/trunk/; revision=57489
- Move most of the code from LsarLookupSids into LsapLookupSids.
- Use the code from LsapLookupNames to handle the referenced domains list in LsapLookupSids.
svn path=/trunk/; revision=57488
- Fix what might finally be the last missing "this->" instances left over from the C++ conversion (used a regex this time)
svn path=/trunk/; revision=57485
- Convert the application's code to UNICODE
- But the regproc.c's code is untouched (apart from the pseudo-error messages issued with fprintf)
svn path=/trunk/; revision=57471
Fixes several bugs in the current implementation of LsapSplitNames and LsapLookupNames. This fixes the crashing lsa advapi32 wintest. LsapLookupNames is still WIP.
svn path=/trunk/; revision=57464
- WCHAR ==> TCHAR in (before a REALLY conversion of regedit into UNICODE)
- Correct some mistakes in displayed strings
- Improve informative / warning / error messages when importing registry files
- Now, try to import each registry file specified in the command line and don't fail miserably when one of them is missing, but continue with the next one (as Windows' regedit does).
Patch by Edijs Kolesnikovičs (2/2) adapted by me.
CORE-6239 #comment Fixed in r57462 with some adaptations. Thanks ;) #resolve
svn path=/trunk/; revision=57462
Move gdi kdbg extension into a separate file, prefix names with ! to match WinDbg extensions more closely (e.g. "!gdi.help"), imlement help, dumpht, handle, entry and eventlist commands.
svn path=/trunk/; revision=57459
- Fix comment headers.
- Improve error-displaying function and add another one (to be used later on).
- Clear a part of code.
svn path=/trunk/; revision=57456
Implement Kdbg CLI callbacks. These callbacks can be registered from external modules and allow to process kdbg commands.
[WIN32K]
Implement kdbg callbacks for gdi: "gdi!dumpht <type>" dumps the handle table, "gdi!handle <x>" dumps information about a handle.
CORE-6650 #resolve
svn path=/trunk/; revision=57454
Get rid of the ugly container object code. Let LsapCreateDbObject and LsapOpenDbObject handle container objects instead.
svn path=/trunk/; revision=57449
- Validate Account SIDs in LsarCreateAccount and LsarOpenAccount.
- LsarOpenAccount: Do not check the granted access of the policy handle.
- LsarOpenAccount: Return the proper status code.
svn path=/trunk/; revision=57448
- Correct command processing following the first command in interactive mode.
- Correct invocation of command-specific help functions.
svn path=/trunk/; revision=57447
- Make srb volatile, since it's assigned inside SEH and referenced in finally
[NTOSKRNL]
- FsRtlTeardownPerStreamContexts: make IsMutexLocked volatile (SEH)
- IoCreateFile: Make SystemEaBuffer volatile (SEH), save status and information in the caller's IoStatusBlock, cleanup and fail when IoCheckEaBufferValidity failed with PreviousMode == KernelMode, too.
- NtLockFile: Move ExAllocatePoolWithTag out of the SEH block. ExAllocatePoolWithTag does not raise an exception by default (unlike ExAllocatePoolWithQuotaTag). Get rid of this SEH block completely and check the return value instead.
- NtQueryDirectoryFile: make AuxBuffer volatile (SEH), again move ExAllocatePoolWithTag out of the SEH block and check return value instead.
IopCaptureUnicodeString: Make Name volatile (SEH)
svn path=/trunk/; revision=57437
Add a "comment" that will notify whoever wants to compile this poc, to move the IoCompleteRequest out of the SEH block.
svn path=/trunk/; revision=57435
- Allocate a capture buffer outside of SEH in NtAddAtom and NtRaiseHardError
- Call ExpGetCurrentUserUILanguage outside of SEH in NtQueryDefaultUILanguage and return the actual result instead of returning PsInstallUILanguageId in case of success.
- Don't allocate a unicode string inside SEH in NtQuerySystemEnvironmentValue, instead use RtlAnsiStringToUnicodeString directly on the callers buffer.
CORE-6624
svn path=/trunk/; revision=57429
- Reset read and write events directly before waiting. Fixes an issue where a read could return 0 bytes if the previous read had read all available data without waiting (thus leaving the event set).
svn path=/trunk/; revision=57424
- Do not access ThreadContext after freeing it in NpfsWaiterThread
- Correctly update Vcb->EmptyWaiterCount when terminating in NpfsWaiterThread
- Fix more MSVC warnings, lots of DPRINTs
svn path=/trunk/; revision=57421
- Fix return status if no listening server found in NpfsCreate
- Do not use obsolete function MmGetSystemAddressForMdl
- Fix a few MSVC/GCC 4.7 warnings
- Correctly handle device/root FCB allocation failure
- Fix type of NPFS_CCB::RefCount
svn path=/trunk/; revision=57419
- Revert rev.57413. Indeed, when one boots ReactOS without debugging (selecting the first entry in the boot menu), the COM1 symbolic link (corresponding to \Device\Serial0) is created automatically by the serial driver. However, when one boots in debugging mode (selecting the second entry -- ReactOS (Debug) --), then for some reason the COM1 link isn't created (albeit \Device\Serial0 is). Therefore the real problem is elsewhere. Seems that it has something to share with http://jira.reactos.org/browse/CORE-4263
svn path=/trunk/; revision=57414
- HACK: Add artificially a symbolic link to the first COM port, because it happens for
whatever reason that the serial.sys driver doesn't create it when it creates the Serial0
device. When this functionality is repaired, the HACK shall disappear.
svn path=/trunk/; revision=57413
- Revert rev.57400 only for this file since CID 701342 was a false-positive from Coverity (because Coverity doesn't know what the aim of the POOL_RAISE_IF_ALLOCATION_FAILURE is).
svn path=/trunk/; revision=57411
- Implement LsaRemovePrivilegesFromAccount.
- Add stubs for LsaGetRemoteUserName, LsaLookupPrivilegeDisplayName, LsaOpenPolicySce and LsaSetInformationTrustedDomain.
- Fix some issues in the spec file.
svn path=/trunk/; revision=57410
- Reworking the Find* APIs in kernel32. Fixes some kernel32_winetest:file failures.
- The FindExInfoBasic information level for FindFirstFileEx, is also implemented.
- Update ndk and psdk headers regarding to this work.
CORE-6623 #comment Committed in rev.57407. #resolve
svn path=/trunk/; revision=57407
- Implement the PolicyDnsDomainInformation class of LsarQueryInformationPolicy and enable the PolicyModificationInformation class.
- Add required attributes to the initialization code.
svn path=/trunk/; revision=57397
- Implement most missing information classes of LsarQueryInformationPolicy.
- Add initialization code for new attributes of the policy object.
- Implement LsarQueryInformationPolicy2 and LsarSetInformationPolicy2.
svn path=/trunk/; revision=57391
- Remove duplicated definitions from ntddk.h
- Fix annotations in ntifs.h, wdm.h, ntgdi.h, winddi.h
[NDK]
- Declare most of the heap functions only for user mode
- Remove duplicate RtlGetNtGlobalFlags()
svn path=/trunk/; revision=57389
- Set the default quota limits when the LSA database is created.
- Implement the PolicyDefaultQuotaInformation class of LsarQueryInformationPolicy.
svn path=/trunk/; revision=57383
- Convert the application to Unicode.
- Implement "net start" and "net stop" commands that use the service manager APIs.
svn path=/trunk/; revision=57375
Unmap the desktop heap in IntFreeDesktopHeap. Fixes leaking session space memory, when creating and deleting desktops.
I would revert the "hackfix" from r57348, but for me changing MiPteToAddress to MiAddressToPte looks more like a legit bug fix, rather than "increasing system view space to 36MB instead of 20MB". But I'm probably missing something. In that case, Alex, please revert your hack, it shouldn't be needed anymore.
CORE-6688 #resolve
svn path=/trunk/; revision=57367
- Fix overlapped I/O error handling for pipe transport
- ROS now works with Windows npfs.sys again (CORE-2198)
- Wine has this completely reworked, so this ros-diff should finally disappear with the next sync
svn path=/trunk/; revision=57365
- Separate condition calculation in RtlVerifyVersionInfo into an extra function. Patch by Hermès Bélusca (2/X)
- Don't make the Hungarian more ridiculous than it needs to be
CORE-6611
svn path=/trunk/; revision=57355
- Skip all qmgr tests because they cause timeouts on testbot. This should hopefully be fixed soon and they can be re-enabled.
CORE-6536
svn path=/trunk/; revision=57353
- hungarian calc translation by Nagy Tibor(xnagytibor at gmail dot com); CORE-6511 #resolve #comment Commited. Thanks for your work
- dutch rapps translation update by stijnsanders (stijn at yoy dot be); CORE-6540 #resolve #comment Commited. Thanks for your work
svn path=/trunk/; revision=57350
- Correctly show the amount of available memory in the serial debug log. Patch by Hermès Bélusca (2/2)
CORE-6635 #comment Committed. Thanks. #resolve
svn path=/trunk/; revision=57333
make sure at least one rect is allocated in REGION_PtsToRegion. Fixes failed assertion when starting pacman4000 (the game itself doesn't work though)
CORE-5431 #resolve
svn path=/trunk/; revision=57329
This patch fixes various things, from Coverity code defects to conversion
warnings :
- CID 715948 (logically dead code @ services/rpcserver.c)
- try to fix CID 716332/3 (resource leaks) by rewriting the ScmReadString
function (@ services/config.c)
- zero out the freshly allocated memory (@ services)
- try to fix CID 716126/7/8 (untrusted value as argument @
advapi32/services/sctrl.c)
Fix also some "size_t to DWORD" warnings on x64 build (@
advapi32/services/scm.c).
Patch by Hermes BELUSCA - MAITO.
Fixes CORE-6606.
svn path=/trunk/; revision=57328
Allow passing NULL to EngFreeMem, like on Windows.
Fixes mode switching with cirrus driver on qemu.
CORE-6335 #resolve
svn path=/trunk/; revision=57325
Fix display of formerly trucated info text in German language.
Patch by Robert Naumann (robert dot naumann at ovgu dot de)
CORE-6218 #resolve
svn path=/trunk/; revision=57323
Rewrite FAT bootsector. It's written to eventually replace FAT12, FAT16 and FAT32 bootsectors using the same code. Currently only used for FAT16. The complete (!) code to load freeldr has been put into a single 512 byte sector. CHS support is not implemented atm, but there's plenty space left (41 bytes). Fixes boot on harddisks smaller than 513 MB.
CORE-6610 #resolve
svn path=/trunk/; revision=57319
* Don't add the whole absolute path to GCC for preprocessing when creating RC dependency files in Ninja builds.. that complicates the already complicated quoting needs here.
svn path=/trunk/; revision=57302
- Make a copy of the data type information instead of writing to the (read-only) .rsrc section. Already applied upstream.
CORE-6645 #comment Should be fixed. Can you retest with HEAD please?
svn path=/trunk/; revision=57298
Implement RtlpSafeCopyMemory, which uses SEH to copy the memory (not in freeldr)
Make RtlLargeIntegerToChar use RtlpSafeCopyMemory to copy the string to the target buffer.
CORE-3767 #resolve
svn path=/trunk/; revision=57295
- Aric Stewart : While calculating lines, discard uniscribe data for non-visible lines.
- Nikolay Sivov : Release uniscribe data on Edit control destruction (valgrind).
- Sync Port wine.
- Someone needs to post a wine bug report due to the lack of support for Ctrl+Backspace. Debug fixme was added. See bug 1419.
svn path=/trunk/; revision=57291
- NdisReadConfiguration should return NdisParameterInteger for requests for NdisParameterHexInteger
- Assert that conversion to integer from string does not fail
- Always trigger the ISR function if MiniportInitialize or MiniportHalt is executing
CORE-6064 #comment Please try to replicate with DEBUG_ULTRA turned on in NDIS
svn path=/trunk/; revision=57289
Finally commit the patch to improve freeldr disk performance by Carlo Bramini.
Obviously someone wants to read 0 bytes and that should not fail.
svn path=/trunk/; revision=57283
* Make freeldr_common depend on bugcodes and remove this dependency from the other targets.
* Improve those conditions readability a bit.
svn path=/trunk/; revision=57280
Apply Carlos patch again, but use MaxSectors = 1 for now. That should result in the exact identical behaviour as before.
svn path=/trunk/; revision=57278
- Use a writable buffer for lpCommandLine in CreateProcessW. Simplify starting of control panel applets. Patch by Hermès Bélusca.
- CORE-6570 #resolve #comment We need FishEye ;)
svn path=/trunk/; revision=57277
- Remove the FILESYSBUFFER from the memory layout, grow the DISKREADBUFFER to 64 KB
- Make use of the full disk buffer when reading sectors, speeds up hdd boot process by about a factor of 2, patch by Carlo Bramini
- See CORE-6071
svn path=/trunk/; revision=57274
Stop using the FILESYSBUFFER. It's a 64 KB memory region statically set up int the lower 1MB address space. This memory is rare and it doesn't make sense to put the buffer there, since it's only used to copy the data from the DISKREADBUFFER (which *must* be in the lower 1MB) to a temporary location to copy it to some other location afterwards. It's replaced with temporary heap buffers and direct reads, where possible. Also Don't read a full FAT cluster, when only a part of it is required.
svn path=/trunk/; revision=57267
[NTOSKRNL]: As a side effect, implement SeCreateClientSecurityFromSubjectContext and SeGetTokenControlInformation, although most of the code was already there.
[NTOSKRNL]: One useful change, SE_GROUP_USE_FOR_DENY_ONLY (Deny Only Groups) are now handled correctly.
svn path=/trunk/; revision=57261
[PSDK]: Sync some headers and idl files with Wine.
[PSDK]: Import xmldom.h from Wine.
[LIBWINE]: Sync some debugging functions with Wine.
[UUID]: Add SID_SContainerDispatch.
[MSXML]: Import from Wine.
[MSXML2]: Import from Wine.
[MSXML3]: Sync with Wine 1.5.12.
[MSXML4]: Import from Wine.
[MSXML6]: Import from Wine.
[SYSSETUP]: Register the newly imported msxml* dlls.
svn path=/trunk/; revision=57257
- Move exception stuff to rtltypes.h
- Add missing exception flags
- Add _DISK_GEOMETRY_EX forward declaration
[PSDK]
- Add missing exception flags to winnt.h
[NDK]
- Remove exception flags, they are defined in both winnt.h and wdm.h
svn path=/trunk/; revision=57255
* Remove the importlibs folder. It's not needed anymore. While we're here, it's worth noting that the use of link_directories is not recommended, you should use target_link_libraries with absolute paths for example.
svn path=/trunk/; revision=57238
- Move more support for Desktop Proc into Win32k. Increase Desktop drawing by about 10%. Rearanged code and plugged in the server side callout.
svn path=/trunk/; revision=57236
[NTOSKRNL]: Restore the page table reference counting mechanism, and put it in a macro to be cleaner. Also use macros for testing PD boundaries, instead of math-by-hand.
svn path=/trunk/; revision=57229
Thank you thfabba (Thomas Fabber) for one of the most useful, yet ignored, tests in our suite. Hope this makes it up to you.
svn path=/trunk/; revision=57225
[NTOSKRNL]: Kill a bunch of now-useless DPRINT1s in Mm, significantly cleaning up the log.
[HIVES/MSI]: .NET needs InstallRoot, not InstallDir. Kills millions of DPRINT1s, thus cleaning up the log.
svn path=/trunk/; revision=57221
[NTOSKRNL]: No longer support non-ARM3 sections in NtProtectVirtualMemory, as the only OS calls were already NO-OPS.
[NTOSKRNL]: Always use ARM3 sections unless SEC_PHYSICAL_MEMORY is used, and make the check explicit.
[NTOSKRNL]: No longer support allocating memory on top of non-ARM3 sections.
[NTOSKRNL]: No longer ASSERT when certain features are not yet implemented, instead return an error code.
[NTOSKRNL]: Add another check in NtFreevirtualMemory when invalid memory is being freed, insert of ASSERTing.
[NTOSKRNL]: Implement and use MiIsEntireRangeCommitted when protecting memory to make sure the entire range is committed.
This patch removes multiple hacks, ASSERTs, and evil mixing of ARM3 and non-ARM3 code/memory.
svn path=/trunk/; revision=57215
Mark intrinsics on gcc with __attribute__((artificial)) so that they appear as one unit in the debug info. This way traces don't point inside the implementations, when they cause an eception, but rather to the line where they are used.
svn path=/trunk/; revision=57214
[NTOSKRNL]: Remove an ASSERT(FALSE) that was only there for testing.
[NTOSKRNL]: Support transition pages during prototype PTE faults, which is our first try at soft faults! Should fix ASSERTs that were seen in the previous attempts in ole32, corrupting the registry.
[NTOSKRNL]: It's fine for MiCreatePagingFileMap to fail in MmCreateSection -- don't assert and simply return failure. Should fix the ASSERTs taht were seen in KmTest.
[NTOSKRNL]: Enable richard's ARM3 section code unconditionally for all non-file backed sections. Works4me. Let's see what Testbot says.
Nobody has showed me how to use/where is PatchBot, and google founds 0 relevant results, so this is going into main again. However I'm actually home this week to revert if something goes wrong :)
svn path=/trunk/; revision=57209
Freeldr size is currently limited to 448 KB. On MSVC it was already at 442 KB, before wine's wctype table was used. The new wctype table is itself 37 KB. This lead to freeldr overflowing into memory regions that were used for the filesystem buffer, causing bootfailures. Fix this by giving freeldr it's own using _isctype(), since freeldr casts WCHAR to CHAR anyway.
svn path=/trunk/; revision=57205
Move imagesoft to applications and add it to build.
Convert lang files to UTF-8.
Fix casts and x64 warnings.
Patch by Hermes Belusca.
See bug 7185 for details.
svn path=/trunk/; revision=57201
Add vgafontedit to build.
Convert the language resource files into UTF-8.
Fix x64 warnings.
Patch by Hermes Belusca.
Bug 7152.
svn path=/trunk/; revision=57200
- Fix a memory overwrite bug in some crappy WINE code that leads to nasty memory corruption of the service cache entry. This corrupts the first field of the cache, causing it to always reallocate memory because it thinks the size is 0. This would be even worse if the code didn't overwrite the other 12 bytes of corruption with proper data on the next lines. This also caused the aliases value to be garbage because it pointed at uninitialized data.
svn path=/trunk/; revision=57199
- Implement proper support for partial sends on TCP sockets
- This prevents a deadlock when a very very large packet is queued to be sent
svn path=/trunk/; revision=57186
* Prefer STREQUAL over MATCHES since we're comparing with strings here. Brought to you by Hermès Bélusca.
See issue #7306 for more details.
svn path=/trunk/; revision=57181
- Add some tests for lstrncpyW
- This function is fine, I wrote that when chasing some bug thinking this function was at fault.
svn path=/trunk/; revision=57179
- Fix one of the worst bugs in AFD of all time. Our AFD code operated under the assumption that none of the input parameters would change once we called LockRequest. This assumption is completely false. The only guarantee that made was that the pages never disappeared from us, not they they couldn't be modified. There are frequent cases where the user-mode buffer was modified from underneath us (WSPRecv allocates the struct on stack which makes it invalid during overlapped operations that complete later). When this happened, we would bugcheck when we tried to unlock the buffers since we accessed this in a member of the struct the caller passed us.
- I've fixed this by adding a parameter to LockRequest which specifies whether the buffer should be copied back when it is unlocked.
- This bug has been around for ages and I was never able to figure out why we just freed garbage sometimes. Now that the ws2_32_winetest exposed it reliably, I was finally able to fix it.
svn path=/trunk/; revision=57175
- mark DllMain as a weak symbol for GCC.
- supply a stubbed DllMain for MSVC.
- DllMain is optional, and some DLLs don't implement it. That doesn't mean that they have no entry point, it means "I have nothing more to initialize than the CRT".
svn path=/trunk/; revision=57171
- Change AFD to a very aggressive buffering policy
- It now attempts to keep its 64K receive buffer completely full at all times
- This increases network performance significantly
svn path=/trunk/; revision=57170
- Implement LsaSetSeceret/LsarSetSecret (secret values are not encrypted yet) and LsaSetSystemAccessAccount.
- Improve some TRACE messages.
svn path=/trunk/; revision=57167
- Make hard-coded calling convention exceptions in ExInterlocked compatible with GCC 4.7, and add the corresponding TODO about how ugly this is
svn path=/trunk/; revision=57166
PSEH2 uses a special mechanism to deal with nested try blocks inside the same function. Instead of pushing a second exception registration record on the exception list, it uses an internal pointer to handle the different try-levels.
But when a function using SEH is inlined, the resulting code will push 2 registration frames on the stack. Now it happens with GCC 4.7.1 that these frames get shuffled on the stack, putting one for the inner try on a higher stack address. This is something that RtlUnwind regards as a bug and throws a STATUS_INVALID_UNWIND_TARGET exception. This was the reason for the crashing PSEH2_TEST, when compiled with GCC 4.7.1.
To fix this, I added a mechanism that will prevent functions using SEH from being inlined.
svn path=/trunk/; revision=57159
- Check result of walking the import descriptor and properly fail in case it wasn't successful.
See issue #7289 for more details.
svn path=/trunk/; revision=57156
[NTOSKRNL]: Remove an ASSERT(FALSE) that was only there for testing.
[NTOSKRNL]: Enable richard's ARM3 section code unconditionally for all non-file backed sections. Works4me. Let's see what Testbot says.
svn path=/trunk/; revision=57155
- Add some optimizations (GCC) on compilation of libMesa
- Move opengl32 to the opengl directory
- Disable ICD refcounting for now, it does more harm than good.
svn path=/trunk/; revision=57153
* Call cl directly instead of its full path using <CMAKE_C_COMPILER>. Figuring out why it didn't work is left as an exercise for the reader.
svn path=/trunk/; revision=57152
Hermès Bélusca:
* Fix a bug in the way we compiled the boot sectors on the x64 build.
* Consistently set the mc compiler, like gcc builds.
* Use proper variables when referring to the compilers.
See issue #7297 for more details.
svn path=/trunk/; revision=57151
- Fix a bug causing FIONREAD to return an incorrect value after a datagram receive completes when only returning a subset of the data (returns WSAEMSGSIZE)
svn path=/trunk/; revision=57147
- Add fake iostream headers to fix MSVC compilation
- hack numerical_limits<float>::infinity() implementation until we have a real C++ library
Oddly, empty headers seem to be enough for now
svn path=/trunk/; revision=57136
[IPHLPAPI] - Fix a use after free in getNthInterfaceEntity (CID 716795 - partly reverts r53190). Fix a possible double free in getArpTable (CID 716796).
svn path=/trunk/; revision=57127
- Use wine's wctype table in CRT for iswctype() function. Previous implementation was returning incorrect information for non-Latin characters. Problem found and fixed by Sergey Shamanaev (seven_ro).
- Move wctype.c from libwine to lib/sdk/crt instead of making yet another copy of it (currently there is one more in tools/unicode). Suggested by Amine Khaldi.
See issue #5090 for more details.
svn path=/trunk/; revision=57119
- Add support for getting and setting SO_EXCLUSIVEADDRUSE
- Add support for setting SO_REUSEADDR
[AFD]
- Implement proper TDI way of indicating a reusable address file
- More work remains in TCP/IP to support this
svn path=/trunk/; revision=57115
- Fix screensave access hangs but it was recoverable and did not crash. The new ATI points seem to kick in so disabling them for now and leaving error prints. See bug 7225, need to separate the message queue.
svn path=/trunk/; revision=57114
- Active, Focus and Foreground. Fixes many of the the wine tests and including the todos. Fix bug 7089.
- Get ATI support points in place, include code support for ptiSysLock which will be rewritten soon.
- Move Desktop Proc to Win32k. This will allow the access checks to work. Note: DesktopBG.c creates a Win32 thread every time a Desktop is created. Please keep the file and code intact for historical purposes.
- Get code close to wine.
References:
Focus test ROS passes: http://www.winehq.org/pipermail/wine-patches/2012-August/116887.html
Install acts and looks better: http://www.resmap.com/instructions/plug-ins/ERViewer7_0_RC.exe
svn path=/trunk/; revision=57111
- Attempt to fix Win test_mouse_input, properly set MA_ACTIVATE with right conditions when sending WM_LBUTTONDOWN.
- Get code close to wine.
svn path=/trunk/; revision=57109
Remove "size_t to DWORD/int..." conversion warnings in x64 build.
Patch by Hermes Belusca.
I replaced size_t by SIZE_T, as this is the proper Win32 type. And I also used the prefix 'cch' (count of characters) instead of the generic 'dw'.
See issue #7149 for more details.
svn path=/trunk/; revision=57108
- Move WM_SETREDRAW and WM_SYNCPAINT to Win32k.
- Patch by Alex Henrie: Minimize and maximize boxes can only appear when WS_SYSMENU is set.
svn path=/trunk/; revision=57105
- AttachThreadInput, this should fix the crash. Original crash patch by Giannis Adamopoulos. See bug 7225.
- WARNING: This code should be turned off until the restructuring is finished. Please read bug 7225!
svn path=/trunk/; revision=57103
- Fix a memory leak in the failure path of WSPGetSockName and WSPGetPeerName
- Fix a broken debug print in WSPGetPeerName
svn path=/trunk/; revision=57097
- Sync WIDL to Wine 1.5.10. Part 1 of 2.
- Adjust files to use MIDL compatible header guards.
- Add support for nameless structs and unions.
svn path=/trunk/; revision=57095
- Add more option support to WSPGetSockOpt and WSPSetSockOpt
- Return the correct error code for an unsupported option in WSPGetSockOpt
- Hack a SO_ERROR get handler together for apps that need it
- Add better unsupported protoopts debugging (particularly for getsockopt)
- SMPlayer can now stream media from the Internet :)
svn path=/trunk/; revision=57094
- Do not assume null termination of DllName and optimize extension search in LdrpLoadDll. Patch by Alexander Yastrebov (menone7 at gmail dot com).
See issue #7251 for more details.
svn path=/trunk/; revision=57092
- Fixed skip test regression in User32 Win wine test.
- Regressed one scroll control test. AbiWord scrolls and Explorer redraw issue still
the same.
- WIP: Rearranged code for standard structures prior to moving scroll code to Win32k. Proc support will remain in User32 (A2W etc) and redirected to Win32k. Drawing support will be added when this switch is made. Then ReactOS will have 100 percent wine scrolls plus our fixes in one file.
svn path=/trunk/; revision=57091
Patch by milawynsrealm:
* Implemented the beginnings of InitiateShutdownA/W (nothing works yet, and it's not exported).
* Running InitiateSystemShutdownA/W invokes InitiateSystemShutdownExA/W while
using "Other (Planned)" as the reason code.
- The "Other (Planned)" reason code seemed to be the best default
option so far.
Let me know if you feel otherwise.
* Added the shutdown flags that are used for InitiateShutdownA/W inside of
winreg.h.
* Include the reason.h header inside the winreg.h header so that the reason
codes can be
properly called. This conforms to the VC2010 method of adding this support.
* Added the declarations for InitiateSystemShutdownExA/W and InitiateShutdownA/W inside of winreg.h.
* In winuser.h, change the definitions for EWX_* to conform to MSDN
documentation
-
http://msdn.microsoft.com/en-us/library/windows/desktop/aa376868%28v=vs.85%29.aspx
* Added definition support for EWX_HYBRID_SHUTDOWN which is found in Windows 8.
* Calling InitiateSystemShutdownExA will convert strings to UNICODE and send it
over to InitiateSystemShutdownExW. The same is also for InitiateShutdownA.
See issue #7245 for more details.
svn path=/trunk/; revision=57089
- Deactivate Test_SimpleParameters in AttachThreadInput tests until it doesn't crash in win32k.
- Add some more tests in Test_SimpleParameters that should bring win32k to its limits
svn path=/trunk/; revision=57085
- change error messages in CallWindowProc to make it apparent that we caught an exception with SEH as requested by Caemyr
svn path=/trunk/; revision=57084
- Do not treat the release of the windows key as a hotkey if it was used as a modifier for another hotkey that was pressed
- Now if I press win+R only the Run window opens
svn path=/trunk/; revision=57083
- Hack around the fact that desktop handling in ros is awful. Now the child threads use the proper desktop.
- Convert all calls to SendMessage to SendMessageTimeout to make sure it won't hang (it doesn't hang in windows but who knows what can happen in ros)
- Add a few more tests
svn path=/trunk/; revision=57079
Use FILE_FLAG_NO_BUFFERING and FILE_FLAG_WRITE_THROUGH in the hope that they prevent journal changes from getting lost.
svn path=/trunk/; revision=57077
Use "advanced C++ features" like default parameters to reduce the complexity of StringOut calls and fix a warning in the MSVC build :-)
svn path=/trunk/; revision=57076
- Fix bug 6751, 7228 and others, Validate link windows, not relink them per say.
- Stop spurious window handle errors. This fixes all of the DeferWinPos handle errors.
svn path=/trunk/; revision=57068
- Increase the size of the ID buffers to fit certain non-standard IDs reported by Hyper-V on Windows 8. These should be allocated from pool, but this code really sucks and should be replaced anyway.
- Fixes buffer overflow causing a bug check during boot on Hyper-V
svn path=/trunk/; revision=57067
- Fix a critical bug in interrupt handling that could result in HAL returning the current processor to the wrong IRQL after an interrupt is handled that requires a raise to a synchronize IRQL.
svn path=/trunk/; revision=57065
- Fix a critical bug in interrupt sharing between scsiport miniports and other drivers which caused scsiport to mask the interrupts from other devices sitting behind it
- This commit and r57063 fixes bug 7231
svn path=/trunk/; revision=57064
- Fixed crash, see bug 7226.
- AttachThreadInput is new to ReactOS, it passes the wine tests, help is needed, white papers are welcome.
svn path=/trunk/; revision=57045
[NTOSKRNL]: Massively cleanup triplicated code that is just a series of macros/inlines.
[NTOSKRNL]: Handle more complex prototype PTE faults that are not just demand-zero.
In my private branch, I can now run ReactOS with *all* pagefile-backed sections running under ARM3 mode.
svn path=/trunk/; revision=57033
- Sync FormatMessage implementation to Wine 1.5.4. Fixes crash in kernel32_winetest:format_msg.
See issue #7217 for more details.
svn path=/trunk/; revision=57031
- Implement CaptureUnicodeStringOrAtom, which handles user mode class names or atoms, and use it in some places.
- Fix a number of format strings
svn path=/trunk/; revision=57023
* Set the attribute before the variable in write_func_param_struct(). Should be sent upstream.
* Initialize in an MSVC compatible way. Should be sent upstream.
[REACTOS/IDLS]
* Use widl instead of midl in MSVC builds.
svn path=/trunk/; revision=57019
- Use trivial Clip object, if NULL one is passed in IntEngAlphaBlend
- In NtGdiDescribePixelFormat allow passing NULL for the output pixel descriptor and copy the result *to* the caller not from the caller.
- Fix some format strings
- Update some annotations
svn path=/trunk/; revision=57013
Partly revert r56995. Firstly it breaks MSVC builds, secondly the stuff doesn't belong into this header. MS headers don't have __fpclassify etc and our headers are not supposed to contain any fancy additions. If you need it for 3rd party code, put it somewhere else.
svn path=/trunk/; revision=57012
[NTOSKRNL]: Set MiSessionSpaceWs address and use where needed.
[NTOSKRNL]: Initialize the session working set, and add support to MiLockWorkingSet and MiUnlockWorkingSet for session WS.
[NTOSKRNL]: Implement MiSessionAddProcess and MiSessionRemoveProcess which does the work required for this.
[NTOSKRNL]: Fix IoGetIrpRequestorProcess.
In my private branch, MmMapViewInSessionSpace is working fine for the user and GDI heaps. Will enable after TestBot tests.
svn path=/trunk/; revision=57011
- pass COLORADJUSTMENT to IntEngStretchBlt
- IntEngStretchBlt, EngStretchBltROP, DrvStretchBltROP always use a source, ASSERT that
- annotate pbrDefaultBrush and psurfDefaultBitmap as _Notnull_
- Don't use uninitialized psoInput in EngStretchBltROP
- Use trivial CLIPOBJ instead of NULL in IntEngStretchBlt
- Always pass a source surface to EngStretchBltROP
svn path=/trunk/; revision=57008
- Fix PREFAST warnings related to printf format strings, empty SEH handler, some possible NULL pointer dereferences, some unchecked return values
svn path=/trunk/; revision=57005
[NTOSKRNL]: Don't assume all prototype PTEs are cached, in fact none are in ReactOS at the moment! This resulted in the wrong hardware caching bits for the PEB/TEB and NLS Data which are using ARM3 section code.
[NTOSKRNL]: Also implement dirty page bit for prototype PTEs.
svn path=/trunk/; revision=57000
* Leverage the object library option provided by CMake 2.8.8+ which will speed up the build even further.
* These wrapping conditions will go away as soon as we ship the new BE.
svn path=/trunk/; revision=56997
- Add some more C99 math functions
- Fix definition of __forceinline and FORCEINLINE for C99
- Fix and add definition of _aligned_malloc and _aligned_free
- Fix definition of is(w)blank, as a C99 function, it is not in msvcrt.dll and has to be implemented in msvcrtex
All of this taken from the mingw-w64 project
svn path=/trunk/; revision=56995
- Partial update of math.h
Someone used to mingw-w64 headers system should look into this, I NEED those C99 functions!
svn path=/trunk/; revision=56989
- Implement MiProtectVirtualMemory for VAD based allocator (it's very similar to the already implemented MiSetProtectionOnSection function). However it still doesn't fully work because support in other functions is missing (failed assertions in MiFlushTbAndCapture).
See issue #7216 for more details.
svn path=/trunk/; revision=56986
- Align the stack on a 16-byte boundary for x86 like any sensible compiler would, anyway. Should fix weird GCC 4.7 behavior.
svn path=/trunk/; revision=56985
- Add _PRAGMA_WARNING_SUPPRESS() macro
- Fix definition of __analysis_noreturn for PREFAST runs
- Annotate RtlAssert with __analysis_noreturn everywhere
- Add proper annotations to all DbgPrint and DbgPrintEx definitions
- Suppress warnings for use of ProbeForRead outside of SEH
svn path=/trunk/; revision=56983
* Explicitly mark the functions as stdcall (NTAPI).. -mrtd changes the default calling convention, but name-decoration isn't affected by this. The -mrtd feature has its origin in some older linux-code-mode, and it's considered for removal in GCC 4.8.
* Fix some warnings.
svn path=/trunk/; revision=56973
* In the journey of running his GCC 4.7.1 compiled bootcd, two issues were revealed. Thomas kindly investigated them and fixed them, and as a result the bootcd boots to shell !
[CSRSRV]
* Fix the output parameter of ProcessLUIDDeviceMapsEnabled case in NtQueryInformationProcess() to be ULONG instead of BOOLEAN (as required).
* ASSERT that the function succeeds.
[SMSS]
* Move this condition up to the commented-out part (where it belongs).
svn path=/trunk/; revision=56972
- Take translation into account when inverting an XFORMOBJ
- Always use the matrices from the DCATTR instead of DCLEVEL
- Mark Device-to-World translation as invalid when the Window Origin is modified
Fixes 7088
See issue #7088 for more details.
svn path=/trunk/; revision=56970
- Fix _XSTATE_SAVE definition for ARM
[NDK]
- #if out NtCurrentTeb() inline function for ARM, it's implemented in ARMLIB
[CRT]
- #if out some intrinsics in msc/intrin.h that don't exist on ARM
- Add _crt_va_start, _crt_va_arg and _crt_va_end for ARM
svn path=/trunk/; revision=56964
- Separate some _CI* functions into their own files and export them from ntdll. Patch by Vincenzo Cotugno.
See issue #7085 for more details.
svn path=/trunk/; revision=56961
FF 3.6 and Thunderbird 3 is no more and thus is hosted on the same spot as the older FF versions are.
Fox Audio is updated to 0.9.1 including head rev mpg123 lib and hosted on our svn, too overwriting the old fox audio player.
Closing Bug #7194 and #7195, too by adding Total Commander and Click-N-Type Virtual Keyboard
svn path=/trunk/; revision=56956
- Do not leave critical section twice in Win32CsrReleaseConsole. Patch by Hermès Bélusca
See issue #6622 for more details.
svn path=/trunk/; revision=56955
Fix some problems with the lock implementation
- Add a 'generation' to the lock IRPs so we know if we've reprocessed them on any
specific turn when we unlock something else.
- Simplify coalescing of lock regions to just rebuilding the region by going through
the shared lock list and expanding a new region with any overlaps.
- Simplify coalescing new shared locks into larger regions in the same manner.
svn path=/trunk/; revision=56953
- Keep a reference count for FCBs to prevent race conditions when closing multiple handles to the same pipe concurrently
- Acquire the pipe list lock in NpfsQueryDirectory to guard against concurrent deletion of pipes
See issue #7205 for more details.
svn path=/trunk/; revision=56950
- Ensure that account names are not in use when a new alias, group or user is created. Return a proper status code if the account name is alread in use.
- Initialize logon/password related data for new user account objects.
- Add missing prototypes and user account control bits to ntsam.h
svn path=/trunk/; revision=56936
Add support for MSVC ARM
Configuration script works as usual from VS 11 ARM command prompt, host tools is configured for x86 and must be compiled from a VS x86 command prompt.
svn path=/trunk/; revision=56935
- Handle transferring buffer to user mode in WH_CALLWNDPROC(RET) hooks if lParam is a pointer.
This fixes the gallium3d opengl ICD, so newest VMWare opengl Driver should now work.
Please TEST!
svn path=/trunk/; revision=56931
[NTOSKRNL]: Cleanup the page fault handler to help with debugging, fix a few bugs and missing perf counters. There's a lot of cut corners that need some love, will be slowly adding more asserts/sanity code to make sure things are working right.
svn path=/trunk/; revision=56926
Check if the name of a new account (alias, group or user) is used before the account is created. This check is needed because account names must be unique.
svn path=/trunk/; revision=56917
* Leverage the object library option provided by CMake 2.8.8+ which will speed up the build even further.
* Compared strings using STREQUAL.
* These wrapping conditions will go away as soon as we ship the new BE.
svn path=/trunk/; revision=56909
- Fix a regression from r56863. New logic is: the requested data size is sizeof(ULONG), so if the result read is less than that - continue to the next slot. Thanks to SomeGuy for pointing out the problem.
See issue #7147 for more details.
svn path=/trunk/; revision=56907
[NTOSKRNL]: Implement MmMapViewOInSessionSpace, MmUnmapViewInSessionSpace. Win32k needs to use these to we can test them.
svn path=/trunk/; revision=56906
Don't set the ebp register when doing INTs. We only need the output after the int and since the REGS structure is usually not fully initialized before calling Int386, we would load random values. This can cause crashes on VPC.
Thanks to hbelusca fo testing.
svn path=/trunk/; revision=56903
Implement check for SERVICE_WIN32_OWN_PROCESS or SERVICE_WIN32_SHARE_PROCESS type.
Patch by Hermes Belusca.
See issue #7179 for more details.
svn path=/trunk/; revision=56900
- When no file name is passed on the command line, open a file-open-dialog
- Halfplement printing
- Replace Quit button with install button
- Patch by milawynsrealm <spaceseel at gmail got com>
See issue #6803 for more details.
svn path=/trunk/; revision=56898
- Don't modify a dialog template resource directly, instead make a copy of it.
- Should be sent to wine (bug #7189)
[BROWSEUI]
- Remove useless diff file.
svn path=/trunk/; revision=56897
- Fix possible buffer overflow: ExpandEnvironmentStrings wants character count size of a buffer, not byte sized. Spotted by Thomas Faber.
See issue #6053 for more details.
svn path=/trunk/; revision=56888
- Revert r56865, it duplicates same action (expanding the var), spotted by Thomas Faber.
See issue #6053 for more details.
svn path=/trunk/; revision=56887
- Fix uninitialized variable usage warning, based on a patch by Edijs Kolesnikovics.
See issue #6828 for more details.
svn path=/trunk/; revision=56886
- Hermes Belusca: Fix wrong definition of CMHIVE structure (defined only 3 FileHandles when 4 is needed).
See issue #7162 for more details.
svn path=/trunk/; revision=56884
* Improve the way DDKAPI, DDKCDECLAPI and DDKFASTAPI are defined. With that we don't need ReactOS specific defines anymore.
* Already sent upstream.
svn path=/trunk/; revision=56882
- Use COUNT_OF where appropriate. Miscellaneous code cleanup. Patch by Hermès Bélusca
See issue #7182 for more details.
svn path=/trunk/; revision=56876
* Fix Cookie for loader locking generation
Silences "LdrUnlockLoaderLock() called with an invalid cookie!" debug messages
svn path=/trunk/; revision=56874
* Track pixel format with window handle for device contexts
* Fix SetPixelFormat in case pixel format were already set
svn path=/trunk/; revision=56873
- Update Uniata to 41b5. Thanks to Alter for the great driver and Olaf Siejka for preparing the patch, getting our changes upstream and testing the updated version.
See issue #7148 for more details.
svn path=/trunk/; revision=56870
- Implement Import/Export of hive files. Patch by Hermes Belusca (German translation by me)
See issue #7180 for more details.
svn path=/trunk/; revision=56869
- Apply the "Refresh" command to the ListView in addition to the TreeView
- Use COUNT_OF where applicable; miscellaneous readability and consistency fixes
- Space fixes in resource files; French translation fixes
- Patch by Hermes Belusca
See issue #7180 for more details.
svn path=/trunk/; revision=56868
- Edijs Kolesnikovics: Expand environment strings during processing startup items in HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Run.
See issue #6053 for more details.
svn path=/trunk/; revision=56865
- Don't stop enumerating functions of a PCI device if current function returned invalid vendor id. Also add a check for returned data size. This fixes detection of some storage controllers, e.g. Intel ICH8, ICH9, ICH10 chipsets.
Thanks to Alter (UniATA author) for finding the problem and providing solution.
See issue #7147 for more details.
svn path=/trunk/; revision=56863
Correct comments and code error introduced in rev 56844.
Patch by Hermes Belusca.
I used a helper variable to determine whether or not ScmDeleteNamedPipeCriticalSection must be called. Changing the order in which functions are called could cause a deadlock.
See issue #7172 for more details.
svn path=/trunk/; revision=56861
Allocate the ARC_DISK_SIGNATURE structures from the heap instead of putting them into the initial loader block allocation, since the number of disks changes later. Fixes memory corrruption and boot breakage when 3 hdds are connected.
[NTOSKRNL]
Remove a hack that disabled unloading drivers, which didn't work because of memory corruption from freeldr. This works now, too.
See issue #7139 for more details.
svn path=/trunk/; revision=56860
- Make sure freeldr is not compiled with SSE instructions (default for VS 11+)
- Print trap number and instruction stream on bugcheck
- Fix assembly code for ML
svn path=/trunk/; revision=56857
- Implement SampGetObjectAttributeString to retrieve the size of a string, allocate a buffer and retrieve the string from the registry.
- Use SampGetObjectAttributeString to retrieve string attributes in SamrQueryInformationXxx functions.
- Add most missing cases to SamrQueryInformationUser.
- Fix a type mismatch in ntsam.h.
svn path=/trunk/; revision=56850
- Wine doesn't prepend \registry\ to any registry path, which is wrong. Fix that.
- Bring back previous implementation of GetGeoInfo & co.
- Fix GEO_OFFICIALLANGUAGES in the headers.
- Thanks to Kamil Hornicek and Samuel Serapion for finding the problem and creating patches.
See issue #6595 for more details.
svn path=/trunk/; revision=56849
Implement service database locking via RLockServiceDatabase / RUnlockServiceDatabase etc... and use this functionality.
Patch by Hermès Bélusca.
I did not rename the database lock functions because the functions names RLockServiceDatabase and RUnlockServiceDatabase are misleading. They do not lock any database but lock the service start function. The existing functions ScmLockDatabaseExclusive, ScmLockDatabaseShared and ScmUnlockDatabase do protect (lock) the service database (service, group and image lists) form concurrent access. That is also the reason for renaming the SC_LOCK_STRUCT to START_LOCK.
See issue #7131 for more details.
svn path=/trunk/; revision=56844
- Simplify AcquireRemoveRestorePrivilege. Improve clean-up & acquire privilege before unloading hive in CreateUserProfileW. Patch by Hermes Belusca
See issue #7160 for more details.
svn path=/trunk/; revision=56843
- Improve permission acquirement for loading/unloading hives. Patch by Hermes Belusca
See issue #7159 for more details.
svn path=/trunk/; revision=56835
- Acquire the necessary privileges when loading/unloading hives. Patch by Hermes Belusca.
See issue #7159 for more details.
svn path=/trunk/; revision=56825
- Store all fixed size user attributes in the registry value "F".
- Initialize fixed size domain attributes in SampCreateUserAccount and SamrCreateUserInDomain.
- Implement most information classes of SamrQueryInformationUser.
- Disable all informationclasses of SamrSetInformationUser that store fixed size attributes.
svn path=/trunk/; revision=56820
- Implement missing cases of SamrSetInformationDomain.
- Use the fixed domain data to assign new RIDs in SamrCreateAliasInDomain and SamrCreateUserInDomain.
svn path=/trunk/; revision=56819
- Implement all cases of SamrQueryInformationDomain.
- Store all fixed size domain attributes in the registry value "F".
- Initialize all domain attribute in SampCreateDomain.
svn path=/trunk/; revision=56818
- Implement SURFACE_vSetPalette and use it everywhere to set the palette for a surface. Make SURFACE::ppal const, so noone accidentally modifies it without properly handling the references.
svn path=/trunk/; revision=56816
- Use a define for the service name in QueryServiceConfig2 test. Patch by Hermes Belusca. Bug 7145.
- Add LockDatabase test for Lock/UnlockServiceDatabase, QueryServiceLockStatus. Patch by Hermes Belusca. Bug 7146.
svn path=/trunk/; revision=56810
- Add test for QueryServiceConfig2 with SERVICE_CONFIG_DESCRIPTION and SERVICE_CONFIG_FAILURE_ACTIONS. Patch by Hermes Belusca.
- Remove ok_lasterr in favor of ok_err.
See issue #7144 for more details.
svn path=/trunk/; revision=56809
Handle read only devices and report them unsupported.
Forbid the formatting of the system drive.
Patch by Mikael Lyngvig.
See bug 2081 for more details.
svn path=/trunk/; revision=56808
Implement RtlConvertVariantToProperty, RtlConvertPropertyToVariant, PropertyLengthAsVariant
Those are just wrappers around Ole32 functions.
svn path=/trunk/; revision=56795
- Really implement RtlRandomEx and add its values table
- Rename SavedValue to RtlpRandomConstantVector to allow RtlRandom & RtlRandomEx to have two different values tables
- Complete and fix documentation
- Stop using magic values
svn path=/trunk/; revision=56791
- Initialize Winsock before using getaddrinfo (and in general). Fixes test regressions from r56773.
See issue #7135 for more details.
svn path=/trunk/; revision=56789
- Implement SamGetAliasMembership, SamQueryInformationAlias and SamSetInformationAlias.
- Add stub SamLookupNamesInDomain.
[SAMSRV]
- Implement SamrGetAliasMembership and SamrSetInformationAlias.
- Add stub for SamrQueryInformationAlias.
- SamrCreateAliasInDomain and SAM setup code: Set the description attribute for aliases.
svn path=/trunk/; revision=56785
Properly export RtlVolumeDeviceToDosName by using IoVolumeDeviceToDosName. No need to reimplement RtlVolumeDeviceToDosName.
svn path=/trunk/; revision=56781
[XINPUT1_3] - Move header file to PSDK, where it belongs
[MLANG][OBJSEL] - Remove unneeded import library references
[README.WINE] - Mark modules as synced to 1.5.4 if they are
svn path=/trunk/; revision=56766
Code cleaning and removing bugs.
Patch by Hermès Bélusca.
I did not include the changes to EnumServicesStatusW because it does not improve the code but introduces an unnecessary exception.
See issue #7127 for more details.
svn path=/trunk/; revision=56763
- Sync to Wine 1.5.4. Resource files left untouched.
- Fix INTERNET_OPTION_SECURITY_CERTIFICATE_STRUCT if SSL support unavailable (already applied upstream)
See issue #7117 for more details.
svn path=/trunk/; revision=56760
- Better mark ROS-specific changes
- Make wininet_ros.diff sensible
- Update wininet.h
See issue #7117 for more details.
svn path=/trunk/; revision=56758
- Do not manually allocate an incompatible hostent structure in FindEntryInHosts. Use populate_hostent instead. Fixes buffer overflow in name resolution.
See issue #7126 for more details.
svn path=/trunk/; revision=56756
intsafe.h:
- Fix type redefinitions when ntdef.h is included
- Implement (Rtl)LongLongSub and (Rtl)UlongLongMult
- Add some more definitions
- misc fixes
svn path=/trunk/; revision=56750
- Fix wait asserts to account for the Thread->WaitNext case
- At least output a warning in place of the assertion failure in KeWaitForMultipleObjects
See issue #7129 for more details.
svn path=/trunk/; revision=56749
- Disable the assert in KeWaitForMultipleObjects for now, as tcpip isn't straightforward to fix
See issue #7129 for more details.
svn path=/trunk/; revision=56748
Improve a check in RQueryServiceConfig2W and RQueryServiceConfig2A
Patch by Hermès Bélusca.
See issue #7123 for more details.
svn path=/trunk/; revision=56739
Implement SERVICE_CONFIG_FAILURE_ACTIONS case in RChangeServiceConfig2W.
Patch by Hermès Bélusca.
I moved the changes to RChangeServiceConfig2W into a new function (ScmSetFailureActions). I also removed the check for services that run in the services.exe process because ReactOS will not support this kind of services. We should use a separate process or svchost instead.
See issue #7122 for more details.
svn path=/trunk/; revision=56738
* Alter the way we handle the dlldata generation with midl. This works around the warnings we get about multiple rules to generate proxy.dlldata.c.
* Brought to yo by Peter Kummel.
svn path=/trunk/; revision=56731
When a VAD is truncated using VirtualFree, truncate the corresponding MemoryArea
so new allocations will match in both spaces.
svn path=/trunk/; revision=56727
This new patch corrects bugs introduced in the implementation of
SERVICE_CONFIG_FAILURE_ACTIONS case in RQueryServiceConfig2W() and
RQueryServiceConfig2A().
Patch by Hermès Bélusca.
See issue #7101 for more details.
svn path=/trunk/; revision=56725
Removing the redundant function WaitForLSA() and use ScmWaitForLsa() instead.
Patch by Hermès Bélusca.
See issue #7110 for more details.
svn path=/trunk/; revision=56721
Implement SamEnumerateAliasesInDomain and SamrEnumerateAliasesInDomain. SamEnumerateAliasesInDomain does not return the names of the enumerated aliases, most likely due to a bug in rpcrt4.dll.
svn path=/trunk/; revision=56718
- Use IRegistrar mechanism for registration. Fixes urlmon:misc and mshtml:dom crashes
See issue #7113 for more details.
svn path=/trunk/; revision=56717
Fix first argument of the target program so that paths with spaces aren't
reparsed by the c runtime as multiple arguments.
svn path=/trunk/; revision=56716
- Fix attach thread input based on which thread is foreground. Tested with wine Msg test_SetFocus, CursorIcon test_SetCursor and test_ShowCursor, still needs more testing. See bug 7098 and bug 7107, used the test cases and it works with Qemu.
svn path=/trunk/; revision=56714
- Add missing C definition of InlineIsEqualGUID in guiddef.h
- Use portable TYPE_ALIGNMENT instead of __builtin_alignof in mstcpip.h
- Remove definition of DL_EUI48 from netiodef.h, since it's already definied as a forward declaration in mstcpip.h
- Make WS2TCPIP_INLINE extern inline instead of static inline to fix warnings about usage in non static inline functions
svn path=/trunk/; revision=56710
- Implement SamGetMembersInAlias and SamrGetMembersInAlias.
- Add registry helper routines SampRegQueryKeyInfo, SampRegEnumerateValue and SampRegSetValue.
- Remove unused SAM database code.
- Store the name and members key (only for aliases and groups) in the database object.
svn path=/trunk/; revision=56704
- Fast fix attach thread input. Tested with win Msg test_SetFocus, fixed the WM_ACTIVATE issue, still needs more testing. See bug 7098, used the test case and it works.
svn path=/trunk/; revision=56703
- brasilian portugeese translation by Matheus Macabu (bug no. 7079);
[AHK]
- add scripts for including AHK tests into Reactos\Bin;
svn path=/trunk/; revision=56697
Implement SERVICE_CONFIG_FAILURE_ACTIONS case in RQueryServiceConfig2W and RQueryServiceConfig2A.
Patch by Hermès Bélusca.
See issue #7101 for more details.
svn path=/trunk/; revision=56696
- Implement SamSetInformationDomain.DomainNameInformation and SamrSetInformationDomain.DomainNameInformation.
- Set the account domain name for SAM too.
- Remove the old samlib.h file.
svn path=/trunk/; revision=56687
- Implement SamFreeMemory and SamLookupDomainInSamServer.
- Remove unused file debug.h.
[SAMSRV]
- Implement SamrLookupDomainInSamServer.
- Add registry helper functions.
- Store the domain name in a new Name attribute which is used by Sam(r)LookupDomainInSamServer.
svn path=/trunk/; revision=56685
- Add __post_invalid to specstrings.h
- Add missing InterlockedCompareExchangePointerAcquire and InterlockedCompareExchangePointerRelease for x86 to winbase.h
- Add missing MemoryBarrier definition
svn path=/trunk/; revision=56683
- Allow placement of a wait entry in virgin address space prior to mapping a page.
- Add a wait entry in the address space when paging in section view.
- Correct a problem that previously prevented us from evicting or querying pages that
had been protected into PAGE_NOACCESS protection by adding a query for disabled
mappings and handling disabled mappings in a few places (this may be controversial).
svn path=/trunk/; revision=56682
- Get the logon user SID using the new SAM keys and values. This is still a hack.
[SAMLIB]
- Remove all hacks.
[SYSSETUP]
- Remove all administrator account hacks.
svn path=/trunk/; revision=56680
- Implement SamOpenUser and SamSetInformationUser.
- Add SamQueryInformationUser stub.
[SAMSRV]
- Implement SamrOpenUser.
- Add a hack to SamrSetInformationUser that enables us to store a users password (as plain-text) in the registry.
- SamrCreateUserInDomain: Fix the creation of user account key names and start counting user RIDs at 1000.
- Clean-up the SAM registry setup code.
- Assingn SIDs to the BUILTIN and Account domains.
- Create the Administrator and Guest accounts in the SAM setup.
svn path=/trunk/; revision=56679
Move the creation of the random account domain SID from syssetup.dll to lsasrv.dll. This change is required because the account domain SID must be stored in the LSA database before the SAM database initializes. Syssetup.dll created the account domain SID much too late.
svn path=/trunk/; revision=56678
- Don't check for send nonclient paint messages and bump up the paint count. This may spell the end of the PAINTING BUG spam.
svn path=/trunk/; revision=56673
- Implement SamCreateUserInDomain and SamrCreateUserInDomain.
- SamOpenDomain: Use the correct object types when trying to open a domain object.
svn path=/trunk/; revision=56672
Add Names sub keys to the Alias, Groups and Users keys of the Account an Builtin domains. These will later contain the 'Name to SID' entries that will simplify lookup by name operations.
svn path=/trunk/; revision=56670
- Return the actual number of bytes copied for configuration descriptor requests
- Fix MSVC warnings and NULL vs 0 vs FALSE issues
svn path=/trunk/; revision=56667
- Add SxS for classes, still not plugged in for a year now.
- Need more information on global headers to support class contexts. ATM the headers are local, for noting what is needed.
svn path=/trunk/; revision=56652
[KERNEL32]: Simplify QueueWorkItem since the trampoline is in Rtl.
[KERNEL32]: Add SxS support to QueueUserApc.
[KERNEL32]: Add some extra sanity checks/assertions in certain places.
svn path=/trunk/; revision=56651
- Use RtlAnsiStringToUnicodeString instead of mbstowcs to correctly handle manifests that aren't null-terminated
See issue #6743 for more details.
svn path=/trunk/; revision=56649
- Use Wine debug messages in samlib.dll.
- Move SAM initialization code from samlib.dll to samsrv.dll.
- Lsass.exe initializes SAM instead of syssetup.dll.
svn path=/trunk/; revision=56648
- Convert to Wine debug messages.
- Add server side stubs of the SAM RPC interface. The RPC server is not implemented yet.
svn path=/trunk/; revision=56645
- Swap GetFullPathName success/failure cases in BasePushProcessParameters. Fixes kernel32:GetModuleFileName test.
See issue #6786 for more details.
svn path=/trunk/; revision=56643
- Partial sync port Wine 1.5.4 for system.c.
- Researched branches/GSoC_2011/ThemesSupport and current changes before sync.
svn path=/trunk/; revision=56642
- Add new ntlsa.h file to the PSDK.
- LsarAddPrivilegesToAccount: Implement the ability to add new privileges to an existing privilege set.
svn path=/trunk/; revision=56594
- Fix some sickening formatting disasters
- Allocate the unicode string buffers from paged pool, like everything else in the NDIS config API
svn path=/trunk/; revision=56590
- Handle unknown color types in TranslateCOLORREF
- properly translate the color back to RGB in NtGdiSetPixel
Fixes a few hundred thousand gdi32 winetests (dib) :)
svn path=/trunk/; revision=56582
- In DC_vSetOwner, do not take ownership of the current dc brush and pen, instead dereference them and select default brush and pen. Fixes bug #7070
- Fix debug logging in GDIOBJ_vDereferenceObject
- create debug log event in GDIOBJ_vSetObjectOwner
svn path=/trunk/; revision=56579
Do not add the "SeUnsolicitedInputPrivilege" privilege to the administrators privilege set because it has been superseded by the "SeMachineAccountPrivilege" privilege and the later has already been added to the privilege set.
svn path=/trunk/; revision=56578
- Fix bug 6796, use wine code to clear bits before checking to minimize or maximize.
- Fix all the wine Win test_window_styles and todo tests.
svn path=/trunk/; revision=56570
* Sync to Wine 1.5.4. I excluded loader and virtual tests from the sync until bug #7071 is fixed.
See issue #7070 for more details.
svn path=/trunk/; revision=56567
- Patch by Dmitry Timoshkov : SetParent() should use ShowWindow() to make a reparented window visible and move a window to new position.
- Note: SetWindowPos should be correct, http://www.winehq.org/pipermail/wine-cvs/2012-April/086267.html
svn path=/trunk/; revision=56560
- Fix the remaining wine Win tests for FindWindow/Ex/A/W. Check the buffer not the length, buffer could be pointing to a null. Enable the message window handling. Use wine code for FindWindowExA.
svn path=/trunk/; revision=56557
Add a 4th instance of fusion.dll back into system32.
(doesnt match any actual windows system but needed for wine's msi.)
svn path=/trunk/; revision=56556
- Make EngSecureMem probe the buffer, so we have at least a minimum functionality, even though it's not safe
- Implement EngSecureMemForRead
- Use IntEngBitBlt from IntEngStretchBlt, when source and dest size are equal
svn path=/trunk/; revision=56553
- Make CreateDIBPalette handle BITMAPCOREINFO (we need to handle this, since win32k can load bitmap files, that can contain these headers)
- Remove obsolete IntSetDIBColorTable, IntGetDIBColorTable
svn path=/trunk/; revision=56548
- Alloca to use GDIOBJ_vReferenceObjectByPointer with exclusively locked objects
- Make sure the global mono palette actually has 2 entries
- Simplify allocation of default palette
- Implement GreGetSetColorTable, replacing IntSetDIBColorTable / IntGetDIBColorTable
- Make sure that memory possibly copied to user mode is zeroed.
svn path=/trunk/; revision=56546
Fix a couple of omissions from my PAGEOP removal;
Make sure to place a wait entry in the address space when faulting
in bss pages.
Restore the original entry in the final cases of section swap out,
because the entry had been replaced with a wait and nothing else
restores it.
svn path=/trunk/; revision=56540
- Fix crash when sending activate application message and check if thread is in cleanup. Use kernel functions for thread data types.
svn path=/trunk/; revision=56538
- Implement LsaEnumeratePrivilegesOfAccount and LsarEnumeratePrivilegesAccount.
- Implement parts of LsarAddPrivilegesToAccount.
svn path=/trunk/; revision=56527
Do not ASSERT that the object is not exclusively locked in GDIOBJ_vDereferenceObject. The idea behind this was to easily detect cases where someone would accidentally dereference an object, instead of unlocking it. But this function is used from other functions, that can definately deal with exclusively locked objects. Changing this would leat to code duplication / more complex code.
Forgetting to unlock an object will still be detected by the kernel, when returning to user mode, since APC would still be disabled.
Should fix failed assertion when running dx9 setup.
svn path=/trunk/; revision=56525
- Create default hatch brush bitmaps on win32k init
- After creating a PDEV fill the fields in the ahsurf array that are not filled by the driver with these bitmaps
- don't create a new bitmap when a hatch brush is created, instead only store the style and use the related bitmap from the PDEV when realizing the brush.
- Fix the palette of DIB brushes, when realizing the brush
- Don't leak the bitmaps for DIB brushes in BRUSH_Cleanup
svn path=/trunk/; revision=56523
Implement CreateDIBPalette(), replacing BuildDIBPalette.
It creates a palette without a handle and handles DIB_PAL_COLORS as well as DIB_RGB_COLORS. Additionally it now handles DIB_PAL_BRUSHHACK, which is used for DIB brushes, when DIB_PAL_COLORS is passed to CreateDIBPatternBrush(). The palette is not created directly, but instead the indices into the DC palette are put into the palette and the real palette is created, when the brush is realized. The latter is not yet handled.
svn path=/trunk/; revision=56518
[NTOS]: Implement Case C of NtFreeVirtualMemory, which is sometimes seen in some heap logs. The hard part is figuring out the right amount of committed/decommitted pages. Only supports 2-level paging for now as the algorithm is already messy enough.
svn path=/trunk/; revision=56515
Rename PALETTE_AllocPalette2 to PALETTE_AllocPalette, allocate PALETTE and color array in one allocation, improve code
svn path=/trunk/; revision=56514
- Do not multiply define WINVER and friends
- Add missing _WIN32_WINNT define in rpcrt4_winetest. Already sent to Wine(TM)
svn path=/trunk/; revision=56513
- Fix warnings - there is no DischargePolicy[4]
- Disable tests that fail on Windows 2003 (576 failures?!)
- Add missing file header
svn path=/trunk/; revision=56506
- Add tests for CreateDIBPatternBrush(Pt)
- Add some helper code to initialize a dibsection and a palette, which can be reused by other tests
- Add tests for DIB brush in GetObject
svn path=/trunk/; revision=56498
- Add cjMaxBits parameter to GreCreateDIBitmapInternal
- Rename GDIBRUSH_* constants to BR_*, as they are named in gdikdx
svn path=/trunk/; revision=56496
- Fix SetCurrentDirectoryA to return success when setting the current directory again
See issue #6874 for more details.
svn path=/trunk/; revision=56490
Account for wait entries delaying a view attribute change and interacting
with the machinery in CoW copying code, specifically making CoW insert and
revoke a wait while copying the page, and make the CoW copy function take
both pages as arguments rather than relying on the address space.
Also alter the MM_WAIT_ENTRY value a bit to take into account an assert
that it must have bit 0x800 set.
svn path=/trunk/; revision=56488
- Add the linking exception text to the official ReactOS licensing text. Previously, the exception text was only available at the ReactOS website with no references from the source code.
svn path=/trunk/; revision=56479
A pointer is not a handle. A handle is not a pointer. At least in most cases. Defining STRICT in win32k revealed horrible things...
svn path=/trunk/; revision=56478
- Fix a palette leak in DIB_CreateDIBSection
- Remove PALETTE_AllocPalette and PALETTE_AllocPaletteIndexedRGB, use PALETTE_AllocPalWithHandle instead
svn path=/trunk/; revision=56476
* Implement Ctrl+C support on MessageBox. Patch by Guido Pola (prodito {at} live [dot] com).
See issue #5281 for more details.
svn path=/trunk/; revision=56475
Modify DIB_MapPaletteColors, first allocating a palette without initializing the colors, then setting up the colors. This wway we don't need to allocate an intermediate buffer.
svn path=/trunk/; revision=56474
- Implement GreCreatePaletteInternal and make NtGdiCreatePaletteInternal safe regarding user mode memory access.
- Allow allocating an indexed palette without initializing the colors
- Implement PALETTE_AllocPalWithHandle
- remove pointless Self member in PALETTE structure
- cleanup palette.h a bit
svn path=/trunk/; revision=56473
- Import isinf and isnan implementations from libwine_port and adjust port.h and config.h to support them
- Remove isinf/isnan hacks from jscript and wined3d build files
- Add missing port.h include to jscript/array.c (sent and applied upstream)
See issue #7027 for more details.
svn path=/trunk/; revision=56470
Rewrite SURFACE_AllocSurface(), which now does the part of the former SURFACE_bSetBitmapBits() as well. This is to allocate the bits for a bitmap directly with the SURFACE object in one allocation. Also don't use kernel mode sections anymore by default, but paged pool memory.
svn path=/trunk/; revision=56460
Don't calll GDIOBJ_vDereferenceObject from GDIOBJ_vUnlockObject, instead manually decrement the reference count. This allows us to ASSERT that the former function is never called with an exclusive lock held.
svn path=/trunk/; revision=56458
Never ever trust the wine file layout.
wine can load a dll when there is no file using builtins, while normal windows dont.
This fixes fusion beeing installed in the wrong places.
Loading the 2nd and 3rd copy of fusion fails atm.
svn path=/trunk/; revision=56453
Autogenerate oldnames for MSVC as well.
Currently on gcc builds we use a special def file syntax and use dlltool to create the lib, while on MSVC builds we use an asm file with aliases.
svn path=/trunk/; revision=56448
Fix a serious bug in PSEH that could lead to stack corruption and was causing CSRSS to crash, when large amounts of text were output on the console.
Background: PSEH used __builtin_alloca to allocate an SEH registration frame on the stack on demand, ie only for the first try level. But there are some nasty things with __builtin_alloca: First it DOES NOT - as one might think - free the allocated memory, once the allocation "goes out of scope", like with local variables, but only on function exit. Therefore it cannot normally be used inside a loop. The trick that PSEH used to "fix" this problem, was to save the stack pointer and reset it back at the end. This is quite problematic, since the rest of the code might assume that the stack pointer is still where it was left off after the allocation. The other thing is that __builtin_alloca() can allocate the memory whenever it likes to. It can allocate everything on function entry or not allocate anything at all, when other stack variables that went out of scope have left enough space to be reused. In csrss it now happened that the allocation was done before the stack pointer was saved, so the memory could not be freed by restoring the old stack pointer value. That lead to slowly eating up the stack since the code was inside a loop.
The allocation is now replaced with a variable sized array. The variable stays in scope until the _SEH2_END and will be automaticall cleaned up by the compiler. This also makes saving and restoring the stack pointer obsolete.
Reliability++
svn path=/trunk/; revision=56442
Remove PAGEOPs and use the argument to pass relevant information where needed,
including generally a section page table entry or a PFN_NUMBER.
In its place, the code looks for an MM_WAIT_ENTRY in the appropriate place and
waits, returning STATUS_MM_RESTART_OPERATION. Rather than copying the pagein
and CoW operations in the PAGEOP contention case, we just punt back and restart
the operation, resulting in simpler code.
svn path=/trunk/; revision=56441
When a DC has the default palette selected, use the color value from PALETTERGB() directly instead of looking it up in the dc palette (just as the code was before). Fixes skipped bitmap winetests
svn path=/trunk/; revision=56440
- In NtGdiSetPixel, return the real RGB value, which is the target format color translated back to RGB, not the desired RGB value. Fixes a few bitmap winetest.
- Handle a too large index in PALETTE_ulGetRGBColorFromIndex
svn path=/trunk/; revision=56439
- Do not null terminate buffer before initializing its length in RtlDosSearchPath_Ustr. Use unicode string functions made for this purpose instead.
See issue #7010 for more details.
svn path=/trunk/; revision=56438
- Add a small RtlException test, mainly to check that a stack overflow really throws STATUS_STACK_OVERFLOW, not STATUS_ACCESS_VIOLATION.
svn path=/trunk/; revision=56434
- add missing DBG_DECREASE_LOCK_COUNT() when deleting an object that was exclusively locked. Fixes strange hang in comctl32_winetest.
The question is: why does changing a variable, which is never checked cause such trouble?
- Don't pass the DC's clip object to IntEngCopyBits, when querying a pixel
- make acExclusiveLockCount[] 0x20 bytes long, just to be really sure, that (x & 0x1F) does never overflow it.
svn path=/trunk/; revision=56433
- Do not rely on undefined behavior to get values easily accessible as constants.
- Quick build fix. Will be sent to Wine, possibly modified.
svn path=/trunk/; revision=56432
- Implement TranslateCOLORREF, based on IntHandleSpecialColorType, but now returning both the translated color and the resulting RGB color, correctly handling DIBINDEX, which will use the given value without translation.
- Rewrite NtGdiSetPixel using IntPatBlt
- Rewrite NtGdiGetPixel using IntEngCopyBits
- Fix EXLATEOBJ_iXlateTable to return 0, when the palette index is too big, instead of wrapping around
- Remove old debugcode
svn path=/trunk/; revision=56429
Pass EBRUSHOBJ to IntPatBlt instead of the BRUSH. This way we can use the DC's eboFill, instead of initializing a new EBRUSHOBJ.
svn path=/trunk/; revision=56427
- Accept NULL Buffer/Size in RtlGetFullPathName_Ustr
- Fix NULL dereference in RtlGetFullPathName_UstrEx if no StaticString was given
- Various other corrections to path functions. 17 test failures fixed overall.
svn path=/trunk/; revision=56426
- Make XFORMOBJ_iSetXform fail, when the XFORM is invalid (eM11 or eM22 are 0)
- Handle error in GreModifyWorldTransform
svn path=/trunk/; revision=56422
- Add a test for RtlDoesFileExists_U (and its three friends, if addresses are provided)
- Various small path test improvements
svn path=/trunk/; revision=56416
- Add a test for RtlGetFullPathName_Ustr (requires the function address to be known)
- Various improvements to the other path tests
svn path=/trunk/; revision=56413
- Add test for RtlGetLongestNtPathLength
- Add test for RtlDetermineDosPathNameType_U (and RtlDetermineDosPathNameType_Ustr, if address is known)
svn path=/trunk/; revision=56411
- Add missing mmtypes.h include in mmfuncs.h
- Remove RtlDetermineDosPathNameType_Ustr from rtlfuncs.h, move it up in path.c
- Add RtlGetLongestNtPathLength to rtlfuncs.h
svn path=/trunk/; revision=56410
- Fix a bug in the region code that could cause allocating 0 bytes
- Remove SetLastError()
- "flatten" IntGdiCombineRgn making it more readable
svn path=/trunk/; revision=56409
- Add forgotten storage of the LUN in the PDO extension which not only broke units beyond LUN 0 but also caused a BSOD due to reporting duplicate devices to the PnP manager
- Thanks to tower for reporting
svn path=/trunk/; revision=56406
- Desktop: Added code for server side switch over and some notes. Did not include desktopbg.c.
- Focus: Fixes wine Win tests for SetParent, Active, Focus and Foreground. Leaving the wine todos. Msg tests improved. Pop up menus are still broken see bug 6751. The tests reflect these pop up menu issues.
- WinPos: (WIP) Fixed MapWindowPoints. Arrange icons is still broken. SetWindowPos sets the foreground when it should.
- Implemented AllowSetForegroundWindow and LockSetForegroundWindow.
- Commit to reset base lines for RegTest ComCtl32 and related bugs.
- Coding credits and complements go out to the Wine team.
svn path=/trunk/; revision=56396
- Fix calculation of the brush origin. The coordinates passed to EngBitBlt "defines which pixel in the mask corresponds to the upper left corner of the destination rectangle." Our code was using it as corresponding to the surface origin.
The fix is currently only used when the new dib code is compiled. The old dib code is broken and expects the broken behaviour
svn path=/trunk/; revision=56392
- Troubleshooting bug 5630, moved DestroyProcessClasses from process to thread since process is called first. This way, it is assured the class destruction is on queue, but not before thread death.
- Added a global pointer to be used in a later commit.
- Warning: this does not fix bug 5630.
svn path=/trunk/; revision=56386
* Implement LoadSettings() and SaveSettings(). Patch by Edijs Kolesnikovics with some minor changes by me.
See issue #6925 for more details.
svn path=/trunk/; revision=56382
Fix a bug in MiAllocatePoolPages, that made the function succeed, when MAX_ULONG / -1 / 0xFFFFFFFF bytes were requested. The value overflowed into 0 and 0 pages were returned. When freeing this block, it could either free the next following large allocation or ASSERT when the end of the pool was reached without finding the end of the allocation.
Fixes FoxitReader 4.2/4.3
svn path=/trunk/; revision=56366
Mark _chkstk as extern to avoid duplication with msvcrtex library (using alloca will cause _alloca_probe to be linked, which aliases _chkstk)
svn path=/trunk/; revision=56361
- Implement saving / restoring debug registers on traps
- Replace the loop in KeContextToTrapFrame with something less ridiculous
- fixes a number of ntdd exception winetests
svn path=/trunk/; revision=56357
Expand the environment variables when running startup programs
Patch by Edijs Kolesnikovics, slightly modified by me
See issue #6953 for more details.
svn path=/trunk/; revision=56353
Add quotes to autocompleted names, when certain characters are present, not only spaces. Not sure if that's really all, but should be the most common.
svn path=/trunk/; revision=56350
Fix several bugs in the copy command:
- "x:" is not a valid source path (see bug #5709)
- when appending files using "+", cmd must distinguish between + as operator and + as part of the source file, when being put in "". For that reason the tokenizer was modified to make + a seperate token, which is replaced with | when creating the string of multiple files (since + is a valid file character)
- ? was not correctly handled when passed in the output file name
- factor out the code to create the file name from wildcards and make it readable (no, p, q, r are NOT reasonable variable names!)
- Move code out of the loop that doesn't belong there
- Make sure the file names are printed when multiple files are copied or appended
- write the count of written files (which is 1 when appending), not source files after the copy process is done
- Remove an excessive newline when writing strings with ConPuts()
- Improve readability a bit
svn path=/trunk/; revision=56346
Remove trailing backslash in shellink working dir
Patch by Edijs Kolesnikovics (terminedijs at yahoo dot com)
See issue #7000 for more details.
svn path=/trunk/; revision=56344
Fix path reference leaks in PATH_add_outline
Should fix failed assertion when closing google earth.
thanks to r3ddr4g0n for providing the neccessary debug info.
svn path=/trunk/; revision=56342
- Make the handle to the shutdown event a global handle and set it when the service manager is being shut down.
- Close the start event properly.
svn path=/trunk/; revision=56337
Implement RtlCreateBootStatusDataFile, RtlGetSetBootStatusData, RtlLockBootStatusData and RtlUnlockBootStatusData.
[SYSSETUP]
Call RtlCreateBootStatusDataFile as part of the install process.
svn path=/trunk/; revision=56332
* CMake automatically handles def files when they're added to the source list, so we don't need to mark it as an external object here.
svn path=/trunk/; revision=56321
- Don't include NDK from winnt.h, instead duplicate NtCurrentTeb inline definition between psfuncs.h and winnt.h as it used to be
- remove duplicated _GENERAL_LOOKASIDE_POOL
- Add missing NTKERNELAPI to ObDereferenceObjectDeferDelete
svn path=/trunk/; revision=56318
* Put ntoskrnl and ntdll in the same folder, because they both start with nt.
* Place hal next to acpi, they both deal with hardware stuff.
* Move mountmgr next to usb drivers.
* Put the rtl next to the crt, and share as much as possible between the two.
* I'm just kidding, you know, April's fool and all ;)
Here's the real deal:
[WIN32SS]
* And finally, integrate win32k itself into the new file layout. Now the subsystem modules are located close to each other (like gdi32 and ntgdi, or user32 and ntuser).
* Thanks go to the subsystem team for coming up with this nice layout, hopefully this will scale to the whole codebase layout soon.
* Special thanks to Smiley for coming up with this cool idea :)
svn path=/trunk/; revision=56311
* Initialize the subsystem restructure. Start by bringing-in gdi32 and user32. Brought to you by the awesome Subsystem Team.
svn path=/trunk/; revision=56305
- If neccessary unlock the working set in MiMakeSystemAddressValid before calling MmAccessFault, fixes a failed ASSERT, when coming from NtFreeVirtualMemory
- Remove duplicated ASSERT
svn path=/trunk/; revision=56300
- turkish translation of dxdiag by Arda Tanrýkulu (bug no. 6986);
- italian translation of browseui by Paolo Devoti (bug no. 6980);
svn path=/trunk/; revision=56298
* Make use of /client none and /server none to tell midl not to generate them.
* Add dummy proxy file generation in generate_idl_iids().
svn path=/trunk/; revision=56288
* Recognize the extra client/server files in add_rpc_files() that Mr. midl generates regardless of the passed flags, and mark them as dummy files so that they don't break the msvc parallel build.
svn path=/trunk/; revision=56286
- Don't rely on the current lookahead size for loopback packets. Instead, indicate the entire packet at once.
- The current lookahead size doesn't matter when indicating full packets. The packets are indicated in their entirety regardless of the lookahead size.
- The Parallels Tools NIC driver now works on ROS. Dedicated to Alex Ionescu.
svn path=/trunk/; revision=56285
- The legacy ROS Mm uses structures known as page ops to track operations on a page such as page out, page in, and access fault. The idea is that each operation is forced to wait until the page has completed all other pending operations to start its work. The problem was that the page op's completion event was a NotificationEvent instead of a SynchronizationEvent. This caused all operations to proceed at the same time if they were waiting on a single page op to begin. Now that is fixed and page ops proceed one after another as intended. This bug has been around since r9077.
- When waiting for sections to be unmapped or destroyed, the Mm waits for pending page operations to complete. The problem is that MmUnmapViewOfSection had a critical bug in which it forgot to dereference the page op it just retrieved. This caused zombie page ops to be stuck to that particular address if there were any pending operations at the time of the MmUnmapViewOfSection call. As a result, section destruction to bug check due to the hung page op after waiting 10 seconds for the operation to complete. This bug has been around since r18849.
- Due to the combined effects of the above bugs, sometimes unmapping or freeing a section would hang the system or bug check the system (remember the "Failed to wait for page op" messages?). This was evident in smiley_'s theme work when many applications calling FreeLibrary at the same time would trigger this bug. There are likely many more cases that triggered this series of events which either could never be replicated or simply could not be explained.
svn path=/trunk/; revision=56284
Attempt to fix a concurrency issue with midl. Regarding to the MSVC builder output, midl failed when compiling wine/itss.h due to a concurrent access to itss_i.c. Although the command to generate itss.h doesn't seem to geenrate itss_i.c (at least not on my wdk buld), I added a switch to rename that file.
svn path=/trunk/; revision=56280
"while (TRUE);" is probably the worst way of handling critical errors / unhandled failure pathes! Replace that with ASSERT(FALSE);
svn path=/trunk/; revision=56272
- Only initialize the nonpged pool after the pfn database was initialized
- "Fix" IRQL for the initialization of non paged pool
svn path=/trunk/; revision=56271
- Implement HwIdle() function to put cpu in idle mode, when waiting for keyboard input.
- Patch by Carlo Bramini (carlo dot bramix at libero.it)
See issue #6453 for more details.
svn path=/trunk/; revision=56270
Write a lot of general prose about the operation of the Mm parts of NewCC.
Dedicate to timo and chongo.
No code changes.
svn path=/trunk/; revision=56267
- romanian rapps translation update (including INF update) by Stefan Fulea (bug no. 6878);
- italian translation update by Paolo Devoti (bug no. 6980);
svn path=/trunk/; revision=56266
- ObReferenceObject() does NOT return an NTSTATUS. It returns the new reference count. Remove pointless NT_SUCCESS check
- Enable interrupts in amd54 page fault handler before calling MmAccessFault
- Add missing MmDecommittedPte for amd64
svn path=/trunk/; revision=56265
Mmake regedit to save/load settings for: window placement, listview columns size, last opened key, status bar, splitter.
Patch by Grégori Macário Harbs <mysoft64bits at gmail dot com> and Edijs Kolesnikovics <terminedijs at yahoo dot com>
See issue #6920 for more details.
svn path=/trunk/; revision=56256
Handle Ctrl-A in address bar.
Patch by Edijs Kolesnikovics (terminedijs at yahoo dot com)
See issue #5936 for more details.
svn path=/trunk/; revision=56255
Remove pointless ASSERTs, instead set the balance of the new node to balanced, before inserting it.
Dedicated to Alex.
svn path=/trunk/; revision=56253
- Refactor some multiply used overly complex expressions into human readable variable names
- Output some useful debuginfo when an import could bot be resolved
svn path=/trunk/; revision=56247
- Fix implementations of AcpiOsWaitSemaphore and AcpiOsAcquireMutex to obey the caller's demands to not block if requested
svn path=/trunk/; revision=56245
- Fix a stupid string comparison mistake that lead to false positives in the duplicate device detection (1 and 10 detected as conflict)
svn path=/trunk/; revision=56243
- Add *PNP0A08
[ACPI]
- Handle the PNP0A08 in a couple of missed cases
- Finally, PCI should work on systems that use the new PNP0A08 ID for identifying a PCI Express root bus
svn path=/trunk/; revision=56242
- Set DN_DISABLEABLE if the device can be disabled
[NEWDEV]
- Remove a hack needed because DN_DISABLEABLE was never set
svn path=/trunk/; revision=56241
- Add PNP0A08 as an alias for the PCI bus (more commonly known as PNP0A03)
- Should fix numerous PCI regressions on various machines since switching to ACPI (and the further regression of breaking boot since VBE is now PnP)
svn path=/trunk/; revision=56238
- Rewrite coordinate transformation code to use XFORMOBJ apis instead of using floating point in kernel mode. As a small present fix 14 gdi32_winetests (5 mapping, 9 bitmap)
I disabled some RtoL code, since it didn't work anyway and caused more bugs than it fixed.
svn path=/trunk/; revision=56236
- It appears ros wasn't ready for properly handling page faults with interrupts disabled, disable bugcheck and warn and dump stack instead for now.
- Make KeRosDumpStackFrameArray and KdbSymPrintAddress safe to use at elavated IRQL -- don't use Unicode formats for DbgPrint at possible elavated IRQL/interrupts disabled as this may generate a page fault. Safely convert to ANSI instead before printing out the address.
svn path=/trunk/; revision=56235
- Fix a crazy bug in KiTrap0EHandler, it didn't enable interrupts unless it trapped when interrupts were already disabled (during a page fault during page fault handling, for example). This seems to have worked because the old non-newcc version of MiReadPage appears to rely on a page fault to bring the paged out page in. Thanks Timo.
svn path=/trunk/; revision=56234
[NTOS]: Expand system space view buckets when they are running low.
[NTOS]: Support SEC_BASED section creates and mappings, implement based VAD parsing.
[NTOS]: Support section mappings at a fixed base address and check for conflicts.
[NTOS]: Define 8 prioritized standyby lists and initialize them. Also define the modified page list.
[NTOS]: Support mapping with SEC_COMMIT less than the entire size of the section.
[NTOS]: Detect and assert if ARM3 sections are attempted to be unmapped, since this isn't supported yet.
[NTOS]: Clean up some DPRINTs and clarify ARM3 ASSERTs vs. Windows ASSERTs.
svn path=/trunk/; revision=56232
- Implement proper use of alternate resource requirement lists
- Implement the case to set DN_NO_SHOW_IN_DM
- Implement reporting more problem codes: CM_PROB_NEED_RESTART, CM_PROB_FAILED_DRIVER_ENTRY, CM_PROB_FAILED_DRIVER_ENTRY, CM_PROB_DRIVER_FAILED_LOAD, CM_PROB_WILL_BE_REMOVED, CM_PROB_HELD_FOR_EJECT, CM_PROB_TRANSLATION_FAILED, and CM_PROB_NORMAL_CONFLICT
svn path=/trunk/; revision=56231
- Fix running RtlGetFullPathName_UstrEx test from drive root
- Add a test for RtlGetFullPathName_U based on the same test cases
svn path=/trunk/; revision=56230
- Fix right-to-left support the new EngBitBlt code
- Remove an ASSERT that we don't support
- Fix clipping in IntEngBitBlt by bailing out when the target rect got empty
- Delete obsolete file
You can use the code now, but there is a bug in the clipping code somewhere, sometimes causing the taskbar to be overwritten
svn path=/trunk/; revision=56224
- Add support for pattern brushes and bottom-to-top blt in new EngBitblt
- implement a new much simpler EngCopyBits
- improve clip enumeration code
The code now generally works very well now, only has a few bugs left
svn path=/trunk/; revision=56219
- Implement support for bottom up bitblt
- Add solid pattern support in generic BitBlt function
- Make sure right-to-left is only used in the appropriate functions
- Fix 1bpp _NextPixel() macro
svn path=/trunk/; revision=56218
- Do not overflow the uncommitted range descriptor segment. Really fixes notepad.
- Free the correct region in failure case
- Some comment fixes
See issue #6966 for more details.
svn path=/trunk/; revision=56217
- Add a trivial XLATEOBJ as a global variable.
- Make sure the XLATEOBJ is not NULL, when calling the diblib code
- Remove the IntEngMaskBlt stub, its a very special function for font rendering, keep the old one
- Add more driver debug assertions
- Remove obsolete definition
svn path=/trunk/; revision=56216
- Implement spacial even more optimized versions of SRCCOPY on equal surfaces for 8,16,24 and 32bpp.
- Add the right-to-left versions to the function tables
- Add _CALCSHIFT macro(s) to calculate the shift in the dib functions, instead of precalculating it in EngBitBlt. This costs us a few bytes per function (yes, with so many functions, every byte counts!) but since it's only for 1 and 4 bpp and improves the code by keeping DIB specific code out of the Eng function, it's reasonable to do so.
- Add optional optimization pragmas
svn path=/trunk/; revision=56212
- Apply fixes from Wine 1.4. Fixes invalid free in notepad and other edit control users
See issue #6966 for more details.
svn path=/trunk/; revision=56210
- Once again require a reboot for driver replacement since this seems to cause new issues with devices being enumerated multiple times on vmware
svn path=/trunk/; revision=56206
[NTOSKRNL]
- Bugcheck if a driver reports a PDO with a non-unique instance ID
[ACPI]
- Check that we're not reporting the same device multiple times
svn path=/trunk/; revision=56204
- Create PnpRootRegisterDevice which is used to register a given PDO with the root device so it won't report it twice
- Listing devices by connection works with PCI HAL now but it seems that ACPI is detecting multiple ACPI\PNP0C0F\0 instances here in vbox which is causing the same infinite loop
svn path=/trunk/; revision=56200
- Device manager now reports problem codes, shows unknown devices, and displays non-PnP drivers like Windows
- Inspired by Eric's recent work
[DEVMGMT]
- Finally (!!!) add support for showing devices with no drivers installed yet
- Expand the class tree if one of the devices has a problem
[INF]
- Add legcydrv.inf for installing the LegacyDriver class
[NTOSKRNL]
- Fix null termination issues and enable the legacy driver registry code
- Add a service description in legacy device entries
- Return valid flags for a device status query
- Store problem codes for several common device node failure states
svn path=/trunk/; revision=56199
Implement the 'View/Devices by Connection' feature. It runs very well on windows XP but fails on ReactOS. Needs to be investigated.
svn path=/trunk/; revision=56197
- As a side effect to 45140 one of the "non-used debug features", breaking in with WinDbg, would no longer work. Add this back, as well as the DPC timeout debug check and support for skipping ticks.
svn path=/trunk/; revision=56194
- Forgot this dereference
- Unloading works now, but there are many bugs in the device stacks that prevent it from occurring
- Usbhub will unload properly when a hub is removed for a driver update, but usbstor won't unload when all usb storage devices have been removed
- Work needs to be done to fix issues like this
svn path=/trunk/; revision=56185
- Reenable some dereferences of the driver object
- Fix return values in NtLoadDriver
- Split unloading into code for legacy drivers and non-legacy drivers
svn path=/trunk/; revision=56184
- Remove an extra deference to the device object that happened inside the IopDeleteDevice function (called by Ob when the reference count is 0)
svn path=/trunk/; revision=56183
Add pSetupGuidFromString(), pSetupIsGuidNull() and pSetupStringFromGuid() to the PSDK header setupapi.h and remove a local declaration.
svn path=/trunk/; revision=56182
Add InstallRoot key.
It is reg_sz and contains the full path to the installation directory.
Checked on Windows & Wine.
svn path=/trunk/; revision=56178
- Fix entrypoint and add startup code to fix registration of mlang classes. Fixes crashes and failures in inetcomm:mimeintl winetest and adds back many tests in mlang winetest
svn path=/trunk/; revision=56156
FsRtlIsDbcsInExpression/FsRtlIsNameInExpression: in case there are contigous stars in the expression, skip all the stars up to the last one and only consider the last one.
This fixes the failing tests.
svn path=/trunk/; revision=56143
- Add PCI-PCI bridges to the critical device database to fix discovery of critical devices that are not attached directly to the root bus
- See bug #6958 for details
svn path=/trunk/; revision=56140
- Include the Lautus visual style by Pisarz (as a blob for now), and enable it by default
svn path=/branches/ros-branch-0_3_14-clt2012/; revision=56136
- When installing dll copy manifest to winsxs\manifests directory as comctl32 before sync did. Fixes Firefox 10 regression.
See issue #6910 for more details.
svn path=/trunk/; revision=56132
- Fix broken VIDEO_PORT_GET_DEVICE_EXTENSION macro
- Add support for child devices (monitors only for now)
- Monitors now show up in device manager ("Plug and Play Monitor" shows up if EDID data is reported, otherwise "Default Monitor" is displayed)
svn path=/trunk/; revision=56128
- It appears that the driver unloading code is more profoundly broken that I had previously thought. I ran into issues testing with videoprt which would call IoCreateDevice and IoDeleteDevice during enumeration of child devices. The issue arose when the IoDeleteDevice call unloaded the video driver which was currently initializing. This caused video initialization to fail and the system to shutdown.
- Disable this code completely for now until the proper algorithm for determining when a driver should unload is found
svn path=/trunk/; revision=56125
32-Bit stub installer for 16-Bit Microsoft installers
TODO: -load this installer instead of the original 16bit Microsoft installer
-improve error handling and string allocation
svn path=/trunk/; revision=56110
* Make use of the cmake rc handling. As a result we don't need set_rc_compiler() anymore, among other benefits.
* There's one minor issue mentioned as a FIXME, we'll get that sorted out as soon as the bug report we filed upstream gets resolved.
* Set set_rc_compiler() to be a dummy, to be removed later.
[IMM32]
* Properly set the compiler flag.
svn path=/trunk/; revision=56105
- Adjust the CD root readme.txt for CLT
- Add CD options to welcome.exe
- Taken from previous years, see r51078, r46065
svn path=/branches/ros-branch-0_3_14-clt2012/; revision=56100
Handle cases where multiple ranges overlap a new lock, including either exclusive or shared
ranges. We expand a shared range when an overlap occurs and add another shared range to
the shared ranges list. Also make sure to complete an IRP along every non-pending case.
Reduces failures in kernel32_winetest except an expected successful unlock of ~0,1, which
appears to contravene the documentation.
svn path=/trunk/; revision=56098
- Dereference the correct device object (the one who asked for shutdown notification) instead of whatever happens to be on the top of the device stack
- Fix flag issues
svn path=/trunk/; revision=56087
- Add all CD options to "welcome.exe", modify its code a bit to support this.
This is all stuff which has already been done last year, see r46065.
svn path=/branches/ros-branch-0_3_13-clt2011/; revision=51078
Although the file manager didn't become fully usable with this patch, it works better than without and the patch doesn't seem to have negative side effects.
See issue #5503 for more details.
svn path=/branches/ros-branch-0_3_13/; revision=51066
[13:43] <smiley1_> fuck
[13:44] <smiley1_> INVALID_KERNEL_HANDLE ?!?
[13:45] <smiley1_> Caemyr: after my latest commit 5 tests end with this bugcheck
svn path=/branches/ros-branch-0_3_13/; revision=51040
In contrast to my previous commit, this should indeed be merged to Trunk, but please don't forget to get rid of the corresponding FreeLDR code as well then.
svn path=/branches/ros-branch-0_3_13/; revision=51038
- Set "Angelus_02_ROSWP.bmp" as the default wallpaper
- Add a shortcut to RApps to the Desktop
- Change the boot logo to update the copyright year. Done with GIMP this time as it was one of the few tools to create proper 4-bit RLE files.
This logo shall not be merged back to Trunk, because Aleksey wants to have another bitmap ready by the next release.
svn path=/branches/ros-branch-0_3_13/; revision=51037
This is also stuff, which was mostly done by Andrew Greenwood for FOSDEM last year. I just changed it for our needs.
svn path=/branches/ros-branch-0_3_11-clt2010/; revision=46065
Kudos for this go to Andrew Greenwood, I just scripted his way of creating the disc.
- Combining them also requires changing the Live-CD directory in the kernel to "live", which renders regular Live-CDs created in this tree unbootable.
svn path=/branches/ros-branch-0_3_11-clt2010/; revision=46059
This includes:
- Merging 45269,45270,45614,45618,45619,45822,45966.
- Hardcoding NtProductWinNt instead of NtProductServer as the product type. I didn't merge the new code for this as I'm not sure about its dependencies.
- Changing 1.bmp and 6.bmp for CLT2010.
svn path=/branches/ros-branch-0_3_11-clt2010/; revision=46055
- Replace our Japanese "Systema" font added for releases by "Droid Sans Fallback" from the Android project.
This font is licensed under Apache 2.0 license (notice included) and also offers us Chinese and Korean characters.
You have to copy "DroidSansFallback.ttf" from http://android.git.kernel.org/?p=platform/frameworks/base.git;a=tree;f=data/fonts to "modules/optional".
svn path=/branches/ros-branch-0_3_11/; revision=44305
IDS_STRING_LICENSE "ReactOS Calc is free software released under GNU GPL license.\r\n\r\nYou can get a copy of GNU GPL license here:\r\nhttp://www.gnu.org/licenses/gpl.html\r\n\r\nYou can also get a translation of GNU GPL license here:\r\nhttp://www.gnu.org/licenses/translations.html"
MENUITEM "A ReactOS &Számológépről", IDM_HELP_ABOUT
END
END
/* String Tables */
STRINGTABLE
BEGIN
IDS_STRING_LICENSE "A ReactOS Számológép a GNU GPL licenc alatt kiadott szabad szoftver.\r\n\r\nA GNU GPL licenc egy másolatát innen szerezheted be:\r\nhttp://www.gnu.org/licenses/gpl.html\r\n\r\nValamint a GNU GPL licenc fordítását innen szerezheted be:\r\nhttp://www.gnu.org/licenses/translations.html"
IDS_STRING_LICENSE "Makina Llogaritese ReactOS eshte program falas i lanquar nen liçensen GNU GPL.\r\n\r\nJu mund te merrni nje kopje te liçenses se GNU CPL ketu:\r\nhttp://www.gnu.org/licenses/gpl.html\r\n\r\nJu gjithashtu mund te merrni e liçenses se GNU GPL ketu:\r\nhttp://www.gnu.org/licenses/translations.html"
IDS_STRING_LICENSE "Hesap Makinesi, GNU GPL ile yayınlanan özgür bir yazılımdır.\r\n\r\nGNU GPL'nin bir tıpkısını buradan elde edebilirsiniz:\r\nhttp://www.gnu.org/licenses/gpl.html\r\n\r\nBir de GNU GPL'nin çevirilerini buradan elde edebilirsiniz:\r\nhttp://www.gnu.org/licenses/translations.html"
IDS_LICENSE "This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version.\r\n\r\nThis program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details.\r\n\r\nYou should have received a copy of the GNU General Public License along with this program; if not, write to the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA."
IDS_ABOUT "&За..."
IDS_TITLE "Character Map"
IDS_LICENSE "This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version.\r\n\r\nThis program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details.\r\n\r\nYou should have received a copy of the GNU General Public License along with this program; if not, write to the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA."
IDS_LICENSE "This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version.\r\n\r\nThis program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details.\r\n\r\nYou should have received a copy of the GNU General Public License along with this program; if not, write to the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA."
IDS_ABOUT "&En quant a..."
IDS_TITLE "Character Map"
IDS_LICENSE "This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version.\r\n\r\nThis program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details.\r\n\r\nYou should have received a copy of the GNU General Public License along with this program; if not, write to the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA."
IDS_LICENSE "This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version.\r\n\r\nThis program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details.\r\n\r\nYou should have received a copy of the GNU General Public License along with this program; if not, write to the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA."
IDS_ABOUT "&O programu..."
IDS_TITLE "Mapa znaků"
IDS_LICENSE "This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version.\r\n\r\nThis program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details.\r\n\r\nYou should have received a copy of the GNU General Public License along with this program; if not, write to the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA."
IDS_LICENSE "Dieses Programm ist kostenlos; Sie können es frei verteilen mit od. ohne Änderungen unter der GNU Lesser General Public License wie es von der Free Software Foundation veröffentlicht wurde; entweder Version 2.1 der Lizenz, oder eine spätere Version (ihrer Wahl).\r\n\r\nThis program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details.\r\n\r\nYou should have received a copy of the GNU General Public License along with this program; if not, write to the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA."
IDS_ABOUT "Ü&ber..."
IDS_TITLE "Zeichentabelle"
IDS_LICENSE "Dieses Programm ist kostenlos; Sie können es frei verteilen mit od. ohne Änderungen unter der GNU Lesser General Public License wie es von der Free Software Foundation veröffentlicht wurde; entweder Version 2.1 der Lizenz, oder eine spätere Version (ihrer Wahl).\r\n\r\nThis program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details.\r\n\r\nYou should have received a copy of the GNU General Public License along with this program; if not, write to the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA."
IDS_LICENSE "This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version.\r\n\r\nThis program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details.\r\n\r\nYou should have received a copy of the GNU General Public License along with this program; if not, write to the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA."
IDS_ABOUT "&Πληροφορίες..."
IDS_TITLE "Character Map"
IDS_LICENSE "This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version.\r\n\r\nThis program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details.\r\n\r\nYou should have received a copy of the GNU General Public License along with this program; if not, write to the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA."
IDS_LICENSE "This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version.\r\n\r\nThis program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details.\r\n\r\nYou should have received a copy of the GNU General Public License along with this program; if not, write to the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA."
IDS_ABOUT "A&bout..."
IDS_TITLE "Character Map"
IDS_LICENSE "This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version.\r\n\r\nThis program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details.\r\n\r\nYou should have received a copy of the GNU General Public License along with this program; if not, write to the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA."
IDS_LICENSE "This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version.\r\n\r\nThis program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details.\r\n\r\nYou should have received a copy of the GNU General Public License along with this program; if not, write to the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA."
IDS_ABOUT "&Acerca de ..."
IDS_TITLE "Character Map"
IDS_LICENSE "This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version.\r\n\r\nThis program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details.\r\n\r\nYou should have received a copy of the GNU General Public License along with this program; if not, write to the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA."
IDS_LICENSE "Ce programme est un logiciel libre ; vous pouvez le redistribuer et/ou le modifier tout en respectant les termes de la ""GNU General Public License"" publiée par la Free Software Foundation; dans sa version 2 (ou selon votre préférence) toute version ultérieure.\r\n\r\nCe programme est distribué dans l'espoir qu'il sera utile, cependant SANS GARANTIE D'AUCUNE SORTE ; sans même une garantie implicite de COMMERCIABILITÉ ou DE CONFORMITÉ À UNE UTILISATION PARTICULIÈRE. \r\n\r\nVoir la Licence Publique Générale GNU pour plus de détails. Vous devriez avoir reçu un exemplaire de la Licence Publique Générale GNU avec ce programme ; si ce n'est pas le cas, écrivez à la Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA."
IDS_ABOUT "À propos..."
IDS_TITLE "Character Map"
IDS_LICENSE "Ce programme est un logiciel libre ; vous pouvez le redistribuer et/ou le modifier tout en respectant les termes de la ""GNU General Public License"" publiée par la Free Software Foundation; dans sa version 2 (ou selon votre préférence) toute version ultérieure.\r\n\r\nCe programme est distribué dans l'espoir qu'il sera utile, cependant SANS GARANTIE D'AUCUNE SORTE ; sans même une garantie implicite de COMMERCIABILITÉ ou DE CONFORMITÉ À UNE UTILISATION PARTICULIÈRE. \r\n\r\nVoir la Licence Publique Générale GNU pour plus de détails. Vous devriez avoir reçu un exemplaire de la Licence Publique Générale GNU avec ce programme ; si ce n'est pas le cas, écrivez à la Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA."
IDS_LICENSE "This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version.\r\n\r\nThis program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details.\r\n\r\nYou should have received a copy of the GNU General Public License along with this program; if not, write to the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA."
IDS_LICENSE "Program ini adalah software bebas; anda dapat mendistribusikan dan/atau mengubahnya di bawah term GNU General Public License seperti dipublikasikan oleh Free Software Foundation; baik Lisensi versi 2, atau (menurut opini anda) setiap versi berikutnya.\r\n\r\nProgram ini didistribusikan dengan harapan ia akan berguna, tetapi TANPA JAMINAN APAPUN; bahkan tanpa jaminan berarti dari MERCANTABILITAS atau KECUKUPAN UNTUK KEPERLUAN TERTENTU. Lihat GNU General Public License untuk lebih jelasnya.\r\n\r\nAnda seharusnya menerima duplikat GNU General Public License bersamaan dengan program ini; jika tidak, tulis ke Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA."
IDS_ABOUT "Te&ntang..."
IDS_TITLE "Character Map"
IDS_LICENSE "Program ini adalah software bebas; anda dapat mendistribusikan dan/atau mengubahnya di bawah term GNU General Public License seperti dipublikasikan oleh Free Software Foundation; baik Lisensi versi 2, atau (menurut opini anda) setiap versi berikutnya.\r\n\r\nProgram ini didistribusikan dengan harapan ia akan berguna, tetapi TANPA JAMINAN APAPUN; bahkan tanpa jaminan berarti dari MERCANTABILITAS atau KECUKUPAN UNTUK KEPERLUAN TERTENTU. Lihat GNU General Public License untuk lebih jelasnya.\r\n\r\nAnda seharusnya menerima duplikat GNU General Public License bersamaan dengan program ini; jika tidak, tulis ke Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA."
IDS_LICENSE "Questo programma è software libero; può redistribuirlo e/o modificarlo sotto\ni termini della licenza pubblica GNU come pubblicata dalla Free Software Foundation; sia la versione 2 sia una versione successiva (a sua scelta).\r\n\r\nQuesto programma è distribuito\nnella speranza che sia utile, ma SENZA ALCUNA GARANZIA; senza neanche la garanzia implicita\ndi NEGOZIABILITA' o APPLICABILITA' per un particolare scopo. Si veda la licenza generale pubblica GNU per maggiori dettagli.\r\n\r\nDovrebbe aver ricevuto una copia assieme a questo programma; se così non fosse, scriva alla Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA."
IDS_ABOUT "&Informazioni su..."
IDS_TITLE "Mappa caratteri"
IDS_LICENSE "Questo programma è software libero; può redistribuirlo e/o modificarlo sotto\ni termini della licenza pubblica GNU come pubblicata dalla Free Software Foundation; sia la versione 2 sia una versione successiva (a sua scelta).\r\n\r\nQuesto programma è distribuito\nnella speranza che sia utile, ma SENZA ALCUNA GARANZIA; senza neanche la garanzia implicita\ndi NEGOZIABILITA' o APPLICABILITA' per un particolare scopo. Si veda la licenza generale pubblica GNU per maggiori dettagli.\r\n\r\nDovrebbe aver ricevuto una copia assieme a questo programma; se così non fosse, scriva alla Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA."
IDS_LICENSE "This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version.\r\n\r\nThis program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details.\r\n\r\nYou should have received a copy of the GNU General Public License along with this program; if not, write to the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA."
IDS_ABOUT "バージョン情報(&B)..."
IDS_TITLE "Character Map"
IDS_LICENSE "This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version.\r\n\r\nThis program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details.\r\n\r\nYou should have received a copy of the GNU General Public License along with this program; if not, write to the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA."
IDS_LICENSE "This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version.\r\n\r\nThis program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details.\r\n\r\nYou should have received a copy of the GNU General Public License along with this program; if not, write to the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA."
IDS_ABOUT "정보(&A)"
IDS_TITLE "Character Map"
IDS_LICENSE "This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version.\r\n\r\nThis program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details.\r\n\r\nYou should have received a copy of the GNU General Public License along with this program; if not, write to the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA."
IDS_LICENSE "This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version.\r\n\r\nThis program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details.\r\n\r\nYou should have received a copy of the GNU General Public License along with this program; if not, write to the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA."
IDS_ABOUT "&Apie..."
IDS_TITLE "Character Map"
IDS_LICENSE "This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version.\r\n\r\nThis program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details.\r\n\r\nYou should have received a copy of the GNU General Public License along with this program; if not, write to the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA."
IDS_LICENSE "This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version.\r\n\r\nThis program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details.\r\n\r\nYou should have received a copy of the GNU General Public License along with this program; if not, write to the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA."
IDS_ABOUT "Over..."
IDS_TITLE "Character Map"
IDS_LICENSE "This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version.\r\n\r\nThis program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details.\r\n\r\nYou should have received a copy of the GNU General Public License along with this program; if not, write to the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA."
IDS_LICENSE "Dette programmet er gratis programvare; du kan distribuere det og/eller endre det under betingelsene av GNU General Public License som er utgitt av Free Software Foundation; version 2 av lisensen, eller (etter din mening) alle senere versjoner.\r\n\r\nDette programmet er utgitt i håp for at det skal kunne brukes, men DET ER INGEN GARANTIER; uten heller forutsatt garantier av SALGBARHET eller SIKKETHET FOR EN ENKELTHET FORMÅL. Se på GNU General Public Lisensen for mere detaljer.\r\n\r\nDu skal ha motatt en kopi av GNU General Public Lisensen sammen med denne programmet; hvis du ikke har motatt det, skriv til Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA."
IDS_ABOUT "O&m..."
IDS_TITLE "Character Map"
IDS_LICENSE "Dette programmet er gratis programvare; du kan distribuere det og/eller endre det under betingelsene av GNU General Public License som er utgitt av Free Software Foundation; version 2 av lisensen, eller (etter din mening) alle senere versjoner.\r\n\r\nDette programmet er utgitt i håp for at det skal kunne brukes, men DET ER INGEN GARANTIER; uten heller forutsatt garantier av SALGBARHET eller SIKKETHET FOR EN ENKELTHET FORMÅL. Se på GNU General Public Lisensen for mere detaljer.\r\n\r\nDu skal ha motatt en kopi av GNU General Public Lisensen sammen med denne programmet; hvis du ikke har motatt det, skriv til Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA."
IDS_LICENSE "Niniejszy program jest wolnym oprogramowaniem; możesz go rozprowadzać dalej i/lub modyfikować na warunkach Powszechnej Licencji Publicznej GNU, wydanej przez Fundację Wolnego Oprogramowania - według wersji 2 tej Licencji lub (według twojego wyboru) którejś z późniejszych wersji.\r\n\r\nNiniejszy program rozpowszechniany jest z nadzieją, iż będzie on użyteczny - jednak BEZ JAKIEJKOLWIEK GWARANCJI, nawet domyślnej gwarancji PRZYDATNOŚCI HANDLOWEJ albo PRZYDATNOŚCI DO OKRESLONYCH ZASTOSOWAŃ. W celu uzyskania bliższych informacji sięgnij do Powszechnej Licencji Publicznej GNU.\r\n\r\nZ pewnością wraz z niniejszym programem otrzymałeś też egzemplarz Powszechnej Licencji Publicznej GNU (GNU General Public License); jeśli nie - napisz do Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA."
IDS_ABOUT "&O programie..."
IDS_TITLE "Tablica znaków"
IDS_LICENSE "Niniejszy program jest wolnym oprogramowaniem; możesz go rozprowadzać dalej i/lub modyfikować na warunkach Powszechnej Licencji Publicznej GNU, wydanej przez Fundację Wolnego Oprogramowania - według wersji 2 tej Licencji lub (według twojego wyboru) którejś z późniejszych wersji.\r\n\r\nNiniejszy program rozpowszechniany jest z nadzieją, iż będzie on użyteczny - jednak BEZ JAKIEJKOLWIEK GWARANCJI, nawet domyślnej gwarancji PRZYDATNOŚCI HANDLOWEJ albo PRZYDATNOŚCI DO OKRESLONYCH ZASTOSOWAŃ. W celu uzyskania bliższych informacji sięgnij do Powszechnej Licencji Publicznej GNU.\r\n\r\nZ pewnością wraz z niniejszym programem otrzymałeś też egzemplarz Powszechnej Licencji Publicznej GNU (GNU General Public License); jeśli nie - napisz do Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA."
IDS_LICENSE "Este programa é software livre; você pode redistribuí-lo e/ou modificá-lo sob os termos da GNU General Public License conforme publicada pela Free Software Foundation; quer a versão 2 da licença, ou (conforme você escolha) qualquer versão posterior.\r\n\r\nEste programa é distribuído com a esperança de que seja útil, mas SEM QUALQUER GARANTIA; mesmo sem a garantia implícita de MERCANTIBILIDADE OU ADEQUAÇÃO A UM DETERMINADO PROPÓSITO. Para mais detalhes, veja a GNU General Public License.\r\n\r\nVocê deve ter recebido uma cópia da GNU General Public License juntamente com este programa; caso contrário, escreva para a Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA."
IDS_ABOUT "So&bre..."
IDS_TITLE "Mapa de Caracteres"
IDS_LICENSE "Este programa é software livre; você pode redistribuí-lo e/ou modificá-lo sob os termos da GNU General Public License conforme publicada pela Free Software Foundation; quer a versão 2 da licença, ou (conforme você escolha) qualquer versão posterior.\r\n\r\nEste programa é distribuído com a esperança de que seja útil, mas SEM QUALQUER GARANTIA; mesmo sem a garantia implícita de MERCANTIBILIDADE OU ADEQUAÇÃO A UM DETERMINADO PROPÓSITO. Para mais detalhes, veja a GNU General Public License.\r\n\r\nVocê deve ter recebido uma cópia da GNU General Public License juntamente com este programa; caso contrário, escreva para a Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA."
IDS_LICENSE "Această aplicație este publică; fiind permisă modificarea și/sau (re)distribuția sa în termenii Licenței Publice Generale GNU publicată de Free Software Foundation; sau versiunea 2 a Licenței, sau (la alegere) a oricărei versiuni ulterioare.\r\n\r\nAceastă aplicație este distribuită doar în speranța de a fi utilă, FĂRĂ însă NICI O GARANȚIE; nici măcar cu garanția implicită a VANDABILITĂȚII sau a UTILITĂȚII ÎNTR-UN SCOP ANUME. Pentru mai multe detalii consultați Licența Publică Generală GNU.\r\n\r\nPuteți vedea această licență aici:\r\nhttp://www.gnu.org/licenses/gpl.html\r\n\r\nDe asemenea puteți consulta traduceri neoficiale ale acestei licențe aici:\r\nhttp://www.gnu.org/licenses/translations.html"
IDS_ABOUT "&Despre…"
IDS_TITLE "Harta caracterelor"
IDS_LICENSE "Această aplicație este publică; fiind permisă modificarea și/sau (re)distribuția sa în termenii Licenței Publice Generale GNU publicată de Free Software Foundation; sau versiunea 2 a Licenței, sau (la alegere) a oricărei versiuni ulterioare.\r\n\r\nAceastă aplicație este distribuită doar în speranța de a fi utilă, FĂRĂ însă NICI O GARANȚIE; nici măcar cu garanția implicită a VANDABILITĂȚII sau a UTILITĂȚII ÎNTR-UN SCOP ANUME. Pentru mai multe detalii consultați Licența Publică Generală GNU.\r\n\r\nPuteți vedea această licență aici:\r\nhttp://www.gnu.org/licenses/gpl.html\r\n\r\nDe asemenea puteți consulta traduceri neoficiale ale acestei licențe aici:\r\nhttp://www.gnu.org/licenses/translations.html"
IDS_LICENSE "Эта программа является свободно распространяемой; Вы можете распространять ее повторно и (или) изменять, соблюдая условия Открытого лицензионного соглашения GNU, опубликованного Фондом свободно распространяемого программного обеспечения; либо редакции 2 Соглашения, либо (на ваше усмотрение) любой редакции, выпущенной позже.\r\n\r\nЭта программа распространяется в надежде на то, что она окажется полезной, но БЕЗ КАКИХ-ЛИБО ГАРАНТИЙ, включая подразумеваемую гарантию КАЧЕСТВА либо ПРИГОДНОСТИ ДЛЯ ОПРЕДЕЛЕННЫХ ЦЕЛЕЙ. Подробности содержатся в Открытом лицензионном соглашении GNU.\r\n\r\nВместес этой программой должен распространяться экземпляр Открытого лицензионного соглашения GNU, если он отсутствует, сообщите об этом в Фонд свободно распространяемого программного обеспечения (Free Software Foundation, Inc.), 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA."
IDS_ABOUT "&О программе..."
IDS_TITLE "Таблица символов"
IDS_LICENSE "Эта программа является свободно распространяемой; Вы можете распространять ее повторно и (или) изменять, соблюдая условия Открытого лицензионного соглашения GNU, опубликованного Фондом свободно распространяемого программного обеспечения; либо редакции 2 Соглашения, либо (на ваше усмотрение) любой редакции, выпущенной позже.\r\n\r\nЭта программа распространяется в надежде на то, что она окажется полезной, но БЕЗ КАКИХ-ЛИБО ГАРАНТИЙ, включая подразумеваемую гарантию КАЧЕСТВА либо ПРИГОДНОСТИ ДЛЯ ОПРЕДЕЛЕННЫХ ЦЕЛЕЙ. Подробности содержатся в Открытом лицензионном соглашении GNU.\r\n\r\nВместес этой программой должен распространяться экземпляр Открытого лицензионного соглашения GNU, если он отсутствует, сообщите об этом в Фонд свободно распространяемого программного обеспечения (Free Software Foundation, Inc.), 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA."
IDS_LICENSE "Tento program je voľný softvér; môžete ho šíriť a/alebo modifikovať podľa podmienok GNU Všeobecnej verejnej licencie (GNU General Public License) ako bola zverejnená nadáciou Free Software Foundation; buď verzie 2 tejto licencie, alebo (podľa Vášho uváženia) niektorej neskoršej verzie.\r\n\r\nTento program je distribuovaný v nádeji, že bude užitočný, avšak BEZ AKEJKOĽVEK ZÁRUKY; rovnako bez záruky PREDAJNOSTI alebo VHODNOSTI PRE URČITÝ ÚČEL. Pre viac detailov si pozrite GNU Všeobecnú verejnú licenciu (GNU General Public License).\r\n\r\nKópiu Všeobecnej verejnej licencie GNU ste mali dostať spolu s týmto programom; ak nie, napíšte si o ňu na Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA."
IDS_ABOUT "Č&o je Mapa znakov"
IDS_TITLE "Character Map"
IDS_LICENSE "Tento program je voľný softvér; môžete ho šíriť a/alebo modifikovať podľa podmienok GNU Všeobecnej verejnej licencie (GNU General Public License) ako bola zverejnená nadáciou Free Software Foundation; buď verzie 2 tejto licencie, alebo (podľa Vášho uváženia) niektorej neskoršej verzie.\r\n\r\nTento program je distribuovaný v nádeji, že bude užitočný, avšak BEZ AKEJKOĽVEK ZÁRUKY; rovnako bez záruky PREDAJNOSTI alebo VHODNOSTI PRE URČITÝ ÚČEL. Pre viac detailov si pozrite GNU Všeobecnú verejnú licenciu (GNU General Public License).\r\n\r\nKópiu Všeobecnej verejnej licencie GNU ste mali dostať spolu s týmto programom; ak nie, napíšte si o ňu na Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA."
IDS_LICENSE "Ky program eshte falas; ju mund ta shperndani ose modifikoni nen termat e liçenses publike te GNU nga Free Software Foundation; ose versionin 2 te Liçenses, ose (opsionet tend) versionet me te reja.\r\n\r\nKy program shperndahet me shpresen qe do te jete i nevojshem, POR PA ASNJE GARANCI; madje dhe pa nënkuptimin e garancisë së tregtimit apo përshtatshmerise për qëllim të veçantë. Shiko liçensen publike te GNU per me shume detaje.\r\n\r\nJu duhet te jeni paisur me nje kopje te liçenses GNU perkrah ketij programi; nese jo, shkruani Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA."
IDS_LICENSE "Detta programmet är fri programvara; du kan distribuera det och/eller ändra det under villkoren enligt GNU General Public License som är utgivet av Free Software Foundation; version 2, eller (om du så önskar) alla senare versioner.\r\n\r\nDette programmet er utgivet i hopp om att det skall kunne användas, men DET FINNS INGA GARANTIER; även utan underförstådd garanti om SÄLJBARHET eller LÄMPLIGHET FÖR ETT VISST ÄNDAMÅL. Se på GNU General Public Licensen för mer detaljer.\r\n\r\nDu skall ha motagit en kopia av GNU General Public Licensen tillsammans med detta programmet; om du inte har fått det, skriv til Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA."
IDS_ABOUT "O&m..."
IDS_TITLE "Character Map"
IDS_LICENSE "Detta programmet är fri programvara; du kan distribuera det och/eller ändra det under villkoren enligt GNU General Public License som är utgivet av Free Software Foundation; version 2, eller (om du så önskar) alla senare versioner.\r\n\r\nDette programmet er utgivet i hopp om att det skall kunne användas, men DET FINNS INGA GARANTIER; även utan underförstådd garanti om SÄLJBARHET eller LÄMPLIGHET FÖR ETT VISST ÄNDAMÅL. Se på GNU General Public Licensen för mer detaljer.\r\n\r\nDu skall ha motagit en kopia av GNU General Public Licensen tillsammans med detta programmet; om du inte har fått det, skriv til Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA."
IDS_LICENSE "ÖNEMLİ: Aşağıdaki metin, özgün metnin resmî olmayan çevirisidir. Çeviri metniyle özgün metin arasında ayrım olabilir. Özgün metin, çeviri metninin altındadır.\r\n\r\n***\r\n\r\nBu yazılım özgürdür, yâni bu yazılım Özgür Yazılım Vakfı'nın yayınladığı GNU Umûmî Kamu Ruhsatı'nın 2. sürümü veyâ daha sonraki sürümleri altında yeniden dağıtabilir veyâ değiştirebilirsiniz.\r\n\r\nBu yazılım, kullanışlı olabileceği umuduyla dağıtılmıştır, ancak bilhassa SATILABİLİRLİK ve BELİRLİ BİR AMACA UYGUNLUK açısından olmak üzere bu yazılımın hiçbir güvencesi yoktur. Daha çok bilgi için GNU Umûmî Kamu Ruhsatı'na bakınız.\r\n\r\nBu yazılımla birlikte GNU Umûmî Kamu Ruhsatı'nın bir sûretine de iye olmanız gerekir, eğer yoksa Özgür Yazılım Vakfı A.Ş.'ne (51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 ABD) yazınız.\r\n\r\n***\r\n\r\nThis program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version.\r\n\r\nThis program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details.\r\n\r\nYou should have received a copy of the GNU General Public License along with this program; if not, write to the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA."
IDS_ABOUT "&Hakkında"
IDS_TITLE "Karakter Eşlem"
END
Some files were not shown because too many files have changed in this diff
Show More
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
