GitHub-Mirror/riotX-android
1
0
Fork 1
mirror of https://github.com/vector-im/riotX-android synced 2025-10-05 15:52:47 +02:00
Code Issues Releases Wiki Activity

Reduce complexity of function

Browse Source
This commit is contained in:
Hugh Nimmo-Smith
2023-03-09 13:56:42 -05:00
committed by yostyle
parent 8e416cdaee
commit fb3b8aabf6
1 changed files with 54 additions and 47 deletions
Download Patch File Download Diff File Expand all files Collapse all files

101
matrix-sdk-android/src/main/java/org/matrix/android/sdk/api/rendezvous/Rendezvous.kt
View File

@@ -234,65 +234,72 @@ class Rendezvous(
if (verificationResponse?.outcome == Outcome.VERIFIED || verificationResponse?.type == PayloadType.VERIFIED) { if (verificationResponse?.outcome == Outcome.VERIFIED || verificationResponse?.type == PayloadType.VERIFIED) {
val verifyingDeviceId = verificationResponse.verifyingDeviceId val verifyingDeviceId = verificationResponse.verifyingDeviceId
?: throw RendezvousError("No verifying device id returned", RendezvousFailureReason.ProtocolError) ?: throw RendezvousError("No verifying device id returned", RendezvousFailureReason.ProtocolError)
val verifyingDeviceFromServer = crypto.getCryptoDeviceInfo(userId, verifyingDeviceId) handleVerification(session, verifyingDeviceId, verificationResponse.verifyingDeviceKey, verificationResponse.masterKey)
if (verifyingDeviceFromServer?.fingerprint() != verificationResponse.verifyingDeviceKey) { } else {
Timber.tag(TAG).w( Timber.tag(TAG).i("Not doing verification")
"Verifying device $verifyingDeviceId key doesn't match: ${ }
verifyingDeviceFromServer?.fingerprint() }
} vs ${verificationResponse.verifyingDeviceKey})"
) @Throws(RendezvousError::class)
private suspend fun handleVerification(session: Session, verifyingDeviceId: String, verifyingDeviceKey: String?, masterKey: String?) {
var crypto = session.cryptoService()
var userId = session.myUserId
val verifyingDeviceFromServer = crypto.getCryptoDeviceInfo(userId, verifyingDeviceId)
if (verifyingDeviceFromServer?.fingerprint() != verifyingDeviceKey) {
Timber.tag(TAG).w(
"Verifying device $verifyingDeviceId key doesn't match: ${
verifyingDeviceFromServer?.fingerprint()
} vs $verifyingDeviceKey)"
)
// inform the other side
if (isUsingV1()) {
send(Payload(PayloadType.FINISH, outcome = Outcome.E2EE_SECURITY_ERROR))
} else {
send(Payload(PayloadType.FAILURE, reason = FailureReason.E2EE_SECURITY_ERROR))
}
throw RendezvousError("Key from verifying device doesn't match", RendezvousFailureReason.E2EESecurityIssue)
}
masterKey?.let { masterKeyFromVerifyingDevice ->
// verifying device provided us with a master key, so use it to check integrity
// see what the homeserver told us
val localMasterKey = crypto.crossSigningService().getMyCrossSigningKeys()?.masterKey()
// n.b. if no local master key this is a problem, as well as it not matching
if (localMasterKey?.unpaddedBase64PublicKey != masterKeyFromVerifyingDevice) {
Timber.tag(TAG).w("Master key from verifying device doesn't match: $masterKeyFromVerifyingDevice vs $localMasterKey")
// inform the other side // inform the other side
if (isUsingV1()) { if (isUsingV1()) {
send(Payload(PayloadType.FINISH, outcome = Outcome.E2EE_SECURITY_ERROR)) send(Payload(PayloadType.FINISH, outcome = Outcome.E2EE_SECURITY_ERROR))
} else { } else {
send(Payload(PayloadType.FAILURE, reason = FailureReason.E2EE_SECURITY_ERROR)) send(Payload(PayloadType.FAILURE, reason = FailureReason.E2EE_SECURITY_ERROR))
} }
throw RendezvousError("Key from verifying device doesn't match", RendezvousFailureReason.E2EESecurityIssue) throw RendezvousError("Master key from verifying device doesn't match", RendezvousFailureReason.E2EESecurityIssue)
} }
verificationResponse.masterKey?.let { masterKeyFromVerifyingDevice -> // set other device as verified
// verifying device provided us with a master key, so use it to check integrity Timber.tag(TAG).i("Setting device $verifyingDeviceId as verified")
crypto.setDeviceVerification(DeviceTrustLevel(locallyVerified = true, crossSigningVerified = false), userId, verifyingDeviceId)
// see what the homeserver told us Timber.tag(TAG).i("Setting master key as trusted")
val localMasterKey = crypto.crossSigningService().getMyCrossSigningKeys()?.masterKey() crypto.crossSigningService().markMyMasterKeyAsTrusted()
} ?: run {
// set other device as verified anyway
Timber.tag(TAG).i("Setting device $verifyingDeviceId as verified")
crypto.setDeviceVerification(DeviceTrustLevel(locallyVerified = true, crossSigningVerified = false), userId, verifyingDeviceId)
// n.b. if no local master key this is a problem, as well as it not matching Timber.tag(TAG).i("No master key given by verifying device")
if (localMasterKey?.unpaddedBase64PublicKey != masterKeyFromVerifyingDevice) { }
Timber.tag(TAG).w("Master key from verifying device doesn't match: $masterKeyFromVerifyingDevice vs $localMasterKey")
// inform the other side
if (isUsingV1()) {
send(Payload(PayloadType.FINISH, outcome = Outcome.E2EE_SECURITY_ERROR))
} else {
send(Payload(PayloadType.FAILURE, reason = FailureReason.E2EE_SECURITY_ERROR))
}
throw RendezvousError("Master key from verifying device doesn't match", RendezvousFailureReason.E2EESecurityIssue)
}
// set other device as verified // request secrets from the verifying device
Timber.tag(TAG).i("Setting device $verifyingDeviceId as verified") Timber.tag(TAG).i("Requesting secrets from $verifyingDeviceId")
crypto.setDeviceVerification(DeviceTrustLevel(locallyVerified = true, crossSigningVerified = false), userId, verifyingDeviceId)
Timber.tag(TAG).i("Setting master key as trusted") session.sharedSecretStorageService().let {
crypto.crossSigningService().markMyMasterKeyAsTrusted() it.requestSecret(MASTER_KEY_SSSS_NAME, verifyingDeviceId)
} ?: run { it.requestSecret(SELF_SIGNING_KEY_SSSS_NAME, verifyingDeviceId)
// set other device as verified anyway it.requestSecret(USER_SIGNING_KEY_SSSS_NAME, verifyingDeviceId)
Timber.tag(TAG).i("Setting device $verifyingDeviceId as verified") it.requestSecret(KEYBACKUP_SECRET_SSSS_NAME, verifyingDeviceId)
crypto.setDeviceVerification(DeviceTrustLevel(locallyVerified = true, crossSigningVerified = false), userId, verifyingDeviceId)
Timber.tag(TAG).i("No master key given by verifying device")
}
// request secrets from the verifying device
Timber.tag(TAG).i("Requesting secrets from $verifyingDeviceId")
session.sharedSecretStorageService().let {
it.requestSecret(MASTER_KEY_SSSS_NAME, verifyingDeviceId)
it.requestSecret(SELF_SIGNING_KEY_SSSS_NAME, verifyingDeviceId)
it.requestSecret(USER_SIGNING_KEY_SSSS_NAME, verifyingDeviceId)
it.requestSecret(KEYBACKUP_SECRET_SSSS_NAME, verifyingDeviceId)
}
} else {
Timber.tag(TAG).i("Not doing verification")
} }
} }