(converter) Add more logging around dom sample data retrieval errors

This reverts commit b7a5219ed3.

code/functions/live-capture/api/java/nu/marginalia/api/domsample/DomSampleClient.java

@@ -41,7 +41,7 @@ public class DomSampleClient {
         }
         catch (StatusRuntimeException sre) {
             if (sre.getStatus() != Status.NOT_FOUND) {
-                logger.error("Failed to fetch DOM sample");
+                logger.error("Failed to fetch DOM sample", sre);
             }
             return Optional.empty();
         }

code/processes/converting-process/ft-dom-classifier/resources/request-classifier.xml

@@ -15,6 +15,7 @@
     <classifier target="url-regex" rule="tracking">/ccm/collect$</classifier>
     <classifier target="url-regex" rule="tracking">^/[0-9]+\.js$</classifier>
     <classifier target="url-regex" rule="tracking">^/[a-z0-9]\.gif$</classifier>
+    <classifier target="url-regex" rule="tracking">^/pixel\.gif$</classifier>
     <classifier target="url-regex" rule="ads">/pagead/</classifier>
     <classifier target="url-regex" rule="ads">/google-ads/</classifier>
 

code/processes/converting-process/java/nu/marginalia/converting/processor/DomainProcessor.java

@@ -98,10 +98,13 @@ public class DomainProcessor {
         return domSampleClient
                 .getSampleAsync(domainName, domSampleExecutor)
                 .thenApply(domSampleClassifier::classifySample)
-                .handle((a,b) ->
-                        Objects.requireNonNullElseGet(a,
-                                () -> EnumSet.of(DomSampleClassification.UNCLASSIFIED)))
-                .get();
+                .handle((a,b) -> {
+                    if (b != null) {
+                        logger.warn("Exception when fetching sample data", b);
+                        return EnumSet.of(DomSampleClassification.UNCLASSIFIED);
+                    }
+                    return a;
+                }).get();
     }
 
     @Nullable

code/processes/converting-process/java/nu/marginalia/converting/processor/plugin/HtmlDocumentProcessorPlugin.java

@@ -161,7 +161,6 @@ public class HtmlDocumentProcessorPlugin extends AbstractDocumentProcessorPlugin
 
         final Set<HtmlFeature> features = featureExtractor.getFeatures(url, doc, documentHeaders, dld);
 
-
         if (!documentLengthLogic.validateLength(dld, specialization.lengthModifier() * documentClass.lengthLimitModifier())) {
             features.add(HtmlFeature.SHORT_DOCUMENT);
         }

code/processes/converting-process/java/nu/marginalia/converting/processor/plugin/PdfDocumentProcessorPlugin.java

@@ -115,7 +115,9 @@ public class PdfDocumentProcessorPlugin extends AbstractDocumentProcessorPlugin
 
         ret.quality = -5;
 
-        ret.features = Set.of(HtmlFeature.PDF);
+        ret.features = new HashSet<>(); // must be mutable!
+        ret.features.add(HtmlFeature.PDF);
+
         ret.description = getDescription(doc);
         ret.hashCode = dld.localitySensitiveHashCode();
 

deploy.txt

@@ -11,3 +11,4 @@
 2025-05-17:  Redeploy all.
 2025-05-28:  Deploy assistant and browserless.
 2025-06-06:  Deploy assistant and browserless.
+2025-07-21:  Deploy executor partition 1.