(converter) Add more logging around dom sample data retrieval errors

Reapply "(grpc) Use grpc-netty instead of grpc-netty-shaded"
This reverts commit b7a5219ed3.
2025-10-06 07:32:38 +02:00 · 2025-07-21 13:26:38 +02:00 · 2025-07-21 13:23:32 +02:00 · 2025-07-21 13:10:41 +02:00
2 changed files with 8 additions and 5 deletions
--- a/code/functions/live-capture/api/java/nu/marginalia/api/domsample/DomSampleClient.java
+++ b/code/functions/live-capture/api/java/nu/marginalia/api/domsample/DomSampleClient.java
@@ -41,7 +41,7 @@ public class DomSampleClient {
        }
        catch (StatusRuntimeException sre) {
            if (sre.getStatus() != Status.NOT_FOUND) {
-                logger.error("Failed to fetch DOM sample");
+                logger.error("Failed to fetch DOM sample", sre);
            }
            return Optional.empty();
        }
--- a/code/processes/converting-process/java/nu/marginalia/converting/processor/DomainProcessor.java
+++ b/code/processes/converting-process/java/nu/marginalia/converting/processor/DomainProcessor.java
@@ -98,10 +98,13 @@ public class DomainProcessor {
        return domSampleClient
                .getSampleAsync(domainName, domSampleExecutor)
                .thenApply(domSampleClassifier::classifySample)
-                .handle((a,b) ->
-                        Objects.requireNonNullElseGet(a,
-                                () -> EnumSet.of(DomSampleClassification.UNCLASSIFIED)))
-                .get();
+                .handle((a,b) -> {
+                    if (b != null) {
+                        logger.warn("Exception when fetching sample data", b);
+                        return EnumSet.of(DomSampleClassification.UNCLASSIFIED);
+                    }
+                    return a;
+                }).get();
    }

    @Nullable
Author	SHA1	Message	Date
Viktor Lofgren	8aad253cf6	(converter) Add more logging around dom sample data retrieval errors	2025-07-21 13:26:38 +02:00
Viktor Lofgren	556d7af9dc	Reapply "(grpc) Use grpc-netty instead of grpc-netty-shaded" This reverts commit `b7a5219ed3`.	2025-07-21 13:23:32 +02:00
Viktor Lofgren	b7a5219ed3	Revert "(grpc) Use grpc-netty instead of grpc-netty-shaded" Reverting this change to see if it's the cause of some instability issues observed.	2025-07-21 13:10:41 +02:00