From 4ec3268c78572b84afd39fa8b8e47f851e655707 Mon Sep 17 00:00:00 2001 From: Jehan Date: Wed, 30 Apr 2025 23:36:15 +0200 Subject: [PATCH] clang-format: uncomment rule not usable yet. BinPackParameters is looking for a boolean right now, which was changed to the enum we were using, but only for LLVM 20 (not yet available in our CI). Comment this line for now. Fixes failure in "clang-format" job in CI: > Debian clang-format version 14.0.6 > /builds/GNOME/gimp/.clang-format:22:20: error: invalid boolean > BinPackParameters: AlwaysOnePerLine > ^~~~~~~~~~~~~~~~ > Error reading /builds/GNOME/gimp/.clang-format: Invalid argument See: https://github.com/llvm/llvm-project/issues/117830 --- .clang-format | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.clang-format b/.clang-format index 1d27824df1..9fbafa2f5e 100644 --- a/.clang-format +++ b/.clang-format @@ -19,7 +19,9 @@ AllowAllArgumentsOnNextLine: false AllowAllParametersOfDeclarationOnNextLine: false AlwaysBreakAfterReturnType: AllDefinitions BinPackArguments: true -BinPackParameters: AlwaysOnePerLine +# Uncomment when our CI uses LLVM 20. +# See: https://github.com/llvm/llvm-project/issues/117830 +# BinPackParameters: AlwaysOnePerLine BreakBeforeBinaryOperators: None BreakBeforeBraces: GNU BreakBeforeTernaryOperators: false