eUgEntOptIc44/gimp
1
1
Fork 0
mirror of https://gitlab.gnome.org/GNOME/gimp.git synced 2025-10-06 01:12:40 +02:00
Code Issues Releases Activity

app, libgimpbase, plug-ins: deprecate GimpPixPipe.

Browse Source 
This really feels like internal API which we'd want to keep private (and
used by core plug-ins only).

Also as Jacob noticed, it's not even included in libgimpbase/gimpbase.h
so plug-ins wishing to use this API need to include this file
specifically anyway (but the header is still installed and the API is
introspected).

Since we cannot remove these functions now that GIMP 3 was published,
for API stability, I am only deprecating them both in the C API with
macros and in the bindings with GObject Introspection annotations.
Therefore any third-party plug-in developer trying to use these
functions in a plug-in will get build-time or run-time warnings.

Then when we'll move on to GIMP 4 development, we can remove the
deprecation and simply make this file private-only use instead.
This commit is contained in:
Jehan
2025-09-11 15:26:47 +02:00
parent 03beda6e2a
commit 7c947ef1af
6 changed files with 74 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
plug-ins/common/file-gih.c
View File

@@ -291,7 +291,9 @@ gih_export (GimpProcedure *procedure,
gint cell_width;
gint cell_height;
G_GNUC_BEGIN_IGNORE_DEPRECATIONS
gimp_pixpipe_params_init (&gihparams);
G_GNUC_END_IGNORE_DEPRECATIONS
/* Possibly retrieve data */
parasite = gimp_image_get_parasite (orig_image,
@@ -331,7 +333,9 @@ gih_export (GimpProcedure *procedure,
&parasite_size);
parasite_data = g_strndup (parasite_data, parasite_size);
G_GNUC_BEGIN_IGNORE_DEPRECATIONS
gimp_pixpipe_params_parse (parasite_data, &gihparams);
G_GNUC_END_IGNORE_DEPRECATIONS
g_object_set (config,
"num-cells", gihparams.ncells,
@@ -437,7 +441,9 @@ gih_export (GimpProcedure *procedure,
GimpValueArray *save_retvals;
gchar *paramstring;
G_GNUC_BEGIN_IGNORE_DEPRECATIONS
paramstring = gimp_pixpipe_params_build (&gihparams);
G_GNUC_END_IGNORE_DEPRECATIONS
procedure = gimp_pdb_lookup_procedure (gimp_get_pdb (),
"file-gih-export-internal");
@@ -474,7 +480,9 @@ gih_export (GimpProcedure *procedure,
g_free (paramstring);
}
G_GNUC_BEGIN_IGNORE_DEPRECATIONS
gimp_pixpipe_params_free (&gihparams);
G_GNUC_END_IGNORE_DEPRECATIONS
g_free (description);
out:

4
plug-ins/common/file-psp.c
View File

@@ -2263,7 +2263,9 @@ read_tube_block (FILE *f,
GimpParasite *pipe_parasite;
gchar *parasite_text;
G_GNUC_BEGIN_IGNORE_DEPRECATIONS
gimp_pixpipe_params_init (&params);
G_GNUC_END_IGNORE_DEPRECATIONS
if (psp_ver_major >= 4)
{
@@ -2331,7 +2333,9 @@ read_tube_block (FILE *f,
(selection_mode == tsmPressure ? "pressure" :
(selection_mode == tsmVelocity ? "velocity" :
"default")))));
G_GNUC_BEGIN_IGNORE_DEPRECATIONS
parasite_text = gimp_pixpipe_params_build (&params);
G_GNUC_END_IGNORE_DEPRECATIONS
IFDBG(2) g_message ("parasite: %s", parasite_text);