mirror of
https://gitlab.gnome.org/GNOME/gimp.git
synced 2025-10-06 01:12:40 +02:00
af3007afbf
This commit changes the metadata viewer to use `GtkListBox`es instead of `GtkTreeView`s for displaying the tags and their values. The main advantages is that the latter isn't available in GTK4 (making the eventual port to it smaller), that they have a11y problems, and that list boxes allow more advanced UIs than just showing a simple string. One thing for example that this commit introduces, is to make the labels selectable, so they can be easily copy-pasted for lookup. Since we wanted to use `GListModel`, this commit also introduces a helper object `GimpMetadataTagObject` which holds both a tag's name and its value. In the future, we could use this to move the string formatting logic to that helper object, which we could then in turn use for more advanced UIs.
95 lines
2.4 KiB
C
95 lines
2.4 KiB
C
/* GIMP - The GNU Image Manipulation Program
|
|
* Copyright (C) 1995 Spencer Kimball and Peter Mattis
|
|
*
|
|
* metadata-tag.c
|
|
* Copyright (C) 2024 Niels De Graef
|
|
*
|
|
* This program is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program. If not, see <https://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include "config.h"
|
|
|
|
#include <libgimp/gimp.h>
|
|
#include <libgimp/gimpui.h>
|
|
|
|
#include "metadata-tag-object.h"
|
|
|
|
struct _GimpMetadataTagObject
|
|
{
|
|
GObject parent_instance;
|
|
|
|
gchar *tag;
|
|
gchar *value;
|
|
};
|
|
|
|
G_DEFINE_TYPE (GimpMetadataTagObject, gimp_metadata_tag_object, G_TYPE_OBJECT);
|
|
|
|
static void gimp_metadata_tag_object_finalize (GObject *object);
|
|
|
|
static void
|
|
gimp_metadata_tag_object_finalize (GObject *object)
|
|
{
|
|
GimpMetadataTagObject *self = GIMP_METADATA_TAG_OBJECT (object);
|
|
|
|
g_free (self->tag);
|
|
g_free (self->value);
|
|
|
|
G_OBJECT_CLASS (gimp_metadata_tag_object_parent_class)->finalize (object);
|
|
}
|
|
|
|
static void
|
|
gimp_metadata_tag_object_init (GimpMetadataTagObject *self)
|
|
{
|
|
}
|
|
|
|
static void
|
|
gimp_metadata_tag_object_class_init (GimpMetadataTagObjectClass *klass)
|
|
{
|
|
GObjectClass *object_class = G_OBJECT_CLASS (klass);
|
|
|
|
object_class->finalize = gimp_metadata_tag_object_finalize;
|
|
}
|
|
|
|
GimpMetadataTagObject *
|
|
gimp_metadata_tag_object_new (const gchar *tag,
|
|
const gchar *value)
|
|
{
|
|
GimpMetadataTagObject *self;
|
|
|
|
g_return_val_if_fail (tag != NULL, NULL);
|
|
g_return_val_if_fail (value != NULL, NULL);
|
|
|
|
self = g_object_new (GIMP_TYPE_METADATA_TAG_OBJECT, NULL);
|
|
self->tag = g_strdup (tag);
|
|
self->value = g_strdup (value);
|
|
|
|
return self;
|
|
}
|
|
|
|
const gchar *
|
|
gimp_metadata_tag_object_get_tag (GimpMetadataTagObject *self)
|
|
{
|
|
g_return_val_if_fail (GIMP_IS_METADATA_TAG_OBJECT (self), NULL);
|
|
|
|
return self->tag;
|
|
}
|
|
|
|
const gchar *
|
|
gimp_metadata_tag_object_get_value (GimpMetadataTagObject *self)
|
|
{
|
|
g_return_val_if_fail (GIMP_IS_METADATA_TAG_OBJECT (self), NULL);
|
|
|
|
return self->value;
|
|
}
|