fix(lints): clippy 1.89-1.90 (#14223)

helix-view/src/annotations/diagnostics.rs

@@ -186,7 +186,7 @@ impl<'a> InlineDiagnosticAccumulator<'a> {
                 .doc
                 .diagnostics
                 .get(self.idx)
-                .map_or(true, |diag| diag.range.start != grapheme.char_idx)
+                .is_none_or(|diag| diag.range.start != grapheme.char_idx)
             {
                 return false;
             }

helix-view/src/document.rs

@@ -1655,7 +1655,7 @@ impl Document {
         let savepoint_idx = self
             .savepoints
             .iter()
-            .position(|savepoint_ref| savepoint_ref.as_ptr() == savepoint as *const _)
+            .position(|savepoint_ref| std::ptr::eq(savepoint_ref.as_ptr(), savepoint))
             .expect("Savepoint must belong to this document");
 
         let savepoint_ref = self.savepoints.remove(savepoint_idx);

helix-view/src/editor.rs

@@ -1644,7 +1644,7 @@ impl Editor {
             doc.language_servers.iter().filter(|(name, doc_ls)| {
                 language_servers
                     .get(*name)
-                    .map_or(true, |ls| ls.id() != doc_ls.id())
+                    .is_none_or(|ls| ls.id() != doc_ls.id())
             });
 
         for (_, language_server) in doc_language_servers_not_in_registry {
@@ -1654,7 +1654,7 @@ impl Editor {
         let language_servers_not_in_doc = language_servers.iter().filter(|(name, ls)| {
             doc.language_servers
                 .get(*name)
-                .map_or(true, |doc_ls| ls.id() != doc_ls.id())
+                .is_none_or(|doc_ls| ls.id() != doc_ls.id())
         });
 
         for (_, language_server) in language_servers_not_in_doc {

helix-view/src/gutter.rs

@@ -69,7 +69,7 @@ pub fn diagnostic<'doc>(
                 .iter()
                 .take_while(|d| {
                     d.line == line
-                        && d.provider.language_server_id().map_or(true, |id| {
+                        && d.provider.language_server_id().is_none_or(|id| {
                             doc.language_servers_with_feature(LanguageServerFeature::Diagnostics)
                                 .any(|ls| ls.id() == id)
                         })

helix-view/src/handlers/lsp.rs

@@ -355,7 +355,7 @@ impl Editor {
                         && diagnostic
                             .source
                             .as_ref()
-                            .map_or(true, |source| !unchanged_diag_sources.contains(source))
+                            .is_none_or(|source| !unchanged_diag_sources.contains(source))
                 };
             let diagnostics = Self::doc_diagnostics_with_filter(
                 &self.language_servers,

helix-view/src/tree.rs

@@ -441,7 +441,7 @@ impl Tree {
         }
     }
 
-    pub fn traverse(&self) -> Traverse {
+    pub fn traverse(&self) -> Traverse<'_> {
         Traverse::new(self)
     }