helix-editor/helix
1
0
Fork 0
mirror of https://github.com/helix-editor/helix.git synced 2025-10-06 00:13:28 +02:00
Code Issues Packages Projects Releases Wiki Activity

minor: Move json deserialization into text_document_hover future

Browse Source 
This follows a pattern used in the signature help request for example.
Moving the json deserialization into the return future of
`text_document_hover` makes the types easier for callers to work with.
This commit is contained in:
Michael Davis
2025-03-04 12:01:06 -05:00
parent 486f4297b7
commit fbc0f956b3
2 changed files with 4 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
helix-lsp/src/client.rs
View File

@@ -1119,7 +1119,7 @@ impl Client {
text_document: lsp::TextDocumentIdentifier,
position: lsp::Position,
work_done_token: Option<lsp::ProgressToken>,
) -> Option<impl Future<Output = Result<Value>>> {
) -> Option<impl Future<Output = Result<Option<lsp::Hover>>>> {
let capabilities = self.capabilities.get().unwrap();
// Return early if the server does not support hover.
@@ -1140,7 +1140,8 @@ impl Client {
// lsp::SignatureHelpContext
};
Some(self.call::<lsp::request::HoverRequest>(params))
let res = self.call::<lsp::request::HoverRequest>(params);
Some(async move { Ok(serde_json::from_value(res.await?)?) })
}
// formatting