GitHub-Mirror/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos synced 2025-10-06 00:12:51 +02:00
Code Issues Packages Projects Releases Wiki Activity

[HALX86] HalpDmaAllocateChildAdapter(): Fix memory leak, on error (#4156)

Browse Source 
Simplify code, instead of adding 2 missing ObDereferenceObject().
(Note that ObInsertObject() always dereferences the object in case of failure.)

CORE-17904
This commit is contained in:
Serge Gautherie
2021-12-20 21:14:36 +01:00
committed by GitHub
parent 2196a06fc1
commit 0fd3e51580
1 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
hal/halx86/generic/dma.c
View File

@@ -477,12 +477,6 @@ HalpDmaAllocateChildAdapter(IN ULONG NumberOfMapRegisters,
(PVOID)&AdapterObject);
if (!NT_SUCCESS(Status)) return NULL;
Status = ObReferenceObjectByPointer(AdapterObject,
FILE_READ_DATA | FILE_WRITE_DATA,
IoAdapterObjectType,
KernelMode);
if (!NT_SUCCESS(Status)) return NULL;
RtlZeroMemory(AdapterObject, sizeof(ADAPTER_OBJECT));
Status = ObInsertObject(AdapterObject,
@@ -493,6 +487,8 @@ HalpDmaAllocateChildAdapter(IN ULONG NumberOfMapRegisters,
&Handle);
if (!NT_SUCCESS(Status)) return NULL;
ObReferenceObject(AdapterObject);
ZwClose(Handle);
AdapterObject->DmaHeader.Version = (USHORT)DeviceDescription->Version;