- Revert hack from r63126 to make some notebook controllers work, and which also broke the mouse wheel on other systems, and replace it with an #ifdef.
See CORE-6901, CORE-4048, CORE-8572
svn path=/trunk/; revision=66762
- Improve the app's title by printing the filename and the current state of the player. By Ricardo Hanke.
- Fix pause state retrieval.
svn path=/trunk/; revision=66746
* Fix leak of the PIDL and PIDL Manager from the shell folder destructors.
* Switch PIDL Manager to a lazy enumeration so it won't lookup the folder contents unless/until they are needed.
svn path=/trunk/; revision=66745
- don't garble the output with invalid data in WideCharToUtf7
- fixes whopping 65536 failed tests and as a result Testman shouldn't choke on kernel32:codepage anymore
svn path=/trunk/; revision=66742
* Disable the hardcoded part of the File menu. It provided no useful function and couldn't be localized. It can be reintroduced later when it is done properly.
svn path=/trunk/; revision=66741
- adjust the settings dialog layout (by Stefan Fulea) CORE-9377
- disable the proxy settings input boxes if default/no proxy is selected
- update the czech translation
svn path=/trunk/; revision=66736
- Remove hardcoded registry values: CurrentVersion, CSDVersion and CurrentBuildNumber from HKLM\SOFTWARE\Microsoft\Windows NT\CurrentVersion. They are computed and stored there by the kernel.
- All the versioning is controlled by the two values: CSDReleaseType and CSDVersion in HKLM\SYSTEM\CurrentControlSet\Control\Windows. Currently we target SP1.
[NTDLL]
The lpVersionInformation->szCSDVersion string should not be built by RtlGetVersion, but instead retrieved from the Peb->CSDVersion string that in turn is initialized by the NTDLL PE Loader. Normally this is a App-Compatibility-dependent string, but for now we somewhat hardcode it (it is built using the actual Peb->OSCSDVersion number).
[RTL]: Rename some variables "à la NT" and use adequate types (but no code changes otherwise).
[NTOS]
- Fix PsGetVersion that should use the CmCSDVersionString variable. This API also returns TRUE if we are in checked build mode (the high byte of NtBuildNumber is flagged).
- The kernel should initialize the CurrentVersion, CSDVersion and CurrentBuildNumber registry values (and few other ones) from the two main CSDReleaseType and CSDVersion values.
- Fix the ReactOS-specific version+revision display in SOS mode.
CORE-6611 CORE-7889 CORE-8877
svn path=/trunk/; revision=66735
- Don't select disconnected interfaces as default
- Only count prefix matches of non-zero length
- Fixes connectivity with multiple NICs when one or more is disconnected
svn path=/trunk/; revision=66734
* Implement support for column sorting in CompareIDs, for Name, Type, and Creation Date columns. The link target, and registry key contents are not sortable yet.
svn path=/trunk/; revision=66732
- Add a whole bunch of new wallpapers (easier to grab them from the repo instead of going through Forum + Jira to search for them). Now that we support JPG/PNG/... wallpapers (in addition to bitmap ones) since r66394, we can have many jpg wallpapers for the price (read: same size) of 1 bitmap one.
- Move a file to a better appropriate place.
svn path=/trunk/; revision=66724
- Call DrawCaption in user32 when we get WM_NCUAHDRAWCAPTION and there is no active theme.
- Should finally fix CORE-9016.
svn path=/trunk/; revision=66723
Add winternl.h, which is compatible with the native one. Do not use this header. USE NDK! (Thanks Hermes!) It's only there for SDK compatibility and to make sure nobody will think it's missing and add it to make use of it.
And to make sure, nobody will use this header, it will #error if you include it from a reactos module.
svn path=/trunk/; revision=66721
* Implement loading the hardcoded list of root keys.
* Add support for root keys to the registry PIDL structure.
* Add support for root-key PIDLs in the registry folder.
* Implement loading root keys when no path is specified.
* Expose the registry folder as a namespace extension to My Computer.
* Make the namespace extension folder names load from resources.
* Add icons for registry keys and values.
CORE-9244 #resolve #comment Basic registry browsing should now be functional. Any other issues (including editing capability), would go in followup issues.
svn path=/trunk/; revision=66719
Make sure include/reactos/wine is included BEFORE PSDK headers. (I didn't tackle all DLLs, only those that (will) need it)
svn path=/trunk/; revision=66716
- Remove unneeded ChangeLog file (we have SVN)
- Partial wine resync of notepad (part 1/x): it's just to bring back some of their fixes and improvements. CORE-9371
svn path=/trunk/; revision=66712
CORE-8537 #resolve #comment Replaced the ASSERT by an informative message when the power action is not implemented. r66708.
svn path=/trunk/; revision=66708
Avoid redefinition of FILE_DEVICE_SMARTCARD in winsmcrd.h, when combined with wine/winioctl.h. A similar #ifdef exists in the MS header.
svn path=/trunk/; revision=66704
In WinMain, higher the scope of szFileName to ensure that it and all variables that point to it are valid
throughout the program.
Should fix CID 731447.
Patch by Ricardo Hanke
CORE-9360 #resolve
svn path=/trunk/; revision=66694
Add File search 6.8.1 to Database. Updates and German translation by me.
CORE-9338 #resolve #comment Added, thx for reporting.
svn path=/trunk/; revision=66691
lack of a proxy configuration by Peter Hater. German translation updated by me.
CORE-4852 #resolve #comment Committed, thx for help.
svn path=/trunk/; revision=66690
Initialize list entry after removing a message from DispatchingMessagesHead. Fixes list corruption.
CORE-9357 #resolve
svn path=/trunk/; revision=66685
- hardware ids must be terminated by 2 zero bytes
[KS]
- more fixes to software bus pnp enumerator
[MMIXER]
- dont assert on buggy topology lines
[NTOS]
- keys must be REG_OPTION_VOLATILE
- allocate file object with correct tag
[INF]
- register wdmaudio as pnp software device (not yet ready)
svn path=/trunk/; revision=66684
* Fix content type column to represent the correct type, or "Key". This column would contain the custom class name if it was ever assigned (I have not seen such a case).
* Implement reading registry values when enumerating details.
Now the registry browsing is semi-useful, albeit read-only.
svn path=/trunk/; revision=66676
* Replace the custom context menu classes with the default implementation from shell32. As a side-effect, navigation now works in ReactOS.
* Make use of the default implementations of IDataObject and IQueryAssociations from shell32 (required by the IContextMenu implementation of Win2003).
* Fix initialization of the NT Object Folder's pidl.
* Make CompareIDs recursive.
* Fix the recursivity in GetDisplayNameOf, when called with FORPARSING.
NOTE: There is still some issue with GetDisplayNameOf, where the address shown in the addressbar seems to skip path components.
svn path=/trunk/; revision=66674
- cpu.c: Convert the faulting address to "real" (VM) address before calling the exception handler.
- ems.c: Simplify code by using ARRAY_INDEX; some poiters should point to physical memory.
- ems.c: Memory hook addresses should be "real".
- memory.c: Remove an extra MemFastMoveMemory call; really use IsListEmpty (was commented by error in my previous commit).
svn path=/trunk/; revision=66671
- Move the VDD memory handler API prototypes to the corresponding DDK header.
- Fix few function arguments types and add few more comments :)
- Move all NTVDM-memory related functions to memory.c
- Prefer checking for !IsListEmpty(&list) instead of doing list.Flink != &list (ehh! NTVDM is not win32k!!)
svn path=/trunk/; revision=66669
- Implement VDDInstallMemoryHook and VDDDeInstallMemoryHook using page guards.
- Implement another API for memory hooks that should be faster than page guards
(for NTVDM only).
- Adjust the VGA and EMS memory handlers to use this method.
- In Fast486, implement a method that will allow us to "rewind" the current instruction,
in case it was interrupted by a memory hook page fault.
- Use a memory hook to protect the BIOS ROM from being written to.
svn path=/trunk/; revision=66666
- Implement NtUserResolveDesktop, which opens a desktop and a window station based on a desktop path string (format: "WinSta\Desktop").
- Move NtUserConsoleControl to a more suitable file, and implement the control code that allows CSRSS to assign console input threads to given desktops.
- Simplify a bit the code in NtUserSetInformationThread.
[CONSRV]
Turn the console input thread to a real one. There should be one such thread per desktop. When a console process is started, we open the desktop on which the process is going to start, we create a new input thread (attach it to the desktop) if needed, or reuse the existing one, and then we open the terminal on the correct desktop.
CORE-9346 #resolve #comment Fixed in revision 66662.
svn path=/trunk/; revision=66662
Don't set Message->DispatchingListEntry.Flink to NULL / compare against NULL, but use InitializeListHead and IsListEmpty. Make sure the list entry is properly initialize, when the item is removed Fixes list corruption.
svn path=/trunk/; revision=66661
- kernelspecs.h: Add IRQL level defines, remove a duplicate annotation and make some definitions more consistent
- concurrencysal.h: Add missing annotations (only dummies so far)
- driverspecs.h: Add some missing annotations
- sal_old.h: remove __inner_callback, which is in sal.h
svn path=/trunk/; revision=66654
Fix annotations for _dupenv_s and _wdupenv_s (They are broken in MS headers, looks like nobody uses attributes for SAL...)
svn path=/trunk/; revision=66653
Annotate mouse.c, move some prototypes to the proper location.
Fix bugs in EngSetPointerShape and IntEngSetPointerShape, where the passed in XLATEOBJ could be NULL. Found by MSVC static analyzer.
svn path=/trunk/; revision=66649
- Annotate eng/device.c and semaphor.c.
- Get rid of IntGdiAcquire/ReleaseSemaphore
- Move some prototypes where they belong
svn path=/trunk/; revision=66647
Fix all MSVC static analyzer warnings. (a few are suppressed after checking that it's ok)
Fixes a number of missing or wrong function return checks, wrong printf format specifiers and a few other things,
svn path=/trunk/; revision=66646
Move __analysis_assume to sal.h (like in newer Windows SDKs) and define it (together with _Analysis_assume_) to "((void)0)" instead of to nothing, to allow it to be used with a comma.
svn path=/trunk/; revision=66643
- Make NT_ASSERT() give the MSVC static analyzer a hint that the condition can now be excpected to be true. This adds __analysis_unreachable(), which uses __assume(0) on _PREFAST_ builds. This is neccessary, since it seems impossible to make MSVC respect __analysis_noreturn / __declspec(noreturn) on an intrinsic prototype like __int2c().
svn path=/trunk/; revision=66642
Update ntgdi.h:
- Change some return types from VOID to NTSTATUS. This was done recently on Windows, but there shouldn't be a compatibility issue with returning an NTSTATUS value instead of the random contents of the eax register.
- Change 2 parameters from VOID* to DRIVER_INFO_2W* and 2 parameters from VOID* to POINTL*
- Add annotations
svn path=/trunk/; revision=66641
- Pass size in bytes to UnsafeSetBitmapBits from NtGdiCreateBitmap
- In NtGdiSetBitmapBits check for stock bitmap and non-API bitmap.
svn path=/trunk/; revision=66616
- Remove wrong flags when initializing a DC
- Set DC::prgnattr before potentially passing it to the cleanup function after failure to create a handle. Add a comment that this is not actually enough. Will be fixed, once we use C++
- Increase GDI object stack levels to 20
svn path=/trunk/; revision=66615
Make sure a region is reasonably initialized, before potentially passing it to the cleanup function, when failing to create a handle.
svn path=/trunk/; revision=66614
NtGdiSetDIBitsToDeviceInternal: Check for ScanLines == 0 and clean up exit pathes. Fixes assertion failure in gdi32_winetest:bitmap
svn path=/trunk/; revision=66612
- Pass bitmap buffer size to SURFACE_AllocSurface and validate it
- Fix arithmetic overflow checks by using RtlULongMult
- GreExtTextOutW: do not allocate / blit zero sized bitmaps
- NtGdiStretchDIBitsInternal: do not pass negative y size to GreCreateBitmapEx
- DIB_CreateDIBSection: use calculated bitmap size, instead of biSizeImage when calculating the section view size and as size parameter to GreCreateBitmapEx
CORE-9245 #resolve
svn path=/trunk/; revision=66611
- revert an "improvement" in NtUserFindExistingCursorIcon
- Remove boken asserts
- Implement GreSetBitmapOwner and use it to set bitmap owner in IntSetCursorData
- Fix cleanup after failure in setting bitmap owner
- Fix string cleanup (don't free INTRESOURCE)
- Validate frame indices to be within range
- Make sure frame indices and JIR reates are copied
- A few other fixes/improvements
svn path=/trunk/; revision=66608
- fix multiple bugs in software bus pnp enumerator
[INF]
- add wdmaud.sys as a client of the software bus pnp enumerator
svn path=/trunk/; revision=66600
Add some missing intrinsics for GCC (_InterlockedExchangeAdd8, __incgsqword, _BitScanForward64, _BitScanReverse64, _bittest64, _bittestandset64, _bittestandreset64, _bittestandcomplement64, _rotr64, _lrotl, _lrotr, __lzcnt, __lzcnt16, __popcnt, __popcnt16, __lzcnt64, __popcnt64, __cpuidex, __ud2, __writecr8/__readcr8 (x86))
Remove useless top level const modifiers from parameters (they do only tell the compiler that the variable cannot be modified, they do not tell the compiler whether the parameter is a compiler constant!)
svn path=/trunk/; revision=66598
German update. No user cares about the number of colors at all. It always was called High/True Color and thus we do so too.
svn path=/trunk/; revision=66594
- Additional improvements by Ricardo Hanke, see CORE-8477 for all the details!
- Add support for play/pause button: now we change its icon and tooltip.
- Do not block when repeatedly change play/pause state.
svn path=/trunk/; revision=66593
- Few whitespace fixes.
- Fix a regression where an exception was thrown when opening a file from cdrom.
Patch by Ricardo Hanke.
CORE-9250 #resolve #comment Patch v2 committed! Thanks!
svn path=/trunk/; revision=66592
- Move all intrinsic prototypes to intrin.h and remove duplicated declatations from msc/intrin.h and mingw/intrin_x86.h
- Fix some intrinsic prototypes for GCC
- Fix some SAL annotations for intrinsics
svn path=/trunk/; revision=66573
- Remove leftovers from rbuild era.
- Remove .hgeol that was introduced in r53995 in an attempt to have Mercury "get[ing] native line endings":
<@hbelusca> tkreuzer - hi tkreuzer! do you know whether you still need this .hgeol file at the root of our source tree?
<@tkreuzer> hbelusca: no, feel free to delete it
- rgenstat/llmosrt.c --> llmsort.c (take it from cdmake); this is however an unused tool in our build toolchain.
svn path=/trunk/; revision=66570
No drive in media is not an error condition.
The hardware reporting no 'ghost' floppy drives like vmware don't show this trace.
svn path=/trunk/; revision=66569
Patch: Make it translatable and add German translation by Robert Naumann + fixed one typo by me.
CORE-9310 #resolve #comment Committed with one lil typo fixed, thx.
svn path=/trunk/; revision=66552
Rewrite NtUserSetCursorIconData
Fixes:
- Memory leaks
- Cursors left in an unpredictable / unhealthy state, including pointers to freed memory, when an operation failed
- Decision whether a cursor uses an ACON or CURSOR as the underlying structure based on user provided flags, instead of cursor flags, which were not even set in the first place.
- Allowing a usermode caller to corrupt the cusor structure, by converting an ACON with a smaller allocation size into a CURSOR
CORE-9301 #resolve
svn path=/trunk/; revision=66528
Get rid of our old cursoricon implementation. Rename cursoricon_new.c to cursoricon.c and remove all traces of NEW_CURSORICON
svn path=/trunk/; revision=66526
- Do not hardcode the length of the string arrays in the LoadString calls (use ARRAYSIZE instead)
- Localize the command prompt info line. CORE-9293 #resolve #comment I placed the string in the resource files so that you can now localize it!
svn path=/trunk/; revision=66518
- Finish a test run in the database when all tests have successfully been run. This got lost during the C++ rewrite of rosautotest in r40147.
- Don't spam the logs with useless OK messages. Only report the web service response if an error occurred.
svn path=/trunk/; revision=66516
- Always call MiniportISR if the interrupt is shared
- Call MiniportHandleInterrupt even if MiniportInitialize is running
- This commit and r66511 fix the Broadcom 57XX NIC (CORE-9295)
svn path=/trunk/; revision=66512
- Handle 64-bit PCI base address registers (BARs)
- Fix maximum address in resource requirements for 20-bit resources
- Fix flags on memory and I/O port resources
[NTOS]
- Fix handling of 64-bit resources
svn path=/trunk/; revision=66511
Add keyboard switcher to startup, per-user. Since we currently do not support expandable string values for shell run startup, just use a normal string. Also there's currently a bug in our explorer that makes the icon of kbswitch not appearing when it is launched at startup.
See CORE-6787 for more information.
svn path=/trunk/; revision=66508
LdrpInitializeProcess:
Don't use NtLdrEntry to initialize LdrpImageEntry.
It is overwritten afterwards to initialize the real NtLdrEntry.
svn path=/trunk/; revision=66505
- Implement __CxxFrameHandler3 as a wrapper around __CxxFrameHandler that translates VC8-style function exception descriptions to VC7-style. This is necessary to make C++ exceptions work on Windows Server 2003, because msvcrt!__CxxFrameHandler does not support VC8 descriptors there.
CORE-9290 #resolve
svn path=/trunk/; revision=66503
Update MSTSC with latest (1.8.3) rdesktop version.
Patch by 'hater', for more details see CORE-9013 #resolve #comment Committed, thanks!
svn path=/trunk/; revision=66502
[WIN32K]: Fix cursor check (in few corner cases SYSTEMCUR(ARROW) happens to be NULL, when some programs -- ole32 -- wants to create windows while there is no graphics initialized yet). James, can you investigate?
svn path=/trunk/; revision=66498
- Check the environment variable ROSAUTOTEST_DIR for an alternative path to the test executables. Otherwise use the default %windir%\bin
- Update the URL of the web service
svn path=/trunk/; revision=66481
Use the STRING(timestamp ...) command introduced in CMake 2.8.11 to get rid of our today macro and in particular the wmic dependency.
wmic requires administrator privileges on NT 5.x
svn path=/trunk/; revision=66480
- Add a test showing RtlUpcaseUnicodeString behavior with zero-length strings
- Run all test cases against FsRtlIsNameInExpressionTest on checked builds, only the Dbcs version asserts
CORE-9254
svn path=/trunk/; revision=66479
- Check for command line validity in some places.
- Correctly set the number of bitmap resources. Spotted by Thomas. CORE-6781
svn path=/trunk/; revision=66475
- Apply a different hack to make Jim happy.
- If you revert any of this and your changes break tests on Windows, I will revert your revert.
svn path=/trunk/; revision=66466
- Use a more standard name for the cursor position headless command structure.
- Remove the useless SysThreadCreated variable.
- Implement the remaining headless support in inbv functions, dealing with text colour (on windows, always set white text on black background). I added an extra feature (disabled by default) in case you want to get colourful headless support.
- Disable all code related to displaying different logos for different SKUs since up to now ReactOS doesn't have Storage or Cluster flavours, but keep it for reference in case somebody needs it. The resource IDs are still there.
- Disable all code related to rotating progress bar (à la XP) since it is not really implemented in ReactOS at the moment.
CORE-6781
svn path=/trunk/; revision=66461
wkssvc.idl: Add NetrWkstaUserGetInfo and NetrWkstaUserSetInfo definitions based on the Samba wkssvc.idl and MSDN.
[NETAPI32]
- Implement NetWkstaUserGetInfo and NetWkstaUserSetInfo.
- Add some debug output.
[WKSSVC]
Add NetrWkstaUserGetInfo and NetrWkstaUserSetInfo stubs.
CORE-9248
svn path=/trunk/; revision=66459
- button.c: Use NtUserAlterWindowStyle where wine uses WIN_SetStyle (usage and parameters were confirmed with windbg)
[NTUSER]
- Implement NtUserAlterWindowStyle.
Fixes remaining failures in user32:msg_controls test.
svn path=/trunk/; revision=66457
- Fix API GetDCEx tests! Dedicated to the great work by Timo Kreuzer.
- This uncovered a loop flaw, witch passed on any DCE last accessed.
svn path=/trunk/; revision=66452
- In MsgiUnicodeToAnsiMessage, use a single contiguous buffer for CREATESTRUCTA and its strings. This allows applications to modify the structure without ill effects
- Don't return the address of a stack structure in MsgiAnsiToUnicodeMessage
CORE-8777 #resolve
svn path=/trunk/; revision=66449
- Contrary to wine we store our version info with utf16 (like windows do). Fix checking for native internet explorer.
- Now our iexplore.inf is installed.
svn path=/trunk/; revision=66445
- Add IID_ITranslateShellChangeNotify, the answer to CORE-8844 - found by David
- Fix some non-constant offsets
- Re-alphabetize the lists
svn path=/trunk/; revision=66440
CORE-9248
Comment out NetGetJoinInformation and NetWkstaGetInfo in wksta.c and reimplement them as RPC client functions to the workstation service in wksta_new.c.
svn path=/trunk/; revision=66436
- Apply OffsetModuleName to the first import entry, not the current one in LdrpUpdateLoadCount3. Fixes missing reference updates on dependency-loaded DLLs.
CORE-5125 CORE-7127 #resolve
svn path=/trunk/; revision=66433
* Fix all the size calculations broken by r66425.
* Fix subfolder navigation (in windows).
* Fix enumeration skipping the last item.
* Add the beginning of a registry folder implementation. It doesn't display all data types yet, and it doesn't support editing or searching.
CORE-9244
svn path=/trunk/; revision=66426
- Fix headers.
- Fix MSVC warning C4200: nonstandard extension used : zero-sized array in struct/union.
[PSDK]
Fix MSVC warning C4200: nonstandard extension used : zero-sized array in struct/union. Note to Wine synchronizers and PSDK maintainers: those MIB* structures should go into a tcpmib.h header instead.
svn path=/trunk/; revision=66425
- Implement ILS_SATURATE in our image list implementation
- Use ILS_SATURATE when showing icons of disabled buttons in the toolbar
Patch Ismael Ferreras Morezuelas aka swyter
CORE-8916
svn path=/trunk/; revision=66418
[NBTSHELL]
[NTOBJSHEX]
* Fix prototypes of GetAttributesOf and GetUIObjectOf to conform with the specialized IDLIST subtypes.
[PSDK]
* Fix the declaration of PCITEMID_CHILD to make the "const" attribute affect the contents, and not the pointers themselves.
In preparation for whenever CORE-8441 happens.
svn path=/trunk/; revision=66414
- Rebar: paint the area that is not covered by the bands. This is a v6 feature and fixes the ugly non-painted rectangle in the taskbar.
svn path=/trunk/; revision=66402
- Revision string without the dash. That allows to possibly use a different separator.
- Just use the ROS revision number in the kernel SOS banner, instead of using a convoluted computation that overflows when the revision number is >= 65536. CORE-8877 #resolve #comment Fixed in r66398, thanks!
svn path=/trunk/; revision=66398
* Introduce a shell extension that allows the user to browse the NT Object namespace from within the shell.
CORE-9243 #resolve
svn path=/trunk/; revision=66396
- Load wallpapers using GDI+ and convert them to bitmap format as needed. We now support PNG and JPEG (and more) wallpapers! Patch by Ricardo Hanke, small modifications by me.
CORE-8802 #resolve
svn path=/trunk/; revision=66394
- BasepGetModuleHandleExW returns BOOLEAN, not NTSTATUS. Treat it as such.
- Always set last error code on failure in BasepGetModuleHandleExW.
CORE-9241 #resolve
svn path=/trunk/; revision=66382
- Mispelling + whitespace fixes.
- Move the finalization of the boot logo display *before* we enable strings to be displayed (as on Windows), but *after* having increased the progress bar to 100% (contrary to Windows), so that we can display the progress bar at 100% without any problem and then do the correct transition:
* either GUI splash-screen --> text-mode emulation console with product name in console header + footer (aka. SOS mode)
* or SOS mode --> text-mode emulation without any graphics.
Since it is done before starting SMSS, we can correctly display the strings it may output (or start other native apps) without fearing that after 5 seconds, the screen clears up in front of you.
CORE-9112 #resolve #comment Fixed in r66378, thanks for reporting!
svn path=/trunk/; revision=66378
CORE-3655 #comment Hackfix the fact that when being compiled with GCC on Linux, compiled messages have their endlines encoded with LF instead of with CR-LF as required by Windows compatibility. This should be normally fixed in windmc (the GCC/binutils message compiler); I've enough complained about that, but not directly to GCC/binutils team. Until they fix their tool, I ask SVN to always store the .mc files with CR-LF endlines. This should "fix" the problem. Suggestion by Thomas Faber.
svn path=/trunk/; revision=66376
Add back support for allocator stack backtraces for GDI objects and dump a list of BTs, when the GDI object table is exhausted. Disabled by default.
svn path=/trunk/; revision=66374
- In PspExitThread, correctly set the ZeroInit field of the message before calling LpcRequestPort (which would otherwise complain with STATUS_INVALID_PARAMETER and fail to send the message)
- In NtRegisterThreadTerminatePort, dereference the port object in case of failure, not a null pointer
CORE-9234 #resolve
svn path=/trunk/; revision=66369
- Add a test for process termination behavior. This shows that CreateProcess with CREATE_SUSPENDED followed by TerminateProcess causes a handle leak.
CORE-9234
svn path=/trunk/; revision=66367
- Make BaseSetLastNTError return the converted Win32 error code. This will determine the upper 24 bits of EAX in functions that return BOOLEAN FALSE right after calling BaseSetLastNTError, e.g. Wow64EnableWow64FsRedirection. Fixes installers using WiX Toolset (e.g. VS2012 redist) on MSVC builds.
See http://wixtoolset.org/issues/4681/ for the WiX bug that causes this.
CORE-8010
svn path=/trunk/; revision=66365
OK, Thomas had to convince me that MAX_USHORT + MAX_USHORT + 0x400 + 0x6 cannot overflow an ULONG.
So remove useless check.
By Thomas :-)
svn path=/trunk/; revision=66358
Don't pretend that ExceptionRecord.ExceptionInformation[2] is a pointer to a string in case of Delphi exception. This can lead to invalid pointer dereference in DbgPrint then.
For instance:
(../../dll/win32/kernel32/client/except.c:371) Delphi Exception at address: 50075885
(../../dll/win32/kernel32/client/except.c:372) Exception-Object: 00E885A8
(../../dll/win32/kernel32/client/except.c:373) Exception text: 2
svn path=/trunk/; revision=66354
- Fix packing for system restore point API types (STATEMGRSTATUS in particular). Fixes VC++ 2012 redist installer.
CORE-8010 #resolve
svn path=/trunk/; revision=66352
- Add some simple tests for RtlRaiseStatus to the RtlException test
- Add missing volatile in (disabled) stack overflow test that caused an infinite loop on GCC builds
CORE-8773
svn path=/trunk/; revision=66351
- Refactor EnumFontFamilies test to be more generic, and check for some common expected system fonts. This shows that EnumFontFamilies behaves correctly, but that we're missing the System font in the enumeration.
CORE-9222
svn path=/trunk/; revision=66347
- Reject bits data early in SetBitmapBits when it's clear that they can't fit in the destination bitmap.
Fixes ugly Office 2007 rulers showing garbage.
svn path=/trunk/; revision=66342
- Do not free resources at process termination.
- Free the provider catalog after the handle table, since the latter references the former.
svn path=/trunk/; revision=66337
- Do not merge memory blocks if they don't belong to the same VM "region" (ie not allocated from the same NtAllocateVirtualMemory call)
Fixes failures of ZwProtectVirtualMemory calls.
Bugs see DPH rollin', they hatin'
svn path=/trunk/; revision=66336
- MiIsEntireRangeCommitted: Ensure the PTE we are checking is really faulted in.
- Prefer MiPteToPde and MiPdeToPte (which should really be called MiFirstPteInPde) instead of MiAddressToPte and MiPteToAddress
Fixes weird failed ASSERT in page fault handler when using DPH.
svn path=/trunk/; revision=66334
- Load default application icon and display it in the taskbar for windows that have no icon. Fixes "GetIconInfo failed" debug prints all over the place (and looks prettier).
CORE-9211 #resolve
svn path=/trunk/; revision=66333
- Fix wine msg test_SetFocus tests. Use send message for WM_WINDOWPOSCHANGING. If nothing has been drawn and the no position changed bits set, set no Z order and no redraw. See CORE-7447.
svn path=/trunk/; revision=66332
- Add /n option to suppress console output. May or may not help to speed up testbot runs, but can't hurt to have in here.
svn path=/trunk/; revision=66318
- Abstract unidirectional anonymous pipes into a CPipe class
- Abstract a process with redirected output into a CPipedProcess class
- Use these abstractions to avoid polling for output from test processes. Instead, use blocking read operations to yield the CPU while waiting for data.
ROSTESTS-144 #resolve
svn path=/trunk/; revision=66316
- Sync to Wine 1.7.36
- Properly disable test_dib_formats. ROSTESTS-152, CORE-5922
- Fix skip message in test_mono_bitmap not to point to a resolved bug. ROSTESTS-153, CORE-5922
- Re-enable font tests that were left skipped even though the associated bug is correctly marked as resolved. ROSTESTS-8
svn path=/trunk/; revision=66312
- Fix wine msg:test_winevents.
- Fix global hooks while sending to same process different thread. Yes, interesting.
- Fix event hooks, use posting (faster) instead of sending. This fixed a problem while sending to the same thread.
svn path=/trunk/; revision=66310
NtQueryInformationFile: Implement FileAccessInformation and FileAlignmentInformation cases according to 'File System Internals' page 485.
svn path=/trunk/; revision=66307
- Part 2/2 of SrvLogon (see r66303): load the per-user shutdown timeouts.
- Retrieve those per-user shutdown timeouts from the registry when the user logs on, adapted from Alex' shutdown patch plus existing code.
- Commit the main part of shutdown code (finally!), still unfinished yet:
* Need to switch to the desktop where the hanging GUI app's window is present,
* Need to deal with apps from other users
* What about SYSTEM processes?
* What about console processes?
- Reuse the old timeout code.
- Fix the sending of WM_QUERYENDSESSION and WM_ENDSESSION messages (this is done by win32k directly; for that winsrv needs just to send one WM_CLIENTSHUTDOWN message with the correct wParam parameter).
Part 13/X
CORE-8322 #comment Big commit in revision 66306!
svn path=/trunk/; revision=66306
- In ExpReleaseOrWaitForKeyedEvent, always restore previous values for ETHREAD::KeyedWaitValue and ETHREAD::KeyedWaitChain, as these fields have alternative meanings outside of keyed events
- Add missing list walk in ExpReleaseOrWaitForKeyedEvent
- In Nt(WaitFor|Release)KeyedEvent, refuse keys that are not two-byte aligned as shown by Wine tests
- Don't forget to set KTHREAD::Process on thread creation
Fixes hang when running ntdll_winetest:om as well as failing tests.
ROSTESTS-118 #resolve
svn path=/trunk/; revision=66304
- Skip over service timeout tests because they take too long. This is not a bug, the tests are completing successfully -- however they are designed to cause service manager timeouts and take two minutes in doing so. Testbot time is too valuable to do this on every commit.
ROSTESTS-151
svn path=/trunk/; revision=66302
- Request only the access rights that are actually required in openTcpFile. Fixes many should-be access denied errors originating from netshell. While this doesn't fix the root cause of CORE-9172, it is a required step if we ever want netshell to work for non-Admin users.
CORE-9172
svn path=/trunk/; revision=66300
Add a stub for the "Windows Management Infrastructure" service.
This helps the Intel PRO eth card installer to go a bit farther
svn path=/trunk/; revision=66295
- Add KmtGetSystemRoutineAddress and use it to avoid importing functions that are not available in some versions of Windows. This allows running kmtests on Windows XP SP3 (and probably Server 2003 SP0/SP2). Note that failures on XP are still not valid bugs, this is purely for convenience! Dedicated to Jérôme.
ROSTESTS-150
svn path=/trunk/; revision=66281
Fix the explanations of how Windows/ReactOS should shut down (it's winlogon itself that calls NtShutdownSystem, not something else; that story about "SMSS API #1" concerns the SMSS API SmpSessionCompleteApi called by the helper function SmSessionComplete which is in turn called by CSRSS function CsrDereferenceNtSession, when all win32 processes are gone, as it should).
The webpage http://www.reactos.org/wiki/ShutdownProcess should be corrected for.
[USER32]
Whitespace fixes for winstation code.
svn path=/trunk/; revision=66275
Demote the "HACK: RemainingAccess = 0x%08lx DesiredAccess = 0x%08lx\n" from DPRINT1 to DPRINT, since it's massively spamming the log.
See CORE-9184
svn path=/trunk/; revision=66274
In NtGdiGetDIBitsInternal limit the size of what is being copied back to to usermode to the cjMaxInfo parameter. Fixes crash of Firefox when downloading files.
CORE-8895 #resolve
svn path=/trunk/; revision=66273
- magic_value--;
- Don't assign a desktop background colour by default. So that we can get the safe-mode background working (in safe mode), while having the default desktop background colours in normal situations.
Patch by Giannis.
svn path=/trunk/; revision=66271
Add #ifdef include guards to winnt.h. RC doesn't seem to support #pragma once and emits a redefinition warning, since with RC we first include winnt.h without STRICT defined, then again from windef.h with STRICT defined.
svn path=/trunk/; revision=66267
- Disable warning C4800: forcing value to bool 'true' or 'false' (performance warning). This is emitted when assigning an integer value to a C++ bool, which is always true (1) or false (0), so assigning an integer to it, will result in an implicit comparison against 0. But "fixing" this warning by adding an explicit comparison ("bool f = (i != 0);") will actually result in LESS efficient code (for whatever reasons). So this warning can be considered entirely useless and counter productive.
- Remove C4018 (signed/unsigned mismatch) from the TODO in the disable list. A comparison between an unsigned and a signed value will very likely result in wrong behavior and can easily cause hard to spot security bugs (e.g. when doing overflow checks). It is also often easy to fix.
svn path=/trunk/; revision=66266
NtfsMoonWalkID():
- Do not allow opening a file by ID if it's not in use any longer
- Do not attempt to create the full path, if an error occured during walk
svn path=/trunk/; revision=66265
Simplify the implementation of the "Open by ID" feature of our driver.
Instead of creating singleton FCB not linked to the rest of FS tree, just walk the whole path down, to recreate it.
This doesn't make nfi work properly though. Will investigate more.
CORE-8725
svn path=/trunk/; revision=66264
- Copy libwinpthread-1.dll if present instead of forcing the use of a specific set of GnuTLS binaries. Partially reverts r66110. Should fix testbot problems (mshtml_winetest:events in particular).
CORE-9167
svn path=/trunk/; revision=66257
Add the missing loop iterator in GetAdaptersAddresses().
This fixes infinite loop, and fixes Firefox 3.6 boot.
CORE-9051 #resolve #comment Fixed in r66253
svn path=/trunk/; revision=66253
- Reshuffle a bit some code.
- Never fail if the kill-COM-processes thread fails to be created.
- WlxLogoff GINA callback *must* be called *after* our logoff handling (with HandleLogoff). This is what happens on Windows (just add breakpoints on ExitWindowsEx and on WlxIsLogoffOk and WlxLogoff, and enable winlogon tracing).
[WIN32K]
Rename a flag to something more meaningful, and fix a flag filtering bug: lParams = wParam & something; ---> lParams = lParam & something; (the wParam is used for something else).
Part 12/X
CORE-8322
svn path=/trunk/; revision=66252
Add support for "module groups". These are meta targets that automatically include all targets using set_module_type() that are included between start_module_group(name) and end_module_group().
svn path=/trunk/; revision=66250
- Use a real timer for caret. This should cleanup message testing from those random system timer messages. See CORE-7447.
svn path=/trunk/; revision=66244
- Assert sanity of object reference counts in UserReferenceObject, UserDereferenceObject and UserDeleteObject. If you hit a cLockObj < 0x10000 assertion failure, you found yourself a use after free (RtlFreeHeap will put a LIST_ENTRY in this location, so a freed item has a kernel pointer there).
See CORE-8703 for an example.
svn path=/trunk/; revision=66243
- Implement KillComProcesses that just kills with force and without any notification back to winlogon, any remaining app that is still alive even if we asked before to kill apps (it's just the aim of this function, not more).
- Fix internal flags according to WinDbg sessions with Win2k3 + tracing checked build winlogon (testing logoff/shutdown/reboot from winlogon itself and when using the "shutdown" command).
- FIXME: Manage EWX_FORCE flag in winlogon...
[WINSRV]
Fix a DPRINT.
[WIN32K]
- Introduce a NotifyLogon function to manage winlogon notifications (when we shutdown and "end" shutdown steps, or cancel it).
- Fix some flags settings.
Part 11/X
CORE-8322
-------
This is a test:
!error !rot13 !reebe !ebg13 !error !rot13 !reebe !ebg13
svn path=/trunk/; revision=66240
- Fix the results from the new API CreateWindowEx tests. Message sequence and isolating each job Destroy and Free perform will come later. Refer to CORE-8703. This may not fix the crash while in wine test User32:msg.c.
- Dedicated to Thomas Faber.
- Fix build window list using threads. The link list works okay for locking but for tracking thread windows, use the snapshot method.
svn path=/trunk/; revision=66234
Partly sync find_value() with MESA 10.4.4. Fixes endless loop when GoogleEarth is started. GoogleEarth now loads and displays the earth, but it doesn't handle any input and makes the entire GUI hang.
svn path=/trunk/; revision=66232
- Handle the case where we have a masked ROP, but no mask surface in EngBitBlt
- Alloc ROPs with a mask in EngPaint
Fixes ASSERT when GoogleEarth is launched.
svn path=/trunk/; revision=66229
Improve naming of some BRUSH fields and set the correct fields to the correct values (ulStyle was not for the brush style, but the hatch style!)
svn path=/trunk/; revision=66227
- Show a confirmation dialog when emptying the recycle bin. Patch by Robert Naumann, with some modifications by me.
CORE-9006 #resolve
svn path=/trunk/; revision=66222
Sync all languages with the once more not synced English one... Every language has a different state and no one sees that if the new strings are not added in there. At least add the English original. Thx for understanding.
DIALOG -> DIALOGEX
svn path=/trunk/; revision=66214
- In ICO_ExtractIconExW, don't try to return two icons if only one was requested. Fixes stack corruption.
CORE-9142 #resolve
svn path=/trunk/; revision=66210
- Add additional list entry checks that can be optionally enabled by defining EXTRA_KERNEL_LIST_ENTRY_CHECKS. These checks warn against attempts to remove items from an empty list, which can easily be an error (and is trivial to avoid where it's not).
- Enable these checks by default for ReactOS code
CORE-8419 #resolve
svn path=/trunk/; revision=66208
- Add list entry security checks equivalent to those in current WDKs. This is useful for ROS because it detects memory corruption very quickly.
CORE-8419
svn path=/trunk/; revision=66206
- Support NO_PRIVATE_WARNINGS parameter when invoking spec2def to suppress warnings about symbols that should be private
- Disable such warnings for msxml3, ole32 and rsaenh
CORE-8445
svn path=/trunk/; revision=66200
- Add DPRINTs to monitor how shutdown goes on (obviously they will go away when shutdown on ROS will be working).
- Add dumb handler for LN_LOGOFF_CANCELED message (unused for now...)
[WIN32K]: DPRINTs added for monitoring shutdown.
[WINSRV]: Start to plugin the whole thing (using pieces of Alex' shutdown patch):
- We need to use a "shutdown" loop (for UserThreadInitiateShutdown win32k call) for being able to cancel shuts down (not implemented yet).
- Add the "magic" call to CsrShutdownProcesses that calls the Shutdown callback of each CSR server for each Win32 process (these are those callbacks that do the real job of terminating the apps, displaying the "Kill the app" dialog, etc...). In few words, the old (disabled) code of InternalExitReactos need to go into those shutdown callbacks (but this is for other commits!).
Part 9/X
CORE-8322 #comment Continue plugging in the shutdown code (from Alex' patch) in WINSRV with adaptations into WINLOGON (+ adding DPRINTs for controlling the whole thing).
svn path=/trunk/; revision=66197
Fix the ROP code passed to IntEngStretchBlt from NtGdiStretchDIBitsInternal. Fixes crash of Nimbus Notes installer.
CORE-9048 #resolve
svn path=/trunk/; revision=66195
Move the shutdown privilege check from winlogon to win32k (function "UserInitiateShutdown") as it should be done.
[WIN32K]
- Introduce the pair of UserInitiateShutdown/UserEndShutdown calls that should be called when WINSRV starts a shutdown (and when it finishes it). In particular it is in UserInitiateShutdown that we need to check whether the caller has the rights to perform a shutdown (it should also have a valid window station).
- Remove the ROS-specific TWOPARAM_ROUTINE_EXITREACTOS call that is traded for Win2k3-compatible call to UserInitiateShutdown.
[WINSRV]
Hackfix our current ExitWindowsEx functionality (based on a patch by Alex made against r46050 for win32csr) to make it "compatible" with the improvements in win32k: impersonate the caller and call the UserInitiateShutdown win32k system call (instead of the TWOPARAM_ROUTINE_EXITREACTOS). More will come later on.
[USER32]
Win32k can require performing shutdown in an asynchronous way (needed also on WINSRV side) so we need to put all the code in a worker thread.
Part 8/X (part 6 was r65693 and part 7 was r66186).
CORE-8322 #comment Start to add Alex' win32csr shutdown patch in WINSRV; fixes for winlogon and additions to win32k.
svn path=/trunk/; revision=66192
- Get rid of IDD_FILE_COPY dialog. It was never used, never completed and windows don't really have such a dialog.
- Remove SHShowFileOperationDialog which was never completed. This will be replaced shortly with a working solution by Huw Davies
svn path=/trunk/; revision=66190
- Sync Combo to wine head. Patch by Huw Davies : Make the combo's listbox a topmost window. See CORE-5186 for prior report.
svn path=/trunk/; revision=66183
- Patch by Piotr Caban : Only store dialog focus when window is hidden or inactive. Only use DIALOGINFO-> hwndFocus to store last focus of inactive windows.
svn path=/trunk/; revision=66182
- For now, only activate custom ReactOS boot on non-x86 builds.
- Fix INI section item list initialization before using it! Fixes custom ReactOS boots (ie. remove an invalid heap free). Now custom ReactOS boots work!
svn path=/trunk/; revision=66179
- Fix registry value retrieval with RegGetValue (RRF_RT_REG_EXPAND_SZ has a non-obvious functioning: it should be used with NO_EXPAND flag. Otherwise use RRF_RT_REG_SZ to retrieve REG_SZ values, or REG_EXPAND_SZ values with automatic expansion as expected). CORE-9001 #resolve #comment Fixed, thanks for reporting!
- Fix whitespace.
svn path=/trunk/; revision=66178
- Return timeout if the count and wait time is zero. This is a wine hack and fixes two related mgs:test_MsgWait* tests. Attempt to fix CORE-9117. Not sure if MsgWaitForMultipleObjects is the problem.
svn path=/trunk/; revision=66175
Load NtGdiFlushUserBatch dynamically to allow loading on Win 2003, where the function does not exist.
ROSTESTS-131 #resolve
svn path=/trunk/; revision=66172
- Setup system cursors and icons. Could help with Themes.
- Set default cursor to the message queue structure.
- Fix wine cursor icon tests. Fix ATI cursor passing issue.
- Fix that sticky mouse cursor while the screen saver is on.
- Move cursor code from User32 and shake that pop up window too.
- Setup for window station security checking.
- Dedicated to the great work by Jérôme Gardou. Doing ones best to preserve his original code!
svn path=/trunk/; revision=66166
- Warn about symbols that should be private. Patch by Thomas Faber. CORE-8445 #resolve #comment Committed in revision 66165. It's also nice/useful to get the warnings even if we are not generating an import lib (example when building rsaenh): MSVC warns also in this case.
- Improve error messages.
- some_ptr = 0; ---> use NULL instead.
- remove useless extra parentheses.
svn path=/trunk/; revision=66165
Build the Open-File filter mask in runtime, according to the supported extensions and media devices registered in the registry.
Patch by Ricardo Hanke.
CORE-7883 #resolve #comment Committed, with number-of-chars vs. number-of-bytes fixes by me, plus minor modification to build the filter only once when mplay32 is launched, and use a default filter if runtime filter build fails.
svn path=/trunk/; revision=66152
SeAssignSecurityEx: Add support for SEF_DEFAULT_OWNER_FROM_PARENT and SEF_DEFAULT_GROUP_FROM_PARENT.
This fixes several kmtest:SeInheritance bugs.
svn path=/trunk/; revision=66148
- Code style changes (whitespace + C-style comments).
- Move reactos/registry to windows/ since it's only for booting windows-like OSes that registry functions are used.
- ARC hw support functions first move (i.e. another code refactoring will happen) outside of reactos/ (since they are used generally, not just for ReactOS loading).
- ARC name outside of reactos/
- Delete now-useless reactos/ subdirectory.
svn path=/trunk/; revision=66145
- Fix date format in CHANGELOG (that uses that #$@! of US format)
- Diverse code style changes (whitespace, extra braces, C++ to C-style comments, ...)
svn path=/trunk/; revision=66144
Add keyed event access mask values and use them in the keyed event object implementation.
This fixes another kmtest:ObTypes bug.
svn path=/trunk/; revision=66139
- Whitespace files.
- Add missing PSEH inclusion (that can be detected if one comments the objbase.h include in rtl.h ...)
[MKHIVE]
Code cleanup + add a comment to explain what this ntoskrnl.h file is.
svn path=/trunk/; revision=66138
Show a critical error if txtsetup.sif cannot be found, instead of displaying empty fields in the setup. Patch by Lee Schroeder.
CORE-8971 #resolve #comment Fixed, thanks!
svn path=/trunk/; revision=66107
- Fix misusage of the hash-table. CORE-9098 #resolve #comment Fixed in revision 66100!
- Really fix date for files and directories when CDs are generated on Windows. Use UTC time everywhere. Simplify code.
svn path=/trunk/; revision=66100
Increase number of static memory descriptors from 32 to 40.
CORE-9097 #resolve #comment Please retest and reopen if it's still not fixed.
svn path=/trunk/; revision=66099
- Provide an editable file for the start menu banner just like we had for explorer-old
- Use the same font that's used for the ReactOS logo
svn path=/trunk/; revision=66095
Fix major bug in EngModifySurface: when pvScan0 and lDelta are passed, the surface is converted to type STYPE_BITMAP. pvBits is calculated accordingly and surface flags are updated according to flSurface parameter. Fixes crash with Intel 810 graphic drivers. Thanks to Julio Carchi for testing/helping with debugging. CORE-7821 #resolve
svn path=/trunk/; revision=66094
Fix ROP operation by ANDing the result with the appropriate dest mask, for all required ROPs). Fixes MaskBlt tests.
svn path=/branches/dib_rewrite/; revision=60905
[GDI32] "Fix" behavior of SetDIBitsToDevice, based on how (broken) Windows actually behaves
All tests for SetDIBitsToDevice now pass, except one, but this seems to be an Mm problem (looks like we commit ridiculously large user mode stacks instead of growing them on demand)
svn path=/branches/dib_rewrite/; revision=60788
[WIN32K] Improve EngBitBlt and EndCopyBits to properly handle device managed surfaces and support RLE compression.
svn path=/branches/dib_rewrite/; revision=59550
- Many changes and bugfixes to the new DIB code
It's in a usable state now, also working with the new diblib. Still lots of bugs and failures need to be fixed.
svn path=/branches/dib_rewrite/; revision=57078
- Mark bitmap as API bitmap in NtGdiCreateDIBSection
- Mark palette as DIB section palette in NtGdiCreateDIBSection
- Set biXPelsPerMeter to 0 instead of using the bitmap dimentions
- Check BITMAPINFO parameters in GreGetDIBits
- Handle case when requested bit depth doesn't match actual one in GreGetDIBits
- Use maximum BITMAPINFO size in NtGdiGetDIBitsInternal
- Verify header size in NtGdiGetDIBitsInternal
- Misc code improvements
svn path=/branches/dib_rewrite/; revision=56593
Implement DC_bIsBitmapCompatible, which checks if a bitmap can be used with the DC in SelectBitmap or GetDIBits
svn path=/branches/dib_rewrite/; revision=56591
- Fix RGB vs BGR mistake in SURFACE_iCompression
- Return the number of copied scanlines in GreGetDIBits
- Fix calculation of destination address in GreGetDIBits
svn path=/branches/dib_rewrite/; revision=56565
IDS_STRING_LICENSE "Această aplicație este publică; fiind permisă modificarea și/sau (re)distribuția sa în termenii Licenței Publice Generale GNU publicată de Free Software Foundation; sau versiunea 2 a Licenței, sau (la alegere) a oricărei versiuni ulterioare.\r\n\r\nAceastă aplicație este distribuită doar în speranța de a fi utilă, FĂRĂ însă NICI O GARANȚIE; nici măcar cu garanția implicită a VANDABILITĂȚII sau a UTILITĂȚII ÎNTR-UN SCOP ANUME. Pentru mai multe detalii consultați Licența Publică Generală GNU.\r\n\r\nPuteți vedea această licență aici:\r\nhttp://www.gnu.org/licenses/gpl.html\r\n\r\nDe asemenea puteți consulta traduceri neoficiale ale acestei licențe aici:\r\nhttp://www.gnu.org/licenses/translations.html"
Some files were not shown because too many files have changed in this diff
Show More
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.