[BOOTLIB]: When failing to find a block device, keep going searching for more, instead of giving up (critical, because the CDROM FAT12 image is now device path #1, not #0).
[BOOTMGR]: Correctly use the right logical operator in EfiInitpGetDeviceNode to get the deepest-level media device node. We now get the CDROM node, not the raw node.
[CDMAKE]: Don't actually create an EFI/BOOT directory on the CDROM itself, but rather in the FAT12 image. Otherwise, this can confuse UEFI implementations to boot the boot manager off the raw CDROM, instead of the FAT12 image on the CDROM.
svn path=/trunk/; revision=70542
[BOOTLIB]: Additional text and graphics console support. Among other things, we have now gained the ability to fill a buffer with a particular color.
[BOOTLIB]: OEM Bitmap (ACPI 5!) support.
[BOOTMGR]: Continue making a few more initialization calls now that bootlib supports more functionality.
svn path=/trunk/; revision=70539
Update the registry configuration to reflect the recent changes to rosvboxmgmt.
Just uncomment the line matching the behavior you prefer.
CORE-10032
ROSAPPS-303
svn path=/trunk/; revision=70537
Introduce another automagic thing. Instead of creating shortlinks once shared folders have been enumerated, just assign them a drive letter!
See it in action: https://twitter.com/HeisSpiter/status/685229912748371968
Choose the one you prefer for 0.4.0 :-)
CORE-10032
ROSAPPS-303
svn path=/trunk/; revision=70536
- Reenable RTL_QUERY_REGISTRY_DELETE: the "PendingFileRenameOperations(2)" and "AllowProtectedRenames" registry values are deleted after being parsed: we don't retry at every reboot to remove/rename files that were already deleted/renamed.
- Remove superfluous parentheses.
- Warn a FIXME if SFC-protected file renames are allowed and we are processing file renames (the "protected file renames" stuff is unimplemented atm.)
svn path=/trunk/; revision=70530
- Use CRT string functions to loop through multi-strings.
- Do not fail the full KnownDll setup if one dll fails to load. Instead, just properly skip the file (and related to that, fix a bug when skipping excluded known dll files).
- Page files should be created only when we are not in WinPE mode (aka. MiniNTBoot = FALSE).
- Formatting fix in smloop.c, no code change.
svn path=/trunk/; revision=70529
- Add support for opening ICO, EMF, TIF and WMF files with the shell image viewer since it already implements what is needed (via gdiplus).
- Add some missing "Content Type" (MIME type) and "PerceivedType" values for the image extensions.
[SHIMGVW]
- Enable the resource strings for EMF, TIF and WMF files since we actually support them.
Should be merged for 0.4 branch.
svn path=/trunk/; revision=70528
- Implement support for manifest prober routine in LdrpWalkImportDescriptor, in its simplest way
- Implement such routine in kernel32 (that's mostly a copy of Wine's create_module_activation_context which seems to nicely correspond to what Windows does).
- As create_module_activation_context is moved into kernel32, delete it from ntdll
- Improve debug output in RTL's Activation Context implementation to ease debugging
- Now, ReactOS indeed looks for and actually loads manifests when loading modules. Thanks to http://blog.tombowles.me.uk/2009/10/05/winsxs/ for a really good description of how activation contexts work
CORE-7313
svn path=/trunk/; revision=70522
[BOOTLIB]: Fix incorrect use of flag introduced a few revisions ago. This fixes <1MB RAM descriptors.
[BOOTLIB]: Enable BmFwMemoryInitialize, since it works now.
All (known) bugs are fixed, bootmgr is back on track.
svn path=/trunk/; revision=70516
[BOOTLIB]: Fix two big device I/O bugs (it's a miracle it worked)
[BOOTLIB]: Use defined constants and comment some more device I/O code.
svn path=/trunk/; revision=70515
[BOOTLIB]: Add a bunch more graphical console support functions.
[BOOTLIB]: Cleanup some older graphics-related code.
[BOOTLIB]: Support graphics re-initialization. We now correctly fallback to text mode since font loading is not implemented.
svn path=/trunk/; revision=70514
Improve the bootvid font generator of Colin (see r70507) in many ways:
- Allow the user to specify the font name (optional), and optionally a font size and x- and y-offset so that (s)he doesn't have to recompile the generator each time (s)he wants to test a new font.
- The default settings (in case the user doesn't specify all or part of the font definition) are those of Windows' bootvid font (i.e. "Lucida Console", font size 10, x_offset = y_offset = 0).
- Create only once the DC and the font handle (to be used for all the generated characters) instead of each time a character is being generated. I still keep the recreation of the HBITMAP for each character (I don't know if we can also improve there by creating it once and zeroing it out before generating each character).
svn path=/trunk/; revision=70512
Add a commented out way to automatically start `rosvboxmgmt auto' on start so that shortcuts for VBox shared folders are properly created.
This is to be enabled on 0.4.0.
CORE-10032
ROSAPPS-303
svn path=/trunk/; revision=70510
Change the Blue Screen Font hardcoded into bootvid.dll to the Open Source "Anonymous Pro" font, which makes a nice 8x13 font.
Blue Screens now look like this: http://fs5.directupload.net/images/160106/ehv6245t.png
[BOOTVID_FONT_GENERATOR]
In case you find an even better font, you now have a nice little tool to test that font and generate the corresponding FontData array for bootvid.
svn path=/trunk/; revision=70507
[BOOTLIB]: Add mostly full support for resource and locale management.
[BOOTLIB]: Stub out bootstat.dat (Boot Status Data Log) support.
[BOOTLIB]: Some refactoring.
[BOOTMGFW]: Add a message table with a few initial strings. Also add an empty bootmgr.xsl stylesheet. We'll have to see what we want/need to do here.
[BOOTMGFW]: Correctly loading HTML and message table resource data, and add a few other additional initialization calls.
Next steps are to re-visit graphics code to support re-initialization.
svn path=/trunk/; revision=70504
Add a new feature to the tool:
Let it auto start VBox Shared folders and to browse all the available shares in order to create shell links on desktop.
The purpose is to workaround the missing network shares discovery feature in ReactOS while keeping the VBox shared folders usage 'user-friendly'.
It has been designed specifically for the coming 0.4.0 release: just put it on autostart for the default user. If there are shares (even new ones), it will create links, if there are no shares, no guest additions, no VBox, it will just exit.
See it in action: https://twitter.com/HeisSpiter/status/684506579555741696
CORE-10032
ROSAPPS-303
svn path=/trunk/; revision=70500
- Use the LockQueueIoDatabaseLock spinlock to guard the device list instead of blindly raising the IRQL
- Add missing lock to IopEditDeviceList
svn path=/trunk/; revision=70496
- Fix a bug in FltpDetachFromFileSystemDevice so it correctly bails when we've walked the attached device list.
- FltpDispatch can come in at high IRQL. Thanks to Thomas for noticing that err.
- Add newlines to the end of DPRINTS (it's been a while...)
- The filter now loads and runs in the reactos FS stack.
svn path=/trunk/; revision=70495
[BOOTLIB]: Implement routines to enumerate subkeys and to read a key value.
[BOOTLIB]: Implement routines to parse, enumerate, and convert registry data into BCD elements, and to convert BCD elements into boot library BCD options.
[BOOTLIB/BOOTMGFW]: Lots of cleanups, mainly around the fact we now use ntintsafe.h instead of the manually self-inlined code from before, and from documenting additional flag values, and from using our newfound BCD powers.
[BOOTMGFW]: Implement BmGetOptionList, BmpUpdateApplicationOptions.
[BOOTMGFW]: Prepare for post-BCD library reinitialization. We correctly read the 3 BCD options so far in the hive.
svn path=/trunk/; revision=70492
- Plug in the dispatch routines. These are just pass through methods for now to get the filter up and running.
- Implement the FastIo handlers. The majority of these call the FastIo routines of the attached device object.
- Make sure we detach from devices that are being deleted in FastIoDetachDevice.
- Move the FastIoDetachDevice routine to a deferred call as it's too expensive to tie up a FastIo request.
svn path=/trunk/; revision=70488
Fix the fix from r70482: Our DIBs are actually 32 bit aligned, so pass even uncompressed bits to GreCreateBitmapEx instead of copying them later with wrong alignment.
svn path=/trunk/; revision=70486
NtGdiCreateDIBitmapInternal: clear CBM_INIT flag, if no bits are given.
IntSetDIBits: Always calculate the bitmap size for uncompressed bitmaps, do not pass uncompressed bits to GreCreateBitmapEx, since they don't have the required alignment (the width in bytes for DIB is 16 bit aligned, bitmaps 32).
Remove a broken ASSERT.
svn path=/trunk/; revision=70482
Implement LsarStorePrivateData and LsarRetrievePrivateData.
[ADVAPI32]
Implement LsaRetrievePrivateData and LsaStorePrivateData.
Encryption of secrets (aka private data) is NOT implemented yet!
svn path=/trunk/; revision=70479
Factorize the code that creates ReactOS freeldr.ini entries, and use it to create a freeldr.ini at a clean ReactOS installation, and when it is installed in the same partition as Win9x/DOS.
CORE-4870 #comment Should be fixed with revision 70467, please retest.
svn path=/trunk/; revision=70467
Properly check the bitmap size in IntSetDIBits, taking into account that it might be set to 0, then we have to calculate it ourselves. Fixes a crash when invalid data is passed to NtGdiCreateDIBitmapInternal.
[GDI32]
Convert COREINFOHEADER to BITMAPINFOHEADER before passing it to NtGdiCreateDIBitmapInternal, which doesn't support it.
CORE-10583 #resolve
svn path=/trunk/; revision=70464
Export NtUserGetClassInfoEx (as it's called in 2k3) both as NtUserGetClassInfo (as it's called on XP) and NtUserGetClassInfo. They have the same prototype.
svn path=/trunk/; revision=70463
- "Fix" an export name: NtUserGetClassInfoEx on 2k3 is the same as NtUserGetClassInfo on XP (note that we currently use the default, aka ros specific, win32kdll on the WHS testbot, but it's mostly identical.
[WIN32KNT_APITEST]
- Fix a typo
- add missing tests to testlist.c
svn path=/trunk/; revision=70462
- Convert win32k native api test to actual wine style api-tests
- Hack around a bit with the win32k dlls, some renaming, etc.
- Delete old apitest stuff
svn path=/trunk/; revision=70458
Don't use DATA and PRIVATE together. DATA means no stub function is generated in the import lib, PRIVATE means nothing is generated in the export lib.
svn path=/trunk/; revision=70454
Now, the fix: the FAT disk checker expected that the free cluster count member of the FAT32 FSInfo sector be really initialized (not to 0xFFFFFFFF), and it expected the presence of the backup of the FSInfo sector as well as the free sector following the FSInfo sector.
svn path=/trunk/; revision=70449
- DPRINT messages printed via VfatPrint by the check-disk procedure.
- Addendum to r70434 and r70435 : The return value of fs_close is equal to the number of corrections made on the disk (0 corrections --> success; 1+ --> something was corrected).
That way, the old code "return fs_close(FixErrors) ? STATUS_SUCCESS : STATUS_UNSUCCESSFUL;" that we had since eons (which always happened to return STATUS_SUCCESS) was actually
indicating to us that our FAT32-formatted volumes were corrupted.
If you test this revision, you should see something happening if you try to install ReactOS now (something that should have happened since ages actually).
svn path=/trunk/; revision=70447
- Formatting + RtlZero/FillMemory modifications as addendum to r70445.
- Do not hardcode FSInfo signature values, use instead the same set of macros fastfat_new introduces.
svn path=/trunk/; revision=70446
Fix handling of NULL buffer in streamout. Fixes a few msvcrt_crt_apitests, while it breaks a few for crtdll. crtdll is broken anyway and obsolete, nothing uses it, so it doesn't really matter.
CORE-9105 #resolve
svn path=/trunk/; revision=70443
It seems suspicious to directly return the value of fs_close as the NTSTATUS code of the check-disk operation (for FAT32 volumes it happens to return 1 whereas for FAT16 volumes it returns 0).
The documentation of this function says that it "returns a non-zero integer if the file system has been changed since the last fs_open, zero otherwise."
Maybe somebody has a more precise idea on that subject? In the meantime I also add some DPRINTs to attempt to diagnose the conditions where this problem occurs.
svn path=/trunk/; revision=70434
- Gather common code in one file instead of duplicating it everywhere.
- Implement full format for FAT12 and FAT16 (using the same function Fat1216WipeSectors), based on similar code for FAT32 implemented by Eric Kohl in revision 63693.
svn path=/trunk/; revision=70433
- fat.asm: remove trailing whitespace.
- fat32.asm: backport the fixes from fat32.S introduced a long time ago.
- fat32.S/faty.S: use .space 12, 0 instead of the long .byte array (generates the same code, but is better readable).
- isoboot/btrt: whitespace fix only.
svn path=/trunk/; revision=70432
Add another test for strlen, that tests, whether the direction flag in ELFAGS has been modified. While clearing it is legitimate to do according to the ABI, the native implementation does not change it, so we don't want to do it either.
svn path=/trunk/; revision=70429
- disable GCC builtins
- Add simple tests for strlen, showing that a NULL pointer will cause an access violation, which is broken in our asm implementation
svn path=/trunk/; revision=70427
[MSVCRT] Explicitly pull in _vsnprintf, bsearch and strcspn from CRT, to prevent the MS linker from exporting stubs from libntdll instead.
See CORE-10753
svn path=/trunk/; revision=70425
- Use the old fat.S source for compiling the FAT12 boot sector, until FATX.S is completely implemented.
- Fix an assembly error in FATX.S
- In comments I added experimental FAT12/16/32 targets based on Timo's FATX.S.
svn path=/trunk/; revision=70423
- Implement AbortSystemShutdownW by a call to BaseAbortSystemShutdown.
- Implement InitiateSystemShutdownW by a call to BaseInitiateSystemShutdown.
- Implement InitiateSystemShutdownExW by a call to BaseInitiateSystemShutdownEx.
- Add RPC binding code for the winreg server (in winlogon.exe).
svn path=/trunk/; revision=70420
SHUTDOWN: Fix the hack be calling InitiateSystemShutdownExW instead of ExitWindowsEx.
WINLOGON: Add a hack by calling ExitWindowsEx in BaseInitiateSystemShutdownEx.
svn path=/trunk/; revision=70419
Disable again the DR7 check until we correctly understand why bit 10 of DR7 (reserved) is almost always set (this lead to MSVC-built ReactOS crashing when being starting in non-debugging mode). See also r69244.
CORE-10165 #comment DR7 check again disabled in r70418.
svn path=/trunk/; revision=70418
For MSVC builds (using KDCOM kd64 WinDbg protocol): Bail out for droppable packets after a given number of retries, if no debugger is attached (list of droppable packets can be found in http://articles.sysprogs.org/kdvmware/kdcom.shtml section "KDCOM protocol", subsection "Droppable packets").
CORE-10541 #resolve #comment Finally fixed in revision r70417!
CORE-7106
svn path=/trunk/; revision=70417
Fix the value for EIP used by KDBG after an INT3 set by KDBG itself. The address is already fixed by KiDispatchException, but only in the context frame, not in the trap frame and KDBG insists to use the trap frame for a lot of things. Also, after a cont from such an int3, KDBG uses a single step to re-enable the breakpoint (it needs to disable it after it was hit to be able to execute the actual instruction), but it used to dismiss *any* single steps after that. So make sure, that an actual single step, as created by the debugger is not being dismissed, but the break point is still restored after the next single step entry. You might expect that a kernel debugger would at least support setting breakpoints, but this is KDBG.
svn path=/trunk/; revision=70416
- Change the start type to demand.
- Should stop free loader from throwing a tantrum because it can't load a non-existant boot driver
svn path=/trunk/; revision=70414
Correctly fix the definition of DRIVER_FS_NOTIFICATION (done the same way as the other DRIVER_xxx "callback" functions; by the way you'll notice they are all NTAPI aka. __stdcall. This is not explicitely mentioned in the W(D)DK, because MS supposes you compile all your kernel-mode code in stdcall convention, the WDK environment coming with preset default compiler switches enabling that. But if you try changing them, you'll run into big troubles. In our headers on the contrary we explicitely mention the calling conventions).
[FLTMGR]
Fix FltpFsNotification to adhere to the correct DRIVER_FS_NOTIFICATION definition.
Addendum to r70410.
svn path=/trunk/; revision=70413
Pass cjMaxBits parameter from GreCreateDIBitmapInternal to IntCreateDIBitmap and check the image size before creating the bitmap.
Should fix crash when hitting about tab in Office2000 WinWord.
CORE-10583 #comment please retest
svn path=/trunk/; revision=70412
- Add the beginning of the fltmgr. It's called rosfltmgr for now so I can test in Windows.
- It's currently just base code which registers for file systems appearing (or disappearing), and attaches itself to them and all other mounted devices in their chain.
- Although it builds (touch wood), don't add it to a running system. The IRPs aren't plugged in yet and it'll just bugcheck lower down the stack.
svn path=/trunk/; revision=70409
- Raise the IRQL when enumerating device lists so it doesn't get edited mid-listing
- Don't hardcode the pointer size when checking the buffer size
svn path=/trunk/; revision=70408
Save parameter registers (rcx, rdx) before calling CallRealMode. Patch by andy-123, applied to a secondary location by me.
CORE-10511 #resolve #comment Thanks. I added the same fix to PnpBiosGet below.
svn path=/trunk/; revision=70407
Hack, that fixes the "Volatile Environment" bug by deleting the "Volatile Environment" key before the user hive is unloaded.
CORE-10705
svn path=/trunk/; revision=70406
Do not use the "LoaderBlock->u.I386.CommonDataArea;" hack to use FreeLdr's DbgPrint function inside KDCOM, for the simple reason that while it works when KDCOM just initializes, the memory area where FreeLdr's DbgPrint function is, gets erased when ReactOS is running. As a result, all attempts to call the DbgPrint function when tracing something in KDCOM at the end of life of ReactOS, just fails lamentably (it hangs).
We therefore cannot rely on external code to provide us with DbgPrint. Instead, implement a very simple DbgPrint function inside KDCOM, as done by KDGDB.
The KD serial port serving for debugging KDCOM is chosen dynamically amongst the other free COM ports.
This needs to be also fixed in KDVM.
[KDGDB]
Instead of hardcoding the KD serial port number serving for debugging KDGDB, determine it dynamically amongst the other free COM ports.
svn path=/trunk/; revision=70405
- Allow to specify in freeldr.ini the debugging port parameters, similarly to what NTLDR allows to do: http://naesten.blogspot.fr/2010/07/undocumented-debug-section-in-bootini.html
- Update the FREELDR.INI example file to reflect these changes.
- Because some FreeLdr components, that need to be initialized before the debugging port parameters can be read from freeldr.ini, use debugging features, we still need to choose some default parameters. For serial ports, we select the possible port starting from COM4 down to COM1.
CORE-9023 #comment Revision 70403: Allow to specify a debugging port in freeldr.ini .
svn path=/trunk/; revision=70403
When the root item in the treeview is selected, remove all items from the listview and wipe the address bar and status bar.
svn path=/trunk/; revision=70402
- Improve implementation of RtlActivateActivationContextUnsafeFast / RtlDeactivateActivationContextUnsafeFast by replace magic numbers by flag values, which are already defined in rtltypes.h, and adding various debugging checks. Two of them are triggered for yet unknown reason:
* Assert in RtlActivateActivationContextUnsafeFast
* "Trying to activate already activated activation context"
They are commented out in trunk not to annoy everyone.
svn path=/trunk/; revision=70396
Initialize the defauls users locale settings based on the selected locale Id from first stage setup.
#CORE-5989 #resolve
svn path=/trunk/; revision=70389
Fix bugs in pen implementation:
- Do not use the x coordinate to adjust styles, instead they start where the lines start
- Don't leak allocated styles
- Make sure the PEN fields are initialized correctly, even for BRUSHES, so that the destructor can do it's cleanup work
- Fix numerous parameter checks
gdi32_apitest:pen now shows 0 failures!
svn path=/trunk/; revision=70388
- Add french translation (not complete, but enough for now: only what can be currently displayed is translated).
- Don't hardcode the "History" item in the travel-log, but use the localized string. Use the hardcoded string *only* if loading the translation failed.
svn path=/trunk/; revision=70376
Fix hebrew "registry editor" translation.
[SHORTCUTS.INF]
Fix regedit shortcut name (localize it instead of using "regedit")
svn path=/trunk/; revision=70373
Rewrite the two existing tests for ICMP and add a third one (for IPv6).
Patch by Tim Crawford.
ROSTESTS-212 #resolve #comment Commited in r70367. Thanks!
svn path=/trunk/; revision=70367
Surround welcome & debugging messages in #ifndef NDEBUG blocks, that should be compiled in trunk but will be disabled in the release.
This is to "cure" the bad-looking problem described in http://www.reactos.org/forum/viewtopic.php?f=25&t=14620 .
svn path=/trunk/; revision=70365
Apply patch by Mark Jansen (learn_more) with a few tweaks. Fixes calls to Shell_NotifyIconA such as those from VBoxTray.
CORE-10497 #resolve
svn path=/trunk/; revision=70360
- When cleaning the clipboard, cancel any pending delayed rendering and increment all the sequence&serial numbers.
- Fix the clipboard access check when performing a delay rendering. This fixes VBox host <-> guest copy/paste amongst others...
CORE-5512 CORE-9620
CORE-8367 CORE-8627 #comment Please retest with revision >= 70355.
svn path=/trunk/; revision=70355
- Reduce indentation level of some code.
- No need to initialize pWinStaObj when it is reinitialized just after.
- Fix some comments.
svn path=/trunk/; revision=70354
Fix the computation of where bitmap pixels start, depending on whether we are dealing with DIBs or DIBs version 5+ (depending on the header BITMAPINFOHEADER or BITMAPV5HEADER etc...).
I also noticed a bug in Windows that few other people already discovered, related to the automatic conversion of CF_DIBV5/CF_BITMAP to CF_DIB clipboard format. See the comment in the code.
CORE-10679
svn path=/trunk/; revision=70349
- Add support for scrolling with the mouse wheel, by Ricardo Hanke.
- No need to check for CloseClipboard failure & display an error message if the clipboard was successfully opened just before.
- Use ARRAYSIZE macro instead of hardcoding the length of available clipboard format list.
CORE-10679
svn path=/trunk/; revision=70347
* Implement AppBar docking (defaults to floating because we don't properly support AppBars yet -- works in Windows).
* Implement loading and saving the AppBar settings from the registry.
* Remove the minimize button from the options dialog.
CORE-10691
svn path=/trunk/; revision=70344
* GetGUIThreadInfo: When they said "foreground thread", they meant the one with the keyboard focus, not the currently running one.
NOTE: This needs verification, as I have no idea how to properly handle IntGetFocusMessageQueue() returning NULL.
[MAGNIFY]
* Make use of the new-found ability to call GetGUIThreadInfo with 0 as the threadId.
CORE-10691
svn path=/trunk/; revision=70338
* Use GetGUIThreadInfo instead of multiple separate "hacks" to obtain all the necessary data in one single call.
* Keep the off-screen DC for later use, and only recreate when needed.
* Restore caret follow back to default-on.
More changes toward CORE-10691
svn path=/trunk/; revision=70337
* Replace the menubar with a notification icon and context menu.
* Change the dialog button to "Ok" instead of "Exit" (applied to en-US and es-ES only, the translators will have to do the rest :P).
* Due to a rather bad problem presumably caused by AttachThreadInput, set the "Follow Caret" option to disabled by default. This can be re-enabled once the problem is fixed.
More changes toward CORE-10691
svn path=/trunk/; revision=70336
Some improvements to the drawing code:
* Draw as soon as the mouse/caret/focus changes, or after 100ms if nothing changed.
* Copy only the needed area of the screen into the internal buffer.
* Blank out the area of the buffer where the client region of the magnifier overlaps, to avoid re-zooming the pixels.
* Keep the source region contained within the closest monitor, instead of only the primary one.
* Invert colors when copying from the screen, instead of when stretching, since there's less pixels to draw.
First step toward the improvements described in CORE-10691
svn path=/trunk/; revision=70335
- Adjust the type of some variables.
- Correctly set the fClipboardChanged flag to TRUE when emptying the clipboard: now this correctly triggers sending the WM_DRAWCLIPBOARD message to windows. Adapted from a patch by Ricardo Hanke.
CORE-10351
svn path=/trunk/; revision=70334
Handle WM_PALETTECHANGED and WM_QUERYNEWPALETTE: realizes any palette found on the clipboard, if there is any, if it receives one of those messages.
svn path=/trunk/; revision=70329
- Display the application icon in program's about dialog.
- Add missing DT_NOPREFIX flag to DrawText() calls.
- Let ShowLastWin32Error() show an error message even if the last error code is zero.
- Remove the calls to OpenClipboard() and CloseClipboard() from the functions in winutils.c and let the caller open and close the clipboard instead.
Patch by Ricardo Hanke
CORE-10657
svn path=/trunk/; revision=70328
Check RtlCreateUnicodeString in SetupCreateSingleDirectory.
Patch by Victor Martinez.
CORE-10647 #resolve #comment Thanks a lot!
svn path=/trunk/; revision=70321
- Don't disable the user profile creation hack until it's actually fixed (NtUnloadKey(NULL) doesn't do anything and I don't know what's actually supposed to go there). Should avoid some user profile corruption after crashes in 3rd stage (since 2nd stage will have flushed the registry).
CORE-10381
svn path=/trunk/; revision=70320
- Don't go past the scroll range
- Reset the grid/cell info when a new font is selected
- Should fix some of the issues Vort listed in CORE-10518
svn path=/trunk/; revision=70319
Remove do { } while (0) constructs from PSEH3 macros, so that a break from within a try block does what it is supposed to do.
svn path=/trunk/; revision=70316
- Fix setting the correct font in certain code paths
- non-eisting glyphs should return 0xffff, not 0x001f
- Don't set last error on failure, GDI APIs don't do that
- Remove GreGetGlyphIndicesW, it was mostly a copy of NtGdiGetGlyphIndicesW and it wasn't used
- Fixes the GetGlyphIndices tests and fixes showing invalid fonts in charmap
svn path=/trunk/; revision=70315
- Don't take a reference on the device object in ScsiClassClaimDevice since it's not going to be released before device removal. Inspired by classpnp. Fixes ejecting mass storage devices.
CORE-8911 #resolve
svn path=/trunk/; revision=70310
- Get rid of the global SetupData variable. Allocate the setup data struct from heap instead and pass its pointer to all wizard pages.
- Keep the setup data pointer in all wizard pages where it is needed.
- Keep the handle to the unattended.inf file open as long as the setup wizard exists.
svn path=/trunk/; revision=70309
Properly return unicast addresses in GetAdaptersAddresses() by properly return a struct sockaddr_in.
This fixes a bunch of failing tests in iphlpapi_apitest, and it should fix any application relying on this API to know interfaces addresses.
svn path=/trunk/; revision=70292
Add another check that shows that data returned by GetAdaptersAddresses() are incomplete and thus broken...
"This isn't the type you're looking for." would say an old man
svn path=/trunk/; revision=70290
Arrange large and small icons after changing the view.
Patch by Carlo Bramini.
#CORE-10350 #resolve #comment Thanks a lot!
svn path=/trunk/; revision=70288
Little Improvements:
* Duplicate code removement regarding the simple list pages (and now everyone has pageup/down + selection via char)
* Duplicate code removement regarding the partition type string
* Document the pages
Patch my Michael Fritscher
#CORE-10012 #resolve #comment Thanks a lot!
svn path=/trunk/; revision=70283
DispTdiQueryIpHwAddress(): use the correct function to get the interface associated with an IP address.
Also, because local links aren't in the ARP table (obviously), handle them without the mechanism described previously
This fixes arpinging oneself.
svn path=/trunk/; revision=70277
- Fix a bug IRPFinish(): do not touch the IRP if there's a pending return. Thanks to Thomas for his help!
- Implement DispTdiQueryIpHwAddress(): the current implementation is not optimal, but works. It first reset the ARP table entry corresponding the to target host, if it exists. Then, it sends the ARP probe and wait till the ARP table is updated to return the HW link address.
Could be improved, but it would require more important work in the driver, which is not a good solution when we're to release ;-).
Obviously, this fixes arping not working in ReactOS: https://twitter.com/HeisSpiter/status/673088515647930368
And this fixes a few iphlpapi_apitest tests.
svn path=/trunk/; revision=70269
Implement client-side only of console font APIs:
- documented: GetConsoleFontSize, GetCurrentConsoleFont;
- undocumented: GetConsoleFontInfo, GetNumberOfConsoleFonts, SetConsoleFont (see http://cboard.cprogramming.com/windows-programming/102187-console-font-size.html for a working usage example of these APIs).
(Also related to CORE-7931)
svn path=/trunk/; revision=70258
"add Everything Search Engine to ReactOS downloader" by Alexander Rechitskiy
(Silently remove some BOMs I created...)
CORE-8309 #resolve #comment Added, thx ^^
svn path=/trunk/; revision=70250
rapps-database does not update automatically because of broken build scripts by reactosfanboy
CORE-10633 #resolve #comment Fixed by removing the copies completely and updating the ones in rapps. Not the best solution, but it works for the update task.
svn path=/trunk/; revision=70249
Fix DLL control themeing by Jared Smudde
CORE-10563 #resolve #comment Hm, yeah, you are right. Somehow I really forgot that one when I did that manifest fun in the past ^^ Thx
svn path=/trunk/; revision=70245
Add/Update Traditional Chinese (zh-TW) translation in ReactOS. [Wave 2/4] by Henry Tang Ih
CORE-10615 #resolve #comment Committed, thx ^^
svn path=/trunk/; revision=70242
Update RosBE version to 2.1.3 by Hermes Belusca
CORE-10603 #resolve #comment Fixed. Does not work in ROS anyway, but fixed ^^
svn path=/trunk/; revision=70239
Missing italian translations in ReactOS by Carlo Bramini
CORE-9725 #comment Applied/Committed lautus and services patches
svn path=/trunk/; revision=70238
- Hackfix the existing charmap for the 0.4 release (just in case I don't get time to finish the new one). This fixes showing invalid glyphs and also removes the advanced section as it was unimplemented.
svn path=/trunk/; revision=70228
- Add support for canonical/string verbs when using CMINVOKECOMMANDINFO. This fixes switching views and adding a new folder when using the button in the common dialogs. This really needs to go in a CDefFolderMenu class (which likely inherits the context menu class), but we don't use that design.
- Partially implement CDefaultContextMenu::GetCommandString 'while I was there' It's completely untested though.
CORE-10089
svn path=/trunk/; revision=70215
Implement an arping tool. Some portions of code are just plain copy/paste from ping tool code (booh, it's bad!).
It was designed and tested on W2K3.
It's in RosApps for two major reasons: such a tool doesn't exist by default in Windows 2K3.
And it doesn't work in ReactOS.
svn path=/trunk/; revision=70212
Add a new apitest for iphlpapi.dll.
It includes tests for testing the SendARP() and its underlying IOCTL.
Tested against W2K3.
Obviously, most of these tests fail on ReactOS.
svn path=/trunk/; revision=70210
- Properly acquire process rundown
- Reference job object when assigning a process to it
- Don't assert when creating a child process whose parent is in a job
Fixes crashes in kernel32_winetest:process
svn path=/trunk/; revision=70177
- Don't cache IFilterMapper2 interface in FilterGraph2. Fixes use after free when playing videos with MPC HC.
- Fix a reference leak
CORE-7671
svn path=/trunk/; revision=70118
- Allow the dialog to be resized, which in turn will grow / shrink the grid view and the fonts inside it. This means users can make the grid larger if they don't have their glasses on or want to see all the fonts in more detail. We no longer need a large font window popping out from the grid when you click on a cell (which I was never a fan of).
- Don't allow scrolling previous to row 0 or after the last row
svn path=/trunk/; revision=70101
- Implement drawing fonts onto the gridview
- Implement scrolling through the grid via the scrollbar
- When a new font is selected, setup that font for drawing. This includes setting up the DC for painting, getting the valid glyphs for that font (this fixes the bug in the existing viewer which has lots of squares for glyphs), setting up scrollbar info, etc.
- Make the cell object more responsible for its own painting
CORE-10518
svn path=/trunk/; revision=70098
- Use the correct attributes when overwriting a read-only file in cabinet_copy_file. Will be sent upstream after the 1.8 release.
CORE-10534 #resolve
svn path=/trunk/; revision=70095
- Patch by Bruno Jesus : Don't add scroll bars to mdiclient if the window style doesn't allow it. This fixes wine bug 9435.
- Patch by Alex Henrie : Avoid double initialization. Use the window class icon if the MDI child doesn't have its own.
- Patch by Michael Stefaniuc : IDI_WINLOGO is already an int resource (PVS-Studio).
- Patch by Frédéric Delanoy : Use BOOL type where appropriate.
- Wine sync port.
svn path=/trunk/; revision=70068
- Return the unique ID from BaseSrvGetTempFile instead of an NTSTATUS. Fixes GetTempFile when using kernel32.dll from Windows.
svn path=/trunk/; revision=70038
GetDriveTypeW: Use neither CreateFileW nor InternalOpenDirW to open the drive, because both functions call SetLastError upon failure. This can cause failing checks in lines 23, 44 and 59 of the kernel32_apitest:GetDriveType test. Use NtOpenFile instead.
svn path=/trunk/; revision=70037
- Implement TCPSendIoctl() to issue IOCTLs to network stack. We should use global handles to \Device\Ip & such, but as iphlpapi doesn't have such feature yet, a hack is here to workaround.
- Implement SendARP() using the TCPSendIoctl() function. So far, it doesn't work, as tcpip.sys is missing appropriate code path.
svn path=/trunk/; revision=70025
-Enable some controls that shouldn't be disabled -> Spotted by Jared
-Yesterday I heard the whispered word "alphabet", correctly order file/fuction names
svn path=/trunk/; revision=70001
- Add document icon to wordpad.
[SHELL32]
- Add FriendlyTypeName support to HCR_MapTypeToValueW as well.
- Sync HCR_GetClassNameA ReactOS additions into HCR_GetClassNameW.
[NOTEPAD][SHIMGVW]
- Add localized FriendlyTypeName file type strings.
[SHELL32][HIVECLS]
Update the FriendlyTypeName file type strings.
This commit is an addendum to revision range r32966-r32969 and r32973.
svn path=/trunk/; revision=69999
- Patch by Alexandre Julliard : Add workaround for removed SC_TASKLIST system menu item. Word 95 assumes that the item exists.
- Wine sync port.
svn path=/trunk/; revision=69959
GetAdapters: Don't stop looking for the dns servers if an interface hasn't an entry.
This is not an error condtion, the loopback doesn't have one.
svn path=/trunk/; revision=69944
-Update some resource IDs to match with Win2k3
-Comment and reorder the resources for better overview
Part 3/3 CORE-10030
svn path=/trunk/; revision=69940
- Acquire the PEB lock before reading Peb->ProcessParameters->Environment in RtlQueryEnvironmentVariable_U. Patch by Mark Jansen.
CORE-10381
svn path=/trunk/; revision=69939
- Fix MB_GetString: the input parameter is the ID of the button string to be retrieved, ranging from 0 to 10 inclusive (this corresponds to the IDOK ... IDCONTINUE range, minus one).
- Add the missing "Close" button string.
svn path=/trunk/; revision=69937
MessageBoxIndirect fixes by Carlo Bramini:
- Implemented loading of text and caption if they are detected as resource IDs.
- Use direct resource string pointers with LoadStringW and use the returned string length.
- Dramatically improve the implementation of ID and resource string assignments, by using a little look up table. This removes some ugly, difficult to maintain copy-paste code.
- Fix the scaling of logical coordinates by making it aware of rounding, i.e. the size of the controls is now calculated correctly.
CORE-10352 #resolve #comment Thank you for the patch! :D
svn path=/trunk/; revision=69935
- Start to implement the charmap required for the 0.4 release
- We now have a basic dialog with the grid in place
CORE-10518
svn path=/trunk/; revision=69931
NetWkstaGetInfo: Retrieve the primary domain name instead of the account domain name as the workgroup/domain name. System CPL shows the proper workgroup name.
svn path=/trunk/; revision=69927
- Initialize DeviceRelations->Count in FdoQueryBusRelations
- Don't fake success for unsupported PNP minor functions, it makes the kernel very unhappy
Powered by Special Pool
svn path=/trunk/; revision=69900
- Addendum to r69867: free device info pointer at the end of acpi_bus_add to avoid use after free.
Powered by Special Pool
svn path=/trunk/; revision=69899
VfatGetAllInformation: Return as much information as possible, but do not fail if the name string does not fit into the buffer.
svn path=/trunk/; revision=69891
- Change SetDIBitsToDeviceFromClipboard to correctly use the requested format instead of always using CF_DIBV5
- Enable/Disable the menu point "Save as..." dynamically
- Remove unneeded import libraries
- Add WS_EX_ACCEPTFILES window style and handle WM_DROPFILES
- Add some defines and structures for handling clipboard files (work in progress)
- Add Open and Save dialogs
Patch by Ricardo Hanke. CORE-10520
svn path=/trunk/; revision=69890
- Add a test verifying that opening a file using different parent directories still yields handles to the same file
CORE-10483
svn path=/trunk/; revision=69877
- CDefView: When we have to flicker don't use the worst possible color to erase the window but the background color of the list view. At least now some flickering will go unnoticed.
svn path=/trunk/; revision=69873
- Remove the HPET hack, which is finally no longer needed (presumably thanks to the ACPI_ACQUIRE_GLOBAL_LOCK/ACPI_RELEASE_GLOBAL_LOCK fixes).
CORE-10509
svn path=/trunk/; revision=69872
- Update to version 20141107
- Get rid of the ROS diffs in actypes.h by making use of the new ACPI_USE_SYSTEM_INTTYPES define
svn path=/trunk/; revision=69866
- Fix GCC versions of ACPI_ACQUIRE_GLOBAL_LOCK/ACPI_RELEASE_GLOBAL_LOCK. It now generates the same code as the original
CORE-10509
svn path=/trunk/; revision=69863
- Apply the same fix as r69849, but for the Forward tooltip. Also it would be nice to use ATL strings to retrieve the resources & not hardcoding an extra NULL character inside the resource string.
- Add a missing string resource in romanian RC file.
svn path=/trunk/; revision=69850
-Fix blurry icons.
-Make the icons sharper and clearer in all size.
-Modified the design of some icons.
-Brand new Fax icons!
-Remove unneeded icon sizes
Things I have changed from the original patch:
-Fix 2 copypasta and 1 double definition errors
-Changed the icon back to the floppy one in folders.cpp and drvdefext.cpp because this would have resulted an a regression for floppy drives
svn path=/trunk/; revision=69847
- GetAllUsersProfileDirectoryW: Fail if lpcchSize is NULL.
- GetDefaultUserProfileDirectoryW: Fail if lpcchSize is NULL.
- GetUserProfileDirectoryW: Fail if hToken is NULL.
svn path=/trunk/; revision=69841
Start factoring out all code related to console-specific stuff (while leaving everything else in place). This is WIP (and the corresponding .c files are included where they are needed instead of being compiled, will be fixed later).
svn path=/trunk/; revision=69838
- GetProfilesDirectoryA: In case of success, return the length of the profiles directory.
- GetProfilesDirectoryW: Set ERROR_INSUFFICIENT_BUFFER, if lpProfilesDir is NULL.
svn path=/trunk/; revision=69837
CreateEnvironmentBlock: Set or overwrite the SystemRoot, SystemDrive and USERPROFILE environment variables of the new environment block.
svn path=/trunk/; revision=69834
- Simplify and restructure thread send messages, use look aside list, message signals and global message link for sorting trouble messages.
- See CORE-9210 for more information. Related to and fixed CORE-9718 and CORE-9975. Could have fixed CORE-9695.
svn path=/trunk/; revision=69793
- IEnumString::Next's pceltFetched parameter is not optional, so provide it. Fixes exception when using Emerge Desktop
svn path=/trunk/; revision=69792
Fix GetAdaptersAdresses operational status.
ReactOS is now seen online.
CORE-9178 #resolve
Please retest apps with connectivity problems.
svn path=/trunk/; revision=69791
Only scale characters with the world-to-device transform, when the graphics mode is GM_ADVANCED. Fixes Petzold's WhatSize testapp.
CORE-7154 #resolve
svn path=/trunk/; revision=69782
Adds a simple CLIP utility, as found on Windows, to ReactOS.
Like the Windows version, it can just redirect the output of another console program or a file to the clipboard.
By Ricardo Hanke, with minor corrections by me.
CORE-10411
svn path=/trunk/; revision=69775
Fix a nasty copypasta bug: When the DC brush was selected into a DC, it was painted with the pen color instead of the brush color. Should fix Snappy Driver installer and potentially a lot of other graphical issues.
CORE-9424 #resolve
svn path=/trunk/; revision=69774
- Return the appropriate status code when encountering file system corruption
- When encountering corruption, print a message by default instead of breaking into the debugger
svn path=/trunk/; revision=69768
- Reimplement the SYSTEM.INI/WIN.INI tabs (they should be seen as 2 different instances of the same window; this would be cleaner to do in C++) with all the expected functionality working.
- Add TreeView helpers for moving/deleting branches.
- Add TreeView helpers for 3-state checkboxes, with support for Windows 2k3 and Vista+ with and without manifest, depending on the comctl32.dll version used by msconfig at runtime. In particular, take advantage of the TVS_EX_PARTIALCHECKBOXES extended style introduced on Windows Vista+.
- Just initialize once the uxtheme function pointers.
- Create the msconfig dialog box hidden and center it on screen before showing it (removes the flickering caused by the quick move).
- Use the correct 16x16 icon for the dialog title icon, adapted from a patch by Jared Smudde with suggestions by Ismael Ferreras Morezuelas.
CORE-9333
svn path=/trunk/; revision=69761
Check the size of RLE bitmaps, while decompressing. Fixes possible buffer overrun.
Patch by Kamil Hornicek
CORE-8735 #resolve
svn path=/trunk/; revision=69760
Restore saved DCs, when changing the DC owner. Otherwise there could be saved DCs with references to process owned resources, causing GDI object leaks.
Fixes assertion when closing iWisoft Video Converter
Also don't copy lSaveDepth and hdcSafe in DC_vCopyState, those must be handled manually.
CORE-10435 #resolve
svn path=/trunk/; revision=69759
Fix COMCTL32_VERSION definition.
[COMCTL32]
The comctl32 we currently have in trunk cannot pretend to be version 6+ (it was currently reporting version 6.82, aka something for Windows 20? ) Fix it and make it report 5.82 instead.
CORE-10457
svn path=/trunk/; revision=69755
Comment out for now in MCB the assert hit when attempting to write on an extX volume.
Aleksey, could you have a look at it?
CORE-10407 #comment Can you retry with r69750?
svn path=/trunk/; revision=69750
Improve the oplocks stubs:
- Always return success when FsRtlCheckOplock() is called: we deny oplock creation at FsRtlOplockFsctrl(), so the oplocks can only be fine.
- Always return TRUE when FsRtlOplockIsFastIoPossible() is called: we deny oplock creation at FsRtlOplockFsctrl(), so no oplock can prevent fastio from happening.
This enables (for real :-)) write support in extX FSD. Not 100% perfect though, as it hits an assert in MCB (but that's yet another story).
Full implementation to come later on.
CORE-10407
CORE-10442
svn path=/trunk/; revision=69742
- Initialize SepRmDbLock and create the system and anonymous logon sessions in Phase 0, right before the system process token is created.
- Implement functions to reference and dereference a logon session.
- Reference a logon session in SepCreateToken and SepDuplicateToken.
- Dereference a logon session in SepDeleteToken.
svn path=/trunk/; revision=69735
- Do not always print the usage when an error occurs. Print it only when a syntactic error happens.
- FAT volume labels are constituted of 11 chars (not 8!) which should be printable ASCII (in particular, >= 0x20) and in uppercase.
svn path=/trunk/; revision=69732
- Properly parse SymbolicLinkName (in particular, don't assume it's null-terminated) in IoSetDeviceInterface. Fixes IoDeviceInterface test failures and subsequent crashes due to memory corruption
CORE-9456
svn path=/trunk/; revision=69729
- Explicitely use UNICODE versions of OpenSCManager and OpenService.
- When OpenSCManager or OpenService fail, they return a NULL handle (not INVALID_HANDLE_VALUE).
svn path=/trunk/; revision=69719
- Port the Services page in C++ and implement hide/show MS/ReactOS services & enable/disable. WIP.
- Fix resource ID for the "delete" button in the FreeLdr page.
- Revert the freeldr "advanced" dialog that I erroneously removed in r69638.
CORE-9333
svn path=/trunk/; revision=69717
- Move the message typedefs into a shared header file.
- Implement LsapRmCreateLogonSession and LsapRmDeleteLogonSession. Call LsapRmCreateLogonSession in LsapCreateLogonSession.
svn path=/trunk/; revision=69714
- Remove a few todo comments that are now completed. Also remove numbers to make it simpler to remove one entry from the todo list.
svn path=/trunk/; revision=69713
- Implement CompareIDs for the folders in the shell namespace. The previous implementation was a generic solution that just compared names.
- CDefView: Implement using CompareIDs method from the IShellFolder. Remove the previous implementation that was hardcoded in the CDefView and worked mostly for file items.
svn path=/trunk/; revision=69712
- co_UserCreateWindowEx: Fail when a wrong handle was passed for the parent window. "Fixes" a crash down the road due to missing null checks in other places (null checks are needed because desktop windows don't have parents).
svn path=/trunk/; revision=69709
- Fix exception specifier (Ged or Thomas, can you double-check those please? :) )
- ATL can be used in code not using the C++11 standard aka. fix build when double '>' characters are present, for example in template<foo bar<stuff>> .
svn path=/trunk/; revision=69702
- Flush the CPU instruction cache after the ATL window proc thunk code is patched into memory.
- Implement some (not all) CAtlList methods that I will need later on.
- Implement some (not all) CStringT and CSimpleStringT methods & operators that I will need later on.
svn path=/trunk/; revision=69701
- Add the SRM code from Timos kernel-fun branch.
- Move its lsasrv code to a separate file.
Thank you very much, Timo!
svn path=/trunk/; revision=69697
Import missing parameters for Ext2 driver.
This fixes extX volumes being only available in read-only on ReactOS.
CORE-10272 #comment Fixed with r69686
svn path=/trunk/; revision=69686
Fix NTDLL implementation of mbstowcs() and wcstombs() so that they return length in caracters and not in bytes.
This fixes last failing *to* CRT apitests
CORE-10390
svn path=/trunk/; revision=69683
Import _mbstowcs_l() from Wine and call it in mbstowcs().
This fixes crashes when calling the msvcrt, crtdll implementation of mbstowcs() with no output string.
Thus, it fixes a few crashing apitests
The NTDLL version is still broken in some way, need to investigate why.
CORE-10390 #resolve #comment Fixed with 69682. Thanks for the report!
svn path=/trunk/; revision=69682
- In UserAttachThreadInput, copy the CaretInfo structure instead of saving a pointer that may be freed right after
CORE-10395 #resolve
svn path=/trunk/; revision=69677
- Force all refreshes to go through the CDeviceManager method instead of calling CDeviceView directly.
- Fixes missing checked radio item in the view menu on startup
svn path=/trunk/; revision=69659
- When refreshing the view, reselect and expand the previously selected node in the tree. This allows to switch from 'by type' to 'by connection' and see where the selected device sits in the tree hierarchy (and vice versa)
svn path=/trunk/; revision=69658
- Automatically refresh the view whenever there is a hardware change on the machine
- Don't force a refresh when we enable/disable devices, this is now be picked up automatically
svn path=/trunk/; revision=69649
- Add DoDeleteAsync method that takes the data object and the fMask parameter from IContextMenu in order to distinguish if we need a permanent delete.
- CDefView: Properly add CMIC_MASK_SHIFT_DOWN and CMIC_MASK_CONTROL_DOWN flags when calling Invoke.
- CDefaultContextMenu: use DoDeleteAsync and pass fmask so as to make Shift+Delete shortcut to permanently delete files.
Note: GetKeyState sometimes returns wrong results but this doesn't concern the shell.
CORE-4365
svn path=/trunk/; revision=69647
- Fix pool leak in failure case (CID 1322140) and don't treat NTSTATUS values as Win32 errors in NtGdiGetGlyphIndicesW.
svn path=/trunk/; revision=69641
- Reenable the FREELDR.INI/BOOT.INI page. When boot items are added in the list, recompute its new contents width and adjust it so that we can horizontally scroll its contents (this is the only common control which does not support automatic width computation when you add contents in it...).
- Save the original FREELDR.INI/BOOT.INI in a default path (I took the one used by windows' msconfig for its INI files).
CORE-9333
svn path=/trunk/; revision=69638
- Implement the "file extract" dialog and enable it in the general page. The extraction functionality proper will be implemented later on.
- Remove an unneeded resource string.
CORE-9333
svn path=/trunk/; revision=69632
- Enable the specstrings.h in shlwapi header (since we have it)
- Add missing BIF_SHAREABLE define (which exists in the 2k3 PSDK), even if it's not used at all in our code (and in wine either); I use it in msconfig for a shell browse dialog (because I want it to behave as I expect also on windows).
svn path=/trunk/; revision=69631
- Add some file utility functions, they will be used later for managing the startup programs.
- Half-plement the general page controls.
- Simplify some code; fix file headers; remove the old toolspage.c (replaced by its c++ equivalent).
CORE-9333
svn path=/trunk/; revision=69630
- Sanitize allocation lifetime and fix memory leaks in ScmConvertToBootPathName. CID 1102363
- Fix leak in failure case of REnumServicesStatusExA. CID 716334
svn path=/trunk/; revision=69629
- Patch by Joachim Priesner : Hide horizontal Listbox scroll bar if no horizontal extent is set. See CORE-1101.
- Patch by Alex Henrie : Simplify if-else statement. Scroll listbox item completely into view on LB_SETCURSEL.
svn path=/trunk/; revision=69625
- Patch by Dmitry Timoshkov : Always call BeginPaint/EndPaint when handling a WM_PAINT message for the button.
- Patch by Alex Henrie : Remove always-false condition.
svn path=/trunk/; revision=69624
- Add missing shlobj.h changes from the previous commit
- Correctly define ITEMIDLIST types, and add initial support for STRICT_TYPED_ITEMIDS
CORE-8441 #resolve
svn path=/trunk/; revision=69621
- Fixup a few missing languages. Hopefully I got them all this time.
- Add a new line to the end of the resources to keep msvc happy
svn path=/trunk/; revision=69617
- Implement updating the device from the toolbar
- Add a message before uninstalling a device. Dedicated to Jared Smudde.
svn path=/trunk/; revision=69614
- GlobalMemoryStatusEx: Correctly compute ullTotalPageFile which should be in bytes, instead of in number of pages. Patch by contributor "kkat". CORE-10361
- GlobalMemoryStatusEx: Fail if the stored length in the data buffer is not what is expected by the API (required by the spec, see MSDN; on the contrary, GlobalMemoryStatus does not require that.)
- GlobalMemoryStatus: Correctly round up the reported total/available memory values, in case they are bigger than ~= 2GB.
svn path=/trunk/; revision=69608
- Fix duplicated resources.
- Implement the Tools tab. It reads the list of available tools (and their localized names & description) from an internal XML file. It can also load an external user-defined XML list of tools; see KB906569 for a description of what it is.
- XML stuff is implemented using COM. It is far easier to use COM with C++ than with C, hence the tools tab code and the XML parser are compiled as C++ whereas everything else is compiled in C. Therefore at the moment msconfig is hybrid C/C++; this is done using CMake magic.
CORE-9333
svn path=/trunk/; revision=69604
Don't keep spining forever in CcRosFlushDirtyPages() when flushing a dirty VACB fails on a RO volume.
This can be triggered with extX volumes and can prevent shutdown from succeeding
svn path=/trunk/; revision=69602
Modify the script to take into account that now, host-tools are no longer required.
Because it needs RosBE 2.1.2 (update guys!) still provide a fallback method to allow using old build method with host-tools. In case you need it, just call configure.sh with-host-tools
svn path=/trunk/; revision=69601
- Reserve some more space for ntdll so that we're compatible with Windows's version (base 0x7c910000). Should fix VMware Hybrid builder
svn path=/trunk/; revision=69587
Implement ExtX support in FS_REC, this allows it to autoload ext2fs.sys
Starting with this revision, browsing ExtX volumes in ReactOS works without any other modifications.
Thanks to Peter Hater for his initial work and to Thomas for his reviews
svn path=/trunk/; revision=69577
Mark (old) Linux partitions (notably extX volumes) as recognized by ReactOS in IsRecognizedPartition()
This is only enabled when building ReactOS.Otherwise, it matches Windows definition.
svn path=/trunk/; revision=69575
- Delete the old devmgmt and replace it with the new one.
- The new one is a temp container for devmgr.dll and simply calls DeviceManager_ExecuteW. Eventually mmc.exe will replace this module
svn path=/trunk/; revision=69547
- Kill off the old devmgr and replace it with the new one
- The new one now contains the (rewritten) device manager code, is now a C++ library and makes use of the recently improved ATL
svn path=/trunk/; revision=69545
Isolate KD a bit by replacing Rtl* memory routines with internal versions. Lets one put breakpoints inside kernel memcpy/memset without making KD very, very sad. Fix MmDbgCopyMemory to also not use RtlCopyMemory -- there is no need for it since it only performs 1-to-8 byte copies anyway. Minor fixes in the print/prompt routines.
svn path=/trunk/; revision=69539
Fix mapping of working set list page -- it should be local.
Get rid of MI_MAKE_LOCAL_PAGE and use ValidKernelPdeLocal/ValidKernelPteLocal consistently. This is what they exist for!
We should now hopefully not be creating any global pages when we don't want them.
Next step; fix flushing.
Bonus: Use the right lock in MiSessionLeader
svn path=/trunk/; revision=69532
Add super-complicated handling of global pages to KeFlushCurrentTb (pretty much the same code which has been in HalpFlushTLB for the past ~6 years). This should be all that is required to make this feature work (everything else being in place already), and *seems* to work fine but is disabled under a switch until tested thoroughly.
Global pages, an important optimization that allows for not flushing the whole x86 TLB every time CR3 is changed (typically on context switch to a new process, or during process attach/detach), relies on us doing extra work whenever we do alter a global page. This is likely where any bugs will have to be flushed out!
Fixup Ki386EnableGlobalPage while we are at it -- disable/restore interrupts properly, and verify PGE-bit isn't set (nothing should have touched it before this routine, which is responsible for initializing it, so we shouldn't have to disable it). Fix, but disable, the CPU-sync spin as well as there should be no particular reason to do this for PGE-enabling during initialization (no other processor will be messing with PTEs at this stage, as compared to a call to KeFlushEntireTb).
Everyone, repeat after me: Global pages are awesome!
svn path=/trunk/; revision=69528
Merge DbgBreakPointWithStatus and RtlpBreakWithStatusInstruction together as one function (the latter is just a label for KD), and add new macro necessary for this (MASM very much wants "::" on a global label inside a PROC local scope). Timo, you are awesome.
Bonus: Complement HEX()'s awesomeness with the other explicit radix specifiers.
svn path=/trunk/; revision=69515
- Increase height of the animation control in the file operation progress dialog to avoid cut-off. Patch by Jared Smudde.
CORE-10326 #resolve
svn path=/trunk/; revision=69510
- Pass the correct DeviceObject to PoRequestPowerIrp's callback
- Use the IRP stack to store callback parameters instead of a pool allocation as shown by the test
svn path=/trunk/; revision=69503
Add SHA-1 digests to RAPPS DB packages by Ismael Ferreras Morasuelas (swyter)
CORE-10319 #resolve #comment Errr... sorry, I was just told that we already verify downloaded stuff in rapps... committed and thx for the work you spent in it...
/me hides
svn path=/trunk/; revision=69498
- Separate system-defined from user-defined window properties. The values stored by win32k/user32 must not interfere with those stored by applications. Fixes various applications (e.g. PeaZip) randomly getting their window properties overwritten by the system
CORE-3897 #resolve
svn path=/trunk/; revision=69494
- Add the SystemLCID to the GlobalData variable and use it in the Advanced page.
- Add a stub for storing font linking settings.
CORE-10075
svn path=/trunk/; revision=69486
- Remove some DECLARE_RETURN()/RETURN()
- Add asserts for the user lock
- Annotate window property functions and use consistent parameter names
svn path=/trunk/; revision=69485
Fix a FIXME: properly reset timer when re-using a queued IRP for reading.
Also fix a possible race condition between time out DPC and IRP re-use.
Thanks to Thomas for his help with DPC & timers.
CORE-10245
svn path=/trunk/; revision=69483
Implement asynchronous reading from mailslot.
Patch by Nikita Pechenkin
Adjustements, style fixing by myself.
CORE-10245 #resolve #comment Modified patch committed with r69475. I have tested kernel32:mailslot and your provided test, both are passing 100%. Thanks!
svn path=/trunk/; revision=69475
- "Fix" SHChangeNotifyRegister to report file system changes. I am not really sure if these changes are correct but really make it work now.
CORE-1171
svn path=/trunk/; revision=69469
- Correctly handle NULL ppidl in EnumerateNext as required by Skip() callers
- Don't reenumerate NT directories every time EnumerateNext is called from Skip()
CORE-10311 #resolve
svn path=/trunk/; revision=69462
- Implement BiInitializeAndValidateHive, BiLoadHive. Leveraging our existing cmlib and the previously committed code, we are now able to read the BCD file, parse it as a registry hive, and lookup the BCD Objects subkey! The BCD Data Store is now available to the Boot Manager (which also validates that reading from ETFS works).
svn path=/trunk/; revision=69454
- The Objects key is in the root, not under Description.
[MKHIVE]:
- Make it *actually* build a BCD hive. It was doing nothing before, because it turns out that irrespective of what appear to be dynamic, command-line driven behavior modes, all of mkhive's logic is deeply tied together through C-level changes and knowledge. (for example, that's why calling it with a single .inf, it still wants to build 6 hives for you). There were also some copy/pasta bugs in the BCD handling code, now fixed.
svn path=/trunk/; revision=69453
- Fix multiple bugs in ETFS code (confusion between file offset vs. disk offset)
- Implement EtfsGetInformation, EtfsSetInformation, and fix ETFS_FILE definition to make this easy.
- Implement EtfsRead.
- Fix multiple bugs in file I/O code (swapped/reversed validation checks)
- Make BlStatusPrint call EfiPrintf on debug builds, even without BD.
- Add some additional error logging.
svn path=/trunk/; revision=69452
- Improve the internal locale storage. Replace the array of strings by a customized struct.
- Implement the locale customization properly. The customization property sheet modifies the internal locale storage rather than the registry. Now, cancelling changes works properly.
CORE-10074
svn path=/trunk/; revision=69449
- Whoever wrote mkhive ran into the problem I just did, and realized hey-i-dont-fucking-want-to-use-that-almost-copy-pasted-but-not-shared-code-so-why-dont-i-use-the-good-kernel-code-instead... but instead of taking the time to create a fucking library like I just did (cause that would be hard man, and fixing headers n' shit), just hard-coded the paths to the kernel files directly like a lazy shit. Fix mkhive to just rely on cmlib, which now has the files shared there.
svn path=/trunk/; revision=69445
- Move cmindex.c and cmname.c to cmlib, because bootmgr/winload use the kernel's cm implementation, unlike our freeldr which uses an almost copy-pasted-but-not-shared-because-hey-why-not-have-to-fix-the-bugs-in-two-places-instead-of-just-one implementation.
- Minor fixes to headers to allow those two files to be used/built outside of ntoskrnl.
svn path=/trunk/; revision=69444
Usability fixes (part 2):
- Properly keep the mouse show state across screenbuffer switches.
- Use unicode strings for the disk menu items.
See r69428.
svn path=/trunk/; revision=69431
Convert COLOR16 values to byte range before calling XLATEOBJ_iXlate.
This fixes gradient colors in some applications, as for example in Code::Blocks.
Patch by Vort. This is a fix for code written in revision r8117, so old !!
CORE-8652 #comment Committed in r69430, thanks guys!
svn path=/trunk/; revision=69430
Usability fixes:
- Update the menu each time the user chooses to show or hide the mouse pointer.
- Keep the mouse show state across screenbuffer switches (text/graphics) (half-hackish at the moment; will be elegantly fixed later on).
- Update the floppy disk menu items each time the user mounts / ejects a disk; display the disk image file name currently mounted (CHAR strings used at the moment, WCHAR conversion will follow soon).
svn path=/trunk/; revision=69428
Reading/writing to memory should #SS(0) when the segment is the stack segment,
and #GP(0) otherwise. It should never generate #NP.
svn path=/trunk/; revision=69427
- Temporarily hack the boot sequence to floppy, then hard disk. See r69421; will be improved in the future.
- Complete the BIOS 16-bit bootstrap code.
svn path=/trunk/; revision=69422
- Add a basic boot sequence functionality (read from CMOS); will be improved in the future.
- Print a "FATAL BOOT FAILURE" error message when INT 18h is called.
- Fail startup if we cannot mount the available hard disk images.
- Improve some diagnostic error messages.
svn path=/trunk/; revision=69421
- Don't forget to push the error code when the exception handler is a task gate.
- Use SS0/ESP0, SS1/ESP1, or SS2/ESP2 for ring 0/1/2 code task CALLs.
svn path=/trunk/; revision=69420
Properly implement support for IOCTL_DISK_GET_DRIVE_GEOMETRY, IOCTL_DISK_GET_DRIVE_GEOMETRY_EX, IOCTL_CDROM_GET_DRIVE_GEOMETRY_EX, IOCTL_DISK_GET_LENGTH_INFO in CdRomDeviceControl
CORE-10287 #resolve #comment Fixed with r69418
svn path=/trunk/; revision=69418
Don't bugcheck on unimplemented FsRtlOplockFsctrl(), FsRtlCurrentBatchOplock(), FsRtlCheckOplock()
Properly implement FsRtlInitializeOplock() (which is no-op on Windows 2k3)
CORE-10284 #resolve #comment Resolved with r69412
svn path=/trunk/; revision=69412
- Add floppy image automount support from the registry, as it was done for HDDs in r69390 (it's really copy-paste & adaptation of the existing code).
- Increase HDD number support from 1 to 4 (maximum) for INT 13h.
svn path=/trunk/; revision=69411
- Don't support IOCTL_DISK_GET_DRIVE_GEOMETRY_EX, IOCTL_CDROM_GET_DRIVE_GEOMETRY_EX for now
- Properly implement IRP completion for IOCTL_DISK_GET_LENGTH_INFO, IOCTL_DISK_GET_DRIVE_GEOMETRY
svn path=/trunk/; revision=69409
Fix a division-by-zero problem by storing the mouse driver's Width and Height
in DWORDs, thus avoiding the integer overflow which could make them zero.
svn path=/trunk/; revision=69408
- Always use the descriptor type, and never the limit, to identify
legacy vs. modern TSSes.
- Don't forget to write back the modified TSS link.
svn path=/trunk/; revision=69407
Read global settings from the register (in HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\NTVDM ; note that this is a ReactOS-only configuration key, because no equivalent functionality exists on windows), and currently initialize:
- the BIOS and ROM files to be used;
- the hard disks to be mounted at startup (they cannot be unmounted at runtime, contrary to the floppies) (maximum 4 hard disks).
svn path=/trunk/; revision=69390
Major bugfixing session for RtlGenerate8dot3Name()... Up to know, AllowExtendedCharacters was totally ignored and any upcased char, as long as it was not in the forbidden list was accepted. This was bringing numerous problems (cf: apitest :-)).
So, now, the following fixes were brought:
- AllowExtendedCharacters isn't ignored any longer. If it's given, the unicode char is upcased, if it's not, as previously, the ansi char is upcased
- Be more strict in the allowed chars in name: only allow "graph" chars. This avoids generating broken names that aren't allowed in FAT
- In case no char could be added in the name, then, for the generation of the name checksum and use it as shortname
- When writing the checksum, don't use reversed order, but direct order, to match Windows behavior (as exposed with tests)
- When writing the checksum, use when possible bit operations instead of numerical operations for performances reasons (NFC)
- Rewrite RtlpGetCheckSum() with an algorithm that produces the exact same checksums than Windows 2003.
This whole commit fixes all apitests related (direct visible effect). As a bonus, it also fixes short names generation in FAT: we no longer produce broken volumes with international file names.
This also fixes less visible issues: we were producing unicode strings with null char in their middle (as exposed in tests), not sure about how all functions could handle this: likely not that good, this could have lead to various memory issues & corruptions.
CORE-10223 #resolve #comment Fixed with r69389
svn path=/trunk/; revision=69389
Add more tests for RtlGenerate8dot3Name().
Not sure how many more are failing in ReactOS: they all pass in my WC (teasing :-))
CORE-10223
svn path=/trunk/; revision=69388
- Start implementing a user menu for mounting/unmounting floppy disks at runtime. Menu state refresh & proper localization remain to be done.
- Add a temporary "Sleep(INFINITE)" where the VdmShutdown function is susceptible to trigger again a VDM cleanup in case it was called again in parallel. For diagnosing CORE-10182, see also r69366.
svn path=/trunk/; revision=69375
- Don't duplicate the code for getting the name of a drive. CDrivesFolder already does it (and it does it better). Make the drive properties call it to get the name it needs.
CORE-10258
svn path=/trunk/; revision=69373
- Improve a change from r27016. Running the control panel applets in the context of explorer is not correct. We should really use ShellExecute here.
svn path=/trunk/; revision=69370
- Fix SH_ParseGuidDisplayName which was completely broken when I committed it.
- Use GUIDFromStringW instead of SHCLSIDFromStringW in _ILCreateGuidFromStrW. The latter needs the string to terminate right after the guid.
svn path=/trunk/; revision=69369
Add basic disk support with mounting/unmounting images in NTVDM:
- basic disk controller (at the moment this is just a collection of helper functions. A real HW emulation will come later on).
- INT 13h services for the BIOS.
At the moment, the images to be mounted are hardcoded in disk.c. Please see disk.c for examples of how to use the function. This will be reworked to allow user choice without having to recompile NTVDM.
CORE-10262 #resolve
svn path=/trunk/; revision=69365
Misc trap/interrupt fixes:
- Stub legacy KiGetTickCountHandler (INT 2A) to fail instead of breakpointing. We have made it so far without it, and if someone finds something that actually uses this instead of Win32's GetTickCount we can add it then. Raises the bar of making ReactOS breakpoint from 2 bytes to 4.
- Bugcheck with the right status code in case Kei386EoiHelper is called (which means you are trying to load a Windows HAL which we totally do not support right now).
- Use Ke* instead of Kf* in C code for IRQL routines.
svn path=/trunk/; revision=69362
- Don't hardcode magic values of characters if they have C escape codes.
- Print an extra newline on call to the Ctrl-C handler, as it is done on real DOS.
- Use a do{}while loop which loops while we don't have read a CR character.
svn path=/trunk/; revision=69361
DosReadFile echoes the line feed when it encounters it.
A backspace should delete the '^' sign for special characters.
svn path=/trunk/; revision=69360
Fix DOS character device I/O. Implement CON line buffering.
Make sure INT 21h functions 01h, 06h, 07h, 08h, 0Ah and 3Fh work as expected
for CON input.
svn path=/trunk/; revision=69356
[EX] Remove "KeGetCurrentProcess" and just use the EPROCESS Pcb member for type correctness instead of inventing a new macro to hide the casting.
[PS] Remove stray INIT_FUNCTION (doesn't do much on a prototype).
[IO] Define _IO_DEBUG_ to 0 again after someone forgot to leave it on 4 years ago (only bloated the code since IopTraceLevel was 0 anyway).
svn path=/trunk/; revision=69354
Add more tests for IoCreateFile(), this time purely dealing with symlinks reparse points.
They won't run on ReactOS (obviously) as we don't have RW NTFS support.
On Windows, they show interesting results....
With Windows 2003, creating the symlink is allowed and works, but then Windows is totally unable to deal with it and keeps complaining about an unhandled reparse tag.
The only way to open it is to open the reparse point itself. Not that working symlinks... Not sure which part is not able to handle the said reparse tag. NTFS? Io?
With Windows Vista+, it just works fine. Symlink is created & functionnal.
Broken logic!
svn path=/trunk/; revision=69353
Add a test for CORE-10188 (which was fixed by Thomas in r69236).
It is based on Nikita Pechenkin's patch with a few modifications by me to avoid race condition on start (and avoid flappy test) and to match more closely our coding style
ROSTESTS-190 #resolve #comment Committed in r69351. Thanks!
svn path=/trunk/; revision=69351
- Use ROS-style paths for include files.
- Fixup its CMakeFiles for C++11 compilation under GCC (done the way we did for other C++ projects).
- Add a VS project for DEVMGR to make Ged happy.
[ATL]
Start C++ fixups:
- Add 'placement new' operator.
- Add some missing functions (that were not caught by MSVC compilation because we atm. accept function usage without the existence of its actual code...).
More to follow...
svn path=/trunk/; revision=69348
[NTOSKRNL]: Add a helper function such that user-mode cannot pass certain kernel-only object attributes to ObOpenObjectByPointer.
[NTOSKRNL]: Make \Device\PhysicalMemory OBJ_KERNEL_EXCLUSIVE
[NTOSKRNL]: Deny access to user-mode when opening a handle to an object with OBJ_KERNEL_EXCLUSIVE
[NTOSKRNL]: Fix NtOpenProcess, NtOpenThread, NtOpenThreadTokenEx, NtOpenProcessTokenEx to use the helper function. Should fix Rtl using OBJ_KERNEL_HANDLE in user-mode.
Thanks to ThFabba for finding out these bugs, and the hbelusca for adding a missing check to NtOpenProcessTokenEx.
svn path=/trunk/; revision=69340
- Fix ZF and CF flags setting in function INT 2Fh, AX=1214h.
- Use CreateEventW explicitely.
- Set the VdmTaskEvent event at startup. This allows user input by default (even if we don't run our own DOS) in NTVDM. Fixes keyboard input not working when testing boot&usage of MSDOS 6.
svn path=/trunk/; revision=69339
Aside question: we have a "nmidebug" driver in \drivers\base\. In it is a NMI callback "NmiDbgCallback". I was wondering what "((void(*)())&KiBugCheckData[4])();" should do, according to the surrounding code, since in some conditions this code path is actually run: http://i.imgur.com/TUsEr5p.jpg
svn path=/trunk/; revision=69337
- Properly free handles in driver (spotted by Thomas)
- Remove dead code in driver (spotted by Thomas)
- Send an IOCTL to stop on symlinks to allow more precise tests
svn path=/trunk/; revision=69336
- Fix devmgmt.exe to correctly build and link against devmgr.dll
- This is a temp exe that just calls DeviceManager_ExecuteW. This will later be replaced by mmc.exe and devmgmt.msc
svn path=/trunk/; revision=69334
- Add support for CAtlString and all its supporting base classes.
- It doesn't do much more than assign wchat_t arrarys and call LoadString, but it's a full base to start adding more methods as people decide to.
svn path=/trunk/; revision=69332
- Add a few helper functions: SH_ParseGuidDisplayName, SHELL32_SetNameOfGuidItem, SHELL32_GetDetailsOfGuidItem.
- SHELL32_SetNameOfGuidItem is based on a patch for CORE-5995
- Use the helpers in CControlPanelFolder, CDesktopFolder and CDrivesFolder. Implements getting the comment and renaming registry items in these folders and share some more code.
svn path=/trunk/; revision=69328
[NTOSKRNL]: Actually apply the foreground priority boost to threads in a foreground process.
[NTOSKRNL]: Correctly handle the case where the quantum length and fixed/variable flag are set to "default", instead of falling back into the server case.
Thanks to WINSRV doing the right thing, ReactOS console apps now receive the priority separation boost. However, my tests show that it doesn't last as long as it should on Windows (quantums too short? bug in priority decrement?). Also, since Win32k.sys doesn't tell the kernel about foreground GUI apps, they don't get the boost. Someone needs to add a NtSetInformationProcess call in whatever win32k function determines active focus.
Dedicated to ThFabba who needs to write some tests ;-)
svn path=/trunk/; revision=69324
- Do not hardcode the number of XMS memory blocks that can map the HMA. It should be function of the MAX_ADDRESS value of our emulator.
- Require that MAX_ADDRESS should be greater or equal than 1 MB.
svn path=/trunk/; revision=69323
Extend the IoCreateFile tests with two parts tests.
First part properly checks for opening/reparse handling on mount points (and ideally on symlinks, see below).
The other part checks for proper handling of the IO_STOP_ON_SYMLINK parameter.
Regarding symlink, I'm clearly not convinced that what I did is correct (hence the failure on both W2K3 & ROS). It seems to me that symlink resolution is up to the FSD and not to IO which only handles mount point traversal.
If someone (Alex?) can confirm/infirm and give more insight, that's more than welcome.
svn path=/trunk/; revision=69322
- Build the properties as C++
- Rearrange the folder structure
- The whole thing now builds and runs from VS (with a few hacks). CMake next
svn path=/trunk/; revision=69320
- Add a helper HCR_GetClassName function to load the name of a reg folder to a STRRET
- Further simplify CAdminToolsFolder, CFontsFolder and CMyDocsFolder
svn path=/trunk/; revision=69319
Implement a save routine for the GeoID. Stores the current GeoID in the default user profile too, if required.
CORE-10172 #resolve
svn path=/trunk/; revision=69309
- Unicodify the CPL. Get rid of <tchar.h>.
- Pass a pointer to all getter and setter functions of the customization property sheet pages.
- Remove the "Property of" text from the property sheets.
- Convert "SendMessage(GetDlgItem(..." to "SendDlgItemMessage(...".
svn path=/trunk/; revision=69308
- Print a message if EISA DMA support is detected. Detection should probably not even be attempted unless the machine supports EISA; the print will show whether that's correct.
CORE-9895
svn path=/trunk/; revision=69302
Save and restore the general purpose and segment registers around Int32Call
calls in the BIOS. Also, make sure CF doesn't get set by the called interrupt
procedure.
svn path=/trunk/; revision=69297
- Add missing OBJ_KERNEL_HANDLE
- OBJ_KERNEL_HANDLE in user mode has no effect... no reason to make a define around it
CORE-10207
svn path=/trunk/; revision=69296
Fix CVE-2015-1769:
- When opening remote databases, don't attempt to migrate w2k database to current format.
- Also, when opening/creating the remote database, don't allow following symlinks anymore.
In case a symlink would be detected, an error message will be printed.
Commit dedicated to Alex :-).
CORE-10216 #resolve #comment Fixed with r69295
svn path=/trunk/; revision=69295
Our ReconcileThisDatabaseWithMasterWorker() routine will expect two parameters: the device extension + the device to which reconcile remote database.
So, fix our code accordingly
svn path=/trunk/; revision=69291
Implement the IOCTL_MOUNTMGR_QUERY_DOS_VOLUME_PATHS:
- Implement MountMgrQueryVolumePaths()
- Implement MountMgrValidateBackPointer()
- Implement MountMgrQueryDosVolumePaths()
- Rename a struct var to reflect its real usage
svn path=/trunk/; revision=69284
- Fix a activation drawing issue, if the window is not activated do not draw it active. Used testmenu program from CORE-1573 to test it. If this creates a new problem please open a Jira report.
svn path=/trunk/; revision=69263
- Support loading executables with the old EXE signature ('ZM' instead of 'MZ').
- Fix the EXE loader so that:
* we can load programs of >= 1Mb size, by exploiting the fact that on real DOS, the computed exe size (which uses the number of 512-byte blocks, stored in the EXE header) is stored in a WORD variable.
This has as an effect to truncate the value, and if it is such that the truncated value is less than the size of available memory, the EXE can be loaded (partly, of course). Some apps expect this behaviour,
for example, Turbo C++ IDE.
* Simplify the memory limits computation, according to http://www.tavi.co.uk/phobos/exeformat.html , which is the correct algorithm used by DOS (and confirmed by FreeDOS also).
svn path=/trunk/; revision=69261
Correctly call the device strategy/interrupt routines. Should fix a bunch of weird errors. This also fixes the NTVDM crash when Command&Conquer terminates, however it doesn't fix the DOS/4GW exception it encounters.
CORE-9678
svn path=/trunk/; revision=69246
- Use a NULL timeout for infinite waits instead of waiting for 100 ns. CORE-10188 #resolve
- Wait for available read data in user mode to handle thread termination
- Return STATUS_IO_TIMEOUT also for a zero-length timeout. Fixes Wine tests
- Avoid MmGetSystemAddressForMdl
- Acquiring a mutex is not a UserRequest
svn path=/trunk/; revision=69236
Fix the file header description. Consistently use .endm for closing a macro started with .macro.
[NTVDM]
- Add "_clean" targets to generated asm16 targets.
- Fix CMake dependency generation in a somewhat hackish way: I don't know how to cleanly specify the location of generated files for custom targets. And it is also hackish because in a CMake custom command which depends on the COMMAND.COM target, I also need to explicitely say that the command depends on the output file created by the COMMAND.COM target...
- Add COMMAND.COM to the CD files, even if NTVDM doesn't use an external command.com for now. CORE-5221
svn path=/trunk/; revision=69234
Implement the IOCTL IOCTL_MOUNTMGR_VOLUME_MOUNT_POINT_DELETED:
- Implement MountMgrVolumeMountPointDeleteed()
- Rename a struct var to reflect its real usage
svn path=/trunk/; revision=69232
- Fix memory leak in IopDetectResourceConflict. While we're at it use pool tagging, kernel handles and avoid INVALID_HANDLE_VALUE.
svn path=/trunk/; revision=69227
- Fix the GCC macro for structure declaration, so that referencing an offset to the structure doesn't fail anymore (ie. doing "mov dx, offset MyStruct" doesn't assemble to "mov dx, 0x100").
This fixes NTVDM not being able to start any DOS app. Reported by Aleksander Rechitskiy.
CORE-9677 CORE-9679 #resolve
CORE-9678
[NTVDM]
- Fix newline in DPRINT.
svn path=/trunk/; revision=69211
- Add support for DOS VDM reentry, i.e. the fact that a DOS app can start a 32-bit app, which in turn can start another DOS app, ad infinitum...
CORE-9711 CORE-9773 #resolve
- Add a small COMMAND.COM which is, for now, completely included in NTVDM. This COMMAND.COM is needed in order to support reentrancy. The fact that I chose to put it inside NTVDM is that any user can use instead his/her own COMMAND.COM, while retaining the possibility to perform VDM reentrancy (on Windows, if you remove the COMMAND.COM in windows\system32 and replace it with your own, you will break VDM reentrancy on windows' ntvdm).
CORE-5221 #resolve #comment I choose for the moment an internal COMMAND.COM, but you can recompile NTVDM to use it externally instead.
Global remarks:
- Quite a few DPRINTs were added for diagnostic purposes (since DOS reentrancy is a new feature), to be sure everything behaves as expected when being used with a large panel of applications. They will be removed when everything is OK.
- Support for current directories and 16/32-bit environment translation (in ntvdm + basevdm-side) remain to be implemented.
Other changes:
- Improve a bit the VDM shutdown code by gathering it at one place (there's still room for other improvements).
- Add suppport for properly pausing/resuming NTVDM.
- Bufferize some console events before dispatching.
Have fun ;^)
svn path=/trunk/; revision=69204
GetNextVDMCommand function:
- Avoid using deep nested levels of indentation.
- Fix the error check conditions (+ status value) for the CsrClientCallServer call to make it compatible with what windows' basesrv can return to us.
[BASESRV]
- Remove some useless "NTAPI" from functions.
- Factor out some code used for creating and destroying console records, and for the destruction of the pair of event handles.
- Use "IsListEmpty" when needed.
- Fix BaseSrvFillCommandInfo so that it returns the needed lengths (even if the user-given lengths are zero) and set the expected status error in case the buffer lenghts are too small (not STATUS_BUFFER_TOO_SMALL but STATUS_INVALID_PARAMETER because it's what kernel32 error check expects, for windows compat; see above).
- Fix initialization of new DOS records: no need to create a new one if there is one already free (status VDM_READY).
- Fix the loop that searches for a valid DOS record containing command information available as well as the conditions in which case our caller needs to wait in GetNextVDMCommand call.
NOTE: The internal state flags of the DOS records have normally nothing to do with the VDM state flags we report back to the user.
CORE-8247 CORE-9711 CORE-9773
svn path=/trunk/; revision=69201
- Read the current user locale when the CPL is created.
- Modify the user locale and update the examples when the user selects a new language.
- Save the user locale only if the user changed the settings.
CORE-10074
svn path=/trunk/; revision=69199
- Changing one "exit" to "exit /b" was not nice from me in the past.
ARM build now prepares host tools nicely again and you can build em. ARM build itself dies very early due to ..\..\boot\freeldr\freeldr\arch\arm\boot.S(9) : fatal error C1083: Cannot open include file: 'ksarm.h': No such file or directory
svn path=/trunk/; revision=69191
- Additional El Torito support. We now parse the EFI, BOOT directories, and find/open the BCD file, and get a handle to it!
svn path=/trunk/; revision=69189
- Disabling C4214 (nonstandard extension used : bit field types other than int), a somewhat overzealous warning for a "nonstandard" extension we rely on all over.
- Defining inactive DPRINT and friends for MSVC using __noop (no not __nop, __noop. See https://msdn.microsoft.com/en-us/library/s6btaxcs.aspx) to get at a whole bunch of C4127 (conditional expression is constant).
- Remove the last of the exported DriverEntry from dxg and dxgthk. There is no need in anyw way to export them -- dxg exports DxDdStartupDxGraphics to Win32k for initialization purposes and dxgthk is just a forwarder. Linking to a DriverEntry is to begin with is a pretty bad idea. Say goodbye to the last of LNK4216.
svn path=/trunk/; revision=69187
- Hey Arch, your buddies gave you ETFS support for native EFI boot, of course reading sector 0 is all zeroes, you're not on FAT, you idiot! ETFS has data at sector 16 and 17.
- Implement beginning of ETFS support. We correctly mount the reactOS boot cd as ETFS and open the root directory entry!
svn path=/trunk/; revision=69181
- Hackplement Layered Window Support from wine.
- See CORE-1576 for more information. Three days work, ReactOS needs more support for playing with GDI bits.
svn path=/trunk/; revision=69179
- Implement Block I/O read operations & related functions. Code needs cleanup, TBD.
- Unfortunately, I wish I could say it works, but it seems like all we get back are zeroes (from EFI itself). I suspect we are reading from the wrong device -- will have to investigate for a bit.
svn path=/trunk/; revision=69178
- Add some more reserved mapping tests for special pool tags and unaligned addresses
- Validate MDL pages in MmMdl test
svn path=/trunk/; revision=69169
- Add BCD creation.
- Add BCD to bootcd, and also to EFISYS.BIN. Verified the BCD is now present on the EFI partition.
svn path=/trunk/; revision=69156
- Fix more device I/O bugs.
- Silence some dbgprints.
- Implement DiskOpen and DiskClose.
- Refactor block cache in its own file.
- We successfully open our boot device (which appears as a floppy, as expected with the new UEFI boot)!
svn path=/trunk/; revision=69153
- Wrap some KDBG-only stuff into KDBG-define so we don't have KdSystemDebugControl being called needlessly on KD-builds.
svn path=/trunk/; revision=69148
- Reorder some more driver exports to alphabetical order.
- Remove NtGdiFlushUserBatch and NtUserQueryUserCounters from syscall list (unused, and not compatible).
- Move and add some debug-only syscalls to the end of the syscall list.
- Fix parameter count of UserValidateTimerCallback, UserValidateHandleSecure, and UserChangeDisplaySettings to match what is compatible, by removing unused or ignored parameters. NtGdiOpenDCW, NtUserEnumDisplayMonitors and NtUserSetCursorIconData still have the wrong numbers.
- Add "stray" NtGdiMakeObjectXferable and "NtDxEngGetRedirectionBitmap" syscall stubs.
- The syscalls should now be compatible with 2K3 SP2 in their order, but not in their argument count (or, most likely, their actual parameters). This means a Windows 2k3 gdi32 or user32 should crash somewhat later now that half of the syscalls' order is not in disarray.
svn path=/trunk/; revision=69147
[NDK] Add define guard for HalEndSystemInterrupt because it is no longer compatible with Windows, and add back the old definition. Fix NtSetSystemEnvironmentValueEx prototype.
[KERNEL32] Export SetFileCompletionNotificationModes (MSDN and headers documents it as Vista-only, but this is not entirely correct).
svn path=/trunk/; revision=69144
- 1.5KLOC code dump of current device block I/O handling. Totally untested and broken, just a checkpoint for now.
- Implement most of Hash Table Utility Functions.
- Implement parts of Block Allocator.
- Finish Implementation of Generic Table Utility Functions.
- Fix some EFI device emulation code.
- Temporarily disable freeing from heap while I figure out what's corrupting it.
svn path=/trunk/; revision=69142
* Allow customizing the 8-letter volume label from the FAT header.
* Make the efisys.bin have EFIBOOT as a label.
* Improve a bit the help text.
svn path=/trunk/; revision=69140
Thanks gigaherz for the "fatten" utility!, and others for testing.
[CDMAKE]
- Add multi-boot CD support, following El-Torito specification, such that we can the usual ISO boot sector on BIOS-based PCs, and the UEFI loader on UEFI-based PCs.
- Load segment should be stored in little endian.
- Fix the computation of the sector count (count in 512 byte sectors and rounded up).
- Rework the command-line options to make them more compatible with CDIMAGE / OSCDIMG.
CORE-10120
[BOOTDATA]
- Activate the UEFI boot support for our ISOs.
svn path=/trunk/; revision=69139
* Change the number of FAT copies stored by the formatting code to 2.
* Implement /BOOT command, to apply a boot sector to the image (FAT12/16 only, for now).
* Make use of the command above to finally get the generated efisys.bin loading in 7zip as a floppy.
svn path=/trunk/; revision=69135
In a failed attempt at getting 7-zip to recognize the fat images,
* Updated the fatfs backing library to v0.11a,
* Changed the default cluster size to 1 for floppy-sized images (< 4096 sectors) and 8 otherwise (4096 was an invalid value), and
* Changed the fatfs formatting code to generate FAT12 filesystems more windows-like.
I see no reason to discard the changes, so here they are.
svn path=/trunk/; revision=69131
Let's try not to leak memory...
So, close what's been opened in case of an error
And in a general way, close files we opened
CORE-10140 #resolve #comment Fixed with r69127
svn path=/trunk/; revision=69127
* Switch to using our existing host-tools header for types. Thanks Colin for pointing me to the right header (it was discrete so I missed it when looking).
svn path=/trunk/; revision=69112
* Fix folder creation and external file access.
* Add fatten as a host-tool.
* Add a target for creating efisys.bin from the bootmgfw
TODO: Make the name of the boot*.efi depend on the platform (ia32/x64/arm).
TODO: Add efisys as a dependency to the bootcd, when we need to make use of the efisys.bin file for the iso (waiting for hbelusca's cdmake work).
svn path=/trunk/; revision=69109
* Remove pointless dependency on BOOL and CHAR, which helps with portability.
* Disable reentrancy, since all the operations are serialized by the commandline.
* Improve a few comments.
svn path=/trunk/; revision=69106
* Fix the integer types for non-windows platforms (assume they have stdint.h instead of assuming embedded).
* Fix file I/O, which was just barely working enough to pass the one test I did.
svn path=/trunk/; revision=69105
- EarlyPrint -> EfiPrintf, as it seems BL actually has this after all :) Change all callers to conform to it.
- Add common exit/failure path in BmMain. Now the fun begins.
svn path=/trunk/; revision=69103
- Last round of display fixes. GOP works now -- fill out the frame buffer with gray as a test (tested in VirtualBox).
- Now to fix the heap.
svn path=/trunk/; revision=69097
- Add normaliz.dll to the build
- Move the appropriate functions from kernel32_vista to normaliz
- Import IsNormalizedString and NormalizeString stubs from Wine
Now Scilab starts
CORE-10124 #resolve
svn path=/trunk/; revision=69093
-State if there are no audio devices installed
-remove an obsolete resource ID
Patch by Jared Smudde CORE-10009 #resolve
svn path=/trunk/; revision=69088
- Generate XDK headers during build. To make changes to wdm.h, ntddk.h, ntifs.h, devioctl.h, ntdef.h or winnt.h, edit the appropriate files in include/xdk (as you should already have been doing for a long time).
CORE-9586 #resolve
svn path=/trunk/; revision=69083
- Fix text console bugs. It works now both when already at 80x25, as well as when using UEFI Shell to switch to 100x31 first. Tested with Virtual Box.
svn path=/trunk/; revision=69078
- Checkpoint commit of about 1000+ lines of text console support code. Right now, it's very disorganized and not tested.
- Write out the rest of the initialization path. Almost everything else is only for Boot Debugging, BitLocker, TPM, PXE...
svn path=/trunk/; revision=69076
- Fix the ASSERT in KeConnectInterrupt for debug single-processor builds (but keep the old one for multiprocessor build to make it less confusing if it is hit).
svn path=/trunk/; revision=69075
- I/O Library initialization.
- A few more random initialization routines. Skip TPM, BitLocker, Network and non-FAT filesystems for now.
svn path=/trunk/; revision=69073
- Fix some heap bugs. It (works?) now, at least for one allocation.
- Fix GCC support for Phase 1 Architectural Initialization.
- Implement Time measurement for Hyper-V compatible hypervisors (tested with Virtual Box 5.0!) as well as non-hypervisors (also tested)
svn path=/trunk/; revision=69071
- Add heap implementation, continuing from my work last year. Seems to be pretty broken, next steps are fixing it.
- Implement block allocator initialization (needs heap).
- Implement a few other missing initialization paths.
svn path=/trunk/; revision=69068
Change tabs to spaces, but only for the files I write. The rest come directly from the fatfs package and are best left untouched.
svn path=/trunk/; revision=69065
Introduce a tool I wrote some years ago, that helps create and manage a FAT disk image from the command-line.
It is built using parts of the isofs embedded library, with win32 bindings for file access. Should be helpful in order to create the EFI boot images needed for EFI-bootable isos.
Because the code is not really portable (yet), it's currently not included in the build process.
svn path=/trunk/; revision=69063
- Convert msconfig to a fully property-sheet-oriented app.
- Start converting the general page to a property page (serves as a model for the other pages).
- Sync translations for the general page.
- Temporarily remove the other pages from compilation.
svn path=/trunk/; revision=69062
- Implement case in BlMmRemoveRegionFromMdlEx where the descriptor's tail (or entire allocation) is contained in the descriptor -- this covers our BootMgr entry.
- Implement some more initialization functions.
- Start implementing the heap allocator initialization code. Now we need to implement the actual page allocator.
svn path=/trunk/; revision=69059
- Implement algorithm to detect if truncation is needed, which should only happen on IA64 systems I believe (otherwise, the OS and firmware should have the same alignment/page size requirements)
- Implement algorithm to detect if coalescing is needed. This shouldn't happen with firmware memory yet, but might happen once we start carving out stuff.
svn path=/trunk/; revision=69056
- DrvEnableDriver does not need to be exported. Fixes MSVC warnings (LNK4216: Exported entry point _DrvEnableDriver@12)
svn path=/trunk/; revision=69049
- Cleanup some bugs/issues in the memory map parsing code.
- Implement creation of BL/NT-compatible memory descriptors based on UEFI descriptors.
- Implement other remaining parts of the page allocator initialization routine.
- Last part missing is to implement routines for removing from a memory list, and for handling the boot manager's own descriptor.
svn path=/trunk/; revision=69047
- Use the right settings to make our CD UEFI compatible. The Internet says this is supposed to be 10000x harder, but it seems to work fine, at least in Virtual Box.
- Implement an EarlyPrint routine for early debugging/testing.
- Using the above, fix a bunch of stupid bugs. The previously committed code now seems to work (so far).
svn path=/trunk/; revision=69043
Add support for converting the EFI file path as well. The first 1000 lines of many have been written. Time to test on Virtual Box.
svn path=/trunk/; revision=69039
- Rename INIT_FUNCTION to INIT_SECTION and put it at the top of functions for consistency with __declspec declarations (it is actually possible to do this via __declspec in newer MSVC versions).
svn path=/trunk/; revision=69037
- Define some core boot library structures -- reverse engineered to be compatible with MS. This is important if we want to load MS' own binaries for testing (such as MemTest.Efi)
- Define basic BCD structures
- Start implementing EFI->Windows Boot Library conversion routines. Last part remaining is EFI path conversion.
- Fix linking with RTL, by providing some stubs for now.
svn path=/trunk/; revision=69033
- Use MmExpansionLock to synchronize changes to MmProcessList. Should fix random crashes in MmDeleteProcessAddressSpace.
CORE-10111 #resolve
svn path=/trunk/; revision=69031
- Associate a temporary VS project (will be removed later on); change the name of the target for now...
- Allow only one instance of MSConfig running on the system (we use a semaphore, compatible with MS' msconfig, so that if you try to run ROS msconfig on windows, you cannot run also windows' msconfig, and vice versa).
- Introduce some utility functions (for strings and other stuff), will be used later on.
CORE-9333
svn path=/trunk/; revision=69024
Fix rand_s implementation so that it doesn't leak resources, so that it doesn't dereference null pointer, so that it matches MSDN documentation (https://msdn.microsoft.com/fr-fr/library/sxtz2fa8.aspx)
CID 716561
CID 716668
svn path=/trunk/; revision=69005
Fix a nasty typo in QueryPointsFromMemory() which was like breaking the behavior of IOCTL_MOUNTMGR_QUERY_POINTS, IOCTL_MOUNTMGR_DELETE_POINTS
CID 1321853
svn path=/trunk/; revision=69002
Fix uninitialized address freeing in case of error in MupGetProviderInformation(), InitializeProvider()
CID 1322227
CID 1322240
svn path=/trunk/; revision=68990
- Don't try to free an uninitialized pointer in VfatSetRenameInformation. CID 1250303
- Actually use the dynamically calculated HashTableSize. CID 1237119/1237120/1237121
svn path=/trunk/; revision=68986
- Sort symbol entries with line number information before those without. Fixes backtraces showing ":0" as file/line for the first line of a function
svn path=/trunk/; revision=68980
Compile the THISCALL calling convention support only for x86. On x64, we are automatically in THISCALL.
Also I suggest we turn this file (and maybe also /lib/sdk/crt/except/i386/cpp.s) into a "msvc-thiscall.c" as it is already done in some other DLLs (like in ole32, riched20).
Fixes build in x64.
svn path=/trunk/; revision=68975
- Update all values in "HKCU\Control Panel\International" when a new language is selected.
- Update the language examples after a language change.
- Disable all settings that should not be affected by a language change.
Missing:
- Top-level windows do not get notification yet.
- Language settings customization should not work yet.
CORE-10074
svn path=/trunk/; revision=68966
- PspMapSystemDll and IopDisplayLoadingMessage are called from non-initialization code, so don't put them in .INIT. CmpHiveRootSecurityDescriptor is called from initialization code, but too late in boot, so don't discard it either.
- Trying to enable this for HAL as well leads to a weird crash very early in boot. Investigation is ongoing. Until then we will just have to keep the huge PCI Class/Vendor tables in memory...
- Enable it for Win32k though as it seems to work fine there.
- Remove INIT_FUNCTION from function prototypes, it serves no purpose there.
See issue 10097 for more details.
svn path=/trunk/; revision=68937
With the newly introduced mechanism (in r68829), on attributes list loop, there shouldn't be any AttributeList attribute anymore.
So, don't attempt to dump them.
svn path=/trunk/; revision=68933
Finally, use the correct implementation for RtlAssert().
In testbots, the behavior will be the following:
On prompt, sysreg will always issue a 'break once' instruction. In umode, where kdbg isn't instructed to handle breakpoint, this will lead to application being killed. With a lot of noise. This matches previous behavior.
In kmode, where kdbg handles breakpoints, sysreg2 will ask for a bt and will reboot the VM. As it was done previously.
The testbots already have the newest available sysreg2 revision.
This was made possible thanks to the help of Stefan and Thomas.
It was also made possible thanks to the commits:
- in trunk: r68899, r68905, r68917
- in project-tools: r2074, r2232
CORE-10088 #resolve #comment Fixed with r68918
svn path=/trunk/; revision=68918
- CNewMenu: Get the folder path from the pidl passed in the Initialize method. No need to query the defview for that.
- Dont use a reactos only interface to create a new directory. Prefer to do it with less code using exported functions.
- Add a new SelectNewItem method that is used when creating a new file or directory.
- Apply same fix for browse for folder dialog.
svn path=/trunk/; revision=68915
- Move NtFlushInstructionCache from sysinfo.c to virtual.c where it fits better. Likewise, move it from kefuncs to mmfuncs in NDK, and fix function arguments (ULONG -> SIZE_T).
- Re-enable TRAP_DEBUG, adding back critical checks in the trap code. Checks can be improved but it is better than potentially silently messing up system state.
- Move remaining RtlPrefetchMemoryNonTemporal code into kernel. Stubbed for non-x86.
- By Hermes suggestion, override ASSERT to NT_ASSERT only for MSVC builds as that is where the main benefit is.
svn path=/trunk/; revision=68907
Fix headers inclusion on MacOSX.
This fixes hhpcomp build on MacOSX
Patch by Nicolas Rouvière
CORE-10084 #resolve #comment Committed in r68906. Thanks!
svn path=/trunk/; revision=68906
Fix KdpPrompt():
- Don't attempt to return in the middle of the loop. It leads to keep the mouse disabled instead of reenabling it.
- Also, return a string length that actually matches what was written to the output buffer.
This fixes invalid behavior on RtlAssert when used with #if 0 moved to #if 1, or when Windows NTDLL is used in ReactOS.
CORE-10082 #resolve #comment Fixed with r68905
CORE-10083 #resolve #comment Fixed with r68905
svn path=/trunk/; revision=68905
- Move Menu to server side. See CORE-7797 and CORE-8299.
- This was for speed while moving windows about the desktop and fixed test results too.
svn path=/trunk/; revision=68904
- Remove the timer's list entry instead of the list head in NtSetTimer and NtCancelTimer. Fixes list entry corruption on VMware Hybrid builder
CORE-10081 #resolve
svn path=/trunk/; revision=68901
- Correctly reallocate buffer in NetWkstaUserGetInfo. Fixes one of the many exceptions when running netapi32 tests with DPH.
svn path=/trunk/; revision=68897
- Rename SHELL32_BindToChild to SHELL32_BindToFS. Do not let it be used for guid items any more. Split SHELL32_GetCLSIDForDirectoryout of it and call it only when needed.
- Fix callers to use SHELL32_BindToGuidItem for guid items.
- Fix a bug in CFSFolder which marked folder items as files when a binding context was used.
svn path=/trunk/; revision=68885
- All shell folders must have the IPersistFolder. Hence their Initialize method is supposed to succeed for them to actually work.
svn path=/trunk/; revision=68884
- Make SHELL32_GetDisplayNameOfChild return the result via a STRRET. Fix all callers accordingly.
- Avoid any heap allocations if a shell folder needs to forward the GetDisplayNameOf call to a child.
svn path=/trunk/; revision=68877
- Remove SHELL32_GetItemAttributes for good. It is never a good idea to have one function that handles many types of pidls.
svn path=/trunk/; revision=68873
- When binding to a drive item try to initialize the new CFSFolder using IPersistFolder3. That allows us to get the path of the drive right from the pidl instead of getting a new reference to the CDrivesFolder and using GetDisplayNameOf for the pidl.
svn path=/trunk/; revision=68865
- Fix swapped parameters of KeSetIntervalProfile
- Calculate the correct bucket pointer in KiParseProfileList, and actually increment the counter
CORE-10066
svn path=/trunk/; revision=68859
Improve debugging experience when pressing Tab+k, at least with WinDBG, by breaking with a suitable control code (adopt the SysRq one even if we don't use SysRq key for breaking, but instead, Tab+k).
svn path=/trunk/; revision=68855
Addendum to r68851:
- Reset the state of the worker thread *after* having captured the data, not before.
- Fix the explanations given in comments.
svn path=/trunk/; revision=68854
- Remove superfluous dereference in NtCreateProfile
- Allocate the right size for KPROFILE object
- Don't leak the KPROFILE when deleting an EPROFILE
- Avoid some casts
CORE-10066
svn path=/trunk/; revision=68852
Implement the WinDBG Debugger Worker Thread, which is created inside a target process whenever one uses the ".process /i <addr>" (invasive debugging) command using WinDBG in kernel-mode debugging.
See https://www.microsoftpressstore.com/articles/article.aspx?p=2201303&seqNum=2 section "Switching the Current Process Context" (from the book "Inside Windows Debugging" by Tarik Soulami, pp.101-102) for more details.
The names of the variables must be kept as they are, because WinDBG (more exactly, dbgeng.dll) searches for them within the kernel symbols and retrieves their addresses (since those variables are not publicly exported).
svn path=/trunk/; revision=68851
Make its version information compatible with the one of NTOSKRNL (and accessorily its resource file). Addendum to r25937.
svn path=/trunk/; revision=68850
- Only return the flags that the caller asked for in SHELL32_GetFSItemAttributes. Allows us to get rid of a hell lot of calls to CFSFolder::BindToChild which lead to many calls to FindFirstFile.
svn path=/trunk/; revision=68849
Fix x64 compilation:
- Some KDBG symbols for win32k debugging are defined only in x86 platform when _WINKD_ is disabled.
- KdSetOwedBreakpoints is defined only if _WINKD_ is enabled, addendum for x64 to r68842.
svn path=/trunk/; revision=68848
- Avoid statically importing FindFirstStreamW/FindNextStreamW so that our cmd.exe can work on WinXP.
- Accept lowercase /r switch
svn path=/trunk/; revision=68847
- In DirList, initialize stInfo.ptrHead of the dummy node to avoid invalid memory access. Fixes regression in cmd:batch
svn path=/trunk/; revision=68846
- Sync control.c from wine and disable a large part of it that is not needed. Also update the definition of CPlApplet to match wine.
- Make CControlPanel use the new definition of CPlApplet which lets us simplify loading the applets.
- Make CControlPanel to only use unicode and use the new helper functions.
- Simplify the code for the context menu of cpl items.
svn path=/trunk/; revision=68845
- Fix the condition check when setting twice (or more) the same breakpoint.
- Implement support for deferred breakpoints. For more information, see: http://www.osronline.com/article.cfm?article=541 (which also exposes an interesting problem about them).
svn path=/trunk/; revision=68841
It seems that our disk.sys returns "unknown" media type when performing IOCTL_DISK_GET_DRIVE_GEOMETRY on an extended partition.
Not sure how Windows handles this (if any volunteer for a test :-)), in the meantime, forcibly sector size to 512B to allow NTFS driver opening volumes on extended partitions
svn path=/trunk/; revision=68835
The desktop.ini file is only meant to be read if the folder has the R (read-only) or S (system) attributes.
If this causes your favorite folder to stop showing the icon, use "attrib +r <foldername>" or edit it from the properties dialog.
When we add the desktop.ini files, we will also need to add the R attribute to their respective folders.
Followup to CORE-9002
svn path=/trunk/; revision=68834
Totally rewrite the way MFT records attributes are handled.
Up to now, we were having really similar loops, only looking at the resident part of the attribute list, not really caring about how the loop was going.
This was leading to some issues:
- In case the attribute we were looking for was stored in the non-resident part of the attribute list, we would miss it (excepted in the case of FindAttribute() which was properly browsing the whole attribute list).
- In the specific case of FindAttribute(), one would have been able to setup a broken MFT record with the resident attribute list pointing on the non resident attribute list which itself would point to the resident attribute list. In such case, the driver would loop forever caught on the loop, allocating tones of memory. It was possible to trigger this by user space, from a non-privileged user, just by browsing the right directory entry.
- In the case of the other loops (non FindAttribute()), another issue (other than missing attributes) was present, one would have been able to setup a broken MFT record with an attribute of null-length. This would have caused the driver to loop forever on the attribute list. This could be triggered from usermode too. And could be triggered by a non-privileged user.
This commit introduces a new set of functions for attributes browsing: FindFirstAttribute(), FindNextAttribute(), FindCloseAttribute(). It allows safely browsing attributes and handles broken cases. It also performs reading of the attribute list when present and makes sure there's only one read. This method should be the only one to use to browse the attributes.
The whole NTFS code base has been converted to use this newly set of functions. This really simplifies the implementation of FindAttribute(), and prevent unsafe code duplication.
CORE-10037 #resolve #comment Fixed with r68829
svn path=/trunk/; revision=68829
* Fix loading icon info from dekstop.ini. Also took the chance to remove some unnecessary convolution. The old code tried to load the info, but didn't actually make use of the returned string at all.
CORE-9002 #resolve #comment Icon loading should work now. Adding the default desktop.ini files in the right folders will be a followup issue.
svn path=/trunk/; revision=68828
- Towards a complete fix of VGA console attach/detach: a lot of progress is made but few little things need to be checked/adjusted.
- Fix text scroll (at least in text modes) by doing guest-to-guest moves, using the EmulatorCopyMemory function introduced in r68826.
- Fix the computation of the screen rows/columns values stored in the BDA, in graphics modes (in addition to the change of r68090), by dividing the graphics resolution by the character heights & widths. Correct values are indeed needed by some programs, eg. QBasic (I also add a CharacterWidth; normally it should be computable using the CRTC registers, and is always == 8 or 9, but still...).
svn path=/trunk/; revision=68827
Introduce a function for doing guest-to-guest memory copies (given here in a temporary implementation until a proper one is developed). It will be used in my next commit.
svn path=/trunk/; revision=68826
Properly set StreamNameLength (with the length of extra data we append).
This fixes truncated output from FindFirstStreamW/FindNextStreamW
svn path=/trunk/; revision=68822
- Correctly sync ConsoleFramebuffer when we attach/detach VGA from the console (fix memory corruptions introduced by r68720).
- Fix few comments in the process.
svn path=/trunk/; revision=68812
- Move some #defines where they belong; use ARRAYSIZE(...) macro where appropriate.
- Use enumeration for the environment name types.
- Fix BaseCreateVDMEnvironment so that we only convert the paths of TEMP/TMP, PATH, WINDIR and SYSTEMROOT env values to their short form, as done on Windows. To that purpose use the BaseGetEnvNameType_U helper.
- Fix the loop that computed the needed new environment size.
Needed for CORE-9773.
svn path=/trunk/; revision=68806
Simplify the hackssign application usage.
You don't need anymore to specify which VM type you use. The client will attempt to discover it by looking at available shared folders providers.
If it recognizes one, it will perform the assignation.
No Guest Additions/Tools installed will make the tool refuse to assign a drive letter (obviously).
So basically, you just need to issue some: hackssign assign z ReactOS (for example)
svn path=/trunk/; revision=68802
Stack hacks!
Let's introduce hackssign. This application (and its associated driver) are here to allow
users to assign drive letter to their VMware/VBox shared folders.
It relies on two components: a client to communicate the instructions and a driver to execute such instructions.
Do not execute this application nor its driver outside ReactOS. There are barely no security checks nor sanety checks.
You could do substantial damages.
So, let's go back to shared folders state in ReactOS nowadays...
VMware
------
Configure your shared folders
Install VMware Tools
Reboot
From here, you can access your share from cmd or explorer with UNC path (for instance: \\vmware-host\Shared Folders\ReactOS)
Go to C:\ReactOS\bin (or whatever, depending on your setup)
Execute hackssign assign z ReactOS vmware (for instance)
z is the letter you want to give, and ReactOS is the name of your share (you gave it in VMware configuration)
You're done, you can access your share with the Z drive letter
VirtualBox
----------
Configure your shared folders
Install VBox Guest Additions
Reboot
Go to C:\ReactOS\bin (or whatever, depending on your setup)
Execute rosvboxmgmt start
From here, you can access your share from cmd or explorer with UNC path (for instance: \\vboxsvr\ReactOS)
Execute hackssign assign z ReactOS virtualbox (for instance)
z is the letter you want to give, and ReactOS is the name of your share (you gave it in VMware configuration)
You're done, you can access your share with the Z drive letter
Note that you can delete an assignement by performing a hackssign delete z (or whatever drive you want to remove).
In such case, the share remains available with its UNC path.
svn path=/trunk/; revision=68794
[OLEAUT32]
[DDK]
[PSDK]
[STLPORT]
[CPPRT]
Port the vs2015 fixes to also work on x64
[HHCOMP]
Fix compilation with VS in x64 mode
svn path=/trunk/; revision=68791
- Hackplement support for parsing UNC paths. We are not able to enumerate UNC shares yet. However until it is properly implemented we will be able to enter a UNC patch in the addressbar or start explorer with a path that points to a UNC share.
svn path=/trunk/; revision=68787
* Use lazy enumeration of the nt objects and registry keys, as intended for the IEnumIDList interface.
* Display of the NT Object creation date has been lost in the process, but it was only really used by symlinks.
* Symlink target display doesn't appear to work at the moment, will fix later.
svn path=/trunk/; revision=68783
Add the "rosvboxmgmt" tool.
It's purpose is to allow to interact with the VBoxSF driver as we don't have working MPR yet.
In order to have UNC path available, all you need to do so far is rosvboxmgmt start. All the rest isn't mandatory.
svn path=/trunk/; revision=68778
Implement the TokenImpersonationLevel case of SeQueryInformationToken().
This fixes VBoxSF driver not being able to expose shared folders in ReactOS
svn path=/trunk/; revision=68777
- Add support for specifying a parent window handle for the screensaver configuration dialog, adapted from patch by Timo Kreuzer, see CORE-5718.
- Fix failure return values from the helper functions.
- Add TranslateMessage call in the message pump.
- Get the correct left/top coordinates for the screensaver, being multi-screen aware.
- Use Win-compatible window names & styles for the screensaver preview dialog & screensaver window, compatible MS' scrnsave.lib.
svn path=/trunk/; revision=68776
- Move the properties dialog for the recycle bin in its own file. The implementation of the recycle bin is overly complicated and keeping with it a dialog for editing some registry entries makes it worse.
svn path=/trunk/; revision=68775
- Create a new sublibrary for shell32 that will contain the implementation of CDesktopBrowser and desktop dde support. Link it to both shell32 and rshell. Also add a win8+ hack.
svn path=/trunk/; revision=68769
- Take an extra reference on CDefView during the lifetime of the view window, and correctly handle recursive WM_DESTROY messages
CORE-9932
svn path=/trunk/; revision=68761
Rewrite FsRtlRegisterUncProvider() and FsRtlDeregisterUncProvider() so that they can support MUP in case it's required
They also support DFS
svn path=/trunk/; revision=68759
Changes in preparation for CORE-9773
- Split DosLoadExecutable into DosLoadExecutable & DosLoadExecutableInternal, the latter one can be used for small programs embedded in ntvdm.exe (will be used for integrated command.com).
- Factorize common loading code in DosLoadExecutable(Internal); just before starting a program, set the CPU registers to the default values DOS use; see comments in the code for more details (some programs expect those values).
- Set a correct termination type (hiword in the returned ErrorLevel) when terminating programs (the value is different for TSRs and for regular programs).
CORE-9773 CORE-9729 CORE-9711 CORE-8247
svn path=/trunk/; revision=68746
May thou rest in peace!
(...or rather live on in MSPAINT_NEW's commit history)
[MSPAINT_NEW]
I hereby pronounce thee MSPAINT!
svn path=/trunk/; revision=68741
- CDesktopFolder: Create two interal fs folders that wiill eventually take care of all file support for the desktop folder.
- Implement some methods using the internal fs folders.
svn path=/trunk/; revision=68736
Add/Update Chinese (zh-CN) translation by Henry Tang Ih
CORE-9003 #resolve #comment Committed v7 Patch, as the author told me, this resolves this report. Thx once more for translating ROS to Chinese ^^
svn path=/trunk/; revision=68732
- Use SHELL32_GetGuidItemAttributes, SHELL32_GetFSItemAttributes, SHELL32_BindToGuidItem and SHELL32_GetDisplayNameOfGUIDItem in CControlPanelFolder, CDrivesFolder and CFSFolder instead of using functions that accept all sorts of pidl types.
svn path=/trunk/; revision=68730
- Split SHELL32_GetItemAttributes to SHELL32_GetGuidItemAttributes and SHELL32_GetFSItemAttributes.
- Add a couple helper functions that will reduce code duplication in folders with reg items: SHELL32_BindToGuidItem, SHELL32_GetDisplayNameOfGUIDItem
svn path=/trunk/; revision=68729
- CAdminToolsFolder: return proper attributes when no items are specified. (This is fine for reg folders but doesn't work for fs folders).
- CFontsFolder: fix GetAttributesOf as above. Fix Initialize method to return success. All shell folders should support this method.
- CNetFolder: Return the name of the folder when asked.
- CPrinterFolder: It doesn't have subfolders so it doesn't make sense to implement BindToObject.
svn path=/trunk/; revision=68728
Change console processes priority when the console gains or loses focus. FIXME: Win2k3 backtraces show that we should call NtUserSetInformationProcess(unimplemented in ROS) to set some win32 process foreground flags.
CORE-9911
svn path=/trunk/; revision=68716
- Don't use hardcoded structure types in sizeof's where possible.
- Fix the parameters of NtSetInformationProcess calls in CsrSetBackground/ForegroundPriority.
CORE-9911
svn path=/trunk/; revision=68715
- When we have few R/W IO port handlers, just register them directly instead of using a wrap-up function.
- Remove hardcoded bit flag values.
svn path=/trunk/; revision=68710
- Add some missing MouseResetCounters calls when enabling/disabling mouse reporting, and an ACKnowledge signal when we set mouse defaults.
- When we have few R/W IO port handlers, just register them directly instead of using a wrap-up function.
svn path=/trunk/; revision=68709
- When we have few R/W IO port handlers, just register them directly instead of using a wrap-up function.
- Start implementing the PS/2 keyboard command handler.
- Report scancodes only if the keyboard is enabled.
See r68415.
CORE-9920
svn path=/trunk/; revision=68708
Make sure to attach to the specified process before dereferencing ClientInfo, which is a user mode structure.
CORE-l0017 #resolve
svn path=/trunk/; revision=68702
There will come the day... the day I will find you, inventer of the crappy BOM b***sh*t and you will suffer. Same goes to MS notepad using that crap!
svn path=/trunk/; revision=68688
- Ignore IMAGE_SCN_TYPE_NOLOAD when loading image sections, as shown by ntdll_apitest:NtMapViewOfSection. This avoids errors when trying to relocate .rossym sections (since they were not loaded but Ldr tried to change their protection)
CORE-8384
svn path=/trunk/; revision=68678
- When paging in data for an image section, first flush outstanding cached data since paging reads are noncached. Fixes failure to create section in ntdll_apitest:NtMapViewOfSection/Test_NoLoadSection
- Gracefully handle out-of-pool situation
CORE-8384
svn path=/trunk/; revision=68677
New programs for rapps by Petr Akhlamov
CORE-9152 #comment Partial sync skipping DFend and QBittorrent AND WinFF because there is no direct link mirror. Additionally I updated the stuff to more recent versions AND fixed the D/L links....
svn path=/trunk/; revision=68657
Adding New Apps for rapps and Removing Some Unneedful Spaces in aklepad.txt by Henry Tang Ih
CORE-9953 #comment, Patch committed incl. German translation and some fixes. Still missing: Unlocker and GNU Octave
svn path=/trunk/; revision=68655
- Use newer implementation of RtlActivateActivationContextUnsafeFast(): its time finally has come (see r52615 and r52612). It returns proper return value instead of pushing STATUS_SUCCESS into PRTL_ACTIVATION_CONTEXT_STACK_FRAME type and its "Trying to activate improper activation context" warning pops up all the time (its disabled in trunk to prevent debug log spam).
svn path=/trunk/; revision=68654
Adding New Apps for rapps and Removing Some Unneedful Spaces in aklepad.txt by Erdem Ersoy
CORE-9953 #comment Added Agat, Audacity, Gens, HexEdit, Shed, UltraISO and VBA-SDL because of the prove in image form that it works. Rest ist still not committed.
+ Removed the UTF BOMs again!
+ Added German Translations
+ Corrected the Coding to UTF-8
svn path=/trunk/; revision=68648
Change Trash to Recycle Bin by Lee Schroeder
CORE-8391 #resolve #comment Committed the big one with changes to all RC files, because it's the right way to do that. All these strings are originated from the english resource and NEVER were translated up to now, so we keep these strings in sync. Second argument. Trash is not the right word here (YES, a non native dares to say this ^^) We use the Windows way here, unless someone gives me a REALLY good reason not to ^^
svn path=/trunk/; revision=68645
- In AccpOpenNamedObject, immediately save the last error in case of OpenService failure instead of calling another function in between.
CORE-9990 #resolve
svn path=/trunk/; revision=68636
Add winspy++ to rapps by Stefano Toncich
CORE-9659 #resolve #comment Committed with swyter's suggestions and a german translation included.
svn path=/trunk/; revision=68635
- Enable relocation debug prints again. While it's not a critical error anymore when they happen it's still critical for debugging issues.
svn path=/trunk/; revision=68626
-include the testdata in all targets
-load it from the correct path even when the application is using a different working directory
svn path=/trunk/; revision=68623
VfatWrite (but not VfatRead) is supposed to return STATUS_INVALID_USER_BUFFER
if an error occurred while locking the buffer.
[KERNEL32]
Reading 0 bytes using ReadFile doesn't always succeed on Windows.
svn path=/trunk/; revision=68620
In CcCopyData, Buffer can be NULL during read/write operations.
[FASTFAT]
Use SEH to catch exceptions thrown by MmProbeAndLockPages.
Lock the user buffer before changing the file allocation size.
svn path=/trunk/; revision=68619
- Load sfc_os.dll because applications have a tendency to create remote threads in winlogon with sfc_os function pointers, assuming that it is loaded. See https://bitsum.com/aboutwfp.asp
CORE-9598 #resolve
svn path=/trunk/; revision=68615
PS2:
- By default all the PS/2 ports are disabled. They become enabled by the BIOS at the POST step.
- Similarly it is the BIOS POST that sets up the PS/2 controller configuration byte.
- Synchronize the value of bit 2 "System flag" and bit 4 "Keyboard enable flag" in the status register, according to what is set in the controller configuration register. What is the "keyboard enable flag" ? See http://www.os2museum.com/wp/the-dos-4-0-shell-mouse-mystery/ for more details...
HW MOUSE:
- Resetting the mouse sends also an ACKnowledge byte too...
BIOS32:
- Fix the reported number of bytes in the BIOS configuration table.
- Enable the PS/2 ports in the POST.
- Implement the "Pointing Device BIOS Interface" INT 15h, AH=C2h, AL=00h...09h based on VBox OSE & SeaBIOS; we should make our PS/2 mouse driver use it.
The real call to INT 15h, AH=C2h function is still disabled because our mouse driver doesn't react well with it, when we run some applications like MS Diagnostics.
PS2 MOUSE DRV:
- Update copyright notice;
- Remove 2 useless functions;
- I've put in comments in the code the places where calls to the BIOS ps/2 mouse interface are needed.
svn path=/trunk/; revision=68613
Irp->UserBuffer being NULL doesn't indicate any error. It could be that the
caller really wants the result stored at address NULL (which can be valid,
and is valid by default for programs like NTVDM).
svn path=/trunk/; revision=68607
- Copy-paste error fix in the initialization of the collating table.
- Fix DosCombineFreeBlocks so that it doesn't say "DOS memory arena corrupted" because while combining blocks, the current block became the last one and we tried to merge it with a next block which, by definition, cannot exist (see comment in the code).
- Remove a spurious call to DosCombineFreeBlocks in DosResizeMemory which was forgotten in r68596.
- Check the validity of the encountered MCBs during the loop for linking or unlinking the UMB chain to the main arena chain.
- Fix the size of the created UMB blocks.
svn path=/trunk/; revision=68606
- Use a static buffer for read or writes of "few" bytes (and allocate one for larger operations).
- Writes of zero length, in DOS, truncates or extends the file to the current position of the file pointer. This fixes some "corruption" in some files (so far, only .INI files) in Windows 3.11 installation.
svn path=/trunk/; revision=68604
- Implement OEM bitmaps sizes for server information. If more is need, it will be added. This will be plugged in later.
svn path=/trunk/; revision=68603
- Implement function 4Dh "Get All Handles Number of Pages", 54h "Get Handle Directory / Search for Named Handle / Get Total Number of Handles"
- Fix the return error of few functions.
- Start handling the "system handle" (special handle 0; see the specs for more details); WIP.
svn path=/trunk/; revision=68601
- Increase the maximum number of EMS handles to the maximum permitted by the specification (ie. 255 handles)
- Zero out EMS handles names.
- EMS status are always returned in the AH register!
- Implement functions 4Bh "Get Number of Opened Handles" and 4Ch "Get Handle Number of Pages"
- Remove an hardcoded value.
- Cosmetic change: rename EMS_STATUS_OK to EMS_STATUS_SUCCESS to comply with the name convention used also in XMS, etc...
svn path=/trunk/; revision=68600
- Add some level of "Advanced debugging" (see ntvdm.h) which one can adjust to enable/disable debugging features inside NTVDM (this can be useful as long as NTVDM is under heavy bugfixing. When it will be more perfect, this stuff will be removed).
- Add the possibility to load option ROMs at a given segment. Currently their list should be specified from inside ntvdm.c (in the BiosInitialize call), but I plan to make it available from a registry option (or via command-line for NTVDM-standalone mode).
- Start to separate the initialization of "static" BIOS data (stuff that lives in ROM space) and initialization of "dynamic" BIOS data (eg. initializing the interrupt vector table, the BIOS data area at segment 40h, ...) so that we may be able to reuse part of our code to be able to more-or-less run external (16-bit) BIOSes, or the Windows NTVDM BIOS that uses BOPs to run some of its stuff in ntvdm in 32-bit (as we do for our 32-bit BIOS, except that *all* of our bios is 32-bit, not just some parts). Also, some file reorganization will be in order there soon...
- Add video BIOS version information in memory so that tools such as Microsoft Diagnostics can correctly recognize our video BIOS (btw, we try to emulate the functionality of Cirrus' CL-GD5434).
- Correctly put video BIOS ROM header (+ checksum) in memory so that it is recognized as such by diagnostics tools.
- During BIOS POST, scan for ROMs starting segment 0xC000 (where video ROMs reside).
- Store statically the BIOS configuration table.
- Fix INT 16h, AH=12h "Get extended shift states" so that it correctly returns the state of right Ctrl and Alt keys.
- Fix bit-setting state; report that our keyboard is 101/102 enhanced keyboard.
- Correctly set the error return values (AH=86h and CF set) when a function of INT 15h is unsupported.
- Implement INT 15h, AH=C9h "Get CPU Type and Mask Revision"; INT 1Ah, AH=02h "Get Real-Time Clock Time" and Ah=04h "Get Real-Time Clock Date" by reading the CMOS.
- Implement CMOS century register support.
svn path=/trunk/; revision=68598
Remove broken check. Broken cases are already handled by upper if case.
This fixes the regression that leaded some valid ISOs not to be read anymore by ReactOS
CORE-9254
svn path=/trunk/; revision=68595
- Don't accept 64 bit PE files on x86 (will cause use of uninitialized variable ImageBase). CORE-9955
- Remove a pointless check in MmMapViewOfSection
svn path=/trunk/; revision=68593
Fix build on MSVC by rewriting the code in *STANDARD* C++ !! (and not into some strange idiom called "GCC-C++"). I suggest also to write a proper class for dynamically-allocated (resource) strings instead of either having the static arrays of hardcoded sizes, or being tempted to use non-standard constructs as the one I just saw.
(and btw, instead of defining a new "SIZEOF()" macro, there is one which already exists in the PSDK called "ARRAYSIZE()" which just does the correct job).
svn path=/trunk/; revision=68587
EMS:
- Introduce (and use) helpers for checking validity of EMS handles.
- Do not hardcode the EMS page frame segment, but instead allow it to be changed (for now, it is still set to a default value; in the future, via some configuration file or via the registry). This is done by acquiring a UMB block (see after).
XMS:
- Implement functions 0x01 "Request HMA" and 0x02 "Release HMA".
- Fix the return value of functions 0x04 "Global disable A20" and 0x08 "Query free Extended Memory"; simplify code of function 0x0B "Move EMB".
- Halfplement function 0x0F "Reallocate Extended Memory Block" in the simple case of size reduction (size expansion is left to the programmer as an exercise :PP )
- Rewrite the UMB provider support (functions 0x10, 0x11, 0x12) by calling the Upper Memory Area manager helpers (see after) (this is closer to reality: UMBs are either provided by XMS driver itself, or by an EMS driver which hooks into the XMS driver chain -- as it is done with MS' himem+EMM386; sometimes all that stuff is contained inside one driver only --) instead of calling back into DOS. This is the DOS which calls XMS for getting the UMB blocks and initializing them! (and not the other way around as it was done in r68001!).
NTVDM:
- Introduce an "Upper Memory Area manager" which maintains a list of areas of upper memory (>= A000:0000 and <= FFFF:000F) that can be used as RAM blocks. It is intended to work closely with the NTVDM memory manager and be used by XMS for getting possible free UMBs, and by VDDs for implementing the VDDInclude/ExcludeMem APIs (which adds/remove blocks in/from the UMB pool; those are unaccessible to DOS if those APIs are called after NTVDM have been started, but are accessible by XMS).
DOS:
- Add a helper function for detecting early DOS arena corruptions (for debugging purposes only).
- Make the DOS memory manager really UMB-compatible. This means:
* not hardcoding the start of the UMB chain;
* getting all the available UMB blocks from XMS and initializing them, marking the reserved blocks as read-only (with a correct header; reserved blocks are eg. VGA memory area, ROM blocks...).
There is room for improvements obviously (see the FIXMEs in the code). Used documentation is mentioned in comments in the code.
This commit should fix quite some apps, as well as it fixes corruptions of loaded ROMs in upper memory: that's how I came into working on fixing the UMB support. In other words, during those two last weeks, I was like in: http://i.imgur.com/zoWpqEB.gifv
CORE-9969 #resolve
svn path=/trunk/; revision=68586
- Remove some hardcoded values.
- Reshuffle again DOS initialization to better reflect how it is done in the real world (see "Advanced MS-DOS Programming" by Ray Duncan, Chapter 2 "MS-DOS in Operation"): split DOS data stuff into DOS BIOS data, and DOS kernel data areas.
In preparation for an upcoming commit.
svn path=/trunk/; revision=68585
- use optimal buffer size to load null terminated strings using LoadString
- add printing-related menu entries and dialogs (no printing functionality yet)
svn path=/trunk/; revision=68584
* Rework the WIN7_COMPAT_MODE into actually just disabling the incompatible functions, and introduce WIN7_DEBUG_MODE which does the rest of the "hacks" I used to ease development.
svn path=/trunk/; revision=68580
- When directly submitting the results to the web service, make sure to URL-encode the test log, or & signs will terminate the log and make Testman see the test as crashed (and have all other kinds of possible consequences)
svn path=/trunk/; revision=68578
- Skip user32:msg_paint test_paint_messages if running on Windows in non-interactive mode. This should allow WHS-Testbot to get a bit further
ROSTESTS-185
ONLINE-441 ROSTESTS-184
svn path=/trunk/; revision=68575
- Add support for intsafe signed Add functions
- Guard signed math in ENABLE_INTSAFE_SIGNED_FUNCTIONS
CORE-9947 #resolve
svn path=/trunk/; revision=68573
NtQuerySystemInformation:
- Windows Vista and later: Check the information class before probing the buffer.
- Pre-Vista Windows: Check the information class after probing the buffer.
- Pre-Vista Windows: Fixed the aligment check for invalid information classes.
- Pre-Vista Windows: The SystemFlagsInformation and SystemKernelDebuggerInformation classes return no required length in case of an error.
This fixes all ntdll_apitest:NtSystemInformation fails.
svn path=/trunk/; revision=68571
- move bitmap and DC initialization to ImageModel
- remove unused global variables
- remove copy-pasta bug from SelectionModel::DrawSelection
svn path=/trunk/; revision=68565
Show shutdown dialog at the logon screen if the user wants to shutdown. Patch by Jared Smudde.
CORE-9919 #resolve #comment Thanks a lot!
svn path=/trunk/; revision=68562
Add a case for VSSolution generation with VS14. It DOES NOT WORK with the cmake version we use currently, but it's better to have the error rather than generating ninja files without warning.
svn path=/trunk/; revision=68551
- Make <cmath> functions available in top-level namespace. Fixes stlport build with VS2015.
- Remove unused __cmath_power and __pow_helper
svn path=/trunk/; revision=68485
- Add ellipsis to the caption text if the window size is reduced. See CORE-9474, it can use more tweaks.
- Also after all this, DefWndNCPaint can soon be moved into Win32k, draw.c in already in. This could help with caption redrawing while moving the window.
svn path=/trunk/; revision=68476
- Improve painting messages, separated functions and dual functions for isolating drawing issues. Next thing to do is fix Set Window Position; Still no SWP_FRAMECHANGED support.
- See CORE-7447 for test results.
svn path=/trunk/; revision=68474
- Use the partition list code from usetup. Scan all harddisks at startup and keep the list alive as long as diskpart is running.
- Use the partiton list in the 'select disk' and 'list disk' commands.
- Implement the 'list disk' and 'list partition' commmands.
- Add required strings.
svn path=/trunk/; revision=68473
- Skip ole32:dragdrop test_DoDragDrop if running on Windows in non-interactive mode. This should allow WHS-Testbot to get a bit further
ROSTESTS-182
ONLINE-441 ROSTESTS-181
svn path=/trunk/; revision=68441
- Remove an unused but set variable. Fixes compilation with FEATURE_UNIX_FILENAME_COMPLETION defined. Patch by Lee Schroeder.
CORE-9913 #resolve
svn path=/trunk/; revision=68420
- Move some #defines into their correct headers.
- Fix some DPRINTs.
- Add missing DOS SYSVars values (memory-related), confirmed by DOS undocumented & FreeDOS.
- Implement INT 21h, AX=5700h and 5701h "Get/Set File last-written date & time".
- Implement INT 2Fh, AH=13h "Set Disk Interrupt Handler" chain support, which is an obscure functionality (to make story short: allows inserting disk filter drivers): see the comments inside the code (dos.c/dos.h) for more information.
svn path=/trunk/; revision=68418
We don't support any PS/2 keyboard command for now. Just return ACKnowledge. This unblocks some programs that want to initialize the keyboard by sending keyboard commands and then performing polling on the port until "valid" data comes out. (unblocks e.g. DOS Mugen game, amongst others...).
svn path=/trunk/; revision=68415
Pasting a larger-than-current-canvas image now DOES resize the canvas.
(adapted from a patch by Gian Sass)
CORE-9674 #resolve #comment Fixed in r68398
svn path=/trunk/; revision=68398
- Whitespace fixes.
- Improve some DPRINTs.
- hardcoded_values--;
- Fix DisplayMessage() for NULL-terminated strings.
- Free the allocated block of memory in the mouse driver cleanup procedure.
- Properly inherit the parent process environment block if needed.
- Return the correct last error if DosCopyEnvironmentBlock fails.
- Big ifs turned into switch.
- Implement some INT 2Fh DOS multiplex functions (AX=1200h "Installation check", AX=1203h "Get DOS data segment", AX=1214h "Compare FAR pointers", AX=122Fh "Set DOS version to return"); remove the DPRINT for AX=1680h "Release Current Virtual Machine Time-slice".
- Stubplement INT 2Ah "DOS critical sections / network" (it just monitors calls to itself at the moment).
- Use the boot drive root path as the current directory if we failed retrieving a valid one.
- Offsetize the DOS_SYSVARS members (so that I don't have to compute by head the offsets, especially when some of the members is a structure from which I don't know in advance its size); add some C_ASSERTs on the size of DOS standard structures.
- Move the NullDriverRoutine buffer outside the sysvars buffer (because it has nothing to do inside it).
- In ConDrvReadInput: do not echo the first part of an extended character.
- Add basic support for changing the reported DosVersion.
svn path=/trunk/; revision=68395
Enable the 'Edit...' and 'Remove' buttons on the Advanced IP Settings dialog only if the 'IP addresses' and 'Dafault gateways' lists are not empty.
svn path=/trunk/; revision=68392
Show an error message if formatting a partition fails.
Based on patch by mna.
CORE-7969 #resolve #comment Thanks a lot!
svn path=/trunk/; revision=68388
Since CsrClientCallServer returns the value of ApiMessage.Status, then just use ApiMessage.Status instead of declaring another Status variable for querying the return value of CsrClientCallServer (continuation of r62460).
svn path=/trunk/; revision=68384
- Add the IAtlMemMgr interface
- Add a basic implementation of CWin32Heap which just implements the base IAtlMemMgr
- Required for CAtlString / CAtlStringMgr (coming later)
svn path=/trunk/; revision=68381
- Use the correct HINSTANCE in the dll. Fixes loading strings for tooltips, etc.
- Rename CMainWindow to CDeviceManager
- Fixup the decelerations and add missing SAL decoration
svn path=/trunk/; revision=68378
- Add few remaining members to the SYSVARS list.
- Implement retrieving the (DOS) boot drive (by using the host boot drive letter from %SYSTEMDRIVE%).
Should fix Win3.11 and MSD 2.0+ boot drive retrieval.
svn path=/trunk/; revision=68377
- Rearrange the file structure, move the properties/resource/misc stuff to a ./properties folder
- Add a CMakeLists.txt file to combine both old and new code. Should now build with the msvc RosBe (doesn't yet run)
svn path=/trunk/; revision=68371
I know this *_new thing is a bit overused, but there are a lot of changes coming to devmgr and rather than take it out of the build for a few days, it's easier to do it this way
svn path=/trunk/; revision=68369
- last few fixes to the device manager code to get it building with rosbe (msvc)
- Next steps are to merge it with the existing devmgr code (mostly done in my WC) and get it running via mmc.exe & devmgmt.msc
svn path=/trunk/; revision=68367
Implement basic DOS country info (some stuff is not implemented yet, but the basic functionality is there). This is needed by Microsoft Diagnostics 2.0+ (amongst others)...
See also r66039.
CORE-9903 #resolve
svn path=/trunk/; revision=68363
- Unambiguously specify top-level namespace for Win32 API functions in preparation for upcoming ATL changes. Based on a patch by Benedikt Freisen.
CORE-9675
svn path=/trunk/; revision=68359
Make the keyboard layouts selection not dependent on the selected language.
Patch by joao.jeronimo.89.
CORE-9630 #resolve #comment Thanks a lot!
svn path=/trunk/; revision=68354
- Show that PAGE_NOCACHE also works for image and data sections
- Show that *MapViewOfSection returns user space addresses
CORE-9808
svn path=/trunk/; revision=68352
Continue streams integration:
- NtfsGetFileSize() will now return the file size depending on the open data stream
- NtfsGetFileSize() will also optionally return allocated size
- In NtfsMakeFCBFromDirEntry(), when initializing FSRTL_COMMON_FCB_HEADER entry, use data stream sizes
svn path=/trunk/; revision=68348
- Implement INT 10h, AH=13h "Write String" function.
- Fix VidBiosPrintCharacter to use the colour attribute only in graphics mode, or when explicitely needed.
- Fix some special cases where specifying a BIOS mode page of 0xFF means "use current page".
- Use a macro to check whether a given mode number specifies a text mode, and use it where needed.
svn path=/trunk/; revision=68347
- Add a separate class for the root node
- Move creating the action menu items to a generic function so we can use it for both the context menu and the main menu
- Create the main action menu as a dynamic popup menu. It doesn't work quite the same as the menus via the resources, so if any menu expects know how to fix this, be my guest
svn path=/trunk/; revision=68342
- Add description of the 'L' key to the partition selection page.
- Make the 'ENTER' key work for logical partitions too. Selected unpartitioned space will be converted to a logical partition.
Patch by Gerhard Gruber (sparhawk).
CORE-9641 #resolve
svn path=/trunk/; revision=68339
- Implement dynamic context menu for device and class nodes
- Fix CanUninstall to return correct results
- Strings hardcoded for now, will fix soon
svn path=/trunk/; revision=68334
Fix user buffer handling for FSCTL_GET_NTFS_VOLUME_DATA. It fixes NTFSInfo.
We're just lacking a few information in the output data now
CORE-8725
svn path=/trunk/; revision=68327
Time to free some Sysinternals tool: ntfsinfo.
To make it short, this tool dumps various information about a NTFS volume and its reserved meta-data files
Our version comes with three advantages compared to the Russinovich's tool:
- It's FLOSS
- It works properly on NT5+ (developed with W2K3 & W7) whereas R's cannot display meta-data files information
- It will open a volume by default if none provided
One issue so far: it doesn't work properly on ReactOS!
CORE-8725
svn path=/trunk/; revision=68326
- Skip msi:msi test if running on Windows in non-interactive mode. This should allow WHS-Testbot to get a bit further
ROSTESTS-180
ONLINE-441 ROSTESTS-179
svn path=/trunk/; revision=68319
Add CmpDestroySecurityCache() and CmpDestroyHiveViewList() stubs and call them in CmpDestroyHive and CmUnloadKey().
CORE-6492 #resolve #comment Thank you Hermes! This is exactly what I needed!
svn path=/trunk/; revision=68313
Validate the stream we're trying to open properly exists.
This check might have to be moved later on when the driver switches to RW
svn path=/trunk/; revision=68309
Always gather the size of the unnamed stream for directory display.
This fixes file size display when there are several data streams available
svn path=/trunk/; revision=68308
- Do not forget to initialize LoadDll->NamePointer in DbgkMapViewOfSection!!
- Just copy the NamePointer (pointer to pointer to file name) in DbgUiConvertStateChangeStructure. See the description of the lpImageName member of the LOAD_DLL_DEBUG_INFO structure in https://msdn.microsoft.com/en-us/library/windows/desktop/ms680351(v=vs.85).aspx for more details.
This fixes some debugging stuff with GDB (see the below-mentioned report).
Adapted from a patch by andy-123 (whom I don't remember his name^^),
CORE-7019 #resolve #comment Fixed in r68306
CORE-8622 #comment An updated fix was committed in r68306
svn path=/trunk/; revision=68306
HvFree:
- Free the BaseBlock.
- Do not free the hive itself because the HHIVE is part of the CMHIVE structure and freeing it here could be an unpleasant surprise.
[NTOSKRNL]
CmpDestroyHive: Free the CMHIVE after calling HvFree.
CmUnloadKey: Free the hive storage, the hive locks and the CMHIVE properly.
svn path=/trunk/; revision=68303
Implement support for NTFS $DATA streams:
- The driver is now able to read various streams for a same file, using the same syntax as Windows.
- This fixes to read (in general) files with multiple streams where reading unnamed stream was leading to read beyond file end
- Also fix reading small files which are smaller than a sector
For demo, see: http://www.heisspiter.net/~Pierre/rostests/NTFS_Streams.png
svn path=/trunk/; revision=68302
While handling IRP_MN_QUERY_DIRECTORY, in case there is no $FILE_NAME attribute, dump file attributes & MFT ID.
This fixes ASSERT failure when browsing some Win7 volumes
svn path=/trunk/; revision=68290
Don't attempt to open the unnamed stream from $DATA attribute on file lookup. It was unused & leaking.
It fixes opening files that don't have unnamed stream (even though we cannot read there contents yet as we only support unnamed stream)
svn path=/trunk/; revision=68285
- Add a stub implementation for IActiveIMMMessagePumpOwner.
- Use #ifdef __REACTOS__ to mark a ROS-diff
CORE-4953 #resolve
svn path=/trunk/; revision=68275
- Mark the page as being on the standby list before dereferencing it in MmFreePagesFromMdl. Since the PFN is marked as deleted, MiDecrementReferenceCount will correctly insert it into the free list, but this is required to satisfy MiDecrementReferenceCount's sanity check.
CORE-9877 #resolve
svn path=/trunk/; revision=68273
- Add support for selecting any device when refreshing the view. This allows us to re-select a device after it's been enabled instead of collapsing the tree and losing track of what you did.
- Plug some memory leaks
- HeapAlloc -> new
svn path=/trunk/; revision=68272
Don't attempt to read the unnamed stream of the $DATA attribute of each file matching:
- We don't need such attribute later on
- In case there's no such unammed stream, finding the file fails, whereas the file really exist
This fixes (at least here) browsing Win7 NTFS system drives, where our driver was always failing on pagefile.sys
svn path=/trunk/; revision=68268
- Add basic functionality for enabling and disabling devices. Make it accessible via the toolbar and main menu
- Implement checking whether a device has a problem and if a device can be uninstalled
- Implement getting, setting and removing device flags in the install params
- Fix creating and destroying the (currently empty) context menu
svn path=/trunk/; revision=68265
- ReAllocateLayoutBuffer: Write all new partition table entries to the disk.
- UpdateDiskLayout:
- Create link entries for logical partitions.
- Wipe unused logical partiton table entries.
svn path=/trunk/; revision=68257
- Fix a GCC warning (error on Macs) concerning the printf "%Iu" specifier.
- To make sure data included by bin2c, that need to be interpreted as a (long) string, is correctly NULL-terminated, introduce an output format called "STR": this creates a long character array using the "\xXX" format.
- To circumvent a silly limitation of MSVC (all versions?) about the maximum length (65535 bytes) of a char string (aka. char MyArray[] = "...my_long_string...";), introduced yet another output format called "BINSTR" which creates an array of bytes that is NULL-terminated (aka. char MyArray[] = {0xde, 0xad, 0xbe, 0xef, 0x00};).
- Finally, the output format "BIN" is the regular bin2c format (simple array of bytes).
[HAL_PCIDATA][FREELDR_INSTALL]
Use the above-described functionality (for HAL_PCIDATA, use BINSTR format because the PciVendors data is otherwise too large to be stored in "char_string" format).
svn path=/trunk/; revision=68255
- Reset FunctionDescriptorCount to zero in USBCCGP_LegacyEnum since the function can be called multiple times
CORE-9226
svn path=/trunk/; revision=68250
- Flush cout after each write as already done by Colin in r66855, per ROSTESTS-158
- Use DbgPrint instead of OutputDebugStringA again because the latter only calls the former anyway
Fixes test summary lines not being recognized by Testman, especially on VMware.
A little summary so we don't keep going back and forth with this function:
1) Only writing complete lines is required to that the output doesn't mix with debug output from other components. See r55618
2) OutputDebugStringA splits its input into 512-byte-sized blocks with no regard for line breaks, so using it with strings larger than 512 bytes breaks (1).
3) OutputDebugStringA eventually calls DbgPrint("%s", string) anyway so using it with chunks smaller than 512 bytes is not an optimization
As a result, yes this function MUST split up the lines itself, this can't be optimized or simplified away! kthxbye
ROSTESTS-178 #resolve
svn path=/trunk/; revision=68246
In case of directory enumeration, validate the record earlier to really prevent any potentiel buffer overflow
CORE-9254
svn path=/trunk/; revision=68244
Revamp r68233:
- Don't duplicate code, implement checks in a helper function
- When checking name content, do it earlier for better performances
- Add extra checks to prevent a potential buffer overflow in case of Joliet names with illformed entries
CORE-9254
svn path=/trunk/; revision=68239
UpdateDiskLayout:
- Resize the layout buffer if necessary.
- Start writing logical partitions to the disk.
- Disable the code that wipes unused table entries. May be enabled later.
Right now, you can only create one logical partition because the link entries are not created yet.
svn path=/trunk/; revision=68235
Add a few sanity checks to our handling of ISO 9660 / Joliet:
- Null name entries are forbidden
- Degenerated entries (mistmaching sizes) reveal broken layout
In both cases, the lookup for a file is aborted and the CD considered as corrupted by the FSD.
explorer displays empty CDs then.
CORE-9254 #resolve #comment Fixed with r68233
svn path=/trunk/; revision=68233
- Add basic implementations of RtlApplicationVerifierStop and RtlCopyMappedMemory for the benefit of some Windows dlls
CORE-9857 CORE-9858 #resolve
svn path=/trunk/; revision=68232
UpdateDiskLayout:
- Set the proper HiddenSectors value.
- Fix counting the PartitonaNumber.
UpdatePartitionNumbers() has become obsolete. Remove it.
svn path=/trunk/; revision=68226
- Add a test for SystemFlagsInformation that demonstrates the parameter checks performed by NtQuerySystemInformation/NtSetSystemInformation
CORE-9849
svn path=/trunk/; revision=68225
As shown by the non commited yet tests from Thomas, we have to check for privilege in NtSetSystemInformation - SystemFlagsInformation
svn path=/trunk/; revision=68224
- Probe input buffer for read in NtSetSystemInformation() and call the helpers function in a PSEH block
- For the NtSetSytemInformation - SystemSessionCreate specific case, as we return session ID, probe for write directly there.
svn path=/trunk/; revision=68223
Don't trust the user!
Probe buffers in NtSetSystemInformation - SystemSessionCreate and in NtSetSystemInformation - SystemSessionDetach
svn path=/trunk/; revision=68221
Begin upgrading the VGA emulation to SuperVGA emulation
(Cirrus Logic CL-GD5343 compatible).
This is still a WIP. So far only the VCLK and MCLK have been implemented.
svn path=/trunk/; revision=68216
- Fix assertion failure in 2nd stage by setting s_IsTerminated when an instance does not yet exist.
- Rename CComCreatorSingleton to CComCreatorCentralInstance since it's not /technically/ a singleton
svn path=/trunk/; revision=68215
- Also make My Computer a singleton, as shown by the CMyComputer test. With r68210 and this commit, SHFileOperation on a large number of files is approximately 3 times as fast.
CORE-9839 #resolve
svn path=/trunk/; revision=68212
- Introduce a CComCreatorSingleton class and use it for CDesktopFolder. Multiple calls to SHGetDesktopFolder will now return the same instance, which provides a massive speedup in many shell operations.
CORE-9839
svn path=/trunk/; revision=68210
- Add a test showing that repeated calls to SHGetDesktopFolder return pointers to the same object, and that its CreateViewObject method instead creates new objects.
CORE-9839
svn path=/trunk/; revision=68200
- Use a separate heap allocation for the thread parameters to ScServiceMainStub, since the thread can live longer than the ACTIVE_SERVICE structure
CORE-9235
svn path=/trunk/; revision=68196
- Restructure co_UserProcessHotKeys to correctly process modifier-only hotkeys. Fixes start menu opening after Win+X shortcuts, and probably several other hotkey-related issues. Thanks to reactosfanboy.
CORE-9728 #resolve
svn path=/trunk/; revision=68190
- Add tooltips for the toolbar
- Fix the 'disable' button not showing for devices that be disabled
- Some code cleanup / noise
svn path=/trunk/; revision=68185
- Add support for WM_ENTERMENULOOP/WM_EXITMENULOOP and update the status bar style to allow hints to be drawn
- Fixup the menu hints
svn path=/trunk/; revision=68184
- In 'Devices by Connection, if a device has a problem, expand the treeview to to show that problem device.
- Add a missing break in WM_COMMAND to stop the app from closing
- Fix clearing the lists
svn path=/trunk/; revision=68182
- Make class and device nodes polymorphic and move the code into separate files
- Add an abstract base class which we attach to the listview nodes
- Add double clicking of nodes
svn path=/trunk/; revision=68180
- Set the correct length in FsdGetFsVolumeInformation/FsdGetFsAttributeInformation, and write back partial data when returning STATUS_BUFFER_OVERFLOW
- Replace unnecessary checks with ASSERTs
CORE-9820 #resolve
svn path=/trunk/; revision=68175
- Move the devmgmt code to devmgr where it belongs and start to rewrite it (devmgmt_new wasn't a good design). It's not part of devmgr yet, I'll merge it and add it to the build when it's more complete.
- Add support for caching devices to speed up switching device views
- start to add dynamic context support so we can enable/disable, update and uninstall devices depending on its state.
- WIP
svn path=/trunk/; revision=68165
- Simplify PicIRQComplete helper function.
- Set up temporary stack for the BIOS.
- Initialize the "User Data Area" that is found at 0050:xxxx (see http://helppc.netcore2k.net/table/memory-map for more details).
- Some INT --> UINT
- Simplify few macros.
- Simplify DOS initialization; add few functions that will be useful later on.
- Remove trailing whitespace.
svn path=/trunk/; revision=68159
Improve the recovery console:
- Add help texts.
- Implement the partinfo command which displays the partition table of the chosen drive.
svn path=/trunk/; revision=68158
Fix broken filesystem detection.
- Treat FAT32 filesystems like FAT filesystems because we do not provide a FAT32 entry in the filesystemlist.
- HACK: Do not try to check an unidentified filesystem.
CORE-9815 #resolve
svn path=/trunk/; revision=68156
PATCH: Get configure and host-tools building on arm again by Steven Edwards from dev-ml
+ adding Timo's portable sqrt variant to where it's needed to fix win32k build.
+ disabled the assert in sqrt.c for now.
svn path=/trunk/; revision=68145
Fix compilation for AMD64 and ARM.
- It's no good idea to use the x86 ASM optimizations on any architecture. Luckily Alter made plain C++ ones for that case, too. Thus modify the #ifdefs a bit to use em.
- Fix a few directly used functions instead of the defined architecture fixed ones of em.
- After some discussion with Thomas Faber the ULONG vs UINT32 problems were resolved by using the same platform defines for all three architectures.
BUILDS? yes WORKS? Trololololo ^^
svn path=/trunk/; revision=68144
Complete NtQuerySystemInformation - SystemNumaProcessorMap stub so that it is possible to query the highest node number (and only that!)
CORE-9680
svn path=/trunk/; revision=68142
Improve bin2c by saving in a #define the size of the generated array, and specify this size in the declaration of the array so that doing sizeof(...) becomes possible. Use "unsigned char" as the (portable) type of the contents of the array.
[HAL]
Add PCHAR casts where needed to take into account the previous modifications.
svn path=/trunk/; revision=68139
Implement GetNumaHighestNodeNumber()
Implement GetNumaNodeProcessorMask()
Implement GetNumaProcessorNode()
Implement GetNumaAvailableMemoryNode()
They won't work yet though, given that the kernel mode counterpart is still unimplemented.
CORE-9680
svn path=/trunk/; revision=68136
- Stubplement the font generator functions for text-mode.
- Store in plane 2+ the font ONLY in text mode (guilty r68085). Fixes spurious graphics corruption in gfx modes.
CORE-9791
CORE-9794 #resolve #comment Should be fixed in r68134.
svn path=/trunk/; revision=68134
- Immediately finish a zero-length request in TdiSendDatagram. This may not be completely correct (should possibly get forwarded to tcpip instead) but is better than asserting.
CORE-9810
svn path=/trunk/; revision=68131
Addendum to 68126. The loader should return STATUS_INVALID_IMAGE_PROTECT
if e_lfanew is 0, or if the DOS stub appears too large due to a bad
e_lfanew. (Note: All plain MZ executables have an invalid e_lfanew)
svn path=/trunk/; revision=68127
- Set VadType = VadImageMap for image section mappings
- Rewrite MmGetFileNameForAddress and NtAreMappedFilesTheSame. Take into account that the first address must be an image section mapping
- Fixes a few kernel32_winetest:virtual tests
CORE-9736 #resolve
svn path=/trunk/; revision=68123
- Implement mandatory filesystem selection, formatting and filesystem checks for all new partitons.
- Implement optional filesystem selection, formatting and filesystem checks for formatted boot and install partitions.
- Enable installing ReactOS on primary partitions other than the first one. Usetup will install Freeloader on the first (or active) partition (aka boot partition) and install ReactOS on the chosen partition (aka install partition).
svn path=/trunk/; revision=68112
- Some INT --> UINT fixes.
- Fix the third value of MemorySizes according to the specification, confirmed by Aleksander.
svn path=/trunk/; revision=68099
Fix IMUL. MINSHORT and MAXSHORT aren't good constants since they don't have
a (SHORT) cast, and (LONG)((SHORT)MINSHORT) is uglier than just using -32768.
svn path=/trunk/; revision=68078
Fix INT 21h, AH=55h. It's supposed to set the current PSP too.
Fix the order of registers in DOS_REGISTER_STATE to make it more compatible.
svn path=/trunk/; revision=68066
Revert r67603, apparently DosTerminateProcess should just always pop the registers.
Make our DOS_REGISTERS_STATE structure more compatible.
svn path=/trunk/; revision=68065
Stubplement INT 25h and INT 26h. These interrupt calls are really weird since
they don't IRET on return, so the default interrupt stub messes up the stack.
svn path=/trunk/; revision=68054
Programs don't expect the XMS function AH = 07h to access the keyboard
controller, since the specification says it's done in a hardware-independent
way. So, reimplement this function by calling EmulatorGetA20() instead.
Also, for the sake of simplicity, use EmulatorSetA20 instead of PCAT_A20Control
to change the A20 state.
svn path=/trunk/; revision=68029
- Implement the DOS idle interrupt.
- Link to the parent's environment block by default in DosCreatePsp.
- Fix INT 21h/36h (Get Free Space) to report 0xFFFF if the number
of clusters is too high to fit in a word.
svn path=/trunk/; revision=68028
opgroups.c: We shouldn't restore SP in the opcode handler as that might
interfere with triple faults. Also, in this case it's also wrong because
the exception procedure already restores the stack pointer.
common.c: Fix a comment, no code changes.
svn path=/trunk/; revision=68027
Missing italian translations in ReactOS by Carlo Bramini
CORE-9725 #comment WineD3D, ieframe and shortcuts patches committed. thx ^^
See issue 9725 for more details.
svn path=/trunk/; revision=68011
Add/Update Chinese (zh-CN) translation by Henry Tang Ih
CORE-9003 #comment Forgot one file...
See issue 9003 for more details.
svn path=/trunk/; revision=68010
Implement XMS functions 10h, 11h and 12h by forwarding them to the
VDM DOS memory manager.
CORE-9651 CORE-9741 #resolve #comment Fixed in revision 68001.
svn path=/trunk/; revision=68001
Add/Update Chinese (zh-CN) translation by Henry Tang Ih
CORE-9003 #resolve #comment Trunk patch applied, thx ^^
See issue 9003 for more details.
svn path=/trunk/; revision=67993
- Move the fastio code to a separate file.
- Add Pierres IRP-Queue code and use it for IRP_MJ_QUERY_VOLUME_INFORMATION, IRP_MJ_SET_VOLUME_INFORMATION, IRP_MJ_QUERY_INFORMATION, IRP_MJ_SET_INFORMATION, IRP_MJ_DEVICE_CONTROL and IRP_MJ_FILE_SYSTEM_CONTROL requests.
svn path=/trunk/; revision=67988
Directly implement NtfsOpenFileById() for special files from the MFT where we cannot moonwalk there path.
It concerns any file with ID < 0x10.
This function can only cope with file which ID is < 0xc. Windows Internals reports that 0xc - 0xf entries are unused.
It would be interesting to double check returrned status in case of error, and also what Windows returns when attempting weird opening of suchs entries (overwrite, create for unused, etc).
svn path=/trunk/; revision=67983
At the request of Christoph von Wittich, bring devmgmt_new into the build.
* Created CMakeLists.txt and added to parent folder.
* Removed some references to CAtlString that were not needed and are not implemented in our headers.
* Fixed build with gcc.
* Spread all the changes done to the english resources to the other languages. Many languages now contain untranslated strings that will need to be fixed.
Note that I made no effort to fix any bugs or improve any features. The app comes as-is, except it now builds with rosbe.
svn path=/trunk/; revision=67976
Update LibreOffice version to 4.4.3 and add zh-CN translation in RAPPS/RAPPS_NEW by Henry Tang Ih
CORE-9748 #resolve #comment Committed, thx
svn path=/trunk/; revision=67966
- When a DOS application is started by a process that has no console,
the ConsoleHandle in the VDM_CONSOLE_RECORD is initially NULL.
Fix that by making an initial VDM_GET_FIRST_COMMAND call in NTVDM
and setting the ConsoleHandle to the handle of NTVDM's console in
BaseSrvGetNextVDMCommand.
- Fix a bug in BaseSrvGetVDMExitCode (VDM_READY means the task has exited).
svn path=/trunk/; revision=67961
Implement a portable version of sqrt. It's using an optimized combination of different algorithms, resulting in code that calculates the result in the maximum possible (when internally using double) precision with only 11 multiplications and a single division.
svn path=/trunk/; revision=67956
- Add FdoQueryBusRelations to enumerate the 'attached' raw port.
- Create the PDO for the raw port (\Device\ParallelX) and let the symbolic link (\DosDevices\LPTX) point to it.
- Move the open, close and write code from the FDO to the PDO.
svn path=/trunk/; revision=67936
Now that the Fast486 FPU is feature-complete, tell programs that we have a builtin FPU.
(This commit may cause regressions if there are bugs in the FPU)
svn path=/trunk/; revision=67934
Implement FPTAN by calculating the sine and then dividing it by
the approximated cosine: sqrt(1 - sin(x) ^ 2).
This method turned out to be faster and more precise than the
Maclaurin series for tan(x), which converges very slowly.
svn path=/trunk/; revision=67932
- Don't attempt to moon walk path name for reserved MFT entries.
- Don't attempt to dereference file name if it doesn't exist
svn path=/trunk/; revision=67918
- Use UserRefObjectCo in IntNotifyWinEvent to avoid a reference leak in case the call-out does not return
- Sanitize list walk
svn path=/trunk/; revision=67907
Add very long tests for tunnel cache.
So far, they are skipped because they are really long (they require more than 15s to complete).
Unfortunately, for unknown reason now, they are failing in ReactOS (whereas they shouldn't!).
An idea would be to see whether we can set an expiry of 1s for tunnel cache just for dbgtests and query the value from registry, so that it could help reduce test duration on ReactOS (but not on w2k3).
ROSTESTS-177
svn path=/trunk/; revision=67901
Add simple tests regarding renaming and tunnel cache behavior for short names in user mode.
Longer tests should be added to show what happens in case of cache expiry.
All pass on w2k3 but not on ReactOS.
CORE-3875
svn path=/trunk/; revision=67897
Fix the implementation of FSIN and FCOS:
First of all, 4 steps for a Maclaurin series is not enough.
Second, the angle should be normalized to the [-pi/2, pi/2] range.
svn path=/trunk/; revision=67894
- Move the code to copy and rename hardware profiles from the dialog procedures into separate functions.
- Use the dialogs only to retrieve the destination profile name.
- Do not copy or rename a hardware profile if it source and destination name is the same.
- Replace a hard.-coded string by a resource string.
svn path=/trunk/; revision=67889
Short commit message: implementation of (names) tunnel cache in file system RTL.
This is in the vast majority work done by Johannes Anderwald, I've just reviewed, fixed a few things, and implemented last bits.
Thanks to Johannes for his initial implementation (and huge work!).
Dedicated to Hervé's secret plans ;-).
CORE-7272
CORE-3875
svn path=/trunk/; revision=67886
Don't attempt to allocate null-size buffer when copying empty string.
Note to next generations students: test your code and DON'T LEAK MEMORY!!!!
It still leaks atm, will have a look later on.
Note to Mr Bragin, beloved ReactOS Project Coordinator: did you actually reviewed your students work?
CORE-7272
svn path=/trunk/; revision=67885
- Add a debugging assert that will save your lot of time if you attempt to manually queue a wrong IRP. You cannot queue an IRP which is set to be later queued again. This is a broken behavior.
- Remove a bit of code duplication
svn path=/trunk/; revision=67880
- Update the CrtModeControl byte in the BDA when we change video modes.
- Implement INT 10h, AX=1003h "Toggle Intensity/Blinking Bit".
- Partially implement INT 10h, AH=1Bh "Functionality/State Information (VGA)".
svn path=/trunk/; revision=67879
- Only free the IRP context in case the request is not to be queued
- Stubplement request queueing support in NtfsDispatch()
svn path=/trunk/; revision=67877
Split NtfsFsdDispatch() in two.
Now, NtfsFsdDispatch() will only take care of allocating the IRP context and complete the IRP in case it failed (that fixes a null-pointer dereference, just for the record).
NtfsDispatch() will really dispatch the IRP to the internal functions. So that it can be called either directly from NtfsFsdDispatch() or by a queued IRP (to be implemented).
svn path=/trunk/; revision=67875
Use a better algorithm for the base 2 logarithm.
Put the shared code for FPREM and FPREM1 in an inline function used by both.
svn path=/trunk/; revision=67855
Due to some kind of mixup, I thought the series for log(x) was actually for log10(x).
Fix Fast486FpuCalculateLogBase2 by dividing the result with log(2) and not log10(2).
svn path=/trunk/; revision=67841
Fix a copy-paste bug. Adjust the number when subtracting in Fast486FpuAdd. Don't overflow
the mantissa in Fast486FpuToSingle/Fast486FpuToDouble without correcting the exponent.
svn path=/trunk/; revision=67838
INI files for setting parameters? Lets get to the past Win 3.11 standards and make a configure dialog for that which reads and writes the stuff to the registry.
svn path=/trunk/; revision=67833
Followup to r67830: When no one handles a message, properly return that it was not handled.
This way all messages are handled correctly and not just NCCREATE.
Also took the chance to short-cut NCDESTROY, since the icon handlers have no need to receive this message.
CORE-9592 #resolve
svn path=/trunk/; revision=67831
do not handle WM_NCCREATE in ProcessWindowMessage
otherwise it get passed to ProcessIconMessage which will flag it as handled in case g_NumIcons is 0
which then will result in ATL not calling DefWndProc anymore
CORE-9592
svn path=/trunk/; revision=67830
Fix Fast486FpuArithmeticOperation. It doesn't really matter for the operation
itself which operand is the source/destination, because the FPU actually
always performs the operation on ST0 and something else. So, FDIV/FDIVR were
never really reversed here, it's just that FDIV always divides ST0 by something
and FDIVR always divides something by ST0.
svn path=/trunk/; revision=67828
Fix UnsignedDivMod128 (again).
Fix Fast486FpuAdd to handle numbers whose difference of exponents is greater than
the number of bits in the mantissa.
svn path=/trunk/; revision=67827
The maximum length of hardware profiles names is 79 characters. Use a matching string length and set the length of the edit control accordingly.
svn path=/trunk/; revision=67825
Implement support for FastIO for:
- FastIoQueryBasicInfo
- FastIoQueryStandardInfo
Now, with this commit and the two previous, ReactOS won't attempt to issue an IRP for these query, but will directly go with the FastIO path.
The performance improvement is really visible in 1st stage (at least, here with VBox).
svn path=/trunk/; revision=67824
Fix several division related problems:
- In UnsignedDivMod128, fix the leading zero calculation for 128-bit numbers.
- In Fast486FpuDivide, there's no need to increase the exponent by 64 (adding zeros
at the end of a number after the decimal point changes nothing).
- FDIV/FDIVR were reversed
svn path=/trunk/; revision=67820
- Zero is not a denormalized number.
- In Fast486FpuMultiply, we must account for the fact that the resulting mantissa
also has the "decimal point" at the second position.
svn path=/trunk/; revision=67819
Implement MiGetFileObjectForSectionAddress and use it in MmGetFileNameForAddress and NtAreMappedFilesTheSame. Don't call MmLocateMemoryAreaByAddress from these functions anymore.
svn path=/trunk/; revision=67810
Fix a fixme in VfatGetUserBuffer():
Only request high priority page when in the paging path. Otherwise, request normal priority
svn path=/trunk/; revision=67808
Don't check if a AMR3 owned memory area can be inserted, since we already know it's ok. Delete the related memory area code.
svn path=/trunk/; revision=67798
Add a tiny hack to MiFindEmptyAddressRangeInTree and MiFindEmptyAddressRangeDownTree to support VADs in the kernel VA range. Make MmFindGap use those functions to look for free space.
svn path=/trunk/; revision=67797
Get rid of MiRosTakeOverSharedUserPage. We don't need it anymore, since the user page is manually handled in the page fault handler and since it's outside the VAD region, we don't need to block that range. Now there should be no memory areas left at all in MmDeleteProcessAddressSpace.
svn path=/trunk/; revision=67796
Modify MmLocateMemoryAreaByAddress as well to use the VAD table. Since the page fault handler uses it to find ARM3-Fault pages and the shared user page does have a memory area, but not a VAD, add a check for the shared user page in the old fault handler.
svn path=/trunk/; revision=67795
Implement MiRosCleanupMemoryArea to cleanup memory areas from MmCleanProcessAddressSpace, since later when we remove the old-style memory area links, we will not be able to retrieve those.
svn path=/trunk/; revision=67794
Use the VAD tree to search for MEMORY_AREAS, except when inserting an ARM3 based MA. In this case we still need to use the old tables, since the related VAD is already inserted into the VAD tree.
svn path=/trunk/; revision=67793
- Allocate Memory area before trying to insert it in different pathes of MmCreateMemoryArea. This change is a preparation for upcoming changes.
- Cleanup MmInsertMemoryArea from useless stuff
svn path=/trunk/; revision=67791
Use 1 as base address parameter to MmCreateMemoryArea, when 0 is the actual base and remove FixedAddress parameter in MmCreateMemoryArea
svn path=/trunk/; revision=67790
Made mazescr use screensaver.lib for multi screen support
Add symbol to make things look more... mature in C:\ReactOS
Fixes of my two problems (app does not really terminate and maze is not generated completely) and tidy up (-200 lines of code!) of my mess and the mess we had in there before by David Quintana. Thx man :-D
svn path=/trunk/; revision=67781
- Add coprocessor constants
[NTOSKRNL]
- Handle process in NtFlushInstructionCache and validate parameters
- Use _MoveToCoprocessor instead of GCC inline assembly for ARM
svn path=/trunk/; revision=67770
- Simplify CurrentDirectories array usage.
- We can directly use a pointer to a DOS_DATA structure stored in the guest memory.
- Use the DOS data structures for CurrentDrive (in DOS_DATA) and LastDrive (this is in fact NumLocalDrives in the SYSVARS list).
- Use ANSI versions of GetLocaleInfo where applicable.
svn path=/trunk/; revision=67750
Bring in initiated work on IRPs in NTFS (and complete it).
This simplifies the way IRPs and their context are handled in the driver.
Only VfatDispatchRequest() is responsible of completing IRPs (if required), freeing the IRP context (if required), and queueing the IRP for later completion (if required).
This allows removing duplicated code, hacks, and so on. It might help reducing IRP leaks, or memory leaks.
By default, VfatDispatchRequest() will complete the IRP and delete the IRP context.
In case you don't want it to complete the IRP (because you passed it down, for instance), remove the IRPCONTEXT_COMPLETE flag. See for instance: VfatDeviceControl().
In case you want to queue the IRP (you previously called: VfatQueueRequest()), call the newly introduced VfatMarkIrpContextForQueue() function that will prepare it.
svn path=/trunk/; revision=67743
- Separate C++ exports per architecture, add ARM exports (that again have different mangling)
- Add symbol aliases for ARM C++ exports
- Compile in/out functions only on x86
- Add some missing exports for non-x86
svn path=/trunk/; revision=67730
setjmp is a macro expanding to _setjmp or _setjmpex. In soviet russia and on ARM builds, the compiler will convert invocation of _setjmp back into a call to setjmp. The compiler handles _setjmp and _setjmpex in the same way, generating code where r0 points to the jump_buf and r1 points to the current functions stack frame (sp on function entry). So make setjmp and _setjmp aliases to _setjmpex and make the latter use r1.
svn path=/trunk/; revision=67729
- Add some early "return" after calls to EmulatorTerminate()
- Some VDDs rely on the fact that NTVDM calls ExitProcess on Windows when it is going to quit, so let's do the same.
- Put port 61h (and 62h) support in ppi.c (programmable-peripheral-interface).
svn path=/trunk/; revision=67726
Create the "Hardware Profiles\0000" key as part of the registry setup. This must be done at this point because the "Hardware Profiles\Current" link will only be created, if the "Hardware Profiles\0000" key exists.
svn path=/trunk/; revision=67725
Partly revert previous changes, bringing back copysignf. Add global defines copysignf=_copysignf, since we have that now.
svn path=/trunk/; revision=67723
Implement basic funtions of the parallel port driver. It supports Centronics-Mode only.
You can print files using: copy <filename> lpt1:
svn path=/trunk/; revision=67713
- Remove useless copysignf invocation and the wrong defines for it
- BrokenHacksOnTopOfBrokenCode--;
- Should be sent upstream
svn path=/trunk/; revision=67709
This is evil under amd64, too... so we disable it for now.
[ROSHTTPD]
UINT -> size_t
[NCFTP]
About time to clean this mess. Are we a Unix? No sir!
svn path=/trunk/; revision=67697
Wine guys... if you put all stuff which uses one local variable in a #ifdef __i386__, then god heaven... put that one in a #ifdef, too! Should be sent upstream!
svn path=/trunk/; revision=67696
Fix the XMS driver. AH = 08h is supposed to return the size of the
largest free block in AX, and the total amount of *free* memory
in DX.
svn path=/trunk/; revision=67675
Implement VDD user hooks: they are called when a DOS program is started or terminated, and when the VM enters a blocking state or is resumed.
[NTVDM]
- Do some parameter checks and set last errors in VDD memory helpers.
- Fix a bug in VDDInstallIOHook when installing IO hooks: the IoHandlers pointer MUST NEVER be incremented!!
[TESTVDD]: Update my test VDD with tests for the user hooks.
svn path=/trunk/; revision=67671
Use the SDA for storing the request in DosCallDriver.
Rename some more fields we aren't going to use to "Unused..." in the SDA.
svn path=/trunk/; revision=67651
The LMSW instruction doesn't #GP when the program tries to return to real mode.
Rather, it just doesn't happen (the PE bit remains 1).
svn path=/trunk/; revision=67647
- Fix/add a number of macros based on native definitions
- Add "intrinsics" for GNU ARM assembler
- Move trap macros to asmmacro.S
svn path=/trunk/; revision=67639
- Only set the IOSB status if we complete the IRP
- Fix the assert: the caller might want not to complete the IRP nor to queue it (passed down IRPs)
svn path=/trunk/; revision=67636
Add two more flags (mutually exclusive) for IRP context:
- _COMPLETE will cause the IRP to be completed at the end of the dispatch, with the run-time priority boost set by caller
- _QUEUE will cause the IRP to be queued for delayed execution (not yet implemented)
This allows more flexibility for callers that can set the behavior thanks to the flags.
Default behavior is the previous one: by default the IRP is completed at the end of the dispatch
That one should really come to FastFAT...
svn path=/trunk/; revision=67635
- Move stuff from armddk.h to XDK/DDK
- Fix ARM CONTEXT flags
- Add missing KeGetCurrentIrql() for ARM
- Improve some amd64 based definitions
- Use Native math for Int64Sh**Mod32 on ARM
svn path=/trunk/; revision=67631
- Remove unused HYPERSPACE_BASE (which was broken for x86, too)
- Add PAE values for HYPER_SPACE and HYPER_SPACE_END on x86
- Add missing MM_HAL_VA_START and MM_HAL_VA_END for ARM
svn path=/trunk/; revision=67630
Don't force the run-time priority boost in NtfsFsdDispatch(). Some dispatched MJ functions might want to adjust it (MJ_READ/MJ_WRITE/MJ_CREATE).
The same should be actually done in FastFAT. I believe that would help avoiding several code duplications...
svn path=/trunk/; revision=67624
- Modify the int32 dispatch to clear the CF only on entry, so that we can
track in our handlers whether it was the first time the BOP executed.
- Implement INT 15h, AH = 41h (Wait On External Event).
- Fix INT 15h, AX = E801h - modify the stack CF instead of the handler CF.
- Make INT 16h AH = 00h clear CF when there is a character, so that the BOP doesn't
repeat.
svn path=/trunk/; revision=67612
- Implement XMS function 0x0E (Get Handle Information).
- Fix INT 15h, AX = E820h - setCF can't be used inside an int32 callback for changing
the return carry flag, because it has a different meaning there (it means that the BOP
should be repeated). Instead, we must modify the CF that was pushed on the stack.
svn path=/trunk/; revision=67611
- Enable C4189 (local variable initialized but not referenced) on MSVC builds and make it an error.
CORE-9676 #resolve
svn path=/trunk/; revision=67607
DosTerminateProcess shouldn't blindly attempt to restore the old state,
(for example if the process was started manually by a debugger).
svn path=/trunk/; revision=67603
- Move some interrupt initialization where it belongs and activate few other ones.
- Initialize interruct vector for INT 2Ah (Network check) because some apps directly call it and crash if it contains NULL.
svn path=/trunk/; revision=67595
- Improvement/Usability: when a DOS app is started in a separate console, print its full path as it's done in Windows.
- Stubplement a LoadGlobalSettings function for NTVDM so that it will be able to grab user settings from the registry.
- Move DOS-only related variables AcceptCommands, CommandThread and SessionId to where they belong. I will rework ConsoleCtrlHandler to make it more elegant in the future (DOS-agnostic).
- Remove the useless ENTER-key-up hack.
svn path=/trunk/; revision=67589
Remove notification icons when their attached HWND is no longer valid. Patch by Joachim Henze (reactosfanboy), with some extra newlines by me.
CORE-9537 #resolve
svn path=/trunk/; revision=67583
Implement EMS function AH = 53h (Get/Set Handle Name).
Some programs expect to find the string "EMMXXXX0" at offset 0x0A in
the segment where the EMS interrupt handler is, so move the interrupt
handler BOP to the private device area of the EMS driver.
svn path=/trunk/; revision=67573
- Add nothrow versions of new/delete operators
- Add <cassert>
- Fix a TODO and add missing dependency to <exception> header
svn path=/trunk/; revision=67555
Add some missing german translations
Add some missing manifests
Improve some resources
Add possibility to build an application with one language
svn path=/trunk/; revision=67552
- Implement call gates.
- Fix Fast486InterruptInternal and get rid of ugly hacks.
- Fix IRET (CS loaded too early).
- Add a structure definition for the 16-bit TSS (not supported yet).
svn path=/trunk/; revision=67545
- Implement portable fabsf.c
- Move some ARM stubs to a better location
- Add stubs for __dtoi64, __i64tos, __u64tos, _clearfp
svn path=/trunk/; revision=67537
- Handle failure to allocate VM for thunk code
- Factor out the assembly thumk code, fix amd64 code and implement ARM code
svn path=/trunk/; revision=67535
- Convert tabs to spaces
- Remove excessive local variable indentation for alignment, since that doesn't help to improve readability
- No code changes
svn path=/trunk/; revision=67534
- Fix a typo.
- Use a #define for the device flag.
- In r67526, the following change was committed but not described in the commit message:
- Enable opening devices in DosCreateFile and DosCreateFileEx.
svn path=/trunk/; revision=67527
Update the copyright year (better late than never).
Push the error code inside Fast486InterruptInternal, to make the size of the
pushed value on the stack correct.
Update the CPL in Fast486TaskSwitch.
svn path=/trunk/; revision=67526
Add a few definitions based on (Windows RT 8.1) symbol files, ks386.inc, ksamd64.inc, ksarm.inc and Windows 10 WDK (ntosp.h ftw!)
svn path=/trunk/; revision=67525
- Implement KiCpuId and make use of it
- Get rid of ugly CPUID, RDMSR and WRMSR functions
- remove unused KTS_ constants
svn path=/trunk/; revision=67524
- Implement C versions of RtlInterlockedPushEntrySList, RtlInterlockedPushListSList, RtlInterlockedPopEntrySList and RtlInterlockedFlushSList.
- RtlInterlockedPushListSList is fastcall, not stdcall
svn path=/trunk/; revision=67522
- Improve definition of ExInterlockedCompareExchange64 and interlocked SList functions and improve some annotations based on native header
- Update processor feature constants
svn path=/trunk/; revision=67521
Mouse:
- Remove now useless code in mouse support in BIOS.
- Implement INT 33h, AH=1Bh "Return mouse sensitivity" (returning hardcoded standard values since we don't support custom sensitivities) (AH=13h and 1Ah are marked as UNSUPPORTED).
- INT 33h, AH=1Fh "Disable mouse driver" returns in ES:BX the old INT 33h vector value: implement that.
- Implement INT 33h, AH=21h "Software reset", AH=24h and 4Dh and 6Dh "Software version and mouse info", "pointer to copyright string" and "version 'string'" functionalities.
DOS:
- Initialize in Win2k3-ntvdm-compatible order the DOS drivers: NUL, then CON, then XMS, and then EMS.
- Fix segment/offset inversion usage in INT 21h, AH=5Ch "Lock/Unlock region of file": when using MAKELONG macro to build a far pointer, the first parameter (loword) is the offset, and the second parameter (hiword) is the segment.
svn path=/trunk/; revision=67518
When storing a segment selector, the operand size attribute is only ignored when
writing to memory (where it's treated as if it's always 16-bit).
svn path=/trunk/; revision=67512
Implement INT 27h (Terminate and Stay Resident).
Keep track of the last entry SS:SP in the INT 21h handler.
Restore the stack in DosTerminateProcess.
The number of bytes to keep resident applies only to the block which holds the PSP,
other blocks are not freed.
svn path=/trunk/; revision=67507
Separate the process-related code from the DOS kernel.
Enable starting processes from other processes in STANDALONE mode.
Implement INT 21h, AH = 55h and INT 21h, AH = 26h (Create/Clone PSP).
Implement overlay loading.
svn path=/trunk/; revision=67498
- Arch, don't assume the driver you see in the backtrace is one that needs fixing. CDFS is the one who's a file system driver here...
svn path=/trunk/; revision=67496
[BUILD]
msvc.cmake: Disable thread-local static initialization.
CMakeLists.txt: Disable PCH for VS2015.
configure.cmd: Make it aware of cl.exe version 19.x
[CPPRT]
Add alias for the new variants of the delete operators.
[BROWSEUI]
[MFIFS]
[FRAMEDYN]
[NDIS]
[DDK]
[PSDK]
[STLPORT]
Add explicit declarations of the new delete operators for those modules that don't use the WITH_RUNTIME option.
[WIDL]
[WPP]
Do not alias the snprintf family of functions to the _snprintf variants, since VS14 already declares them internally.
svn path=/trunk/; revision=67483
When a segment isn't present, the exception should always be #NP (unless
it was the stack segment, in which case the exception should be #SS).
svn path=/trunk/; revision=67479
The fix in r67477 was incorrect. When loading an executable high, we need to
allocate all of the memory and copy the program itself to the highest part of it.
I know it sounds illogical but that's how it works...
svn path=/trunk/; revision=67478
Also check for BlockData == 0 in RosResizeMemory. This, however, wasn't a crash since we
were lucky enough to cast the segment to a WORD before the access.
svn path=/trunk/; revision=67476
Continue the work converting the UI to using ATL-wrapped windows. CORE-9593
[RSHELL]
[EXPLORER]
Fixup two class declarations to work with the rosctrls.h changes.
svn path=/trunk/; revision=67474
- Move definition of TIMER_TABLE_ENTRY from ntoskrnl to NDK
- Add definitions of KTIMER_TABLE, KDPC_LIST, SYNCH_COUNTERS
svn path=/trunk/; revision=67471
Use portable definitions for service table constants. (Moved from ARM specific definition in ntoskrnl internal header, with a fixed value for TABLE_NUMBER_BITS, which is 1, not 3)
svn path=/trunk/; revision=67470
- Consistently return STATUS_INVALID_IMAGE_PROTECT from PeFmtCreateSection if the PE signature is missing. Patch by V.
CORE-9618 #resolve
svn path=/trunk/; revision=67464
In DosAllocateMemory, when the "last fit" allocation strategy is selected, split
the block so that the last part of it is used.
svn path=/trunk/; revision=67462
Initial work on a lightweight layout engine for ATL::CWindow.
Although a lot of work is still required making the classes more generic and layout-aware,
but it is already able to replicate the original rapps layout without explicit positioning of the windows.
Committing mostly for backup/history purposes.
CORE-9593
svn path=/trunk/; revision=67460
Remove the useless wrappers BiosPeekCharacter and BiosGetCharacter. They're also
a source of bugs since 0xFFFF could legitimately appear in the buffer.
svn path=/trunk/; revision=67459
- In INT 21h, AH = 0Ah, the final carriage return is not counted.
- Implement XMS function 0Bh (Move Extended Memory Block).
- The driver must preserve the contents of unlocked Extended Memory Blocks (EMBs),
so move the bitmap setting/clearing code into XmsAlloc and XmsFree.
- Make XmsAlloc optimize memory blocks by moving them around, except it can't
move locked blocks.
svn path=/trunk/; revision=67457
Implement INT 21h, AH = 52h (Get List of Lists - SYSVARS).
Rewrite the SFT code to keep the SFT in guest memory.
Implement the NUL device driver.
svn path=/trunk/; revision=67444
Fix RegQueryInfoKey
- Return a value in lpcClass if lpClass is NULL
- Return correct error codes as shown by tests
- Correctly name parameters -- most of these are NOT byte counts
CORE-6976
svn path=/trunk/; revision=67425
- Add a test for RegQueryInfoKey. This serves as a placeholder to be replaced with the upstream version once accepted -- however it tests against Win 2003 behavior, so it can validate changes to our advapi32.
CORE-6976
svn path=/trunk/; revision=67424
Remove hack in PrivMoveFileIdentityW and properly handle failing call to BasepNotifyTrackingService().
Fixes regression brought by r67355
svn path=/trunk/; revision=67423
- Add a test for NtGdiAddFontResourceW. This goes in gdi32_apitest until we fix w32knapi to be Testman-compatible (ROSTESTS-167). Patch by Víctor Martínez Calvo.
ROSTESTS-166 #resolve
svn path=/trunk/; revision=67391
- Don't use the connection's name as the tab title in the Connection Properties dialog. Patch by Lee Schroeder.
CORE-9603 #resolve
svn path=/trunk/; revision=67390
- Avoid printing an unterminated string in registry test. Powered by DPH.
- Add a ROS hack to avoid a buffer overflow when one of our DPRINTs is returned by WaitForDebugEvent (e.g. when using DPH)
svn path=/trunk/; revision=67382
When the VGA memory map is A0000-BFFFF, mirror the bottom 64 KB into the top.
This should take care of all VGA addressing problems.
svn path=/trunk/; revision=67377
* Turn the files into .CPP, to ease future changes. All the code remains class-free for now, with one exception.
* Adapt the download progress dialog implementation to ATL/C++, which is a best match for COM classes.
* Add an ATL CModule class to the process, necessary for
CORE-9593
svn path=/trunk/; revision=67376
Store the return address in INT 22h as a far pointer.
The amount of memory stored in the Env variable is EnvSize, not sizeof(Env)
since Env is a pointer.
svn path=/trunk/; revision=67369
In DosCreateProcess, allocate space for the environment block dynamically and expand
it if needed, just like we do in CommandThreadProc.
In GetNextVDMCommand, remove the check that checks whether VDMState is one of
VDM_NOT_LOADED, VDM_NOT_READY or VDM_READY - that check makes no sense whatsoever,
since those aren't input values for that structure field. Their bit masks do correspond
to valid input fields, but even then the check makes no sense.
svn path=/trunk/; revision=67363
- Report A20 line status in the PS/2 controller output port.
- Properly implement XMS functions 3 and 5 (Global Enable/Disable A20 line), 4 and 6 (Local Enable/Disable A20 line) and 7 (Get A20 line status) using flag+counter and PS/2 I/O calls.
- Fix XMS driver version report.
svn path=/trunk/; revision=67361
- Halfplement BasepGetComputerNameFromNtPath() which allows querying the computer name given a handle & an NT path
- Implement BasepNotifyTrackingService() which issues a FileTrackingInformation on file move
svn path=/trunk/; revision=67355
Implement the XMS functions AH = 03h and AH = 04h (global enable/disable A20).
Make the GetHandleRecord function in the EMS driver inline.
CORE-8277 #comment Please retest.
svn path=/trunk/; revision=67352
- Fix copy-paste error in the initialization of DriverHeader.
- Use BOP_... syntax for BOP #define names (to comply with the rest of the code).
svn path=/trunk/; revision=67351
- Move the EMS code from the BIOS to the DOS driver where it belongs.
- Expand the DOS device API with a new function, DosCreateDeviceEx, which
will allow 32-bit DOS driver to reserve private memory.
- For each DOS device, create an entry in guest memory so that 16-bit code
can call 32-bit DOS drivers directly.
- Implement an XMS driver stub that uses the above.
- Arch, that's not how the DOS driver strategy routine works, you need to
give it the request in ES:BX which it will store somewhere, and then call
the interrupt routine.
svn path=/trunk/; revision=67339
- Implement BasepOpenFileForMove() used by PrivMoveFileIdentityW(), with its Windows bugs
- Implement PrivMoveFileIdentityW()
Not sure yet why Windows implementation exposes a sharing violation during our API test. Our absence of sharing violation looks more legit...
To be investigated.
svn path=/trunk/; revision=67335
Make the total amount of EMS pages configurable.
Allocate memory for EMS instead of sharing a part of the guest memory.
svn path=/trunk/; revision=67325
Make the GUI version actually work by disabling wmain per ifdef which will be set only at CUI build.
Fix resources to make the text fit nicely and get rid of the RLEXT/LTEXT mess
Add German translation
svn path=/trunk/; revision=67319
- Do not display a message box in CLanStatus::QueryInterface. Fixes hang when running com_apitest:netshell
- Change the order of some interfaces in CNetworkConnections to make com_apitest slightly happier
svn path=/trunk/; revision=67314
- Keep a CLanStatus instance around in CNetworkConnections (as before r65758) and properly manage its lifetime. Fixes Status context menu item for network connections.
CORE-9564
svn path=/trunk/; revision=67311
- Some additions to the previous commit
- Make destructors private
- Use delete to free object allocated using new
- Try to fix some ITEMIDLIST typing
svn path=/trunk/; revision=67310
Fix artifacts from incomplete C++ conversion:
- Add m_ prefix to member variables to avoid shadowing locals
- Use initializer lists in constructors
- Use destructors instead of putting code in Release
- Avoid C-style casts (not exhaustive)
svn path=/trunk/; revision=67307
- Move Network Connections back to Control Panel, where it belongs. Was accidentally moved to My Computer in r66485.
CORE-9495 #resolve
CORE-9564
svn path=/trunk/; revision=67298
Add ARM stubs for _abnormal_termination, _except_handler2, _except_handler3, _global_unwind2, _local_unwind2, __C_specific_handler, __CxxFrameHandler, __rt_srsh
[RTL]
Add ARM stubs for RtlGetCallersAddress, RtlDispatchException, RtlUnwind, RtlInitializeContext
[NTOSKRNL]
Add ARM stubs for READ/WRITE_REGISTER_*
svn path=/trunk/; revision=67294
We have a zero-warnings policy in trunk, accordingly:
- Disable overflow warnings in mciwave
- Remove all -Wno-error directives
- Remove all allow_warnings invocations
- Make allow_warnings defunct, it needs to be reworked, e.g. according to CORE-6959.
svn path=/trunk/; revision=67291
- Rearrange header inclusions. Put almost all NDK stuff in ntvdm.h.
- sizeof(array)/sizeof(array[0]) --> ARRAYSIZE(array) : increase code readability.
- Use Rtl heap functions (other parts of the code already did use them).
svn path=/trunk/; revision=67283
Add manifest to vmwinst, explorer and winlogon.
Remove em from telephon and ntobjshex again. No dialog, no manifest ^^
svn path=/trunk/; revision=67246
Add manifest to telephon.cpl.
[SHELLEXT]
Add manifest to netshell, stobject and ntobjshex.
Translate ntobjshex to German.
svn path=/trunk/; revision=67243
- The auxiliary PS/2 port IRQ is disabled by default.
- In the DOS mouse driver's IRQ handler, just reading the entire packet
is faster than waiting for one IRQ per byte. (real drivers can do that too,
using polling, which is slower on real hardware but faster in NTVDM).
- Increase the speed of the PS/2 IRQ scheduler so that mouse packets don't
fill up the queue completely. And consequently, increase the number of
CPU steps per cycle to avoid "stuck key" bugs.
svn path=/trunk/; revision=67231
- Make some compilers and static analyzers happy by removing a no-op condition. Patch by Samuel Serapion.
CORE-7214 #resolve
svn path=/trunk/; revision=67230
- Fix range check in NtUserSetWindowFNID. Patch by Samuel Serapion.
- Update comment on an old hack
CORE-7212 #resolve
svn path=/trunk/; revision=67228
- Make GetDriveType test succeed if the current directory is the drive root. Spotted by Edijs.
- Use strsafe functions
ROSTESTS-160 #resolve
svn path=/trunk/; revision=67222
- Completely rewrite the timing system. Replace hardcoded callbacks
with dynamic hardware timers.
- Finish implementing the PS/2 mouse.
- Fix the DOS mouse driver.
Inspired by a patch by Stefano Toncich (Tonix) (see CORE-9166).
CORE-9166 #comment A different fix was committed in r67219.
svn path=/trunk/; revision=67219
- Add the client interface code of the server service.
- Implement NetRemoteTOD. This will not fix CORE-5423 because the server side (NetrRemoteTOD) is not implemented yet.
svn path=/trunk/; revision=67197
Refactor the code for __rt_div to allow reusing it for __rt_sdiv64 and __rt_udiv64 and implement those as asm wrappers around worker functions (due to the calling convention they cannot be implemented fully in C)
svn path=/trunk/; revision=67195
Initialize the list of hooks before the call to NtAllocateVirtualMemory, to prevent crashes
in MemCleanup in case it fails.
svn path=/trunk/; revision=67186
Disable some functions in wksta_new.c and re-enable their counterparts in wksta.c. For some reason I cannot get the wine dummy code working in the workstation service. Perhaps it is yet another RPC bug.
CORE-9415
svn path=/trunk/; revision=67182
* Fix comparison length: StrCmpNW takes chars, not bytes.
* While at it, make canonical comparisons use memcmp instead of string comparison, as we only care about equality, not ordering.
Better fix for CORE-9432
svn path=/trunk/; revision=67181
Fix the Interlocked function mess. Implement all Interlocked functions in xdk/interlocked.h as they exist in native. Use this header to generate wdm.h and winnt.h. Remove Interlocked definitions from winbase.h. Fix definition of ExInterlockedAddLargeInteger.
svn path=/trunk/; revision=67173
Fix usage of interlocked[Compare]ExchangePointer. These functions take a PVOID* as first parameter and nothing else. In native headers they are inline functions, not macros.
svn path=/trunk/; revision=67171
- Add missing KeMemoryBarrierWithoutFence, NUMBER_POOL_LOOKASIDE_LISTS, MM_SHARED_USER_DATA_VA, MM_EMPTY_PTE_LIST, MM_EMPTY_LIST, P*E_PER_PAGE, SESSION_POOL_LOOKASIDES, MiPdeToPte for ARM
- Fix KI_USER_SHARED_DATA for ARM based on native DDK
svn path=/trunk/; revision=67168
* Make the info struct pointers const, to ensure we are not modifying the contents from the const idlists.
* Disable checking that the provided PIDL is part of the folder. Fixes enumeration in ros, but feels a lot like hiding a bug.
CORE-9432 #resolve
svn path=/trunk/; revision=67166
Add more recent Setup for Steam (2 years more recent) + localisations for the setup by Radek Liska
CORE-4196 #resolve #comment Added to RAPPS, have fun ^^
svn path=/trunk/; revision=67165
- Fix ARM build of libwine. Patch by Yuntian Zhang. CORE-8672 #resolve
- Don't include non-existant ARM intrinsic headers
svn path=/trunk/; revision=67149
- Remove nsIDOMWindowUtils::SetCriticalDisplayPortForElement, as it's no longer present in Gecko. Fixes stack corruption when exiting IE.
CORE-9513
svn path=/trunk/; revision=67135
Add Revo uninstaller 1.95 by nicoalta01
CORE-8892 #resolve #comment Added, have fun. I added CCleaner, too while bein at it ^^
svn path=/trunk/; revision=67133
- Add missing SEH/Probe in NtGetPlugPlayEvent and IopGetInterfaceDeviceList, and correctly copy the interface list. Patch by Stephan Röger.
CORE-9498 #resolve
svn path=/trunk/; revision=67129
- Fix uninitialized variable use in EnumEnhMetaFile
- Apply Wine commit 88e81025 (gdi32: Fix typo in a condition (PVS-Studio).) by André Hentschel
CORE-9191 #resolve
svn path=/trunk/; revision=67126
- Another addendum to r67107: don't let CleanupAndFreePacket try to free the buffer since it does not have the correct pointer
CORE-8210
svn path=/trunk/; revision=67110
CORE-9060 #comment rapps-db-update-and-enhancement-includes-es-es-l10n-2015-03-20.patch committed + continued your ways in some more entries + made the German translation follow it either + added some missing German translations.
svn path=/trunk/; revision=67100
- Rewrite the progress dialog making it responsible for controlling services. (starting, stopping, etc).
- Fixup the rest of the code to make use of running actions through the progress dialog.
- As a side-effect, this should fix CORE-4585
svn path=/trunk/; revision=67094
- Fedor Zaytsev: Fix a typo (copy/paste) which resulted in inability to move forward in Explorer (when selecting item from the context menu of the forward button). CORE-9463
svn path=/trunk/; revision=67080
- Use the correct console critical section when setting console control handlers.
- Hold the console critical section in FreeConsole (so that we avoid freeing the console while also running code in the console control dispatcher...).
svn path=/trunk/; revision=67069
- Correctly retrieve/set the default console properties.
- (for console.dll only): split ApplyConsoleInfo so that it only deals with displaying the confirmation dialog (and set the correct return value for the PSN_APPLY notification message); the code that really sets console properties and save them in the registry is done in the main CPL function, after the property dialog is destroyed and before the CPL returns.
svn path=/trunk/; revision=67068
Fix the shift key. Improve the BIOS keyboard handler. Do not append
modifier keys to the buffer.
CORE-8231 #resolve #comment Fixed in revision r67066.
svn path=/trunk/; revision=67066
- If we do arithmetics using an non-defined env-var, the latter is automatically understood to be zero.
- If one left-shifts more than 31 bits (or left-shifts a negative number of bits), the result is automaticaly set to zero (checked on Windows'cmd + with cmd_winetest + wine cmd code).
svn path=/trunk/; revision=67062
Allocate the device lock semaphore for a PDEVOBJ in PDEVOBJ_AllocPDEV and implement PDEVOBJ_vDeletePDEV. Fixes a PDEVOBJ leak, found by Thomas and Giannis.
svn path=/trunk/; revision=67060
Check in BltMask if the masking operation would exceed the mask bitmap. Should fix crash when running gdi32_apitest MaskBlt.
CORE-9483
svn path=/trunk/; revision=67058
- Fix some comments that were otherwise hard to understand.
- Don't hardcode MAX_PATH in some API calls but instead use the real array char size.
- Don't leak find-file handles: fix leaked handles to NUL pseudo-file in situations where we do: copy some_file+NUL some_dest_file . Should fix some cmd winetests.
svn path=/trunk/; revision=67055
In a quest to better registry,
don't break VSSolution builds.
freeldr_pe is not in the same directory and copy doesn't care if you ask to concatenate C:\tomatoes, it already has the first file.
svn path=/trunk/; revision=67053
Add more tests for ExtCreatePen. This adds tests for almost all thinkable combinations of parameters. On win7: "ExtCreatePen: 7594830 tests executed (0 marked as todo, 0 failures), 0 skipped." After evaluating the results on WHS2003, this test will be disabled, since it is expected that most of these fail on ros atm.
svn path=/trunk/; revision=67040
- Remove old hack member in SC_RPC_CONFIG_INFOA that is no longer necessary and makes info levels other than SERVICE_CONFIG_DESCRIPTION fail. Fixes failure in VMware Tools installer.
- Actually save the new service description in RChangeServiceConfigW
CORE-9479 #resolve
svn path=/trunk/; revision=67027
- Actually create the "InstallEvent" as an event and use it to communicate success from newdev back to umpnpmgr. This works better than checking the process exit code from rundll32 (which always returns 0).
CORE-9477 #resolve
svn path=/trunk/; revision=67025
- GOTO command: Add a lower-bound test when skipping trailing spaces and such.
- CD/CHDIR command: Fix the helper SetRootPath function so that it fails if getting the full path string fails, and remove trailing whitespace from directory string. Fixes stuff like:
cd .. && echo success
cd ".. " && echo success
etc...
CORE-6810
svn path=/trunk/; revision=67020
- CFSFolder: Explicitly check for the supported pidl types. A CFSFolder can be created by a drive pidl. Handle this case and return the appropriate attributes in GetAttributesOf.
CORE-9458
svn path=/trunk/; revision=67017
- CControlPanelFolder: Factor out CCPLItemMenu class. Use it if the user selected a cpl item and use the default context menu otherwise.
- CControlPanelFolder: Use ExpandEnvironmentStrings when enumerating applets from the registry. Patch by Christoph.
- CCPLItemMenu: Call Control_RunDLLA directly so as to be able to run control panel applets that don't use the cpl extension.
CORE-7755 CORE-9466
svn path=/trunk/; revision=67016
- CControlPanelFolder: Explicitly check the pidl type in GetAttributesOf. Do not call the generic SHELL32_GetItemAttributes for cpl items.
svn path=/trunk/; revision=67015
- CNetFolder: As this folder isn't really implemented yet, there is no need to call the hacky common implementation of wine's shell folders (which will be removed eventually).
svn path=/trunk/; revision=67010
Make sure host-tools hosts get the correct type definitions on 64 bit (native) MSVC builds. x64 builds boot to desktop now.
CORE-8587 #resolve
svn path=/trunk/; revision=67004
- Implement Ctrl-C using interrupt 0x23.
- Fix INT 21h, AH = 0Ah to detect special characters.
- When attaching to / detaching from the console, adjust the console mode
and attach/detach the UI.
- Do not translate scancodes to characters while ALT is held down.
svn path=/trunk/; revision=67002
Indeed, some ReactOS (and Windows as well) components do not support the system directory having spaces, in particular SMSS: this is due to the basic command-line parsing rules of SMSS that considers that the presence of a space in the command-line is equivalent to a separator, be it in or out a quoted string.
svn path=/trunk/; revision=66995
- CProgressDialog: Allocate big enough buffers needed for the text messages during initialization and don't reallocate them at all. Should stop thrashing the heap while copying a large number of files.
CORE-9252
svn path=/trunk/; revision=66992
Make GetAdaptersAddresses work, with parameters check.
More work is needed :
-it returns the loopback, which shouldn't appear with default flags.
-the required size is fixed.
svn path=/trunk/; revision=66981
- CDefaultContextMenu: GetAttributesOf should only return the requested flags and not more. However our shell is not up to such nice behavior so don't depend o it for now.
svn path=/trunk/; revision=66980
- CDefView: Use SHForwardContextMenuMsg to forward menu messages to the context menu class
- CDefaultContextMenu: Implement IContextMenu3 and use SHForwardContextMenuMsg to forward menu messages to shell extensions.
CORE-9446 (part 2/2)
svn path=/trunk/; revision=66979
- Convert SHGetAllAccessSA to a soft stub in the spec file. Having it as a diff with wine doesn't add anything anyway.
svn path=/trunk/; revision=66975
- Add an additional new line before showing the test results.
Some log commands print their lines in multiple print commands. As a result the results line can end up in the middle of a previous log that was not a complete line. This confuses testman and causes it to report this test as a crashed test as it can't find the line with the results. This is not the best fix possible but makes sure that the results in testman fluctuate a bit less.
svn path=/trunk/; revision=66962
- Add a test for RtlReAllocateHeap -- shows that it doesn't handle allocations larger than 0x7f000 correctly in ROS
CORE-9441
svn path=/trunk/; revision=66958
Implement support for decentralized registry inf files.
This is done with the new add_registry_inf() cmake function, which takes one or more inf files, which are then converted to UTF-16 and merged into a single registry.inf, which is then used to create the livecd hives and imported by usetup. Move the registry entries for some drivers out of hivesys.inf into separate files next to the driver.
svn path=/trunk/; revision=66952
Improve the concatenate_files macro introduced by Timo in r52179 + r52182 and hackfixed in r53914 . Notice that now it can take an arbitrary number of files to be concatenated. Hence you need to specify first the output file, and all the rest is the different files.
[FREELDR]
Use the improved concatenate_files macro.
svn path=/trunk/; revision=66946
- stricmp doesn't exist in *nix, use strcasecmp instead.
- setmode (for setting IO streams mode -- text, binary --) is useless in *nix world, so just define it as a dummy function.
Should fix build.
svn path=/trunk/; revision=66945
- Take the best of the two CAT rosapps and turn them into a host-tool. Will be used later on in the build process.
- Few comment cleaning in bin2c tool.
svn path=/trunk/; revision=66942
- CDefaultContextMenu: Reduce relying on the type of the pidl. Query the attributes of the item from the folder instead.
CORE-8973
svn path=/trunk/; revision=66936
- Do not delete files that have open handles
- Delete on cleanup instead of close, and do not depend on FileObject->DeletePending (since the last file object is not necessarily the one that caused the delete)
CORE-9433
svn path=/trunk/; revision=66931
- Move the hotkey loop to its own thread to make it work when modal dialogs are open, and also during device installation
CORE-9428
svn path=/trunk/; revision=66914
Fix the implementation of the "Get Device Information" IOCTL.
Remove the broken implementation of the "Set Device Information" IOCTL.
svn path=/trunk/; revision=66910
- Enable ConnectMultiplePorts for mouclass. This means that "the events generated by all pointing devices on the system are fed to the Windows subsystem in a single input stream".
svn path=/trunk/; revision=66908
- Do not allow the creation of keys in the master hive. Fixes boot with the VMware sound driver from rapps installed (and it works, too).
CORE-5381 #resolve
svn path=/trunk/; revision=66905
- Fix some english.
- Validity checks for DosGetSftEntry returned pointer added.
- Use unsigned indices for for-loops indices that are always positive.
svn path=/trunk/; revision=66903
- Correctly handle recursive change notifications in CDefView
- Remove desktop folder hack from SHChangeNotify and move it to CDefView until we have ITranslateShellChangeNotify
Fixes phantom files/folders on desktop. Based on a patch by Huw Campbell.
CORE-8844
svn path=/trunk/; revision=66901
- Apply Wine commit b1d9d43a (winmm: Don't mask out SND_ALIAS_ID or SND_FILENAME in sndPlaySound.) by Andrew Eikum. Fixes crash in winmm_winetest:wave
- Import WINMM_CheckCallback from Wine and use it, various cleanups (commits cb77f9a2, 06d6dd3e, e6a501bb, a311dff7 by Jörg Höhle). In particular, accepting a NULL callback in DriverCallback fixes the crash in winmm_winetest:wave.
CORE-9401 #resolve
svn path=/trunk/; revision=66900
Write a proper exception filter for the emulated CPU. Allows to:
- handle memory access exceptions inside the virtual memory space (happens when a VDD installs a memory hook on a memory region and a DOS app tries to read/write inside this region);
- detect NTVDM bugs (if during emulation one tries to read/write in invalid memory areas). This should unveils at least 1 bug in the DOS device emulation, when running 386TO486.COM inside NTVDM.
svn path=/trunk/; revision=66897
Implement DOS character device support and driver loading support.
Separate the DOS memory manager code from the main DOS kernel source file.
CORE-9370 #resolve #comment Committed in revision r66895.
svn path=/trunk/; revision=66895
- Make brush structure definition C++ compatible
- Add delete callback for GDI objects and use if for brushes.
- Make IntGdiSetSolidBrushColor NTAPI instead of FASTCALL
svn path=/trunk/; revision=66891
- Add InterlockedIn/DecrementUL
- Define NULL to nullptr for C++ code
- Reorder includes a bit. First GDI then USER. Don't include most USER headers for C++ for now.
svn path=/trunk/; revision=66890
- Add ntwin32.h, move declaration of PTHREADINFO, PPROCESSINFO and W32CLIENTINFO there
- Avoid language extensions that are not C++ compatible
- Avoid dependenence to PTHREADINFO/PPROCESSINFO in ntuser.h and use incomplete types instead
- Move duplicate definition of PATRECT from ntusrtyp.h to user32.h private header
svn path=/trunk/; revision=66888
- intsafe.h: Fix some constants to be C++ compatible
- sal.h: Implement _Analysis_mode_, __prefast_operator_new_null and __prefast_operator_new_throws annotations
- Make probe.h (mostly) C++ compatible
svn path=/trunk/; revision=66886
- Handle allocation failures in FixupDIBBrushPalette
- In IntCreateDIBitmap make sure to the absolute height to GreCreateBitmap
svn path=/trunk/; revision=66883
- Introduce a "console configuration" library that is used by both CONSRV and the console properties applet so that they can share common code concerning getting/setting console registry properties.
- Make use of the Windows-compatible (and undocumented) CONSOLE_STATE_INFO structure for that purpose (as well as the WM_SETCONSOLEINFO): see commits r63819 and r58415 and links within for more details. Note: this structure needs to be 4-byte packed (contrary to what it is said in almost all the links from above. The difference is only visible at the level of the last member that is the ConsoleTitle string array. This was tested on windows).
- Simplify some parts of console settings initialization.
- Some work is still needed concerning how to correctly retrieve the default console settings (without touching the ConsoleTitle member of CONSOLE_STATE_INFO, contrary to what we do currently).
[CONSOLE.DLL]
- Make the console properties applet windows-compatible, in the sense that you can now run it on win2k3 and use it instead of the windows one. This implies having the same strange hacks as windows' one, namely, that the window handle parameter of the CPlApplet entry point is either used as the caller (parent) window handle, OR, as a shared section handle to shared data with CONSRV.
[KERNEL32]
- Rework the console applet initialization accordingly. Also we reload each time the console.dll when opening the console applet, and then unload it: this "allows" to reset all the global variables that console.dll may (and does) have.
svn path=/trunk/; revision=66867
- Create the window station handle and the desktops with MAXIMUM_ALLOWED access rights.
- Call AddAceToWindowStation before calling SetWindowStationUser.
svn path=/trunk/; revision=66863
Make outputting a string as easy as it should be. Now that our StringOut internally uses OutputDebugStringA instead of DbgPrint, we don't need to output in 512 byte chunks anymore.
Additionally, do an explicit flush when using std::cout to not lose debug output.
ROSTESTS-158 #resolve #comment Committed in r66855
svn path=/trunk/; revision=66855
- set the devmode size for ENUM_REGISTRY_SETTINGS case in NtUserEnumDisplaySettings so it gets copied back to caller later
svn path=/trunk/; revision=66854
- Always fill out KEY_NAME_INFORMATION::NameLength in CmpQueryNameInformation if enough space is available. Fixes ntdll:reg test failures.
CORE-9403 #resolve
svn path=/trunk/; revision=66844
- Fix bugs in MemExceptionHandler, VDDInstallMemoryHook and VDDDeInstallMemoryHook where we must translate physical addresses to real ones and vice-versa.
- Give a first implementation of VDDAllocMem and VDDFreeMem.
svn path=/trunk/; revision=66829
Fix an off-by-one error in the SMTABLE string parsing code. Enable SYS_VERSION string for VirtualPc detection. Should hopefully fix VirtualPc mouse.
svn path=/trunk/; revision=66825
Implement parsing of SMBIOS tables to be able to apply hardware specific hacks. First hack fix attempt is on Microsoft VirtualMachine.
svn path=/trunk/; revision=66823
- remove the custom parser, add caching, accelerators and lazy loading support and more (patch by Ismael Ferreras Morezuelas)
- modifications by me:
- don't rely on an undocumented behavior when calling GetPrivateProfileStringW and check the return value instead (should get fixed in kernel32 too)
- modify the packaging scripts so the resulting CAB file contains UTF16 encoded files and remove the re-encoding hack from the patch (this is backwards compatible as the previous parser implementation was UTF16 aware)
CORE-9060
svn path=/trunk/; revision=66814
- Add mising wmiguid.h
- Fix parameter of IoWMIOpenBlock based on latest WDK
- Add a few missing constants to wmistr.h
svn path=/trunk/; revision=66813
- add icons 165, 166 (by Robert Naumann) and 167 (adapted regedit icon by me) and add these to the Drive's properties Tools tab (patch by Robert Naumann)
- use the dialog resource id directly in SH_CreatePropertySheetPage (makes the icons actually draw)
CORE-9382
svn path=/trunk/; revision=66810
r62291
[NTOSKRNL]
Start implementing the built-in WMI driver
r62294
[NTOSKRNL]
Add basic code for the WMI GUID object
r62301
[NTOSKRNK]
Halfplement WmipSecurityMethod, implement WmipGUIDFromString as a wrapper around RtlGUIDFromString due to different format requirements, fix usage of RtlPrefixUnicodeString.
r62302
[NTOSKRNL]
Implement WmipFastIoDeviceControl, start implementing WmipIoControl
r62321
[NTOSKRNL]
Stubplement IOCTL_WMI_UNREGISTER_GUIDS and IOCTL_WMI_RECEIVE_NOTIFICATIONS, just enough that the callers don't error out.
r62322
[NTOSKRNL]
Zero out the guid object, remove debug breakpoints in WmipDeleteMethod and WmipCloseMethod (for now there's nothing to do), factor out the code to capture the guid object attributes into WmipCaptureGuidObjectAttributes, ignore ioctl 0x228168 for now and stubplement IOCTL_WMI_OPEN_GUID_FOR_EVENTS
svn path=/trunk/; revision=66797
- Let us know if we need to handle FPU emulation.
- The PspDeleteLdt and PspDeleteVdmObjects do not need to return anything, they just clean possible existing structures only.
- Use ExFreePoolWithTag when freeing Process->VdmObjects (help in detecting possible memory corruption).
- Since we sometimes toy with Process->VdmObjects, give a basic implementation of PspDeleteVdmObjects that just frees VdmObjects for now. Also, add an assert in PspDeleteLdt because the LdtInformation process member should remain NULL for now (since we don't use it).
svn path=/trunk/; revision=66793
Also set status in RtlSetLastWin32ErrorAndNtStatusFromNtStatus() (to match both name & documentation ;-)).
Patch by Stefan Ginsberg.
Should be sent upstream?
svn path=/trunk/; revision=66782
- Don't include user-mode header in kernel
- Don't set Win32 error in PsConvertToGuiThread(), it will be done in KiSystemServiceHandler()
- Fix setting Win32 error in KiSystemServiceHandler()
Patch by Stefan Ginsberg
svn path=/trunk/; revision=66781
- Don't allow a miniport to register more than once for shutdown callbacks
- Fixes hang on shutdown with the BCM57XX driver
svn path=/trunk/; revision=66779
- Fix network scanning when many base stations are in range
- Fix input buffer size for OID_802_11_DISASSOCIATE and OID_802_11_BSSID_LIST_SCAN
[NDISUIO]
- Return STATUS_BUFFER_TOO_SMALL when the OID buffer length is too small
svn path=/trunk/; revision=66778
Add the most recent VC2005, 2008 and 2010 runtimes to rapps.
Add the new VC2012 and 2013 variants, too. LibreOffice will love you for that.
svn path=/trunk/; revision=66773
- Revert hack from r63126 to make some notebook controllers work, and which also broke the mouse wheel on other systems, and replace it with an #ifdef.
See CORE-6901, CORE-4048, CORE-8572
svn path=/trunk/; revision=66762
- Improve the app's title by printing the filename and the current state of the player. By Ricardo Hanke.
- Fix pause state retrieval.
svn path=/trunk/; revision=66746
* Fix leak of the PIDL and PIDL Manager from the shell folder destructors.
* Switch PIDL Manager to a lazy enumeration so it won't lookup the folder contents unless/until they are needed.
svn path=/trunk/; revision=66745
- don't garble the output with invalid data in WideCharToUtf7
- fixes whopping 65536 failed tests and as a result Testman shouldn't choke on kernel32:codepage anymore
svn path=/trunk/; revision=66742
* Disable the hardcoded part of the File menu. It provided no useful function and couldn't be localized. It can be reintroduced later when it is done properly.
svn path=/trunk/; revision=66741
- adjust the settings dialog layout (by Stefan Fulea) CORE-9377
- disable the proxy settings input boxes if default/no proxy is selected
- update the czech translation
svn path=/trunk/; revision=66736
- Remove hardcoded registry values: CurrentVersion, CSDVersion and CurrentBuildNumber from HKLM\SOFTWARE\Microsoft\Windows NT\CurrentVersion. They are computed and stored there by the kernel.
- All the versioning is controlled by the two values: CSDReleaseType and CSDVersion in HKLM\SYSTEM\CurrentControlSet\Control\Windows. Currently we target SP1.
[NTDLL]
The lpVersionInformation->szCSDVersion string should not be built by RtlGetVersion, but instead retrieved from the Peb->CSDVersion string that in turn is initialized by the NTDLL PE Loader. Normally this is a App-Compatibility-dependent string, but for now we somewhat hardcode it (it is built using the actual Peb->OSCSDVersion number).
[RTL]: Rename some variables "à la NT" and use adequate types (but no code changes otherwise).
[NTOS]
- Fix PsGetVersion that should use the CmCSDVersionString variable. This API also returns TRUE if we are in checked build mode (the high byte of NtBuildNumber is flagged).
- The kernel should initialize the CurrentVersion, CSDVersion and CurrentBuildNumber registry values (and few other ones) from the two main CSDReleaseType and CSDVersion values.
- Fix the ReactOS-specific version+revision display in SOS mode.
CORE-6611 CORE-7889 CORE-8877
svn path=/trunk/; revision=66735
- Don't select disconnected interfaces as default
- Only count prefix matches of non-zero length
- Fixes connectivity with multiple NICs when one or more is disconnected
svn path=/trunk/; revision=66734
* Implement support for column sorting in CompareIDs, for Name, Type, and Creation Date columns. The link target, and registry key contents are not sortable yet.
svn path=/trunk/; revision=66732
- Add a whole bunch of new wallpapers (easier to grab them from the repo instead of going through Forum + Jira to search for them). Now that we support JPG/PNG/... wallpapers (in addition to bitmap ones) since r66394, we can have many jpg wallpapers for the price (read: same size) of 1 bitmap one.
- Move a file to a better appropriate place.
svn path=/trunk/; revision=66724
- Call DrawCaption in user32 when we get WM_NCUAHDRAWCAPTION and there is no active theme.
- Should finally fix CORE-9016.
svn path=/trunk/; revision=66723
Add winternl.h, which is compatible with the native one. Do not use this header. USE NDK! (Thanks Hermes!) It's only there for SDK compatibility and to make sure nobody will think it's missing and add it to make use of it.
And to make sure, nobody will use this header, it will #error if you include it from a reactos module.
svn path=/trunk/; revision=66721
* Implement loading the hardcoded list of root keys.
* Add support for root keys to the registry PIDL structure.
* Add support for root-key PIDLs in the registry folder.
* Implement loading root keys when no path is specified.
* Expose the registry folder as a namespace extension to My Computer.
* Make the namespace extension folder names load from resources.
* Add icons for registry keys and values.
CORE-9244 #resolve #comment Basic registry browsing should now be functional. Any other issues (including editing capability), would go in followup issues.
svn path=/trunk/; revision=66719
Make sure include/reactos/wine is included BEFORE PSDK headers. (I didn't tackle all DLLs, only those that (will) need it)
svn path=/trunk/; revision=66716
- Remove unneeded ChangeLog file (we have SVN)
- Partial wine resync of notepad (part 1/x): it's just to bring back some of their fixes and improvements. CORE-9371
svn path=/trunk/; revision=66712
CORE-8537 #resolve #comment Replaced the ASSERT by an informative message when the power action is not implemented. r66708.
svn path=/trunk/; revision=66708
Avoid redefinition of FILE_DEVICE_SMARTCARD in winsmcrd.h, when combined with wine/winioctl.h. A similar #ifdef exists in the MS header.
svn path=/trunk/; revision=66704
In WinMain, higher the scope of szFileName to ensure that it and all variables that point to it are valid
throughout the program.
Should fix CID 731447.
Patch by Ricardo Hanke
CORE-9360 #resolve
svn path=/trunk/; revision=66694
Add File search 6.8.1 to Database. Updates and German translation by me.
CORE-9338 #resolve #comment Added, thx for reporting.
svn path=/trunk/; revision=66691
lack of a proxy configuration by Peter Hater. German translation updated by me.
CORE-4852 #resolve #comment Committed, thx for help.
svn path=/trunk/; revision=66690
Initialize list entry after removing a message from DispatchingMessagesHead. Fixes list corruption.
CORE-9357 #resolve
svn path=/trunk/; revision=66685
- hardware ids must be terminated by 2 zero bytes
[KS]
- more fixes to software bus pnp enumerator
[MMIXER]
- dont assert on buggy topology lines
[NTOS]
- keys must be REG_OPTION_VOLATILE
- allocate file object with correct tag
[INF]
- register wdmaudio as pnp software device (not yet ready)
svn path=/trunk/; revision=66684
* Fix content type column to represent the correct type, or "Key". This column would contain the custom class name if it was ever assigned (I have not seen such a case).
* Implement reading registry values when enumerating details.
Now the registry browsing is semi-useful, albeit read-only.
svn path=/trunk/; revision=66676
* Replace the custom context menu classes with the default implementation from shell32. As a side-effect, navigation now works in ReactOS.
* Make use of the default implementations of IDataObject and IQueryAssociations from shell32 (required by the IContextMenu implementation of Win2003).
* Fix initialization of the NT Object Folder's pidl.
* Make CompareIDs recursive.
* Fix the recursivity in GetDisplayNameOf, when called with FORPARSING.
NOTE: There is still some issue with GetDisplayNameOf, where the address shown in the addressbar seems to skip path components.
svn path=/trunk/; revision=66674
- cpu.c: Convert the faulting address to "real" (VM) address before calling the exception handler.
- ems.c: Simplify code by using ARRAY_INDEX; some poiters should point to physical memory.
- ems.c: Memory hook addresses should be "real".
- memory.c: Remove an extra MemFastMoveMemory call; really use IsListEmpty (was commented by error in my previous commit).
svn path=/trunk/; revision=66671
- Move the VDD memory handler API prototypes to the corresponding DDK header.
- Fix few function arguments types and add few more comments :)
- Move all NTVDM-memory related functions to memory.c
- Prefer checking for !IsListEmpty(&list) instead of doing list.Flink != &list (ehh! NTVDM is not win32k!!)
svn path=/trunk/; revision=66669
- Implement VDDInstallMemoryHook and VDDDeInstallMemoryHook using page guards.
- Implement another API for memory hooks that should be faster than page guards
(for NTVDM only).
- Adjust the VGA and EMS memory handlers to use this method.
- In Fast486, implement a method that will allow us to "rewind" the current instruction,
in case it was interrupted by a memory hook page fault.
- Use a memory hook to protect the BIOS ROM from being written to.
svn path=/trunk/; revision=66666
- Implement NtUserResolveDesktop, which opens a desktop and a window station based on a desktop path string (format: "WinSta\Desktop").
- Move NtUserConsoleControl to a more suitable file, and implement the control code that allows CSRSS to assign console input threads to given desktops.
- Simplify a bit the code in NtUserSetInformationThread.
[CONSRV]
Turn the console input thread to a real one. There should be one such thread per desktop. When a console process is started, we open the desktop on which the process is going to start, we create a new input thread (attach it to the desktop) if needed, or reuse the existing one, and then we open the terminal on the correct desktop.
CORE-9346 #resolve #comment Fixed in revision 66662.
svn path=/trunk/; revision=66662
Don't set Message->DispatchingListEntry.Flink to NULL / compare against NULL, but use InitializeListHead and IsListEmpty. Make sure the list entry is properly initialize, when the item is removed Fixes list corruption.
svn path=/trunk/; revision=66661
- kernelspecs.h: Add IRQL level defines, remove a duplicate annotation and make some definitions more consistent
- concurrencysal.h: Add missing annotations (only dummies so far)
- driverspecs.h: Add some missing annotations
- sal_old.h: remove __inner_callback, which is in sal.h
svn path=/trunk/; revision=66654
Fix annotations for _dupenv_s and _wdupenv_s (They are broken in MS headers, looks like nobody uses attributes for SAL...)
svn path=/trunk/; revision=66653
Annotate mouse.c, move some prototypes to the proper location.
Fix bugs in EngSetPointerShape and IntEngSetPointerShape, where the passed in XLATEOBJ could be NULL. Found by MSVC static analyzer.
svn path=/trunk/; revision=66649
- Annotate eng/device.c and semaphor.c.
- Get rid of IntGdiAcquire/ReleaseSemaphore
- Move some prototypes where they belong
svn path=/trunk/; revision=66647
Fix all MSVC static analyzer warnings. (a few are suppressed after checking that it's ok)
Fixes a number of missing or wrong function return checks, wrong printf format specifiers and a few other things,
svn path=/trunk/; revision=66646
Move __analysis_assume to sal.h (like in newer Windows SDKs) and define it (together with _Analysis_assume_) to "((void)0)" instead of to nothing, to allow it to be used with a comma.
svn path=/trunk/; revision=66643
- Make NT_ASSERT() give the MSVC static analyzer a hint that the condition can now be excpected to be true. This adds __analysis_unreachable(), which uses __assume(0) on _PREFAST_ builds. This is neccessary, since it seems impossible to make MSVC respect __analysis_noreturn / __declspec(noreturn) on an intrinsic prototype like __int2c().
svn path=/trunk/; revision=66642
Update ntgdi.h:
- Change some return types from VOID to NTSTATUS. This was done recently on Windows, but there shouldn't be a compatibility issue with returning an NTSTATUS value instead of the random contents of the eax register.
- Change 2 parameters from VOID* to DRIVER_INFO_2W* and 2 parameters from VOID* to POINTL*
- Add annotations
svn path=/trunk/; revision=66641
- Pass size in bytes to UnsafeSetBitmapBits from NtGdiCreateBitmap
- In NtGdiSetBitmapBits check for stock bitmap and non-API bitmap.
svn path=/trunk/; revision=66616
- Remove wrong flags when initializing a DC
- Set DC::prgnattr before potentially passing it to the cleanup function after failure to create a handle. Add a comment that this is not actually enough. Will be fixed, once we use C++
- Increase GDI object stack levels to 20
svn path=/trunk/; revision=66615
Make sure a region is reasonably initialized, before potentially passing it to the cleanup function, when failing to create a handle.
svn path=/trunk/; revision=66614
NtGdiSetDIBitsToDeviceInternal: Check for ScanLines == 0 and clean up exit pathes. Fixes assertion failure in gdi32_winetest:bitmap
svn path=/trunk/; revision=66612
- Pass bitmap buffer size to SURFACE_AllocSurface and validate it
- Fix arithmetic overflow checks by using RtlULongMult
- GreExtTextOutW: do not allocate / blit zero sized bitmaps
- NtGdiStretchDIBitsInternal: do not pass negative y size to GreCreateBitmapEx
- DIB_CreateDIBSection: use calculated bitmap size, instead of biSizeImage when calculating the section view size and as size parameter to GreCreateBitmapEx
CORE-9245 #resolve
svn path=/trunk/; revision=66611
- revert an "improvement" in NtUserFindExistingCursorIcon
- Remove boken asserts
- Implement GreSetBitmapOwner and use it to set bitmap owner in IntSetCursorData
- Fix cleanup after failure in setting bitmap owner
- Fix string cleanup (don't free INTRESOURCE)
- Validate frame indices to be within range
- Make sure frame indices and JIR reates are copied
- A few other fixes/improvements
svn path=/trunk/; revision=66608
- fix multiple bugs in software bus pnp enumerator
[INF]
- add wdmaud.sys as a client of the software bus pnp enumerator
svn path=/trunk/; revision=66600
Add some missing intrinsics for GCC (_InterlockedExchangeAdd8, __incgsqword, _BitScanForward64, _BitScanReverse64, _bittest64, _bittestandset64, _bittestandreset64, _bittestandcomplement64, _rotr64, _lrotl, _lrotr, __lzcnt, __lzcnt16, __popcnt, __popcnt16, __lzcnt64, __popcnt64, __cpuidex, __ud2, __writecr8/__readcr8 (x86))
Remove useless top level const modifiers from parameters (they do only tell the compiler that the variable cannot be modified, they do not tell the compiler whether the parameter is a compiler constant!)
svn path=/trunk/; revision=66598
German update. No user cares about the number of colors at all. It always was called High/True Color and thus we do so too.
svn path=/trunk/; revision=66594
- Additional improvements by Ricardo Hanke, see CORE-8477 for all the details!
- Add support for play/pause button: now we change its icon and tooltip.
- Do not block when repeatedly change play/pause state.
svn path=/trunk/; revision=66593
- Few whitespace fixes.
- Fix a regression where an exception was thrown when opening a file from cdrom.
Patch by Ricardo Hanke.
CORE-9250 #resolve #comment Patch v2 committed! Thanks!
svn path=/trunk/; revision=66592
- Move all intrinsic prototypes to intrin.h and remove duplicated declatations from msc/intrin.h and mingw/intrin_x86.h
- Fix some intrinsic prototypes for GCC
- Fix some SAL annotations for intrinsics
svn path=/trunk/; revision=66573
- Remove leftovers from rbuild era.
- Remove .hgeol that was introduced in r53995 in an attempt to have Mercury "get[ing] native line endings":
<@hbelusca> tkreuzer - hi tkreuzer! do you know whether you still need this .hgeol file at the root of our source tree?
<@tkreuzer> hbelusca: no, feel free to delete it
- rgenstat/llmosrt.c --> llmsort.c (take it from cdmake); this is however an unused tool in our build toolchain.
svn path=/trunk/; revision=66570
No drive in media is not an error condition.
The hardware reporting no 'ghost' floppy drives like vmware don't show this trace.
svn path=/trunk/; revision=66569
Patch: Make it translatable and add German translation by Robert Naumann + fixed one typo by me.
CORE-9310 #resolve #comment Committed with one lil typo fixed, thx.
svn path=/trunk/; revision=66552
Rewrite NtUserSetCursorIconData
Fixes:
- Memory leaks
- Cursors left in an unpredictable / unhealthy state, including pointers to freed memory, when an operation failed
- Decision whether a cursor uses an ACON or CURSOR as the underlying structure based on user provided flags, instead of cursor flags, which were not even set in the first place.
- Allowing a usermode caller to corrupt the cusor structure, by converting an ACON with a smaller allocation size into a CURSOR
CORE-9301 #resolve
svn path=/trunk/; revision=66528
Get rid of our old cursoricon implementation. Rename cursoricon_new.c to cursoricon.c and remove all traces of NEW_CURSORICON
svn path=/trunk/; revision=66526
- Do not hardcode the length of the string arrays in the LoadString calls (use ARRAYSIZE instead)
- Localize the command prompt info line. CORE-9293 #resolve #comment I placed the string in the resource files so that you can now localize it!
svn path=/trunk/; revision=66518
- Finish a test run in the database when all tests have successfully been run. This got lost during the C++ rewrite of rosautotest in r40147.
- Don't spam the logs with useless OK messages. Only report the web service response if an error occurred.
svn path=/trunk/; revision=66516
- Always call MiniportISR if the interrupt is shared
- Call MiniportHandleInterrupt even if MiniportInitialize is running
- This commit and r66511 fix the Broadcom 57XX NIC (CORE-9295)
svn path=/trunk/; revision=66512
- Handle 64-bit PCI base address registers (BARs)
- Fix maximum address in resource requirements for 20-bit resources
- Fix flags on memory and I/O port resources
[NTOS]
- Fix handling of 64-bit resources
svn path=/trunk/; revision=66511
Add keyboard switcher to startup, per-user. Since we currently do not support expandable string values for shell run startup, just use a normal string. Also there's currently a bug in our explorer that makes the icon of kbswitch not appearing when it is launched at startup.
See CORE-6787 for more information.
svn path=/trunk/; revision=66508
LdrpInitializeProcess:
Don't use NtLdrEntry to initialize LdrpImageEntry.
It is overwritten afterwards to initialize the real NtLdrEntry.
svn path=/trunk/; revision=66505
- Implement __CxxFrameHandler3 as a wrapper around __CxxFrameHandler that translates VC8-style function exception descriptions to VC7-style. This is necessary to make C++ exceptions work on Windows Server 2003, because msvcrt!__CxxFrameHandler does not support VC8 descriptors there.
CORE-9290 #resolve
svn path=/trunk/; revision=66503
Update MSTSC with latest (1.8.3) rdesktop version.
Patch by 'hater', for more details see CORE-9013 #resolve #comment Committed, thanks!
svn path=/trunk/; revision=66502
[WIN32K]: Fix cursor check (in few corner cases SYSTEMCUR(ARROW) happens to be NULL, when some programs -- ole32 -- wants to create windows while there is no graphics initialized yet). James, can you investigate?
svn path=/trunk/; revision=66498
- Check the environment variable ROSAUTOTEST_DIR for an alternative path to the test executables. Otherwise use the default %windir%\bin
- Update the URL of the web service
svn path=/trunk/; revision=66481
Use the STRING(timestamp ...) command introduced in CMake 2.8.11 to get rid of our today macro and in particular the wmic dependency.
wmic requires administrator privileges on NT 5.x
svn path=/trunk/; revision=66480
- Add a test showing RtlUpcaseUnicodeString behavior with zero-length strings
- Run all test cases against FsRtlIsNameInExpressionTest on checked builds, only the Dbcs version asserts
CORE-9254
svn path=/trunk/; revision=66479
- Check for command line validity in some places.
- Correctly set the number of bitmap resources. Spotted by Thomas. CORE-6781
svn path=/trunk/; revision=66475
- Apply a different hack to make Jim happy.
- If you revert any of this and your changes break tests on Windows, I will revert your revert.
svn path=/trunk/; revision=66466
- Use a more standard name for the cursor position headless command structure.
- Remove the useless SysThreadCreated variable.
- Implement the remaining headless support in inbv functions, dealing with text colour (on windows, always set white text on black background). I added an extra feature (disabled by default) in case you want to get colourful headless support.
- Disable all code related to displaying different logos for different SKUs since up to now ReactOS doesn't have Storage or Cluster flavours, but keep it for reference in case somebody needs it. The resource IDs are still there.
- Disable all code related to rotating progress bar (à la XP) since it is not really implemented in ReactOS at the moment.
CORE-6781
svn path=/trunk/; revision=66461
wkssvc.idl: Add NetrWkstaUserGetInfo and NetrWkstaUserSetInfo definitions based on the Samba wkssvc.idl and MSDN.
[NETAPI32]
- Implement NetWkstaUserGetInfo and NetWkstaUserSetInfo.
- Add some debug output.
[WKSSVC]
Add NetrWkstaUserGetInfo and NetrWkstaUserSetInfo stubs.
CORE-9248
svn path=/trunk/; revision=66459
- button.c: Use NtUserAlterWindowStyle where wine uses WIN_SetStyle (usage and parameters were confirmed with windbg)
[NTUSER]
- Implement NtUserAlterWindowStyle.
Fixes remaining failures in user32:msg_controls test.
svn path=/trunk/; revision=66457
- Fix API GetDCEx tests! Dedicated to the great work by Timo Kreuzer.
- This uncovered a loop flaw, witch passed on any DCE last accessed.
svn path=/trunk/; revision=66452
- In MsgiUnicodeToAnsiMessage, use a single contiguous buffer for CREATESTRUCTA and its strings. This allows applications to modify the structure without ill effects
- Don't return the address of a stack structure in MsgiAnsiToUnicodeMessage
CORE-8777 #resolve
svn path=/trunk/; revision=66449
- Contrary to wine we store our version info with utf16 (like windows do). Fix checking for native internet explorer.
- Now our iexplore.inf is installed.
svn path=/trunk/; revision=66445
- Add IID_ITranslateShellChangeNotify, the answer to CORE-8844 - found by David
- Fix some non-constant offsets
- Re-alphabetize the lists
svn path=/trunk/; revision=66440
CORE-9248
Comment out NetGetJoinInformation and NetWkstaGetInfo in wksta.c and reimplement them as RPC client functions to the workstation service in wksta_new.c.
svn path=/trunk/; revision=66436
- Apply OffsetModuleName to the first import entry, not the current one in LdrpUpdateLoadCount3. Fixes missing reference updates on dependency-loaded DLLs.
CORE-5125 CORE-7127 #resolve
svn path=/trunk/; revision=66433
* Fix all the size calculations broken by r66425.
* Fix subfolder navigation (in windows).
* Fix enumeration skipping the last item.
* Add the beginning of a registry folder implementation. It doesn't display all data types yet, and it doesn't support editing or searching.
CORE-9244
svn path=/trunk/; revision=66426
- Fix headers.
- Fix MSVC warning C4200: nonstandard extension used : zero-sized array in struct/union.
[PSDK]
Fix MSVC warning C4200: nonstandard extension used : zero-sized array in struct/union. Note to Wine synchronizers and PSDK maintainers: those MIB* structures should go into a tcpmib.h header instead.
svn path=/trunk/; revision=66425
- Implement ILS_SATURATE in our image list implementation
- Use ILS_SATURATE when showing icons of disabled buttons in the toolbar
Patch Ismael Ferreras Morezuelas aka swyter
CORE-8916
svn path=/trunk/; revision=66418
[NBTSHELL]
[NTOBJSHEX]
* Fix prototypes of GetAttributesOf and GetUIObjectOf to conform with the specialized IDLIST subtypes.
[PSDK]
* Fix the declaration of PCITEMID_CHILD to make the "const" attribute affect the contents, and not the pointers themselves.
In preparation for whenever CORE-8441 happens.
svn path=/trunk/; revision=66414
- Rebar: paint the area that is not covered by the bands. This is a v6 feature and fixes the ugly non-painted rectangle in the taskbar.
svn path=/trunk/; revision=66402
- Revision string without the dash. That allows to possibly use a different separator.
- Just use the ROS revision number in the kernel SOS banner, instead of using a convoluted computation that overflows when the revision number is >= 65536. CORE-8877 #resolve #comment Fixed in r66398, thanks!
svn path=/trunk/; revision=66398
* Introduce a shell extension that allows the user to browse the NT Object namespace from within the shell.
CORE-9243 #resolve
svn path=/trunk/; revision=66396
- Load wallpapers using GDI+ and convert them to bitmap format as needed. We now support PNG and JPEG (and more) wallpapers! Patch by Ricardo Hanke, small modifications by me.
CORE-8802 #resolve
svn path=/trunk/; revision=66394
- BasepGetModuleHandleExW returns BOOLEAN, not NTSTATUS. Treat it as such.
- Always set last error code on failure in BasepGetModuleHandleExW.
CORE-9241 #resolve
svn path=/trunk/; revision=66382
- Mispelling + whitespace fixes.
- Move the finalization of the boot logo display *before* we enable strings to be displayed (as on Windows), but *after* having increased the progress bar to 100% (contrary to Windows), so that we can display the progress bar at 100% without any problem and then do the correct transition:
* either GUI splash-screen --> text-mode emulation console with product name in console header + footer (aka. SOS mode)
* or SOS mode --> text-mode emulation without any graphics.
Since it is done before starting SMSS, we can correctly display the strings it may output (or start other native apps) without fearing that after 5 seconds, the screen clears up in front of you.
CORE-9112 #resolve #comment Fixed in r66378, thanks for reporting!
svn path=/trunk/; revision=66378
CORE-3655 #comment Hackfix the fact that when being compiled with GCC on Linux, compiled messages have their endlines encoded with LF instead of with CR-LF as required by Windows compatibility. This should be normally fixed in windmc (the GCC/binutils message compiler); I've enough complained about that, but not directly to GCC/binutils team. Until they fix their tool, I ask SVN to always store the .mc files with CR-LF endlines. This should "fix" the problem. Suggestion by Thomas Faber.
svn path=/trunk/; revision=66376
Add back support for allocator stack backtraces for GDI objects and dump a list of BTs, when the GDI object table is exhausted. Disabled by default.
svn path=/trunk/; revision=66374
- In PspExitThread, correctly set the ZeroInit field of the message before calling LpcRequestPort (which would otherwise complain with STATUS_INVALID_PARAMETER and fail to send the message)
- In NtRegisterThreadTerminatePort, dereference the port object in case of failure, not a null pointer
CORE-9234 #resolve
svn path=/trunk/; revision=66369
- Add a test for process termination behavior. This shows that CreateProcess with CREATE_SUSPENDED followed by TerminateProcess causes a handle leak.
CORE-9234
svn path=/trunk/; revision=66367
- Make BaseSetLastNTError return the converted Win32 error code. This will determine the upper 24 bits of EAX in functions that return BOOLEAN FALSE right after calling BaseSetLastNTError, e.g. Wow64EnableWow64FsRedirection. Fixes installers using WiX Toolset (e.g. VS2012 redist) on MSVC builds.
See http://wixtoolset.org/issues/4681/ for the WiX bug that causes this.
CORE-8010
svn path=/trunk/; revision=66365
OK, Thomas had to convince me that MAX_USHORT + MAX_USHORT + 0x400 + 0x6 cannot overflow an ULONG.
So remove useless check.
By Thomas :-)
svn path=/trunk/; revision=66358
Don't pretend that ExceptionRecord.ExceptionInformation[2] is a pointer to a string in case of Delphi exception. This can lead to invalid pointer dereference in DbgPrint then.
For instance:
(../../dll/win32/kernel32/client/except.c:371) Delphi Exception at address: 50075885
(../../dll/win32/kernel32/client/except.c:372) Exception-Object: 00E885A8
(../../dll/win32/kernel32/client/except.c:373) Exception text: 2
svn path=/trunk/; revision=66354
- Fix packing for system restore point API types (STATEMGRSTATUS in particular). Fixes VC++ 2012 redist installer.
CORE-8010 #resolve
svn path=/trunk/; revision=66352
- Add some simple tests for RtlRaiseStatus to the RtlException test
- Add missing volatile in (disabled) stack overflow test that caused an infinite loop on GCC builds
CORE-8773
svn path=/trunk/; revision=66351
- Refactor EnumFontFamilies test to be more generic, and check for some common expected system fonts. This shows that EnumFontFamilies behaves correctly, but that we're missing the System font in the enumeration.
CORE-9222
svn path=/trunk/; revision=66347
- Reject bits data early in SetBitmapBits when it's clear that they can't fit in the destination bitmap.
Fixes ugly Office 2007 rulers showing garbage.
svn path=/trunk/; revision=66342
- Do not free resources at process termination.
- Free the provider catalog after the handle table, since the latter references the former.
svn path=/trunk/; revision=66337
- Do not merge memory blocks if they don't belong to the same VM "region" (ie not allocated from the same NtAllocateVirtualMemory call)
Fixes failures of ZwProtectVirtualMemory calls.
Bugs see DPH rollin', they hatin'
svn path=/trunk/; revision=66336
- MiIsEntireRangeCommitted: Ensure the PTE we are checking is really faulted in.
- Prefer MiPteToPde and MiPdeToPte (which should really be called MiFirstPteInPde) instead of MiAddressToPte and MiPteToAddress
Fixes weird failed ASSERT in page fault handler when using DPH.
svn path=/trunk/; revision=66334
- Load default application icon and display it in the taskbar for windows that have no icon. Fixes "GetIconInfo failed" debug prints all over the place (and looks prettier).
CORE-9211 #resolve
svn path=/trunk/; revision=66333
- Fix wine msg test_SetFocus tests. Use send message for WM_WINDOWPOSCHANGING. If nothing has been drawn and the no position changed bits set, set no Z order and no redraw. See CORE-7447.
svn path=/trunk/; revision=66332
- Add /n option to suppress console output. May or may not help to speed up testbot runs, but can't hurt to have in here.
svn path=/trunk/; revision=66318
- Abstract unidirectional anonymous pipes into a CPipe class
- Abstract a process with redirected output into a CPipedProcess class
- Use these abstractions to avoid polling for output from test processes. Instead, use blocking read operations to yield the CPU while waiting for data.
ROSTESTS-144 #resolve
svn path=/trunk/; revision=66316
- Sync to Wine 1.7.36
- Properly disable test_dib_formats. ROSTESTS-152, CORE-5922
- Fix skip message in test_mono_bitmap not to point to a resolved bug. ROSTESTS-153, CORE-5922
- Re-enable font tests that were left skipped even though the associated bug is correctly marked as resolved. ROSTESTS-8
svn path=/trunk/; revision=66312
- Fix wine msg:test_winevents.
- Fix global hooks while sending to same process different thread. Yes, interesting.
- Fix event hooks, use posting (faster) instead of sending. This fixed a problem while sending to the same thread.
svn path=/trunk/; revision=66310
NtQueryInformationFile: Implement FileAccessInformation and FileAlignmentInformation cases according to 'File System Internals' page 485.
svn path=/trunk/; revision=66307
- Part 2/2 of SrvLogon (see r66303): load the per-user shutdown timeouts.
- Retrieve those per-user shutdown timeouts from the registry when the user logs on, adapted from Alex' shutdown patch plus existing code.
- Commit the main part of shutdown code (finally!), still unfinished yet:
* Need to switch to the desktop where the hanging GUI app's window is present,
* Need to deal with apps from other users
* What about SYSTEM processes?
* What about console processes?
- Reuse the old timeout code.
- Fix the sending of WM_QUERYENDSESSION and WM_ENDSESSION messages (this is done by win32k directly; for that winsrv needs just to send one WM_CLIENTSHUTDOWN message with the correct wParam parameter).
Part 13/X
CORE-8322 #comment Big commit in revision 66306!
svn path=/trunk/; revision=66306
- In ExpReleaseOrWaitForKeyedEvent, always restore previous values for ETHREAD::KeyedWaitValue and ETHREAD::KeyedWaitChain, as these fields have alternative meanings outside of keyed events
- Add missing list walk in ExpReleaseOrWaitForKeyedEvent
- In Nt(WaitFor|Release)KeyedEvent, refuse keys that are not two-byte aligned as shown by Wine tests
- Don't forget to set KTHREAD::Process on thread creation
Fixes hang when running ntdll_winetest:om as well as failing tests.
ROSTESTS-118 #resolve
svn path=/trunk/; revision=66304
- Skip over service timeout tests because they take too long. This is not a bug, the tests are completing successfully -- however they are designed to cause service manager timeouts and take two minutes in doing so. Testbot time is too valuable to do this on every commit.
ROSTESTS-151
svn path=/trunk/; revision=66302
- Request only the access rights that are actually required in openTcpFile. Fixes many should-be access denied errors originating from netshell. While this doesn't fix the root cause of CORE-9172, it is a required step if we ever want netshell to work for non-Admin users.
CORE-9172
svn path=/trunk/; revision=66300
Add a stub for the "Windows Management Infrastructure" service.
This helps the Intel PRO eth card installer to go a bit farther
svn path=/trunk/; revision=66295
- Add KmtGetSystemRoutineAddress and use it to avoid importing functions that are not available in some versions of Windows. This allows running kmtests on Windows XP SP3 (and probably Server 2003 SP0/SP2). Note that failures on XP are still not valid bugs, this is purely for convenience! Dedicated to Jérôme.
ROSTESTS-150
svn path=/trunk/; revision=66281
Fix the explanations of how Windows/ReactOS should shut down (it's winlogon itself that calls NtShutdownSystem, not something else; that story about "SMSS API #1" concerns the SMSS API SmpSessionCompleteApi called by the helper function SmSessionComplete which is in turn called by CSRSS function CsrDereferenceNtSession, when all win32 processes are gone, as it should).
The webpage http://www.reactos.org/wiki/ShutdownProcess should be corrected for.
[USER32]
Whitespace fixes for winstation code.
svn path=/trunk/; revision=66275
Demote the "HACK: RemainingAccess = 0x%08lx DesiredAccess = 0x%08lx\n" from DPRINT1 to DPRINT, since it's massively spamming the log.
See CORE-9184
svn path=/trunk/; revision=66274
In NtGdiGetDIBitsInternal limit the size of what is being copied back to to usermode to the cjMaxInfo parameter. Fixes crash of Firefox when downloading files.
CORE-8895 #resolve
svn path=/trunk/; revision=66273
- magic_value--;
- Don't assign a desktop background colour by default. So that we can get the safe-mode background working (in safe mode), while having the default desktop background colours in normal situations.
Patch by Giannis.
svn path=/trunk/; revision=66271
Add #ifdef include guards to winnt.h. RC doesn't seem to support #pragma once and emits a redefinition warning, since with RC we first include winnt.h without STRICT defined, then again from windef.h with STRICT defined.
svn path=/trunk/; revision=66267
- Disable warning C4800: forcing value to bool 'true' or 'false' (performance warning). This is emitted when assigning an integer value to a C++ bool, which is always true (1) or false (0), so assigning an integer to it, will result in an implicit comparison against 0. But "fixing" this warning by adding an explicit comparison ("bool f = (i != 0);") will actually result in LESS efficient code (for whatever reasons). So this warning can be considered entirely useless and counter productive.
- Remove C4018 (signed/unsigned mismatch) from the TODO in the disable list. A comparison between an unsigned and a signed value will very likely result in wrong behavior and can easily cause hard to spot security bugs (e.g. when doing overflow checks). It is also often easy to fix.
svn path=/trunk/; revision=66266
NtfsMoonWalkID():
- Do not allow opening a file by ID if it's not in use any longer
- Do not attempt to create the full path, if an error occured during walk
svn path=/trunk/; revision=66265
Simplify the implementation of the "Open by ID" feature of our driver.
Instead of creating singleton FCB not linked to the rest of FS tree, just walk the whole path down, to recreate it.
This doesn't make nfi work properly though. Will investigate more.
CORE-8725
svn path=/trunk/; revision=66264
- Copy libwinpthread-1.dll if present instead of forcing the use of a specific set of GnuTLS binaries. Partially reverts r66110. Should fix testbot problems (mshtml_winetest:events in particular).
CORE-9167
svn path=/trunk/; revision=66257
Add the missing loop iterator in GetAdaptersAddresses().
This fixes infinite loop, and fixes Firefox 3.6 boot.
CORE-9051 #resolve #comment Fixed in r66253
svn path=/trunk/; revision=66253
- Reshuffle a bit some code.
- Never fail if the kill-COM-processes thread fails to be created.
- WlxLogoff GINA callback *must* be called *after* our logoff handling (with HandleLogoff). This is what happens on Windows (just add breakpoints on ExitWindowsEx and on WlxIsLogoffOk and WlxLogoff, and enable winlogon tracing).
[WIN32K]
Rename a flag to something more meaningful, and fix a flag filtering bug: lParams = wParam & something; ---> lParams = lParam & something; (the wParam is used for something else).
Part 12/X
CORE-8322
svn path=/trunk/; revision=66252
Add support for "module groups". These are meta targets that automatically include all targets using set_module_type() that are included between start_module_group(name) and end_module_group().
svn path=/trunk/; revision=66250
- Use a real timer for caret. This should cleanup message testing from those random system timer messages. See CORE-7447.
svn path=/trunk/; revision=66244
- Assert sanity of object reference counts in UserReferenceObject, UserDereferenceObject and UserDeleteObject. If you hit a cLockObj < 0x10000 assertion failure, you found yourself a use after free (RtlFreeHeap will put a LIST_ENTRY in this location, so a freed item has a kernel pointer there).
See CORE-8703 for an example.
svn path=/trunk/; revision=66243
- Implement KillComProcesses that just kills with force and without any notification back to winlogon, any remaining app that is still alive even if we asked before to kill apps (it's just the aim of this function, not more).
- Fix internal flags according to WinDbg sessions with Win2k3 + tracing checked build winlogon (testing logoff/shutdown/reboot from winlogon itself and when using the "shutdown" command).
- FIXME: Manage EWX_FORCE flag in winlogon...
[WINSRV]
Fix a DPRINT.
[WIN32K]
- Introduce a NotifyLogon function to manage winlogon notifications (when we shutdown and "end" shutdown steps, or cancel it).
- Fix some flags settings.
Part 11/X
CORE-8322
-------
This is a test:
!error !rot13 !reebe !ebg13 !error !rot13 !reebe !ebg13
svn path=/trunk/; revision=66240
- Fix the results from the new API CreateWindowEx tests. Message sequence and isolating each job Destroy and Free perform will come later. Refer to CORE-8703. This may not fix the crash while in wine test User32:msg.c.
- Dedicated to Thomas Faber.
- Fix build window list using threads. The link list works okay for locking but for tracking thread windows, use the snapshot method.
svn path=/trunk/; revision=66234
Partly sync find_value() with MESA 10.4.4. Fixes endless loop when GoogleEarth is started. GoogleEarth now loads and displays the earth, but it doesn't handle any input and makes the entire GUI hang.
svn path=/trunk/; revision=66232
- Handle the case where we have a masked ROP, but no mask surface in EngBitBlt
- Alloc ROPs with a mask in EngPaint
Fixes ASSERT when GoogleEarth is launched.
svn path=/trunk/; revision=66229
Improve naming of some BRUSH fields and set the correct fields to the correct values (ulStyle was not for the brush style, but the hatch style!)
svn path=/trunk/; revision=66227
- Show a confirmation dialog when emptying the recycle bin. Patch by Robert Naumann, with some modifications by me.
CORE-9006 #resolve
svn path=/trunk/; revision=66222
Sync all languages with the once more not synced English one... Every language has a different state and no one sees that if the new strings are not added in there. At least add the English original. Thx for understanding.
DIALOG -> DIALOGEX
svn path=/trunk/; revision=66214
- In ICO_ExtractIconExW, don't try to return two icons if only one was requested. Fixes stack corruption.
CORE-9142 #resolve
svn path=/trunk/; revision=66210
- Add additional list entry checks that can be optionally enabled by defining EXTRA_KERNEL_LIST_ENTRY_CHECKS. These checks warn against attempts to remove items from an empty list, which can easily be an error (and is trivial to avoid where it's not).
- Enable these checks by default for ReactOS code
CORE-8419 #resolve
svn path=/trunk/; revision=66208
- Add list entry security checks equivalent to those in current WDKs. This is useful for ROS because it detects memory corruption very quickly.
CORE-8419
svn path=/trunk/; revision=66206
- Support NO_PRIVATE_WARNINGS parameter when invoking spec2def to suppress warnings about symbols that should be private
- Disable such warnings for msxml3, ole32 and rsaenh
CORE-8445
svn path=/trunk/; revision=66200
- Add DPRINTs to monitor how shutdown goes on (obviously they will go away when shutdown on ROS will be working).
- Add dumb handler for LN_LOGOFF_CANCELED message (unused for now...)
[WIN32K]: DPRINTs added for monitoring shutdown.
[WINSRV]: Start to plugin the whole thing (using pieces of Alex' shutdown patch):
- We need to use a "shutdown" loop (for UserThreadInitiateShutdown win32k call) for being able to cancel shuts down (not implemented yet).
- Add the "magic" call to CsrShutdownProcesses that calls the Shutdown callback of each CSR server for each Win32 process (these are those callbacks that do the real job of terminating the apps, displaying the "Kill the app" dialog, etc...). In few words, the old (disabled) code of InternalExitReactos need to go into those shutdown callbacks (but this is for other commits!).
Part 9/X
CORE-8322 #comment Continue plugging in the shutdown code (from Alex' patch) in WINSRV with adaptations into WINLOGON (+ adding DPRINTs for controlling the whole thing).
svn path=/trunk/; revision=66197
Fix the ROP code passed to IntEngStretchBlt from NtGdiStretchDIBitsInternal. Fixes crash of Nimbus Notes installer.
CORE-9048 #resolve
svn path=/trunk/; revision=66195
Move the shutdown privilege check from winlogon to win32k (function "UserInitiateShutdown") as it should be done.
[WIN32K]
- Introduce the pair of UserInitiateShutdown/UserEndShutdown calls that should be called when WINSRV starts a shutdown (and when it finishes it). In particular it is in UserInitiateShutdown that we need to check whether the caller has the rights to perform a shutdown (it should also have a valid window station).
- Remove the ROS-specific TWOPARAM_ROUTINE_EXITREACTOS call that is traded for Win2k3-compatible call to UserInitiateShutdown.
[WINSRV]
Hackfix our current ExitWindowsEx functionality (based on a patch by Alex made against r46050 for win32csr) to make it "compatible" with the improvements in win32k: impersonate the caller and call the UserInitiateShutdown win32k system call (instead of the TWOPARAM_ROUTINE_EXITREACTOS). More will come later on.
[USER32]
Win32k can require performing shutdown in an asynchronous way (needed also on WINSRV side) so we need to put all the code in a worker thread.
Part 8/X (part 6 was r65693 and part 7 was r66186).
CORE-8322 #comment Start to add Alex' win32csr shutdown patch in WINSRV; fixes for winlogon and additions to win32k.
svn path=/trunk/; revision=66192
- Get rid of IDD_FILE_COPY dialog. It was never used, never completed and windows don't really have such a dialog.
- Remove SHShowFileOperationDialog which was never completed. This will be replaced shortly with a working solution by Huw Davies
svn path=/trunk/; revision=66190
- Sync Combo to wine head. Patch by Huw Davies : Make the combo's listbox a topmost window. See CORE-5186 for prior report.
svn path=/trunk/; revision=66183
- Patch by Piotr Caban : Only store dialog focus when window is hidden or inactive. Only use DIALOGINFO-> hwndFocus to store last focus of inactive windows.
svn path=/trunk/; revision=66182
- For now, only activate custom ReactOS boot on non-x86 builds.
- Fix INI section item list initialization before using it! Fixes custom ReactOS boots (ie. remove an invalid heap free). Now custom ReactOS boots work!
svn path=/trunk/; revision=66179
- Fix registry value retrieval with RegGetValue (RRF_RT_REG_EXPAND_SZ has a non-obvious functioning: it should be used with NO_EXPAND flag. Otherwise use RRF_RT_REG_SZ to retrieve REG_SZ values, or REG_EXPAND_SZ values with automatic expansion as expected). CORE-9001 #resolve #comment Fixed, thanks for reporting!
- Fix whitespace.
svn path=/trunk/; revision=66178
- Return timeout if the count and wait time is zero. This is a wine hack and fixes two related mgs:test_MsgWait* tests. Attempt to fix CORE-9117. Not sure if MsgWaitForMultipleObjects is the problem.
svn path=/trunk/; revision=66175
Load NtGdiFlushUserBatch dynamically to allow loading on Win 2003, where the function does not exist.
ROSTESTS-131 #resolve
svn path=/trunk/; revision=66172
- Setup system cursors and icons. Could help with Themes.
- Set default cursor to the message queue structure.
- Fix wine cursor icon tests. Fix ATI cursor passing issue.
- Fix that sticky mouse cursor while the screen saver is on.
- Move cursor code from User32 and shake that pop up window too.
- Setup for window station security checking.
- Dedicated to the great work by Jérôme Gardou. Doing ones best to preserve his original code!
svn path=/trunk/; revision=66166
- Warn about symbols that should be private. Patch by Thomas Faber. CORE-8445 #resolve #comment Committed in revision 66165. It's also nice/useful to get the warnings even if we are not generating an import lib (example when building rsaenh): MSVC warns also in this case.
- Improve error messages.
- some_ptr = 0; ---> use NULL instead.
- remove useless extra parentheses.
svn path=/trunk/; revision=66165
Build the Open-File filter mask in runtime, according to the supported extensions and media devices registered in the registry.
Patch by Ricardo Hanke.
CORE-7883 #resolve #comment Committed, with number-of-chars vs. number-of-bytes fixes by me, plus minor modification to build the filter only once when mplay32 is launched, and use a default filter if runtime filter build fails.
svn path=/trunk/; revision=66152
SeAssignSecurityEx: Add support for SEF_DEFAULT_OWNER_FROM_PARENT and SEF_DEFAULT_GROUP_FROM_PARENT.
This fixes several kmtest:SeInheritance bugs.
svn path=/trunk/; revision=66148
- Code style changes (whitespace + C-style comments).
- Move reactos/registry to windows/ since it's only for booting windows-like OSes that registry functions are used.
- ARC hw support functions first move (i.e. another code refactoring will happen) outside of reactos/ (since they are used generally, not just for ReactOS loading).
- ARC name outside of reactos/
- Delete now-useless reactos/ subdirectory.
svn path=/trunk/; revision=66145
- Fix date format in CHANGELOG (that uses that #$@! of US format)
- Diverse code style changes (whitespace, extra braces, C++ to C-style comments, ...)
svn path=/trunk/; revision=66144
Add keyed event access mask values and use them in the keyed event object implementation.
This fixes another kmtest:ObTypes bug.
svn path=/trunk/; revision=66139
- Whitespace files.
- Add missing PSEH inclusion (that can be detected if one comments the objbase.h include in rtl.h ...)
[MKHIVE]
Code cleanup + add a comment to explain what this ntoskrnl.h file is.
svn path=/trunk/; revision=66138
Show a critical error if txtsetup.sif cannot be found, instead of displaying empty fields in the setup. Patch by Lee Schroeder.
CORE-8971 #resolve #comment Fixed, thanks!
svn path=/trunk/; revision=66107
- Fix misusage of the hash-table. CORE-9098 #resolve #comment Fixed in revision 66100!
- Really fix date for files and directories when CDs are generated on Windows. Use UTC time everywhere. Simplify code.
svn path=/trunk/; revision=66100
Increase number of static memory descriptors from 32 to 40.
CORE-9097 #resolve #comment Please retest and reopen if it's still not fixed.
svn path=/trunk/; revision=66099
- Provide an editable file for the start menu banner just like we had for explorer-old
- Use the same font that's used for the ReactOS logo
svn path=/trunk/; revision=66095
Fix major bug in EngModifySurface: when pvScan0 and lDelta are passed, the surface is converted to type STYPE_BITMAP. pvBits is calculated accordingly and surface flags are updated according to flSurface parameter. Fixes crash with Intel 810 graphic drivers. Thanks to Julio Carchi for testing/helping with debugging. CORE-7821 #resolve
svn path=/trunk/; revision=66094
- CORE-9069 #comment Add a "NOT_IN_HYBRIDCD" flag (I don't have atm. a better name...) to specify files that must not be present in the bootcd/... or livecd/... directories of the hybridcd. The flag name is confusing because for few files (eg. readme.txt) it is used together with the target "all hybridcd". In this case, that means: add readme.txt file to the bootcd and livecd root directories, add it to the hybridcd root directory but NOT in the bootcd/ and livecd/ directories of the hybridcd... Everybody follows?
- Remove the bootsector files for the livecd (only keep isoboot though :) ) since they are not needed there (they are only needed for the bootcd).
svn path=/trunk/; revision=66092
Make the DiskReadBuffer location and size dynamic. Should fix a number of issues with non-standard BIOSes. Many thanks to jeditobe for his help with testing/debugging of this issue.
CORE-8899 #resolve
CORE-9031 #resolve
svn path=/trunk/; revision=66087
- Fix window from point so it handles disabled windows correctly.
- Cleanup processing mouse routine.
- See CORE-7447.
svn path=/trunk/; revision=66085
- Disable unused dir_hash_next_dir function and corresponding target_dir_traversal structure definition.
- Be really sure de->head and de->child are initialized at NULL.
- Remove extra parentheses and unused variable.
svn path=/trunk/; revision=66083
- Plugging in the real fix for CORE-6129!
- Works like it should, but CMD properties window gets active when it should not. See CORE-6651.
svn path=/trunk/; revision=66078
- Finally fix ATI tests. Break through while testing User32:win.c:test_window_from_point. See CORE-6551.
- If any trouble, please create a new Jira report.
svn path=/trunk/; revision=66074
- Add quite a lot of tests for IOCTL_TCP_QUERY_INFORMATION_EX
This IOCTL is quite important because that's how iphlpapi gets data from it.
Also, this can be used as a viewer for quite a lot SNMP info as described here: http://www.oidview.com/mibs/0/RFC1213-MIB.html
svn path=/trunk/; revision=66070
- Move TCP/IP driver setup code from netcfgx to syssetup.
- Implement SetupStartService().
This installs the TCPIP driver even if no network adapter is available.
CORE-8420 #resolve
svn path=/trunk/; revision=66069
Fix generation of ARM assembly stubs with C++ name mangling. Patch by Yuntian Zhang.
CORE-8700 #resolve #comment Committed, thanks.
svn path=/trunk/; revision=66068
* Replace the page setup dialog with a modified copy from comdlg32. Use PageSetupDlg and a hook function to bring the dialog on screen instead of DialogBox and a dialog procedure. With this, PageSetupDlg can do most of the work (init the controls for example).
* Save the returned hDevMode and hDevNames to two global variables, so we can use them in later calls to page setup and print.
* Include header, footer and page margins when saving/loading settings.
* Remove printer setup from the file menu (and related code/resources) since it isn't needed anymore.
* Brought to you by Ricardo Hanke.
CORE-9040
svn path=/trunk/; revision=66067
- When sending set cursor with an error hit, it should locate a pop up window if any are visible. See CORE-6651.
- Need to fix NtUser co_IntProcessMouseMessage and co_WinPosWindowFromPoint properly. While testing, added hack to help make this work.
- REAL fix for CORE-6129.
svn path=/trunk/; revision=66056
Introduce a way to add arbitrary files into the hybrid cd under a "extras" directory:
- put your files into /trunk/reactos/modules/hybridcd_extras
- do a cmake . && ninja hybridcd
- voilà.
Notice that you need to redo a configure (via "cmake .") in order to update the hybridcd list of files that get included into the hybridcd...
CORE-9069
svn path=/trunk/; revision=66052
Add basic Hybrid-CD generation to our build system.
Few changes were needed, especially in how we deal with the CD target "all": it's only for all the CD targets *BUT* the hybridcd. For the hybridcd you need to always specify the target manually (like in "... FOR all hybridcd" or "... FOR bootcd hybridcd" for example).
Since at the moment we cannot have the bootcd in RAMDISK, and I want to be able to either have the hybridcd booting livecd from within the CD (i.e. read/writes from the CD) or in RAMDISK, I need to also add the files that are going to be copied into the bootcd or livecd into the hybridcd.
CORE-9069 #resolve
svn path=/trunk/; revision=66051
* Fix a long-lived signed/unsigned mismatch that may or may not have caused a few issues when hot-tracking the menubar.
svn path=/trunk/; revision=66046
SepDuplicateToken: Do not allocate a new ModifiedId for the duplicated token. Use the ModifiedId of the source token instead. This fixes the DuplicateTokenEx test.
svn path=/trunk/; revision=66045
* Fix the notify window not resizing itself when the number of icons changes.
* Add error prints when AlignControls fails and exits early.
* Rename the Shell_NotifyIcon handler methods to something more appropriate.
CORE-9061 #resolve
svn path=/trunk/; revision=66040
- Remove hack to work around issue CORE-9039.
- Bypass two more DDE message calls from callback. Remove unneeded code.
svn path=/trunk/; revision=66032
* Overhaul the Popup method's position calculation. It now takes into account proper alignment preferences and exclusion rectangles in order to position menu popups better.
* Fix a small compatibility issue with windows shell objects.
* Use the item rectangle for the exclusion, so that the popup code can properly calculate how to flip the menu position if it doesn't fit downwards.
[EXPLORER]
* Fix the flags sent to Popup when showing the start menu. We have flags that say exactly what we want, and MPPF_ALIGN_LEFT/RIGHT were introduced with NT6 anyhow.
CORE-9004 #resolve #comment Should be fixed with trunk r66030.
svn path=/trunk/; revision=66030
Set directory creation date to creation date of its parent, and fix root directory creation date.
This fixes a off-by-one month if ISO was created between February and December,
and invalid dates if ISO was created in January.
svn path=/trunk/; revision=66029
Database Update. This fixes the now dead LibreOffice link, too.
I completely skipped MirandaIM because they suck by deciding to do the same shit, Filezilla did. SF Malware "optimized" installer!
svn path=/trunk/; revision=66026
- Fix DeviceRelations allocation bug
- Code style: Use sizeof(UNICODE_NULL) where needed; use sizeof(*ptr) for size of type pointed by ptr, when allocating space for ptr.
svn path=/trunk/; revision=66020
* Allow the result of the notify requests to return back to the caller. Fixes regressed shell32:systray winetests.
CORE-8840 #resolve #comment Should be properly fixed in r66019.
svn path=/trunk/; revision=66019
* Fix resource strings so they compile correctly.
* Make use of the resource strings for the tooltip.
* Implement a context menu for the volume icon, using resource strings.
NOTE: I have a strange issue where the cursor disappears while the popup is open. No idea if it's my fault or win32k.
svn path=/trunk/; revision=66015
- Whitespace fixes,
- Add braces for long "case blah: ..." code blocks,
- Add more informational messages when a feature is unimplemented (some control codes and cases happening when using ramdisk with bootcd).
svn path=/trunk/; revision=66013
Instead of keeping binary C arrays for FAT bootsectors (that by the way were completely out of date and were broken) in header files, just generate them out of our ASM-compiled bootsectors, with bin2c (as we do for PCI data for the HAL) and use them instead! So now we can use installfreeldr.exe to install e.g. a correct bootsector on a USB key that will work for loading freeldr! (and thus get rid of the Syslinux hack I presented in my video).
svn path=/trunk/; revision=66012
- Fix remaining DDE issues, re-sync DDE code from wine. Add QOS startup. Moved error debug prints to traces. Over all improvement with test results.
svn path=/trunk/; revision=66011
- Move directory enumeration into its own routine to prevent code duplication.
- Also, only take care of sub-node at the end of the enumeration. It doesn't make sense before.
- Supporting sub-nodes is still to be done.
svn path=/trunk/; revision=66009
Also retrieve $STANDARD_INFORMATION attribute on directory enumeration to get the right file attributes.
This fixes improper display in cmd & in explorer due to missing file attributes flags
svn path=/trunk/; revision=66007
- Implement DDE from wine. Leaving debug errors on the run and later move to trace. See CORE-7447.
- Use callbacks to User32 to convert the data and track it in Win32k.
- Add a new Quality of Service atom.
- Add things to class.c.
- Shell32 tests run now too, or only 4 run. This might be fixed too, since locating a lParam write back issue.
svn path=/trunk/; revision=66000
- Uppercase fixing for the english app title of Sound Recorder. From a suggestion by Jared.
- Fix some french translation.
- Fix some "reactos_sndrec32" thingie in other languages.
Translators, please review and fix the translations!
CORE-9029 #resolve #comment Corrected in revision 65986, thanks!
svn path=/trunk/; revision=65986
- Correctly append a backslash to the BootPath (if needed).
- Be able to specify relative boot paths (relative to the current boot device): as a consequence, remove the "LiveCD" hackish special value that was introduced long long ago.
- Fix BootPath retrieval in ReactOSSetup mode (via the SystemPath optional value), and use a better way to build the temporary txtsetup.sif full file names.
As a consequence we can now build hybrid cds with the following architecture:
\
--> loader\ (bootsectors + free/setupldr.sys)
--> myboot\ (contents of what_defaults_to_reactos directory for the bootcd)
--> mylive\ (contents of what_defaults_to_reactos directory for the livecd)
--> <regular_files>
and
freeldr.ini specifying the following values:
; The Setup entry
[Setup]
BootType=ReactOSSetup
SystemPath=\myboot
; The LiveCD entry
[LiveCD]
BootType=Windows2003
SystemPath=\mylive
Options=/MININT
Part 2/2
CORE-9023
svn path=/trunk/; revision=65982
- Some whitespace fixes in fs.h and code simplifications in fs.c
- Make FsOpenFile working correctly on non-ARC and ARC file names.
- Use FsOpenFile for opening ramdisks instead of ArcOpen (the file "handle" returned by FsOpenFile is just the FileId for ARC functions). Therefore we can open ramdisks files using Windows OSLOADER syntax, i.e. /RDPATH=the_image_file instead of being forced to append for example: net(0) (as in: /RDPATH=net(0)\the_image_file ): see http://lokniketan.org/index.php?title=PXE_booting_to_BARTPE#Work_with_files_in_the_TFTPBOOT_directory for an example of what I mean.
Part 1/2
CORE-9023
svn path=/trunk/; revision=65981
- Implement Ime (only) class support. This is for the new synced class tests. Recommending Developers choice for testing real Imm32.dll support. Should include registry Loading of IMM via Win32k.
- Based on patch by Piotr Caban : Move IME window procedure to user32.
svn path=/trunk/; revision=65977
- ARC disk functions return ARC_STATUS codes (that are ULONG btw, not LONG). Fix prototypes where needed.
- Rearrange a bit our arc.h header by putting together related structures.
[FREELDR]
- Remove arcemul/time.c (put functions back into machine.c). ARC functions should use some SYSTEM_PARAMETER_BLOCK firmware vector array instead...
svn path=/trunk/; revision=65964
Implement pre-install 'select format' and 'format' pages. These enable the user to re-format an existing install partitition.
CORE-9005 #resolve
svn path=/trunk/; revision=65962
Implement the FWAIT instruction.
Fix FPU exception handling. Implement exception masking.
Fix several other bugs and wrong definitions.
svn path=/trunk/; revision=65942
Split the D8/DC opcode handler into two handlers to eliminate the extra branch.
Implement opcode DF (New instructions: FBLD and FBSTP).
svn path=/trunk/; revision=65940
Fix several serious bugs in Fast486FpuToInteger.
Halfplement opcode 0xDD (everything except FRSTOR and FSAVE).
Cleanup the code a little bit.
svn path=/trunk/; revision=65935
Implement opcode 0xDE (New instructions: FADDP, FMULP, FCOMPP, FSUBRP, FSUBP, FDIVRP and FDIVP).
Fix a bug in the 0xD8/0xDC opcode handler.
svn path=/trunk/; revision=65934
"unfix" ROP_TO_ROP4, it was correct before, but the used ROP in NtGdiInvertRgn was not correct. Fixes display of shortcuts.
svn path=/trunk/; revision=65931
- Implement initializing themes as msdn suggests. We don't have shsvcs.dll yet but it doesn't harm to make our gina themes ready.
See http://support.microsoft.com/kb/KbView/322047
svn path=/trunk/; revision=65930
- Use a better icon for the bootcd.
- Replace the GUI ReactOS Setup program icon with a better one, copied from msiexec (just to note, the "setup" icon from shell32 and appwiz are the same as msiexec one). Inspired from CORE-8971.
svn path=/trunk/; revision=65925
[CMD]
Enhance the "ver" command, specifying the OS on which cmd.exe runs (that can be different from ReactOS!) and the reported OS version when using the $V prompt format specifier.
Patch by Lee Schroeder, with modifications by me, see the report for more details.
CORE-8970 #resolve #comment Committed in revision 65924, thanks!
svn path=/trunk/; revision=65924
You can install ReactOS on 'unpartitioned space' again. Usetup will create a primary partition that spans the whole unpartitioned space, format the partition and install ReactOS on that partition.
svn path=/trunk/; revision=65923
Fix calculation of the source point in EngCopyBits for complex clipping regions. One might assume that this function is so essential, that it would do at least the most basic stuff correctly, but ...
svn path=/trunk/; revision=65918
Display an error message with the file name in case we cannot get a file size over PXE.
This makes the error message "(../../boot/freeldr/freeldr/fs/pxe.c:107) err: PxeCall(0x25, 0000E8DE) failed with exit=1 status=0x1" in case of PXE boot less dramatic: it is expected not to find NTBOOTDD.SYS
svn path=/trunk/; revision=65917
Move the code that updates the partition type from FormatPartitionPage to a separate function (UpdatePartitionType) and call it from SelectPartitionPage. This fixes the creation of primary partitions.
svn path=/trunk/; revision=65916
- Fix definition of ROP_TO_ROP4
- Move some macros to intgdi.h
- Fix coordinate space mismatch in IntGdiBitBltRgn and IntGdiFillRgn
Fixes console window selection
svn path=/trunk/; revision=65914
InstallDirectoryPage1: Initialize DestinationRootPath. ReactOS can be installed on an existing partition again.
CORE-8984 #resolve
svn path=/trunk/; revision=65913
- Rewrite NtGdiInvertRgn to not violate locking order
- Remove DceUpdateVisRgn from DC_vPrepareDCsForBlit: It is not GDI's task to handle Window clipping, it violates locking order, it's slow, it's ugly to call USER functions from GDI internals, it's a hack. I couldn't see any clipping regression, if you find anything, let me know.
svn path=/trunk/; revision=65910
Use RegCreateKeyEx to be able to create the settings registry key in case it doesn't already exist.
Patch by Ricardo Hanke.
CORE-8986 #resolve #comment Fixed, thanks!
svn path=/trunk/; revision=65906
Implement RamdiskQueryDeviceRelations() when the device is a drive
According to Hervé, this allows booting ReactOS livecd using PXE (with one of his patch).
svn path=/trunk/; revision=65902
- Implement RamdiskQueryCapabilities() which is used in case of IRP_MJ_PNP + IRP_MN_QUERY_CAPABILITIES
- Implement RamdiskQueryDeviceText() which is used in case of IRP_MJ_PNP + IRP_MN_QUERY_DEVICE_TEXT
- Implement RamdiskQueryBusInformation() which is used in case of IRP_MJ_PNP + IRP_MN_QUERY_BUS_INFORMATION
- Implement RamdiskIoCompletionRoutine() which is the completion routine in case of IRP forwarding
- Also implement support for IRP_MJ_PNP + IRP_MN_START_DEVICE
- Define the RamdiskDiskInterface GUID
This slowly gets RamDisk driver PnP compliant...
svn path=/trunk/; revision=65900
Change the partition creation workflow, so that the user is forced to choose a file system type and format a partition after it has been created.
svn path=/trunk/; revision=65899
Wait for 1 min max but don't limit the number of acquire, ie: swap inverted args.
This fixes ASSERT on use.
Spotted by Hervé
svn path=/trunk/; revision=65898
Finish Japanese translation, fix by Ai Asano and reported by Marco Maria Emanuele Bartucci.
CORE-8983 #resolve #comment Fixed, thanks!
svn path=/trunk/; revision=65897
Use ANSI when printing to the console. Fix the logic of LookupPrivilegeDisplayNameW.
Patch by Ismael Ferreras Morezuelas.
CORE-8965 #resolve #comment Committed in revision r65894. Thanks!
svn path=/trunk/; revision=65894
Import metafile code from wine. The wine code is unmodified (please keep it that way) and used through a wrapper function dispatcher and some helpers. Fixes 1931 wine tests.
svn path=/trunk/; revision=65893
- Add global user heap (un)map helper functions that will be used in other portions of code.
- For consistency purpose also add the note about the mapping in desktop.c (see r65863 for what I mean).
- Temporarily add many trace messages.
svn path=/trunk/; revision=65891
In Escape() make use of GdiGetDcAttr(), GreatLordish -> English and fix copy-pasta in comments, improve formatting, remove some code that (attention euphemism) wasn't exactly correct.
svn path=/trunk/; revision=65889
- Implement GreCreateCompatibleDC, allowing to pass in a boolean value, specifying the DC type (normal or "alternative" DC, aka metafile DC)
- Properly implement NtGdiCreateMetafileDC around GreCreateCompatibleDC
svn path=/trunk/; revision=65885
Implement support for IOCTL_DISK_CHECK_VERIFY, IOCTL_STORAGE_CHECK_VERIFY, IOCTL_STORAGE_CHECK_VERIFY2, IOCTL_CDROM_CHECK_VERIFY
svn path=/trunk/; revision=65869
A bit of code reorganization:
- move a maximum of typedefs into their corresponding headers,
- move user heap functionality into a dedicated header,
- add a note in some functions that the first heap mapping entry in the W32 process info structure is dedicated for the global user heap mapping,
- remove extra-parenthesis in casts.
svn path=/trunk/; revision=65863
- In case of AssignSecurityDescriptor operation in IopGetSetSecurityObject(), put the security descriptor in cache before attempting the assignement
- In IopUnloadDevice(), don't attempt to free the security descriptor, let this to Ob by just derefencing it. Spotted & fixed by Thomas.
This unregresses VMware Tools installation.
CORE-7991
svn path=/trunk/; revision=65862
- Apply Wine commit f41ac94e (msi: Include the terminating null in the buffer size for decoded stream names.) by Hans Leidekker. Fixes a stack buffer overflow when installing VMware Tools.
svn path=/trunk/; revision=65859
- Implement IopGetDeviceAttachmentBase() which allows getting the base device of the device stack given any device object in it
- Implement IopGetDevicePDO() which returns the physical device object of the device stack given any device object in it
- Implement IopSetDeviceSecurityDescriptor() which will swap the old security descriptor of a device object with a new provided one
- Implement IopSetDeviceSecurityDescriptors() which will swap the old security descriptor with a new provided one in all the device objects from the lowest provided to the uppest provided one.
- Fix a fixme in IopGetSetSecurityObject(), the operation SetSecurityDescriptor is now fully implemented for both PDO & DO.
This is required by VMware driver vmci.sys.
Even though, the installation doesn't get any better; it just changes the BSOD, we now face a memory corruption (in SE).
CORE-7991
svn path=/trunk/; revision=65856
- Add another tiny text-editor Akelpad, which works "good enough" in ReactOS.
Suggested by sergeygraf@yandex.ru, patch created by rechitskiy@reactos.org
svn path=/trunk/; revision=65854
Also partly implement LsarpLookupPrivilegeDisplayName (currently, privilege description is the same as privilege name)
svn path=/trunk/; revision=65853
Partly implement the Provider class from WMI.
This allows VMware Tools installer to complain a bit less about imports not found.
The installation still fails and still ends with a BSOD though.
CORE-7991
svn path=/trunk/; revision=65849
- Re-enable the partition size check and display a warning if the install partition is too small.
- Update the required install partition size to 550MB.
svn path=/trunk/; revision=65847
- Add header for Ime information. Setup support for Ime types and hot keys.
- Finish keyboard processing changes and call Imm process key for callback to user mode.
svn path=/trunk/; revision=65845
- Add mod switch for SAS hotkey support.
- Add ImmProcessKey return flags, works the same as ImmProcessHotKey for WinCE.
svn path=/trunk/; revision=65843
- Move IME from stubs into its own file. Add flags and types to main header.
- Later, how to add Ime.h from mingw (tested it and works) and not effect VC++ ? VC SDK has Ime.h.
- Getting ready for Window Class update based on current wine tests.
svn path=/trunk/; revision=65842
Fix the following issues:
- Skip rotated font (font name starting with "@" char)
- Fix a comment (misspelled "Richedit")
- Fix enlarged preview font in font name is long (it truncated font name in 31 chars when copying)
- Fix 2 magic values (255 here is not meaningful, and it doesn't even entirely showing Unicode Plane 0)
Patch by Roy Tam.
CORE-8966 #resolve #comment Thanks. Commited in r65829.
svn path=/trunk/; revision=65829
Add French translation
It's totally broken though because the util directly writes Unicode to console. That should be fixed (see CORE-8965).
svn path=/trunk/; revision=65826
- CreateSystemThreads' parameter is unused, and the parameter of ONEPARAM_ROUTINE_CREATESYSTEMTHREADS win32k system call is set to TRUE when creating system threads in "remote processes", i.e. not CSRSS.
- Few code formatting fixes.
CORE-8949
svn path=/trunk/; revision=65825
* Do not make browseui an NT6 dll just because it has a missing include and it needs a few previously undocumented constants. We can just define them in an undoc header.
svn path=/trunk/; revision=65821
Fix NtUserProcessConnect to use the process handle we give to it, instead of the "current process"... This should fix the user32 CSR connection that I was failing to fix in previous revisions...
CORE-8949
svn path=/trunk/; revision=65820
Fix flags usage for LoadImage / CopyImage, that made network tray applet icons uglily being downscaled from 32px versions instead of their 16px counterparts.
svn path=/trunk/; revision=65819
Reintroduce CSR support for kernel mode, based on code from Ge that was wiped out in revision 58770, and by ntdll CSR code. Is needed for kernel to user-mode CSR callbacks.
For readers, I remind you the big callback picture in the Win32 subsystem:
- In Windows NT 3.1 and 3.51, USER and GDI was modeled against client/server model (USER32.DLL and WINSRV.DLL, and GDI32.DLL and GDISRV.DLL), all running in user mode (using the CSR API).
- Starting Windows NT 4.0 (and up), some USER and GDI parts were moved into kernel mode (in the WIN32K.SYS driver) to speedup communication. We get:
* GDI32.DLL as the client, doing win32k system calls (kernel-mode system calls to win32k),
* and USER32.DLL, WINSRV.DLL and WIN32K.SYS working in tandem, USER32.DLL being the client and {WINSRV.DLL, WIN32K.SYS} being the server.
USER32.DLL can do win32k system calls or CSR calls to WINSRV.DLL (client to server calls). For server-to-server calls, we have WINSRV.DLL
doing win32k system calls, or WIN32K.SYS doing CSR calls back to WINSRV.DLL . Also, there is the possibility for WIN32K.SYS to make user-mode
callbacks to USER32.DLL.
svn path=/trunk/; revision=65817
- Crash while in recursion through hook calls. Move fast calls to api. Placed safe guards for removing message queue structures. Lock threads while calling hooks. Just add paranoid code to prevent recursion freeing that will crash the kernel at some point. Fixes OpenMPT crashes, see CORE-8819. This might improve the same issues with CORE-6734.
svn path=/trunk/; revision=65815
Implement a virtualkd compatible kernel debugger transport DLL. I started this, because I didn't manage to get the original one working, but it turned out, the original one works, you only need to use the correct virtualkd version. Anyway, it's there now. A virtualkd version that works with VBox 4.3.16+ can be found here: http://forum.sysprogs.com/viewtopic.php?f=4&t=3370 or here: http://public.avast.com/~hnanicek/VirtualKd.zip
The folder is called kdvm, since I thought about adding support for VMWare as well, but here the original one probably works as well.
Also fix my email address in some files.
svn path=/trunk/; revision=65813
Reenable some disabled tests, while disabling some other calls, namely:
- code in ClientThreadStartup (that was moved in ClientThreadSetupHelper that is hackilly now called in Init() from DllMain),
- code in User32CallClientThreadSetupFromKernel,
- add two flag manual resets in Init() and the forced call to ClientThreadSetupHelper,
- and moreover the whole CSR call in DllMain, that seems to sometimes cause some user32 internal global pointers to remain NULL where they should not (more specifically some "pdi" thing).
Obviously all these problems need to be understood (why some things do not become initialized when they should, etc...). See r65799, revert r65810, and CORE-8949.
svn path=/trunk/; revision=65811
* Fix count of visible buttons getting out of sync when removing buttons. Fixes empty space at the end of the notification toolbar.
CORE-8840 #resolve #comment This should be fixed as of r65805.
svn path=/trunk/; revision=65805
* Improve an older change that I commited by mistake, with the improvbements based on a patch by Giannis.
* In Windows, fixes the taskbar having a size grip with the taskbar is themed and locked.
* In ReactOS, the size grip never seems to disappear, contrary to Giannis' concerns in the issue.
* Because of the above, I decided to commit the changes, and let the sizing edge inconsistency be a followup to the issue.
CORE-6966 #resolve #comment A modified version of the patch was commited in r65804. Thanks.
svn path=/trunk/; revision=65804
* Handle WM_CONTEXTMENU in the notification area so it does not spread upwards to the taskbar window.
* In theory, only one of the two handlers would be necessary, and it is true when testing in Windows, but in ReactOS, the handler in CSysPagerWnd was not enough. This may be worth a look by the win32k experts to see if it's a bug, or Windows was correcting my error.
CORE-8870 #resolve #comment Should be fixed in r65803. Thanks for reporting.
svn path=/trunk/; revision=65803
So far, totally disable VPB swapout on dismount. It appears to have brought more issues than it actually solves.
A more accurate implementation will be required.
CORE-8928 #comment Can you please retry with r65801
svn path=/trunk/; revision=65801
[USER32][USERSRV][WIN32K]
- Flag CSRSS threads as such.
- Each time a win32 thread is "created" (or a win32k system call is done) a PsConvertToGuiThread call is done, that makes a Win32ThreadCallout which calls UserCreateThreadInfo. We should call back ClientThreadSetup to set client-side info.
- Introduce a ClientThreadSetupHelper function to try to understand what happens when doing direct calls to ClientThreadSetup and via win32k callbacks.
- Reenable CSR call in user32::DllMain but add shame hacks in Init(..) to force NtUserProcessConnect callbacks (yet they should not be done there): see the code comment associated for more details.
- Temporarily disable ClientThreadSetupHelper call in ClientThreadSetup because it makes things fail, like console input thread failing and so on...
- ... and in ClientThreadSetupHelper, some correct code is commented out because it currently breaks other things (like menu initialization etc...), and HACKS ARE ADDED!! (see especially the "if (gpsi)" one, that should not exist, but if removed we fail sometimes in MenuInit because gpsi becomes NULL for some reason, if some other code that makes redundant calls to NtUserProcessConnect, is uncommented).
To sum up I tried to scaffold the thing as it should be, but with disabled code to not break everything.
CORE-8949 #comment Revision 65799 committed the patch v1.
svn path=/trunk/; revision=65799
- Reenable UserClientConnect callback, it's not the problematic code that made bots to fail at 3rd stage and caused r65716 to be committed.
- Put the system threads hack *after* having called NtUserInitialize (that really initializes user-kernel interface with win32k), and not before.
svn path=/trunk/; revision=65798
- Call NtGdiInit before initializing ourselves (ok, in ROS NtGdiInit does nothing interesting, but still do it to be call-compatible with win2k3 so everything initializes as it should).
- Do some cleanup on process detach.
svn path=/trunk/; revision=65797
- In German translation, replace erroneous \" to "" for putting quotes inside strings. Fixes resource compilation in GCC/MSVC.
- Make proper help string indentation in resource files. NOTE FOR TRANSLATORS: Please keep the identation correct!
svn path=/trunk/; revision=65790
Fix invalid memory usage, memory leaks, partial zeroes, big if blocks, ...
Would be nice also to check all the allocations which are not checked yet
CORE-8533
svn path=/trunk/; revision=65788
* Fix the fallback case when BCM_GETIDEALSIZE doesn't work.
* Take into account the size of the borders of the start button twice. Now the caption has enough space and doesn't hide part of the border and more importantly the button is vertically aligned to the tasks buttons.
svn path=/trunk/; revision=65780
Start implementing the recovery console: CLS, EXIT and HELP have been implemented. I also added a DUMPSECTOR command that enables us to dump disk sectors to the screen. For example "DUMPSECTOR 0 63" dumps disk 0 sector 63 to the screen.
svn path=/trunk/; revision=65778
Fix some translations as preparation to get this one fixed: CORE-5790
At least most languages now look sort of nicely. Next: apply the patch and check the non ResHacker compatible languages
svn path=/trunk/; revision=65776
* Forward focus to the defview window when the shell browser gets the focus.
* We can now navigate to the opened window with the keyboard right after it opens. That means that after opening from the desktop a window with the keyboard, we can navigate right away without any additional mouse clicks.
svn path=/trunk/; revision=65775
"No shortcut to the On Screen Keyboard in the start menu" by Jared
CORE-8883 #resolve #comment Committed with minor fix in German translation, thx for help.
svn path=/trunk/; revision=65773
* Do not enable the CExplorerBand wrapper by default. Avoids crashing due to a stack overflow.
CORE-8930 #resolve #comment Oops. Fixed in r65772. Thanks.
svn path=/trunk/; revision=65772
* Make the shell menus focus the parent before displaying themselves. Fixes keyboard focus when opening the start menu with the windows key.
NOTE: I put this in the focus manager for lack of a better place, but it may not be how Windows does it.
svn path=/trunk/; revision=65769
* Do not add two additional pixels at the top margin of the toolbar. This is the behaviour of comctl32 v6 and our explorer depends on that to appear properly. We don't have a proper solution for these differences in behavior and since we already opt to use the v6 behavior I think it is fine.
CORE-5483 #resolve #comment Committed a slightly different version of the patch, thanks.
svn path=/trunk/; revision=65766
* Halfplement IExtractIconAW support into the recycle bin. This is not fully correct as it always uses the fallback file icon, but it's better than nothing at all.
CORE-3938
svn path=/trunk/; revision=65759
* Move to shellext folder.
* Do not initialize the notification SSO, stobject will do so (like in Windows).
* Move some GUIDs to a shared header.
[STOBJECT]
* Initialize netshell's SSO the way Windows does it. Fixes network icon inconsistency.
* Move some GUIDs to a shared header.
CORE-8818 #resolve Fixed in trunk r65758.
svn path=/trunk/; revision=65758
Rename RGNOBJAPI_Lock to REGION_LockRgn and remove the 2nd argument, rename RGNOBJAPI_Unlock to REGION_UnlockRgn, remove the old inline lock/unlock functions. Do proper locking using GDIOBJ_bLockMultipleObjects in NtGdiEqualRgn.
svn path=/trunk/; revision=65746
- Crash is due to receiving an APC for the current sending thread. Prematurely freeing the data block and while the receiving thread did not have a chance to process it. Interception and calling back to user mode will allow thread to go away. What about the memory block, is it still allocated? A cleaver Hack can fix this, but still the application crashed leaving issues and trash laying about. See CORE-8779.
Reference:
http://msdn.microsoft.com/en-us/library/windows/hardware/ff565592(v=vs.85).aspx
"Yes, for thread termination. No, for user APCs."
svn path=/trunk/; revision=65744
Add the NtfsMftZoneReservation registry key on installation
See http://support.microsoft.com/kb/174619 for more information
svn path=/trunk/; revision=65741
* Fix the focus manager to properly close the shell menus when clicking outside the menu area.
* Close the shell menus when activating a context menu action.
* Open the shell menus without activating. Fixes titlebar color changing to inactive for the Favorites menu.
[RSHELL]
[SHELL32]
[BROWSEUI]
* Remove a few DbgPrints and downgrade some others into TRACEs.
CORE-8836 #resolve
svn path=/trunk/; revision=65740
- Rename SetRectRgnEx to IntSetRectRgn and make it usermode only
- Implement IntSetNullRgn
- Improve SetRectRgn code and enable the usermode part
svn path=/trunk/; revision=65739
Rewrite CombineRgn, enabling full handling in usermode if the resulting region is either a rectangular or a NULL region.
svn path=/trunk/; revision=65738
- Make REGION_iOffsetRgn check the region for coordinate space overflow and fail, if the region cannot be moved
- Rename REGION_iOffsetRgn to REGION_bOffsetRgn and make it return BOOL instead of the complexity, since the majority of callers are not interested in the complexity. It's also more obvious that we need to check for an error.
svn path=/trunk/; revision=65733
- Rewrite NtGdiFillRgn and IntGdiPaintRgn
We now properly support painting regions on DCs with arbitrary world transforms, with pattern brushes and we respect the foreground ROP and mode of the DC. And we don't run into deadlocks due to having an exclusive region lock while trying to lock a DC. LOCKING MUST BE DONE IN PROPER ORDER!
svn path=/trunk/; revision=65730
- Rename IntSetPolyPolygonRgn to REGION_SetPolyPolygonRgn
- Implement GreCreatePolyPolygonRgn wrapper around it
- Fix iMode usage in NtGdiPolyPolyDraw
- Improve some variable naming
svn path=/trunk/; revision=65726
Rework GreCreateFrameRgn to return the new region. Implement the internal function REGION_bMakeFrameRegion doing the actual work. Fix frame calculation by moving the source region diagonal instead of only horizontal and vertical, use IntGdiOffsetRgn instead of manually fiddling with the rectangles.
svn path=/trunk/; revision=65725
More improvements to region.c:
- PROSRGNDATA -> REGION, void -> VOID, int -> INT, uppercase struct names
- do not put assignments into if statements
- !x -> x == NULL for pointers
- Add additional parentheses / curly braces
- rename RGN_ATTR::Flags to iComplexity
svn path=/trunk/; revision=65720
Temporarily disable UserClientConnect (in server side) and CSR client to server call (in client side), always set gfServerProcess to FALSE (that is normally almost true but when CSR itself does USER32 operations...), and comment again GetConnect() call in ClientThreadSetup, in an attempt to "fix" 3rd stage for bots (so that we don't assert in DesktopPtrToUser because some pdi is NULL...)
svn path=/trunk/; revision=65716
- Code formatting for NtUserProcessConnect.
[USER32]
- Hack a call to GetConnected in ClientThreadSetup in an attempt to temporarily "fix" a bug that makes the bots fail. Now we really need to fix user32 init!
svn path=/trunk/; revision=65714
- Set the process creation notify routine for BASE that needs to be called when a process is created.
Patch by Timo, see CORE-7505.
[BASESRV]
- Implement BaseSetProcessCreateNotify that just saves internally the notification function to be called when a process is created.
- Call the notification function where it should be.
CORE-7505
svn path=/trunk/; revision=65712
- Play around and declare USERSRV_API_CONNECTINFO (CSR-style-name connect info structure type) as an alias to USERCONNECT (win32k-style-name) structure that is used to perform... "connections" between user32 and winsrv/win32k subsystem.
[WIN32K]
- Make UserThreadCsrApiPort case of NtUserSetInformationThread return success to make usersrv happy (while saving CSR port handle in win32k is still not implemented).
[USER32]
- Clean up "a bit" DllMain, call CsrClientConnectToServer to connect to usersrv (copy-paste of what we do in kernel32 for base and console connection) and now determine properly whether we are doing server-to-server calls (i.e. properly set gfServerProcess).
- Reorganize GdiDllInitialize calls and put them all to the end of DllMain instead.
- No need to support DLL_THREAD_ATTACH/DETACH so call the magic DisableThreadLibraryCalls function.
[USERSRV]
- Implement UserClientConnect with the patch of Timo CORE-7505: it gives a CSR port handle to win32k (if not already done), then do process connection.
CORE-7505
svn path=/trunk/; revision=65710
* Remove internal IStartMenuSite interface that didn't serve any purpose.
* Stop using global instances of some core classes.
svn path=/trunk/; revision=65703
* Simplify a lot of methods my using helpers from shlwapi.
* Remove declarations for undocumented functions that are already declared in our headers.
* Move definitions of IID_IAugmentedShellFolder and CLSID_MergedFolder to our headers.
* Remove definitions of functions that are already implemented in shlwapi.
* Add CreateMergedFolder and CreateMenuBand functions in precomp.h in order to simplify creating these objects when using rshell.
svn path=/trunk/; revision=65698
* Implement handling of file associations marked as "NoOpen". Patch by Lee Schroeder, with a few tweaks.
CORE-8855 #resolve #comment Commited in trunk r65697. Thanks.
svn path=/trunk/; revision=65697
- Simplify NtUserInitialize: we can check whether gpepCSRSS is != NULL to see if we are initialized or not (instead of using gbInitialized).
- The UserInitialize helper doesn't need to take parameters. The two event handles (power and media, used when we receive a power event -- for sleep, etc... -- and a media event -- like USB key insertion and such --) just need to be used in the not-yet-implemented "Initialize Power Request List" and "Initialize Media Change" steps.
- Something that should be done is to bugcheck if the USER version reported is != 5.0 (as windows does).
[WINSRV]
- Collapse common inclusions from usersrv and consrv into the common header winsrv.h.
[USERSRV]
- _UserSoundSentry is NTAPI
- Stub UserClientConnect (Timo's patch contains more involved code. I will commit it later).
- Our NtUserInitialize(0, NULL, NULL); call (that made Windows BSOD) is wrong. It should be done with its first parameter correctly set to the USER version (5.0) and the two other parameters are handles to power and media events (see above). We should create them before.
This is part of patch by Timo Kreuzer.
CORE-7505 #comment UserClientConnect stubbed (it should be better implemented, I will commit the code from the patch later on); power&media events initialized; NtUserInitialize corrected.
svn path=/trunk/; revision=65696
Stubplement NtUserQueryInformationThread and NtUserSetInformationThread that will be used for:
- shutdown support: CORE-8322
- communicating a CSR Port handle to win32k: CORE-7505
CORE-7505 CORE-8322
svn path=/trunk/; revision=65693
On Windows 2k3, BASESRV_API_CONNECTINFO went under a slimming treatment and now is only 4 bytes. In fact all its information was already existing in the static base data structure (BaseStaticServerData). We should now be more 2k3-compatible :)
Fix also the testbots.
svn path=/trunk/; revision=65690
- Introduce BaseClientConnectRoutine and BaseClientDisconnectRoutine functions that do basesrv (de)initialization, and BaseSrvNlsConnect that may potentially init further NLS support in the future.
- BaseSrvDebugProcess is deprecated in Windows 2k3+.
- Few whitespace fixes.
Piece of patch by Timo Kreuzer.
CORE-7505 #comment Basesrv (dis)connect routines committed in r65684.
svn path=/trunk/; revision=65684
* Use PrivateExtractIconsW instead of PrivateExtractIconExW to obtain the icons for caching. Fixes small shell icons using large icons scaled down instead of the proper 16px icons. Patch by Ismael Ferreras Morezuelas (swyter).
CORE-8404 #resolve #comment Commited in r65683. Thanks.
svn path=/trunk/; revision=65683
- Cleanup a bit csrmsg.h (by me), the ObjectDirectory member of the CSR_API_CONNECTINFO structure becomes unused starting Windows 2k3 (add an informative comment about that fact).
- Remove now unneeded ObjectDirectory duplication code (by Timo).
- Fix some whitespace.
CORE-7505 #comment ObjectDirectory duplication code removed in r65682.
svn path=/trunk/; revision=65682
- Store the link count in FCB and return it in FileStandardInformation query
- Return the MFT index in NtfsGetInternalInformation query
svn path=/trunk/; revision=65679
Part 2 of a patch by Edijs.
CORE-5655 #comment Patch committed. When one of you will have a patch for the Windows-menu items disabled bug, please reopen the report. #resolve
svn path=/trunk/; revision=65677
Italian translation of user accounts (control panel) by nicoalta01 (Marco Maria Emanuele Bartucci as I hope his name is)
While I was at it... convert the rest to UTF8
CORE-8857 #resolve #comment Committed, thx for help.
svn path=/trunk/; revision=65665
TRANSLATION: Czech translation update
CORE-8499 #comment INF is UCS2 LE now and the Lang ID is corrected. Can you confirm that this is fixed now?
svn path=/trunk/; revision=65663
- Implement NtfsGrabFCBFromTableById() and NtfsGetFCBForFileById(). These two are responsible for opening and retrieving a file open by ID.
- Modified NtfsMakeFCBFromDirEntry() so that it supports openings by ID which come with less information than normal openings.
- Modified NtfsGrabFCBFromTable() so that it doesn't return a FCB which would have been opened by ID.
- Modified NtfsOpenFile() so that it allows opening a file by ID using the two FCB helpers functions defined upper.
- Modified NtfsCreateFile() so that it can validate input in case of opening by ID.
To make it short, all this implements file opening by ID in NTFS driver. I made the choice to separate FCB which are coming from "normal" opening and these from ID opening.
The reason is that a file opening with ID has less information than a normal opening, and may fail on these information retreival. This is due to the fact that if opening by ID can virtual open all the files, because it ignores authorizations, traverses checks, in the end for retrieving the information, such checks can be done and fail.
I also left all this disabled so far, because it appears to regress NFI. I will investigate this.
CORE-8725
svn path=/trunk/; revision=65652
Implement GetVolumeBitmap().
This allows NFI to find which file is at which LCN: http://www.heisspiter.net/~Pierre/rostests/NTFS_NFI_LCN.png
So far, NFI is not as verbose as it is on Windows in such cases, because FILE_OPEN_BY_FILE_ID is *still* unimplemented (you should consider implementing it Pierre ;-)).
I checked with Windows, the correct file is found though!
CORE-8725
svn path=/trunk/; revision=65645
- In the VCB, directly store the total number of clusters available in the volume, this will save a few recurrent divisions
- Use this everywhere it is possible
- Validate input in GetVolumeBitmap(): make sure we don't want bitmap beyond end of the volume
CORE-8725
svn path=/trunk/; revision=65639
- Implement NtfsGetUserBuffer() that will (attempt to) return the user output buffer for METHOD_NEITHER IOCTL.
- Implement parameters checking GetVolumeBitmap()
CORE-8725
svn path=/trunk/; revision=65638
Switch calc to using the registry for storing configuration values. Remove 9x codepath. Patch by Lee Schroeder. Cleaning up Ziliang Guo.
CORE-7746
svn path=/trunk/; revision=65633
Incorporate fixes provided by a patch from over three years ago that adds support for the additional compare options. Patch provided by kruntuid. Slight cleanup and reshuffling of some code to make it cleaner.
CORE-8484
svn path=/trunk/; revision=65629
Update the Event Detail Dialog to better match XP/2K3
Patch by Lee Schroeder.
I updated the remaining dialogs.
Translators: Please check the dialogs!
CORE_8904 #resolve
svn path=/trunk/; revision=65628
- Patch by Vincent Povirk : Allow EndMenu() calls from WM_ENTERMENULOOP.
- Patch by Akihiro Sagawa : Don't close a popup menu when clicking a sub-menu parent item twice.
- Move code to match wines. See CORE-8299.
svn path=/trunk/; revision=65622
Modify font enumeration code to deal with failure to read the registry key. Also change the registry key being queried to match the one used on Windows. Patch by Ricardo Hanke.
CORE-8203
svn path=/trunk/; revision=65621
* Followup to t65603. Fixes the start menu themeing regression (when running explorer in windows 2003).
CORE-8898 #resolve
svn path=/trunk/; revision=65618
Ach! Wir können noch nicht mit dem ID öffnen!
So far, bail out when we are requested to open a file with its MFT index instead of its name.
nfi triggers this a lot. Likely to be implemented ;-)
CORE-8725
svn path=/trunk/; revision=65613
My dear Pierre, in FSCTL_GET_NTFS_FILE_RECORD, you have METHOD_BUFFERED (yes, read well ;-)).
So if you want it to work, you HAVE to return the size of the data you wrote to the output buffer...
This makes FSCTL_GET_NTFS_FILE_RECORD finally working in ReactOS...
nfi.exe finally goes a bit farther, displays some files names and dies. Definitely still needs love.
CORE-8725
svn path=/trunk/; revision=65612
* Use LoadLibrary instead of GetModuleHandle in the wrapper of WinList_Init.
* Shdocvw was never loaded till that point so WinList_Init was not called.
* Should fix Opening link location in windows.
svn path=/trunk/; revision=65611
* Cleanup variable names and fix a few typos along the way.
* Refactor the start button code into a CStartButton class.
NOTE: There is a known regression with start button themeing, which I'm working on. The missing notification icons are not caused by this.
CORE-8898
svn path=/trunk/; revision=65603
Implement the downward fashion of FSCTL_GET_NTFS_FILE_RECORD and always return a file record which is in use
CORE-8725
svn path=/trunk/; revision=65601
* Make SetWindowStyle and SetWindowExStyle simple wrappers around SHSetWindowBits. There is no reason to reinvent the wheel.
svn path=/trunk/; revision=65599
THE oneliner....
Properly read the information from the IRP to get the reparse tag. This fixes the handling of reparse mount points in ReactOS.
To make it short and crystal clear: reparse points from NTFS now work in ReactOS.
Demonstration with a Windows 7 volume read inside ReactOS with our NTFS driver and the "Documents and Settings" directory pointing to Users.
IopDoNameTransmogrify() properly gets the reparse data and extracts the mount point:
(../../ntoskrnl/io/iomgr/file.c:178) IopDoNameTransmogrify(B074DB98, B022BC28, B0226068)
(../../ntoskrnl/io/iomgr/file.c:232) Old name: '\Documents and Settings\'
(../../ntoskrnl/io/iomgr/file.c:266) Reparsed name: '\??\C:\Users'
Then.... http://www.heisspiter.net/~Pierre/rostests/NTFS_Reparse.png
First, I attempt to open "Documents and Settings" on my NTFS volume, it fails as "C:\" drive is hardcoded in the reparse point.
So, I create the Users directory on C:\ and a dummy file in it.
Then, I cd again which works now.
And dir properly shows the dummy created file :-).
svn path=/trunk/; revision=65596
Fix the implementation of the reparse point handling. This takes into account our $FILE_NAME attribute not being aware it's a reparse point...
We now fully get into Io and fail miserably as it seems I forgot one place where reparse points support has to be added.
D'oh!
svn path=/trunk/; revision=65594
On FCB creation, merge file attributes from $FILE_NAME and from $STANDARD_INFORMATION
Not sure it's fully legal, but it allows us to catch them all!
svn path=/trunk/; revision=65592
- Use a timeout to send WM_COPYDATA.
- Recall reading, while being sent to a thread that is hung indefinitely or blocked, it will not return properly. This seems to be the case for CORE-8779. Play it safe and use a timeout.
svn path=/trunk/; revision=65589
- Implement NtfsReadFCBAttribute() which is responsible for reading an attribute from a file which is referenced by its FCB. It will first read the file record in the MFT and then read the attribute, if found.
- Use NtfsReadFCBAttribute() to implement support for reparse point in NtfsCreateFile(). Once a reparse point is found, we attempt to open its data. Given their layout, we directly hand them to the Io manager. Just make sure that we return something consistent on disk. Only handle IO_REPARSE_TAG_MOUNT_POINT so far.
Next question to answer is: what to do when a reparse point is encountered during path traversal?
svn path=/trunk/; revision=65586
Implement support for (some) reparse points in Io manager. Ob should be already fine.
- Implement the IopDoNameTransmogrify() function. This one is responsible for checking the correct data for the reparse point and to update the path name in the file object. It will also free the memory buffer allocated by the driver to communicate the reparse information.
- Fix the support for reparse points in IopCompleteRequest(). If we receive reparse status + reparse tag we know, we call IopDoNameTransmogrify() to update file objet.
- Fix the support for reparse points in IopParseDevice() (oh! you again? :-)). When we complete the IRP ourselves, act as in IopCompleteRequest(). Then, we properly update objects manipulated by Io for the create request and we return STATUS_REPARSE so that Ob can update and recall us afterwards so that we complete.
Some parts are left unimplemented when it comes to reparse tags which are not IO_REPARSE_TAG_MOUNT_POINT. But still less than previously ;-).
svn path=/trunk/; revision=65584
Replace the old "My Computer" icon with a new one.
New icon by: Ismael Ferreras Morezuelas.
CORE-8890 #resolve #comment Committed in revision r65583. Thanks!
svn path=/trunk/; revision=65583
- Add german resource file.
- Convert all others to UTF-8.
- Add manifest file and modify DOIALOG to DIALOGEX + changing default font to MS Shell Dlg. Hello themed keyboard ^^
TBD: Sizes are WAY too small IMO...
svn path=/trunk/; revision=65572
* Make the CBandSiteMenu class actually insert the Toolbars menu, even if it's not yet implemented. This fills the top of the taskbar context menu instead of leaving an ugly separator at the top.
svn path=/trunk/; revision=65566
* Reorganize a bit the CTrayWindowCtxMenu::QueryContextMenu method and do not error if AddContextMenus fails. Fixes the taskbar context menu not opening on right-click.
(No need to call it explorer-new now that it's the primary one!)
CORE-8838
svn path=/trunk/; revision=65560
- Implement handling accelerators for CDesktopBrowser. The only noticeable difference is that pressing alt+f4 in the desktop doesn't close it.
See issue #8864 for more details.
svn path=/trunk/; revision=65557
- Implement registering all hotkeys that explorer registers in windows. Not all of them are implemented. The ones that are implemented work fine in windows but most of them don't work on ros. Thankfully nothing regressed by doing things the same with windows .
svn path=/trunk/; revision=65556
- Handle TWM_DOEXITWINDOWS in CTrayWindow. This message is sent from CDesktopWindow when it handles alt+f4 as an accelerator.
- Also handle SC_CLOSE for WM_SYSCOMMAND by calling ExitWindowsDialog.
- Fixes pressing alt+f4 in xp
- Now we have to make CDesktopWindow send TWM_DOEXITWINDOWS to the tray
svn path=/trunk/; revision=65555
* Add a stubbed CExplorerBand, which I will be using to investigate how the windows shell implements the sidebar panels.
This will never be called in ReactOS because our shell view doesn't handle the buttons for opening the sidebars, so it never asks the shell browser to open one.
CORE-8815
svn path=/trunk/; revision=65554
* The windows menu classes hide the items when the callback returns S_OK, and show them on S_FALSE. Fix our implementation to match.
* The windows CMergedFolder uses its own internal SHITEMID structure, so using filesystem paths directly won't work for hiding the Programs folder.
* Also, because of the above, it's best to create the Programs menu object separately.
svn path=/trunk/; revision=65541
* Stop using ONEPARAM_ROUTINE_CSRSS_GUICHECK
[WIN32K]
* Move the manual gui check for console windows entirely in win32k
* This shouldn't cause any regressions to the ancient gui-on-demand feature
svn path=/trunk/; revision=65538
* Partially rewrite CMergedFolder to fix the invalid assumption that the results of enumerating a folder are ordered.
Fixes the folder merging on certain languages not working as expected, and also some other weaknesses of the previous implementation.
CORE-8835 #resolve #comment Should be fixed in r65537. Thanks for reporting.
svn path=/trunk/; revision=65537
- On Win2k3, the EXIT_(ROS)_EX csr message has 3 parameters, instead of 2 (as on win2k), and the dwReserved is in fact unused.
[USERSRV]
- Add CSR shutdown callback UserClientShutdown (stub).
[CONSRV|USERSRV]
- The CSR shutdown callbacks are just stubs currently.
Part 5/X
CORE-8322
svn path=/trunk/; revision=65528
- Add a flag to enable (or disable depends on your reading ;-)) the VPB swapout process for volume umount.
- By default, disable it for MSVC builds.
This *might* lolfix the MSVC builds.
Just for the record, we also have a bug in the GCC builds but it doesn't seem to show up.
The main issue is that after formatting, we close handle to the volume, and IRP_MJ_CLEANUP is properly received and initiates a bit of dismount.
But then, the IRP_MJ_CLOSE is never received (why????) and thus, dismount cannot properly end.
This is a real & serious issue.
svn path=/trunk/; revision=65527
Fix a FIXME in fastfat:
- Implement support for device buffers flush in VfatFlushVolume().
Unlike Windows SDK, we don't divert the current IRP to pass it to storage device. Here, we allocate a new IRP and call the device so that it flushes buffers.
svn path=/trunk/; revision=65526
If you decrease handles count on cleanup, don't forget to increase it on create.
This fixes sharing violation on ReactOS installation with IopParseDevice hack disabled.
svn path=/trunk/; revision=65525
* Make use of the resource IDs for all paths that need localizing. It was working in the past but was broken by re-synchronizing the code with WINE, which has unlocalized hardcoded strings instead.
This fixes the shortcuts not appearing in other languages.
* Fix the folder for Administrative tools in spanish language
[USERENV]
* Fix spanish folder names to match our shell32 and Windows.
TRANSLATORS: If your language is broken, ensure that the paths in userenv and shell32 resources match!
CORE-8834 #resolve #comment Should be fixed in trunk r65524, thanks for reporting. If this problem still happens, speak with your language's translator or provide your own patch.
svn path=/trunk/; revision=65524
* Brought to you by Ismael Ferreras Morezuelas (swyter) with consistency formatting changes by me.
CORE-8848 #resolve #comment Committed the changes in r65523. Gracias!
svn path=/trunk/; revision=65523
- Move to an appropriate file, and correctly implement (i.e. via CSR call to USERSRV) EndTask.
[USERSRV]
- Hackplement SrvEndTask using our old code.
Part 4/X
CORE-8322
svn path=/trunk/; revision=65521
So...
... first of all NtUserQueryInformationThread takes only 4 parameters in Win2k3 so do it as well...
... and since we claim at being compatible with Win2k3 (and not XP), one **MUST** review **ALL** our win32k exports, in win32ss/w32ksvc.db database first, and then in our w32kdll apitests !!!!!
But I won't do it !
svn path=/trunk/; revision=65519
- Revert 65431, it seems to be breaking more than it fixes. Process Explorer will break again, working on a better way to fix this. See CORE-7447.
svn path=/trunk/; revision=65514
- Call GetThreadConsoleDesktop of CONSRV if needed, in GetThreadDesktop (in case the process is a console app).
- Introduce two last-error helpers UserSetLast(NT)Error which work the same as the (Base)SetLast(NT)Error of kernel32, needed for CSR status errors etc...
[WINSRV]
- Improve the stub of SrvGetThreadConsoleDesktop (it needs to success, and atm. it always zeroes-out the returned console desktop handle).
svn path=/trunk/; revision=65513
- Move definitions for DrawCaptionTemp to userundoc.h as it shouldn't be defined in the psdk
- Add browseui_undoc.h and move there the undocumented definitions for browseui
- Add comctl32_undoc.h and move there the undocumented definitions for comctl32
- Move undocumented definitions for shlwapi to shlwapi_undoc.h
- Add shellutils.h to contain helper macros and definitions that are nor per se undocumented.
- Cleanup internal definitions of explorer. Remove several temporary hacks. They were added at a time that these features were not implemented at all.
svn path=/trunk/; revision=65507
- Stub ElfRegisterEventSourceW, ElfReportEventW and ElfDeregisterEventSource. These are needed by windows sxs.dll, and sxs.dll is needed by windows basesrv.dll.
svn path=/trunk/; revision=65503
- Test whether a driver is hidden or not by checking its status instead of the old hack of hiding certain classes which we deemed should be hidden.
- Add support for hiding devices and problem overlays when showing by connection.
- We now show and hide identical devices when run alongside the Win8 MS device manager in both by type and by connection.
- Update the radio buttons when selecting the menu type.
- Add a manifest and use Win7 arrows on the TreeView.
svn path=/trunk/; revision=65502
* Set 32bpp as default bit depth instead of 16bpp. Suggestion and patch provided by Ismael Ferreras Morezuelas (swyter).
CORE-8826 #resolve #comment Committed in r65498. Gracias!
svn path=/trunk/; revision=65498
* This merge is also a chance to thank every single person involved directly and indirectly in this epic work, among them: Martin Fuchs for ReactOS explorer which we are respectfully retiring now, as it served the project so well over all these years. Thomas Bluemel (Thomas Weidenmueller aka w3seek) for his brave work on the shell, mainly his explorer_new. Andrew Hill for advancing the shell bringup with some impressive work. David Quintana, Giannis Adamopoulos and Huw Campbell for working as a solid team on making this branch a huge success, allowing the shell rewrite dream to finally become a reality. Again, thank you all!
* Merging this branch is not the end.. it's the beginning of some serious bug fixing based hopefully on the Community's continuous feedback.
* Finally, here are *some* of the highlights of this branch (simply put):
[BROWSEUI] Halfplement the address bar. Mostly implement the Favorites menu. Implement handling most hotkeys that should be handled by CShellBrowser. Fix various bugs.
[EXPLORER_NEW] Convert to C++ and use several wtl-like classes to simplify it. Fix several bugs and implement misc missing features.
[FILEBROWSER] A small exe file that opens a new file browser window in its own process. Tested to work in windows. It can be used to test our browseui.dll in windows.
[FONTS] A new marlett font.
[MSGINA] Add a proper shutdown dialog that's used when the user selects shutdown from the start menu (this is how it's done in Windows).
[RSHELL] A temporary module that hosts the implementation of the following classes needed for the shell: CMenuBand, CMenuDeskBar, CMenuSite, CMergedFolder, CStartMenu. These were implemented and tested in windows and for that reason they are still there. Should be moved in shell32 in the future.
[SHELL32] Reorganize files to isolate the ones that are not yet forked from wine. Fix various problems. Simplify the implementation of some shell folders. Implement filling in the file menu in the file browser.
[STOBJECT] A shell extension responsible for misc taskbar notification icons. So far only the sound icon is implemented. Adding this is necessary as the old explorer had the sound icon built in and deprecating it needs a proper solution for these notification icons.
[WIN32K] Fix several bugs that prevented the new start menu (that was implemented and tested in Windows) from functioning properly in ReactOS, mostly due to focus issues. Fix several shell notifications to behave more like in Windows.
* Tonight! We shall feast!
* And tomorrow the US guys shall feast again, on turkey! :p
CORE-7330
svn path=/trunk/; revision=65496
- On refresh, recurse the tree and delete all the Device Ids attached to each node
- Fix SAL and a few missing comments
svn path=/trunk/; revision=65495
- Add a class for managing the device view, and a class for managing the device objects.
- Implement listing devices by type and by connection.
- Add support for showing hidden devices
- Add support for showing unknown devices with overlay icons.
- implement showing the device properties via dounle click or hitting enter
- Add support for both Win7/8 as well as XP
- Make the code much more readable and maintainable. and easier to move to an mmc snapin if we ever get one.
I forgot this existed until today. I had some spare time so I decided to have a quick go at finishing it. Stick with the original one for now though, I ran out of time....
svn path=/trunk/; revision=65493
- Implement FLOATOBJ_bConvertToLong inline function that converts a FLOATOBJ to a long or returns FALSE if the value would overflow a LONG
- Remove underscore prefixes from inline FLOATOBJ functions and use it only on those that already exist as non-inline versions.
- Remove duplicated FLOATOBJ defines for non-x86
- Fail on integer overflow in XFORMOBJ_bXformFixPoints to avoid creating bogus coordinates.
svn path=/trunk/; revision=65490
Move down MEMORY_MARGIN to 0x9A00 to fix boot on BIOSes with even larger EBDAs (see also r64945 and r65127), still leaving 48KB for the DISKREADBUFFER
CORE-8830 #resolve
svn path=/trunk/; revision=65485
Add back definitions that go lost in the last commit.
winnt.h is autogenerated, please do not modify it directly, but instead modify the related file in XDK and regenerate the headers from XDK.
svn path=/trunk/; revision=65481
When I wrote "the compiler can optimize this better" I was obviously referring to a sane compiler like MSVC. Optimize (U)Int32x32To64 on x86 GCC builds by using __emul(u), since the native math results in horribly inefficient code doing 3 multiplications and some shifts.
svn path=/trunk/; revision=65480
* Rename the new explorer to take the now-vacant folder name, to match the output filename. Change 2/2
svn path=/branches/shell-experiments/; revision=65477
* Although the output filename was changed for almost as long as this branch has existed, I never bothered to actually rename the folders to reflect the output name. Change 1/2
svn path=/branches/shell-experiments/; revision=65476
Warn about unimplemented sub-node browsing while looking into a MFT directory stream.
Might likely explain why we cannnot enumerate all the files on a Win7 volume.
svn path=/trunk/; revision=65474
- Show programs command line in taskmgr.
Patch by Ismael Ferreras Morezuelas with minor modifications by me.
- int nMaxCount --> ULONG nMaxCount (that makes everything clearer and removes MSVC warnings).
CORE-5467 #resolve #comment Feature committed in revision 65469, cheers ;)
svn path=/trunk/; revision=65469
- Implement NtfsGetPositionInformation(), NtfsGetBasicInformation()
- Add a fixme in NtfsGetStandardInformation() regarding the number of links
svn path=/trunk/; revision=65468
Improve formatting memory size usage in the status bar of Task Manager.
Patch by Ismael Ferreras Morezuelas (swyter).
CORE-8810 #resolve #comment Committed in r65466, thanks d:^D
svn path=/trunk/; revision=65466
- In NtfsQueryDirectory(), don't upcase name in dir search pattern, it can conflict with POSIX names.
- In CompareFileName(), handle the fact that for Win32 & DOS we do case insensitive comparisons by upcasing name before match. Don't do it for POSIX names!
This fixes name completion in cmd for POSIX. And doesn't break it for Win32 :-).
svn path=/trunk/; revision=65462
- Implement GetBestFileNameFromRecord() which will select the higher subsystem name available (POSIX -> Win32 -> DOS) and return it
- Replace the hand-made implementation of it in dirctl functions relying on it (NtfsGetDirectoryInformation(), NtfsGetFullDirectoryInformation(), NtfsGetBothDirectoryInformation())
- Use it in NtfsMakeFCBFromDirEntry()
This fixes browsing POSIX volume (and opening file) in cmd. Even though, explorer doesn't seem to be happy with such change...
This doesn't fix yet the autocompletion in cmd either.
svn path=/trunk/; revision=65456
- Fix a misspelling.
[NTDLL]
- Fix the prototypes of RtlFormatMessageEx(Ex), this fixes strange apps kills when they use FormatMessage[A/W] with win2k3 kernel32 (that uses internally RtlFormatMessage to do the job).
svn path=/trunk/; revision=65450
- Remove the USE_CONSOLE_INIT_HANDLES define since now we "support" the console initialization events.
- The events in the CONSOLE_START_INFO structure are console initialization events used for asynchronous console creation, that are set whenever console creation succeeds, or fails.
- Stubplement their usage in CONSRV.
Now we are able to fully use Windows 2k3 kernel32.dll and be able to run console programs with it.
svn path=/trunk/; revision=65449
- INT 15h offers some "OS hooks" that do nothing normally but return success.
- Stub "Switch to protected mode" INT 15h AH=89h function.
svn path=/trunk/; revision=65448
- Fix interrupts in V86 mode.
- CLI and STI should call Fast486GetCurrentPrivLevel in their IOPL check, since it
always returns 3 if the VM flag is set.
svn path=/trunk/; revision=65447
- In XFORMOBJ_bApplyXform do not overwrite the data in the input buffer
- Make XFORMOBJ_bXformFixPoints return VOID instead of BOOL
svn path=/trunk/; revision=65445
- Synchronize mouse messages. Best way to do this, just post the move message while it occurs and just update it with recurrent information. The other way was to check time stamps and that was a hackish headache. Then the scorn and reticule would erupt. So it was easier to just post to the queue, update and if a mouse down up was captured than it would be in the order as it was received.
- See CORE-8779 #resolve, CORE-8394, CORE-7797, CORE-7447.
svn path=/trunk/; revision=65440
Add few VDD API prototypes:
- VDDReserve/ReleaseIrqLine to get a "lock" on an IRQ line (so that VDDs can check whether some IRQs are free or not).
- Add DMA services.
svn path=/trunk/; revision=65436
Code organization:
- Create directory hardware/video where to put all video emulation (VGA currently, and maybe other things in the future);
- Create directory hardware/sound where to put all sound emulation (PC speaker currently, and maybe other things in the future);
- timer.c/h --> pit.c/h;
- Adjust the necessary includes and the cmakefiles;
- Remove unneeded includes;
- NTVDM is allowed to have its own VS project ^^
svn path=/trunk/; revision=65430
- Remove unneeded commented code;
- Fix few things related to committing the reserved low-memory VDM page by kernel32;
- Decommit this memory when we terminate NTVDM.
svn path=/trunk/; revision=65426
- Do not recalculate at each refresh the new resolution that usually does not change (if it changes because of a modification of some VGA register, we detect that, and we change the vga mode). So keep the current resolution and use it in paint functions.
- Really reenter a new text/graphic mode when needed (ie. when alphanumeric bit and computed resolution change), this avoids useless console screenbuffers recreations (and flickering), things go faster, yet the VGA registers are still updated (as expected). See r65379, r65018 and r65015 for more details.
svn path=/trunk/; revision=65424
- Remove some old comments (and commented DPRINTs);
- More support for Bda->VGAOptions;
- Improve implementation of VidBiosSetCursorShape (start some cursor emulation, and add a note about it);
- Implement few "Alternate Function Select" subfunctions.
svn path=/trunk/; revision=65421
Remove some explicit comparisons with TRUE and make desired explicit comparison more obvious.
Patch by Love Nystrom, modified by me. Fixes a bug in RtlUpcaseUnicodeString. Not committed: modifications to freetype, since this is 3rd party code.
CORE-8799
svn path=/trunk/; revision=65419
* Commit the folder location fixes. They are mostly untested due to being unable to boot to desktop, but looking at the contents of the HDD after syssetup runs seems that the shortcuts are all created in their rightful place. If anyone is able to boot, feel free to test.
svn path=/branches/shell-experiments/; revision=65415
CORE-7710 #resolve #comment Committed again from the same CORE report. Note to my self, next time this thing is being reopened, I will set it to WONTFIX! Open a NEW REPORT!
svn path=/trunk/; revision=65412
CORE-7493 #resolve #comment Added, but the more recent versions + changed the SF mirror to the generic one + skipped the translating of a application's english name. Thx
svn path=/trunk/; revision=65411
Close your eyes.
Really do it! I see you kept them open...
There are closed now?
OK... All fine.
You can open them again.
Nothing happened.
Source code always used to be like that. A commented was never left by mistake in it.
Never, ok?
svn path=/trunk/; revision=65402
Reenable tests for MCBs. They got fixed by Hervé in r65398.
ROSTESTS-106 #resolve #comment Fixed by Hervé in r65398. Thanks!
svn path=/trunk/; revision=65401
* Fix some icons not appearing. The desktop one for "Command Prompt" still appears on the SYSTEM folder instead of the Default User one somehow.
svn path=/branches/shell-experiments/; revision=65393
Round to nearest integer in FIX2LONG, used in XFORMOBJ APIs. Fixes rounding errors when doing coordinate transformation.
svn path=/trunk/; revision=65392
Remove explicit comparisons with TRUE
i.e. if (BooleanValue == TRUE) -> if (BooleanValue) (and not !BooleanValue as accidentally written in the previous commit message!)
Patch by Love Nystrom
CORE-8799
svn path=/trunk/; revision=65391
* Remove the unwanted "(Empty)" item from the static menu, the SF menu will add its own if needed.
[RSHELL]
* Load the "(Empty)" string from shell32 resources.
[SHELL32]
* Add the string resource for empty menus.
svn path=/branches/shell-experiments/; revision=65389
Allow arbitrary transforms in NtGdiExtCreateRegion.
Shearing and rotation are not handled correctly yet, but at least we do no longer fail on transforms that have scaling and an offset, which are classified as GX_GENERAL
svn path=/trunk/; revision=65382
- Store in bit 7 of Bda->VGAOptions (40:87) whether we needed to clear video memory (or not) when changing the video mode.
- When retrieving the current video mode, set this bit 7 as required.
- Improve a bit the DPRINT of VidBiosSetVideoMode for diagnostic purposes.
- Remove the temporary "fix" (read: hack, and it broke some apps) from r65015 / r65018 : I'm working on a real fix.
- Rework some subfunctions of the INT 10h, AH=11h function (font generator).
- Fix reporting "256 kb video memory" in the Bda->VGAOptions flag.
svn path=/trunk/; revision=65379
- Disable some DPRINTs and reenable some others (those concerning programs loading).
- INT 15h, AH=C2h calls a dedicated mouse bios function, which is stubplemented.
- Move part of the HW mouse / driver hack from the HW mouse module into the BIOS mouse.
- INT 33h: s/BiosMouseService/DosMouseService/, in this interrupt we need to check for function numbers in AL (not in AX :) fixes few apps).
- Reenable mouse user handler callbacks calls in CallMouseUserHandlers.
- Some apps (e.g. the demo from http://www.brackeen.com/vga/mouse.html ) draw by themselves the cursor and do not bother to call the INT 33h "Show cursor" function, but expects that moving the mouse we report its correct position. Fix DosMouseUpdatePosition so that it always updates the stored mouse position, but redraws it only when the cursor is shown.
svn path=/trunk/; revision=65374
* Make use of the CToolbar class here too.
* Fix the menubar logic for closing menus on a second click. Almost. There's some glitch when clicking too fast, that I will fix later.
svn path=/branches/shell-experiments/; revision=65373
- Implement VPB swapout in our FAT driver for dismout (see VfatCheckForDismount)
- Dereference volume handles on close (not on cleanup)
- Keep track of the VDO in our VCB
- Let VfatCheckForDismount() do the actual dismount, instead of VfatDismountVolume() which just initiates it
CORE-8732 #comment Can you retry?
svn path=/trunk/; revision=65372
Add a dummy application that will open first disk and check first sector for MBR and then will open first partition to check for something known (& not MBR)
svn path=/trunk/; revision=65367
- Use wine debug output routines instead of blunt DbgPrint
This avoids the horrid "MSAFD: STATUS_XXX" which doesn't help.
svn path=/trunk/; revision=65355
So... Because actual ReactOS mood is to worship hacks instead of looking for proper fixes to have decent behavior: reenable the IopParseDevice hack.
But, so far, only reenable it for the 1st stage: the most intensive storage stack stage (unless you start playing with partitions & formating in 3rd stage).
CORE-8732 #resolve #comment Bug is now properly hidden with r65352
svn path=/trunk/; revision=65352
Do string case-insensitive comparisons when adding wallpaper file names to the list.
Patch by Ricardo Hanke.
CORE-8775 #resolve #comment Fixed in r65341, thanks!
svn path=/trunk/; revision=65341
Displays the current user name in the TaskMgr shutdown menu.
Patch by Ismael Ferreras Morezuelas (swyter) with minor modifications by me.
CORE-8536 #resolve #comment Committed in r65339, thanks!
svn path=/trunk/; revision=65339
- Remove an unneeded ExFreePool(DeviceInstance.Buffer); call in IopGetInterfaceDeviceList because at this point DeviceInstance is not yet initialized. Fixes MSVC build.
- No need to check for DeviceInstance.Buffer being NULL or not (in IopDeviceStatus), because in case it was NULL the IopCaptureUnicodeString call already failed.
- Add some brackets to conform to code style.
svn path=/trunk/; revision=65337
- Use the correct environment strings block when starting DOS programs.
- When building the DOS master env block, remove the current directory env strings (they start with '='), upcase the environment names (not their values) and remove the WINDIR environment that we inherited when we started NTVDM DOS.
svn path=/trunk/; revision=65335
- For the BIOS wait hack, use the NT API instead of the Win32 one.
- Remove unneeded DOS-exported functions.
- Use a PitGetReloadValue function for retrieving the reload value of a given PIT channel, instead of directly reading the reload value member, for functions *outside* of the PIT module.
- Implement basic Pulse-Width Modulation code for the PC speaker emulation.
svn path=/trunk/; revision=65333
USER command:
- Replace stings by resource strings.
- Add a function to print padded resource strings.
- Fix the password input routine. Repeat if the passwords don't match.
svn path=/trunk/; revision=65332
Int32x32To64 used with unsigned input values will cause unintentional sign extension. There is a lot of code in ROS that is still not fixed!!
Fixes BEEP sound. See also r64020, CORE-8502 and CORE-8505 for more details.
CORE-8505 #comment CsrCaptureTimeout and BEEP code fixed.
svn path=/trunk/; revision=65325
- adjust PLUGPLAY_CONTROL_INTERFACE_DEVICE_LIST_DATA
[UMPNPMGR]
- implement PNP_GetInterfaceDeviceList, PNP_GetInterfaceDeviceListSize
- currently not yet working PlugPlayControlGetInterfaceDeviceList class in NtPlugPlayControl is not implemented
svn path=/trunk/; revision=65322
- Fix the FPU_CHECK() macro.
- Make sure pages are marked dirty even if they have been accessed before.
- Always return after calling Fast486Exception.
svn path=/trunk/; revision=65312
* Work on the exports a bit to match native.
* There are still cases worth inspecting, marked as FIXME.
CORE-8174
svn path=/branches/shell-experiments/; revision=65307
* Another partial sync of pidl.c with Wine 1.7.27.
* Move some functions where they are used, and remove some unused ones.
* Mark some of our changes with history revisions.
CORE-8540
svn path=/branches/shell-experiments/; revision=65306
* Another partial sync of pidl.c with Wine 1.7.27.
* Move SHParseDisplayName where it belongs.
CORE-8540
svn path=/branches/shell-experiments/; revision=65305
- use get_best_icon_file_entry's magic to find the correct icon in ICO_ExtractIconExW - thanks Jérôme!
- add cursor files support for PrivateExtractIcon(Ex)
svn path=/trunk/; revision=65303
- add ICO files support for PrivateExtractIcons(Ex)
- fixes Juice and ICO files now show their icons in explorer
CORE-4021
svn path=/trunk/; revision=65297
* Another partial sync of clipboard.c with Wine 1.7.27.
* Move RenderPREFEREDDROPEFFECT to CIDLDataObj.cpp where it belongs.
CORE-8540
svn path=/branches/shell-experiments/; revision=65294
Fix the limit calculation when using page granularity.
RETF can also perform inter-privilege returns.
Fix the privilege checks when loading CS. DPL != CPL is only a #GP
when we're doing a jump or a call.
svn path=/trunk/; revision=65280
- Fix failure case handling in vfatUpdateFCB
- NULL output parameters on failure in vfatGetFCBForFile
- Fix a few typos
svn path=/trunk/; revision=65278
- Fix incorrect referencing in VfatCreateFile. vfatGetFCBForFile expects a reference on ParentFcb (and may release it), and also returns a referenced parent FCB.
CORE-8756 #resolve
svn path=/trunk/; revision=65276
* Begin implementing TB_GETMETRICS/TB_SETMETRICS. Will send to wine once the button spacing setting works (after writing tests and whatever else may be necessary).
svn path=/branches/shell-experiments/; revision=65275
* Make use of the CToolbar<T> class to implement a CTaskToolbar.
* Change the CTaskSwitchWnd class to use CTaskToolbar instead of managing the HWND directly.
* Silence logspam in CTrayBandSite.
* Fix CNotifyToolbar to properly.
* Move the call to SetMetrics to be called only on initialization, instead of every time an icon changes.
* Make the start button a CContainedWindowT instead of a raw HWND. TODO: Make a CStartButton class to manage it.
[include/reactos/rosctrls.h]
* Some improvements needed by the taskbar.
svn path=/branches/shell-experiments/; revision=65274
- VfatCleanupFile: do not dereference the FCB when closing the volume file object. ObDereferenceObject already causes an IRP_MJ_CLOSE request to be sent, which dereferences the FCB.
CORE-8733 #resolve
svn path=/trunk/; revision=65269
- Move the descriptor reading logic into a separate function.
- Implement hardware task switching and task gates.
- Flush the TLB when reloading CR3.
svn path=/trunk/; revision=65260
- Move out definitions for user/kernel test utility functions into their own header (still not pretty, but at least the one header won't get as huge
- Make KmtStartThread/KmtFinishThread available to all tests
svn path=/trunk/; revision=65256
[NTOSKRNL]
Implement SystemPrioritySeperation case in NtSetSystemInformation
........
[NTOSKRNL]
Fix an ASSERT in ExfReleasePushLockExclusive
........
[NTOSKRNL]
Fix KiCallbackReturnHandler
........
[NTOSKRNL]
Don't expect a fully sized LOADER_PARAMETER_EXTENSION, since the win2003 loader doesn't provide the full one.
........
[NTOSKRNL]
Implement a fake NtLockProductActivationKeys
........
[NTOSKRNL]
- Add some DPRINTs on errors
- Silence a DPRINT
- Only DPRINT on unimplemented affinity support on SMP builds
........
[NTOSKRNL]
- Remove an undocumented flag from the lpc request type in NtRequestWaitReplyPort. This is required for some windows modules that use this flag, otherwise the function fails.
........
svn path=/trunk/; revision=65255
Merge r62304 and r65253 from kernel-fun branch:
Fix logic in ObSetSecurityDescriptorInfo. To understand the change: it is not only style change! The old code modified SecurityDescriptor, which must always stay the same in the loop!
svn path=/trunk/; revision=65254
Various minor behavior corrections & simplifications for SeAssignSecurityEx:
- Fail on missing subject context or invalid group
- Initialize NewDescriptor to NULL on failure
- Never set SE_*_DEFAULTED flags
- Assume a primary token exists
- Remove unnecessary variable initialization
- Remove unnecessary length alignment
CORE-8745
svn path=/trunk/; revision=65244
- Simplify CMyDocsFolder folder to use a CFSFolder internally
- Note that while CAdminToolsFolder and CFontsFolder should aggregate CFSFolder, CMyDocsFolder shouldn't and this is implementation is much closer to windows.
svn path=/branches/shell-experiments/; revision=65243
- Move the ROUND_UP & ROUND_DOWN macro definition to header
- Make NtfsReadDisk() sector size aware so that it can properly align read on the disk (and thus prevent them from failing)
- If $ATTRIBUTE_LIST is non resident, then display a message and continue, don't assert on it. This is to be implemented later on.
This fixes directory enumeration on a Windows 7 NTFS volume.
svn path=/trunk/; revision=65240
Try to read the names from the biggest name space to the smallest.
Only at the end assert we have to have a name.
This fixes name enumeration on Windows 7 NTFS volumes.
svn path=/trunk/; revision=65239
- Fix the BIOS32 Wait hack (Sleep takes a duration in milliseconds, whereas the BIOS function takes the duration in microseconds).
- Initialize the PIT channels with realistic values (realistic == found on real BIOSes).
- Remove unneeded commented code.
svn path=/trunk/; revision=65237
- Begin improving our shell folders implementation
- CAdminToolsFolder is just a fancy CFSFolder so there is no need to reinvent the wheel
- Use a real CFSFolder to do all the work. When ATL aggregation works, we will be able to make this prettier
- Keep a small hack in CAdminToolsFolder::GetDisplayNameOf which returns the folder's name (I need to investigate if this is correct or not)
svn path=/branches/shell-experiments/; revision=65228
* Apply Wine commit e330a128 by Alexandre Julliard: Use Shell_GetImageLists to retrieve image lists instead of using a global variable.
CORE-8540
svn path=/branches/shell-experiments/; revision=65222
- Start implementing GetAdaptersAddresses.
For now it noly gives interface names and DNS servers IP, but that's already more than 'UNIMPLEMENTED'.
svn path=/trunk/; revision=65220
- Use the structure defined in the public headers instead of some strange internal thing.
Uppercase is not so fashionable after all.
svn path=/trunk/; revision=65218
* Move shell32_main.cpp to the wine folder.
* Rename shell32_main.cpp to shell32_main.c.
* Partially sync shell32_main.c with Wine 1.7.27.
* Update the location of shell32_main.h in inclusions.
CORE-8540
svn path=/branches/shell-experiments/; revision=65217
* Mark _ILGetExtension and _ILGetFileType as EXTERN_C.
* __inline before return type.
* Some tiny style consistency fixes.
svn path=/branches/shell-experiments/; revision=65216
* Allow shdebugstr_guid() to be used from C code too.
* Move shellole.cpp to the wine folder.
* Rename shellole.cpp to shellole.c.
* Sync shellole.c with Wine 1.7.27.
CORE-8540
svn path=/branches/shell-experiments/; revision=65213
- Add shell32.cpp and move there CShell32Module, DllGetVersion, DllMain, DllCanUnloadNow, DllGetClassObject, DllRegisterServer, DllUnregisterServer, DllInstall, IDefClFImpl, IDefClF_fnConstructor and SHCreateDefClassObject
- Now shell32_main.cpp and shellole.cpp have code that can be converted back to C and synced to wine
svn path=/branches/shell-experiments/; revision=65212
* Rename a few I<x>Impl to C<x>
* Refactor the toolbar code of notification area into its own class.
* Also refactor away the code specific to the toolbar control into a CToolbar class. Todo: move the CToolbar class into some header file.
svn path=/branches/shell-experiments/; revision=65209
- Remove an old todo file that described the things that were implemented in the shell-experiments branch
svn path=/branches/shell-experiments/; revision=65208
Add a hack to forcibly set sector size in case of weird input. This is noisy on purpose.
Also, be more informative in case of read rejection. Are we reading beyond partition or do we have invalid sector size?
With the hack, the invalid sector size should disappear.
This is to help debugging the recent errors with the removal of IopParseDevice() hack
svn path=/trunk/; revision=65205
* Refactor startmnu.cpp into three separate files. startctxmnu.cpp contains the context menu handler for the start button, and startmnusite.cpp contains the former IStartMenuSiteImpl, renamed to CStartMenuSite.
svn path=/branches/shell-experiments/; revision=65200
Quickly implement NtfsReadFile().
By quickly, I mean that it works but is under optimal in many ways, and also doesn't support any caching. So, don't expect breaking performances.
BUUUUUUT... This implements reading a file on a NTFS volume on ReactOS! And it works!
Here is a picture of all the achievements of ReactOS with NTFS lately: http://www.heisspiter.net/~Pierre/rostests/NTFS_all.png
-> Volume information
-> Displaying files in explorer
-> Moving across directories
-> Reading a file (with more here)
That's all folks! (for now ;-))
svn path=/trunk/; revision=65192
Net user command:
- Fix typos in the /ACTIVE option.
- Implement the /COUNTRYCODE, /PASSWORDCHG and /PASSWORDREQ options.
svn path=/trunk/; revision=65179
- Add an evil header that is going to simplify our C++ code in the shell a lot
- Use the new CListView in the implementation of CDefView to make it more readable and maintainable
svn path=/branches/shell-experiments/; revision=65176
Whatever happened during format, always unmount the volume.
This allows switching FS in usetup after formating an ext2 volume.
As a record, before (read, with the IopParseDevice) hack, this wasn't possible and if formating with ext2 was possible, kernel would have written with either RawFS or FastFAT driver. Which is not exactly what we want ;-).
But no joy guys... The Ext2Fsd needs to work in ReactOS first before we can effectively install ReactOS on ext2 volumes.
In any case, that's a clear step forward :-)
svn path=/trunk/; revision=65174
Implement some kind of volume dismount in FastFAT (ie, implement VfatDismountVolume())
This is not fully perfect situation, but it does most of the job (+ leaking a few things). So far, this is not dramatic as its main use is for 1st stage. This will have to be improved later on.
CORE-8732 #comment Can you retest please?
svn path=/trunk/; revision=65173
- Correctly set the VdmPower flag when the process being started is a NT VDM
- Return a correct status code if VDM access is forbidden.
svn path=/trunk/; revision=65170
- Mark almost all of the exported console APIs hotpatchable (normally on windows 2k3, all the exports of kernel32 are hotpatchable...)
- Version check mismatch is not a ReactOS error by itself so adjust the DPRINT a bit.
svn path=/trunk/; revision=65169
Simplify buffer size management in GetNtfsFileRecord(). As tests shown, Windows doesn't care about the real size of the file record and expects the caller to pass the complete size of the record and returns it fully.
CORE-8725
svn path=/trunk/; revision=65166
Add a simple application (à la NTFSInfo & nfi) to dump the data about a NTFS volume using the FSCTL control codes.
This is for both demonstrating how it works and to assess our driver behavior against Windows behavior of these FSCTL.
CORE-8725
svn path=/trunk/; revision=65165
- A HACK notice was more obvious than needed (I got what I asked after all).
- Reenable opening the printers folder since it works now
svn path=/branches/shell-experiments/; revision=65161
- Do not release the pointer to the ShellView that was just created
- Fixes a crash when showing the Printers shell folder
svn path=/branches/shell-experiments/; revision=65160
- rewrite the GEO_FRIENDLYNAME case of GetGeoInfoW which was completely wrong, intl.cpl now shows a valid list of locations
- note: The geo location resource strings have an arbitrary offset so that they don't collide with the nls resources (which shouldn't be there). Once these are moved out of kernel32 into locale.nls this offset alongside with the hack already present in GetLocalisedText can be removed.
svn path=/trunk/; revision=65157
- pszEnvironment is a multi-sz string so make sure to double-null terminate it. Fixes a buffer overrun in winlogon; powered by DPH.
svn path=/trunk/; revision=65153
- fall back to english if a localized resource is not found in GetLocalisedText
- this prevents debug spam and loss of functionality (see CORE-8720) for languages that don't have kernel32 translated
svn path=/trunk/; revision=65152
* Move TRASH_CanTrashFile and TRASH_TrashFile declarations to recyclebin.h.
* Do not include xdg.h in shlfileop.cpp anymore.
* Remove the now unneeded xdg.h.
svn path=/trunk/; revision=65146
- Move FSCTL_GET_NTFS_VOLUME_DATA implementation in its own function GetNfsVolumeData(), so remove it from NtfsUserFsRequest()
- Add support for FSCTL_GET_NTFS_FILE_RECORD in NtfsUserFsRequest()
- Implement GetNtfsFileRecord() which returns a file record. Not fully sure about its implementation, this is to be checked.
This does not really improve the nfi situation in any kind yet...
CORE-8725
svn path=/trunk/; revision=65145
Testman confirms that IopParseDevice() hack is no longer required.
So, this is the end of this 8y old hack.
Now ReactOS is able to properly use its storage stack (who said, amazing?)
Bisous IopParseDevice() hack :-)
svn path=/trunk/; revision=65144
Revert r65120...
Which was reverting r65119...
Which was reverting r65117...
Which was reverting r65110...
Which was reverting r65107...
Which was reverting r65104!
To make it short? Fuck you IopParseDevice() hack!
And this time, I hope this is the right one!
I couldn't reproduce any of the previous issues in my WC.
svn path=/trunk/; revision=65142
Some fixes and missing implementations in RawFS:
- Remove some magic values for VCB state
- Add a local VPB in our VCB. This will allow diverting the IO VPB with ours in case of dismount (and thus, will fix dismount)
- Implement support for said VPB in both RawCheckForDismount() and RawInitializeVcb()
- Now, dismount is handled in RawCheckForDismount() directly, and not in functions calling it
- Handle streams in RawClose
- Handle VCB being dismounted in RawCreate()
- Handle dismount also in RawCleanup() (not only in RawClose())
This fixes volume locking and dismounting in RawFS. And thus, allows FS swap in case of raw volume formating in first stage :-).
More to follow!
svn path=/trunk/; revision=65141
- Fix renaming files in case the target file already exists.
- Plug a few reference count leaks on FCBs.
CORE-8660 #comment fixed in r65140 #resolve
CORE-8633 #comment fixed in r65140 #resolve
CORE-4758 #comment fixed in r65140 #resolve
svn path=/trunk/; revision=65140
On the road for getting rid of IopParseDevice() hack....
- Add support for FSCTL_LOCK_VOLUME, FSCTL_UNLOCK_VOLUME, FSCTL_DISMOUNT_VOLUME in VfatFileSystemControl()
- Implement VfatLockOrUnlockVolume(). This brings some kind of volume locking to FastFAT FSD. It's likely not fully accurate and welcome to race conditions. But, its main purpose is to be used in usetup. So, this is fine for now.
- Stubplement VfatDismountVolume(). This will be implemented later on, but should be relatively straightforward as it requires volume to be locked (so, we're the last ones on it :-)).
svn path=/trunk/; revision=65129
* Cleanup some window procs.
* Fix some redraw issues in the notification area due to misuse of themeing.
svn path=/branches/shell-experiments/; revision=65124
Actually enable again the hack...
For whatever reason, it works with my WC but not with clean trunk...
Where are the you, magic and silent patch that fixes it? :-(
svn path=/trunk/; revision=65120
Finally, disable again the IopParseDevice hack.
Just for the record, opening a volume with FILE_READ_EA or FILE_READ_DATA is legal and works in Windows (NTFS Info for instance opens it with GENERIC_READ).
Let's hope we can rid of this hack forever now... It's been with us since 2006!
svn path=/trunk/; revision=65119
Don't over-reference our FCB in case of volume opening (vfatAttachFCBToFileObject() already references it).
This fixes 1st stage and beyond with IopParseDevice hack off
svn path=/trunk/; revision=65118
Now that we start to honor the storage stack (ie, without the IopParseDevice hack ;-)), we have to let FSDs forward device IOCTLs.
This allows back copying files on 1st stage
svn path=/trunk/; revision=65116
Don't attempt to mount any partition just because we have a valid partition table...
Restrict this to them being marked as FAT or compatible.
svn path=/trunk/; revision=65115
* Hopefully fix the start menu closing randomly. May have side-effects, but I think it's best to be conservative here and prefer the possibility of the menu staying open unexpectedly, rather than closing unexpectedly.
svn path=/branches/shell-experiments/; revision=65114
Implement support for the FSCTL_GET_NTFS_VOLUME_DATA user request in NtfsUserFsRequest().
This makes NTFSInfo capable of working in ReactOS :-). A picture to show it: http://www.heisspiter.net/~Pierre/rostests/NTFS_info.png
Yes, NTFS Zone isn't computed yet. I'll have a look at it later on.
This doesn't fix nfi.exe though. If it can get its data, it cannot continue. It loops forever on a FSCTL we don't handle yet.
CORE-8725
svn path=/trunk/; revision=65112
* Allow the static items in the Favorites menu to be received by the shell browse window.
* Handle the Organize Favorites menu item by opening either the USER favorites, or the COMMON version of the folder.
[RSHELL]
* Send the proper HWND together with the HMENU, when sending callbacks.
svn path=/branches/shell-experiments/; revision=65111
Finally, move old stuff back from disk.sys to ntfs.sys now it can be properly reached on volume opening:
- Halfplement NtfsUserFsRequest() and add support for IRP_MN_USER_FS_REQUEST in NtfsFsdFileSystemControl()
- Also, use the proper FSCTL code: FSCTL_GET_NTFS_VOLUME_DATA which exists and is documented instead of FSCTL_GET_NTFS_VOLUME_DATA. Spotted by Christoph.
CORE-8725
svn path=/trunk/; revision=65106
Revert r65097 and r65090.
Thanks to r65104, now the FSCTLs go to the right place: the FSDs!
Thanks to Thomas for pointing out that NTFSinfo was really talking with the FSD on Windows and not to disk.sys
CORE-8725
svn path=/trunk/; revision=65105
Disable the IopParseDevice hack. It appears it was triggered on volume opening and thus was breaking volume opening which were then forwarded down to disk.sys.
Not sure how legit it is to have it anylonger.
At least, disabling it reenables volume opening in ReactOS and associated FSCTL!
Alex & Aleksey, can you review please?
CORE-8725
svn path=/trunk/; revision=65104
- add metrics to classic themes (the flag 0xb0001 will result in a kinda esoteric value of type REG_QWORD)
- fixes switching from Lautus back to a classic theme
CORE-8718
svn path=/trunk/; revision=65100
* Fix a 'pasta.
* Open something less stupid when clicking on "Is this copy legal?" in the Help menu.
svn path=/branches/shell-experiments/; revision=65099
* Fix assumption that the USER folder will always exist and only the COMMON folder may be missing. Allows the Start Menu to work in livecd.
[BROWSEUI]
* Apply the same fix to the Favorites folder, although the LiveCD does not currently have the folder so it will not work regardless.
svn path=/branches/shell-experiments/; revision=65098
Actually, sysinternals used to release the source code of NTFSInfo (thanks Christoph!), so we know a bit more about the interface of the user FS request.
So, implement a bit more of the interface to validate it properly works (and so far, it does!)
CORE-8725
svn path=/trunk/; revision=65097
Get ready to enter into the 10th dimension... So:
- Implement support for IRP_MJ_FILE_SYSTEM_CONTROL. Yes... You read well! So, implemented a ScsiDiskFileSystemControl() function. The way it is added to the DriverObject is a big hack, class2 is not supposed to have such requests, so, we do it in its back. Fear!
- Stubplement the NtfsRussinovichism() function. This is the only function we're supposed to call with IRP MJ FSCTRL and with IRP MN USRFSRQST. Its purpose (when its implemented) is to reply back to the M. Russinovich tools (NFI & NTFSInfo) so that they can directly dump NTFS information without going into NTFS driver. They kind of bypass it.
We do all agree this is a ugly hack. But it exists in Windows, as these tools work in Windows. And it would be useful they actually work in ReactOS.
Soon, we'll be able to publish a book "ReactOS Internals" where we speak about undocumented FS controls to dump NTFS information to show how well our NTFS works ;-).
svn path=/trunk/; revision=65090
* CMenuBand: Refcount before assigning a return pointer.
* CMenuDeskBar: Revert change and protect the refcounting in case I was wrong to assume there will be exactly one OnFinalMessage for each OnCreate.
* CMenuToolbars: Add a debug message.
* CStartMenu: Refcount correctly.
svn path=/branches/shell-experiments/; revision=65088
- addendum to revision 64877 which slightly changed UserDrawCaption's logic
- fixes window title being drawn over the icon
svn path=/trunk/; revision=65087
- Move functions to the appropriate source files, zap hacks.c, stubs.c, stubsa.c and stubsw.c (sorry for the noise, but this mess had to be cleaned up)
svn path=/trunk/; revision=65086
For now, disable the VfatSetRenameInformation() asserts in trunk.
They can be reenabled for testing by commenting "#define NASSERTS_RENAME" out.
CORE-8721 #resolve #comment Fixed with r65085
svn path=/trunk/; revision=65085
Finally, implement NtfsGetFreeClusters() which will just read the $Data stream from $BITMAP file record to get the amount of free clusters to allow estimating the free space on a volume.
The implementation is likely under-optimized... But wwell, the rest of the FSD is not better. Who talked about caching?! ;-)
Because pictures are more relevant than words in such case: http://www.heisspiter.net/~Pierre/rostests/NTFS_disksize.png
svn path=/trunk/; revision=65082
* Properly return the toolbar status on QueryStatus.
* Properly make use of the returned into from QueryStatus.
svn path=/branches/shell-experiments/; revision=65080
[user32]
- Properly notify the theme engine that the caption needs to be repainted on WM_SETICON
- Fixes a classic frame appearing when themes are enabled and we navigate to a different folder
svn path=/trunk/; revision=65077
- Stop the log from being spammed when the session is idle and no screensaver is set
- Also checking if my login still works :)
svn path=/trunk/; revision=65076
- Disable querying if audio is muted or not for now.
- Hides an assert that happened in wdmaud.drv
svn path=/branches/shell-experiments/; revision=65073
- Return a readable folder name when SHGDN_FORADDRESSBAR was specified
- We no longer show GUIDs in the address bar
svn path=/branches/shell-experiments/; revision=65072
- Actually give focus to the start menu when CMenuDeskBar::Popup is called
- Fixes opening and navigating the start menu with the keyboard
svn path=/branches/shell-experiments/; revision=65071
- Use IMenuPopup_OnSelect to close the start menu when the win key is pressed.
- Fixes closing the start menu (on windows and on reactos)
svn path=/branches/shell-experiments/; revision=65070
- Send the HSHELL_TASKMAN notification to the shell when the windows key is pressed
- Needed to open and close the start menu with the keyboard
svn path=/branches/shell-experiments/; revision=65069
* Fix some small things that were getting in the way of fixing the start menu (which was broken and no one noticed). The actual fix will come tomorrow since my brain is about to implode at this time.
svn path=/branches/shell-experiments/; revision=65065
- Use GdiGetDcAttr instead of GdiGetHandleUserData where appropriate
- Add a few missing SetLastError()
- Fix return failure return value of GetBkColor()
- Improve order of operations in SelectObject (needs more fixing)
svn path=/trunk/; revision=65063
Get rid of Fast486Interrupt, since it's not used anywhere. Also we can now remove
workarounds for all of the bugs that it caused.
Implement the "single-instruction interrupt delay" for instructions that load the
stack segment only.
svn path=/trunk/; revision=65061
- Revert a recent change in trunk that broke the new shell. Its a shame to see the new shell behave like crap because of win32k
svn path=/branches/shell-experiments/; revision=65057
Add Support routines for client objects. Will be used later. You might wonder why the code uses a lame hash table to link the client object handles to the user mode pointer, when it should be clear that a *client* object should have a user mode attribute, like other objects, that we can use, especially since that is the only real purpose of that object. Well, tell that the MS developer, who implemented client objects without a user mode attribute...
svn path=/trunk/; revision=65053
- Fail in NtGdiCreateClientObj, when the object type is not valid.
This is based on Windows behavior, only more strict. Windows allows to set the stock bit and reuse count, which is probably not what we want.
svn path=/trunk/; revision=65052
- Rewrite the monstrosity that was supposed to open control panel items. Still not really correct but works.
svn path=/branches/shell-experiments/; revision=65051
Bugfixing... Part 10/X:
- Properly compute entry name length in CompareFileName()
- Also, in CompareFileName() properly handle the return of RtlCompareUnicodeString(); this is not RtlEqualUnicodeString()!
- In NtfsLookupFileAt(), don't return an error when we're done walking the path, it's a normal behavior
All these fixes allow our NTFS to go one step farther: it can open directory/files (reading files data remains untested so far) in root and in its subdirs. Which was broken previously.
The said bugfixes in action (and in image): http://www.heisspiter.net/~Pierre/rostests/NTFS_listing_subdir.png
svn path=/trunk/; revision=65041
- Fix CAddressBand::Invoke to correctly detect if an item exists in the list and select the correct item when it does.
- Improve CAddressEditBox::Execute to check if the passed pidl is the one that is being displayed.
- Also fix it to parse the path if needed.
- Directly call CAddressEditBox::Execute when enter is pressed or the Go button is pressed
- Should fix most issues with the address bar
svn path=/branches/shell-experiments/; revision=65036
Implement vfatGrabFCB() (which was defined but never implemented) for increasing the reference count on a FCB.
This will make debugging easier.
Dedicated to Thomas :-).
svn path=/trunk/; revision=65031
Remove the old access check code in SepAccessCheckEx and use the new code instead. The new access check code is a lot better than the old code, but it makes the boot and install fail. This is caused by some kernel objects which are accessed using insufficient access rights. Therefore I added a little hack that shows a warning when insufficient rights are granted for an object and access is granted anyway.
svn path=/trunk/; revision=65023
- Improve CBaseBar::TranslateAcceleratorIO stub
- Returning always TRUE means that creating a basebar ended up eating all messages
- Fixes the hang that happened when we clicked on the folders button in the toolbar
svn path=/branches/shell-experiments/; revision=65020
Make FATGetNextDirEntry() and vfatFindDirSpace() complain when they are given a cleaned up FCB (which shouldn't happen!).
They'll display full path, references count, open handles count.
Where are you little reference leak?
svn path=/trunk/; revision=65014
* Import ADVAPI_GetComputerSid from Wine 1.7.27.
* Apply Wine commit f7a6c4c3 by Detlef Riekenberg: Allow string alias for common RID in sid strings.
CORE-8540
svn path=/trunk/; revision=65010
* Apply Wine commit e57edfea by Paul Vriens: Skip leading spaces when parsing.
* Update the related functions with Wine 1.7.27.
CORE-8540
svn path=/trunk/; revision=65007
- Properly notify the theme engine that the caption needs to be repainted on WM_SETICON
- Fixes a classic frame appearing when themes are enabled and we navigate to a different folder
svn path=/branches/shell-experiments/; revision=65001
- Use a palette created from the DIB infos for surface created through CreateDIBitmap(CBM_CREATEDIB)
CORE-8695 #comment Booting in 16bpp mode is now OK, but some problems remain when switching mode from 16bpp to 32bpp
svn path=/trunk/; revision=64993
- Fix a stupid buffer overflow I introduced in r64967.
- Take BITMAPCOREINFO into account when loading a cursor from file.
svn path=/trunk/; revision=64990
* Fix HMENU leak.
[BROWSEUI]
* Work around for WM_SETICON not properly returning the old HICON.
[SHELL32]
* Fix HICON leak.
* Nitpick.
[WIN32K]
* Do not refcount the menus improperly.
svn path=/branches/shell-experiments/; revision=64986
Updates for some softwares.
Fix several broken mirrors and replace the in theory working one for IrfanView.
Fix some sizes.
svn path=/trunk/; revision=64975
Improve configure script to allow passing multiple arguments, like "configure VSSolution RTC". Add a small help command ("help" or "/?"), allow passing CMake parameters like -DFOO:BOOL=TRUE after our custom parameters.
svn path=/trunk/; revision=64971
- Properly check for CBM_INIT bit in CreateDIBitmap.
- Take into account the fact that we could be passed a BITMAPCOREHEADER
CORE-8695
svn path=/trunk/; revision=64969
- Use CreateDIBitmap with the CDM_CREATEDIB undocumented flag to create alpha bitmaps. This permits to create display compatible yet 32bpp DDBs.
CORE-8695 #comment PLease retest, should be OK now.
svn path=/trunk/; revision=64967
- Move call to UserRegisterClass out of SEH. All parameters are kernel pointers, so exceptions here are critical kernel bugs that shouldn't be hidden.
CORE-8702 #resolve
svn path=/trunk/; revision=64964
- Keep track of the PDEV which we create a compatible bitmap for.
- Allow attaching a DDB to a DC if they are from the same PDEV
Fixes various problems after mode switching, including the infamous "Where is desk.cpl palette bitmap"
svn path=/trunk/; revision=64955
- Don't delete the device node for root enumerated device objects on failure. It's pointless, since IopEnumerateDevice will just recreate it, and more importantly it causes a use-after-free because IopFreeDeviceNode does not unset the DeviceNode member of the device object extension, so IopEnumerateDevice will try to access the freed node
- Set the device object's DeviceNode pointer to NULL in IopFreeDeviceNode
- Use consistent pool tagging for device nodes
CORE-8671 #resolve
svn path=/trunk/; revision=64950
Move the BIOS call buffer to physical address 0x4000, making another page available at the top, moving the margin down to 0x9E000. Should fix boot with machines that have a large EBDA.
CORE-8692 #comment please retest.
svn path=/trunk/; revision=64945
* Fix icon leak of the returned old icon from WM_SETICON.
[RSHELL]
* Add two debug prints (not hit).
[FILEBROWSER]
[EXPLORER-NEW]
* Free PWSTR pointers after exiting.
svn path=/branches/shell-experiments/; revision=64940
- Properly free classes small icon handles
- Do not use LR_SHARED when copying them from the large icon. There's no reason for them to outlive the class.
Should fix remaining failures in user32:class that I introduced.
svn path=/trunk/; revision=64939
- Simplify an overcomplicated way to get buffer size from win32k
- Do not spaghettize between string length and buffer size.
- Properly use GetModuleFileName.
svn path=/trunk/; revision=64938
* Introduce a wine folder to group the Wine synced source files.
* Use the crypt folder as a starting point. More will follow.
CORE-8540
svn path=/trunk/; revision=64937
* CMenuBand: Increase the refcount of m_smc before returning it.
* CMenuBand: Improve the closing logic so that the object is reusable when it needs to be, and can still be released properly.
* CMenuDeskBar: Protect self against unexpected termination.
* CMenuFocusManager: Refcount objects that are being used.
* CStartMenu: Properly release the created objects after it's done using them (by using CComPtr instead of raw pointers).
[BROWSEUI]
* AddressBand: Release the addressband site when closing the band.
* InternetToolbar: Do not filter away ALL the items of the favorites folder.
* InternetToolbar: Do not AddRef a CComPtr that already did the refcounting itself.
CORE-8690
svn path=/branches/shell-experiments/; revision=64929
* Merge r64866 from the shell branch which had:
* Fix wrong array length passed to GetClassNameW. CID 716222
* Replace other instances of explicit array length to GetWindowTextW with _countof(x).
Based on a patch by Christoph von Wittich.
svn path=/trunk/; revision=64924
- In an incredibly daring move, enable the long awaited new cursors & icons implementation, featuring:
- Alpha channeled cursors
- Animated cursors (only the first frame is displayed now)
- Less leaks (tm)
- Tests that pass(tm)
- Copying icons and cursors from DLL resources, for beautifuler ReactOS, your turn gigaherz ;-)
- A lot of other things which I am very proud of.
CORE-7575 #resolve
svn path=/trunk/; revision=64921
- Remove the cursor from the process cache when its handle is deleted, not after.
- Do not return an invalid handle in NtUserSetCursor.
CORE-7575
svn path=/trunk/; revision=64912
- Fix LookupIconIdFromDirectoryEx, returning 0 when no matching entry is found.
- Fix error handling when opening a cursor file.
- Various code beautification here and there
CORE-7575
svn path=/trunk/; revision=64911
Fix ARM build, patch by Yuntian Zhang with minor adjustment by me.
CORE-8666 #resolve #comment Committed in r64910, thanks!
svn path=/trunk/; revision=64910
Do not raise an exception in _invalid_parameter, which is only done in later MSVCRTs. Wine uses a symbolic constant (_MSVCR_VER) to handle this and other things and compiles their CRT code multiple times. As an alternative we could use a global version variable to avoid recompiling, once we implement other CRT dlls.
CORE-8670 #resolve
svn path=/trunk/; revision=64909
- check the right buffer's length
[WIN32K]
- simplify IntKeyboardUpdateLeds a bit and mind previous mode
- fixes keyboard indicators
CORE-8547
svn path=/trunk/; revision=64908
Make special pool usable:
- Invalidate PTEs on free to catch use-after-free situations (and not confuse Mm)
- Fix pattern check not to look for more than 8 bits in a byte
- Enable POOL_FLAG_SPECIAL_POOL if special pool has been initialized
- Implement MmExpandSpecialPool
- Issue the correct SPECIAL_POOL_DETECTED_MEMORY_CORRUPTION bugcheck when problems are detected
- Magic values--
To enable special pool for a single tag, set a value for MmSpecialPoolTag in ntoskrnl/mm/ARM3/pool.c.
To enable it for more than one tag, set MmSpecialPoolTag and modify MmUseSpecialPool in ntoskrnl/mm/ARM3/special.c (e.g. to return TRUE independent of Tag).
CORE-8680 #resolve
svn path=/trunk/; revision=64886
- Generate PAGE_FAULT_IN_NONPAGED_AREA bugcheck for PTEs that have their protection set to zero. This gives a more useful error description than the infamous 'TempPte.u.Long != 0' assertion*.
CORE-8679 #resolve
* and is also What Windows Does(TM)
svn path=/trunk/; revision=64885
- Fix a few usages of UserSetCursor
- Defer the actual freeing of cursor resources to when the object is freed for real.
CORE-7575
svn path=/trunk/; revision=64879
- "Convert" new cursor & icons implementation to the new user object handle manager.
- Fix a few idiosyncracies in the way cursor handles are used (only with USE_NEW_CURSORICON_ENABLED)
[WIN32SS]
- Storm out the flowers out of how classes use icon and cursor objects, with proper refcounting and all those joyous things.
Handles are for the powerless, kernel mode use pointers.
Only with USE_NEW_CURSORICON enabled (soon!)
CORE-7575
svn path=/trunk/; revision=64877
* Fix wrong array length passed to GetClassNameW. CID 716222
* Replace other instances of explicit array length to GetWindowTextW with _countof(x).
Based on a patch by Christoph von Wittich.
svn path=/branches/shell-experiments/; revision=64866
* Cleanup in case of error. CID 1248426
[RSHELL]
* Add uninitialized class fields. CID 1248477
* Avoid leaking memory. CID 1248438
[BROWSEUI]
* Fix potential overwriting of a variable. CID 716363
* Save the rshell handle instead of loading it every time. CID 1248435
* Fix leaked PIDL. CID 1248418
[SHELL32]
* Fix GCC build. And one small nickpick that has been bothering me for a long time.
svn path=/branches/shell-experiments/; revision=64864
- reference the current process info structure while we're leaving win32k.
The process can die anytime while we're not looking.
CORE-8663 #resolve
svn path=/trunk/; revision=64863
- Remove code that breaks wine release 1.7.29 user32 input tests. Code was there since r2505.
- So due to this commit, over compensating hacks can break.
svn path=/trunk/; revision=64860
* SHOnCWMCommandLine: Fix IETHREADPARAM leak.
[SHELL32]
* Fix HMENU leak of the popup used in the view mode button of the toolbar.
[RSHELL]
* Undo a previous change to help debug the leaks.
* Remove child submenus when closing a menu band.
* Add some extra verification for debugging purposes.
[BROWSEUI]
[RSHELL]
[SHELL32]
* Move ReleaseCComPtrExpectZero to the shared header.
svn path=/branches/shell-experiments/; revision=64858
[SHELL32]
[BROWSEUI]
* Move undocshell.h to a shared location, and move some shared utility functions into it.
* Replace all the COM object constructor functions with generic equivalents.
* Fixes a big bunch of "problems" found by Coverity Scan, but I don't have the list of CID at the moment.
svn path=/branches/shell-experiments/; revision=64854
- Control register 0 is CR0: use FAST486_REG_CR0 instead of 0, as it is done in the rest of the code.
- Improve a if/else if control.
- Don't halt the processor in the middle of prefixes processing.
svn path=/trunk/; revision=64851
* Use the x86 toolchain for host tools if the targeting platform is ARM. Brought to you by Yuntian Zhang.
CORE-7407 #resolve #comment Committed in r64849. Thanks!
svn path=/trunk/; revision=64849
- add a missing break and reshuffle the code a tiny bit to fix CIDs 514466 and 513487
- don't skip the terminating debug print for ft_glyph_format_bitmap
svn path=/trunk/; revision=64847
- Move FCB list removal to vfatDelFCBFromTable, since vfatAddFCBToTable does the insert. Fixes list corruption in vfatUpdateFCB.
svn path=/trunk/; revision=64843
- Correctly interpret SeCreateClientSecurity return value in NpInitializeSecurity
- Always charge quota when allocating client context
- Specify explicit 0 tag when freeing allocations with unknown pool tag
- Misc readability fixes
svn path=/trunk/; revision=64839
- Do not pass IO_STATUS_BLOCKs when creating IRPs for asynchronous use. Fixes a use-after-free where AfdCloseSocket would cancel IRPs without actually waiting for their completion, and proceed to free the FCB, which contained these IO_STATUS_BLOCKs.
Note that using TdiBuildInternalDeviceControlIrp for these requests is broken in the first place, since it is intended for synchronous requests and requires a guarantee about the calling thread's lifetime. These functions (and their completion routines) should use IoAllocateIrp/IoReuseIrp/IoFreeIrp instead. However this can be fixed later; the incredibly annoying nonpaged pool corruption due to this that has been around for 10 years should be fixed with this commit.
CORE-8640 #resolve
svn path=/trunk/; revision=64838
- Implement vfatPrepareTargetForRename() that prepares for renaming. It tries to open target and deletes it if it exists and if allowed. And then, it opens the parent directory.
- Implement VfatSetRenameInformation() that actually does the renaming (call as SetInformationFile). It handles cases we we have (or we don't have) TargetDirectory provided. It sends notifications as appropriated on demands.
- Implement vfatRenameEntry() that renames an entry in place. So far, it only supports FATX entries renaming. FAT entries are a bit more complex. It falls back to vfatMoveEntry() in later cases.
- Implement VfatMoveEntry() that will move an entry accross directories (or in place for FAT). Its principles are simple: it deletes the entry in old parent, and recreate it in new parent, keeping file metadata & data.
- Modify VfatDelEntry() and VfatAddEntry() so that they can handle deleting an entry without touching its data and adding an entry with an already provided FCB and thus use the given metadata.
- Implement vfatDelFCBFromTable() which is just old code moved to new routine to allow reuse. It deletes a FCB entry from hash table. Doesn't deal with references!
- Implement vfatMakeFullName() which is mostly old code moved to new routine to allow reuse. It allocates buffer and copy data for FCB full name.
- Implement vfatUpdateFCB() that will update a FCB with new names and parent. It will remove anything related to old name and will recreate using new data. It will adjust references count.
- Modify vfatMakeFCBFromDirEntry() so that it calls vfatMakeFullName().
- Modify vfatReleaseFCB() so that it calls vfatDelFCBFromTable().
- Revert VfatOpenFile() to its previous features.
- Modify VfatCreateFile() to reimplement support for SL_OPEN_TARGET_DIRECTORY. It is way less hackish than previously. It also properly opens parent now, by incrementing its handle count and by setting appropriate access rights.
[KERNEL32]
- Rewritten MoveFileWithProgressW() to implement all the missing features that are used in Windows 2k3 including links and reparse points.
- Implemented BasepMoveFileDelayed() to replace deprecated add_boot_rename_entry(). This functions is matching the features implemented in SMSS.
- Implemented BasepMoveFileCopyProgress() which is used in MoveFileWithProgressW().
- Stubbed BasepNotifyTrackingService() which is not use at the moment (FastFAT, even in Windows doesn't provide such feature).
- Reimplemented ReplaceFileA(), MoveFileWithProgressA() to quit Winisms and use our internal helpers.
- Make MoveFileX() use MoveFileWithProgressX() directly.
- Fixed a few prototypes.
TL;DR:
This (huge) commit implements file and directory renaming in FastFAT driver. This allows getting rid of old implementation in kernel32 where files were force copied.
A feature is still missing, but Jérôme should implement it anytime soon (he prototyped it already): moving directories across volumes. This requires some work in BasepCopyFileExW().
Kudos to all the devs who helped me on this: Christoph, Hervé, Jérôme, Thomas.
This finally allows killing CR-52... It was about time!
svn path=/trunk/; revision=64836
- Add the localgroup command. It does not work properly on ReactOS yet.
- Print a warning when the domain option of the accounts command is used.
svn path=/trunk/; revision=64834
Bugfixing... Part 9/X:
- Return the appropriate size for file size.
- Round the allocation to cluster size (as requested by the API).
This fixes metadata display when enumerating a directory in CMD.
What you get now: http://www.heisspiter.net/~Pierre/rostests/NTFS_listing_fixed.png
Time to fix all the rest!
D'oh!
svn path=/trunk/; revision=64833
Bugfixing... Part 8/X:
- Actually, the files timestamp are already stored in the correct format on-disk... I should have listened to Thomas...
This fixes incorrect dates display when enumerating a directory contents. My apologies Thomas :-(.
Last to fix: the file size which is broken.
svn path=/trunk/; revision=64832
[USER32_APITEST] Disable WndProc test when runtime checks are enabled
[KERNEL32_WINETEST] Zero initialize a buffer. This is necessary, since we fail all calls to GetVolumePathNamesForVolumeNameW and thus never get any data into the buffer, which can later result in a buffer-overrun, when doing a lstrlenW on it.
svn path=/trunk/; revision=64831
Bugfixing... Part 6/X:
- Properly return the size of the NTFS volume (and not a buggy size)
- Properly return the characteristics of the NTFS volume
svn path=/trunk/; revision=64829
Bugfixing... Part 6/X:
- Properly compute file name length.
This makes directory enumeration return complete file/directory names.
Note that it's also possible to enumerate the files in open dialog of notepad (for instance :-))
Opening a subdirectory/file is broken though. To be investigated.
svn path=/trunk/; revision=64825
Implement the HLT instruction.
Remove the IdleCallback, since it's unused and probably won't be used.
(The load reduction will be implemented in NTVDM instead.)
svn path=/trunk/; revision=64823
Implement RtlDeleteNoSplay which is really just a copy/paste of RtlDelete, but without splaying the tree after deletion of the node. Needed by the filter driver fltmgr.sys. Dedicated to Mr. V ;)
svn path=/trunk/; revision=64818
- Implement _RTC_GetErrDesc, _RTC_SetErrorFuncW, add stubs for _RTC_NumErrors, _RTC_SetErrorType, _RTC_SetErrorFunc
- Implement _RTC_DefaultErrorFuncW which will be used, when no other error func was set
- Implement _RTC_InitBase, which will be called from _RTC_Initialize, and which in turn calls either _CRT_RTC_INITW, if CRT was linked, or a local _CRT_RTC_INITW0, which in turn will return the error function to use. This allows us to use a custom error function for all modules that link to (MSV)CRT. Only user32 does not really fit into here, since it uses the same startup code but does not link to MSVCRT.
[CRT]
- Call _RTC_Initialize from __main before initializing the global constructors, but fall back to a dummy _RTC_NoInitialize(), when RunTmChk.lib was not linked. Now we properly initialize both our own as well as MS RunTmChk lib.
svn path=/trunk/; revision=64816
- Improve memory layout by moving the 32/64 bit stack to 0x7000-0xF000 and moving the BIOSCALLBUFFER up a bit. This gives us 56 KB additional space for freeldr itself. This allows to compile freeldr with /RTC1 (x86 only, the x64 version would get too big). And yes, it works.
- Implement FrLdrBugCheckWithMessage to get some useful messages on the screen and use it in MmCheckFreeldrImageFile
- Merge the .rtc section into the .text section, when we use RTC1
- Check the location of the Extended BIOS Data Area, add it to the memory descriptors and make sure we have enough space to put freeldr in. If the location of the EBDA is too low, print out a nice message on a blue screen :)
svn path=/trunk/; revision=64815
* Use the runtime checks globally in ReactOS now, not just for user mode modules.
* We no longer need the MS support lib, as Timo kindly implemented one for ReactOS.
* Rename the lib to runtmchk.
[PSEH][CRT]
* Remove some constrictions to seh.s source files, we no longer need them.
[KERNEL32]
* We no longer need to explicitly link to the runtime checks lib.
[FREELDR][KEYBOARD][NTOS][SETUPLDR]
* Link to the runtime checks lib when this mode is enabled.
CORE-8626
svn path=/trunk/; revision=64807
* Use set_module_type() instead of the combination of set_entrypoint(), set_subsystem() and set_image_base().
* Remove the now redundant bugcodes dependency.
[FRAMEBUF_NEW]
* Remove redundant bugcodes dependency.
svn path=/trunk/; revision=64806
* Let the minimum required CMake version be 2.8.12 so that *cough* people with old RosBE would be warned to update it! (I'm looking at you, Arch).
svn path=/trunk/; revision=64801
Bugfixing... Part 5/X:
- Actually, we don't care about the name in the file index. We don't need it to read the data attribute, it's unnamed. And the returned name was buggy (this still needs work though)
- When we are getting a file record which is a directory, there is NO data attribute. Don't attempt to read it. This prevents failure on directory entry return.
These fixes enable NTFS directory listing in ReactOS!
Even though, more fixes are required. So far, the metadata of the files are kind of broken. Explorer seems to be unable to list files.
This keeps anyway being a major step forward, as this was totally impossible a month ago ;-).
For these willing to see NTFS in action in ReactOS: http://www.heisspiter.net/~Pierre/rostests/NTFS_listing.png
svn path=/trunk/; revision=64800
Bugfixing... Part 4/X:
- Fix a nasty bug in NtfsLookupFileAt() (how did it work before?). The name parsing was wrong (no progress was being made) and thus was leading to an infinite loop in directory browsing.
- Fix a lovely bug coming from a non-documented feature in NTFS. To properly read the MFT index, you've to apply a mask. Do this to properly handles MFT record. This fixes returned MFT index which allows resuse.
- Do not allow returning MFT records < 0x10 for now. Not sure whether it should be allowed, but so far, these are MFT special records, so let's forget about it. IIRC, they are available on Windows. But trying to chase another bug for the moment.
This does not fix yet directory enumeration.
svn path=/trunk/; revision=64793
- Use a helper function for copying little chunks of memory (1, 2, 4 and 8 bytes) because a profiling of ntvdm showed that especially 1 and 2 bytes of memory were read the most, and calling RtlCopy/MoveMemory for intensively copying 1 or 2 bytes was shown to be inefficient. We also don't use directly intrinsics/builtins because the compiler cannot know in advance the size of the memory to be copied, it cannot perform the required optimizations. It was checked that using the builtin-memcpy or memmove of GCC when compiling the program in release+full optimization mode just embedded a call to _memcpy, and naively using the movsX intrinsics of MSVC does not do the job of "moving" memory taking into account for the possible overlaps. Therefore, for small sizes (<= 8 bytes), we use copy assignments, whereas for large sizes (and for 3, 5, 7, 9+ bytes) we use the regular method of calling RtlMoveMemory. We gain ~=10% speed with this optimization.
- Also I use >> and & for dividing by 4 and 2 instead of the regular / and % operations because they are not optimized otherwise by default by MSVC (they are however, if you explicitely enable optimizations).
svn path=/trunk/; revision=64792
Properly fix warnings on MSVC, introduced in r38302.
"- 'allowwarnings=true' -- not anymore", they said.
Advice by ThFabba.
svn path=/trunk/; revision=64790
- prevent a buffer underrun (fixes stray quotes being appended on autocomplete in some cases)
- check if the input string is not empty (fixes first file in directory getting skipped on autocomplete)
- fix some typos
CORE-8623
svn path=/trunk/; revision=64787
* Workaround for CORE-8525, CORE-6023, CORE-7735 and CORE-8635.
* Brought to you by V and Amine. Thanks to Timo and Jerome for the reviews.
CORE-8525 CORE-6023 CORE-7735 CORE-8635 #comment Please retest with r64777 or later.
svn path=/trunk/; revision=64777
Bugfixing... Part 3/X:
- Really release the allocated memory in NtfsFindFileAt() and NtfsLookupFileAt(). Don't attempt to release caller pointer!
This fixes crashes on directory enumeration failure. Even though this latter still doesn't work.
svn path=/trunk/; revision=64776
Bugfixing... Part 2/X:
- Please welcome yet another structure in our NTFS driver... The INDX buffer which is used for non resident index entries. Doc (incomplete) here: http://bos.asmhackers.net/docs/filesystems/ntfs/INDX.html
- Make use of it in NtfsFindMftRecord() to replace some totally obscure code.
- Add some asserts to verify we read somehow what we expect. One of the assert is not working properly... Hum! Need to find out why.
We don't go any farther so far. Good news though: a FIXME has been replaced by another FIXME.
NB: This would deserve being ported to FreeLDR to fix the same FIXME.
svn path=/trunk/; revision=64771
Handle int 0x2c (assertion failure) in KDBG by breaking into the debugger instead of ignoring it and pretending it was handled. Now NT_ASSERT works on GCC builds as well. (As good as things work in KDBG...)
svn path=/trunk/; revision=64770
Bugfixing... Part 1/X:
- FixupUpdateSequenceArray() returns a NTSTATUS, so properly handle it.
- Actually... Attributes name can be unicode in case of a file name, but it can also be ansi, for streams name... So, don't force UNICODE_STRING, it causes more troubles than it solves.
So, now, we really progress in reading directory. Instead of finding no files because we improperly read attributes, we now corrupt memory somewhere and crash ReactOS.
svn path=/trunk/; revision=64765
- Don't truncate pipe name in the RootPipe case in NpCreateFcb. Found by Windows's RtlInsertUnicodePrefix implementation -- which might indicate that ours is broken.
svn path=/trunk/; revision=64763
- Use NpAcquire*Vcb/NpReleaseVcb instead of using NpVcb directly
- CaseInsensitiveIndex is integer, not boolean
- Minor fixes involving unnecessary casts and magic numbers
svn path=/trunk/; revision=64761
Implement a simple version of RunTmChk.lib for MSVC runtime check support, which can also be used in kernel mode. This one is good enough to compile ntoskrnl with it.
svn path=/trunk/; revision=64756
- Implement NtfsGetNameInformation()
- Implement NtfsGetDirectoryInformation()
- Implement NtfsGetFullDirectoryInformation()
- Implement NtfsGetBothDirectoryInformation()
- Implement NtfsQueryDirectory() which makes use of all the functions upper + all the previous fixes to make it able to look for a file using WC and file entry index
This is supposed to bring directory enumeration in line on NTFS volumes. BUT, there's a bug at some point which makes it fail (or my test volume is corrupted :-P (which is unlikely (Scheme, get out of this commit message!))). Will look into it later on. Committing so far because it's quite major work anyway.
More to follow~
svn path=/trunk/; revision=64754
Implement NtfsFileFlagsToAttributes() to fix some of the attributes of the MFT to make them usable by ReactOS.
Would deserve a double-check
svn path=/trunk/; revision=64753
* Actually send an OnSelect message right before executing the menu items. Fixes the problem where going to start->shutdown would keep the start menu open in the background.
svn path=/branches/shell-experiments/; revision=64727
* Fix another comment.
* Fix a cch/cb bug.
* Make use of the DSA_DestroyCallback function instead of messing around with the internals of the DSA.
CORE-8564
svn path=/branches/shell-experiments/; revision=64646
* Work around shellexecute not handling GUID path components by giving them to explorer as a cmdline parameter.
* NOTE: The Printers and Faxes option is temporarily disabled because it CRASHES explorer-new.
svn path=/branches/shell-experiments/; revision=64579
* Always open separate.
[BROWSEUI]
* Use the threadref IUnknown for reference counting in the browser threads.
svn path=/branches/shell-experiments/; revision=64578
* We don't keep changelogs in the file headers anymore. That's what the SVN commit history is for.
CORE-7559
svn path=/branches/shell-experiments/; revision=64406
[SHELL32]
* Implement shell shutdown using a proper shutdown dialog. Patch by Lee Schroeder with a small change to fix MSVC build.
CORE-7559 #comment Commited into shell-experiments branch r64403.
svn path=/branches/shell-experiments/; revision=64403
* Implement skeleton shell dde parser.
[SHELL32]
* Copy over the skeleton from rshell, and fill in the handlers for ViewFolder and ExploreFolder, with rudimentary implementations.
CORE-7552
svn path=/branches/shell-experiments/; revision=64395
* Implement SHCreateFromDesktop and supporting functions, and move those implementations to their own file.
[SHELL32]
* Handle message 1035 from the desktop window.
[SHLWAPI]
* Fix a bug in SHAllocShared, where source and destination parameters were reversed.
[EXPLORER-NEW]
* Use SHCreateFromDesktop to open the new window.
NOTE: There appears to be some more problems with the SH*Shared implementation, beyond the swapped parameters, which prevent the opening of the new windows. These functions will have to be revised and the corrected implementation sent to WINE.
svn path=/branches/shell-experiments/; revision=64314
* Implement Taskbar auto-hide. The setting dialog does not work, though, so in order to enable it you need to change the StuckRects2 registry key so that the Settings value has the right bit set to 1 (or import from a Windows installation).
svn path=/branches/shell-experiments/; revision=64089
* Make shlwapi_undoc.h compatible with C code.
[EXPLORER-NEW]
* Link with browseui.
* Use SHOpenNewFrame linked from browseui instead of explicitly loaded.
* Make use of SHExplorerParseCmdLine. Does not yet open windows in an existing process when used through commandline.
svn path=/branches/shell-experiments/; revision=64083
* Make use of the wine debug functions and turn DbgPrints into TRACE/WARN/ERR.
[SHELL32]
* Turn some DbgPrints into TRACEs.
svn path=/branches/shell-experiments/; revision=63912
* Stop using the C defines LPSHELLFOLDER, LPSHELLVIEW and LPUNKNOWN, and use the respective C++ interfaces instead.
* Change one batch of COM interface pointers into CComPtr-based pointers, and remove associated Release calls (including at least one that was not supposed to be there at all).
* Remove a couple (repeated multiple times) pointless casts.
svn path=/branches/shell-experiments/; revision=63908
* Populate edit and view menu on first activation. TODO: enable/disable edit menu items in OnInitMenuPopup.
* Add Edit menu to resources (en-US only, other langs TODO)
* Repurpose BuildFileMenu to build the menu for the selection. This needs improvements as it uses all the items from the context menu at the moment.
* Add items to the File menu when shown.
svn path=/branches/shell-experiments/; revision=63836
* Improve the view menu handler a bit. Now the view menu properly marks the current view as expected.
svn path=/branches/shell-experiments/; revision=63811
* Find the menu index so that the forwarded WM_INITMENUPOPUP has all the info shell32 needs.
[SHELL32]
* Begin implementing dynamic menu editing, which is used by the shell views in order to change, add or remove items from the filebrowser menus. Some menu items may be temporarily lost until this is finished.
svn path=/branches/shell-experiments/; revision=63809
* Fix DllMain not being called when building with gcc. Apparently msvc makes DllMain extern "C" even if you didn't ask for it, unlike gcc.
* Simplify some code.
svn path=/branches/shell-experiments/; revision=63791
* Shell service object DLLs expect the ShellServiceObjectDelayLoad key to exist.
[SYSSETUP.INF]
* Mark stobject.dll to be registered during setup.
[STOBJECT]
* Implement icon handling.
* Implement rudimentary volume icon handler.
* Allow the volume icon to show the mute status of the primary audio device.
svn path=/branches/shell-experiments/; revision=63750
* Create skeleton for the SysTray shell service object DLL. No tray icons are created yet.
* Tranks Robert Naumann for providing the icon resources, and some file templates.
svn path=/branches/shell-experiments/; revision=63732
* Notify the parent menu popup when the deskbar is closing.
[EXPLORER-NEW]
* Set the button pressed when the start menu gets displayed.
* Set the button released when the start menu notifies it was closed.
svn path=/branches/shell-experiments/; revision=63710
* Use the IAugmentedShellFolder methods instead of the old constructor.
[SHELL32]
* Fix gcc compilation.
svn path=/branches/shell-experiments/; revision=63708
* Now that CMergedFolder works, try to make it more like windows.
* CMergedFolder: Declare and expose the undocumented IAugmentedShellFolder2 (all methods unimplemented yet). It will require major changes to the way I implemented it, but it will be for the best.
* CStartMenu: Make use of the real CMergedFolder in Windows 2003 (does not exist in win7).
svn path=/branches/shell-experiments/; revision=63703
* CFocusManager: Try to fix some weird behaviour.
* CMergedFolder: Downgrade some prints to TRACEs, and implement a couple methods needed by some debugging code.
* Activate merged folders by default. TODO: implement the filtering of the "Programs" submenu, and use it for the real Programs menu item.
[SHELL32]
* defcontextmenu.cpp: Make a copy of the apidl array before storing it for later, since it may be a pointer to the stack which may not be available later. Fixes the merged folders not working on clicks and context menu.
* shlmenu.cpp: While debugging, I made Shell_MergeMenus closer to WINE's.
svn path=/branches/shell-experiments/; revision=63702
* Revert debugging change that shouldn't have been commited.
* Implement rudimentary tooltip support for tray icons. Does not yet work exactly like the windows does it.
svn path=/branches/shell-experiments/; revision=63685
* Fix a typo that broke tray notify icons.
* Implement loading of Shell Service Objects. Works in win2003 but no idea if it works in ros since we don't have any SSO implemented yet ;P
svn path=/branches/shell-experiments/; revision=63684
* Handle SMSET_BOTTOM on SetShellFolder so the shell items show below the static menu.
* Downgrade some DbgPrints to TRACEs (reduces log spam).
* Add some extra debugging messages to CMergedFolder.
* Export the CMergedFolder constructor so it can be used from browseui.
[BROWSEUI]
* Use merged folders for the Favorites menu.
svn path=/branches/shell-experiments/; revision=63683
* Change the way the menu items are activated. Now the menubar activates on mouse down, and the other items activate on mouse up. Not everything works perfectly yet, but it will eventually allow proper usage of the shell menus by keeping the mouse button down. I believe this is also the way to go to avoid the "instant reopening" of the menus when trying to close them.
svn path=/branches/shell-experiments/; revision=63671
* Added IPersistFolder2 interface to CMergedFolder, per MSDN suggestion.
* Changed the way the pidl info is stored to be more clean and readable.
svn path=/branches/shell-experiments/; revision=63669
* Implement a rudimentary but mostly functional (for start menu purposes) CMergedFolder class. It's still disabled by default because clicking on an item in a merged folder appears to fail to execute it.
svn path=/branches/shell-experiments/; revision=63658
* Disregard the restricted setting and always remove the Search menu from the start menu. When Search is implemented, it can be reenabled.
svn path=/branches/shell-experiments/; revision=63639
* Implement a rudimentary "Help and Support" start menu item by launching the default browser with http://reactos.org/ as the URL.
svn path=/branches/shell-experiments/; revision=63638
* Notify the focus manager that we are about to open a context menu, so that it doesn't mess with the menu popup.
svn path=/branches/shell-experiments/; revision=63634
* Use a struct like the comment suggested. May not fix anything, but it's one FIXME less in ReactOS.
svn path=/branches/shell-experiments/; revision=63623
* Copy basic path parsing from explorer-new, so filebrowser.exe can load with a different folder active.
svn path=/branches/shell-experiments/; revision=63622
* Process ParseNow on the CBEN_ENDEDIT notification.
* Call SHAutoComplete to ask the edit control to have autocomplete functionality. I need to figure out the flag or whatever is needed to make it show "Search 'string'" when entering something that's not a valid path.
svn path=/branches/shell-experiments/; revision=63621
* Turn off spammy log.
* A small themeing tweak for the menubar.
[BROWSEUI]
* Turn off spammy log.
* A small tweak to a function.
svn path=/branches/shell-experiments/; revision=63620
[TASKMGR]
Set a proper shutdown level (with SetProcessShutdownParameters) so that explorer and taskmgr are terminated the very last when one shutdowns ReactOS.
See Windows Internals 4th page 286 (section "Shutdown") which gives the values (that I've cross-checked on Windows 2k3 too).
svn path=/branches/shell-experiments/; revision=63601
* Fix stack corruption in VS2010 builds. No idea why it doesn't crash with other compilers.
[EXPLORER-NEW]
* Fix a similar bug that does not appear to cause any issue, but is a bug regardless.
svn path=/branches/shell-experiments/; revision=63548
* Use the debugging class to track COM refcounting of the CMenuBand.
* CMenuSite: Remove an useless line.
[BROWSEUI]
* Refactor the CreateMenuBar method in an attempt to figure out a seemingly magic crash with VS2010 (not yet solved).
* Begin fixing some unused-but-set warnings.
[SHELL32]
* Fix some small bugs spotted by Victor.
svn path=/branches/shell-experiments/; revision=63546
* Fix gcc compilation.
[BROWSEUI/RSHELL]
* Use virtual destructors and cleanup with delete in the creator functions.
* Try to fix a bit the "close" flow, so that less circular references remain when the filebrowser windows are closed.
svn path=/branches/shell-experiments/; revision=63539
* Plug a few menu leaks. In Windows, it brings down the leaked menus from 20 per navigation, to only 1-2. In ReactOS, from 60 to 20.
[RSHELL,SHELL32]
* Code tweaks that shouldn't change the actual behaviour.
svn path=/branches/shell-experiments/; revision=63537
* Begin fixing the process of destroying the related objects when closing the window, so that eventually the filebrowser/explorer process will properly exit cleanly when no more windows are open.
svn path=/branches/shell-experiments/; revision=63535
* This shouldn't have been commited. The browse windows were freezing because it was trying to use the menu from shell32 instead of rshell.
svn path=/branches/shell-experiments/; revision=63533
* The CDefView should not process the backspace key directly. It's already handled by the accelerators.
[BROWSEUI]
* Allow the docked toolbars to translate accelerators.
* CAddressEditBox: Cancel accelerators without modifiers while focused.
[RSHELL]
* Cancel accelerators while a popup is open, and ignore them otherwise.
svn path=/branches/shell-experiments/; revision=63504
* Remove a call that shouldn't even be working in Windows, and was completely unnecessary. Fixes explorer-new navigation history in ReactOS.
* Added some debug traces.
CORE-8173
svn path=/branches/shell-experiments/; revision=63479
* Close menu on right click too.
[BROWSEUI]
* Check/uncheck the lock toolbar item based on the lock state. The view menu does not update yet.
[SHELL32]
* Destroy the menu when the view window is destroyed.
svn path=/branches/shell-experiments/; revision=63461
* Reuse the same menu instead of recreating it every time something changes. Fixes the menus not showing, but it's not the right way to do it. A better implementation should come later.
[BROWSEUI]
* Add a german version of the toolbar strings, by Christoph von Wittich.
svn path=/branches/shell-experiments/; revision=63426
* Keep the call to TranslateAcceleratorSB within the shell browser, since it appears the windows CDefView does not call it.
* "Hackplement" the backspace key as being the same as the "go up one level" menu item. This does not seem to be exactly true in Windows, but it does the job.
svn path=/branches/shell-experiments/; revision=63415
* Improve the message loop to allow processing of accelerators.
[SHELL32]
* Return the accelerator to the shell browser if the view doesn't handle it.
svn path=/branches/shell-experiments/; revision=63397
* Do not swap the big and small imagelist pointers. Fixes the explorer windows not having an icon in the taskbar.
Note: the underlying issue preventing the taskbar from showing a 32x32 icon in the buttons still exists, so other apps with the same behaviour will still fail to draw.
svn path=/branches/shell-experiments/; revision=63383
* Implement ParseNow to allow navigating to the current address in the editbox.
[SHELL32]
* Set the focus to the listview if the browser is requesting it.
CORE-7330
svn path=/branches/shell-experiments/; revision=63371
* Disable the brandband again, since it doesn't look right in ros.
* Fix the browse window styles so that it can properly open with system-provided default size.
* Change the default view mode of the file list to Icons.
CORE-7330
svn path=/branches/shell-experiments/; revision=63370
* Default to always-on-top if the registry setting is not found.
* Reload and apply settings on display change. Fixes taskbar not repositioning on resolution changes.
CORE-7330
svn path=/branches/shell-experiments/; revision=63369
* Fix the fallback for when rshell functions are not exported or rshell is not present.
* While at it, avoid unnecessary calls to LoadLibrary.
svn path=/branches/shell-experiments/; revision=63357
* Turn back some DbgPrints into TRACEs.
* Remove the desktop from the rshell exports, as it works better in ros that way, and it's only needed for debugging in windows 8.
svn path=/branches/shell-experiments/; revision=63352
* Allow WM_ACTIVATEAPP to be sent to the deactivated windows. Fixes the start menu not closing when clicking outside the taskbar. Patch by Huw (Frontier).
CORE-8235 #resolve #comment Included in shell-experiments branch. Thanks.
svn path=/branches/shell-experiments/; revision=63350
* HSHELL_WINDOWCREATED should only be sent for visible windows.
CORE-8226 #resolve #comment Fixed in the latest commit. Thanks for reporting.
svn path=/branches/shell-experiments/; revision=63316
* Fix handling of taskbar items.
* Filter out the desktop and taskbar from the button list.
* Fixes minimizing from the taskbar in Windows (something else is preventing it from working in ros).
[NTUSER]
* Improve filtering of windows before calling HSHELL_WINDOWCREATED.
[USER32]
* Menus are supposed to be WS_EX_TOOLWINDOW so they don't show up in the taskbar.
[ATL]
[BROWSEUI]
[SHELL32]
* Include ATL aggregation patch by Huw (Frontier) (with Amine's changes).
CORE-8175
svn path=/branches/shell-experiments/; revision=63304
* AddressBand: Create a combobox item to hold the info of the current folder, and keep it selected. This will in the future be improved to show a pseudo-tree including all the parent folders up to the Desktop, with the Desktop and My Computer expanded.
CORE-8220
svn path=/branches/shell-experiments/; revision=63270
* Fix gcc build.
* Also, undo a change that wasn't as useful as I first thought it would be.
CORE-8183 #resolve #comment Here you go. Thanks for reporting.
svn path=/branches/shell-experiments/; revision=63196
CORE-8176 #resolve #comment Trunk commit r63174 should fix this issue. I merged from trunk to bring it into Shell-experiments.
svn path=/branches/shell-experiments/; revision=63175
* Begin implementing resizing of the rebar.
* Begin implementing the addressbar function. For now, the current folder path is displayed. No icon, no parsing support, no combo dropdown list.
CORE-8173
svn path=/branches/shell-experiments/; revision=63156
* Fix redundant clauses by converting the code to a switch block. Adapted from a patch by Victor Martinez.
CORE-8161 #resolve #comment Fixed in the shell-experiments branch. Thanks.
svn path=/branches/shell-experiments/; revision=63115
* Do not set the imagelist if the bitmap wasn't loaded.
* Fix the flags that caused the toolbar not to relocate when toggling the lock mode.
svn path=/branches/shell-experiments/; revision=63114
* I forgot a cast and a couple IID_PPV_ARG uncommited.
[BROWSEUI]
* Fixed rebar flags to match windows. Adds the missing border around the toolbars.
* Fix some calculations of the rebar size.
* Fetch the icon of the current folder and assign it to the browse window.
CORE-7330
svn path=/branches/shell-experiments/; revision=63103
[SHELL32]
* Move the IID_NULL_PPV_ARG macro to the shobj_undoc header, next to the (also ros-specific) IID_PPV_ARG macro, so that it can be used elsewhere.
[SHELL32]
* Make use of IID_NULL_PPV_ARG in all the calls to GetUIObjectOf, and fix one instance of mismatched riid/pointer.
CORE-7330
svn path=/branches/shell-experiments/; revision=63044
* Make use of the IID_PPV_ARG for typesafe interface return pointers, and a few other cosmetic changes.
CORE-7330
svn path=/branches/shell-experiments/; revision=63033
* Reenable the brand box on file browser windows.
* Fix an invalid usage of a null HWND.
* Implement size calculation of the standard toolbar.
CORE-7330
svn path=/branches/shell-experiments/; revision=62961
* Implement selecting the first/last item, and make the menu system choose to select the first item when opening a submenu with the keyboard.
svn path=/branches/shell-experiments/; revision=62959
* Fix stack overflow when pressing enter with a menu item selected. Executing with enter now works correctly.
CORE-7586
svn path=/branches/shell-experiments/; revision=62957
* Prevent the focused window from receiving keyboard events while a shell menu is open.
CORE-7586
svn path=/branches/shell-experiments/; revision=62935
* Almost working keyboard navigation on horizontal menu bar. It does not yet switch between menus when a submenu of the shell menu is currently open and you press [right].
CORE-7586
svn path=/branches/shell-experiments/; revision=62891
* Implemented horizontal keyboard navigation on the menubar. Does not yet work for the Favorites menu, which is a shell popup and not a tracked popup. Also missing the system menu in the rotation.
svn path=/branches/shell-experiments/; revision=62757
* Fix keyboard navigation on vertical popup menus. Navigating through the menubar does not work yet.
CORE-7586
svn path=/branches/shell-experiments/; revision=62753
* Fixed the context menu for shell items.
* Some more code style improvements.
* Moved the toggles between using system classes and rshell classes into the constructor functions, so the code is easier to read.
CORE-7586
svn path=/branches/shell-experiments/; revision=62752
* Code cleanups and formatting.
* Remove the logging wrappers. If I need them again I'll bring them back.
* Try to fix a few "glitches" in the hot-tracking.
svn path=/branches/shell-experiments/; revision=62693
* Some code improvements, refactoring, and commenting.
* Using alternative method of handling hot-tracking, which does not break in win2003.
CORE-7586
svn path=/branches/shell-experiments/; revision=62681
* Improvements on the focus manager. The menus work better, but still not fully. Commiting for backup/history purposes.
CORE-7586
svn path=/branches/shell-experiments/; revision=62601
* Redesigned large portions of the focus manager. All the mouse interactions seem to work now
CORE-7586.
svn path=/branches/shell-experiments/; revision=62567
* Improve behaviour when hovering and clicking on the menubar. It's still somewhat glitchy though.
CORE-7586
svn path=/branches/shell-experiments/; revision=62539
* Improve mouse navigation of the menubar.
* Fix the menus.
* Fix the case for system includes (hopefully fixes).
CORE-7586
svn path=/branches/shell-experiments/; revision=62537
* Implement WH_MSGFILTER hooking to handle the popup menus from the horizontal menubar. Switching between menu items wby moving the mouse now works, but at the moment, the non-menu popups (including the start menu) are somewhat glitchy.
CORE-7586
svn path=/branches/shell-experiments/; revision=62534
* Begin work in improving the behaviour of the horizontal mode menuband. There's still a lot of work to do, and some things are temporarily worse than before, but in other places it has improved already.
CORE-7586
svn path=/branches/shell-experiments/; revision=62520
* Fix the hot tracking on the filebrowser menubar. Still does not handle switching menus while hovering, though.
CORE-7586
svn path=/branches/shell-experiments/; revision=62514
* Fix keyboard navigation and hottracking behaviour. One glitch remains where quickly moving the mouse to a parent's toolbar item, and returning to the submenu before it closes, won't restore the parent's hot item to the one with the submenu.
svn path=/branches/shell-experiments/; revision=62509
* Fix some null dereferences.
* Fix positioning of submenus of an horizontal menu toolbar.
[BROWSEUI]
* Fix some null dereferences.
CORE-7586
svn path=/branches/shell-experiments/; revision=62492
* Added partial implementation of the IShellFolderView interface to CFolderView. Patch by Ivan Rodionov.
CORE-7976 #resolve #comment Applied to shell-experiments branch. Thanks.
svn path=/branches/shell-experiments/; revision=62489
* Use the correct icon for the "My Computer" item. Patch by Robert Naumann.
CORE-7979 #resolve #comment Applied to shell-experiments branch. Thanks.
svn path=/branches/shell-experiments/; revision=62488
* SHGetImageList should not return a duplicated ImageList. In Windows the pointers returned by Shell_GetImageLists match the pointers returned by SHGetImageList for SHIL_SMALL and SHIL_LARGE.
[RSHELL]
* Remove two obsolete debug prints.
svn path=/branches/shell-experiments/; revision=62483
* Workaround for the exec issue. Ros currently seems to send a bogus WM_ACTIVATE message when clicking while the window is already active. Proper fix may come later if I can figure out why this happens.
CORE-7586
svn path=/branches/shell-experiments/; revision=62475
* Fix reusing the same toolbar when SetMenu is called multiple times.
* Avoid some null dereferences.
[BROWSEUI]
* Temporarily (?) disable the logo band.
The browser window's "coolbar" and menubar now display and work properly in both Windows and ReactOS.
CORE-7586
svn path=/branches/shell-experiments/; revision=62472
* Give TrackPopupMenuEx the top-level window. Need to figure out how Windows does this, it probably does not simply use the top-level window that way.
* Give TrackPopupMenuEx better flags and a better exclude rect.
CORE-7586
svn path=/branches/shell-experiments/; revision=62469
* Rename the output to explorer_old
[EXPLORER-NEW]
* Rename the output to explorer
* Launch a browseui window when explorer is run with an existing shell process.
Shell-experiments will now be running the new shell by default.
This allows me to test the shell classes under more accurate conditions, so I was using it locally for a while.
I decided to commit because of two reasons:
1. It was making me temporarily revert some changes done to some files when I wanted to commit, and
2. It lets everyone see the results of the shell-experiments project without having to mess with the task manager.
Keep in mind that, as the branch name implies, it STILL is an experiment.
CORE-7586
svn path=/branches/shell-experiments/; revision=62449
* Load and use rshell for the menubar.
* Properly forward WM_NOTIFY and WM_COMMAND messages to the toolbars.
[RSHELL]
* Improve behaviour of horizontal menubands.
* Clicking on submenu items does not work yet.
CORE-7586
svn path=/branches/shell-experiments/; revision=62448
* Revert a change that removed too much. Unbreaks the "New..." menu, and anywhere else that required this, although the code feels like a workaround for a bug elsewhere.
svn path=/branches/shell-experiments/; revision=62436
* I don't know what this may fix, but it was wrong. On the upside, now there's less spam in the log.
svn path=/branches/shell-experiments/; revision=62433
* CMenuSite: Reworked the code to avoid SHIsSameObject, since newer versions of windows do not implement that function. The code should be equivalent, and does less unnecessary calls to QueryInterface.
CORE-7879
svn path=/branches/shell-experiments/; revision=62432
* CMenuSFToolbar: Keep the m_shellFolder pointer in a CComPtr, so that it doesn't get deleted and possibly reused for something else.
CORE-7586
svn path=/branches/shell-experiments/; revision=62429
* Make horizontal separators of vertical toolbars draw.
* Apply the same padding to separators as the rest of the buttons.
* Fixup some tabs into spaces, for consistency.
* Needs to be sent to wine.
svn path=/branches/shell-experiments/; revision=62426
* SHInvokeDefaultCommand is supposed to invoke the DEFAULT command, so why was bInvokeDefault given FALSE?!
[RSHELL]
* A couple of trivial fixes.
[NTUSER/USER32]
* I missed two bits. See CORE-7966 for more info on the menu issue.
CORE-7586
svn path=/branches/shell-experiments/; revision=62420
* I was telling AddButton that all the items were the last, except the last. Now the submenus display properly. Some of them at least. Others get an exception, it seems.
CORE-7881
svn path=/branches/shell-experiments/; revision=62416
[USER32]
* Fix what I think is a wrong behaviour of storing MF_POPUP in the fType of the menu. Now it relies on hSubMenu being != NULL as an indicator of the presence of a submenu.
* Resource submenus are not supposed to get the hSubMenu as a wID, as far as I can tell.
* From the user point of view, it matches Windows better. Needs review and testing, as I don't know if I updated everything correctly.
svn path=/branches/shell-experiments/; revision=62415
* Improve logging in case of unexpected failures, and trace the creation of toolbar (menu) items.
CORE-7586
svn path=/branches/shell-experiments/; revision=62414
* Move the copying back where it belongs. CMake may generate the dependencies the wrong way around (explorer-new should depend on rshell), but at least the copying works as expected, even if I always have to "build solution".
* Allow toggling between TBSTYLE_EX_VERTICAL and the manual TBSTATE_WRAP setting by (un)definiting TBSTYLE_EX_VERTICAL.
CORE-7881
svn path=/branches/shell-experiments/; revision=62412
* Improve encapsulation of the CMenuToolbarBase by avoiding unnecessary usages of the window handle from the derived classes.
CORE-7881
svn path=/branches/shell-experiments/; revision=62411
* CMenuToolbarBase: Use TBSTATE_BREAK on every button instead of TBSTYLE_EX_VERTICAL. This allows the vertical alignment to work on ros, although the separators are neither sized nor drawn correctly, and the arrow alignment is wrong.
NOTE: It's still not functional. Second level submenus don't show up, and clicking on items does nothing.
CORE-7881
svn path=/branches/shell-experiments/; revision=62382
* Move dependency copying to the target script, so that the target properly depends on the source and not the other way around.
* Make all the custom constructors WINAPI.
* Add all the custom constructors to the spec file.
CORE-7596
svn path=/branches/shell-experiments/; revision=62365
* Add a new logging wrapper to record calls from the start menu back to the explorer site.
CORE-7586
svn path=/branches/shell-experiments/; revision=62335
* Show the start menu at the same position and alignment Windows uses.
[RSHELL]
* Use IShellFolder methods instead of SHCreateShellItem.
* Handle toolbar window events from the toolbar class.
* Improve the positioning calculations.
* TODO: How to tell the submenus of the start menu to show towards the left? For when the taskbar is ABE_RIGHT.
CORE-7596
svn path=/branches/shell-experiments/; revision=62334
* Some menu style improvements.
* Some code style improvements.
* Added a skeleton CMergedFolder, as a base towards showing items from both the user and the common start menus. It does not work yet.
CORE-7586
svn path=/branches/shell-experiments/; revision=62330
* CStartMenu: Update the icon resource IDs to the IDs with the smaller images. This causes the images not to show. Need help figuring out why.
* Misc changes.
CORE-7586
svn path=/branches/shell-experiments/; revision=62328
* CMenuBand: Fix the keyboard navigation a bit. Still not fully working yet.
* Show submenus a bit closer to the arrow, as Windows does.
CORE-7881
svn path=/branches/shell-experiments/; revision=62323
* CMenuBand:
- Use a Pager control on top of the SF Toolbar, like Windows does.
- Cache the ideal size of the toolbars to reuse it next time the start menu shows.
- Draw the dropdown arrows on items with dropdowns.
- Cancel the timer and open a submenu immediately if the item is clicked.
- Draw the selected background color on the item with a popup if there is no other item being hovered.
- Add some space for the dropdown arrows in the size calculations (hardcoded).
- Simplify the size calculation and positioning.
CORE-7881
svn path=/branches/shell-experiments/; revision=62317
* Revert change from r62307. Will do a proper merge instead.
[RSHELL]
* CMenuBand: Use SHGetImageList instead of Shell_GetImageLists.
* CMenuBand: Remove minwidth in the size calculation.
svn path=/branches/shell-experiments/; revision=62308
* CMenuBand: Send timer notifications for all items, so we can hide a previous submenu when the user hovers an item without submenu.
* CMenuBand: Avoid a stack overflow in some versions of windows by relying on the stored value instead of asking for it in the middle of a changed event.
CORE-7881
svn path=/branches/shell-experiments/; revision=62303
Halfplement WmipSecurityMethod, implement WmipGUIDFromString as a wrapper around RtlGUIDFromString due to different format requirements, fix usage of RtlPrefixUnicodeString.
svn path=/branches/kernel-fun/; revision=62301
* CMenuDeskBar: Actually use the Popup flags to decide on the relative position of the submenus.
CORE-7886
svn path=/branches/shell-experiments/; revision=62296
* Take "DbgPrint" function from explorer-new.
* CMenuBand: Show placeholder if the band gets an empty IShellFolder. Added what I guess is a hack, to allow CMenuDeskBar to get the submenu popup from the band.
* CMenuDeskBar: Use WM_ACTIVATE and WM_ACTIVATEAPP to detect when the menu should be closed. Uses the hack above for the exception of showing a submenu.
CORE-7886
svn path=/branches/shell-experiments/; revision=62295
* CMenuBand, CMenuDeskBar: Improve the SubMenu hierarchy and OnSelect flow. Now the menu will spread a FullCancel or Execute upwards and close the whole start menu.
CORE-7881
svn path=/branches/shell-experiments/; revision=62280
* Improve the layout of the class definitions to make the important details easier to find.
* Rename private (non-COM) class methods to more appropriate names, including a prefix.
* CMenuBand: Make one submenu close before showing another one. This may not be happening in the same exact way windows does it.
CORE-7881
svn path=/branches/shell-experiments/; revision=62263
* CMenuBand: Implement rudimentary support for changing the hot item with the keyboard (up/down). The code can probable be simpler, and some corner cases need to be fixed, but it works.
* CMenuDeskBar: Attempt to redesign OnSelect to better match the windows behaviour, which is still mostly unknown.
* Make the log results more readable.
CORE-7881
svn path=/branches/shell-experiments/; revision=62262
* CMenuDeskBar: Use the submenu pointer to pass on the cancel events. Windows appears to call this with code=2 (cancellevel).
* CMenuBand: Begin implementing a focus manager for the menu windows. This class will take care of handling mouse and keyboard interactions, including closing the start menu and submenus when the user clicks outside the menu window.
CORE-7881
svn path=/branches/shell-experiments/; revision=62259
* Improve the logging system to allow using the same logger for both windows classes and rshell classes.
* Add a wrapper for CMenuSite.
* CMenuDeskBar: Reduce the log differences by keeping a cached copy of the client HWND.
* CMenuBand: Reduce the log differences by keeping a copy of the top level HWND. Will be used later.
CORE-7586
svn path=/branches/shell-experiments/; revision=62253
* Fix some more C-style casts, and misc coding style changes.
* CMenuBand: Create a skeleton of the functions that would handle SMIF_TRACKPOPUP submenus.
* CMenuDeskBar: Fix the redraw issue that prevented submenus from working as expected.
CORE-7886
svn path=/branches/shell-experiments/; revision=62248
* CMenuBand: Improve wrapper logging to get a better picture. Handle more SIDs on QueryService. Send selection messages on hot item changed and on execute.
* CMenuDeskBar: Improve wrapper logging to get a better picture. Handle more SIDs on QueryService. Begin handling more cases in OnSelect.
CORE-7881
svn path=/branches/shell-experiments/; revision=62243
* CMenuBand: Fix display of icons for the static toolbar.
* CMenuDeskBar: Fix positioning of the window not to cross the top edge.
CORE-7881
svn path=/branches/shell-experiments/; revision=62242
* Change C-style casts to static_cast where possible, and reinterpret_cast elsewhere.
* Make coding style and formatting more consistent.
svn path=/branches/shell-experiments/; revision=62239
- CStartMenu: add a test flag that makes the start menu show its submenus using SMIF_TRACKPOPUP in order to show how CMenuBand can use TrackPopupMenu
svn path=/branches/shell-experiments/; revision=62238
* CMenuBand: Improve the code structure.
* Make the class selection better managed.
Thanks Giannis.
CORE-7881
svn path=/branches/shell-experiments/; revision=62231
* CMenuDeskBar: Use the proper value for style in AdjustWindowRect.
* CMenuBand: Implement submenu hot-tracking timer. Not functional yet (submenu creation not implemented).
CORE-7881
svn path=/branches/shell-experiments/; revision=62227
- CMenuDeskBar: Implement showing a shadow. Implement closing the menu when it loses focus (this only works with the stock menu band for now)
svn path=/branches/shell-experiments/; revision=62225
- CMenuBand: Fix the size of the separators by setting iBitmap to 0 (which acts as the width of the separator).
- CMenuDeskBar:
Create the window only in CMenuDeskBar::SetClient and not in SetSite.
Greatly simplify SetSite.
Make sure that WS_EX_TOPMOST isn't removed when we call SetWindowPos
Do not forward requests for the SID_SMenuPopup service to the taskbar as this causes the menu band to capture the mouse for the taskbar and not the desk bar
svn path=/branches/shell-experiments/; revision=62223
* A couple small fixes before I go to bed.
* Add to CD, so explorer_new can be run in ros, with the custom classes.
CORE-7886
svn path=/branches/shell-experiments/; revision=62156
* Add more missing code. The custom CMenuDeskBand is now able to show the contents of a CMenuSite/CMenuBand in the right size, including the banner (not yet fully functional).
* Organize the method list in CMenuSite by interface.
[EXPLORER-NEW]
* Revert the hacks from r62134.
[PSDK]
* Add IUnknown_QueryServiceExec to shlwapi_undoc.h
svn path=/branches/shell-experiments/; revision=62149
* Port the implementation of CMenuDeskBar to rshell (still disabled by default).
* Begin implementing missing features:
- Notify the band of the icon size change from SetIconSize.
svn path=/branches/shell-experiments/; revision=62138
* Remove from build while it hangs VS2013.
[EXPLORER-NEW]
* Hack it to work on Windows 7, even if an existing explorer is already running.
* Move start menu popup to its own function, for easier debugging.
* Maybe-fix a drawing issue if no theme is selected.
[RSHELL]
* Added wrapper for CMenuBand
* The cmake script should not use a hardcoded path
* Better name for the log file.
CORE-7886
svn path=/branches/shell-experiments/; revision=62134
* Separate the wrapper logging code to its own file, to facilitate further debugging in other classes.
svn path=/branches/shell-experiments/; revision=62133
* Implemented a class that wraps CMenuBand, for the purpose of logging the calls, with parameters and returned values (disabled, set WRAP_LOG to 1).
* Partial (WIP) implementation of CMenuBand.
[ATL]
* VirtualAlloc can not have a non-zero size while using MEM_RELEASE.
svn path=/branches/shell-experiments/; revision=62132
- Add a tiny hack in browseui that allows it to browse properly when the user tries to open a folder in win8
svn path=/branches/shell-experiments/; revision=62082
- Do not embed a manifest in the resources in order to allow three different scenarios that can be accomplished by using two manifests
- In the first scenario we have filebrowser.exe + filebrowser.exe.manifest in the same folder. This should work only in windows xp, 2003 and reactos as it depends on the browseui that exists in windows
- The second scenario is to have filebrowser.exe + filebrowser.exe.manifest + browseui.dll in the same folder. This should also work in the same platforms as above but the core of the file browser will be used from the supplied browseui. However browseui will also request to instantiate some com objects implemented in browse and as a result some objects will be used from the browseui that exists in windows
- The third scenario is to have filebrowser.exe + filebrowser.exe.regfree.manifest + browseui.dll + browseui.sxs.manifest. This scenario should work in windows xp and all later versions. Note that filebrowser.exe.regfree.manifest must be renamed to filebrowser.exe.manifest. In this scenario all the functionality of the file browser window is used from the supplied browseui.dll
svn path=/branches/shell-experiments/; revision=62081
- Fix atl thunks to be allocated in executable memory and not from the stack in order to run libraries that use atl (such as browseui) in windows with DEP enabled
svn path=/branches/shell-experiments/; revision=62011
- Implement showing and closing the start menu by pressing the WIN key
- Implement handling WM_KLUDGEMINRECT message that informs the window manager the place of an application in the taskbar in order to show the minimization or maximization animation of a window
- Implement showing taskbar settings when the user selects to show the taskbar settings from the settings menu in start menu
- Implement hiding the Favorites menu in the start menu when needed
svn path=/branches/shell-experiments/; revision=62010
- Add an experimental module called FileBrowser.exe. This program works standalone in windows xp and windows 2003 and opens a new file browser window in its own process. If our browseui.dll is in the same folder, filebrowser will use the implementation of our file browser in windows. That means that standalone it works only in xp and 2003 but with our own browseui it will work on all windows versions (but doesn't work on all for now). This can be used for both testing the implementation of our file browser in windows and as a host process for new file browser windows for explorer_new.exe + rshell.dll
svn path=/branches/shell-experiments/; revision=61974
- Commit a great experiment for explorer. Our explorer will try to load a library called rshell.dll which will provide an alternative implementation of some functions that are built in in windows shell. These functions are CStartMenu_Constructor, SHCreateDesktop, SHDesktopMessageLoop, WinList_Init and ShellDDEInit. Providing our own implementation for these functions will allow us to make it run in all windows versions up to windows 8 and also test the implementation of our own components that will be placed temporarily in rshell.dll while they are developed and debugged in windows.
svn path=/branches/shell-experiments/; revision=61971
MENUITEM "Acerca de Calculadora ReactOS", IDM_HELP_ABOUT
MENUITEM "Acerca de la Calculadora de ReactOS", IDM_HELP_ABOUT
END
END
@@ -418,7 +419,14 @@ END
STRINGTABLE
BEGIN
IDS_STRING_LICENSE "Calculadora ReactOS es software gratuito realizado bajo licencia GNU GPL.\r\n\r\nPuedes coger una copia de la licencia GNU GPL aquí:\r\nhttp://www.gnu.org/licenses/gpl.html\r\n\r\nPuedes también coger una traducción de la licencia GNU GPL aquí:\r\nhttp://www.gnu.org/licenses/translations.html"
IDS_STRING_LICENSE "La Calculadora de ReactOS es software libre realizado bajo licencia GNU GPL.\r\n\
\r\n\
Puedes obtener una copia de la licencia GNU GPL aquí:\r\n\
http://www.gnu.org/licenses/gpl.html\r\n\
\r\n\
También puedes obtener una traducción de la licencia GNU GPL aquí:\r\n\
IDS_LICENSE "This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version.\r\n\r\nThis program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details.\r\n\r\nYou should have received a copy of the GNU General Public License along with this program; if not, write to the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA."
IDS_LICENSE "Este programa es software libre; puedes redistribuirlo y/o modificarlo bajo los términos de la GNU General Public License tal y como se publica por la Free Software Foundation; ya sea la versión 2 de la Licencia, o (bajo tu discreción) cualquier versión posterior.\r\n\r\nEste programa se distribuye con el fin de ser útil, pero viene SIN NINGUNA GARANTÍA; sin tan siquiera la garantía implícita de COMERCIALIZACIÓN o la de IDONEIDAD PARA UN PROPÓSITO CONCRETO. Para más información lee la GNU General Public License.\r\n\r\nDeberías de haber recibido una copia de la GNU General Public License con el programa; si no, puedes escribir a la Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 EE.UU."
LTEXT "Hartă a caracterelor v0.1\nDrept de autor (C) 2007 Ged Murphy (gedmurphy@reactos.org)\nTraducere de Ștefan Fulea (stefan.fulea@mail.md)", IDC_STATIC, 48, 7, 210, 36
LTEXT "Hartă de caractere v0.1\nDrept de autor (C) 2007 Ged Murphy (gedmurphy@reactos.org)\nTraducere de Ștefan Fulea (stefan.fulea@mail.md)", IDC_STATIC, 48, 7, 210, 36
IDS_LICENSE "Această aplicație este publică; fiind permisă modificarea și/sau (re)distribuția sa în termenii Licenței Publice Generale GNU publicată de Free Software Foundation; sau versiunea 2 a Licenței, sau (la alegere) a oricărei versiuni ulterioare.\r\n\r\nAceastă aplicație este distribuită doar în speranța de a fi utilă, FĂRĂ însă NICI O GARANȚIE; nici măcar cu garanția implicită a VANDABILITĂȚII sau a UTILITĂȚII ÎNTR-UN SCOP ANUME. Pentru mai multe detalii consultați Licența Publică Generală GNU.\r\n\r\nPuteți vedea această licență aici:\r\nhttp://www.gnu.org/licenses/gpl.html\r\n\r\nDe asemenea puteți consulta traduceri neoficiale ale acestei licențe aici:\r\nhttp://www.gnu.org/licenses/translations.html"
IDS_LICENSE "ÖNEMLİ: Aşağıdaki metin, özgün metnin resmî olmayan çevirisidir. Çeviri metniyle özgün metin arasında ayrım olabilir. Özgün metin, çeviri metninin altındadır.\r\n\r\n***\r\n\r\nBu izlence özgür yazılımdır; bunu, Özgür Yazılım Vakfı'nın yayımladığı GNU Umûmî Kamu Ruhsatı'nın, 2. sürümünün ya da daha sonraki bir sürümünün (Orası size bağlı.) koşulları altında yeniden dağıtabilir veyâ değiştirebilirsiniz.\r\n\r\nBu izlence, kullanışlı olabileceği beklentisiyle dağıtılmıştır ancak bu izlencenin HİÇBİR GÜVENCESİ YOKTUR, SATILABİLİRLİĞİN ve BELİRLİ BİR AMACA UYGUNLUĞUN demek istenilen güvencesi bile. Daha çok bilgi için GNU Umûmî Kamu Ruhsatı'na bakınız.\r\n\r\nBu izlenceyle birlikte GNU Umûmî Kamu Ruhsatı'nın bir kopyasını almış olmalısınız, eğer yoksa Özgür Yazılım Vakfı AŞ'ye (51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 ABD) yazınız.\r\n\r\n***\r\n\r\nThis program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version.\r\n\r\nThis program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details.\r\n\r\nYou should have received a copy of the GNU General Public License along with this program; if not, write to the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA."
IDS_LICENSE "ÖNEMLİ: Aşağıdaki metin, özgün metnin resmî olmayan çevirisidir. Çeviri metniyle özgün metin arasında ayrım olabilir. Özgün metin, çeviri metninin altındadır.\r\n\r\n***\r\n\r\nBu izlence özgür yazılımdır; bunu, Özgür Yazılım Vakfı'nın yayımladığı GNU Umûmî Kamu Ruhsatı'nın, 2. sürümünün ya da daha sonraki bir sürümünün (Orası size bağlı.) şartları altında yeniden dağıtabilir veyâ değiştirebilirsiniz.\r\n\r\nBu izlence, kullanışlı olabileceği beklentisiyle dağıtılmıştır ancak bu izlencenin HİÇBİR GÜVENCESİ YOKTUR, SATILABİLİRLİĞİN ve BELİRLİ BİR AMACA UYGUNLUĞUN demek istenilen güvencesi bile. Daha çok bilgi için GNU Umûmî Kamu Ruhsatı'na bakınız.\r\n\r\nBu izlenceyle birlikte GNU Umûmî Kamu Ruhsatı'nın bir kopyasını almış olmalısınız, eğer yoksa Özgür Yazılım Vakfı AŞ'ye (51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 ABD) yazınız.\r\n\r\n***\r\n\r\nThis program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version.\r\n\r\nThis program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details.\r\n\r\nYou should have received a copy of the GNU General Public License along with this program; if not, write to the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA."
IDS_USAGE "\nEntrez ""CLIP /?"" pour afficher la syntaxe.\n"
IDS_HELP "\nRedirige la sortie des programmes en ligne de commande vers le Presse-Papiers.\n\n\
CLIP [/?]\n\n\
/? Affiche ce message d'aide.\n"
END
Some files were not shown because too many files have changed in this diff
Show More
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
