mirror of
https://github.com/systemd/systemd
synced 2025-10-05 16:03:15 +02:00
1c9500c2b7
This adds TTYReset=yes to all units which run directly on the TTY. We already had this in place for the gettys, but this adds it for the rest that basically has StandardInput=tty + StandardOutput=tty set. Originally, for these tools it wasn't necessary to reset the TTY, because we after all already reset /dev/console very very early on once, during PID1's early initialization, and hence there's no real reason to do it again for these early boot services. But that's actually not right, because since #36666 the TTY we reset from PID 1 is typically /dev/console but the TTY those services are invoked on is typically the resolved version of that, i.e. wherever that points. Now you might think: if one is just an alias to the other, why does it matter to reset this again? Well, because it's only a half-assed alias, and as it turns out WIOCSWINSZ is not propagated from one to the other, i.e the terminal dimesions we initialize for /dev/console don't propagate to whatever that points to. One option to address that would be to immediately propagate this down ourselves (or to fix the kernel for it), but it felt safer to simply do the reset again before the use, after all these one one-off services, and there's no point in optimizing much here. Moreover, its probably safer to give the guarantee that when the firstboot stuff (which after all queries for pws to set) runs it definitely certainly guaranteed has a properly reset terminal.
29 lines
976 B
SYSTEMD
29 lines
976 B
SYSTEMD
# SPDX-License-Identifier: LGPL-2.1-or-later
|
|
#
|
|
# This file is part of systemd.
|
|
#
|
|
# systemd is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU Lesser General Public License as published by
|
|
# the Free Software Foundation; either version 2.1 of the License, or
|
|
# (at your option) any later version.
|
|
|
|
[Unit]
|
|
Description=Storage Target Mode (NVMe-TCP)
|
|
Documentation=man:systemd-storagetm.service(8)
|
|
ConditionVirtualization=!container
|
|
DefaultDependencies=no
|
|
Wants=modprobe@nvmet_tcp.service modprobe@thunderbolt_net.service sys-kernel-config.mount
|
|
After=modprobe@nvmet_tcp.service modprobe@thunderbolt_net.service sys-kernel-config.mount plymouth-start.service systemd-pcrphase-storage-target-mode.service
|
|
Conflicts=shutdown.target
|
|
Before=shutdown.target
|
|
FailureAction=reboot
|
|
SuccessAction=reboot
|
|
|
|
[Service]
|
|
Type=notify
|
|
RemainAfterExit=yes
|
|
StandardInput=tty
|
|
StandardOutput=tty
|
|
TTYReset=yes
|
|
ExecStart={{LIBEXECDIR}}/systemd-storagetm --all
|