mirror of
https://github.com/TeamNewPipe/website
synced 2025-10-06 00:22:38 +02:00
Post-blog-post-posting review (0.22.0)
Sorry about the big additions, I couldn't help myself. :)
This commit is contained in:
@@ -9,7 +9,7 @@ image: newpipe
|
||||
excerpt_separator: <!-- more -->
|
||||
---
|
||||
|
||||
Oh wow would you look at the time. Happy new year from the NewPipe team! We are "starting 2022 off" with some great additions: YouTube-like rewind/fast-forward, pinned comments, and searchable preferences!
|
||||
Oh wow, would you look at the time! Happy new year from the NewPipe team! We are "starting 2022 off" with some great additions: YouTube-like rewind/fast-forward, pinned comments, and searchable preferences!
|
||||
|
||||
Apart from these, we have a bucket-load of fixes and improvements that will hopefully make your NewPipe experience better than ever.
|
||||
|
||||
@@ -28,7 +28,7 @@ This blog post is dedicated to the master meister [@litetex](https://github.com/
|
||||
<figcaption class="text-center">Look at the pin. LOOK AT IT!</figcaption>
|
||||
</figure>
|
||||
|
||||
- The big change for this release will be very obvious to you the moment you double tap to seek on a video. We now have YouTube-like rewind and fast-forward behaviour! Apart from the cool looking visuals, what this means is that you don't have to keep furiously double tapping to execute every single jump in time. Instead, you initiate the action with a double tap, and then every single tap after that executes another jump in time. This 'single tap window' lasts until the animation finishes, after which you have to double tap to initiate another one. This huge quality-of-life improvement to seeking was brought to you by [@vkay94](https://github.com/vkay94). The PR was kept up to date by [@Stypox](https://github.com/Stypox), and then finally pushed across the finish line by [@litetex](https://github.com/litetex). Thanks to everyone involved in this major effort!
|
||||
- The big change for this release will be very obvious to you the moment you double tap to seek on a video. We now have YouTube-like rewind and fast-forward behaviour! Apart from the cool visuals, what this means is that you don't have to keep double-tapping furiously to execute every single jump in time. Instead, you initiate the action with a double tap, and then every single tap after that executes another jump in time. This 'single tap window' lasts until the animation finishes, after which you have to double tap to initiate another one. This huge quality-of-life improvement to seeking was brought to you by [@vkay94](https://github.com/vkay94). The PR was kept up to date by [@Stypox](https://github.com/Stypox), and then finally pushed across the finish line by [@litetex](https://github.com/litetex). Thanks to everyone involved in this major effort!
|
||||
|
||||
<figure class="center">
|
||||
<img src="{{ site.baseurl }}/img/screenshots/new_seek.png" class="img-responsive">
|
||||
@@ -40,13 +40,13 @@ This blog post is dedicated to the master meister [@litetex](https://github.com/
|
||||
|
||||
### Improved
|
||||
|
||||
- Are you tired of the toast notifications telling you that an error occurred, but having no idea what happened, or how to report that error? Well, in addition to the error report page and the error snackbar at the bottom, now NewPipe has a third way to show errors: it generates a silent system notification. You just need to tap on it to report the error to us, all thanks to [@Stypox](https://github.com/Stypox), who also took the opportunity to restructure and improve the rest of the error reporting related code.
|
||||
- Are you tired of the toast notifications telling you that some sort of player error occurred, but having no idea what happened, or how to report that error? Well, in addition to the error report page and the error snackbar at the bottom, now NewPipe has a third way to show errors: it generates a silent system notification. You just need to tap on it to report the error to us, all thanks to [@Stypox](https://github.com/Stypox), who also took the opportunity to restructure and improve the rest of the error-reporting-related code.
|
||||
|
||||
- [@litetex](https://github.com/litetex) implemented another improvement to error handling: If the app tried to open a file manager, but no SAF-compatible file manager was found, NewPipe just crashed. Now it tells you what went wrong and how to fix it.
|
||||
|
||||
- Based on feedback from an accessibility-enabled user, [@litetex](https://github.com/litetex) stopped screen readers from telling you over and over and over again that there is a "Video preview thumbnail" when scrolling through lists.
|
||||
|
||||
- We got another improvement for people with slow Internet or those facing a period of poor connection. The player used to "close with an error" (speak: crash) if the player took too long to buffer during a livestream. This happened because it just fell too far behind the edge of the livestream. To fix and improve this, [@TiA4f8R](https://github.com/TiA4f8R) implemented a two-fold change. The first was to increase the time period before the player is considered to have fallen too far behind, and the second was to simply drop the current play time and jump ahead to the edge of the livestream, skipping the un-buffered section entirely. No more player crashes! Never! Right guys?
|
||||
- We've got another improvement for people with slow Internet or those facing a period of poor connection. The player used to "close with an error" (read: crash) if it took too long to buffer during a livestream. This happened because it just fell too far behind the edge of the livestream. To fix and improve this, [@TiA4f8R](https://github.com/TiA4f8R) implemented a two-fold change. The first was to increase the time period before the player is considered to have 'fallen too far behind', and if that still happens, the second was to simply drop the current play time and jump ahead to the edge of the livestream, skipping the un-buffered section entirely. No more player crashes! Never! Right guys? Right.
|
||||
|
||||
### Fixed
|
||||
|
||||
@@ -56,7 +56,7 @@ This blog post is dedicated to the master meister [@litetex](https://github.com/
|
||||
|
||||
- When a video link was opened with a timestamp URL parameter that had more than 3 digits, NewPipe ignored the 4th and higher digits. This meant that the app took you to the wrong timestamp. For example, 1001 seconds (16 minutes and 41 seconds) would be parsed as 1 second instead. [@mhmdanas](https://github.com/mhmdanas) has fixed this.
|
||||
|
||||
- [@Stypox](https://github.com/Stypox) fixed many different crashes where the code expected the player's queue to be not `null` but it was, indeed, `null`.
|
||||
- [@Stypox](https://github.com/Stypox) fixed many different crashes where the code expected the player's queue to be `not null`, but where it was, you guessed it, `null`.
|
||||
|
||||
- [@Cheechaii](https://github.com/Cheechaii) introduced #respect into the app. Now the player respects display cutouts (like notches) when playing in multi-window mode, whereas previously, black bars were shown.
|
||||
|
||||
@@ -64,7 +64,7 @@ This blog post is dedicated to the master meister [@litetex](https://github.com/
|
||||
|
||||
- [@Jaspann](https://github.com/Jaspann), in their second contribution, fixed showing the PeerTube-specific sub-channel icon on non-PeerTube services, where it makes no sense.
|
||||
|
||||
- Sometimes, the keyboard would stop working when using the search field after the video page was closed, no matter how hard you smashed the keys. [@litetex](https://github.com/litetex) has fixed this to prevent you from damaging your screen. Not really their first/second contribution to the project, but a welcome one nonetheless.
|
||||
- Sometimes, the keyboard would stop working when using the search field after the video page was closed, no matter how hard you smashed the keys. [@litetex](https://github.com/litetex) has fixed this to prevent you from damaging your screen. Not really their first or second contribution to the project, but a welcome one nonetheless.
|
||||
|
||||
- When items were added to the queue using the long-press menu in lists, it was clear that there was some info missing when the queue was opened. This is because the full stream info was loaded only when its page was opened. Thanks to [@Douile](https://github.com/Douile), now the complete stream info is loaded when it is added to the queue from a list.
|
||||
|
||||
@@ -84,25 +84,24 @@ This blog post is dedicated to the master meister [@litetex](https://github.com/
|
||||
|
||||
- [@litetex](https://github.com/litetex) fixed the broken link of the "Get it on F-Droid" button in the English README on GitHub, and reduced its size to a sane value in all the translated READMEs.
|
||||
|
||||
|
||||
- Talking about broken links, [@TobiGr](https://github.com/TobiGr) fixed a link in the English README linking to the Portuguese README.
|
||||
|
||||
- [@albertomosconi](https://github.com/albertomosconi) moved the translated README files into the `doc` folder, and updated the links accordingly.
|
||||
- [@albertomosconi](https://github.com/albertomosconi) moved the translated README files into the `doc` folder to reduce visual clutter in the repo, and updated the links accordingly.
|
||||
|
||||
## Nerd Talk
|
||||
|
||||
- Dependabot updated spotbugs-annotations from 4.5.0 to 4.5.3.
|
||||
- Dependabot updated spotbugs-annotations from 4.5.0 to 4.5.3. What happened, dependabot? Just one update? You're getting lazy these days. Tut tut tut! (Pro tip: you can make fun of robots all day, because it's not like they can ever retaliate, right? Probably. At least, we think so... Okay, maybe this wasn't such a good idea... ACK! Why does that toaster suddenly have four legs!? Stay away! STAY AWAY!)
|
||||
|
||||
- [@litetex](https://github.com/litetex) disabled an unreliable test for the SoundCloud stream extractor. Who even needs tests? (Just kidding, they're a cornerstone of good programming. ~~Eat your broccoli~~ Write your unit tests, kids.)
|
||||
|
||||
- [@XiangRongLin](https://github.com/XiangRongLin) ensured that search history entries in tests are in the correct order, fixing the sometimes-failing-sometimes-passing CI pipeline. Remember what we said about tests above, they are important!
|
||||
- [@XiangRongLin](https://github.com/XiangRongLin) ensured that search history entries in tests are in the correct order, fixing the sometimes-failing-sometimes-passing CI pipeline. Keep in mind what we said about tests above, they are important!
|
||||
|
||||
- YouTube removed the public dislike data [in December](https://support.google.com/youtube/thread/134791097/update-to-youtube-dislike-counts), so we used a temporary workaround by calculating the dislikes using the average rating. But now that that is gone too, [@litetex](https://github.com/litetex) removed the code used to extract YouTube dislikes, and made several other improvements:
|
||||
- Fixed the exception caused when a video had zero likes.
|
||||
- De-duplicated a large amount of code in the service-specific stream extractors by using methods common to all of them.
|
||||
- Also changed the YouTube extractor tests to reflect the removal of the dislike count (we really like tests!).
|
||||
- Also changed the YouTube extractor tests to reflect the removal of the dislike count (we really like tests! No, we're not related to Hermione Granger in any way, but thanks for asking).
|
||||
|
||||
- [@litetex](https://github.com/litetex), while touching the dislike tests, migrated the unit tests from JUnit 4 to JUnit 5, and changed related code accordingly.
|
||||
- [@litetex](https://github.com/litetex), while modifying the dislike tests, migrated the unit tests from JUnit 4 to JUnit 5, and changed related code accordingly.
|
||||
|
||||
- [@TacoTheDank](https://github.com/TacoTheDank) came in with the usual whirlwind of library updates and associated changes. The biggest change here is that we now compile with Java 11 (because we compile on SDK 30). This is a good thing... we think. (We hope.) Other than that:
|
||||
- Sonarqube: 3.1.1 -> 3.3
|
||||
@@ -124,9 +123,9 @@ This blog post is dedicated to the master meister [@litetex](https://github.com/
|
||||
|
||||
- [@TobiGr](https://github.com/TobiGr) made some small improvements to code quality and readability here and there.
|
||||
|
||||
- [@litetex](https://github.com/litetex) configured the CI to upload test reports when an error occurs, because the truncated stacktrace shown by default doesn't provide enough info sometimes.
|
||||
- [@litetex](https://github.com/litetex) configured the CI to upload test reports when an error occurs in CI runs, because the truncated stacktrace shown by default doesn't provide enough info sometimes.
|
||||
|
||||
- [@XiangRongLin](https://github.com/XiangRongLin) switched the JUnit asserts with AssertJ ones in `HistoryRecordManagerTest` to obtain more detailed error messages, and converted the `SearchHistoryEntry` Java class to a Kotlin data class for the same reason.
|
||||
- [@XiangRongLin](https://github.com/XiangRongLin) switched the JUnit asserts to AssertJ ones in `HistoryRecordManagerTest` to obtain more detailed error messages, and converted the `SearchHistoryEntry` Java class to a Kotlin data class for the same reason.
|
||||
|
||||
- [@mhmdanas](https://github.com/mhmdanas) fixed a false Android Studio warning.
|
||||
|
||||
@@ -136,9 +135,9 @@ This blog post is dedicated to the master meister [@litetex](https://github.com/
|
||||
|
||||
- [@Poussinou](https://github.com/Poussinou) added a link to the donation section of the NewPipe website to the Sponsors section on the GitHub repo.
|
||||
|
||||
- [@mhmdanas](https://github.com/mhmdanas) made a minor edit to the License section of the README to make it more readable. Because that's what the README is for. Reading. In case that wasn't clear yet.
|
||||
- [@mhmdanas](https://github.com/mhmdanas) made a minor edit to the License section of the README to make it more readable. Because that's what the README is for. Reading. In case that wasn't clear.
|
||||
|
||||
- [@mhmdanas](https://github.com/mhmdanas) made another minor edit, this time to the trigger file of the CI workflow, so it doesn't run unnecessarily.
|
||||
- [@mhmdanas](https://github.com/mhmdanas) made another minor edit, this time to the trigger file of the CI workflow, so it doesn't run unnecessarily. (NO, CI, the app won't suddenly break if someone makes a spelling error in a README. Stop running pointless tests!)
|
||||
|
||||
## Where to get this brand-new version
|
||||
|
||||
|
Reference in New Issue
Block a user