eUgEntOptIc44/gimp
1
1
Fork 0
mirror of https://gitlab.gnome.org/GNOME/gimp.git synced 2025-10-05 21:02:42 +02:00
Code Issues Releases Activity

Issue #14878: fix missing spin boxes in Map to Object plug-in

Browse Source 
Light position spin boxes in Map to Object could be missing
or shown when they shouldn't be due to reuse of a variable.

Fixes #14878
This commit is contained in:
Anders Jonsson
2025-09-14 13:19:03 +02:00
committed by Alx Sa
parent c8971ac2ae
commit cb565344e9
1 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
plug-ins/map-object/map-object-ui.c
View File

@@ -24,6 +24,7 @@ static GtkWidget *appwin = NULL;
static GtkNotebook *options_note_book = NULL;
static GtkWidget *pointlightwid;
static GtkWidget *viewpointlightwid;
static GtkWidget *dirlightwid;
static GtkWidget *sphere_page = NULL;
@@ -110,16 +111,19 @@ lightmenu_callback (GimpProcedureConfig *config)
{
gtk_widget_set_visible (dirlightwid, FALSE);
gtk_widget_set_visible (pointlightwid, TRUE);
gtk_widget_set_visible (viewpointlightwid, TRUE);
}
else if (light_type == DIRECTIONAL_LIGHT)
{
gtk_widget_set_visible (dirlightwid, TRUE);
gtk_widget_set_visible (pointlightwid, FALSE);
gtk_widget_set_visible (viewpointlightwid, FALSE);
}
else
{
gtk_widget_set_visible (dirlightwid, FALSE);
gtk_widget_set_visible (pointlightwid, FALSE);
gtk_widget_set_visible (viewpointlightwid, FALSE);
}
if (mapvals.livepreview)
@@ -537,7 +541,6 @@ main_dialog (GimpProcedure *procedure,
g_signal_connect (config, "notify::light-position-z",
G_CALLBACK (update_preview),
config);
lightmenu_callback (config);
/* Viewpoint Tab */
gimp_procedure_dialog_get_label (GIMP_PROCEDURE_DIALOG (appwin),
@@ -551,10 +554,10 @@ main_dialog (GimpProcedure *procedure,
NULL);
gtk_orientable_set_orientation (GTK_ORIENTABLE (hbox),
GTK_ORIENTATION_HORIZONTAL);
pointlightwid = gimp_procedure_dialog_fill_frame (GIMP_PROCEDURE_DIALOG (appwin),
"viewpoint-position-frame",
"viewpoint-position-label", FALSE,
"viewpoint-position-box");
viewpointlightwid = gimp_procedure_dialog_fill_frame (GIMP_PROCEDURE_DIALOG (appwin),
"viewpoint-position-frame",
"viewpoint-position-label", FALSE,
"viewpoint-position-box");
gimp_procedure_dialog_get_scale_entry (GIMP_PROCEDURE_DIALOG (appwin),
"first-axis-x", 1.0);
@@ -636,6 +639,7 @@ main_dialog (GimpProcedure *procedure,
g_signal_connect (config, "notify::second-axis-z",
G_CALLBACK (update_preview),
config);
lightmenu_callback (config);
/* Material Tab */
gimp_procedure_dialog_get_label (GIMP_PROCEDURE_DIALOG (appwin),