The number of colors in an image shouldn't be higher than the number of
colormap entries. Additionally, consolidate post error cleanup in
load_image().
(cherry picked from commit f597355beffd9e483e11407d4c3b56f32db3634d)
Conflicts:
plug-ins/common/file-xwd.c
Applied and enhanced patch from andres which makes file-xwd detect
this kind of file corruption and abort loading with an error message.
(cherry picked from commit 0b35f6a082)
Ran non-interactively, file-cel could crash e.g. if loading an image to
generate a thumbnail, because there is no way to specify a palette file
in that case.
(cherry picked from commit 96ce2c936d)
Cherry picked from commit 76155d79df.
gimp-2-6 is no longer maintained. But we might as well commit this for
the benefit of EL/LTS distros. This patch hasn't even been compiled, so
YMMV. Enjoy.
If there's a version mismatch between compiled version (header) and
installed shared libpng library, structs are not created and NULL is
returned.
(cherry picked from commit 1ac6c7b85c)
According to the bug, Debian enforces
-Wformat-security and -Werror=format-security, which is a good thing.
Most of these patches are already in master, but I'll check master
anyway.
Using G_OPTION_FLAG_NO_ARG with G_OPTION_ARG_NONE is not a valid combination,
glib 2.28.2 warns about it.
(gimp:20379): GLib-WARNING **: goption.c:2132: ignoring no-arg, optional-arg or filename flags (8) on option "debug-handlers" of type 0
(cherry picked from commit b81276ca83)
In gimp_display_shell_drop_uri_list(), shell->display is dereferenced in
some places without checking that it's still there. It can be set to
NULL if the user quits the application while a drag and drop action is
being processed and the main loop is iterated during execution of this
function. (Bug #652280)
(cherry picked from commit b1a2c736bf)
Conflicts:
app/display/gimpdisplayshell-dnd.c
* fixes issues with poppler 0.17 completely
* uses new libgimp API to pass surfaces instead of pixbufs
* uses GTK+ 3 API to convert surfaces to pixbufs where available
(backported from commit 7bdadd80ba)
If a moveto is followed by multiple pairs of coordinates, the
subsequent pairs are supposed to be treated as implicit lineto
commands.
The parser used to ignore this part of the SVG specification and
treated subsequent pairs of coordinates as moveto commands (which
is correct in general, but for moveto commands there is this
explicit exception of the general rule).
(cherry picked from commit beef765b4f)
Move the g_signal_emit() to the end, because the cell->renderer could
be changed and cause a segfault. Also check cell->renderer before
dereferencing it.
(cherry picked from commit ff03681bdf)
plug-ins/script-fu/scheme-wrapper.c:
- Fixed set and get of UTF-8 coded strings for parasites using slightly
modified version of a patch from Massimo.
plug-ins/script-fu/tinyscheme/scheme.c:
- Additional fix to string-append and fixed substring. The mk_empty_string
routine is not the way to allocate space for UTF-8 coded strings.
- Added some comments.
(Cherry picked of commit b0d8ba5ffd)
At end of a double quoted string, readstrexp() passed byte count instead
of character count to mk_counted_string(). Cleaned up basic_inchar().
It ignores bad UTF-8 coded characters when reading from file or buffer.
Fixed string-set! and string-append due to mixup of chars vs. bytes.
Fixed calculation of pointer to past end of string in open-*-string
routines.
(Cherry picked of commit d06a4ee4c3)
Fix for nasty gc bug. This change shifts the burden of protecting newly
allocated cells in foreign functions from the foreign functions to the
TinyScheme interpreter.
(cherry pick of commit 28e7c3f612)
gimp_plug_in_handle_proc_return(): if there is no plug-in main loop
running (the plugin was running asynchronously from a menu), show the
plug-in's error message here, because nobody else will show it
otherwise.
(cherry picked from commit bdc2d4520b)
Added G_SPAWN_STDOUT_TO_DEV_NULL and G_SPAWN_STDERR_TO_DEV_NULL to the
g_spawn_sync () flags. According to Tor Lillqvist this won't fix the bug,
but the GLib docs state that these flags have to be added if stdout and
stderr are set to NULL.
The CMYK Decompose/Recompose plugin used its own (faulty) algorithm
for RGB<->CMYK conversions. This fix changes the plugin to use the
conversion routines provided by libgimpcolorspace.
Call cairo_surface_flush() before reading or writing a surface's
pixels directly, and use cairo_surface_mark_dirty() after writing
pixels directly, so we don't read old pixels, and our written pixels
get actually used.
(manually cherry-picked from fad6053643)
The "hue" parameter from the PDB is in a [-180..180] range, not in
[-100..100]. Note that unlike stated in the bug, this is not an
incompatible change, because it simply got broken between 2.4 and
2.6.
(cherry picked from commit 2813fce0b8)
Don't cancel the popup in grab_notify() if the popup's grab was
shadowed by one of the widgets in the popup, like the scrollbar.
(cherry picked from commit 991210c0f9)
When we are going to open new image windows, unset the transient
window. We don't need it since we will use gdk_window_raise() to
keep the dialog on top. And if we don't do it, then the dialog
will pull the image window it was invoked from on top of all the
new opened image windows, and we don't want that to happen.
Patch heavily inspiried by hack from Massimo Valentini.
Fix totally broken value ranges of integer PDB parameters. Magically,
the bug was affecting only exactly the two cases mentioned in above
bug report.
* tools/pdbgen/pdb.pl (arg_parse): return <, <=, > and >= literally
instead of applying a mapping that was originally meant for
generated C code that would e.g. transform "0 <= int32 < 10" into
"if (value < 0 || value >= 10) fail". This inversion of all
operators is now wrong because PDB parameters have been turned into
GParamSpecs which always need inclusive ranges as min and max
values.
* tools/pdbgen/pdbgen.pl (arrayexpand): generated array length type
specs must be "0 <= int32", not "0 < int32".
* tools/pdbgen/app.pl: when generating integer param specs, check if
the value range is specified in terms of < instead of <=, and
add/subtract 1, resuting in the inclusive range needed for integer
GParamSpecs.
* app/pdb/color-cmds.c: regenerated, fixing the two broken ranges
mentioned in the bug report.
(cherry picked from commit 9dd373d86e)
Applied changes from CVS version 1.24 of official version of TinyScheme.
Merged redundant list_length, is_list, OP_LISTP code.
(backport of commit 4c862bf678)
Don't overwrite the entire context part of all tool options with
values from contextrc, or we will end up with one tool option set to a
non-default values affecting all other tool options that were at their
default value in the next gimp session.
(cherry picked from commit 547c92d0f6)
Allocate buffers with some extra padding as the MMX instructions
used in matrixmult_mmx() may read more than strictly necessary.
(cherry picked from commit cbb815c203)
gimp_paint_core_finish(): when bailing out early because nothing was
painted (e.g. because we repeatedly shift-click on the same pixel,
which doesn't advance the interpolation distance), don't forget to
call gimp_viewable_preview_thaw() or the drawable preview will be
frozen forever.
(cherry picked from commit c55753f2ad)
Move calling gimp_plug_in_shm_free() from gimp_plug_in_manager_finalize()
to gimp_plug_in_manager_exit() so it's also called in stable GIMP
releases which simply call exit() at some point instead of taking the
time to shut down everything completely.
(cherry picked from commit 9a4bf10d30)
Sobel doesn't work on layers with transparency, like text layers, so
the text layer in the chalk script needed to be merged with the
background layer beneath it.
gimp_display_shell_get_*_coord(): initialize the coords with
GIMP_COORDS_DEFAULT_VALUES allGimpCoords members get initialized.
(cherry-picked from 74bf91cb63)
Use png_set_expand_gray_1_2_4_to_8() instead of the deprecated
png_set_gray_1_2_4_to_8() if libpng is at least 1.2.27 (which is in
debian stable), so plug-ins built against old versions contine to work
when libpng 1.4 gets installed.
The functions read_rle8() and read_rle16() didn't check if the addresses
to which they wrote are in bounds when expanding runlength encoded data.
(cherry picked from commit 4d9724f2f6)
In order to avoid overflows when calculating needed memory, cast the
first variable used into a large enough type so the whole calculation is
done in that type.
(cherry picked from commit 838be627be)
Make sure we never call gimp_free_select_tool_remove_last_segment()
with priv->n_segment_indices being negative, and increase robustness
of the code in general.
Note that we always halt the tool when backspace is pressed and there
are no vertices left. This is to minimize the risk of ending up in an
invalid tool state.
(cherry picked from commit c7a5195bdf)
Revert commits bc099a98f3 and
c77781de89 from Jul 27 2006;
also changed refval boundaries of the "width" size entries
in the spirit of the original fix, only reversed.
Rationale: the "horizontal" parameters all have to affect the
horizontal *lines*, so have an effect in *vertical* direction.
Will commit a label change on top to clarify this.
(cherry picked from commit 028b66beba)
Use an equivalent division instead of multiplying values and checking if
they are more than G_MAXINT32, because divisions cannot overflow.
(cherry picked from commit f63ba36dd9)
Explicitly check that Bitmap_Head.biHeight is not G_MININT32
instead of relying on ABS(G_MININT32) being negative.
(cherry picked from commit 43d57c6663)
The code used to make the assumption that the selection mask was
a layer. Actually it is a channel and changing the code accordingly
fixes the reported problem.
(cherry picked from commit 474b5fdff3)
When a color gets set on the module via GimpColorSelector::set_color(),
make sure that the result of its transformation to CMYK doesn't
get set back on GIMP. Also, when the color profile changes, make
sure we only re-transform the RGB value to CMYK and don't set that
result back on GIMP either.
(cherry picked from commit 659cf3743e)
As pointed out by Massimo Valentini in bug #519503, the code used
height where width should have been used. Correct.
(cherry picked from commit f7ff0903ff)
(gimp_layer_tree_view_mask_update): call
gimp_layer_tree_view_update_borders() unconditionally; not only when a
mask has been added, but also when it has been removed.
(cherry picked from commit 098a0e4491)
The dock needs to listen to image changes in the context and not only
display changes since the introduction of the empty-image-window does
not cause any display changes when creating the first image.
Don't blindly fill the dest region's alpha channel even if it has
none. Fixes longstanding bug that made things without alpha dropped
to indexed images to arrive broken.
(cherry picked from commit 0c57e8c68e)
It doesn't make sense to store image-specific settings such as resolution
and offsets in the global print-settings file. Only store them in the
image parasite, but remove them before saving the print-settings file.
(cherry picked from commit 9464d303a9)
Add "577581 – Crashes when using any colors tool/function on Windows"
to NEWS. Even though it didn't involve a fix in the GIMP code base it
still has informational value.
Add "589667 – GIMP crashes when clicking GEGL Operation on Windows" to
NEWS. Even though it didn't involve a fix in the GIMP code base it
still has informational value.
Use the passed parameters if the quality setting is 0.01 or greater
instead of rejecting values below 0.05 in non-interactive mode.
(cherry picked from commit fc979283de)
It appears that there are good reasons why a user might want to save
a clean image, for example because the file has been deleted or damaged.
(cherry picked from commit 5c630f4ad8)
Remove a conditional so that, in interactive mode, the Send by E-mail
feature always uses the name of the file as the default file field
value, instead of using the previously entered value of the field.
Make sure to always call rebuildlist() after reseting, including after
interactively clicking the Reset button. Also, we don't need to
restartrender() after rebuildlist() calls since that is done last in
rebuildlist() itself.
'mng_putchunk_plte' and 'mng_putchunk_trns' both copy the array passed in
as if it was full size even when it is only partly used. This commit wraps
their calls passing the arrays dimensioned correctly.
In function 'respin_cmap', when 'find_unused_ia_colour' returns an index
suitable for transparency the number of colors in the colormap, the
following loop used to access three values beyond the end of the array
'before'.
Finally fix a typo in a call to mng_putchunk_text().
(cherry picked from commit e0f21468d4)
The history menus located at the back and forward buttons stopped working
after a webkit update some time ago. With these changes the menus work
again, at least with recent webkit releases.
(cherry picked from commit 02960ed3bd)
The problem is that the parser adds an empty property value when
parsing an empty Alt-array, "<rdf:Alt/>".
But when it is encoded it is expected to be in the form of a NULL
terminated array of pairs of property values, with the result that the
NULL terminator is considered the second element of the first pair and
the loop encoding these properties goes beyond the end of the array,
thus dereferencing invalid pointers.
This commit alters the parser to avoid adding dummy values when empty
rdf:Alt, rdf:Bag and rdf:Seq elements are found.
Fix an oversight: only the first tEXt chunk of a PNG was considered,
though repeatedly, when looking for the comment.
(cherry picked from commit 65c21b6bc3)
The plug-in makes use of a GimpPixelFetcher to access the source image.
And a GimpPixelFetcher in its default state only returns pixels inside
the bounding box of the selection. Setting its edge-mode to whatever
but GIMP_PIXEL_FETCHER_EDGE_NONE allows to read pixels outside of the
selection.
(cherry picked from commit 34ccca92a5)
Always initialize the 'status' member of a newly allocated cairo_path_t
to the value CAIRO_STATUS_SUCCESS as required to successively call
cairo_append_path().
(cherry picked from commit 5be4f235a3)
the image and the up or down arrow is pressed.
Applied patch from Massimo as found in bug #567393. This changes ROUND()
to RINT() to correct rounding for negative numbers. Also did this change
in gimp_rectangle_tool_adjust_coord().
(cherry picked from commit 05537763ef)
Not all actions have procedures associated with them, for example
unused "plug-in-recent-[N]" actions, so check for NULL before we
invoke the plug-in action
(gimp_drawable_transform_affine)
(gimp_drawable_transform_flip)
(gimp_drawable_transform_rotate): also transform the layer mask if we
are transforming a layer and there is no selection (which causes the
entire layer to be transformed).
at each new GIMP session
Do not store the number of copies in the print-settings resource file,
but keep it in the print-settings that are attached to the image.
(cherry picked from commit af965d82dd)
g_parse_debug_string() has special treatment of the string 'help',
but we want to use it for the GIMP_LOG_HELP domain.
(cherry picked from commit a427213fb8)
The version checks for babl and GEGL did not cope correctly with the
minor version upgrade. This change fixes this by introducing a generic
version check.
2009-04-03 Michael Natterer <mitch@gimp.org>
Merged from trunk:
Bug 577575 – transform tool fills underlying extracted area wrongly
* app/tools/gimpfliptool.c
* app/tools/gimpperspectivetool.c
* app/tools/gimprotatetool.c
* app/tools/gimpscaletool.c (gimp_*_tool_register): pass
GIMP_CONTEXT_BACKGROUND_MASK to the register callback to the tools
use the global background color.
svn path=/branches/gimp-2-6/; revision=28237
2009-03-28 Michael Natterer <mitch@gimp.org>
Merged from trunk:
Bug 555738 – Image display is wrong after undoing canvas size
enlargement
* app/display/gimpdisplayshell-handlers.c
(gimp_display_shell_size_changed_detailed_handler): call
gimp_display_shell_expose_full() because resizing the canvas can
leave all sorts of display areas unupdated otherwise.
svn path=/branches/gimp-2-6/; revision=28231
2009-03-28 Sven Neumann <sven@gimp.org>
Merged from trunk:
Bug 577024 – help-browser plugin crashes when used with webkit 1.1.3
* plug-ins/help-browser/help-browser.c (run): call g_thread_init().
Seems to be needed with newer versions of webkit.
svn path=/branches/gimp-2-6/; revision=28228
2009-03-28 Michael Natterer <mitch@gimp.org>
Merged from trunk:
Bug 555025 – Action GEGL box widgets weirdness
Must not set GDK_HINT_MIN_SIZE if we don't actually set a minimum
size, or the window will be shrinkable to zero and it won't
expand automatically when its contents' requisition grows.
* app/widgets/gimpdialogfactory.[ch]: add hackish API
gimp_dialog_factory_set,get_has_min_size() because GTK+ itself
has no API for querying a window's GdkWindowHints.
(gimp_dialog_factory_set_user_pos): set GDK_HINT_MIN_SIZE only if
the window was being marked as having a minimum size using above
new API.
* app/widgets/gimptoolbox.c (gimp_toolbox_set_geometry)
* app/display/gimpdisplayshell.c (gimp_display_shell_style_set):
call gimp_dialog_factory_set_has_min_size (window, TRUE).
svn path=/branches/gimp-2-6/; revision=28225
2009-03-17 Tor Lillqvist <tml@iki.fi>
* libgimpconfig/gimpconfigwriter.c
(gimp_config_writer_close_file): Drop Windows code to remove
target file before renaming. g_rename() nowadays takes of allowing
replacing existing files on Windows.
svn path=/branches/gimp-2-6/; revision=28169
2009-03-16 Tor Lillqvist <tml@iki.fi>
* app/version.c (gimp_show_library_version): The build-time and
run-time versions were swapped in the output.
svn path=/branches/gimp-2-6/; revision=28159
2009-03-12 Sven Neumann <sven@gimp.org>
Merged from trunk:
Bug 575154 – changing the help browser preference may not work
* app/gui/gui.c (gui_restore_callback): connect to changes of
the
"user-manual-online" gimprc property and kill the gimp-help
plug-in as it caches the location of the help pages.
* app/widgets/gimphelp.[ch]: added
gimp_help_user_manual_changed()
for this purpose.
svn path=/branches/gimp-2-6/; revision=28147
2009-03-12 Sven Neumann <sven@gimp.org>
Merged from trunk:
Bug 573695 – 1-bit white background saved as PBM becomes all
black
* plug-ins/common/file-pnm.c: look at the colormap and test
which
of the two colors is black and which is white.
svn path=/branches/gimp-2-6/; revision=28145
2009-03-12 Sven Neumann <sven@gimp.org>
Merged from trunk:
Bug 573070 – crash when working with 1x3200 pixel image
* app/display/gimpdisplayshell.c
(gimp_display_shell_scale_changed):
make sure that x_src_dec and y_src_dec never become zero.
svn path=/branches/gimp-2-6/; revision=28143
2009-03-12 Sven Neumann <sven@gimp.org>
Bug 573542 – blur plugin: bug in the first line
* plug-ins/common/blur.c (blur_prepare_row): cast GimpPixelRgn.h
to a signed integer.
svn path=/branches/gimp-2-6/; revision=28141
2009-03-10 Sven Neumann <sven@gimp.org>
Bug 572403 – gimp-2.6 crashed with SIGSEGV in IA__g_object_get()
* configure.in: fixed check for newer version of GTK+ that
determines if GTK_DISABLE_DEPRECATED is used.
svn path=/branches/gimp-2-6/; revision=28133
2009-03-07 Sven Neumann <sven@gimp.org>
Merged from trunk:
* plug-ins/file-jpeg/jpeg-load.c (load_image)
* plug-ins/file-jpeg/jpeg-save.c (save_image): need to finish
the
progress update.
svn path=/branches/gimp-2-6/; revision=28119
2009-03-05 Sven Neumann <sven@gimp.org>
Merged from trunk:
Bug 573695 – 1-bit white background saved as PBM becomes all
black
* plug-ins/common/file-pnm.c: need to handle the special case
that
the image colormap has only one entry.
svn path=/branches/gimp-2-6/; revision=28105
2009-03-04 Sven Neumann <sven@gimp.org>
Merged from trunk:
Bug 574149 – Can't get name/filename of files loaded from URI
* tools/pdbgen/pdb/image.pdb (image_get_name_invoker): use
gimp_image_get_display_name().
* app/pdb/image-cmds.c
* libgimp/gimpimage_pdb.c: regenerated.
svn path=/branches/gimp-2-6/; revision=28100
2009-02-28 Sven Neumann <sven@gimp.org>
Merged from trunk:
Bug 573488 – Small bug in Filter>Distorts>Ripple
* plug-ins/common/ripple.c (ripple_vertical): fixed bug spotted
in
SMEAR mode, pointed out by Andreas Groth.
svn path=/branches/gimp-2-6/; revision=28081
2009-02-22 Sven Neumann <sven@gimp.org>
* app/actions/image-actions.c: reverted last change. No changes
in
the stable branch without commit approval. And definitely no
string changes.
svn path=/branches/gimp-2-6/; revision=28061
2009-02-20 Michael Natterer <mitch@gimp.org>
Merged from trunk:
Bug 572156 – top left pixel position/coordinate is not 0,0 but 1,1
* app/display/gimpstatusbar.c
(gimp_statusbar_push_coords)
(gimp_statusbar_update_cursor): fix braino for
GIMP_CURSOR_PRECISION_PIXEL_CENTER: going to the pixel's
center doesn't need any rounding, it simply needs clipping
away the coordinates' fractional parts, gah...
Review all tools' cursor precision:
* app/tools/gimpblendtool.c (gimp_blend_tool_init): set cursor
precision to SUBPIXEL.
* app/tools/gimptexttool.c (gimp_text_tool_init)
* app/tools/gimpmeasuretool.c (gimp_measure_tool_init)
* app/tools/gimpeditselectiontool.c (gimp_edit_selection_tool_init):
set cursor precision to PIXEL_BORDER.
svn path=/branches/gimp-2-6/; revision=28054
2009-02-18 Sven Neumann <sven@gimp.org>
Merged from trunk:
Bug 472644 – Rotate with clipping crops the whole layer
* app/core/gimp-transform-resize.c: applied patch as attached to
bug #472644. Supposedly fixes the problem of the disappearing
image.
svn path=/branches/gimp-2-6/; revision=28048
2009-02-13 Sven Neumann <sven@gimp.org>
Merged from trunk:
Bug 571628 – Scaling image to 25% turn background from white to
grey
* app/paint-funcs/scale-region.c (pixel_average2): fixed
right-shift
for GRAYA pixels.
svn path=/branches/gimp-2-6/; revision=28024
2009-02-12 Michael Natterer <mitch@gimp.org>
Merged from trunk:
* plug-ins/file-faxg3/Makefile.am
* plug-ins/help/Makefile.am
* plug-ins/metadata/Makefile.am: add $(libgimpconfig) to LDADD
where it was missing. Libgimp pulls in libgimpconfig and these
plug-ins were linking against the installed libgimpconfig under
some #$&%*#%&%$& .la file circumstances.
svn path=/branches/gimp-2-6/; revision=28019
2009-02-12 Michael Natterer <mitch@gimp.org>
Merged from trunk:
Bug 567840 – GIMP's GtkScaleButton conflicts with GTK's
* app/widgets/gtkscalebutton.c: rename the type to
"GimpGtkScaleButton" so we don't crash if the real
GtkScaleButton type is registered too.
svn path=/branches/gimp-2-6/; revision=28018
2009-01-29 Sven Neumann <sven@gimp.org>
Merged from trunk:
* app/core/gimpchannel-combine.c
(gimp_channel_combine_ellipse_rect):
fixed incorrect optimization that caused glitches in the rounded
corners on the left side of rectangular selections.
svn path=/branches/gimp-2-6/; revision=27969
2009-01-28 Sven Neumann <sven@gimp.org>
* app/tools/gimpgegltool.c (gimp_param_spec_duplicate): if
compiling for GEGL >= 0.0.23, use double parameters with
gegl_color_get_rgba().
svn path=/branches/gimp-2-6/; revision=27966
2009-01-26 Michael Natterer <mitch@gimp.org>
Merged from trunk:
* libgimpwidgets/gimpbutton.c (gimp_button_clicked): chain up if a
parent impl exists to be safe against future gtk versions doing
something in GtkButton::clicked() (as happened in GTK+ trunk).
svn path=/branches/gimp-2-6/; revision=27959
2009-01-25 Sven Neumann <sven@gimp.org>
Merged from trunk:
* app/tools/gimpgegltool.c (gimp_gegl_tool_get_config):
(gimp_gegl_tool_get_config): canonicalize the type name of the
created config class.
svn path=/branches/gimp-2-6/; revision=27941
2009-01-24 Michael Natterer <mitch@gimp.org>
Merged from trunk:
Bug 568890 – don't rely on GtkAction implementation details
* app/widgets/gimpuimanager.c (gimp_ui_manager_menu_item_select):
use gtk_widget_get_action() instead of g_object_get_data(),
which relies on the name of the data key.
svn path=/branches/gimp-2-6/; revision=27940
2009-01-23 Kevin Cozens <kcozens@cvs.gimp.org>
Merged from trunk:
* libgimpcolor/gimprgb-parse.c: Applied patch from Andreas Turtschan
to fix more RGB colour values. Fixes bug #568909.
svn path=/branches/gimp-2-6/; revision=27938
2009-01-23 Kevin Cozens <kcozens@cvs.gimp.org>
Merged from trunk:
* libgimpcolor/gimprgb-parse.c: Applied patch from Andreas Turtschan
to fix colour values for slategray and slategray. Fixes bug #568839.
svn path=/branches/gimp-2-6/; revision=27934
2009-01-22 Tor Lillqvist <tml@iki.fi>
Bug 559408 - Brushes dragged to the image window look strange
* app/widgets/gimppixbuf.c (gimp_pixbuf_format_compare): Drop
Windows-specific code to prefer BMP. The BMP format written by
gdk-pixbuf doesn't support alpha. PNG is better. Note that the
same bug report also takes up a different problem.
svn path=/branches/gimp-2-6/; revision=27927
Bug 563337 – Rectangle Select Tool does not allow 1:1 fixed ratio
* libgimpwidgets/gimpnumberpairentry.c: When testing if the value
changed on focus-out we shall test against the current values, not
the default values.
svn path=/branches/gimp-2-6/; revision=27915
2009-01-17 Sven Neumann <sven@gimp.org>
Merged from trunk:
Bug 568016 – Black pullout parameter of plug-in-newsprint has
no effect
* plug-ins/common/newsprint.c: fixed the documentation of the
colorspace parameter.
svn path=/branches/gimp-2-6/; revision=27909
2009-01-13 Sven Neumann <sven@gimp.org>
* INSTALL
* autogen.sh
* configure.in: looks like we need intltool >= 0.36.3 (and we
recommend using an even newer version).
svn path=/branches/gimp-2-6/; revision=27901
Bug 562818 – First image opened in GIMP offset
* app/display/gimpdisplayshell.c (gimp_display_shell_shrink_wrap):
Only rely on disp_width/height for border calculation if they are
larger than 1. If not, special-case the calculation so we don't
get a severly mispositioned image.
svn path=/branches/gimp-2-6/; revision=27893
Bug 562213 – Align Tool doesn't work properly if it is the active
tool at startup
* app/tools/gimpaligntool.c: Perform NULL-pointer dodging to avoid
crashing.
svn path=/branches/gimp-2-6/; revision=27890
2009-01-01 Sven Neumann <sven@gimp.org>
Merged from trunk:
Bug 565223 – Perspective transformation jagged edges / comb effect
* app/core/gimp-transform-region.c: reverted the code change, but
not the cleanups, from commit r26786.
svn path=/branches/gimp-2-6/; revision=27867
2008-12-28 Sven Neumann <sven@gimp.org>
* app/tools/gimpgegltool.c (gimp_param_spec_duplicate): fixed
handling of GEGL minor version number in compile-time check.
svn path=/branches/gimp-2-6/; revision=27847
2008-12-28 Sven Neumann <sven@gimp.org>
* app/tools/gimpgegltool.c (gimp_param_spec_duplicate): fixed
typo
in GEGL version number check.
svn path=/branches/gimp-2-6/; revision=27845
2008-12-28 Sven Neumann <sven@gimp.org>
Merged from trunk:
Bug 563985 – jpg save dialog: "cancel" is treated like "commit"
for settings
* plug-ins/file-jpeg/jpeg.c (run): only attach the comment and
settings to the image if the save was successful.
svn path=/branches/gimp-2-6/; revision=27844
2008-12-27 Sven Neumann <sven@gimp.org>
Merged from trunk:
Bug 564087 – Using clone tool on a layer with a part out of
canvas
causes crashes
* app/paint/gimppaintcore.c (gimp_paint_core_paste): intersect
the
rectangle with the extents of the saved projection.
svn path=/branches/gimp-2-6/; revision=27836
2008-12-27 Sven Neumann <sven@gimp.org>
Merged from trunk:
Bug 564593 – crash when the drawable is changed while a color
tools is active
* app/core/gimpdrawable-shadow.c
(gimp_drawable_merge_shadow_tiles):
keep a reference to the shadow tiles because it might otherwise
be
free'd under our feet.
svn path=/branches/gimp-2-6/; revision=27833
2008-12-21 Sven Neumann <sven@gimp.org>
Merged from trunk:
Bug 564869 – GIMP crashes on selecting Tools->GEGL operation
* app/tools/gimptool.c (gimp_tool_initialize): check if the tool
has set an error.
svn path=/branches/gimp-2-6/; revision=27820
2008-12-21 Sven Neumann <sven@gimp.org>
Merged from trunk:
Bug 565138 – python-fu-foggify does not check if image is in rgb
mode
* plug-ins/pygimp/plug-ins/foggify.py (foggify): fixed handling
of
grayscale images.
svn path=/branches/gimp-2-6/; revision=27818
2008-12-17 Sven Neumann <sven@gimp.org>
Merged from trunk:
* plug-ins/common/file-png.c (load_image) (save_image): use a
tile
cache to optimize pixel access.
svn path=/branches/gimp-2-6/; revision=27806
2008-12-04 Sven Neumann <sven@gimp.org>
Merged from trunk:
Bug 563130 – Hue selection mode does not cross the 0-360 degrees
line
* app/core/gimpimage-contiguous-region.c (pixel_difference):
applied patch from Daniel Hornung.
svn path=/branches/gimp-2-6/; revision=27765
Bug 563179 – Scrollbars not resized when we extend the canvas size
* app/display/gimpdisplayshell-handlers.c
(gimp_display_shell_size_changed_detailed_handler): Add explicit
call to gimp_display_shell_scroll_clamp_and_update() at the end to
make sure it is called.
svn path=/branches/gimp-2-6/; revision=27763
2008-12-04 Sven Neumann <sven@gimp.org>
Merged from trunk:
* tools/pdbgen/pdb/convert.pdb: fixed an error in the
documentation
of the gimp-image-convert-rgb procedure.
* app/pdb/convert-cmds.c
* libgimp/gimpconvert_pdb.c: regenerated.
svn path=/branches/gimp-2-6/; revision=27759
2008-12-03 Sven Neumann <sven@gimp.org>
* app/core/gimpimagemap.c (gimp_image_map_apply): when compiling
against GEGL from trunk, use "gegl:translate" instead of
"shift".
svn path=/branches/gimp-2-6/; revision=27748
2008-11-27 Sven Neumann <sven@gimp.org>
Merged from trunk:
Bug 562459 – PF_PALETTE: 'TypeError' when used in a plugin that
is
registered in <Image>
* plug-ins/pygimp/gimpui.defs (gimp_palette_select_button_new):
the 'title' parameter is optional.
svn path=/branches/gimp-2-6/; revision=27736
2008-11-27 Sven Neumann <sven@gimp.org>
Merged from trunk:
Bug 562386 – PF_SLIDER and PF_SPINNER 'Step' values do not
change
consistently...
* plug-ins/pygimp/gimpfu.py (SliderEntry): set the precision on
the slider just as we do it for the spin-button.
svn path=/branches/gimp-2-6/; revision=27731
2008-11-27 Sven Neumann <sven@gimp.org>
Merged from trunk:
* plug-ins/pygimp/gimpfu.py (SpinnerEntry): let SpinnerEntry
return a float instead of trying to convert the value to an int.
svn path=/branches/gimp-2-6/; revision=27729
2008-11-27 Sven Neumann <sven@gimp.org>
Merged from trunk:
Bug 562386 – PF_SLIDER and PF_SPINNER 'Step' values do not
change
consistently...
* plug-ins/pygimp/gimpfu.py (SpinnerEntry): initialize the
spin-button the way that gtk_spin_button_new_with_range() is
implemented.
svn path=/branches/gimp-2-6/; revision=27727
Bug 562366 – Default image dimensions are not correctly
transferred in the file/new dialog box
* app/dialogs/preferences-dialog.c
(prefs_template_select_callback): We need to copy the template in
the same way as in the New Image dialog.
* app/dialogs/image-new-dialog.c (image_new_dialog_set): ... and
when we copy the template to the New Image dialog.
svn path=/branches/gimp-2-6/; revision=27725
Bug 562366 – Default image dimensions are not correctly
transferred in the file/new dialog box
* app/dialogs/preferences-dialog.c
(prefs_template_select_callback): We need to copy the template in
the same way as in the New Image dialog.
svn path=/branches/gimp-2-6/; revision=27721
2008-11-22 Sven Neumann <sven@gimp.org>
Merged from trunk:
Bug 561899 – GIMP can't save to mounted filesystem if file
exists
* plug-ins/file-uri/uri-backend-gvfs.c (copy_uri): pass the
G_FILE_COPY_OVERWRITE flag to g_file_copy().
svn path=/branches/gimp-2-6/; revision=27710
2008-11-19 Sven Neumann <sven@gimp.org>
Merged from trunk:
Bug 558454 – Plugin Map Color Range disapears from GIMP
* plug-ins/script-fu/scripts/Makefile.am
* plug-ins/script-fu/scripts/plug-in-compat.init: new file
providing compatibility with plug-ins from older GIMP
versions. Contains a reimplementation of plug-in-color-map based
on ideas and code from Eric Lamarque.
* plug-ins/script-fu/scheme-wrapper.c (tinyscheme_init): load
the
plug-in-compat.init file.
svn path=/branches/gimp-2-6/; revision=27684
Bug 559239 – Error while loading psd-data
* plug-ins/file-psd/psd-layer-res-load.c (load_layer_resource):
Layer resource data should not be padded.
svn path=/branches/gimp-2-6/; revision=27681
2008-11-15 Sven Neumann <sven@gimp.org>
Merged from trunk:
* app/display/gimpdisplayshell-scroll.[ch]: removed function
gimp_display_shell_scroll_get_scaled_viewport_offset() as it was
only returning -shell->offset_x and -shell->offset_y and it
started to show up in profiles.
* app/display/gimpdisplayshell-draw.c
* app/display/gimpdisplayshell-transform.c
* app/display/gimpdisplayshell-scale.c: use the shell offsets
directly.
svn path=/branches/gimp-2-6/; revision=27664
Bug 560903 – Explicit zooming with e.g. '1' should handle
zoom-focus better
* app/display/display-enums.h: Added
GIMP_ZOOM_FOCUS_RETAIN_CENTERING_ELSE_BEST_GUESS.
* app/display/gimpdisplayshell-scale.c
(gimp_display_shell_scale_get_zoom_focus): Take the new enum into
account; if the image is centered, keep it centered, else use the
best-guess method.
* app/actions/view-commands.c (view_zoom_explicit_cmd_callback):
Use the new enum for explicit zooming.
svn path=/branches/gimp-2-6/; revision=27654
Bug 560245 – Zoom selection always centered in the Navigation tab
* app/display/gimpdisplayshell-scale.c (gimp_display_shell_scale):
Also take the image center and not only the zoom focus point into
account when deciding whether or not to center the image after
zoom.
svn path=/branches/gimp-2-6/; revision=27652
2008-11-14 Sven Neumann <sven@gimp.org>
Merged from trunk:
* app/display/gimpdisplayshell-preview.c
(gimp_display_shell_draw_quad): check that the resulting area
has
positive width and height.
svn path=/branches/gimp-2-6/; revision=27643
2008-11-13 Sven Neumann <sven@gimp.org>
Merged from trunk:
Bug 559292 – SOTA Chrome cannot accept different textures
* app/pdb/gimppdb-utils.c (gimp_pdb_image_is_base_type)
(gimp_pdb_image_is_not_base_type): gimp_object_get_name() may
return NULL for images. Use gimp_image_get_uri() instead.
svn path=/branches/gimp-2-6/; revision=27636
2008-11-11 Sven Neumann <sven@gimp.org>
Merged from trunk:
Bug 560375 – Clearing an already empty document history crashes
GIMP
* app/actions/documents-commands.c
(documents_clear_cmd_callback):
gtk_recent_manager_purge_items() may return 0 but not set an
error.
svn path=/branches/gimp-2-6/; revision=27621
2008-11-11 Michael Natterer <mitch@gimp.org>
Merged from trunk:
Bug 559580 – Image windows need better default locations
* app/display/gimpdisplayshell.c (gimp_display_shell_style_set):
Only set GDK_HINT_USER_POS on the empty display because it gets a
position set by gimp. All other displays should be placed by the
window manager. Fixes all displays appearing at 0,0.
svn path=/branches/gimp-2-6/; revision=27616
2008-11-11 Sven Neumann <sven@gimp.org>
Merged from trunk:
* plug-ins/common/file-pdf.c: fixed size of the GimpParam array
used for the return values.
svn path=/branches/gimp-2-6/; revision=27611
Bug 559716 – Changing crop size in Crop Tool Options can make UI
unresponsive
* app/tools/gimprectangletool.c: Accept a broader range of x, y,
width and height values from the tool options so we don't end up
in an infinite signal emission loop.
svn path=/branches/gimp-2-6/; revision=27606
2008-11-10 Michael Natterer <mitch@gimp.org>
Merged from trunk:
* app/core/gimpdrawable-curves.c (gimp_drawable_curves_explicit):
use GIMP_CURVE_FREE, not _SMOOTH. Fixes the resp. PDB call.
svn path=/branches/gimp-2-6/; revision=27602
2008-11-10 Sven Neumann <sven@gimp.org>
* POTFILES.in: added file with a new string that was needed to
fix
a crash.
svn path=/branches/gimp-2-6/; revision=27594
Bug 558549 – Stroking a single-point path with a paint tool
crashes GIMP
* app/paint/gimppaintcore-stroke.c
(gimp_paint_core_stroke_vectors): Return an error message if there
were not enough points to stroke.
* app/dialogs/stroke-dialog.c (stroke_dialog_response): Guard
against crashes if an implementator forgets to set an error.
svn path=/branches/gimp-2-6/; revision=27590
* app/display/gimpdisplayshell-scale.c
(gimp_display_shell_scale_update_rulers): Avoid critical warnings
when converting an image window with a unit other than pixels into
a the empty image window. Probably fixes some of the crashes
reported by Windows users.
svn path=/branches/gimp-2-6/; revision=27587
2008-11-04 Sven Neumann <sven@gimp.org>
Merged from trunk:
* app/display/gimpdisplayshell-dnd.c
(gimp_display_shell_drop_uri_list): when dropping multiple
images
to the empty image window, open them as seperate images.
svn path=/branches/gimp-2-6/; revision=27555
2008-11-03 Michael Natterer <mitch@gimp.org>
Merged from trunk:
Bug 559015 – Move tool gives bad information about px moved
* app/tools/gimpeditselectiontool.c (gimp_edit_selection_tool_init):
set cursor precision to PIXEL_BORDER because that's what the move
tool snaps to.
Unrelated: set CENTER_CROSS_SIZE to an odd number so it's drawn
symmetrically.
svn path=/branches/gimp-2-6/; revision=27534
2008-10-31 Sven Neumann <sven@gimp.org>
Bug 558660 – help behavior for locales without manual
translation
* app/widgets/gimphelp.c (gimp_help_user_manual_is_installed):
as a fallback check for the english user manual.
svn path=/branches/gimp-2-6/; revision=27501
2008-10-30 Sven Neumann <sven@gimp.org>
Backed out this change for now as it causes problem with some
window managers:
Bug 556896 – Dialogs don't get minimized with single image
window
* app/display/gimpdisplayshell.c
* app/display/gimpdisplay-foreach.[ch]
* app/widgets/gimpdialogfactory.[ch]: merged changes from trunk.
Hide the toolbox and docks if the last display is iconified.
Unhide them if a display is uniconified.
svn path=/branches/gimp-2-6/; revision=27475
2008-10-29 Sven Neumann <sven@gimp.org>
Merged from trunk:
Bug 557950 – Scaling in Gimp 2.6 is much slower than in Gimp 2.4
* app/paint-funcs/scale-region.c: don't do multi-pass scaling
when we are scaling up.
svn path=/branches/gimp-2-6/; revision=27473
Bug 558215 – unit and zoom entries in Statusbar not visible
* app/display/gimpdisplayshell-callbacks.c
(gimp_display_shell_canvas_size_allocate): Don't try to be clever,
call gimp_display_shell_scaled() whenever the canvas size changes
so a newly created display shell gets updated properly.
svn path=/branches/gimp-2-6/; revision=27471
2008-10-29 Sven Neumann <sven@gimp.org>
Merged from trunk:
Bug 558451 – Cannot build GIMP using Sun CC on Solaris 2.8
* app/pdb/gimp-pdb-compat.c
* app/gegl/gimpoperationtilesink.c
* app/gegl/gimpoperationtilesource.c
* app/tools/gimpgegltool.c: applied patches from Eric Lamarque
fixing the build using Sun CC on Solaris.
svn path=/branches/gimp-2-6/; revision=27468
2008-10-29 Sven Neumann <sven@gimp.org>
Merged from trunk:
Bug 558420 – projection incorrect with alpha-less layers
* app/core/gimpprojection-construct.c
(gimp_projection_initialize):
need to initialize the projection if the covering layer is not
opaque.
svn path=/branches/gimp-2-6/; revision=27461
Bug 556603 – Zoom region always zooms in center of image
* app/tools/gimpmagnifytool.c (gimp_magnify_tool_button_release):
When zooming with a click, use gimp_display_shell_scale() instead
of local zoom logic.
svn path=/branches/gimp-2-6/; revision=27454
2008-10-25 Michael Natterer <mitch@gimp.org>
Merged from trunk:
Bug 557870 – "Qmask" message popping up here and there
* app/display/gimpdisplayshell-title.c
(gimp_display_shell_format_title): use
gimp_viewable_get_description() instead of gimp_object_get_name()
for displaying the active drawable's name so the quick mask and
the floating selection have the same names as in the
layers/channels dialogs.
svn path=/branches/gimp-2-6/; revision=27406
2008-10-24 Sven Neumann <sven@gimp.org>
Bug 557705 – compatibility with GEGL > 0.0.20
* app/core/gimpdrawable-brightness-contrast.c
* app/core/gimpdrawable-invert.c
* app/tools/gimpbrightnesscontrasttool.c: choose GEGL operation
names based on the GEGL version we are being used with.
svn path=/branches/gimp-2-6/; revision=27391
2008-10-24 Sven Neumann <sven@gimp.org>
* app/gegl/gimp-gegl-utils.[ch]: added
gimp_gegl_check_version(),
a run-time GEGL version check.
* app/core/gimpimagemap.c (gimp_image_map_apply): use the new
function to determine the names of the GEGL ops to use.
svn path=/branches/gimp-2-6/; revision=27389
2008-10-24 Sven Neumann <sven@gimp.org>
Bug 556896 – Dialogs don't get minimized with single image
window
* app/display/gimpdisplayshell.c
* app/display/gimpdisplay-foreach.[ch]
* app/widgets/gimpdialogfactory.[ch]: merged changes from trunk.
Hide the toolbox and docks if the last display is iconified.
Unhide them if a display is uniconified.
svn path=/branches/gimp-2-6/; revision=27386
2008-10-23 Michael Natterer <mitch@gimp.org>
Merged from trunk:
* app/plug-in/gimppluginprocframe.c
(gimp_plug_in_proc_frame_dispose): set proc_frame->procedure to
NULL *after* calling gimp_plug_in_cleanup(). Fixes the crash on
windows in bug #557061 (but not the bug).
svn path=/branches/gimp-2-6/; revision=27377
2008-10-23 Sven Neumann <sven@gimp.org>
Merged from trunk:
* configure.in: removed check for Carbon and added a test for
the
target OS being Darwin instead.
* app/config/gimpguiconfig.c: use PLATFORM_OSX instead of
HAVE_CARBON to determine the default "web-browser" command.
svn path=/branches/gimp-2-6/; revision=27371
2008-10-22 Sven Neumann <sven@gimp.org>
Merged from trunk:
* plug-ins/print/print-preview.c
(print_preview_leave_notify_event):
check the crossing mode and don't unset the "inside" flag when
the
event is caused by a pointer grab/ungrab.
svn path=/branches/gimp-2-6/; revision=27369
* app/display/gimpdisplayshell-scale.c
* app/display/gimpdisplayshell-callbacks.c: Fix calls to
gimp_display_shell_scaled() when Resize window on zoom is enabled.
svn path=/branches/gimp-2-6/; revision=27367
2008-10-22 Sven Neumann <sven@gimp.org>
Merged from trunk:
Bug 524615 – Print not to scale
* plug-ins/print/print.c: set the unit for dimensions on the
Cairo
context used for printing to GTK_UNIT_PIXELS.
* plug-ins/print/print-draw-page.c (print_draw_page): changed
the
Cairo scale factors accordingly. Seems to fix printing on
Windows.
svn path=/branches/gimp-2-6/; revision=27365
2008-10-22 Sven Neumann <sven@gimp.org>
Merged from trunk:
* app/widgets/gimpprogressbox.c: set box->progress to NULL in
destroy() and check for progress being NULL in various places so
we don't crash on API calls after the widget is destroyed.
svn path=/branches/gimp-2-6/; revision=27363
2008-10-22 Sven Neumann <sven@gimp.org>
Merged from trunk:
Bug 555246 – gimp crashes when a file is opened while a preview
is
generating
* app/widgets/gimpthumbbox.c: set box->progress to NULL in
destroy() and check for progress being NULL in various places so
we don't crash on API calls after the widget is destroyed.
svn path=/branches/gimp-2-6/; revision=27361
2008-10-22 Sven Neumann <sven@gimp.org>
Merged from trunk:
Bug 556741 – Alpha layer automatically added (in psd format) but
not desired
* plug-ins/file-psd/psd-save.c: applied patch from Dennis Ranke
that flattens the projection for indexed images.
svn path=/branches/gimp-2-6/; revision=27359
2008-10-22 Sven Neumann <sven@gimp.org>
Merged from trunk:
Bug 555246 – gimp crashes when a file is opened while a preview
is
generating
* app/widgets/gimpfiledialog.c: set dialog->progress to NULL in
destroy() and check for progress being NULL in various places so
we don't crash on API calls after the widget is destroyed.
svn path=/branches/gimp-2-6/; revision=27355
2008-10-21 Sven Neumann <sven@gimp.org>
Merged from trunk:
* app/tools/gimpgegltool.c (gimp_param_spec_duplicate):
GEGL_IS_PARAM_SPEC_PATH() became GEGL_IS_PARAM_SPEC_FILE_PATH()
in GEGL 0.0.21.
* app/tools/gimpgegltool.c (gimp_gegl_tool_dialog): for the
combo-box, strip known prefixes from the GEGL operation names
and
use icons instead.
svn path=/branches/gimp-2-6/; revision=27352
2008-10-21 Sven Neumann <sven@sven>
* app/tools/gimpgegltool.c
(gimp_gegl_tool_operation_blacklisted):
make the operations blacklist work with GEGL >= 0.0.21.
svn path=/branches/gimp-2-6/; revision=27348
2008-10-21 Sven Neumann <sven@gimp.org>
Merged from trunk:
* app/actions/file-commands.c (file_open_recent_cmd_callback):
ref
the GimpDisplay and GimpImageFile objects while holding a
reference to them. Fixes a potential crash if GIMP is closed
while
the image is being loaded.
svn path=/branches/gimp-2-6/; revision=27347
2008-10-20 Sven Neumann <sven@gimp.org>
Merged from trunk:
* app/widgets/gimperrorconsole.c (gimp_error_console_init):
don't
make the font size even smaller. We already use a smaller font
in
the dock windows.
svn path=/branches/gimp-2-6/; revision=27342
2008-10-17 Sven Neumann <sven@gimp.org>
Merged from trunk:
* plug-ins/file-psd/psd-save.c (xfwrite): fixed handling of
empty
strings. Don't quit silently, write an error message to stderr
at
least.
svn path=/branches/gimp-2-6/; revision=27303
2008-10-17 Sven Neumann <sven@sven>
Merged from trunk:
* app/core/gimp.[ch]: added signal Gimp::image-opened to
announce
that an image has been loaded and a display was created for it.
* app/file/file-open.c (file_open_with_proc_and_display): call
gimp_opened() to emit the new signal.
* app/gui/dbus-service.xml
* app/gui/gimpdbusservice.[ch]: propagate the 'opened' signal to
listeners of the "org.gimp.GIMP.UI" DBus service.
* app/gui/gui-unique.c: formatting.
svn path=/branches/gimp-2-6/; revision=27298
2008-10-14 Sven Neumann <sven@gimp.org>
Merged from trunk:
* themes/Default/images/stock-gegl.svg
* themes/Default/images/stock-gegl-22.svg
* themes/Default/images/stock-gegl-22.png: remove white from the
shadow to render correctly on dark backgrounds.
svn path=/branches/gimp-2-6/; revision=27289
2008-10-14 Sven Neumann <sven@gimp.org>
Merged from trunk:
* app/widgets/gimpdialogfactory.c
(gimp_dialog_factory_add_dialog):
let new docks appear at the pointer position.
svn path=/branches/gimp-2-6/; revision=27283
2008-10-13 Sven Neumann <sven@gimp.org>
Merged from trunk:
Bug 556182 – Could you please explain a few strings [I18N]
* plug-ins/pygimp/plug-ins/py-slice.py: added translator
comments.
svn path=/branches/gimp-2-6/; revision=27273
2008-10-10 Michael Natterer <mitch@gimp.org>
Merged from trunk:
* app/tools/gimpmovetool.c (gimp_move_tool_button_release): flush
the image after setting active items back from temporarily
selected ones. Fixes menu item sensitivity.
svn path=/branches/gimp-2-6/; revision=27210
2008-10-09 Sven Neumann <sven@gimp.org>
Merged from trunk:
Bug 555697 – build fails if configured with --without-libjpeg
* plug-ins/Makefile.am: applied patch from Simon Zilliken that
disables the build of the PSD plug-in if JPEG support is
disabled.
svn path=/branches/gimp-2-6/; revision=27197
2008-10-09 Michael Natterer <mitch@gimp.org>
Merged from trunk:
This is not exactly a bugfix-only commit, but fixing this bug
was the original reason for all the curve and image map tool
refactorings that went into 2.6. It would be silly not to
fix it just because I simply forgot to hack the final step of
enabling all the new code. The two new translatable strings are
a PITA, sorry about that; but better than still only exporting
the old curves and levels formats in 2.6.
Bug 134956 – Curves tool doesn't save free curves
* app/core/gimpmarshal.list
* app/widgets/gimpsettingsbox.[ch]: add signal "file-dialog-setup"
and emit it when the export/import file chooser is fully
constructed. Callbacks can then do additional things to the
dialog, like adding custom buttons.
* app/tools/gimpcurvestool.h
* app/tools/gimplevelstool.h: add boolean member
"export_old_format".
* app/tools/gimpcurvestool.c
* app/tools/gimplevelstool.c (gimp_*_tool_dialog): connect to
the settings box' "file-dialog-setup".
(gimp_*_tool_export_setup): new callback which adds a toggle to
the file choosers that allows to export to the old format.
Default saving the new format, we defaulted to the old one before.
(gimp_*_tool_settings_export): check the "export_old_format"
boolean and only save the cruft format if it is TRUE; chain up
otherwise, which generically saves the new format.
* app/tools/gimplevelstool.c (gimp_levels_tool_settings_import):
add the same file format detection code as in the curves tool
so it transparently loads old and new levels files.
svn path=/branches/gimp-2-6/; revision=27195
2008-10-09 Michael Natterer <mitch@gimp.org>
Merged from trunk:
* app/gegl/gimpcurvesconfig.c (gimp_curves_config_save_cruft):
when saving a curve of type GIMP_CURVE_FREE, don't use
gimp_curve_get_point() because that returns nothing for free
curves.
(gimp_curves_config_load_cruft): reset the curve before loading it.
* app/core/gimpcurve.c (gimp_curve_get_point): instead of above
mentioned uninitialized nonsense, at least return -1,-1 for free
curves.
svn path=/branches/gimp-2-6/; revision=27191
Some files were not shown because too many files have changed in this diff
Show More
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
